Re: Review Request 17592: QPID-5531 [C++ broker] Set timeout for every DTX transaction

2014-02-05 Thread Pavel Moravec
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17592/ --- (Updated Feb. 5, 2014, 8:36 a.m.) Review request for qpid, Chug Rolke, Cliff

Re: Review Request 17592: QPID-5531 [C++ broker] Set timeout for every DTX transaction

2014-02-05 Thread Gordon Sim
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17592/#review33686 --- Ship it! I think 60 seconds may be a bot short for the default

Re: Review Request 17592: QPID-5531 [C++ broker] Set timeout for every DTX transaction

2014-02-04 Thread Pavel Moravec
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17592/ --- (Updated Feb. 4, 2014, 2:15 p.m.) Review request for qpid, Chug Rolke, Cliff

Re: Review Request 17592: QPID-5531 [C++ broker] Set timeout for every DTX transaction

2014-02-04 Thread Gordon Sim
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17592/#review33613 --- /trunk/qpid/cpp/src/qpid/broker/DtxManager.h

Re: Review Request 17592: QPID-5531 [C++ broker] Set timeout for every DTX transaction

2014-02-04 Thread Chug Rolke
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17592/#review33617 --- /trunk/qpid/cpp/src/qpid/broker/Broker.cpp

Re: Review Request 17592: QPID-5531 [C++ broker] Set timeout for every DTX transaction

2014-02-03 Thread Cliff Jansen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17592/#review33415 --- This builds fine on Windows. By inspection the code changes look

Re: Review Request 17592: QPID-5531 [C++ broker] Set timeout for every DTX transaction

2014-02-03 Thread Gordon Sim
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17592/#review33416 --- Ship it! /trunk/qpid/cpp/src/qpid/broker/DtxManager.h

Re: Review Request 17592: QPID-5531 [C++ broker] Set timeout for every DTX transaction

2014-02-03 Thread Steve Huston
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17592/#review33536 --- /trunk/qpid/cpp/src/qpid/broker/DtxManager.h

Re: Review Request 17592: QPID-5531 [C++ broker] Set timeout for every DTX transaction

2014-02-01 Thread Pavel Moravec
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17592/ --- (Updated Feb. 1, 2014, 11:30 a.m.) Review request for qpid, Chug Rolke, Cliff

Re: Review Request 17592: QPID-5531 [C++ broker] Set timeout for every DTX transaction

2014-02-01 Thread Pavel Moravec
On Jan. 31, 2014, 4:36 p.m., Gordon Sim wrote: /trunk/qpid/cpp/src/qpid/broker/DtxManager.h, line 54 https://reviews.apache.org/r/17592/diff/1/?file=457723#file457723line54 Rather than passing the default timeout through on each call, why not pass it in to the constructor of

Re: Review Request 17592: QPID-5531 [C++ broker] Set timeout for every DTX transaction

2014-02-01 Thread Pavel Moravec
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17592/ --- (Updated Feb. 1, 2014, 2:47 p.m.) Review request for qpid, Chug Rolke, Cliff

Review Request 17592: QPID-5531 [C++ broker] Set timeout for every DTX transaction

2014-01-31 Thread Pavel Moravec
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17592/ --- Review request for qpid, Chug Rolke, Cliff Jansen, Kim van der Riet, and Steve

Re: Review Request 17592: QPID-5531 [C++ broker] Set timeout for every DTX transaction

2014-01-31 Thread Gordon Sim
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17592/#review1 --- /trunk/qpid/cpp/src/qpid/broker/DtxManager.h