[jira] [Updated] (DISPATCH-1283) Router crash when link gets freed before its deliveries are freed
[ https://issues.apache.org/jira/browse/DISPATCH-1283?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ganesh Murthy updated DISPATCH-1283: Fix Version/s: (was: 1.6.0) > Router crash when link gets freed before its deliveries are freed > - > > Key: DISPATCH-1283 > URL: https://issues.apache.org/jira/browse/DISPATCH-1283 > Project: Qpid Dispatch > Issue Type: Bug > Components: Container >Affects Versions: 1.5.0 >Reporter: Ganesh Murthy >Assignee: Ganesh Murthy >Priority: Major > > {noformat} > (gdb) bt > #0 0x7ff1db20d060 in qdr_delete_delivery_internal_CT (core=0x1416180, > delivery=0x7ff1c80d2fe8) at > /home/gmurthy/opensource/qpid-dispatch/src/router_core/transfer.c:613 > #1 0x7ff1db20e9b6 in qdr_delete_delivery_CT (core=0x1416180, > action=0x7ff1bc33d828, discard=false) at > /home/gmurthy/opensource/qpid-dispatch/src/router_core/transfer.c:1221 > #2 0x7ff1db206ec0 in router_core_thread (arg=0x1416180) at > /home/gmurthy/opensource/qpid-dispatch/src/router_core/router_core_thread.c:148 > #3 0x7ff1db11858e in start_thread () from /lib64/libpthread.so.0 > #4 0x7ff1dabc06a3 in clone () from /lib64/libc.so.6 > (gdb){noformat} -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] asfgit closed pull request #473: DISPATCH-1297: Fix the outgoing buffer reference counting
asfgit closed pull request #473: DISPATCH-1297: Fix the outgoing buffer reference counting URL: https://github.com/apache/qpid-dispatch/pull/473 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1275) Enable deletion of connections based on connection id
[ https://issues.apache.org/jira/browse/DISPATCH-1275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16799384#comment-16799384 ] ASF subversion and git services commented on DISPATCH-1275: --- Commit d84d75ea48954a3064e1c776fead7e061445308e in qpid-dispatch's branch refs/heads/master from Charles E. Rolke [ https://gitbox.apache.org/repos/asf?p=qpid-dispatch.git;h=d84d75e ] DISPATCH-1275: Fix exception test to work in python2 and python3 > Enable deletion of connections based on connection id > - > > Key: DISPATCH-1275 > URL: https://issues.apache.org/jira/browse/DISPATCH-1275 > Project: Qpid Dispatch > Issue Type: Bug > Components: Container >Affects Versions: 1.5.0 >Reporter: Ganesh Murthy >Assignee: Ganesh Murthy >Priority: Major > Fix For: 1.6.0 > > > Sometimes there is a need to delete/kill certain connections on which there > are slow consumers or consumers that won't acknowledge messages. > Add functionality to the router server side code that will allow users to > delete connections based on the connection id. The connection id can be > obtained from the output of-- > {noformat} > qdstat -c{noformat} > or > {noformat} > qdmanage QUERY --type=connection{noformat} > This JIRA involves the following tasks > # Add two fields, adminStatus and operStatus to the *connection* entity in > the router schema. Possible connection adminStatues are *enabled* and > *deleted.* Possible operStatuses are *up* > # Modify the router's c-management agent to respond to a UPDATE management > request. A connection id must be provided to update a connection > (adminStatus=deleted). When a client deletes a connection object, the > connection to the peer is terminated by the router. Client will not be > allowed to terminate inter-router connections. > # Add policy control over who is permitted to write adminStatus (add a new > flag at the policy group level called allowAdminStatusUpdate) -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1283) Router crash when link gets freed before its deliveries are freed
[ https://issues.apache.org/jira/browse/DISPATCH-1283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16799338#comment-16799338 ] ASF subversion and git services commented on DISPATCH-1283: --- Commit 4b3a42067b81bea6e5ba9a3f530ae1f6c577cc5d in qpid-dispatch's branch refs/heads/master from Ted Ross [ https://gitbox.apache.org/repos/asf?p=qpid-dispatch.git;h=4b3a420 ] DISPATCH-1283 - Added protection of links from being freed while they are in IO processing > Router crash when link gets freed before its deliveries are freed > - > > Key: DISPATCH-1283 > URL: https://issues.apache.org/jira/browse/DISPATCH-1283 > Project: Qpid Dispatch > Issue Type: Bug > Components: Container >Affects Versions: 1.5.0 >Reporter: Ganesh Murthy >Assignee: Ganesh Murthy >Priority: Major > Fix For: 1.6.0 > > > {noformat} > (gdb) bt > #0 0x7ff1db20d060 in qdr_delete_delivery_internal_CT (core=0x1416180, > delivery=0x7ff1c80d2fe8) at > /home/gmurthy/opensource/qpid-dispatch/src/router_core/transfer.c:613 > #1 0x7ff1db20e9b6 in qdr_delete_delivery_CT (core=0x1416180, > action=0x7ff1bc33d828, discard=false) at > /home/gmurthy/opensource/qpid-dispatch/src/router_core/transfer.c:1221 > #2 0x7ff1db206ec0 in router_core_thread (arg=0x1416180) at > /home/gmurthy/opensource/qpid-dispatch/src/router_core/router_core_thread.c:148 > #3 0x7ff1db11858e in start_thread () from /lib64/libpthread.so.0 > #4 0x7ff1dabc06a3 in clone () from /lib64/libc.so.6 > (gdb){noformat} -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Resolved] (DISPATCH-1297) Fix buffer reference counting for multiframe fanout messages
[ https://issues.apache.org/jira/browse/DISPATCH-1297?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Ross resolved DISPATCH-1297. Resolution: Fixed > Fix buffer reference counting for multiframe fanout messages > > > Key: DISPATCH-1297 > URL: https://issues.apache.org/jira/browse/DISPATCH-1297 > Project: Qpid Dispatch > Issue Type: Bug > Components: Router Node >Affects Versions: 1.6.0 >Reporter: Ken Giusti >Assignee: Ken Giusti >Priority: Major > Fix For: 1.6.0 > > > The current reference counting implementation doesn't take into account the > loss of a fanout consumer. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Resolved] (DISPATCH-1283) Router crash when link gets freed before its deliveries are freed
[ https://issues.apache.org/jira/browse/DISPATCH-1283?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Ross resolved DISPATCH-1283. Resolution: Fixed > Router crash when link gets freed before its deliveries are freed > - > > Key: DISPATCH-1283 > URL: https://issues.apache.org/jira/browse/DISPATCH-1283 > Project: Qpid Dispatch > Issue Type: Bug > Components: Container >Affects Versions: 1.5.0 >Reporter: Ganesh Murthy >Assignee: Ganesh Murthy >Priority: Major > Fix For: 1.6.0 > > > {noformat} > (gdb) bt > #0 0x7ff1db20d060 in qdr_delete_delivery_internal_CT (core=0x1416180, > delivery=0x7ff1c80d2fe8) at > /home/gmurthy/opensource/qpid-dispatch/src/router_core/transfer.c:613 > #1 0x7ff1db20e9b6 in qdr_delete_delivery_CT (core=0x1416180, > action=0x7ff1bc33d828, discard=false) at > /home/gmurthy/opensource/qpid-dispatch/src/router_core/transfer.c:1221 > #2 0x7ff1db206ec0 in router_core_thread (arg=0x1416180) at > /home/gmurthy/opensource/qpid-dispatch/src/router_core/router_core_thread.c:148 > #3 0x7ff1db11858e in start_thread () from /lib64/libpthread.so.0 > #4 0x7ff1dabc06a3 in clone () from /lib64/libc.so.6 > (gdb){noformat} -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Comment Edited] (DISPATCH-1300) Remove 'stand-alone' from console install path
[ https://issues.apache.org/jira/browse/DISPATCH-1300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16799316#comment-16799316 ] Jiri Daněk edited comment on DISPATCH-1300 at 3/22/19 8:10 PM: --- Would the following work? {noformat} 865 "httpRootDir": { 866 "type": "path", +"default": "stand-alone console directory", 867 "description": "Absolute path to a directory from which to serve static HTML files. For example, /usr/share/qpid-dispatch/console.", 868 "deprecationName": "httpRoot", 869 "create": true 870 }, {noformat} was (Author: jdanek): Would the following work? {noformat} 865 "httpRootDir": { 866 "type": "path", +"default": "stand-alone console directory". 867 "description": "Absolute path to a directory from which to serve static HTML files. For example, /usr/share/qpid-dispatch/console.", 868 "deprecationName": "httpRoot", 869 "create": true 870 }, {noformat} > Remove 'stand-alone' from console install path > -- > > Key: DISPATCH-1300 > URL: https://issues.apache.org/jira/browse/DISPATCH-1300 > Project: Qpid Dispatch > Issue Type: Improvement > Components: Console >Affects Versions: 1.5.0 >Reporter: Ernest Allen >Assignee: Ernest Allen >Priority: Major > Fix For: 1.6.0 > > > Remove 'stand-alone' from the console install directory. This allows upstream > and downstream console locations to match. It also allows the console to be > used without requiring httpRoot to be setup. > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1300) Remove 'stand-alone' from console install path
[ https://issues.apache.org/jira/browse/DISPATCH-1300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16799316#comment-16799316 ] Jiri Daněk commented on DISPATCH-1300: -- Would the following work? {noformat} 865 "httpRootDir": { 866 "type": "path", + "default": "stand-alone console directory". 867 "description": "Absolute path to a directory from which to serve static HTML files. For example, /usr/share/qpid-dispatch/console.", 868 "deprecationName": "httpRoot", 869 "create": true 870 }, {noformat} > Remove 'stand-alone' from console install path > -- > > Key: DISPATCH-1300 > URL: https://issues.apache.org/jira/browse/DISPATCH-1300 > Project: Qpid Dispatch > Issue Type: Improvement > Components: Console >Affects Versions: 1.5.0 >Reporter: Ernest Allen >Assignee: Ernest Allen >Priority: Major > Fix For: 1.6.0 > > > Remove 'stand-alone' from the console install directory. This allows upstream > and downstream console locations to match. It also allows the console to be > used without requiring httpRoot to be setup. > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Comment Edited] (DISPATCH-1300) Remove 'stand-alone' from console install path
[ https://issues.apache.org/jira/browse/DISPATCH-1300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16799316#comment-16799316 ] Jiri Daněk edited comment on DISPATCH-1300 at 3/22/19 8:01 PM: --- Would the following work? {noformat} 865 "httpRootDir": { 866 "type": "path", +"default": "stand-alone console directory". 867 "description": "Absolute path to a directory from which to serve static HTML files. For example, /usr/share/qpid-dispatch/console.", 868 "deprecationName": "httpRoot", 869 "create": true 870 }, {noformat} was (Author: jdanek): Would the following work? {noformat} 865 "httpRootDir": { 866 "type": "path", + "default": "stand-alone console directory". 867 "description": "Absolute path to a directory from which to serve static HTML files. For example, /usr/share/qpid-dispatch/console.", 868 "deprecationName": "httpRoot", 869 "create": true 870 }, {noformat} > Remove 'stand-alone' from console install path > -- > > Key: DISPATCH-1300 > URL: https://issues.apache.org/jira/browse/DISPATCH-1300 > Project: Qpid Dispatch > Issue Type: Improvement > Components: Console >Affects Versions: 1.5.0 >Reporter: Ernest Allen >Assignee: Ernest Allen >Priority: Major > Fix For: 1.6.0 > > > Remove 'stand-alone' from the console install directory. This allows upstream > and downstream console locations to match. It also allows the console to be > used without requiring httpRoot to be setup. > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Reopened] (DISPATCH-1283) Router crash when link gets freed before its deliveries are freed
[ https://issues.apache.org/jira/browse/DISPATCH-1283?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ganesh Murthy reopened DISPATCH-1283: - > Router crash when link gets freed before its deliveries are freed > - > > Key: DISPATCH-1283 > URL: https://issues.apache.org/jira/browse/DISPATCH-1283 > Project: Qpid Dispatch > Issue Type: Bug > Components: Container >Affects Versions: 1.5.0 >Reporter: Ganesh Murthy >Assignee: Ganesh Murthy >Priority: Major > Fix For: 1.6.0 > > > {noformat} > (gdb) bt > #0 0x7ff1db20d060 in qdr_delete_delivery_internal_CT (core=0x1416180, > delivery=0x7ff1c80d2fe8) at > /home/gmurthy/opensource/qpid-dispatch/src/router_core/transfer.c:613 > #1 0x7ff1db20e9b6 in qdr_delete_delivery_CT (core=0x1416180, > action=0x7ff1bc33d828, discard=false) at > /home/gmurthy/opensource/qpid-dispatch/src/router_core/transfer.c:1221 > #2 0x7ff1db206ec0 in router_core_thread (arg=0x1416180) at > /home/gmurthy/opensource/qpid-dispatch/src/router_core/router_core_thread.c:148 > #3 0x7ff1db11858e in start_thread () from /lib64/libpthread.so.0 > #4 0x7ff1dabc06a3 in clone () from /lib64/libc.so.6 > (gdb){noformat} -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Updated] (DISPATCH-1300) Remove 'stand-alone' from console install path
[ https://issues.apache.org/jira/browse/DISPATCH-1300?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ganesh Murthy updated DISPATCH-1300: Fix Version/s: (was: 1.6.0) > Remove 'stand-alone' from console install path > -- > > Key: DISPATCH-1300 > URL: https://issues.apache.org/jira/browse/DISPATCH-1300 > Project: Qpid Dispatch > Issue Type: Improvement > Components: Console >Affects Versions: 1.5.0 >Reporter: Ernest Allen >Assignee: Ernest Allen >Priority: Major > > Remove 'stand-alone' from the console install directory. This allows upstream > and downstream console locations to match. It also allows the console to be > used without requiring httpRoot to be setup. > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Updated] (DISPATCH-1246) Address Proxy module leaks qdrc_endpoint_t on shutdown
[ https://issues.apache.org/jira/browse/DISPATCH-1246?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ganesh Murthy updated DISPATCH-1246: Fix Version/s: (was: 1.6.0) > Address Proxy module leaks qdrc_endpoint_t on shutdown > -- > > Key: DISPATCH-1246 > URL: https://issues.apache.org/jira/browse/DISPATCH-1246 > Project: Qpid Dispatch > Issue Type: Bug > Components: Routing Engine >Affects Versions: 1.5.0 >Reporter: Ken Giusti >Assignee: Chuck Rolke >Priority: Minor > > Running the system_tests_edge_router under valgrind: > ==21590== 657 (256 direct, 401 indirect) bytes in 4 blocks are definitely > lost in loss record 2,886 of 3,532 > ==21590==at 0x4C3147C: memalign (vg_replace_malloc.c:908) > ==21590==by 0x4C31589: posix_memalign (vg_replace_malloc.c:1072) > ==21590==by 0x4EA12FF: qd_alloc (alloc_pool.c:181) > ==21590==by 0x4E83086: qdrc_endpoint_create_link_CT > (core_link_endpoint.c:70) > ==21590==by 0x4E92C2C: on_conn_event (addr_proxy.c:237) > ==21590==by 0x4E92C2C: on_conn_event (addr_proxy.c:199) > ==21590==by 0x4E82E28: qdrc_event_conn_raise (core_events.c:90) > ==21590==by 0x4E82E28: qdrc_event_conn_raise (core_events.c:90) > ==21590==by 0x4E8123F: qdr_connection_opened_CT (connections.c:1147) > ==21590==by 0x4E8C916: router_core_thread (router_core_thread.c:124) > ==21590==by 0x5511593: start_thread (in /usr/lib64/libpthread-2.27.so) > ==21590==by 0x62A6F4E: clone (in /usr/lib64/libc-2.27.so) > ==21590== > Appears that the endpoint allocated here in addr_proxy.c: > // > // Attach a receiving link for edge address tracking updates. > // > ap->tracking_endpoint = > qdrc_endpoint_create_link_CT(ap->core, conn, QD_INCOMING, > > qdr_terminus_normal(QD_TERMINUS_EDGE_ADDRESS_TRACKING), > qdr_terminus(0), > >endpoint_descriptor, ap); > is not released when the router is shutdown -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1297) Fix buffer reference counting for multiframe fanout messages
[ https://issues.apache.org/jira/browse/DISPATCH-1297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16799333#comment-16799333 ] ASF subversion and git services commented on DISPATCH-1297: --- Commit f31d69b6bea62d6142413c24ac0b2bdd016923d1 in qpid-dispatch's branch refs/heads/master from Ken Giusti [ https://gitbox.apache.org/repos/asf?p=qpid-dispatch.git;h=f31d69b ] DISPATCH-1297: Fix the outgoing buffer reference counting The older code did not correctly account for the loss of a multicast consumer. It could end up releasing a buffer before it was sent to all consumers. This closes #473 > Fix buffer reference counting for multiframe fanout messages > > > Key: DISPATCH-1297 > URL: https://issues.apache.org/jira/browse/DISPATCH-1297 > Project: Qpid Dispatch > Issue Type: Bug > Components: Router Node >Affects Versions: 1.6.0 >Reporter: Ken Giusti >Assignee: Ken Giusti >Priority: Major > Fix For: 1.6.0 > > > The current reference counting implementation doesn't take into account the > loss of a fanout consumer. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1297) Fix buffer reference counting for multiframe fanout messages
[ https://issues.apache.org/jira/browse/DISPATCH-1297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16799335#comment-16799335 ] ASF GitHub Bot commented on DISPATCH-1297: -- asfgit commented on pull request #473: DISPATCH-1297: Fix the outgoing buffer reference counting URL: https://github.com/apache/qpid-dispatch/pull/473 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Fix buffer reference counting for multiframe fanout messages > > > Key: DISPATCH-1297 > URL: https://issues.apache.org/jira/browse/DISPATCH-1297 > Project: Qpid Dispatch > Issue Type: Bug > Components: Router Node >Affects Versions: 1.6.0 >Reporter: Ken Giusti >Assignee: Ken Giusti >Priority: Major > Fix For: 1.6.0 > > > The current reference counting implementation doesn't take into account the > loss of a fanout consumer. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1283) Router crash when link gets freed before its deliveries are freed
[ https://issues.apache.org/jira/browse/DISPATCH-1283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16799362#comment-16799362 ] ASF subversion and git services commented on DISPATCH-1283: --- Commit 9abdbdf0edffe0e62644d302712d0bff0b86c8c4 in qpid-dispatch's branch refs/heads/master from Ted Ross [ https://gitbox.apache.org/repos/asf?p=qpid-dispatch.git;h=9abdbdf ] DISPATCH-1283 - Added the link-cleanup protection everywhere except for connection_closed. > Router crash when link gets freed before its deliveries are freed > - > > Key: DISPATCH-1283 > URL: https://issues.apache.org/jira/browse/DISPATCH-1283 > Project: Qpid Dispatch > Issue Type: Bug > Components: Container >Affects Versions: 1.5.0 >Reporter: Ganesh Murthy >Assignee: Ganesh Murthy >Priority: Major > Fix For: 1.6.0 > > > {noformat} > (gdb) bt > #0 0x7ff1db20d060 in qdr_delete_delivery_internal_CT (core=0x1416180, > delivery=0x7ff1c80d2fe8) at > /home/gmurthy/opensource/qpid-dispatch/src/router_core/transfer.c:613 > #1 0x7ff1db20e9b6 in qdr_delete_delivery_CT (core=0x1416180, > action=0x7ff1bc33d828, discard=false) at > /home/gmurthy/opensource/qpid-dispatch/src/router_core/transfer.c:1221 > #2 0x7ff1db206ec0 in router_core_thread (arg=0x1416180) at > /home/gmurthy/opensource/qpid-dispatch/src/router_core/router_core_thread.c:148 > #3 0x7ff1db11858e in start_thread () from /lib64/libpthread.so.0 > #4 0x7ff1dabc06a3 in clone () from /lib64/libc.so.6 > (gdb){noformat} -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1292) Coverity issues on master branch
[ https://issues.apache.org/jira/browse/DISPATCH-1292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16799460#comment-16799460 ] Ganesh Murthy commented on DISPATCH-1292: - {noformat} *** CID 337241: Null pointer dereferences (REVERSE_INULL) /home/gmurthy/opensource/qpid-dispatch/src/connection_manager.c: 780 in qd_dispatch_configure_connector() 774 qd_connection_manager_t *cm = qd->connection_manager; 775 qd_connector_t *ct = qd_server_connector(qd->server); 776 777 qd_error_clear(); 778 ct->policy_vhost = qd_entity_opt_string(entity, "policyVhost", 0); CHECK(); 779 >>> CID 337241: Null pointer dereferences (REVERSE_INULL) >>> Null-checking "ct" suggests that it may be null, but it has already >>>been dereferenced on all paths leading to the check. 780 if (ct && load_server_config(qd, >config, entity, false) == QD_ERROR_NONE) { 781 DEQ_ITEM_INIT(ct); 782 DEQ_INSERT_TAIL(cm->connectors, ct); 783 log_config(cm->log_source, >config, "Connector"); 784 785 // ** CID 337240: Concurrent data access violations (MISSING_LOCK) /home/gmurthy/opensource/qpid-dispatch/src/policy.c: 1174 in qd_policy_amqp_open_connector() *** CID 337240: Concurrent data access violations (MISSING_LOCK) /home/gmurthy/opensource/qpid-dispatch/src/policy.c: 1174 in qd_policy_amqp_open_connector() 1168 qd_conn->policy_settings = NEW(qd_policy_settings_t); 1169 if (qd_conn->policy_settings) { 1170 ZERO(qd_conn->policy_settings); 1171 1172 if (qd_policy_open_fetch_settings(policy, policy_vhost, POLICY_VHOST_GROUP, qd_conn->policy_settings)) { 1173 qd_conn->policy_settings->outgoingConnection = true; >>> CID 337240: Concurrent data access violations (MISSING_LOCK) >>> Accessing "qd_conn->policy_counted" without holding lock >>>"sys_mutex_t.mutex". Elsewhere, "qd_connection_t.policy_counted" is accessed >>>with "sys_mutex_t.mutex" held 1 out of 2 times (1 of these accesses strongly >>>imply that it is necessary). 1174 qd_conn->policy_counted = true; // Count senders and receivers for this connection 1175 } else { 1176 qd_log(policy->log_source, 1177 QD_LOG_ERROR, 1178 "Failed to find policyVhost settings for connection '%d', policyVhost: '%s'", 1179 conn_id, policy_vhost);{noformat} > Coverity issues on master branch > > > Key: DISPATCH-1292 > URL: https://issues.apache.org/jira/browse/DISPATCH-1292 > Project: Qpid Dispatch > Issue Type: Bug > Components: Container >Affects Versions: 1.5.0 >Reporter: Ganesh Murthy >Assignee: Ganesh Murthy >Priority: Major > Fix For: 1.6.0 > > > {noformat} > 10 of 17,133 > New Defects reported by Coverity Scan for Apache Qpid dispatch-router > Inbox > x > scan-ad...@coverity.com > > 12:31 AM (7 hours ago) > > to me > Hi, > Please find the latest report on new defect(s) introduced to Apache Qpid > dispatch-router found with Coverity Scan. > 11 new defect(s) introduced to Apache Qpid dispatch-router found with > Coverity Scan. > 55 defect(s), reported by Coverity Scan earlier, were marked fixed in the > recent build analyzed by Coverity Scan. > New defect(s) Reported-by: Coverity Scan > Showing 11 of 11 defect(s) > ** CID 336749: Control flow issues (MISSING_BREAK) > /home/gmurthy/opensource/qpid-dispatch/src/server.c: 909 in handle() > > *** CID 336749: Control flow issues (MISSING_BREAK) > /home/gmurthy/opensource/qpid-dispatch/src/server.c: 909 in handle() > 903 qdr_handle_authentication_service_connection_event(e); > 904 return true; > 905 } > 906 > 907 switch (pn_event_type(e)) { > 908 > >>> CID 336749: Control flow issues (MISSING_BREAK) > >>> The case for value "PN_PROACTOR_INTERRUPT" is not terminated by a > >>>'break' statement. > 909 case PN_PROACTOR_INTERRUPT: > 910 if (qd_server->stopping) { > 911 /* Interrupt the next thread */ > 912 pn_proactor_interrupt(qd_server->proactor); > 913 /* Stop the current thread */ > 914 return false; > ** CID 336748: Resource leaks (RESOURCE_LEAK) >
[jira] [Commented] (DISPATCH-1292) Coverity issues on master branch
[ https://issues.apache.org/jira/browse/DISPATCH-1292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16799458#comment-16799458 ] ASF subversion and git services commented on DISPATCH-1292: --- Commit c3079b3c2fec654ecfc667abc3c29cc787307c96 in qpid-dispatch's branch refs/heads/master from Ganesh Murthy [ https://gitbox.apache.org/repos/asf?p=qpid-dispatch.git;h=c3079b3 ] DISPATCH-1292 - Coverity fixes > Coverity issues on master branch > > > Key: DISPATCH-1292 > URL: https://issues.apache.org/jira/browse/DISPATCH-1292 > Project: Qpid Dispatch > Issue Type: Bug > Components: Container >Affects Versions: 1.5.0 >Reporter: Ganesh Murthy >Assignee: Ganesh Murthy >Priority: Major > Fix For: 1.6.0 > > > {noformat} > 10 of 17,133 > New Defects reported by Coverity Scan for Apache Qpid dispatch-router > Inbox > x > scan-ad...@coverity.com > > 12:31 AM (7 hours ago) > > to me > Hi, > Please find the latest report on new defect(s) introduced to Apache Qpid > dispatch-router found with Coverity Scan. > 11 new defect(s) introduced to Apache Qpid dispatch-router found with > Coverity Scan. > 55 defect(s), reported by Coverity Scan earlier, were marked fixed in the > recent build analyzed by Coverity Scan. > New defect(s) Reported-by: Coverity Scan > Showing 11 of 11 defect(s) > ** CID 336749: Control flow issues (MISSING_BREAK) > /home/gmurthy/opensource/qpid-dispatch/src/server.c: 909 in handle() > > *** CID 336749: Control flow issues (MISSING_BREAK) > /home/gmurthy/opensource/qpid-dispatch/src/server.c: 909 in handle() > 903 qdr_handle_authentication_service_connection_event(e); > 904 return true; > 905 } > 906 > 907 switch (pn_event_type(e)) { > 908 > >>> CID 336749: Control flow issues (MISSING_BREAK) > >>> The case for value "PN_PROACTOR_INTERRUPT" is not terminated by a > >>>'break' statement. > 909 case PN_PROACTOR_INTERRUPT: > 910 if (qd_server->stopping) { > 911 /* Interrupt the next thread */ > 912 pn_proactor_interrupt(qd_server->proactor); > 913 /* Stop the current thread */ > 914 return false; > ** CID 336748: Resource leaks (RESOURCE_LEAK) > /home/gmurthy/opensource/qpid-dispatch/src/router_node.c: 567 in > AMQP_rx_handler() > > *** CID 336748: Resource leaks (RESOURCE_LEAK) > /home/gmurthy/opensource/qpid-dispatch/src/router_node.c: 567 in > AMQP_rx_handler() > 561 qd_log(router->log_source, QD_LOG_DEBUG, "Message > rejected due to policy violation on target. User:%s", conn->user_id); > 562 pn_link_flow(pn_link, 1); > 563 pn_delivery_update(pnd, PN_REJECTED); > 564 pn_delivery_settle(pnd); > 565 qd_message_free(msg); > 566 qd_iterator_free(addr_iter); > >>> CID 336748: Resource leaks (RESOURCE_LEAK) > >>> Variable "link_exclusions" going out of scope leaks the storage it > >>>points to. > 567 return next_delivery; > 568 } > 569 } > 570 } else { > 571 // > 572 // This is a targeted link, not anonymous. > ** CID 336747: (RESOURCE_LEAK) > /home/gmurthy/opensource/qpid-dispatch/tests/message_test.c: 81 in > test_send_to_messenger() > /home/gmurthy/opensource/qpid-dispatch/tests/message_test.c: 86 in > test_send_to_messenger() > > *** CID 336747: (RESOURCE_LEAK) > /home/gmurthy/opensource/qpid-dispatch/tests/message_test.c: 81 in > test_send_to_messenger() > 75 static char* test_send_to_messenger(void *context) > 76 { > 77 qd_message_t *msg = qd_message(); > 78 qd_message_content_t *content = MSG_CONTENT(msg); > 79 qd_message_compose_1(msg, "test_addr_0", 0); > 80 qd_buffer_t *buf = DEQ_HEAD(content->buffers); > >>> CID 336747: (RESOURCE_LEAK) > >>> Variable "msg" going out of scope leaks the storage it points to. > 81 if (buf == 0) return "Expected a buffer in the test message"; > 82 > 83 pn_message_t *pn_msg = pn_message(); > 84 size_t len = flatten_bufs(content); > 85 int result = pn_message_decode(pn_msg, buffer, len); > 86 if (result != 0) return "Error in pn_message_decode"; > /home/gmurthy/opensource/qpid-dispatch/tests/message_test.c: 86 in >
[jira] [Comment Edited] (PROTON-1996) Proton Client is "stalled" during SASL handshake
[ https://issues.apache.org/jira/browse/PROTON-1996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16798945#comment-16798945 ] Daniel Maier edited comment on PROTON-1996 at 3/22/19 11:59 AM: I can confirm configuring initialHandshakeTimeoutSeconds avoids this issue. Also we created an overall connection timeout with connection retry in our client, which is eclipse hono client: https://github.com/eclipse/hono/issues/1022. However we never found the root cause of this. As it works now for us, we would be fine to close this issue if nobody else has an idea for the root cause. I never mentioned this: we use https://github.com/EnMasseProject/enmasse/tree/master/keycloak-plugin for SASL authentication. Perhaps this is an important information for this issue. was (Author: danielmaier-bsi): I can confirm configuring initialHandshakeTimeoutSeconds avoids this issue. Also we created an overall connection timeout with connection retry in our client, which is eclipse hono client: https://github.com/eclipse/hono/issues/1022. However we never found the root cause of this. As it works now for us, we would be fine to close this issue if nobody else has an idea for the root cause. I never mentioned this: we use https://github.com/EnMasseProject/enmasse/tree/master/keycloak-plugin for SASL authentication if this is important for this issue. > Proton Client is "stalled" during SASL handshake > > > Key: PROTON-1996 > URL: https://issues.apache.org/jira/browse/PROTON-1996 > Project: Qpid Proton > Issue Type: Bug > Components: proton-j >Affects Versions: proton-j-0.25.0, proton-j-0.31.0 >Reporter: Daniel Maier >Priority: Major > > Hi, > When I try to connect with proton vertx client to an AMQP server, the client > seems to come sporadically in some kind of "stalled" state. The logs, see > below, look like the server just not responds anymore which cause the client > to be stalled. There are no more logs regarding SASL handshake. > Used server is qdrouter. > Would it make sense from your point of view to introduce a timeout here? Or > is the responsibility for this in the calling application? > {code} > 08:32:49.412 [vert.x-eventloop-thread-0] DEBUG > o.a.qpid.proton.engine.impl.SaslImpl - Finished writing SASL output. Output > Buffer : java.nio.HeapByteBuffer[pos=8 lim=512 cap=512] > 08:32:49.412 [vert.x-eventloop-thread-0] DEBUG > o.a.qpid.proton.engine.impl.SaslImpl - Finished writing SASL output. Output > Buffer : java.nio.HeapByteBuffer[pos=8 lim=512 cap=512] > 08:32:49.412 [vert.x-eventloop-thread-0] DEBUG > o.a.qpid.proton.engine.impl.SaslImpl - Finished writing SASL output. Output > Buffer : java.nio.HeapByteBuffer[pos=8 lim=512 cap=512] > 08:32:49.412 [vert.x-eventloop-thread-0] DEBUG > o.a.qpid.proton.engine.impl.SaslImpl - Finished writing SASL output. Output > Buffer : java.nio.HeapByteBuffer[pos=0 lim=512 cap=512] > 08:32:49.412 [vert.x-eventloop-thread-0] DEBUG > o.a.qpid.proton.engine.impl.SaslImpl - Finished writing SASL output. Output > Buffer : java.nio.HeapByteBuffer[pos=0 lim=512 cap=512] > 08:32:49.412 [vert.x-eventloop-thread-0] DEBUG > o.a.qpid.proton.engine.impl.SaslImpl - Finished writing SASL output. Output > Buffer : java.nio.HeapByteBuffer[pos=0 lim=512 cap=512] > 08:32:49.412 [vert.x-eventloop-thread-0] DEBUG > io.netty.handler.ssl.SslHandler - [id: 0x429f2c43, L:/100.100.0.6:45982 - > R:xxx.com/xxx:443] HANDSHAKEN: TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 > 08:32:49.418 [vert.x-eventloop-thread-0] DEBUG > o.a.qpid.proton.engine.impl.SaslImpl - SaslImpl [_outcome=PN_SASL_NONE, > state=PN_SASL_IDLE, done=false, role=CLIENT] about to call input. > 08:32:49.418 [vert.x-eventloop-thread-0] TRACE > io.vertx.proton.impl.ProtonTransport - New Proton Event: CONNECTION_INIT > 08:32:49.418 [vert.x-eventloop-thread-0] DEBUG > o.a.qpid.proton.engine.impl.SaslImpl - Finished writing SASL output. Output > Buffer : java.nio.HeapByteBuffer[pos=0 lim=512 cap=512] > 08:32:49.418 [vert.x-eventloop-thread-0] DEBUG > o.a.qpid.proton.engine.impl.SaslImpl - Finished writing SASL output. Output > Buffer : java.nio.HeapByteBuffer[pos=0 lim=512 cap=512] > {code} > Thanks > Daniel -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1280) http against https enabled listener causes segfault
[ https://issues.apache.org/jira/browse/DISPATCH-1280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16798961#comment-16798961 ] michael goulish commented on DISPATCH-1280: --- LWS developer pushed patch. I got through 100 iterations of my reproducer on master with no crash. (I could not do enough iterations before to get a real baseline, but I did get one crash in first 20 tries.) I think it's a deadbug. > http against https enabled listener causes segfault > --- > > Key: DISPATCH-1280 > URL: https://issues.apache.org/jira/browse/DISPATCH-1280 > Project: Qpid Dispatch > Issue Type: Bug >Reporter: Gordon Sim >Assignee: michael goulish >Priority: Major > > If you have a listener with http enabled, an ssl profile referenced, but > requireSsl set to false, and then try to access it over plain http, you get a > segfault in libwebsockets if using version 3.0.1-2. Downgrading to 2.4.2 of > libwebsockets fixes this. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Closed] (DISPATCH-1280) http against https enabled listener causes segfault
[ https://issues.apache.org/jira/browse/DISPATCH-1280?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] michael goulish closed DISPATCH-1280. - Resolution: Fixed > http against https enabled listener causes segfault > --- > > Key: DISPATCH-1280 > URL: https://issues.apache.org/jira/browse/DISPATCH-1280 > Project: Qpid Dispatch > Issue Type: Bug >Reporter: Gordon Sim >Assignee: michael goulish >Priority: Major > > If you have a listener with http enabled, an ssl profile referenced, but > requireSsl set to false, and then try to access it over plain http, you get a > segfault in libwebsockets if using version 3.0.1-2. Downgrading to 2.4.2 of > libwebsockets fixes this. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (PROTON-1996) Proton Client is "stalled" during SASL handshake
[ https://issues.apache.org/jira/browse/PROTON-1996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16798945#comment-16798945 ] Daniel Maier commented on PROTON-1996: -- I can confirm configuring initialHandshakeTimeoutSeconds avoids this issue. Also we created an overall connection timeout with connection retry in our client, which is eclipse hono client: https://github.com/eclipse/hono/issues/1022. However we never found the root cause of this. As it works now for us, we would be fine to close this issue if nobody else has an idea for the root cause. I never mentioned this: we use https://github.com/EnMasseProject/enmasse/tree/master/keycloak-plugin for SASL authentication if this is important for this issue. > Proton Client is "stalled" during SASL handshake > > > Key: PROTON-1996 > URL: https://issues.apache.org/jira/browse/PROTON-1996 > Project: Qpid Proton > Issue Type: Bug > Components: proton-j >Affects Versions: proton-j-0.25.0, proton-j-0.31.0 >Reporter: Daniel Maier >Priority: Major > > Hi, > When I try to connect with proton vertx client to an AMQP server, the client > seems to come sporadically in some kind of "stalled" state. The logs, see > below, look like the server just not responds anymore which cause the client > to be stalled. There are no more logs regarding SASL handshake. > Used server is qdrouter. > Would it make sense from your point of view to introduce a timeout here? Or > is the responsibility for this in the calling application? > {code} > 08:32:49.412 [vert.x-eventloop-thread-0] DEBUG > o.a.qpid.proton.engine.impl.SaslImpl - Finished writing SASL output. Output > Buffer : java.nio.HeapByteBuffer[pos=8 lim=512 cap=512] > 08:32:49.412 [vert.x-eventloop-thread-0] DEBUG > o.a.qpid.proton.engine.impl.SaslImpl - Finished writing SASL output. Output > Buffer : java.nio.HeapByteBuffer[pos=8 lim=512 cap=512] > 08:32:49.412 [vert.x-eventloop-thread-0] DEBUG > o.a.qpid.proton.engine.impl.SaslImpl - Finished writing SASL output. Output > Buffer : java.nio.HeapByteBuffer[pos=8 lim=512 cap=512] > 08:32:49.412 [vert.x-eventloop-thread-0] DEBUG > o.a.qpid.proton.engine.impl.SaslImpl - Finished writing SASL output. Output > Buffer : java.nio.HeapByteBuffer[pos=0 lim=512 cap=512] > 08:32:49.412 [vert.x-eventloop-thread-0] DEBUG > o.a.qpid.proton.engine.impl.SaslImpl - Finished writing SASL output. Output > Buffer : java.nio.HeapByteBuffer[pos=0 lim=512 cap=512] > 08:32:49.412 [vert.x-eventloop-thread-0] DEBUG > o.a.qpid.proton.engine.impl.SaslImpl - Finished writing SASL output. Output > Buffer : java.nio.HeapByteBuffer[pos=0 lim=512 cap=512] > 08:32:49.412 [vert.x-eventloop-thread-0] DEBUG > io.netty.handler.ssl.SslHandler - [id: 0x429f2c43, L:/100.100.0.6:45982 - > R:xxx.com/xxx:443] HANDSHAKEN: TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 > 08:32:49.418 [vert.x-eventloop-thread-0] DEBUG > o.a.qpid.proton.engine.impl.SaslImpl - SaslImpl [_outcome=PN_SASL_NONE, > state=PN_SASL_IDLE, done=false, role=CLIENT] about to call input. > 08:32:49.418 [vert.x-eventloop-thread-0] TRACE > io.vertx.proton.impl.ProtonTransport - New Proton Event: CONNECTION_INIT > 08:32:49.418 [vert.x-eventloop-thread-0] DEBUG > o.a.qpid.proton.engine.impl.SaslImpl - Finished writing SASL output. Output > Buffer : java.nio.HeapByteBuffer[pos=0 lim=512 cap=512] > 08:32:49.418 [vert.x-eventloop-thread-0] DEBUG > o.a.qpid.proton.engine.impl.SaslImpl - Finished writing SASL output. Output > Buffer : java.nio.HeapByteBuffer[pos=0 lim=512 cap=512] > {code} > Thanks > Daniel -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (PROTON-1996) Proton Client is "stalled" during SASL handshake
[ https://issues.apache.org/jira/browse/PROTON-1996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16798948#comment-16798948 ] Gordon Sim commented on PROTON-1996: I made some changes to the router auth plugin to better handle this area: https://issues.apache.org/jira/browse/DISPATCH-1269 (though these are speculative and I never reproduced the symptoms) > Proton Client is "stalled" during SASL handshake > > > Key: PROTON-1996 > URL: https://issues.apache.org/jira/browse/PROTON-1996 > Project: Qpid Proton > Issue Type: Bug > Components: proton-j >Affects Versions: proton-j-0.25.0, proton-j-0.31.0 >Reporter: Daniel Maier >Priority: Major > > Hi, > When I try to connect with proton vertx client to an AMQP server, the client > seems to come sporadically in some kind of "stalled" state. The logs, see > below, look like the server just not responds anymore which cause the client > to be stalled. There are no more logs regarding SASL handshake. > Used server is qdrouter. > Would it make sense from your point of view to introduce a timeout here? Or > is the responsibility for this in the calling application? > {code} > 08:32:49.412 [vert.x-eventloop-thread-0] DEBUG > o.a.qpid.proton.engine.impl.SaslImpl - Finished writing SASL output. Output > Buffer : java.nio.HeapByteBuffer[pos=8 lim=512 cap=512] > 08:32:49.412 [vert.x-eventloop-thread-0] DEBUG > o.a.qpid.proton.engine.impl.SaslImpl - Finished writing SASL output. Output > Buffer : java.nio.HeapByteBuffer[pos=8 lim=512 cap=512] > 08:32:49.412 [vert.x-eventloop-thread-0] DEBUG > o.a.qpid.proton.engine.impl.SaslImpl - Finished writing SASL output. Output > Buffer : java.nio.HeapByteBuffer[pos=8 lim=512 cap=512] > 08:32:49.412 [vert.x-eventloop-thread-0] DEBUG > o.a.qpid.proton.engine.impl.SaslImpl - Finished writing SASL output. Output > Buffer : java.nio.HeapByteBuffer[pos=0 lim=512 cap=512] > 08:32:49.412 [vert.x-eventloop-thread-0] DEBUG > o.a.qpid.proton.engine.impl.SaslImpl - Finished writing SASL output. Output > Buffer : java.nio.HeapByteBuffer[pos=0 lim=512 cap=512] > 08:32:49.412 [vert.x-eventloop-thread-0] DEBUG > o.a.qpid.proton.engine.impl.SaslImpl - Finished writing SASL output. Output > Buffer : java.nio.HeapByteBuffer[pos=0 lim=512 cap=512] > 08:32:49.412 [vert.x-eventloop-thread-0] DEBUG > io.netty.handler.ssl.SslHandler - [id: 0x429f2c43, L:/100.100.0.6:45982 - > R:xxx.com/xxx:443] HANDSHAKEN: TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 > 08:32:49.418 [vert.x-eventloop-thread-0] DEBUG > o.a.qpid.proton.engine.impl.SaslImpl - SaslImpl [_outcome=PN_SASL_NONE, > state=PN_SASL_IDLE, done=false, role=CLIENT] about to call input. > 08:32:49.418 [vert.x-eventloop-thread-0] TRACE > io.vertx.proton.impl.ProtonTransport - New Proton Event: CONNECTION_INIT > 08:32:49.418 [vert.x-eventloop-thread-0] DEBUG > o.a.qpid.proton.engine.impl.SaslImpl - Finished writing SASL output. Output > Buffer : java.nio.HeapByteBuffer[pos=0 lim=512 cap=512] > 08:32:49.418 [vert.x-eventloop-thread-0] DEBUG > o.a.qpid.proton.engine.impl.SaslImpl - Finished writing SASL output. Output > Buffer : java.nio.HeapByteBuffer[pos=0 lim=512 cap=512] > {code} > Thanks > Daniel -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Created] (DISPATCH-1299) Provide API access to the already existing safe-reference capability in alloc-pool
Ted Ross created DISPATCH-1299: -- Summary: Provide API access to the already existing safe-reference capability in alloc-pool Key: DISPATCH-1299 URL: https://issues.apache.org/jira/browse/DISPATCH-1299 Project: Qpid Dispatch Issue Type: Improvement Components: Container Reporter: Ted Ross Assignee: Ted Ross Fix For: 1.6.0 This improvement adds the following two functions to the list of functions generated per pooled type: {{typedef ... _sp;}} {{void set_safe_ptr( *p, _sp *sp);}} {{ *safe_deref_(_sp sp);}} A user of this feature can declare or allocate a safe-pointer, set the safe-pointer using a normal object pointer, and dereference the safe-pointer later to yield the original normal pointer. If, in the interim time, the object was freed, the safe-dereference will yield a NULL pointer rather than a stale (possibly re-used) pointer. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1299) Provide API access to the already existing safe-reference capability in alloc-pool
[ https://issues.apache.org/jira/browse/DISPATCH-1299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16799032#comment-16799032 ] ASF subversion and git services commented on DISPATCH-1299: --- Commit c47b976df339ea896b2ba5cf535b9bc07c13534c in qpid-dispatch's branch refs/heads/master from Ted Ross [ https://gitbox.apache.org/repos/asf?p=qpid-dispatch.git;h=c47b976 ] DISPATCH-1299 - Added safe-reference feature to the alloc-pool module. Note: alloc-malloc also has the same interface (will build), but does not provide the same safety. > Provide API access to the already existing safe-reference capability in > alloc-pool > -- > > Key: DISPATCH-1299 > URL: https://issues.apache.org/jira/browse/DISPATCH-1299 > Project: Qpid Dispatch > Issue Type: Improvement > Components: Container >Reporter: Ted Ross >Assignee: Ted Ross >Priority: Major > Fix For: 1.6.0 > > > This improvement adds the following two functions to the list of functions > generated per pooled type: > {{typedef ... _sp;}} > {{void set_safe_ptr( *p, _sp *sp);}} > {{ *safe_deref_(_sp sp);}} > A user of this feature can declare or allocate a safe-pointer, set the > safe-pointer using a normal object pointer, and dereference the safe-pointer > later to yield the original normal pointer. If, in the interim time, the > object was freed, the safe-dereference will yield a NULL pointer rather than > a stale (possibly re-used) pointer. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1285) Router crashes occasionally on system_tests_delivery_abort
[ https://issues.apache.org/jira/browse/DISPATCH-1285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16799033#comment-16799033 ] ASF subversion and git services commented on DISPATCH-1285: --- Commit 16826bc29e8772feeda84c07f546a5db60d755a8 in qpid-dispatch's branch refs/heads/master from Ted Ross [ https://gitbox.apache.org/repos/asf?p=qpid-dispatch.git;h=16826bc ] DISPATCH-1285 - Updated the deferred receive handler to use safe pointers to links (cherry picked from commit 33d4a27f973037345f3db61390a998fd3cee2f94) > Router crashes occasionally on system_tests_delivery_abort > -- > > Key: DISPATCH-1285 > URL: https://issues.apache.org/jira/browse/DISPATCH-1285 > Project: Qpid Dispatch > Issue Type: Bug > Components: Container >Affects Versions: 1.5.0 >Reporter: Ganesh Murthy >Assignee: Ganesh Murthy >Priority: Major > Fix For: 1.6.0 > > > The router occasionally crashes with the following backtrace when running > system_tests_delivery_abort. Dont run the test independently, run it as part > of the test suite using ctest -VV > > {noformat} > (gdb) bt > #0 0x7f3f763d8aaf in qd_link_get_node_context (link=0x7f3f580b40e8) at > /home/gmurthy/opensource/qpid-dispatch/src/container.c:1053 > #1 0x7f3f7642595f in deferred_AMQP_rx_handler (context=0x7f3f580b40e8, > discard=false) at /home/gmurthy/opensource/qpid-dispatch/src/router_node.c:640 > #2 0x7f3f7642bf02 in invoke_deferred_calls (conn=0x1b5a568, > discard=false) at /home/gmurthy/opensource/qpid-dispatch/src/server.c:728 > #3 0x7f3f7642c9c2 in handle (qd_server=0x1a0f5b0, e=0x7f3f58093520, > pn_conn=0x1bf4e40, ctx=0x1b5a568) at > /home/gmurthy/opensource/qpid-dispatch/src/server.c:961 > #4 0x7f3f7642cd2a in thread_run (arg=0x1a0f5b0) at > /home/gmurthy/opensource/qpid-dispatch/src/server.c:1017 > #5 0x7f3f7632258e in start_thread () from /lib64/libpthread.so.0 > #6 0x7f3f75dca6a3 in clone () from /lib64/libc.so.6 > (gdb){noformat} > > Here is the output from the test - > {noformat} > 40: Test command: /usr/bin/python > "/home/gmurthy/opensource/qpid-dispatch/build/tests/run.py" "unit2" "-v" > "system_tests_delivery_abort" > 40: Test timeout computed to be: 1500 > 40: test_01_message_route_truncated_one_router > (system_tests_delivery_abort.RouterTest) ... ok > 40: test_02_message_route_truncated_two_routers > (system_tests_delivery_abort.RouterTest) ... ok > 40: test_03_link_route_truncated_one_router > (system_tests_delivery_abort.RouterTest) ... ok > 40: test_04_link_route_truncated_two_routers > (system_tests_delivery_abort.RouterTest) ... ERROR > 40: test_05_message_route_abort_one_router > (system_tests_delivery_abort.RouterTest) ... ERROR > 40: test_06_message_route_abort_two_routers > (system_tests_delivery_abort.RouterTest) ... ERROR > 40: test_07_multicast_truncate_one_router > (system_tests_delivery_abort.RouterTest) ... ERROR > 40: ERROR > 40: > 40: == > 40: ERROR: test_04_link_route_truncated_two_routers > (system_tests_delivery_abort.RouterTest) > 40: -- > 40: Traceback (most recent call last): > 40: File > "/home/gmurthy/opensource/qpid-dispatch/tests/system_tests_delivery_abort.py", > line 101, in test_04_link_route_truncated_two_routers > 40: test.run() > 40: File > "/home/gmurthy/opensource/qpid-dispatch/tests/system_tests_delivery_abort.py", > line 390, in run > 40: container.run() > 40: File > "/opt/qpid-proton/qpid-proton/lib64/proton/bindings/python/proton/_reactor.py", > line 181, in run > 40: while self.process(): pass > 40: File > "/opt/qpid-proton/qpid-proton/lib64/proton/bindings/python/proton/_reactor.py", > line 240, in process > 40: event.dispatch(self._global_handler) > 40: File > "/opt/qpid-proton/qpid-proton/lib64/proton/bindings/python/proton/_events.py", > line 135, in dispatch > 40: _dispatch(handler, type.method, self) > 40: File > "/opt/qpid-proton/qpid-proton/lib64/proton/bindings/python/proton/_events.py", > line 117, in _dispatch > 40: handler.on_unhandled(method, *args) > 40: File > "/opt/qpid-proton/qpid-proton/lib64/proton/bindings/python/proton/_reactor.py", > line 665, in on_unhandled > 40: event.dispatch(self.base) > 40: File > "/opt/qpid-proton/qpid-proton/lib64/proton/bindings/python/proton/_events.py", > line 135, in dispatch > 40: _dispatch(handler, type.method, self) > 40: File > "/opt/qpid-proton/qpid-proton/lib64/proton/bindings/python/proton/_events.py", > line 115, in _dispatch > 40: m(*args) > 40: File >
[jira] [Commented] (DISPATCH-1299) Provide API access to the already existing safe-reference capability in alloc-pool
[ https://issues.apache.org/jira/browse/DISPATCH-1299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16799034#comment-16799034 ] ASF subversion and git services commented on DISPATCH-1299: --- Commit 45332d36a1091d872cf857178432e04631af8456 in qpid-dispatch's branch refs/heads/master from Ted Ross [ https://gitbox.apache.org/repos/asf?p=qpid-dispatch.git;h=45332d3 ] DISPATCH-1299 - Update safe-pointer use in the lookup client to use the newer API. (cherry picked from commit 1ee6aa76e2bdcbdcd4fc9d9f9fe7a7f0bd7a97a5) > Provide API access to the already existing safe-reference capability in > alloc-pool > -- > > Key: DISPATCH-1299 > URL: https://issues.apache.org/jira/browse/DISPATCH-1299 > Project: Qpid Dispatch > Issue Type: Improvement > Components: Container >Reporter: Ted Ross >Assignee: Ted Ross >Priority: Major > Fix For: 1.6.0 > > > This improvement adds the following two functions to the list of functions > generated per pooled type: > {{typedef ... _sp;}} > {{void set_safe_ptr( *p, _sp *sp);}} > {{ *safe_deref_(_sp sp);}} > A user of this feature can declare or allocate a safe-pointer, set the > safe-pointer using a normal object pointer, and dereference the safe-pointer > later to yield the original normal pointer. If, in the interim time, the > object was freed, the safe-dereference will yield a NULL pointer rather than > a stale (possibly re-used) pointer. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] ChugR commented on a change in pull request #472: Dispatch 1288 1 - policy for outbound connectors
ChugR commented on a change in pull request #472: Dispatch 1288 1 - policy for outbound connectors URL: https://github.com/apache/qpid-dispatch/pull/472#discussion_r268181900 ## File path: src/policy.c ## @@ -404,18 +409,47 @@ bool qd_policy_open_lookup_user( } else { qd_log(policy->log_source, QD_LOG_DEBUG, "Internal: lookup_user: lookup_user"); } +Py_XDECREF(module); } -if (!res) { -if (module) { -Py_XDECREF(module); -} -qd_python_unlock(lock_state); -return false; -} +qd_python_unlock(lock_state); -// if (name_buf[0]) { -// Go get the named settings +qd_log(policy->log_source, + QD_LOG_TRACE, + "[%"PRIu64"]: ALLOW AMQP Open lookup_user: %s, rhost: %s, vhost: %s, connection: %s. Usergroup: '%s'%s", + conn_id, username, hostip, vhost, conn_name, name_buf, (res ? "" : " Internal error.")); +} +return res; +} + + +/** Fetch policy settings for a vhost/group + * A vhost database user group name has been returned by qd_policy_open_lookup_user + * or by some configuration value. Access the vhost database for that group and + * extract the run-time settings. + * @param[in] policy pointer to policy + * @param[in] username authenticated user name (for logging) + * @param[in] hostip numeric host ip address (for logging) + * @param[in] vhost vhost name + * @param[in] conn_name connection name for tracking (for logging) + * @param[in] name_buf group name that holds the settings of interest + * @param[in] conn_id connection id for log tracking (for logging) + * @param[out] settings pointer to settings object to be filled with policy values + **/ +bool qd_policy_open_fetch_settings( +qd_policy_t *policy, +const char *username, +const char *hostip, +const char *vhost, +const char *conn_name, +const char *name_buf, +uint64_tconn_id, Review comment: Fixed at 7baea. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (PROTON-1996) Proton Client is "stalled" during SASL handshake
[ https://issues.apache.org/jira/browse/PROTON-1996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16799041#comment-16799041 ] Gordon Sim commented on PROTON-1996: I'd suggest we close it and open an issue against the router if/when there is another occurrence. > Proton Client is "stalled" during SASL handshake > > > Key: PROTON-1996 > URL: https://issues.apache.org/jira/browse/PROTON-1996 > Project: Qpid Proton > Issue Type: Bug > Components: proton-j >Affects Versions: proton-j-0.25.0, proton-j-0.31.0 >Reporter: Daniel Maier >Priority: Major > > Hi, > When I try to connect with proton vertx client to an AMQP server, the client > seems to come sporadically in some kind of "stalled" state. The logs, see > below, look like the server just not responds anymore which cause the client > to be stalled. There are no more logs regarding SASL handshake. > Used server is qdrouter. > Would it make sense from your point of view to introduce a timeout here? Or > is the responsibility for this in the calling application? > {code} > 08:32:49.412 [vert.x-eventloop-thread-0] DEBUG > o.a.qpid.proton.engine.impl.SaslImpl - Finished writing SASL output. Output > Buffer : java.nio.HeapByteBuffer[pos=8 lim=512 cap=512] > 08:32:49.412 [vert.x-eventloop-thread-0] DEBUG > o.a.qpid.proton.engine.impl.SaslImpl - Finished writing SASL output. Output > Buffer : java.nio.HeapByteBuffer[pos=8 lim=512 cap=512] > 08:32:49.412 [vert.x-eventloop-thread-0] DEBUG > o.a.qpid.proton.engine.impl.SaslImpl - Finished writing SASL output. Output > Buffer : java.nio.HeapByteBuffer[pos=8 lim=512 cap=512] > 08:32:49.412 [vert.x-eventloop-thread-0] DEBUG > o.a.qpid.proton.engine.impl.SaslImpl - Finished writing SASL output. Output > Buffer : java.nio.HeapByteBuffer[pos=0 lim=512 cap=512] > 08:32:49.412 [vert.x-eventloop-thread-0] DEBUG > o.a.qpid.proton.engine.impl.SaslImpl - Finished writing SASL output. Output > Buffer : java.nio.HeapByteBuffer[pos=0 lim=512 cap=512] > 08:32:49.412 [vert.x-eventloop-thread-0] DEBUG > o.a.qpid.proton.engine.impl.SaslImpl - Finished writing SASL output. Output > Buffer : java.nio.HeapByteBuffer[pos=0 lim=512 cap=512] > 08:32:49.412 [vert.x-eventloop-thread-0] DEBUG > io.netty.handler.ssl.SslHandler - [id: 0x429f2c43, L:/100.100.0.6:45982 - > R:xxx.com/xxx:443] HANDSHAKEN: TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 > 08:32:49.418 [vert.x-eventloop-thread-0] DEBUG > o.a.qpid.proton.engine.impl.SaslImpl - SaslImpl [_outcome=PN_SASL_NONE, > state=PN_SASL_IDLE, done=false, role=CLIENT] about to call input. > 08:32:49.418 [vert.x-eventloop-thread-0] TRACE > io.vertx.proton.impl.ProtonTransport - New Proton Event: CONNECTION_INIT > 08:32:49.418 [vert.x-eventloop-thread-0] DEBUG > o.a.qpid.proton.engine.impl.SaslImpl - Finished writing SASL output. Output > Buffer : java.nio.HeapByteBuffer[pos=0 lim=512 cap=512] > 08:32:49.418 [vert.x-eventloop-thread-0] DEBUG > o.a.qpid.proton.engine.impl.SaslImpl - Finished writing SASL output. Output > Buffer : java.nio.HeapByteBuffer[pos=0 lim=512 cap=512] > {code} > Thanks > Daniel -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] ChugR commented on a change in pull request #472: Dispatch 1288 1 - policy for outbound connectors
ChugR commented on a change in pull request #472: Dispatch 1288 1 - policy for outbound connectors URL: https://github.com/apache/qpid-dispatch/pull/472#discussion_r268181596 ## File path: src/policy.c ## @@ -1110,6 +1152,62 @@ void qd_policy_amqp_open(qd_connection_t *qd_conn) { } +void qd_policy_amqp_open_connector(qd_connection_t *qd_conn) { +pn_connection_t *conn = qd_connection_pn(qd_conn); +qd_dispatch_t *qd = qd_server_dispatch(qd_conn->server); +qd_policy_t *policy = qd->policy; +bool connection_allowed = true; + +if (policy->enableVhostPolicy && +(!qd_conn->role || !strcmp(qd_conn->role, "normal") || !strcmp(qd_conn->role, "route-container"))) { +// Open connection or not based on policy. +const char *hostip = qd_connection_remote_ip(qd_conn); +const char *conn_name = qd_connection_name(qd_conn); +uint32_t conn_id = qd_conn->connection_id; + +qd_connector_t *connector = qd_connection_connector(qd_conn); +const char *policy_vhost = qd_connector_policy_vhost(connector); + +if (!qd_conn->policy_settings) { +qd_conn->policy_settings = NEW(qd_policy_settings_t); // TODO: memory pool for settings +ZERO(qd_conn->policy_settings); +} + +if (strlen(policy_vhost) > 0) { +// This connector connection is controlled by policy. +if (qd_policy_open_fetch_settings(policy, qd_conn->user_id, hostip, policy_vhost, conn_name, +POLICY_VHOST_GROUP, conn_id, +qd_conn->policy_settings)) { +// It's too late to apply transport policy settings as the local +// AMQP Open has already been sent. +// TODO: Apply transport max_frame and channel_max to outgoing Review comment: Resolved at 7baea. In outbound connections all the transport settings are from the connector and none come from policy. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] ChugR commented on a change in pull request #472: Dispatch 1288 1 - policy for outbound connectors
ChugR commented on a change in pull request #472: Dispatch 1288 1 - policy for outbound connectors URL: https://github.com/apache/qpid-dispatch/pull/472#discussion_r268183135 ## File path: src/policy.c ## @@ -1110,6 +1152,62 @@ void qd_policy_amqp_open(qd_connection_t *qd_conn) { } +void qd_policy_amqp_open_connector(qd_connection_t *qd_conn) { Review comment: I'm leaving the name as-is. It looks good at the call site in container.c. There are two hard problems in software engineering: cache invalidation, naming things, and off-by-one errors. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] asfgit closed pull request #467: DISPATCH-1275 - Enabled deletion of connections based on connection i…
asfgit closed pull request #467: DISPATCH-1275 - Enabled deletion of connections based on connection i… URL: https://github.com/apache/qpid-dispatch/pull/467 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (PROTON-1996) Proton Client is "stalled" during SASL handshake
[ https://issues.apache.org/jira/browse/PROTON-1996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16799019#comment-16799019 ] Daniel Maier commented on PROTON-1996: -- Great. Thanks. I see as I opened this issue I am also the one who is allowed to close it :). Shall I close it or do you want to do some further investigations? > Proton Client is "stalled" during SASL handshake > > > Key: PROTON-1996 > URL: https://issues.apache.org/jira/browse/PROTON-1996 > Project: Qpid Proton > Issue Type: Bug > Components: proton-j >Affects Versions: proton-j-0.25.0, proton-j-0.31.0 >Reporter: Daniel Maier >Priority: Major > > Hi, > When I try to connect with proton vertx client to an AMQP server, the client > seems to come sporadically in some kind of "stalled" state. The logs, see > below, look like the server just not responds anymore which cause the client > to be stalled. There are no more logs regarding SASL handshake. > Used server is qdrouter. > Would it make sense from your point of view to introduce a timeout here? Or > is the responsibility for this in the calling application? > {code} > 08:32:49.412 [vert.x-eventloop-thread-0] DEBUG > o.a.qpid.proton.engine.impl.SaslImpl - Finished writing SASL output. Output > Buffer : java.nio.HeapByteBuffer[pos=8 lim=512 cap=512] > 08:32:49.412 [vert.x-eventloop-thread-0] DEBUG > o.a.qpid.proton.engine.impl.SaslImpl - Finished writing SASL output. Output > Buffer : java.nio.HeapByteBuffer[pos=8 lim=512 cap=512] > 08:32:49.412 [vert.x-eventloop-thread-0] DEBUG > o.a.qpid.proton.engine.impl.SaslImpl - Finished writing SASL output. Output > Buffer : java.nio.HeapByteBuffer[pos=8 lim=512 cap=512] > 08:32:49.412 [vert.x-eventloop-thread-0] DEBUG > o.a.qpid.proton.engine.impl.SaslImpl - Finished writing SASL output. Output > Buffer : java.nio.HeapByteBuffer[pos=0 lim=512 cap=512] > 08:32:49.412 [vert.x-eventloop-thread-0] DEBUG > o.a.qpid.proton.engine.impl.SaslImpl - Finished writing SASL output. Output > Buffer : java.nio.HeapByteBuffer[pos=0 lim=512 cap=512] > 08:32:49.412 [vert.x-eventloop-thread-0] DEBUG > o.a.qpid.proton.engine.impl.SaslImpl - Finished writing SASL output. Output > Buffer : java.nio.HeapByteBuffer[pos=0 lim=512 cap=512] > 08:32:49.412 [vert.x-eventloop-thread-0] DEBUG > io.netty.handler.ssl.SslHandler - [id: 0x429f2c43, L:/100.100.0.6:45982 - > R:xxx.com/xxx:443] HANDSHAKEN: TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 > 08:32:49.418 [vert.x-eventloop-thread-0] DEBUG > o.a.qpid.proton.engine.impl.SaslImpl - SaslImpl [_outcome=PN_SASL_NONE, > state=PN_SASL_IDLE, done=false, role=CLIENT] about to call input. > 08:32:49.418 [vert.x-eventloop-thread-0] TRACE > io.vertx.proton.impl.ProtonTransport - New Proton Event: CONNECTION_INIT > 08:32:49.418 [vert.x-eventloop-thread-0] DEBUG > o.a.qpid.proton.engine.impl.SaslImpl - Finished writing SASL output. Output > Buffer : java.nio.HeapByteBuffer[pos=0 lim=512 cap=512] > 08:32:49.418 [vert.x-eventloop-thread-0] DEBUG > o.a.qpid.proton.engine.impl.SaslImpl - Finished writing SASL output. Output > Buffer : java.nio.HeapByteBuffer[pos=0 lim=512 cap=512] > {code} > Thanks > Daniel -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] ChugR commented on a change in pull request #472: Dispatch 1288 1 - policy for outbound connectors
ChugR commented on a change in pull request #472: Dispatch 1288 1 - policy for outbound connectors URL: https://github.com/apache/qpid-dispatch/pull/472#discussion_r268180966 ## File path: src/policy.c ## @@ -404,18 +409,47 @@ bool qd_policy_open_lookup_user( } else { qd_log(policy->log_source, QD_LOG_DEBUG, "Internal: lookup_user: lookup_user"); } +Py_XDECREF(module); } -if (!res) { -if (module) { -Py_XDECREF(module); -} -qd_python_unlock(lock_state); -return false; -} +qd_python_unlock(lock_state); -// if (name_buf[0]) { -// Go get the named settings +qd_log(policy->log_source, + QD_LOG_TRACE, + "[%"PRIu64"]: ALLOW AMQP Open lookup_user: %s, rhost: %s, vhost: %s, connection: %s. Usergroup: '%s'%s", + conn_id, username, hostip, vhost, conn_name, name_buf, (res ? "" : " Internal error.")); +} +return res; +} + + +/** Fetch policy settings for a vhost/group + * A vhost database user group name has been returned by qd_policy_open_lookup_user + * or by some configuration value. Access the vhost database for that group and + * extract the run-time settings. + * @param[in] policy pointer to policy + * @param[in] username authenticated user name (for logging) + * @param[in] hostip numeric host ip address (for logging) + * @param[in] vhost vhost name + * @param[in] conn_name connection name for tracking (for logging) + * @param[in] name_buf group name that holds the settings of interest + * @param[in] conn_id connection id for log tracking (for logging) + * @param[out] settings pointer to settings object to be filled with policy values + **/ +bool qd_policy_open_fetch_settings( +qd_policy_t *policy, +const char *username, +const char *hostip, +const char *vhost, +const char *conn_name, +const char *name_buf, +uint64_tconn_id, +qd_policy_settings_t *settings) +{ +bool res = false; +qd_python_lock_state_t lock_state = qd_python_lock(); +PyObject *module = PyImport_ImportModule("qpid_dispatch_internal.policy.policy_manager"); +if (module) { res = false; Review comment: fixed at 7baea This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] codecov-io edited a comment on issue #472: Dispatch 1288 1 - policy for outbound connectors
codecov-io edited a comment on issue #472: Dispatch 1288 1 - policy for outbound connectors URL: https://github.com/apache/qpid-dispatch/pull/472#issuecomment-474588568 # [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/472?src=pr=h1) Report > Merging [#472](https://codecov.io/gh/apache/qpid-dispatch/pull/472?src=pr=desc) into [master](https://codecov.io/gh/apache/qpid-dispatch/commit/bdafbbe02f2762ec3c38bc254e59c3efa9b23c9e?src=pr=desc) will **increase** coverage by `0.03%`. > The diff coverage is `96.1%`. [![Impacted file tree graph](https://codecov.io/gh/apache/qpid-dispatch/pull/472/graphs/tree.svg?width=650=rk2Cgd27pP=150=pr)](https://codecov.io/gh/apache/qpid-dispatch/pull/472?src=pr=tree) ```diff @@Coverage Diff @@ ## master #472 +/- ## == + Coverage 86.68% 86.72% +0.03% == Files 86 86 Lines 1908819150 +62 == + Hits1654716608 +61 - Misses 2541 2542 +1 ``` | [Impacted Files](https://codecov.io/gh/apache/qpid-dispatch/pull/472?src=pr=tree) | Coverage Δ | | |---|---|---| | [src/container.c](https://codecov.io/gh/apache/qpid-dispatch/pull/472/diff?src=pr=tree#diff-c3JjL2NvbnRhaW5lci5j) | `79.62% <100%> (+0.74%)` | :arrow_up: | | [src/connection\_manager.c](https://codecov.io/gh/apache/qpid-dispatch/pull/472/diff?src=pr=tree#diff-c3JjL2Nvbm5lY3Rpb25fbWFuYWdlci5j) | `89.36% <100%> (+0.04%)` | :arrow_up: | | [src/server.c](https://codecov.io/gh/apache/qpid-dispatch/pull/472/diff?src=pr=tree#diff-c3JjL3NlcnZlci5j) | `86.96% <100%> (+0.26%)` | :arrow_up: | | [src/policy.c](https://codecov.io/gh/apache/qpid-dispatch/pull/472/diff?src=pr=tree#diff-c3JjL3BvbGljeS5j) | `85.91% <95.77%> (+0.61%)` | :arrow_up: | | [tests/alloc\_test.c](https://codecov.io/gh/apache/qpid-dispatch/pull/472/diff?src=pr=tree#diff-dGVzdHMvYWxsb2NfdGVzdC5j) | `95.34% <0%> (-4.66%)` | :arrow_down: | | [src/router\_core/transfer.c](https://codecov.io/gh/apache/qpid-dispatch/pull/472/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL3RyYW5zZmVyLmM=) | `90.55% <0%> (-0.43%)` | :arrow_down: | | [src/parse.c](https://codecov.io/gh/apache/qpid-dispatch/pull/472/diff?src=pr=tree#diff-c3JjL3BhcnNlLmM=) | `88.29% <0%> (-0.26%)` | :arrow_down: | | [src/iterator.c](https://codecov.io/gh/apache/qpid-dispatch/pull/472/diff?src=pr=tree#diff-c3JjL2l0ZXJhdG9yLmM=) | `93.45% <0%> (-0.22%)` | :arrow_down: | | [src/router\_core/connections.c](https://codecov.io/gh/apache/qpid-dispatch/pull/472/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL2Nvbm5lY3Rpb25zLmM=) | `94.43% <0%> (-0.13%)` | :arrow_down: | | [src/router\_node.c](https://codecov.io/gh/apache/qpid-dispatch/pull/472/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9ub2RlLmM=) | `94.13% <0%> (-0.06%)` | :arrow_down: | | ... and [12 more](https://codecov.io/gh/apache/qpid-dispatch/pull/472/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/472?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/472?src=pr=footer). Last update [bdafbbe...7baea83](https://codecov.io/gh/apache/qpid-dispatch/pull/472?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1275) Enable deletion of connections based on connection id
[ https://issues.apache.org/jira/browse/DISPATCH-1275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16799057#comment-16799057 ] ASF subversion and git services commented on DISPATCH-1275: --- Commit 9f621c432f7e9dd49156292d1f7e53be4fd7eaf9 in qpid-dispatch's branch refs/heads/master from Ganesh Murthy [ https://gitbox.apache.org/repos/asf?p=qpid-dispatch.git;h=9f621c4 ] DISPATCH-1275 - Enabled deletion of connections based on connection id. Added related policy code. By default, a user has privileges to delete a connection. A policy needs to disallow this. Inter-router connections can never be deleted This closes #467 > Enable deletion of connections based on connection id > - > > Key: DISPATCH-1275 > URL: https://issues.apache.org/jira/browse/DISPATCH-1275 > Project: Qpid Dispatch > Issue Type: Bug > Components: Container >Affects Versions: 1.5.0 >Reporter: Ganesh Murthy >Assignee: Ganesh Murthy >Priority: Major > > Sometimes there is a need to delete/kill certain connections on which there > are slow consumers or consumers that won't acknowledge messages. > Add functionality to the router server side code that will allow users to > delete connections based on the connection id. The connection id can be > obtained from the output of-- > {noformat} > qdstat -c{noformat} > or > {noformat} > qdmanage QUERY --type=connection{noformat} > This JIRA involves the following tasks > # Add two fields, adminStatus and operStatus to the *connection* entity in > the router schema. Possible connection adminStatues are *enabled* and > *deleted.* Possible operStatuses are *up* > # Modify the router's c-management agent to respond to a UPDATE management > request. A connection id must be provided to update a connection > (adminStatus=deleted). When a client deletes a connection object, the > connection to the peer is terminated by the router. Client will not be > allowed to terminate inter-router connections. > # Add policy control over who is permitted to write adminStatus (add a new > flag at the policy group level called allowAdminStatusUpdate) -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1275) Enable deletion of connections based on connection id
[ https://issues.apache.org/jira/browse/DISPATCH-1275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16799058#comment-16799058 ] ASF GitHub Bot commented on DISPATCH-1275: -- asfgit commented on pull request #467: DISPATCH-1275 - Enabled deletion of connections based on connection i… URL: https://github.com/apache/qpid-dispatch/pull/467 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Enable deletion of connections based on connection id > - > > Key: DISPATCH-1275 > URL: https://issues.apache.org/jira/browse/DISPATCH-1275 > Project: Qpid Dispatch > Issue Type: Bug > Components: Container >Affects Versions: 1.5.0 >Reporter: Ganesh Murthy >Assignee: Ganesh Murthy >Priority: Major > > Sometimes there is a need to delete/kill certain connections on which there > are slow consumers or consumers that won't acknowledge messages. > Add functionality to the router server side code that will allow users to > delete connections based on the connection id. The connection id can be > obtained from the output of-- > {noformat} > qdstat -c{noformat} > or > {noformat} > qdmanage QUERY --type=connection{noformat} > This JIRA involves the following tasks > # Add two fields, adminStatus and operStatus to the *connection* entity in > the router schema. Possible connection adminStatues are *enabled* and > *deleted.* Possible operStatuses are *up* > # Modify the router's c-management agent to respond to a UPDATE management > request. A connection id must be provided to update a connection > (adminStatus=deleted). When a client deletes a connection object, the > connection to the peer is terminated by the router. Client will not be > allowed to terminate inter-router connections. > # Add policy control over who is permitted to write adminStatus (add a new > flag at the policy group level called allowAdminStatusUpdate) -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] asfgit closed pull request #474: NO-JIRA: prevent python system paths from leaking into the test envir…
asfgit closed pull request #474: NO-JIRA: prevent python system paths from leaking into the test envir… URL: https://github.com/apache/qpid-dispatch/pull/474 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Resolved] (DISPATCH-1285) Router crashes occasionally on system_tests_delivery_abort
[ https://issues.apache.org/jira/browse/DISPATCH-1285?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Ross resolved DISPATCH-1285. Resolution: Fixed > Router crashes occasionally on system_tests_delivery_abort > -- > > Key: DISPATCH-1285 > URL: https://issues.apache.org/jira/browse/DISPATCH-1285 > Project: Qpid Dispatch > Issue Type: Bug > Components: Container >Affects Versions: 1.5.0 >Reporter: Ganesh Murthy >Assignee: Ganesh Murthy >Priority: Major > Fix For: 1.6.0 > > > The router occasionally crashes with the following backtrace when running > system_tests_delivery_abort. Dont run the test independently, run it as part > of the test suite using ctest -VV > > {noformat} > (gdb) bt > #0 0x7f3f763d8aaf in qd_link_get_node_context (link=0x7f3f580b40e8) at > /home/gmurthy/opensource/qpid-dispatch/src/container.c:1053 > #1 0x7f3f7642595f in deferred_AMQP_rx_handler (context=0x7f3f580b40e8, > discard=false) at /home/gmurthy/opensource/qpid-dispatch/src/router_node.c:640 > #2 0x7f3f7642bf02 in invoke_deferred_calls (conn=0x1b5a568, > discard=false) at /home/gmurthy/opensource/qpid-dispatch/src/server.c:728 > #3 0x7f3f7642c9c2 in handle (qd_server=0x1a0f5b0, e=0x7f3f58093520, > pn_conn=0x1bf4e40, ctx=0x1b5a568) at > /home/gmurthy/opensource/qpid-dispatch/src/server.c:961 > #4 0x7f3f7642cd2a in thread_run (arg=0x1a0f5b0) at > /home/gmurthy/opensource/qpid-dispatch/src/server.c:1017 > #5 0x7f3f7632258e in start_thread () from /lib64/libpthread.so.0 > #6 0x7f3f75dca6a3 in clone () from /lib64/libc.so.6 > (gdb){noformat} > > Here is the output from the test - > {noformat} > 40: Test command: /usr/bin/python > "/home/gmurthy/opensource/qpid-dispatch/build/tests/run.py" "unit2" "-v" > "system_tests_delivery_abort" > 40: Test timeout computed to be: 1500 > 40: test_01_message_route_truncated_one_router > (system_tests_delivery_abort.RouterTest) ... ok > 40: test_02_message_route_truncated_two_routers > (system_tests_delivery_abort.RouterTest) ... ok > 40: test_03_link_route_truncated_one_router > (system_tests_delivery_abort.RouterTest) ... ok > 40: test_04_link_route_truncated_two_routers > (system_tests_delivery_abort.RouterTest) ... ERROR > 40: test_05_message_route_abort_one_router > (system_tests_delivery_abort.RouterTest) ... ERROR > 40: test_06_message_route_abort_two_routers > (system_tests_delivery_abort.RouterTest) ... ERROR > 40: test_07_multicast_truncate_one_router > (system_tests_delivery_abort.RouterTest) ... ERROR > 40: ERROR > 40: > 40: == > 40: ERROR: test_04_link_route_truncated_two_routers > (system_tests_delivery_abort.RouterTest) > 40: -- > 40: Traceback (most recent call last): > 40: File > "/home/gmurthy/opensource/qpid-dispatch/tests/system_tests_delivery_abort.py", > line 101, in test_04_link_route_truncated_two_routers > 40: test.run() > 40: File > "/home/gmurthy/opensource/qpid-dispatch/tests/system_tests_delivery_abort.py", > line 390, in run > 40: container.run() > 40: File > "/opt/qpid-proton/qpid-proton/lib64/proton/bindings/python/proton/_reactor.py", > line 181, in run > 40: while self.process(): pass > 40: File > "/opt/qpid-proton/qpid-proton/lib64/proton/bindings/python/proton/_reactor.py", > line 240, in process > 40: event.dispatch(self._global_handler) > 40: File > "/opt/qpid-proton/qpid-proton/lib64/proton/bindings/python/proton/_events.py", > line 135, in dispatch > 40: _dispatch(handler, type.method, self) > 40: File > "/opt/qpid-proton/qpid-proton/lib64/proton/bindings/python/proton/_events.py", > line 117, in _dispatch > 40: handler.on_unhandled(method, *args) > 40: File > "/opt/qpid-proton/qpid-proton/lib64/proton/bindings/python/proton/_reactor.py", > line 665, in on_unhandled > 40: event.dispatch(self.base) > 40: File > "/opt/qpid-proton/qpid-proton/lib64/proton/bindings/python/proton/_events.py", > line 135, in dispatch > 40: _dispatch(handler, type.method, self) > 40: File > "/opt/qpid-proton/qpid-proton/lib64/proton/bindings/python/proton/_events.py", > line 115, in _dispatch > 40: m(*args) > 40: File > "/opt/qpid-proton/qpid-proton/lib64/proton/bindings/python/proton/_handlers.py", > line 888, in on_connection_bound > 40: sock = IO.connect(host, int(port)) > 40: File > "/opt/qpid-proton/qpid-proton/lib64/proton/bindings/python/proton/_io.py", > line 48, in connect > 40: return socket.create_connection((host, port)) > 40: File "/usr/lib64/python2.7/socket.py", line 575, in create_connection > 40: raise err > 40: socket.error: [Errno 111] Connection
[jira] [Closed] (PROTON-1996) Proton Client is "stalled" during SASL handshake
[ https://issues.apache.org/jira/browse/PROTON-1996?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Maier closed PROTON-1996. Resolution: Not A Problem > Proton Client is "stalled" during SASL handshake > > > Key: PROTON-1996 > URL: https://issues.apache.org/jira/browse/PROTON-1996 > Project: Qpid Proton > Issue Type: Bug > Components: proton-j >Affects Versions: proton-j-0.25.0, proton-j-0.31.0 >Reporter: Daniel Maier >Priority: Major > > Hi, > When I try to connect with proton vertx client to an AMQP server, the client > seems to come sporadically in some kind of "stalled" state. The logs, see > below, look like the server just not responds anymore which cause the client > to be stalled. There are no more logs regarding SASL handshake. > Used server is qdrouter. > Would it make sense from your point of view to introduce a timeout here? Or > is the responsibility for this in the calling application? > {code} > 08:32:49.412 [vert.x-eventloop-thread-0] DEBUG > o.a.qpid.proton.engine.impl.SaslImpl - Finished writing SASL output. Output > Buffer : java.nio.HeapByteBuffer[pos=8 lim=512 cap=512] > 08:32:49.412 [vert.x-eventloop-thread-0] DEBUG > o.a.qpid.proton.engine.impl.SaslImpl - Finished writing SASL output. Output > Buffer : java.nio.HeapByteBuffer[pos=8 lim=512 cap=512] > 08:32:49.412 [vert.x-eventloop-thread-0] DEBUG > o.a.qpid.proton.engine.impl.SaslImpl - Finished writing SASL output. Output > Buffer : java.nio.HeapByteBuffer[pos=8 lim=512 cap=512] > 08:32:49.412 [vert.x-eventloop-thread-0] DEBUG > o.a.qpid.proton.engine.impl.SaslImpl - Finished writing SASL output. Output > Buffer : java.nio.HeapByteBuffer[pos=0 lim=512 cap=512] > 08:32:49.412 [vert.x-eventloop-thread-0] DEBUG > o.a.qpid.proton.engine.impl.SaslImpl - Finished writing SASL output. Output > Buffer : java.nio.HeapByteBuffer[pos=0 lim=512 cap=512] > 08:32:49.412 [vert.x-eventloop-thread-0] DEBUG > o.a.qpid.proton.engine.impl.SaslImpl - Finished writing SASL output. Output > Buffer : java.nio.HeapByteBuffer[pos=0 lim=512 cap=512] > 08:32:49.412 [vert.x-eventloop-thread-0] DEBUG > io.netty.handler.ssl.SslHandler - [id: 0x429f2c43, L:/100.100.0.6:45982 - > R:xxx.com/xxx:443] HANDSHAKEN: TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 > 08:32:49.418 [vert.x-eventloop-thread-0] DEBUG > o.a.qpid.proton.engine.impl.SaslImpl - SaslImpl [_outcome=PN_SASL_NONE, > state=PN_SASL_IDLE, done=false, role=CLIENT] about to call input. > 08:32:49.418 [vert.x-eventloop-thread-0] TRACE > io.vertx.proton.impl.ProtonTransport - New Proton Event: CONNECTION_INIT > 08:32:49.418 [vert.x-eventloop-thread-0] DEBUG > o.a.qpid.proton.engine.impl.SaslImpl - Finished writing SASL output. Output > Buffer : java.nio.HeapByteBuffer[pos=0 lim=512 cap=512] > 08:32:49.418 [vert.x-eventloop-thread-0] DEBUG > o.a.qpid.proton.engine.impl.SaslImpl - Finished writing SASL output. Output > Buffer : java.nio.HeapByteBuffer[pos=0 lim=512 cap=512] > {code} > Thanks > Daniel -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] asfgit closed pull request #472: Dispatch 1288 1 - policy for outbound connectors
asfgit closed pull request #472: Dispatch 1288 1 - policy for outbound connectors URL: https://github.com/apache/qpid-dispatch/pull/472 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1288) Optionally enforce access policy on connections established by the router
[ https://issues.apache.org/jira/browse/DISPATCH-1288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16799128#comment-16799128 ] ASF subversion and git services commented on DISPATCH-1288: --- Commit 60d2e75f1ace295a68a5d3878997e543b2b79cc5 in qpid-dispatch's branch refs/heads/master from Charles E. Rolke [ https://gitbox.apache.org/repos/asf?p=qpid-dispatch.git;h=60d2e75 ] DISPATCH-1288: Add policy controls for outbound connector connections This closes #472 > Optionally enforce access policy on connections established by the router > - > > Key: DISPATCH-1288 > URL: https://issues.apache.org/jira/browse/DISPATCH-1288 > Project: Qpid Dispatch > Issue Type: Bug > Components: Policy Engine >Affects Versions: 1.5.0 >Reporter: Chuck Rolke >Assignee: Chuck Rolke >Priority: Major > > There are cases where router-initiated connections to external processes > (using connectors) need to have enforcement of access policy from the > external container. > That is, when an outbound connection is created by a connector then there is > nothing to prevent that external remote container from opening links to any > address like, for instance, $management. > In the normal case policy is applied only to inbound connections. This issue > covers the case where policy must be applied to outbound connections. > Like the normal policy case, the connector policy will be applied to incoming > link creation requests initiated by the external container. Outbound link > creation requests initiated by the router are exempt from policy restrictions. > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Resolved] (DISPATCH-1275) Enable deletion of connections based on connection id
[ https://issues.apache.org/jira/browse/DISPATCH-1275?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ganesh Murthy resolved DISPATCH-1275. - Resolution: Fixed Fix Version/s: 1.6.0 > Enable deletion of connections based on connection id > - > > Key: DISPATCH-1275 > URL: https://issues.apache.org/jira/browse/DISPATCH-1275 > Project: Qpid Dispatch > Issue Type: Bug > Components: Container >Affects Versions: 1.5.0 >Reporter: Ganesh Murthy >Assignee: Ganesh Murthy >Priority: Major > Fix For: 1.6.0 > > > Sometimes there is a need to delete/kill certain connections on which there > are slow consumers or consumers that won't acknowledge messages. > Add functionality to the router server side code that will allow users to > delete connections based on the connection id. The connection id can be > obtained from the output of-- > {noformat} > qdstat -c{noformat} > or > {noformat} > qdmanage QUERY --type=connection{noformat} > This JIRA involves the following tasks > # Add two fields, adminStatus and operStatus to the *connection* entity in > the router schema. Possible connection adminStatues are *enabled* and > *deleted.* Possible operStatuses are *up* > # Modify the router's c-management agent to respond to a UPDATE management > request. A connection id must be provided to update a connection > (adminStatus=deleted). When a client deletes a connection object, the > connection to the peer is terminated by the router. Client will not be > allowed to terminate inter-router connections. > # Add policy control over who is permitted to write adminStatus (add a new > flag at the policy group level called allowAdminStatusUpdate) -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Resolved] (DISPATCH-1288) Optionally enforce access policy on connections established by the router
[ https://issues.apache.org/jira/browse/DISPATCH-1288?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Ross resolved DISPATCH-1288. Resolution: Fixed > Optionally enforce access policy on connections established by the router > - > > Key: DISPATCH-1288 > URL: https://issues.apache.org/jira/browse/DISPATCH-1288 > Project: Qpid Dispatch > Issue Type: Bug > Components: Policy Engine >Affects Versions: 1.5.0 >Reporter: Chuck Rolke >Assignee: Chuck Rolke >Priority: Major > Fix For: 1.6.0 > > > There are cases where router-initiated connections to external processes > (using connectors) need to have enforcement of access policy from the > external container. > That is, when an outbound connection is created by a connector then there is > nothing to prevent that external remote container from opening links to any > address like, for instance, $management. > In the normal case policy is applied only to inbound connections. This issue > covers the case where policy must be applied to outbound connections. > Like the normal policy case, the connector policy will be applied to incoming > link creation requests initiated by the external container. Outbound link > creation requests initiated by the router are exempt from policy restrictions. > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] asfgit closed pull request #475: Remove /stand-alone from console install dir.
asfgit closed pull request #475: Remove /stand-alone from console install dir. URL: https://github.com/apache/qpid-dispatch/pull/475 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1300) Remove 'stand-alone' from console install path
[ https://issues.apache.org/jira/browse/DISPATCH-1300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16799156#comment-16799156 ] ASF subversion and git services commented on DISPATCH-1300: --- Commit c57e76b92ef2ead3232dc114c1e8c1565c999db1 in qpid-dispatch's branch refs/heads/master from Ernest Allen [ https://gitbox.apache.org/repos/asf?p=qpid-dispatch.git;h=c57e76b ] DISPATCH-1300 - Removing /stand-alone from console install dir Updated the console-tarball generator to work with the new layout This closes #475 > Remove 'stand-alone' from console install path > -- > > Key: DISPATCH-1300 > URL: https://issues.apache.org/jira/browse/DISPATCH-1300 > Project: Qpid Dispatch > Issue Type: Improvement > Components: Console >Affects Versions: 1.5.0 >Reporter: Ernest Allen >Assignee: Ernest Allen >Priority: Major > Fix For: 1.6.0 > > > Remove 'stand-alone' from the console install directory. This allows upstream > and downstream console locations to match. It also allows the console to be > used without requiring httpRoot to be setup. > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Comment Edited] (DISPATCH-1300) Remove 'stand-alone' from console install path
[ https://issues.apache.org/jira/browse/DISPATCH-1300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16799170#comment-16799170 ] Ernest Allen edited comment on DISPATCH-1300 at 3/22/19 4:43 PM: - [~jdanek] The patch that was checked in included the update to qdrouter.json and the console/stand-alone/README.md. Or at least I thought it did. Looking at the commit it looks like these are not there. I'll investigate. was (Author: eallen): [~jdanek] The patch that was checked in included the update to qdrouter.json and the console/stand-alone/README.md. > Remove 'stand-alone' from console install path > -- > > Key: DISPATCH-1300 > URL: https://issues.apache.org/jira/browse/DISPATCH-1300 > Project: Qpid Dispatch > Issue Type: Improvement > Components: Console >Affects Versions: 1.5.0 >Reporter: Ernest Allen >Assignee: Ernest Allen >Priority: Major > Fix For: 1.6.0 > > > Remove 'stand-alone' from the console install directory. This allows upstream > and downstream console locations to match. It also allows the console to be > used without requiring httpRoot to be setup. > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Comment Edited] (DISPATCH-1300) Remove 'stand-alone' from console install path
[ https://issues.apache.org/jira/browse/DISPATCH-1300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16799167#comment-16799167 ] Jiri Daněk edited comment on DISPATCH-1300 at 3/22/19 4:53 PM: --- This needs a doc update in files {{/python/qpid_dispatch/management/qdrouter.json}} and {{/console/stand-alone/README.md}}. edit: let me reopen this then, although I doubt that is necessary formality... was (Author: jdanek): This needs a doc update in files {{/python/qpid_dispatch/management/qdrouter.json}} and {{/console/stand-alone/README.md}}. > Remove 'stand-alone' from console install path > -- > > Key: DISPATCH-1300 > URL: https://issues.apache.org/jira/browse/DISPATCH-1300 > Project: Qpid Dispatch > Issue Type: Improvement > Components: Console >Affects Versions: 1.5.0 >Reporter: Ernest Allen >Assignee: Ernest Allen >Priority: Major > Fix For: 1.6.0 > > > Remove 'stand-alone' from the console install directory. This allows upstream > and downstream console locations to match. It also allows the console to be > used without requiring httpRoot to be setup. > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] grs commented on issue #475: Remove /stand-alone from console install dir.
grs commented on issue #475: Remove /stand-alone from console install dir. URL: https://github.com/apache/qpid-dispatch/pull/475#issuecomment-475678682 Looks good to me! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Created] (DISPATCH-1300) Remove 'stand-alone' from console install path
Ernest Allen created DISPATCH-1300: -- Summary: Remove 'stand-alone' from console install path Key: DISPATCH-1300 URL: https://issues.apache.org/jira/browse/DISPATCH-1300 Project: Qpid Dispatch Issue Type: Improvement Components: Console Affects Versions: 1.5.0 Reporter: Ernest Allen Assignee: Ernest Allen Remove 'stand-alone' from the console install directory. This allows upstream and downstream console locations to match. It also allows the console to be used without requiring httpRoot to be setup. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Updated] (DISPATCH-1288) Optionally enforce access policy on connections established by the router
[ https://issues.apache.org/jira/browse/DISPATCH-1288?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Ross updated DISPATCH-1288: --- Fix Version/s: 1.6.0 > Optionally enforce access policy on connections established by the router > - > > Key: DISPATCH-1288 > URL: https://issues.apache.org/jira/browse/DISPATCH-1288 > Project: Qpid Dispatch > Issue Type: Bug > Components: Policy Engine >Affects Versions: 1.5.0 >Reporter: Chuck Rolke >Assignee: Chuck Rolke >Priority: Major > Fix For: 1.6.0 > > > There are cases where router-initiated connections to external processes > (using connectors) need to have enforcement of access policy from the > external container. > That is, when an outbound connection is created by a connector then there is > nothing to prevent that external remote container from opening links to any > address like, for instance, $management. > In the normal case policy is applied only to inbound connections. This issue > covers the case where policy must be applied to outbound connections. > Like the normal policy case, the connector policy will be applied to incoming > link creation requests initiated by the external container. Outbound link > creation requests initiated by the router are exempt from policy restrictions. > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Updated] (DISPATCH-1300) Remove 'stand-alone' from console install path
[ https://issues.apache.org/jira/browse/DISPATCH-1300?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Ross updated DISPATCH-1300: --- Fix Version/s: 1.6.0 > Remove 'stand-alone' from console install path > -- > > Key: DISPATCH-1300 > URL: https://issues.apache.org/jira/browse/DISPATCH-1300 > Project: Qpid Dispatch > Issue Type: Improvement > Components: Console >Affects Versions: 1.5.0 >Reporter: Ernest Allen >Assignee: Ernest Allen >Priority: Major > Fix For: 1.6.0 > > > Remove 'stand-alone' from the console install directory. This allows upstream > and downstream console locations to match. It also allows the console to be > used without requiring httpRoot to be setup. > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1300) Remove 'stand-alone' from console install path
[ https://issues.apache.org/jira/browse/DISPATCH-1300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16799170#comment-16799170 ] Ernest Allen commented on DISPATCH-1300: [~jdanek] The patch that was checked in included the update to qdrouter.json and the console/stand-alone/README.md. > Remove 'stand-alone' from console install path > -- > > Key: DISPATCH-1300 > URL: https://issues.apache.org/jira/browse/DISPATCH-1300 > Project: Qpid Dispatch > Issue Type: Improvement > Components: Console >Affects Versions: 1.5.0 >Reporter: Ernest Allen >Assignee: Ernest Allen >Priority: Major > Fix For: 1.6.0 > > > Remove 'stand-alone' from the console install directory. This allows upstream > and downstream console locations to match. It also allows the console to be > used without requiring httpRoot to be setup. > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1300) Remove 'stand-alone' from console install path
[ https://issues.apache.org/jira/browse/DISPATCH-1300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16799192#comment-16799192 ] Jiri Daněk commented on DISPATCH-1300: -- Thanks. Is there a good way to say in {{qdrouterd.json}} that {{httpRootDir}} now has a default? > Remove 'stand-alone' from console install path > -- > > Key: DISPATCH-1300 > URL: https://issues.apache.org/jira/browse/DISPATCH-1300 > Project: Qpid Dispatch > Issue Type: Improvement > Components: Console >Affects Versions: 1.5.0 >Reporter: Ernest Allen >Assignee: Ernest Allen >Priority: Major > Fix For: 1.6.0 > > > Remove 'stand-alone' from the console install directory. This allows upstream > and downstream console locations to match. It also allows the console to be > used without requiring httpRoot to be setup. > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Resolved] (DISPATCH-1299) Provide API access to the already existing safe-reference capability in alloc-pool
[ https://issues.apache.org/jira/browse/DISPATCH-1299?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Ross resolved DISPATCH-1299. Resolution: Fixed > Provide API access to the already existing safe-reference capability in > alloc-pool > -- > > Key: DISPATCH-1299 > URL: https://issues.apache.org/jira/browse/DISPATCH-1299 > Project: Qpid Dispatch > Issue Type: Improvement > Components: Container >Reporter: Ted Ross >Assignee: Ted Ross >Priority: Major > Fix For: 1.6.0 > > > This improvement adds the following two functions to the list of functions > generated per pooled type: > {{typedef ... _sp;}} > {{void set_safe_ptr( *p, _sp *sp);}} > {{ *safe_deref_(_sp sp);}} > A user of this feature can declare or allocate a safe-pointer, set the > safe-pointer using a normal object pointer, and dereference the safe-pointer > later to yield the original normal pointer. If, in the interim time, the > object was freed, the safe-dereference will yield a NULL pointer rather than > a stale (possibly re-used) pointer. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Resolved] (DISPATCH-1300) Remove 'stand-alone' from console install path
[ https://issues.apache.org/jira/browse/DISPATCH-1300?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Ross resolved DISPATCH-1300. Resolution: Fixed > Remove 'stand-alone' from console install path > -- > > Key: DISPATCH-1300 > URL: https://issues.apache.org/jira/browse/DISPATCH-1300 > Project: Qpid Dispatch > Issue Type: Improvement > Components: Console >Affects Versions: 1.5.0 >Reporter: Ernest Allen >Assignee: Ernest Allen >Priority: Major > Fix For: 1.6.0 > > > Remove 'stand-alone' from the console install directory. This allows upstream > and downstream console locations to match. It also allows the console to be > used without requiring httpRoot to be setup. > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Resolved] (DISPATCH-1265) Delivery_abort test causes inter-router session error
[ https://issues.apache.org/jira/browse/DISPATCH-1265?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Ross resolved DISPATCH-1265. Resolution: Fixed > Delivery_abort test causes inter-router session error > - > > Key: DISPATCH-1265 > URL: https://issues.apache.org/jira/browse/DISPATCH-1265 > Project: Qpid Dispatch > Issue Type: Bug > Components: Router Node >Affects Versions: 1.5.0 > Environment: Fedora 29, Python 3. > branch DISPATCH-1264#a5aab9 > ctest -VV -R system_tests_delivery_abort >Reporter: Chuck Rolke >Assignee: Ganesh Murthy >Priority: Critical > Fix For: 1.6.0 > > Attachments: DISPATCH-1265_ctest-log.txt, > DISPATCH-1265_scraped-logs-timeout.html > > > Inter-router connection closes with: > error :"amqp:session:invalid-field" "sequencing error, expected delivery-id > 24, got 23" -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1300) Remove 'stand-alone' from console install path
[ https://issues.apache.org/jira/browse/DISPATCH-1300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16799167#comment-16799167 ] Jiri Daněk commented on DISPATCH-1300: -- This needs a doc update in files {{/python/qpid_dispatch/management/qdrouter.json}} and {{/console/stand-alone/README.md}}. > Remove 'stand-alone' from console install path > -- > > Key: DISPATCH-1300 > URL: https://issues.apache.org/jira/browse/DISPATCH-1300 > Project: Qpid Dispatch > Issue Type: Improvement > Components: Console >Affects Versions: 1.5.0 >Reporter: Ernest Allen >Assignee: Ernest Allen >Priority: Major > Fix For: 1.6.0 > > > Remove 'stand-alone' from the console install directory. This allows upstream > and downstream console locations to match. It also allows the console to be > used without requiring httpRoot to be setup. > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Reopened] (DISPATCH-1300) Remove 'stand-alone' from console install path
[ https://issues.apache.org/jira/browse/DISPATCH-1300?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jiri Daněk reopened DISPATCH-1300: -- > Remove 'stand-alone' from console install path > -- > > Key: DISPATCH-1300 > URL: https://issues.apache.org/jira/browse/DISPATCH-1300 > Project: Qpid Dispatch > Issue Type: Improvement > Components: Console >Affects Versions: 1.5.0 >Reporter: Ernest Allen >Assignee: Ernest Allen >Priority: Major > Fix For: 1.6.0 > > > Remove 'stand-alone' from the console install directory. This allows upstream > and downstream console locations to match. It also allows the console to be > used without requiring httpRoot to be setup. > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1300) Remove 'stand-alone' from console install path
[ https://issues.apache.org/jira/browse/DISPATCH-1300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16799187#comment-16799187 ] ASF subversion and git services commented on DISPATCH-1300: --- Commit e6374ea6c2247c3c8ee360e8c9883cfe7552 in qpid-dispatch's branch refs/heads/master from Ernest Allen [ https://gitbox.apache.org/repos/asf?p=qpid-dispatch.git;h=e6374ea ] DISPATCH-1300 Update documentation and schema for removing 'stand-alone' directory from console install path > Remove 'stand-alone' from console install path > -- > > Key: DISPATCH-1300 > URL: https://issues.apache.org/jira/browse/DISPATCH-1300 > Project: Qpid Dispatch > Issue Type: Improvement > Components: Console >Affects Versions: 1.5.0 >Reporter: Ernest Allen >Assignee: Ernest Allen >Priority: Major > Fix For: 1.6.0 > > > Remove 'stand-alone' from the console install directory. This allows upstream > and downstream console locations to match. It also allows the console to be > used without requiring httpRoot to be setup. > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1300) Remove 'stand-alone' from console install path
[ https://issues.apache.org/jira/browse/DISPATCH-1300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16799198#comment-16799198 ] Ernest Allen commented on DISPATCH-1300: Not sure how to say it, but the default httpRootDir is the cmake install prefix (normally '/usr' but can be overridden) followed by 'share/qpid-dispatch/console'. > Remove 'stand-alone' from console install path > -- > > Key: DISPATCH-1300 > URL: https://issues.apache.org/jira/browse/DISPATCH-1300 > Project: Qpid Dispatch > Issue Type: Improvement > Components: Console >Affects Versions: 1.5.0 >Reporter: Ernest Allen >Assignee: Ernest Allen >Priority: Major > Fix For: 1.6.0 > > > Remove 'stand-alone' from the console install directory. This allows upstream > and downstream console locations to match. It also allows the console to be > used without requiring httpRoot to be setup. > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Updated] (DISPATCH-1288) Optionally enforce access policy on connections established by the router
[ https://issues.apache.org/jira/browse/DISPATCH-1288?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chuck Rolke updated DISPATCH-1288: -- Attachment: DISPATCH-1288.txt > Optionally enforce access policy on connections established by the router > - > > Key: DISPATCH-1288 > URL: https://issues.apache.org/jira/browse/DISPATCH-1288 > Project: Qpid Dispatch > Issue Type: Bug > Components: Policy Engine >Affects Versions: 1.5.0 >Reporter: Chuck Rolke >Assignee: Chuck Rolke >Priority: Major > Fix For: 1.6.0 > > Attachments: DISPATCH-1288.txt > > > There are cases where router-initiated connections to external processes > (using connectors) need to have enforcement of access policy from the > external container. > That is, when an outbound connection is created by a connector then there is > nothing to prevent that external remote container from opening links to any > address like, for instance, $management. > In the normal case policy is applied only to inbound connections. This issue > covers the case where policy must be applied to outbound connections. > Like the normal policy case, the connector policy will be applied to incoming > link creation requests initiated by the external container. Outbound link > creation requests initiated by the router are exempt from policy restrictions. > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org