[GitHub] [qpid-dispatch] codecov-io commented on issue #658: DISPATCH-1540 - Set the pre-settled flag appropriately on a delivery …
codecov-io commented on issue #658: DISPATCH-1540 - Set the pre-settled flag appropriately on a delivery … URL: https://github.com/apache/qpid-dispatch/pull/658#issuecomment-573907457 # [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/658?src=pr=h1) Report > Merging [#658](https://codecov.io/gh/apache/qpid-dispatch/pull/658?src=pr=desc) into [master](https://codecov.io/gh/apache/qpid-dispatch/commit/655145d8e5c9d3a947e407e8bbf08deb13830db3?src=pr=desc) will **increase** coverage by `0.03%`. > The diff coverage is `100%`. [](https://codecov.io/gh/apache/qpid-dispatch/pull/658?src=pr=tree) ```diff @@Coverage Diff @@ ## master #658 +/- ## == + Coverage 86.53% 86.57% +0.03% == Files 91 91 Lines 2065220658 +6 == + Hits1787217884 +12 + Misses 2780 2774 -6 ``` | [Impacted Files](https://codecov.io/gh/apache/qpid-dispatch/pull/658?src=pr=tree) | Coverage Δ | | |---|---|---| | [src/router\_node.c](https://codecov.io/gh/apache/qpid-dispatch/pull/658/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9ub2RlLmM=) | `93.23% <100%> (ø)` | :arrow_up: | | [src/router\_core/delivery.c](https://codecov.io/gh/apache/qpid-dispatch/pull/658/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL2RlbGl2ZXJ5LmM=) | `89.59% <100%> (+0.12%)` | :arrow_up: | | [src/router\_core/forwarder.c](https://codecov.io/gh/apache/qpid-dispatch/pull/658/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL2ZvcndhcmRlci5j) | `93.95% <0%> (-0.47%)` | :arrow_down: | | [src/server.c](https://codecov.io/gh/apache/qpid-dispatch/pull/658/diff?src=pr=tree#diff-c3JjL3NlcnZlci5j) | `86.56% <0%> (+0.12%)` | :arrow_up: | | [src/parse.c](https://codecov.io/gh/apache/qpid-dispatch/pull/658/diff?src=pr=tree#diff-c3JjL3BhcnNlLmM=) | `87.97% <0%> (+0.22%)` | :arrow_up: | | [src/router\_core/transfer.c](https://codecov.io/gh/apache/qpid-dispatch/pull/658/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL3RyYW5zZmVyLmM=) | `94.14% <0%> (+0.24%)` | :arrow_up: | | [src/router\_core/connections.c](https://codecov.io/gh/apache/qpid-dispatch/pull/658/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL2Nvbm5lY3Rpb25zLmM=) | `94.32% <0%> (+0.33%)` | :arrow_up: | | [src/router\_core/route\_tables.c](https://codecov.io/gh/apache/qpid-dispatch/pull/658/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL3JvdXRlX3RhYmxlcy5j) | `76.17% <0%> (+0.49%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/658?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/658?src=pr=footer). Last update [655145d...1e5d89d](https://codecov.io/gh/apache/qpid-dispatch/pull/658?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1540) multiframe presettled messages not included in presettled count on downstream router
[ https://issues.apache.org/jira/browse/DISPATCH-1540?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17014707#comment-17014707 ] ASF GitHub Bot commented on DISPATCH-1540: -- codecov-io commented on issue #658: DISPATCH-1540 - Set the pre-settled flag appropriately on a delivery … URL: https://github.com/apache/qpid-dispatch/pull/658#issuecomment-573907457 # [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/658?src=pr=h1) Report > Merging [#658](https://codecov.io/gh/apache/qpid-dispatch/pull/658?src=pr=desc) into [master](https://codecov.io/gh/apache/qpid-dispatch/commit/655145d8e5c9d3a947e407e8bbf08deb13830db3?src=pr=desc) will **increase** coverage by `0.03%`. > The diff coverage is `100%`. [](https://codecov.io/gh/apache/qpid-dispatch/pull/658?src=pr=tree) ```diff @@Coverage Diff @@ ## master #658 +/- ## == + Coverage 86.53% 86.57% +0.03% == Files 91 91 Lines 2065220658 +6 == + Hits1787217884 +12 + Misses 2780 2774 -6 ``` | [Impacted Files](https://codecov.io/gh/apache/qpid-dispatch/pull/658?src=pr=tree) | Coverage Δ | | |---|---|---| | [src/router\_node.c](https://codecov.io/gh/apache/qpid-dispatch/pull/658/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9ub2RlLmM=) | `93.23% <100%> (ø)` | :arrow_up: | | [src/router\_core/delivery.c](https://codecov.io/gh/apache/qpid-dispatch/pull/658/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL2RlbGl2ZXJ5LmM=) | `89.59% <100%> (+0.12%)` | :arrow_up: | | [src/router\_core/forwarder.c](https://codecov.io/gh/apache/qpid-dispatch/pull/658/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL2ZvcndhcmRlci5j) | `93.95% <0%> (-0.47%)` | :arrow_down: | | [src/server.c](https://codecov.io/gh/apache/qpid-dispatch/pull/658/diff?src=pr=tree#diff-c3JjL3NlcnZlci5j) | `86.56% <0%> (+0.12%)` | :arrow_up: | | [src/parse.c](https://codecov.io/gh/apache/qpid-dispatch/pull/658/diff?src=pr=tree#diff-c3JjL3BhcnNlLmM=) | `87.97% <0%> (+0.22%)` | :arrow_up: | | [src/router\_core/transfer.c](https://codecov.io/gh/apache/qpid-dispatch/pull/658/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL3RyYW5zZmVyLmM=) | `94.14% <0%> (+0.24%)` | :arrow_up: | | [src/router\_core/connections.c](https://codecov.io/gh/apache/qpid-dispatch/pull/658/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL2Nvbm5lY3Rpb25zLmM=) | `94.32% <0%> (+0.33%)` | :arrow_up: | | [src/router\_core/route\_tables.c](https://codecov.io/gh/apache/qpid-dispatch/pull/658/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL3JvdXRlX3RhYmxlcy5j) | `76.17% <0%> (+0.49%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/658?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/658?src=pr=footer). Last update [655145d...1e5d89d](https://codecov.io/gh/apache/qpid-dispatch/pull/658?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > multiframe presettled messages not included in presettled count on downstream > router > - > > Key: DISPATCH-1540 > URL: https://issues.apache.org/jira/browse/DISPATCH-1540 > Project: Qpid Dispatch > Issue Type: Bug > Components: Container >Affects Versions: 1.10.0 >Reporter: Gordon Sim >Assignee: Ganesh Murthy >Priority: Major > Fix For: 1.11.0 > > > Set up two routers connected to each other. Attach receiver to one, sender to > the other and send a large message (such that it is sent as multiple transfer > frames). > > Then look at the inter-router link stats for each router. The downstream > router (i.e. that to which receiver is attached), does not record the > delivery as presettled. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To
[jira] [Commented] (DISPATCH-1513) system_tests_http failing with libwebsockets 3.2 on Fedora 31
[
https://issues.apache.org/jira/browse/DISPATCH-1513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17014644#comment-17014644
]
ASF GitHub Bot commented on DISPATCH-1513:
--
codecov-io commented on issue #660: DISPATCH-1513 - Fixed router crash when
running http requests over ht…
URL: https://github.com/apache/qpid-dispatch/pull/660#issuecomment-573859128
#
[Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/660?src=pr=h1)
Report
> Merging
[#660](https://codecov.io/gh/apache/qpid-dispatch/pull/660?src=pr=desc) into
[master](https://codecov.io/gh/apache/qpid-dispatch/commit/655145d8e5c9d3a947e407e8bbf08deb13830db3?src=pr=desc)
will **increase** coverage by `0.01%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/qpid-dispatch/pull/660?src=pr=tree)
```diff
@@Coverage Diff @@
## master #660 +/- ##
==
+ Coverage 86.53% 86.55% +0.01%
==
Files 91 91
Lines 2065220652
==
+ Hits1787217875 +3
+ Misses 2780 2777 -3
```
| [Impacted
Files](https://codecov.io/gh/apache/qpid-dispatch/pull/660?src=pr=tree) |
Coverage Δ | |
|---|---|---|
|
[src/router\_core/forwarder.c](https://codecov.io/gh/apache/qpid-dispatch/pull/660/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL2ZvcndhcmRlci5j)
| `93.95% <0%> (-0.47%)` | :arrow_down: |
|
[src/router\_core/core\_client\_api.c](https://codecov.io/gh/apache/qpid-dispatch/pull/660/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL2NvcmVfY2xpZW50X2FwaS5j)
| `91.41% <0%> (-0.38%)` | :arrow_down: |
|
[src/router\_node.c](https://codecov.io/gh/apache/qpid-dispatch/pull/660/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9ub2RlLmM=)
| `93.23% <0%> (ø)` | :arrow_up: |
|
[src/router\_core/connections.c](https://codecov.io/gh/apache/qpid-dispatch/pull/660/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL2Nvbm5lY3Rpb25zLmM=)
| `94.1% <0%> (+0.11%)` | :arrow_up: |
|
[src/server.c](https://codecov.io/gh/apache/qpid-dispatch/pull/660/diff?src=pr=tree#diff-c3JjL3NlcnZlci5j)
| `86.56% <0%> (+0.12%)` | :arrow_up: |
|
[src/router\_core/transfer.c](https://codecov.io/gh/apache/qpid-dispatch/pull/660/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL3RyYW5zZmVyLmM=)
| `94.14% <0%> (+0.24%)` | :arrow_up: |
|
[...re/modules/edge\_addr\_tracking/edge\_addr\_tracking.c](https://codecov.io/gh/apache/qpid-dispatch/pull/660/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL21vZHVsZXMvZWRnZV9hZGRyX3RyYWNraW5nL2VkZ2VfYWRkcl90cmFja2luZy5j)
| `87.09% <0%> (+1.61%)` | :arrow_up: |
--
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/660?src=pr=continue).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/660?src=pr=footer).
Last update
[655145d...f43200f](https://codecov.io/gh/apache/qpid-dispatch/pull/660?src=pr=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> system_tests_http failing with libwebsockets 3.2 on Fedora 31
> -
>
> Key: DISPATCH-1513
> URL: https://issues.apache.org/jira/browse/DISPATCH-1513
> Project: Qpid Dispatch
> Issue Type: Bug
> Components: Tests
>Reporter: Ganesh Murthy
>Assignee: Ganesh Murthy
>Priority: Major
> Fix For: 1.11.0
>
>
> Fedora 31 has the latest libwebsockets v 3.2.0 and system_tests_http is
> failing -
> To reproduce
> # cd qpid-dispatch/dockerfiles
> # Open the file Dockerfile-fedora and comment out the line ENTRYPOINT
> ["qdrouterd"] and uncomment CMD ["/bin/bash"]. Save the file.
> # sudo docker build -t fedora31/dispatch --file=Dockerfile-fedora .
> # sudo docker run -i -t fedora31/dispatch
> # cd /main/qpid-dispatch/build
> # ctest -V -R system_tests_http. You will see the following error
> I am commenting out the failing test until the underlying problem is fixed.
> {noformat}
> [root@13552f9cbb69 build]# /usr/bin/python
>
[GitHub] [qpid-dispatch] codecov-io commented on issue #660: DISPATCH-1513 - Fixed router crash when running http requests over ht…
codecov-io commented on issue #660: DISPATCH-1513 - Fixed router crash when running http requests over ht… URL: https://github.com/apache/qpid-dispatch/pull/660#issuecomment-573859128 # [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/660?src=pr=h1) Report > Merging [#660](https://codecov.io/gh/apache/qpid-dispatch/pull/660?src=pr=desc) into [master](https://codecov.io/gh/apache/qpid-dispatch/commit/655145d8e5c9d3a947e407e8bbf08deb13830db3?src=pr=desc) will **increase** coverage by `0.01%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/qpid-dispatch/pull/660?src=pr=tree) ```diff @@Coverage Diff @@ ## master #660 +/- ## == + Coverage 86.53% 86.55% +0.01% == Files 91 91 Lines 2065220652 == + Hits1787217875 +3 + Misses 2780 2777 -3 ``` | [Impacted Files](https://codecov.io/gh/apache/qpid-dispatch/pull/660?src=pr=tree) | Coverage Δ | | |---|---|---| | [src/router\_core/forwarder.c](https://codecov.io/gh/apache/qpid-dispatch/pull/660/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL2ZvcndhcmRlci5j) | `93.95% <0%> (-0.47%)` | :arrow_down: | | [src/router\_core/core\_client\_api.c](https://codecov.io/gh/apache/qpid-dispatch/pull/660/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL2NvcmVfY2xpZW50X2FwaS5j) | `91.41% <0%> (-0.38%)` | :arrow_down: | | [src/router\_node.c](https://codecov.io/gh/apache/qpid-dispatch/pull/660/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9ub2RlLmM=) | `93.23% <0%> (ø)` | :arrow_up: | | [src/router\_core/connections.c](https://codecov.io/gh/apache/qpid-dispatch/pull/660/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL2Nvbm5lY3Rpb25zLmM=) | `94.1% <0%> (+0.11%)` | :arrow_up: | | [src/server.c](https://codecov.io/gh/apache/qpid-dispatch/pull/660/diff?src=pr=tree#diff-c3JjL3NlcnZlci5j) | `86.56% <0%> (+0.12%)` | :arrow_up: | | [src/router\_core/transfer.c](https://codecov.io/gh/apache/qpid-dispatch/pull/660/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL3RyYW5zZmVyLmM=) | `94.14% <0%> (+0.24%)` | :arrow_up: | | [...re/modules/edge\_addr\_tracking/edge\_addr\_tracking.c](https://codecov.io/gh/apache/qpid-dispatch/pull/660/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL21vZHVsZXMvZWRnZV9hZGRyX3RyYWNraW5nL2VkZ2VfYWRkcl90cmFja2luZy5j) | `87.09% <0%> (+1.61%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/660?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/660?src=pr=footer). Last update [655145d...f43200f](https://codecov.io/gh/apache/qpid-dispatch/pull/660?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1513) system_tests_http failing with libwebsockets 3.2 on Fedora 31
[
https://issues.apache.org/jira/browse/DISPATCH-1513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17014626#comment-17014626
]
ASF GitHub Bot commented on DISPATCH-1513:
--
ganeshmurthy commented on pull request #660: DISPATCH-1513 - Fixed router crash
when running http requests over ht…
URL: https://github.com/apache/qpid-dispatch/pull/660
…tps. This fix is available only on systems that are running libwebsockets
version 3.2.0 and above
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> system_tests_http failing with libwebsockets 3.2 on Fedora 31
> -
>
> Key: DISPATCH-1513
> URL: https://issues.apache.org/jira/browse/DISPATCH-1513
> Project: Qpid Dispatch
> Issue Type: Bug
> Components: Tests
>Reporter: Ganesh Murthy
>Assignee: Ganesh Murthy
>Priority: Major
> Fix For: 1.11.0
>
>
> Fedora 31 has the latest libwebsockets v 3.2.0 and system_tests_http is
> failing -
> To reproduce
> # cd qpid-dispatch/dockerfiles
> # Open the file Dockerfile-fedora and comment out the line ENTRYPOINT
> ["qdrouterd"] and uncomment CMD ["/bin/bash"]. Save the file.
> # sudo docker build -t fedora31/dispatch --file=Dockerfile-fedora .
> # sudo docker run -i -t fedora31/dispatch
> # cd /main/qpid-dispatch/build
> # ctest -V -R system_tests_http. You will see the following error
> I am commenting out the failing test until the underlying problem is fixed.
> {noformat}
> [root@13552f9cbb69 build]# /usr/bin/python
> "/main/qpid-dispatch/build/tests/run.py" "-m" "unittest" "-v"
> "system_tests_http.RouterTestHttp.test_https_get"
> test_https_get (system_tests_http.RouterTestHttp) ...
> /main/qpid-dispatch/tests/system_tests_http.py:54: DeprecationWarning:
> cafile, capath and cadefault are deprecated, use a custom context instead.
> http_data = urlopen(url, cafile=cls.ssl_file('ca-certificate.pem'))
> ERROR==
> ERROR: test_https_get (system_tests_http.RouterTestHttp)
> --
> Traceback (most recent call last):
> File "/main/qpid-dispatch/tests/system_tests_http.py", line 252, in
> test_https_get
> self.assert_get("http://localhost:%s; % r.ports[0])
> File "/main/qpid-dispatch/tests/system_tests_http.py", line 83, in
> assert_get
> self.assertEqual(u'HTTP test\n', self.get("%s/system_tests_http.txt" %
> url))
> File "/main/qpid-dispatch/tests/system_tests_http.py", line 54, in get
> http_data = urlopen(url, cafile=cls.ssl_file('ca-certificate.pem'))
> File "/usr/lib64/python3.7/urllib/request.py", line 222, in urlopen
> return opener.open(url, data, timeout)
> File "/usr/lib64/python3.7/urllib/request.py", line 525, in open
> response = self._open(req, data)
> File "/usr/lib64/python3.7/urllib/request.py", line 543, in _open
> '_open', req)
> File "/usr/lib64/python3.7/urllib/request.py", line 503, in _call_chain
> result = func(*args)
> File "/usr/lib64/python3.7/urllib/request.py", line 1345, in http_open
> return self.do_open(http.client.HTTPConnection, req)
> File "/usr/lib64/python3.7/urllib/request.py", line 1320, in do_open
> r = h.getresponse()
> File "/usr/lib64/python3.7/http/client.py", line 1344, in getresponse
> response.begin()
> File "/usr/lib64/python3.7/http/client.py", line 306, in begin
> version, status, reason = self._read_status()
> File "/usr/lib64/python3.7/http/client.py", line 275, in _read_status
> raise RemoteDisconnected("Remote end closed connection without"
> http.client.RemoteDisconnected: Remote end closed connection without
> response--
> Ran 1 test in 0.164s {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] ganeshmurthy opened a new pull request #660: DISPATCH-1513 - Fixed router crash when running http requests over ht…
ganeshmurthy opened a new pull request #660: DISPATCH-1513 - Fixed router crash when running http requests over ht… URL: https://github.com/apache/qpid-dispatch/pull/660 …tps. This fix is available only on systems that are running libwebsockets version 3.2.0 and above This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-8401) [Broker-J] Broker dies when DB connection is lost
[
https://issues.apache.org/jira/browse/QPID-8401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17014413#comment-17014413
]
Robert Godfrey commented on QPID-8401:
--
{quote}Now regarding the current behavior of the broker, note that when the
broker dies this way I end up with a message that stays acquired forever (not
by any client consumer but by the housekeeping task itself). When I restart the
broker this message never gets deleted even though it expired and I can't
consume it either... Shouldn't the message be released when rolling back the
failed dequeue operation?
[https://github.com/apache/qpid-broker-j/blob/master/broker-core/src/main/java/org/apache/qpid/server/queue/AbstractQueue.java#L1852]
{quote}
So acquisition should not be persisted, so when the broker dies and then
restarts the message should not be acquired. In terms of the onRollback in the
code quoted - that logic is for when a transaction is manually rolled back by a
client (not applicable in this case), it is not designed for handling the case
where the broker initiates rollback - in this case the expected behaviour is
that the broker (really should be the virtual host) dies.
> [Broker-J] Broker dies when DB connection is lost
> -
>
> Key: QPID-8401
> URL: https://issues.apache.org/jira/browse/QPID-8401
> Project: Qpid
> Issue Type: Bug
> Components: Broker-J
>Affects Versions: qpid-java-broker-7.1.6
>Reporter: Olivier VERMEULEN
>Priority: Critical
>
> When using a JDBC message store, if the housekeeping task is triggered while
> the DB connection is lost (DB down or network problem) then the Broker dies
> with the stack below.
> This happens when a message expires and the housekeeping task tries to delete
> it from the store while the DB is not accessible. In this case a
> StoreException is thrown but this exception is not catched by the
> Housekeeping task which is only catching ConnectionScopedRuntimeExceptions.
>
> 2019-12-12 16:22:40,671 ERROR [virtualhost-default-pool-3] (o.a.q.s.Main) -
> Uncaught exception, shutting down.
> org.apache.qpid.server.store.StoreException: java.sql.SQLException: JZ006:
> Caught IOException: com.sybase.jdbc4.jdbc.SybConnectionDeadException: JZ0C0:
> Connection is already closed.
> at
> org.apache.qpid.server.store.jdbc.AbstractJDBCMessageStore$JDBCTransaction.(AbstractJDBCMessageStore.java:1153)
> at
> org.apache.qpid.server.store.jdbc.GenericAbstractJDBCMessageStore$RecordedJDBCTransaction.(GenericAbstractJDBCMessageStore.java:122)
> at
> org.apache.qpid.server.store.jdbc.GenericAbstractJDBCMessageStore$RecordedJDBCTransaction.(GenericAbstractJDBCMessageStore.java:118)
> at
> org.apache.qpid.server.store.jdbc.GenericAbstractJDBCMessageStore.newTransaction(GenericAbstractJDBCMessageStore.java:114)
> at
> org.apache.qpid.server.txn.AutoCommitTransaction.dequeue(AutoCommitTransaction.java:87)
> at
> org.apache.qpid.server.queue.AbstractQueue.dequeueEntry(AbstractQueue.java:1780)
> at
> org.apache.qpid.server.queue.AbstractQueue.dequeueEntry(AbstractQueue.java:1775)
> at
> org.apache.qpid.server.queue.AbstractQueue.deleteEntry(AbstractQueue.java:1819)
> at
> org.apache.qpid.server.queue.AbstractQueue.expireEntry(AbstractQueue.java:2354)
> at
> org.apache.qpid.server.queue.AbstractQueue.getNextAvailableEntry(AbstractQueue.java:2236)
> at
> org.apache.qpid.server.queue.AbstractQueue.access$1800(AbstractQueue.java:131)
> at
> org.apache.qpid.server.queue.AbstractQueue$AdvanceConsumersTask.execute(AbstractQueue.java:3712)
> at
> org.apache.qpid.server.virtualhost.HouseKeepingTask$1.run(HouseKeepingTask.java:56)
> at java.security.AccessController.doPrivileged(Native Method)
> at
> org.apache.qpid.server.virtualhost.HouseKeepingTask.run(HouseKeepingTask.java:51)
> at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
> at java.util.concurrent.FutureTask.runAndReset(FutureTask.java:308)
> at
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$301(ScheduledThreadPoolExecutor.java:180)
> at
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:294)
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
> at
> org.apache.qpid.server.bytebuffer.QpidByteBufferFactory.lambda$null$0(QpidByteBufferFactory.java:464)
> at java.lang.Thread.run(Thread.java:748)
> Caused by: java.sql.SQLException: JZ006: Caught IOException:
> com.sybase.jdbc4.jdbc.SybConnectionDeadException: JZ0C0: Connection is
> already closed.
> at
> com.sybase.jdbc4.jdbc.ErrorMessage.createIOEKilledConnEx(ErrorMessage.java:1155)
> at
>
[jira] [Commented] (DISPATCH-1540) multiframe presettled messages not included in presettled count on downstream router
[
https://issues.apache.org/jira/browse/DISPATCH-1540?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17014395#comment-17014395
]
ASF GitHub Bot commented on DISPATCH-1540:
--
kgiusti commented on pull request #658: DISPATCH-1540 - Set the pre-settled
flag appropriately on a delivery …
URL: https://github.com/apache/qpid-dispatch/pull/658#discussion_r365850091
##
File path: src/router_core/delivery.c
##
@@ -201,8 +201,16 @@ void qdr_delivery_remote_state_updated(qdr_core_t *core,
qdr_delivery_t *deliver
}
-qdr_delivery_t *qdr_deliver_continue(qdr_core_t *core,qdr_delivery_t *in_dlv)
+qdr_delivery_t *qdr_deliver_continue(qdr_core_t *core,qdr_delivery_t *in_dlv,
bool settled)
{
+//
+// If the delivery is already pre-settled, don't do anything with the
pre-settled flag.
+//
+// If the in_delivery was not pre-settled, you can go to pre-settled.
+if (! in_dlv->presettled && settled) {
+in_dlv->presettled = settled;
Review comment:
This is (technically) a possible race condition. This method runs under the
I/O thread which should not be modifying qdr_delivery_t state directly.
It would be better to pass along the presettled flag in the action. I
suggest considering changing the existing code to use the action->args.delivery
action structure (adding a pre-settled flag there) instead of the
args.connection structure.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> multiframe presettled messages not included in presettled count on downstream
> router
> -
>
> Key: DISPATCH-1540
> URL: https://issues.apache.org/jira/browse/DISPATCH-1540
> Project: Qpid Dispatch
> Issue Type: Bug
> Components: Container
>Affects Versions: 1.10.0
>Reporter: Gordon Sim
>Assignee: Ganesh Murthy
>Priority: Major
> Fix For: 1.11.0
>
>
> Set up two routers connected to each other. Attach receiver to one, sender to
> the other and send a large message (such that it is sent as multiple transfer
> frames).
>
> Then look at the inter-router link stats for each router. The downstream
> router (i.e. that to which receiver is attached), does not record the
> delivery as presettled.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] kgiusti commented on a change in pull request #658: DISPATCH-1540 - Set the pre-settled flag appropriately on a delivery …
kgiusti commented on a change in pull request #658: DISPATCH-1540 - Set the
pre-settled flag appropriately on a delivery …
URL: https://github.com/apache/qpid-dispatch/pull/658#discussion_r365850091
##
File path: src/router_core/delivery.c
##
@@ -201,8 +201,16 @@ void qdr_delivery_remote_state_updated(qdr_core_t *core,
qdr_delivery_t *deliver
}
-qdr_delivery_t *qdr_deliver_continue(qdr_core_t *core,qdr_delivery_t *in_dlv)
+qdr_delivery_t *qdr_deliver_continue(qdr_core_t *core,qdr_delivery_t *in_dlv,
bool settled)
{
+//
+// If the delivery is already pre-settled, don't do anything with the
pre-settled flag.
+//
+// If the in_delivery was not pre-settled, you can go to pre-settled.
+if (! in_dlv->presettled && settled) {
+in_dlv->presettled = settled;
Review comment:
This is (technically) a possible race condition. This method runs under the
I/O thread which should not be modifying qdr_delivery_t state directly.
It would be better to pass along the presettled flag in the action. I
suggest considering changing the existing code to use the action->args.delivery
action structure (adding a pre-settled flag there) instead of the
args.connection structure.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] asfgit closed pull request #659: NO-JIRA: bump .travis.yml proton version to latest (0.30.0)
asfgit closed pull request #659: NO-JIRA: bump .travis.yml proton version to latest (0.30.0) URL: https://github.com/apache/qpid-dispatch/pull/659 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-8401) [Broker-J] Broker dies when DB connection is lost
[ https://issues.apache.org/jira/browse/QPID-8401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17014250#comment-17014250 ] Olivier VERMEULEN commented on QPID-8401: - If this could be handled at the JDBC level that would be perfect but I don't think that it's possible. If you take Oracle for example, the resiliency is handled by the FCF feature of the UCP connection pool but according to the documentation this requires some retry logic on the client side... I guess I could write my own ConnectionProvider and do some retries if necessary at the level of the getConnection but that would only handle the creation of the connection, what if the DB crashes after getting the connection but before deleting the expired message? Now regarding the current behavior of the broker, note that when the broker dies this way I end up with a message that stays acquired forever (not by any client consumer but by the housekeeping task itself). When I restart the broker this message never gets deleted even though it expired and I can't consume it either... Shouldn't the message be released when rolling back the failed dequeue operation? [https://github.com/apache/qpid-broker-j/blob/master/broker-core/src/main/java/org/apache/qpid/server/queue/AbstractQueue.java#L1852] > [Broker-J] Broker dies when DB connection is lost > - > > Key: QPID-8401 > URL: https://issues.apache.org/jira/browse/QPID-8401 > Project: Qpid > Issue Type: Bug > Components: Broker-J >Affects Versions: qpid-java-broker-7.1.6 >Reporter: Olivier VERMEULEN >Priority: Critical > > When using a JDBC message store, if the housekeeping task is triggered while > the DB connection is lost (DB down or network problem) then the Broker dies > with the stack below. > This happens when a message expires and the housekeeping task tries to delete > it from the store while the DB is not accessible. In this case a > StoreException is thrown but this exception is not catched by the > Housekeeping task which is only catching ConnectionScopedRuntimeExceptions. > > 2019-12-12 16:22:40,671 ERROR [virtualhost-default-pool-3] (o.a.q.s.Main) - > Uncaught exception, shutting down. > org.apache.qpid.server.store.StoreException: java.sql.SQLException: JZ006: > Caught IOException: com.sybase.jdbc4.jdbc.SybConnectionDeadException: JZ0C0: > Connection is already closed. > at > org.apache.qpid.server.store.jdbc.AbstractJDBCMessageStore$JDBCTransaction.(AbstractJDBCMessageStore.java:1153) > at > org.apache.qpid.server.store.jdbc.GenericAbstractJDBCMessageStore$RecordedJDBCTransaction.(GenericAbstractJDBCMessageStore.java:122) > at > org.apache.qpid.server.store.jdbc.GenericAbstractJDBCMessageStore$RecordedJDBCTransaction.(GenericAbstractJDBCMessageStore.java:118) > at > org.apache.qpid.server.store.jdbc.GenericAbstractJDBCMessageStore.newTransaction(GenericAbstractJDBCMessageStore.java:114) > at > org.apache.qpid.server.txn.AutoCommitTransaction.dequeue(AutoCommitTransaction.java:87) > at > org.apache.qpid.server.queue.AbstractQueue.dequeueEntry(AbstractQueue.java:1780) > at > org.apache.qpid.server.queue.AbstractQueue.dequeueEntry(AbstractQueue.java:1775) > at > org.apache.qpid.server.queue.AbstractQueue.deleteEntry(AbstractQueue.java:1819) > at > org.apache.qpid.server.queue.AbstractQueue.expireEntry(AbstractQueue.java:2354) > at > org.apache.qpid.server.queue.AbstractQueue.getNextAvailableEntry(AbstractQueue.java:2236) > at > org.apache.qpid.server.queue.AbstractQueue.access$1800(AbstractQueue.java:131) > at > org.apache.qpid.server.queue.AbstractQueue$AdvanceConsumersTask.execute(AbstractQueue.java:3712) > at > org.apache.qpid.server.virtualhost.HouseKeepingTask$1.run(HouseKeepingTask.java:56) > at java.security.AccessController.doPrivileged(Native Method) > at > org.apache.qpid.server.virtualhost.HouseKeepingTask.run(HouseKeepingTask.java:51) > at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) > at java.util.concurrent.FutureTask.runAndReset(FutureTask.java:308) > at > java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$301(ScheduledThreadPoolExecutor.java:180) > at > java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:294) > at > java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142) > at > java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617) > at > org.apache.qpid.server.bytebuffer.QpidByteBufferFactory.lambda$null$0(QpidByteBufferFactory.java:464) > at java.lang.Thread.run(Thread.java:748) > Caused by: java.sql.SQLException: JZ006: Caught IOException: > com.sybase.jdbc4.jdbc.SybConnectionDeadException: JZ0C0: Connection is > already closed. > at >
[jira] [Created] (QPIDJMS-485) AmqpJmsBytesMessageFacade does not copy the content-type
Jens Kordowski created QPIDJMS-485: -- Summary: AmqpJmsBytesMessageFacade does not copy the content-type Key: QPIDJMS-485 URL: https://issues.apache.org/jira/browse/QPIDJMS-485 Project: Qpid JMS Issue Type: Bug Components: qpid-jms-client Affects Versions: 0.48.0 Reporter: Jens Kordowski AmqpJmsBytesMessageFacade hardcodes the content-type during the copy-operation to application/octet-stream Proposal to copy the content-type as well (in the AmqpJmsMessageFacade) and fall-back to application/octet-stream if no content-type was set I don't see any reason, why the content-type is not copied as well -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
