[jira] [Updated] (DISPATCH-1137) Connection info contains stale pointer to container id
[ https://issues.apache.org/jira/browse/DISPATCH-1137?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robbie Gemmell updated DISPATCH-1137: - Fix Version/s: (was: 2.0.0) > Connection info contains stale pointer to container id > -- > > Key: DISPATCH-1137 > URL: https://issues.apache.org/jira/browse/DISPATCH-1137 > Project: Qpid Dispatch > Issue Type: Bug > Components: Router Node >Affects Versions: 1.3.0 >Reporter: Ken Giusti >Assignee: Ken Giusti >Priority: Major > Fix For: 1.4.0 > > > On connection close the memory pointed to by the container name pointer in > the connection info structure has been freed (as found by valgrind). Need to > keep a copy of the name. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (PROTON-2198) C engine sometimes does not advance link after delivery reject/conn close
[ https://issues.apache.org/jira/browse/PROTON-2198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17113900#comment-17113900 ] Jiri Daněk commented on PROTON-2198: Triage note: {{pn_delivery_settle}} should advance, and it does, usually, but apparently not under load. The delivery being the same (not advanced) is meant that the new delivery is at the same memory address as previous delivery, now disposed off. Which is not necessarily wrong, because proton can (and preferably, should) reuse memory. Dispatch uses memory locations to track deliveries. If necessary, it could use delivery ids instead. > C engine sometimes does not advance link after delivery reject/conn close > - > > Key: PROTON-2198 > URL: https://issues.apache.org/jira/browse/PROTON-2198 > Project: Qpid Proton > Issue Type: Bug > Components: proton-c >Affects Versions: proton-c-0.30.0 > Environment: Fedora 29, qpid-dispatch master @fc284e00, self test > system_tests_policy_oversize_basic, test_40 >Reporter: Charles E. Rolke >Priority: Major > Attachments: proton-2198.txt > > > Intermittently qpid-dispatch receive handlers see consecutive deliveries with > the same delivery reported from pn_link_current(). -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (PROTON-2193) Python MessagingHandler does not call on_connection_error on error
[ https://issues.apache.org/jira/browse/PROTON-2193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17113902#comment-17113902 ] Jiri Daněk commented on PROTON-2193: If reconnect is disabled, the Python client should then report an error. > Python MessagingHandler does not call on_connection_error on error > -- > > Key: PROTON-2193 > URL: https://issues.apache.org/jira/browse/PROTON-2193 > Project: Qpid Proton > Issue Type: Bug > Components: python-binding >Affects Versions: proton-c-0.30.0 >Reporter: Charles E. Rolke >Priority: Major > > When the client receives an AMQP close with a condition then the > on_connection_error handler is not called. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (PROTON-2183) [cpp client] No messaging_handler callback for aborted messages
[ https://issues.apache.org/jira/browse/PROTON-2183?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17113904#comment-17113904 ] Jiri Daněk commented on PROTON-2183: Triage note: missing feature, cpp does not handle aborted messages (it would have to drop the message and update credit, unless draining). > [cpp client] No messaging_handler callback for aborted messages > --- > > Key: PROTON-2183 > URL: https://issues.apache.org/jira/browse/PROTON-2183 > Project: Qpid Proton > Issue Type: Bug > Components: cpp-binding >Affects Versions: proton-c-0.30.0 >Reporter: Charles E. Rolke >Priority: Major > Attachments: PROTON-2183-send-receive-console.log > > > A cpp receiver throws "receiver read failure" when an aborted message is > received. > A client based on: > {{ class simple_recv : public proton::messaging_handler}} > does not get called at (on_transport_error, on_connection_error, > on_session_error, on_sender_error, on_receiver_error, on_error). The > exception is thrown back to main() and the client application has no way to > intercept it. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Closed] (PROTON-2173) [c, cpp] Idle connections closed with TCP FIN cause framing errors
[ https://issues.apache.org/jira/browse/PROTON-2173?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jiri Daněk closed PROTON-2173. -- Resolution: Not A Bug > [c, cpp] Idle connections closed with TCP FIN cause framing errors > -- > > Key: PROTON-2173 > URL: https://issues.apache.org/jira/browse/PROTON-2173 > Project: Qpid Proton > Issue Type: Bug > Components: proton-c >Affects Versions: proton-c-0.30.0 >Reporter: Charles E. Rolke >Priority: Major > > This issue was mis-characterized in PROTON-2162 but the same basic problem > stands. When a completely idle connection is closed with an incoming TCP FIN > then the connection emits a close frame with a framing error. This is a > normal, clean connection close and there is no framing error. > Demonstrate this using cpp examples direct_recv and simple_send. > * modify simple_send on_sendable() so that it just returns without sending > anything > * run direct_recv > * run simple_send > * let it sit. There is no traffic. > * kill simple_end by pid with dash 9 > * simple_send prints "killed" > * direct_recv prints "amqp:connection:framing-error: connection aborted" > Wireshark shows three frames over the wire: > * --> 5672 FIN > * <-- 5672 CLOSE amqp:connection:framing-error:connection aborted > * --> 5672 RST > This is an abnormal connection closure. One end has sent a FIN and then later > the other end sends a message to it. The OS should never have to reply to > that message with a RST. > AmqpNetLite gets it right. Run examples PeerToPeer.Server and .Client with > client modified never to send anything but just open the connection and sit > there. Then kill the client. Over the wire: > * --> 5672 FIN > * <-- 5672 FIN ACK > * --> 5672 ACK > This is a normal connection closure TCP handshake. The server prints: > Exception: The transport 'ListenerTcpTransport' is closed. > Dispatch customers are asking why there are so many framing errors even when > running common utilities like qdstat. And there are so many framing errors > reported that if a real framing error ever shows up it will never be seen. > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Reopened] (PROTON-2173) [c, cpp] Idle connections closed with TCP FIN cause framing errors
[ https://issues.apache.org/jira/browse/PROTON-2173?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jiri Daněk reopened PROTON-2173: > [c, cpp] Idle connections closed with TCP FIN cause framing errors > -- > > Key: PROTON-2173 > URL: https://issues.apache.org/jira/browse/PROTON-2173 > Project: Qpid Proton > Issue Type: Bug > Components: proton-c >Affects Versions: proton-c-0.30.0 >Reporter: Charles E. Rolke >Priority: Major > > This issue was mis-characterized in PROTON-2162 but the same basic problem > stands. When a completely idle connection is closed with an incoming TCP FIN > then the connection emits a close frame with a framing error. This is a > normal, clean connection close and there is no framing error. > Demonstrate this using cpp examples direct_recv and simple_send. > * modify simple_send on_sendable() so that it just returns without sending > anything > * run direct_recv > * run simple_send > * let it sit. There is no traffic. > * kill simple_end by pid with dash 9 > * simple_send prints "killed" > * direct_recv prints "amqp:connection:framing-error: connection aborted" > Wireshark shows three frames over the wire: > * --> 5672 FIN > * <-- 5672 CLOSE amqp:connection:framing-error:connection aborted > * --> 5672 RST > This is an abnormal connection closure. One end has sent a FIN and then later > the other end sends a message to it. The OS should never have to reply to > that message with a RST. > AmqpNetLite gets it right. Run examples PeerToPeer.Server and .Client with > client modified never to send anything but just open the connection and sit > there. Then kill the client. Over the wire: > * --> 5672 FIN > * <-- 5672 FIN ACK > * --> 5672 ACK > This is a normal connection closure TCP handshake. The server prints: > Exception: The transport 'ListenerTcpTransport' is closed. > Dispatch customers are asking why there are so many framing errors even when > running common utilities like qdstat. And there are so many framing errors > reported that if a real framing error ever shows up it will never be seen. > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Updated] (PROTON-2128) Python client crash sending aborted messages
[ https://issues.apache.org/jira/browse/PROTON-2128?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jiri Daněk updated PROTON-2128: --- Description: This issue was originally reported under DISPATCH-1464 (and previously reported under PROTON-2042, now resolved as a duplicate) Dispatch self tests have an intermittent failure: {noformat} 41: test_05_message_route_abort_one_router (system_tests_delivery_abort.RouterTest) ... python: /home/chug/git/qpid-proton/c/src/core/engine.c:691: pni_add_work: Assertion `!delivery->local.settled' failed. 1/1 Test #41: system_tests_delivery_abort ..Child aborted***Exception: 4.47 sec {noformat} {noformat} The failure is an assert with the assumption that the delivery must not be settled. The failing code is handling a SENDER link. The suspect here is interaction with the abort processing which spontaneously settles an outgoing delivery from the client side. The message is not presettled and there is no settlement over the wire. Spontaneous settlement may prove the assert to be overly aggressive: sometimes deliveries may be settled in pni_add_work(). Maybe the assertion could be changed to allow delivery.local.settled to be true but only if delivery.aborted is also true. Core dump backtraces to be added shortly. was: This issue was originally reported under DISPATCH-1464 (and previously reported under PROTON-2042, now resolved as a duplicate) Dispatch self tests have an intermittent failure: {nofornat} 41: test_05_message_route_abort_one_router (system_tests_delivery_abort.RouterTest) ... python: /home/chug/git/qpid-proton/c/src/core/engine.c:691: pni_add_work: Assertion `!delivery->local.settled' failed. 1/1 Test #41: system_tests_delivery_abort ..Child aborted***Exception: 4.47 sec {noformat} The failure is an assert with the assumption that the delivery must not be settled. The failing code is handling a SENDER link. The suspect here is interaction with the abort processing which spontaneously settles an outgoing delivery from the client side. The message is not presettled and there is no settlement over the wire. Spontaneous settlement may prove the assert to be overly aggressive: sometimes deliveries may be settled in pni_add_work(). Maybe the assertion could be changed to allow delivery.local.settled to be true but only if delivery.aborted is also true. Core dump backtraces to be added shortly. > Python client crash sending aborted messages > > > Key: PROTON-2128 > URL: https://issues.apache.org/jira/browse/PROTON-2128 > Project: Qpid Proton > Issue Type: Bug > Components: python-binding >Affects Versions: proton-c-0.29.0 > Environment: Fedora 29; dispatch master=2efbd; proton master or 0.29 > release >Reporter: Charles E. Rolke >Priority: Major > Attachments: PROTON-2128-reproducer.zip, > PROTON-2128_DISPATCH-1464-gdb-bt.txt, PROTON-2128_DISPATCH-1464-gdb-py-bt.txt > > > This issue was originally reported under DISPATCH-1464 (and previously > reported under PROTON-2042, now resolved as a duplicate) > Dispatch self tests have an intermittent failure: > {noformat} > 41: test_05_message_route_abort_one_router > (system_tests_delivery_abort.RouterTest) > ... python: /home/chug/git/qpid-proton/c/src/core/engine.c:691: > pni_add_work: Assertion `!delivery->local.settled' failed. > 1/1 Test #41: system_tests_delivery_abort ..Child aborted***Exception: > 4.47 sec > {noformat} > {noformat} > The failure is an assert with the assumption that the delivery must not be > settled. The failing code is handling a SENDER link. > The suspect here is interaction with the abort processing which spontaneously > settles an outgoing delivery from the client side. The message is not > presettled and there is no settlement over the wire. > Spontaneous settlement may prove the assert to be overly aggressive: > sometimes deliveries may be settled in pni_add_work(). Maybe the assertion > could be changed to allow delivery.local.settled to be true but only if > delivery.aborted is also true. > Core dump backtraces to be added shortly. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Updated] (PROTON-2128) Python client crash sending aborted messages
[ https://issues.apache.org/jira/browse/PROTON-2128?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jiri Daněk updated PROTON-2128: --- Description: This issue was originally reported under DISPATCH-1464 (and previously reported under PROTON-2042, now resolved as a duplicate) Dispatch self tests have an intermittent failure: {nofornat} 41: test_05_message_route_abort_one_router (system_tests_delivery_abort.RouterTest) ... python: /home/chug/git/qpid-proton/c/src/core/engine.c:691: pni_add_work: Assertion `!delivery->local.settled' failed. 1/1 Test #41: system_tests_delivery_abort ..Child aborted***Exception: 4.47 sec {noformat} The failure is an assert with the assumption that the delivery must not be settled. The failing code is handling a SENDER link. The suspect here is interaction with the abort processing which spontaneously settles an outgoing delivery from the client side. The message is not presettled and there is no settlement over the wire. Spontaneous settlement may prove the assert to be overly aggressive: sometimes deliveries may be settled in pni_add_work(). Maybe the assertion could be changed to allow delivery.local.settled to be true but only if delivery.aborted is also true. Core dump backtraces to be added shortly. was: This issue was originally reported under DISPATCH-1464 (and previously reported under PROTON-2042, now resolved as a duplicate) Dispatch self tests have an intermittent failure: {{ 41: test_05_message_route_abort_one_router (system_tests_delivery_abort.RouterTest) ... python: /home/chug/git/qpid-proton/c/src/core/engine.c:691: pni_add_work: Assertion `!delivery->local.settled' failed. 1/1 Test #41: system_tests_delivery_abort ..Child aborted***Exception: 4.47 sec }} The failure is an assert with the assumption that the delivery must not be settled. The failing code is handling a SENDER link. The suspect here is interaction with the abort processing which spontaneously settles an outgoing delivery from the client side. The message is not presettled and there is no settlement over the wire. Spontaneous settlement may prove the assert to be overly aggressive: sometimes deliveries may be settled in pni_add_work(). Maybe the assertion could be changed to allow delivery.local.settled to be true but only if delivery.aborted is also true. Core dump backtraces to be added shortly. > Python client crash sending aborted messages > > > Key: PROTON-2128 > URL: https://issues.apache.org/jira/browse/PROTON-2128 > Project: Qpid Proton > Issue Type: Bug > Components: python-binding >Affects Versions: proton-c-0.29.0 > Environment: Fedora 29; dispatch master=2efbd; proton master or 0.29 > release >Reporter: Charles E. Rolke >Priority: Major > Attachments: PROTON-2128-reproducer.zip, > PROTON-2128_DISPATCH-1464-gdb-bt.txt, PROTON-2128_DISPATCH-1464-gdb-py-bt.txt > > > This issue was originally reported under DISPATCH-1464 (and previously > reported under PROTON-2042, now resolved as a duplicate) > Dispatch self tests have an intermittent failure: > {nofornat} > 41: test_05_message_route_abort_one_router > (system_tests_delivery_abort.RouterTest) > ... python: /home/chug/git/qpid-proton/c/src/core/engine.c:691: > pni_add_work: Assertion `!delivery->local.settled' failed. > 1/1 Test #41: system_tests_delivery_abort ..Child aborted***Exception: > 4.47 sec > {noformat} > The failure is an assert with the assumption that the delivery must not be > settled. The failing code is handling a SENDER link. > The suspect here is interaction with the abort processing which spontaneously > settles an outgoing delivery from the client side. The message is not > presettled and there is no settlement over the wire. > Spontaneous settlement may prove the assert to be overly aggressive: > sometimes deliveries may be settled in pni_add_work(). Maybe the assertion > could be changed to allow delivery.local.settled to be true but only if > delivery.aborted is also true. > Core dump backtraces to be added shortly. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Updated] (PROTON-2128) Python client crash sending aborted messages
[ https://issues.apache.org/jira/browse/PROTON-2128?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jiri Daněk updated PROTON-2128: --- Description: This issue was originally reported under DISPATCH-1464 (and previously reported under PROTON-2042, now resolved as a duplicate) Dispatch self tests have an intermittent failure: {noformat} 41: test_05_message_route_abort_one_router (system_tests_delivery_abort.RouterTest) ... python: /home/chug/git/qpid-proton/c/src/core/engine.c:691: pni_add_work: Assertion `!delivery->local.settled' failed. 1/1 Test #41: system_tests_delivery_abort ..Child aborted***Exception: 4.47 sec {noformat} The failure is an assert with the assumption that the delivery must not be settled. The failing code is handling a SENDER link. The suspect here is interaction with the abort processing which spontaneously settles an outgoing delivery from the client side. The message is not presettled and there is no settlement over the wire. Spontaneous settlement may prove the assert to be overly aggressive: sometimes deliveries may be settled in pni_add_work(). Maybe the assertion could be changed to allow delivery.local.settled to be true but only if delivery.aborted is also true. Core dump backtraces to be added shortly. was: This issue was originally reported under DISPATCH-1464 (and previously reported under PROTON-2042, now resolved as a duplicate) Dispatch self tests have an intermittent failure: {noformat} 41: test_05_message_route_abort_one_router (system_tests_delivery_abort.RouterTest) ... python: /home/chug/git/qpid-proton/c/src/core/engine.c:691: pni_add_work: Assertion `!delivery->local.settled' failed. 1/1 Test #41: system_tests_delivery_abort ..Child aborted***Exception: 4.47 sec {noformat} {noformat} The failure is an assert with the assumption that the delivery must not be settled. The failing code is handling a SENDER link. The suspect here is interaction with the abort processing which spontaneously settles an outgoing delivery from the client side. The message is not presettled and there is no settlement over the wire. Spontaneous settlement may prove the assert to be overly aggressive: sometimes deliveries may be settled in pni_add_work(). Maybe the assertion could be changed to allow delivery.local.settled to be true but only if delivery.aborted is also true. Core dump backtraces to be added shortly. > Python client crash sending aborted messages > > > Key: PROTON-2128 > URL: https://issues.apache.org/jira/browse/PROTON-2128 > Project: Qpid Proton > Issue Type: Bug > Components: python-binding >Affects Versions: proton-c-0.29.0 > Environment: Fedora 29; dispatch master=2efbd; proton master or 0.29 > release >Reporter: Charles E. Rolke >Priority: Major > Attachments: PROTON-2128-reproducer.zip, > PROTON-2128_DISPATCH-1464-gdb-bt.txt, PROTON-2128_DISPATCH-1464-gdb-py-bt.txt > > > This issue was originally reported under DISPATCH-1464 (and previously > reported under PROTON-2042, now resolved as a duplicate) > Dispatch self tests have an intermittent failure: > {noformat} > 41: test_05_message_route_abort_one_router > (system_tests_delivery_abort.RouterTest) > ... python: /home/chug/git/qpid-proton/c/src/core/engine.c:691: > pni_add_work: Assertion `!delivery->local.settled' failed. > 1/1 Test #41: system_tests_delivery_abort ..Child aborted***Exception: > 4.47 sec > {noformat} > The failure is an assert with the assumption that the delivery must not be > settled. The failing code is handling a SENDER link. > The suspect here is interaction with the abort processing which spontaneously > settles an outgoing delivery from the client side. The message is not > presettled and there is no settlement over the wire. > Spontaneous settlement may prove the assert to be overly aggressive: > sometimes deliveries may be settled in pni_add_work(). Maybe the assertion > could be changed to allow delivery.local.settled to be true but only if > delivery.aborted is also true. > Core dump backtraces to be added shortly. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Created] (DISPATCH-1666) Self test system detects and reports crashed qdrouterd instances
Charles E. Rolke created DISPATCH-1666: -- Summary: Self test system detects and reports crashed qdrouterd instances Key: DISPATCH-1666 URL: https://issues.apache.org/jira/browse/DISPATCH-1666 Project: Qpid Dispatch Issue Type: Improvement Components: Tests Affects Versions: 1.12.0 Reporter: Charles E. Rolke When a *TestCase* creates a router through *cls.tester.qdrouterd* then the test framework could detect that the router is no longer running normally and fail the test with a "this router has exited" message. When a router crashes there may be a series of test failure messages as in DISPATCH-1660. Yes the tests failed and yes the test timed out. But the most important thing that happened is that a router crashed with an assert. With a notification that there is a crash then debug focus can switch immediately to generating a usable core dump and getting a backtrace in the environment where the test has failed. The responsibility of getting the dump and backtrace might then be shared by CI administrators and not fall back to the developer who wrote the self test. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1665) Add libwebsockets-dev library to travis
[ https://issues.apache.org/jira/browse/DISPATCH-1665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17114035#comment-17114035 ] Ganesh Murthy commented on DISPATCH-1665: - Temporarily moving this to backlog > Add libwebsockets-dev library to travis > --- > > Key: DISPATCH-1665 > URL: https://issues.apache.org/jira/browse/DISPATCH-1665 > Project: Qpid Dispatch > Issue Type: Bug > Components: Tests, Tools >Affects Versions: 1.12.0 >Reporter: Ganesh Murthy >Assignee: Ganesh Murthy >Priority: Major > Fix For: 2.0.0 > > > The travis build does not install the libwebsockets library. Install it to > see what version is being pulled down -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Updated] (DISPATCH-1665) Add libwebsockets-dev library to travis
[ https://issues.apache.org/jira/browse/DISPATCH-1665?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ganesh Murthy updated DISPATCH-1665: Fix Version/s: (was: 2.0.0) Backlog > Add libwebsockets-dev library to travis > --- > > Key: DISPATCH-1665 > URL: https://issues.apache.org/jira/browse/DISPATCH-1665 > Project: Qpid Dispatch > Issue Type: Bug > Components: Tests, Tools >Affects Versions: 1.12.0 >Reporter: Ganesh Murthy >Assignee: Ganesh Murthy >Priority: Major > Fix For: Backlog > > > The travis build does not install the libwebsockets library. Install it to > see what version is being pulled down -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Created] (DISPATCH-1667) Increase minimum required LibWebSockets version from 2.1.0 to 2.4.2
Ganesh Murthy created DISPATCH-1667: --- Summary: Increase minimum required LibWebSockets version from 2.1.0 to 2.4.2 Key: DISPATCH-1667 URL: https://issues.apache.org/jira/browse/DISPATCH-1667 Project: Qpid Dispatch Issue Type: Improvement Components: Container Affects Versions: 1.12.0 Reporter: Ganesh Murthy Assignee: Ganesh Murthy LibWebSockets v2.1.0 was released on 2016-10-06 and is quite old. Move to a more recent version 2.4.2 which was released on 2018-03-07. 2.4.2 is a stable version and contains features like allowing deleting http listener ports on demand. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1667) Increase minimum required LibWebSockets version from 2.1.0 to 2.4.2
[ https://issues.apache.org/jira/browse/DISPATCH-1667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17114063#comment-17114063 ] Robbie Gemmell commented on DISPATCH-1667: -- So this blocks or is required by DISPATCH-1646? > Increase minimum required LibWebSockets version from 2.1.0 to 2.4.2 > --- > > Key: DISPATCH-1667 > URL: https://issues.apache.org/jira/browse/DISPATCH-1667 > Project: Qpid Dispatch > Issue Type: Improvement > Components: Container >Affects Versions: 1.12.0 >Reporter: Ganesh Murthy >Assignee: Ganesh Murthy >Priority: Major > > LibWebSockets v2.1.0 was released on 2016-10-06 and is quite old. Move to a > more recent version 2.4.2 which was released on 2018-03-07. > 2.4.2 is a stable version and contains features like allowing deleting http > listener ports on demand. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Resolved] (PROTON-2198) C engine sometimes does not advance link after delivery reject/conn close
[ https://issues.apache.org/jira/browse/PROTON-2198?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Charles E. Rolke resolved PROTON-2198. -- Resolution: Not A Problem After dispatch aborts a delivery the pn_delivery_t is settled and the pn_delivery_t structure is available to be used for a different delivery. Dispatch still uses the address of a pn_delivery_t to have a 1-to-1 correspondence with a dispatch delivery. After dispatch spontaneously aborts a delivery then no new deliveries are allowed on the link and the pn_delivery_t address reuse problem is avoided. This issue is and was never a problem for aborts that dispatch received on a link from a connected client. > C engine sometimes does not advance link after delivery reject/conn close > - > > Key: PROTON-2198 > URL: https://issues.apache.org/jira/browse/PROTON-2198 > Project: Qpid Proton > Issue Type: Bug > Components: proton-c >Affects Versions: proton-c-0.30.0 > Environment: Fedora 29, qpid-dispatch master @fc284e00, self test > system_tests_policy_oversize_basic, test_40 >Reporter: Charles E. Rolke >Priority: Major > Attachments: proton-2198.txt > > > Intermittently qpid-dispatch receive handlers see consecutive deliveries with > the same delivery reported from pn_link_current(). -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1667) Increase minimum required LibWebSockets version from 2.1.0 to 2.4.2
[ https://issues.apache.org/jira/browse/DISPATCH-1667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17114151#comment-17114151 ] Ganesh Murthy commented on DISPATCH-1667: - The fix for DISPATCH-1646 requires at least LibWebSockets 2.3.0. LibWebSockets 2.4.2 is known to be a stable version. Here is a list of default LWS versions in the following OSes - CentOS 6 No LibWebSockets RHEL 6 LibWebSockets: 2.1.0 (LWS 2.4.2 is available to upgrade) CentOS 7 LibWebSockets: 3.0.1 RHEL 7 LibWebSockets: 2.1.0 (LWS 2.4.2 is available to upgrade) CentOS 8 LibWebSockets: 3.0.1 Ubuntu:Xenial LibWebSockets: 1.7.0 Ubuntu:Bionic LibWebSockets 2.0.3 Ubuntu:latest LibWebSockets 3.2.0 Since RHEL 6 and RHEL 7 can upgrade to LWS 2.4.2, I proposed increasing the least LWS version to 2.4.2. > Increase minimum required LibWebSockets version from 2.1.0 to 2.4.2 > --- > > Key: DISPATCH-1667 > URL: https://issues.apache.org/jira/browse/DISPATCH-1667 > Project: Qpid Dispatch > Issue Type: Improvement > Components: Container >Affects Versions: 1.12.0 >Reporter: Ganesh Murthy >Assignee: Ganesh Murthy >Priority: Major > > LibWebSockets v2.1.0 was released on 2016-10-06 and is quite old. Move to a > more recent version 2.4.2 which was released on 2018-03-07. > 2.4.2 is a stable version and contains features like allowing deleting http > listener ports on demand. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1667) Increase minimum required LibWebSockets version from 2.1.0 to 2.4.2
[ https://issues.apache.org/jira/browse/DISPATCH-1667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17114193#comment-17114193 ] Robbie Gemmell commented on DISPATCH-1667: -- {quote} The fix for DISPATCH-1646 requires at least LibWebSockets 2.3.0. {quote} Ok. Mainly I was prodding if maybe the JIRAs should be linked, given it sounds like DISPATCH-1646 effectively already raised the minimum to 2.3.0 but without actually enforcing it as this presumably will. > Increase minimum required LibWebSockets version from 2.1.0 to 2.4.2 > --- > > Key: DISPATCH-1667 > URL: https://issues.apache.org/jira/browse/DISPATCH-1667 > Project: Qpid Dispatch > Issue Type: Improvement > Components: Container >Affects Versions: 1.12.0 >Reporter: Ganesh Murthy >Assignee: Ganesh Murthy >Priority: Major > > LibWebSockets v2.1.0 was released on 2016-10-06 and is quite old. Move to a > more recent version 2.4.2 which was released on 2018-03-07. > 2.4.2 is a stable version and contains features like allowing deleting http > listener ports on demand. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1667) Increase minimum required LibWebSockets version from 2.1.0 to 2.4.2
[ https://issues.apache.org/jira/browse/DISPATCH-1667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17114225#comment-17114225 ] Ganesh Murthy commented on DISPATCH-1667: - Always appreciate the prodding and yes, this Jira is a placeholder which we will use to increase the min version of LWS to 2.4.2 and yes DISPATCH-1646 effectively raised it to 2.3.0. I think we should link the JIRAs. I will do that. Thanks. > Increase minimum required LibWebSockets version from 2.1.0 to 2.4.2 > --- > > Key: DISPATCH-1667 > URL: https://issues.apache.org/jira/browse/DISPATCH-1667 > Project: Qpid Dispatch > Issue Type: Improvement > Components: Container >Affects Versions: 1.12.0 >Reporter: Ganesh Murthy >Assignee: Ganesh Murthy >Priority: Major > > LibWebSockets v2.1.0 was released on 2016-10-06 and is quite old. Move to a > more recent version 2.4.2 which was released on 2018-03-07. > 2.4.2 is a stable version and contains features like allowing deleting http > listener ports on demand. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Created] (PROTON-2227) restore some old decode-error field handling behaviour
Robbie Gemmell created PROTON-2227: -- Summary: restore some old decode-error field handling behaviour Key: PROTON-2227 URL: https://issues.apache.org/jira/browse/PROTON-2227 Project: Qpid Proton Issue Type: Bug Components: proton-j Affects Versions: proton-j-0.33.4 Reporter: Robbie Gemmell Assignee: Robbie Gemmell Fix For: proton-j-0.34.0 When some rework around decoding/encoding certain types was optimised in PROTON-1708 away from using the more generic type handling, to using very frame-specific handling for certain hot cases (e.g Flow, Transfer, Disposition), some of the outer behaviours around mandatory fields changed. Some additional checks/handling the older type code did should be added to the newer bits to restore those behaviours, which can make things clearer when certain decode issues occur. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (PROTON-2227) restore some old decode-error field handling behaviour
[ https://issues.apache.org/jira/browse/PROTON-2227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17114229#comment-17114229 ] ASF subversion and git services commented on PROTON-2227: - Commit b95d89297de36401fb8cfbb56064f29568abcd49 in qpid-proton-j's branch refs/heads/master from Robbie Gemmell [ https://gitbox.apache.org/repos/asf?p=qpid-proton-j.git;h=b95d892 ] PROTON-2227: restore behaviour around decode errors in Flow/Transfer/Disposition types > restore some old decode-error field handling behaviour > -- > > Key: PROTON-2227 > URL: https://issues.apache.org/jira/browse/PROTON-2227 > Project: Qpid Proton > Issue Type: Bug > Components: proton-j >Affects Versions: proton-j-0.33.4 >Reporter: Robbie Gemmell >Assignee: Robbie Gemmell >Priority: Major > Fix For: proton-j-0.34.0 > > > When some rework around decoding/encoding certain types was optimised in > PROTON-1708 away from using the more generic type handling, to using very > frame-specific handling for certain hot cases (e.g Flow, Transfer, > Disposition), some of the outer behaviours around mandatory fields changed. > Some additional checks/handling the older type code did should be added to > the newer bits to restore those behaviours, which can make things clearer > when certain decode issues occur. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Resolved] (PROTON-2227) restore some old decode-error field handling behaviour
[ https://issues.apache.org/jira/browse/PROTON-2227?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robbie Gemmell resolved PROTON-2227. Resolution: Fixed > restore some old decode-error field handling behaviour > -- > > Key: PROTON-2227 > URL: https://issues.apache.org/jira/browse/PROTON-2227 > Project: Qpid Proton > Issue Type: Bug > Components: proton-j >Affects Versions: proton-j-0.33.4 >Reporter: Robbie Gemmell >Assignee: Robbie Gemmell >Priority: Major > Fix For: proton-j-0.34.0 > > > When some rework around decoding/encoding certain types was optimised in > PROTON-1708 away from using the more generic type handling, to using very > frame-specific handling for certain hot cases (e.g Flow, Transfer, > Disposition), some of the outer behaviours around mandatory fields changed. > Some additional checks/handling the older type code did should be added to > the newer bits to restore those behaviours, which can make things clearer > when certain decode issues occur. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1667) Increase minimum required LibWebSockets version from 2.1.0 to 2.4.2
[ https://issues.apache.org/jira/browse/DISPATCH-1667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17114240#comment-17114240 ] ASF GitHub Bot commented on DISPATCH-1667: -- ganeshmurthy opened a new pull request #742: URL: https://github.com/apache/qpid-dispatch/pull/742 …ockets This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Increase minimum required LibWebSockets version from 2.1.0 to 2.4.2 > --- > > Key: DISPATCH-1667 > URL: https://issues.apache.org/jira/browse/DISPATCH-1667 > Project: Qpid Dispatch > Issue Type: Improvement > Components: Container >Affects Versions: 1.12.0 >Reporter: Ganesh Murthy >Assignee: Ganesh Murthy >Priority: Major > > LibWebSockets v2.1.0 was released on 2016-10-06 and is quite old. Move to a > more recent version 2.4.2 which was released on 2018-03-07. > 2.4.2 is a stable version and contains features like allowing deleting http > listener ports on demand. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] ganeshmurthy opened a new pull request #742: DISPATCH-1667 - Make 2.4.2 as the minimum required version of LibWebS…
ganeshmurthy opened a new pull request #742: URL: https://github.com/apache/qpid-dispatch/pull/742 …ockets This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Assigned] (DISPATCH-1663) system_tests_edge_router fails with ASAN leak
[ https://issues.apache.org/jira/browse/DISPATCH-1663?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ganesh Murthy reassigned DISPATCH-1663: --- Assignee: Ganesh Murthy > system_tests_edge_router fails with ASAN leak > - > > Key: DISPATCH-1663 > URL: https://issues.apache.org/jira/browse/DISPATCH-1663 > Project: Qpid Dispatch > Issue Type: Bug > Components: Tests >Affects Versions: 1.12.0 >Reporter: Ganesh Murthy >Assignee: Ganesh Murthy >Priority: Major > > {noformat} > 53: == > 53: ERROR: test_03_interior_conn_lost > (system_tests_edge_router.LinkRouteProxyTest) > 53: -- > 53: Traceback (most recent call last): > 53: File > "/home/gmurthy/opensource/qpid-dispatch/tests/system_tests_edge_router.py", > line 1859, in test_03_interior_conn_lost > 53: er.teardown() > 53: File "/home/gmurthy/opensource/qpid-dispatch/tests/system_test.py", > line 442, in teardown > 53: super(Qdrouterd, self).teardown() > 53: File "/home/gmurthy/opensource/qpid-dispatch/tests/system_test.py", > line 295, in teardown > 53: error("exit code %s, expected %s" % (status, self.expect)) > 53: File "/home/gmurthy/opensource/qpid-dispatch/tests/system_test.py", > line 285, in error > 53: self.outfile + '.cmd', f.read())); > 53: RuntimeError: Process 16556 error: exit code 1, expected 0 > 53: qdrouterd -c Edge1.conf -I /home/gmurthy/opensource/qpid-dispatch/python > 53: > /home/gmurthy/opensource/qpid-dispatch/build/tests/system_test.dir/system_tests_edge_router/LinkRouteProxyTest/test_03_interior_conn_lost/Edge1-9.cmd > 53: > 53: > 53: = > 53: ==16556==ERROR: LeakSanitizer: detected memory leaks > 53: > 53: Indirect leak of 704 byte(s) in 1 object(s) allocated from: > 53: #0 0x7f60c03a3bf5 in __interceptor_posix_memalign > (/lib64/libasan.so.5+0x10ebf5) > 53: #1 0x7f60bfb5ace3 in qd_alloc > /home/gmurthy/opensource/qpid-dispatch/src/alloc_pool.c:347 > 53: #2 0x7f60bfb63e62 in new_qd_buffer_t > /home/gmurthy/opensource/qpid-dispatch/src/buffer.c:31 > 53: #3 0x7f60bfb641a8 in qd_buffer > /home/gmurthy/opensource/qpid-dispatch/src/buffer.c:44 > 53: #4 0x7f60bfb64628 in qd_buffer_list_clone > /home/gmurthy/opensource/qpid-dispatch/src/buffer.c:71 > 53: #5 0x7f60bfbc4d98 in qd_message_copy > /home/gmurthy/opensource/qpid-dispatch/src/message.c:1030 > 53: #6 0x7f60bfcf9bc9 in qdr_send_to2 > /home/gmurthy/opensource/qpid-dispatch/src/router_core/transfer.c:293 > 53: #7 0x7f60bfcf064f in qdr_management_agent_on_message > /home/gmurthy/opensource/qpid-dispatch/src/router_core/management_agent.c:534 > 53: #8 0x7f60bfc9f707 in qdr_forward_on_message > /home/gmurthy/opensource/qpid-dispatch/src/router_core/forwarder.c:310 > 53: #9 0x7f60bfcd7e3c in qdr_general_handler > /home/gmurthy/opensource/qpid-dispatch/src/router_core/router_core.c:808 > 53: #10 0x7f60bfd7a303 in qd_timer_visit > /home/gmurthy/opensource/qpid-dispatch/src/timer.c:201 > 53: #11 0x7f60bfd694f5 in handle > /home/gmurthy/opensource/qpid-dispatch/src/server.c:937 > 53: #12 0x7f60bfd6b153 in thread_run > /home/gmurthy/opensource/qpid-dispatch/src/server.c:1040 > 53: #13 0x7f60bf7334bf in start_thread (/lib64/libpthread.so.0+0x84bf) > 53: > 53: - > 53: Suppressions used: > 53: count bytes template > 53: 5 3008 qd_message_receive > 53: 2640 qdr_action > 53: 2760 qdr_core_subscribe > 53: 1320 qdr_forward_closest_CT > 53: 2896 qdr_link_deliver > 53: 1256 qdr_link_issue_credit_CT > 53: 1192 qdr_delivery_push_CT > 53:45453371352 *libpython* > 53: 50788 *python2* > 53: - > 53: > 53: SUMMARY: AddressSanitizer: 704 byte(s) leaked in 1 allocation(s). > 53: > 53: > 53: -- > 53: Ran 90 tests in 240.786s > 53: > 53: FAILED (errors=1) > 1/1 Test #53: system_tests_edge_router .***Failed 240.99 sec > {noformat} -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-proton] jiridanek merged pull request #247: PROTON-2225: enable threaderciser by default, suppress race checkers
jiridanek merged pull request #247: URL: https://github.com/apache/qpid-proton/pull/247 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (PROTON-2225) Set -DTHREADERCISER=ON by default, to prevent regressions
[ https://issues.apache.org/jira/browse/PROTON-2225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17114313#comment-17114313 ] ASF GitHub Bot commented on PROTON-2225: jiridanek merged pull request #247: URL: https://github.com/apache/qpid-proton/pull/247 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Set -DTHREADERCISER=ON by default, to prevent regressions > - > > Key: PROTON-2225 > URL: https://issues.apache.org/jira/browse/PROTON-2225 > Project: Qpid Proton > Issue Type: Test > Components: build >Affects Versions: proton-c-0.31.0 >Reporter: Jiri Daněk >Assignee: Jiri Daněk >Priority: Major > > Previously, the test stopped compiling, as fixed in PROTON-2120. The reason > the test is disabled is that the test is failing when it is run. > Instead of disabling the test, it would be better to have the test running, > suppress the reported errors and fill a jira to get them fixed eventually. > This requires writing suppressions for both helgrind and tsan. > Now that fd-limit test is disabled (PROTON-2172), we should have some other > test to highlight issues from PROTON-2133. > Current state is that threaderciser test builds and fails under helgrind with > {noformat} > threaderciser start: threads=8, time=1, actions=[listen, close-listen, > connect, close-connect, wake, timeout, cancel-timeout] > ==17017== ---Thread-Announcement-- > ==17017== > ==17017== Thread #5 was created > ==17017==at 0x4D69A3E: clone (in > /nix/store/6m2k8kx8h216jlx9dg3lp4m90bz05yck-glibc-2.30/lib/libc-2.30.so) > ==17017==by 0x4863DBB: create_thread (in > /nix/store/6m2k8kx8h216jlx9dg3lp4m90bz05yck-glibc-2.30/lib/libpthread-2.30.so) > ==17017==by 0x486568B: pthread_create@@GLIBC_2.2.5 (in > /nix/store/6m2k8kx8h216jlx9dg3lp4m90bz05yck-glibc-2.30/lib/libpthread-2.30.so) > ==17017==by 0x483E374: pthread_create_WRK (in > /nix/store/6glsqxyngs9kjkx9mqhshwfi93qfsw8q-valgrind-3.15.0/lib/valgrind/vgpreload_helgrind-amd64-linux.so) > ==17017==by 0x483F46F: pthread_create@* (in > /nix/store/6glsqxyngs9kjkx9mqhshwfi93qfsw8q-valgrind-3.15.0/lib/valgrind/vgpreload_helgrind-amd64-linux.so) > ==17017==by 0x403C92: main (threaderciser.c:572) > ==17017== > ==17017== ---Thread-Announcement-- > ==17017== > ==17017== Thread #2 was created > ==17017==at 0x4D69A3E: clone (in > /nix/store/6m2k8kx8h216jlx9dg3lp4m90bz05yck-glibc-2.30/lib/libc-2.30.so) > ==17017==by 0x4863DBB: create_thread (in > /nix/store/6m2k8kx8h216jlx9dg3lp4m90bz05yck-glibc-2.30/lib/libpthread-2.30.so) > ==17017==by 0x486568B: pthread_create@@GLIBC_2.2.5 (in > /nix/store/6m2k8kx8h216jlx9dg3lp4m90bz05yck-glibc-2.30/lib/libpthread-2.30.so) > ==17017==by 0x483E374: pthread_create_WRK (in > /nix/store/6glsqxyngs9kjkx9mqhshwfi93qfsw8q-valgrind-3.15.0/lib/valgrind/vgpreload_helgrind-amd64-linux.so) > ==17017==by 0x483F46F: pthread_create@* (in > /nix/store/6glsqxyngs9kjkx9mqhshwfi93qfsw8q-valgrind-3.15.0/lib/valgrind/vgpreload_helgrind-amd64-linux.so) > ==17017==by 0x403C64: main (threaderciser.c:571) > ==17017== > ==17017== > ==17017== > ==17017== Lock at 0x4FD4380 was first observed > ==17017==at 0x483F7BD: pthread_mutex_init (in > /nix/store/6glsqxyngs9kjkx9mqhshwfi93qfsw8q-valgrind-3.15.0/lib/valgrind/vgpreload_helgrind-amd64-linux.so) > ==17017==by 0x484EBFF: pmutex_init (epoll.c:137) > ==17017==by 0x485412D: pn_proactor (epoll.c:2104) > ==17017==by 0x402F2D: global_init (threaderciser.c:335) > ==17017==by 0x403BD2: main (threaderciser.c:564) > ==17017== Address 0x4fd4380 is 576 bytes inside a block of size 896 alloc'd > ==17017==at 0x483A9F2: calloc (in > /nix/store/6glsqxyngs9kjkx9mqhshwfi93qfsw8q-valgrind-3.15.0/lib/valgrind/vgpreload_helgrind-amd64-linux.so) > ==17017==by 0x48540BD: pn_proactor (epoll.c:2099) > ==17017==by 0x402F2D: global_init (threaderciser.c:335) > ==17017==by 0x403BD2: main (threaderciser.c:564) > ==17017== Block was alloc'd by thread #1 > ==17017== > ==17017== Possible data race during read of size 4 at 0x4FDF90C by thread #5 > ==17017== Locks held: 1, at address 0x4FD4380 > ==17017==at 0x4855143: post_event (epoll.c:2429) > ==17017==by 0x4855C40: proactor_do_epoll (epoll.c:2676) > ==17017==by 0x4856402: pn_proactor_wait (epoll.c:2803) > ==17017==by 0x40362D: proactor_thread (t
[jira] [Commented] (PROTON-2225) Set -DTHREADERCISER=ON by default, to prevent regressions
[ https://issues.apache.org/jira/browse/PROTON-2225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17114312#comment-17114312 ] ASF subversion and git services commented on PROTON-2225: - Commit bc4a1db33937f02010d5accdc303b3a6bf5db287 in qpid-proton's branch refs/heads/master from Jiri Daněk [ https://gitbox.apache.org/repos/asf?p=qpid-proton.git;h=bc4a1db ] PROTON-2225: enable threaderciser by default, suppress race checkers (#247) * NO-JIRA: specify explicitly the compiler used on macOS On Travis on macOS, gcc is aliased to clang. This way, we won't have a misleading line in Travis report about the compiler. * PROTON-2225: enable threaderciser by default, suppress race checkers > Set -DTHREADERCISER=ON by default, to prevent regressions > - > > Key: PROTON-2225 > URL: https://issues.apache.org/jira/browse/PROTON-2225 > Project: Qpid Proton > Issue Type: Test > Components: build >Affects Versions: proton-c-0.31.0 >Reporter: Jiri Daněk >Assignee: Jiri Daněk >Priority: Major > > Previously, the test stopped compiling, as fixed in PROTON-2120. The reason > the test is disabled is that the test is failing when it is run. > Instead of disabling the test, it would be better to have the test running, > suppress the reported errors and fill a jira to get them fixed eventually. > This requires writing suppressions for both helgrind and tsan. > Now that fd-limit test is disabled (PROTON-2172), we should have some other > test to highlight issues from PROTON-2133. > Current state is that threaderciser test builds and fails under helgrind with > {noformat} > threaderciser start: threads=8, time=1, actions=[listen, close-listen, > connect, close-connect, wake, timeout, cancel-timeout] > ==17017== ---Thread-Announcement-- > ==17017== > ==17017== Thread #5 was created > ==17017==at 0x4D69A3E: clone (in > /nix/store/6m2k8kx8h216jlx9dg3lp4m90bz05yck-glibc-2.30/lib/libc-2.30.so) > ==17017==by 0x4863DBB: create_thread (in > /nix/store/6m2k8kx8h216jlx9dg3lp4m90bz05yck-glibc-2.30/lib/libpthread-2.30.so) > ==17017==by 0x486568B: pthread_create@@GLIBC_2.2.5 (in > /nix/store/6m2k8kx8h216jlx9dg3lp4m90bz05yck-glibc-2.30/lib/libpthread-2.30.so) > ==17017==by 0x483E374: pthread_create_WRK (in > /nix/store/6glsqxyngs9kjkx9mqhshwfi93qfsw8q-valgrind-3.15.0/lib/valgrind/vgpreload_helgrind-amd64-linux.so) > ==17017==by 0x483F46F: pthread_create@* (in > /nix/store/6glsqxyngs9kjkx9mqhshwfi93qfsw8q-valgrind-3.15.0/lib/valgrind/vgpreload_helgrind-amd64-linux.so) > ==17017==by 0x403C92: main (threaderciser.c:572) > ==17017== > ==17017== ---Thread-Announcement-- > ==17017== > ==17017== Thread #2 was created > ==17017==at 0x4D69A3E: clone (in > /nix/store/6m2k8kx8h216jlx9dg3lp4m90bz05yck-glibc-2.30/lib/libc-2.30.so) > ==17017==by 0x4863DBB: create_thread (in > /nix/store/6m2k8kx8h216jlx9dg3lp4m90bz05yck-glibc-2.30/lib/libpthread-2.30.so) > ==17017==by 0x486568B: pthread_create@@GLIBC_2.2.5 (in > /nix/store/6m2k8kx8h216jlx9dg3lp4m90bz05yck-glibc-2.30/lib/libpthread-2.30.so) > ==17017==by 0x483E374: pthread_create_WRK (in > /nix/store/6glsqxyngs9kjkx9mqhshwfi93qfsw8q-valgrind-3.15.0/lib/valgrind/vgpreload_helgrind-amd64-linux.so) > ==17017==by 0x483F46F: pthread_create@* (in > /nix/store/6glsqxyngs9kjkx9mqhshwfi93qfsw8q-valgrind-3.15.0/lib/valgrind/vgpreload_helgrind-amd64-linux.so) > ==17017==by 0x403C64: main (threaderciser.c:571) > ==17017== > ==17017== > ==17017== > ==17017== Lock at 0x4FD4380 was first observed > ==17017==at 0x483F7BD: pthread_mutex_init (in > /nix/store/6glsqxyngs9kjkx9mqhshwfi93qfsw8q-valgrind-3.15.0/lib/valgrind/vgpreload_helgrind-amd64-linux.so) > ==17017==by 0x484EBFF: pmutex_init (epoll.c:137) > ==17017==by 0x485412D: pn_proactor (epoll.c:2104) > ==17017==by 0x402F2D: global_init (threaderciser.c:335) > ==17017==by 0x403BD2: main (threaderciser.c:564) > ==17017== Address 0x4fd4380 is 576 bytes inside a block of size 896 alloc'd > ==17017==at 0x483A9F2: calloc (in > /nix/store/6glsqxyngs9kjkx9mqhshwfi93qfsw8q-valgrind-3.15.0/lib/valgrind/vgpreload_helgrind-amd64-linux.so) > ==17017==by 0x48540BD: pn_proactor (epoll.c:2099) > ==17017==by 0x402F2D: global_init (threaderciser.c:335) > ==17017==by 0x403BD2: main (threaderciser.c:564) > ==17017== Block was alloc'd by thread #1 > ==17017== > ==17017== Possible data race during read of size 4 at 0x4FDF90C by thread #5 > ==17017== Locks held: 1, at address 0x4FD4380 > ==17017==at 0x4855143: post_event (epoll.c:2429) > ==17017==by 0x4855C40: proactor_do_e
[jira] [Commented] (PROTON-2225) Set -DTHREADERCISER=ON by default, to prevent regressions
[ https://issues.apache.org/jira/browse/PROTON-2225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17114311#comment-17114311 ] ASF subversion and git services commented on PROTON-2225: - Commit bc4a1db33937f02010d5accdc303b3a6bf5db287 in qpid-proton's branch refs/heads/master from Jiri Daněk [ https://gitbox.apache.org/repos/asf?p=qpid-proton.git;h=bc4a1db ] PROTON-2225: enable threaderciser by default, suppress race checkers (#247) * NO-JIRA: specify explicitly the compiler used on macOS On Travis on macOS, gcc is aliased to clang. This way, we won't have a misleading line in Travis report about the compiler. * PROTON-2225: enable threaderciser by default, suppress race checkers > Set -DTHREADERCISER=ON by default, to prevent regressions > - > > Key: PROTON-2225 > URL: https://issues.apache.org/jira/browse/PROTON-2225 > Project: Qpid Proton > Issue Type: Test > Components: build >Affects Versions: proton-c-0.31.0 >Reporter: Jiri Daněk >Assignee: Jiri Daněk >Priority: Major > > Previously, the test stopped compiling, as fixed in PROTON-2120. The reason > the test is disabled is that the test is failing when it is run. > Instead of disabling the test, it would be better to have the test running, > suppress the reported errors and fill a jira to get them fixed eventually. > This requires writing suppressions for both helgrind and tsan. > Now that fd-limit test is disabled (PROTON-2172), we should have some other > test to highlight issues from PROTON-2133. > Current state is that threaderciser test builds and fails under helgrind with > {noformat} > threaderciser start: threads=8, time=1, actions=[listen, close-listen, > connect, close-connect, wake, timeout, cancel-timeout] > ==17017== ---Thread-Announcement-- > ==17017== > ==17017== Thread #5 was created > ==17017==at 0x4D69A3E: clone (in > /nix/store/6m2k8kx8h216jlx9dg3lp4m90bz05yck-glibc-2.30/lib/libc-2.30.so) > ==17017==by 0x4863DBB: create_thread (in > /nix/store/6m2k8kx8h216jlx9dg3lp4m90bz05yck-glibc-2.30/lib/libpthread-2.30.so) > ==17017==by 0x486568B: pthread_create@@GLIBC_2.2.5 (in > /nix/store/6m2k8kx8h216jlx9dg3lp4m90bz05yck-glibc-2.30/lib/libpthread-2.30.so) > ==17017==by 0x483E374: pthread_create_WRK (in > /nix/store/6glsqxyngs9kjkx9mqhshwfi93qfsw8q-valgrind-3.15.0/lib/valgrind/vgpreload_helgrind-amd64-linux.so) > ==17017==by 0x483F46F: pthread_create@* (in > /nix/store/6glsqxyngs9kjkx9mqhshwfi93qfsw8q-valgrind-3.15.0/lib/valgrind/vgpreload_helgrind-amd64-linux.so) > ==17017==by 0x403C92: main (threaderciser.c:572) > ==17017== > ==17017== ---Thread-Announcement-- > ==17017== > ==17017== Thread #2 was created > ==17017==at 0x4D69A3E: clone (in > /nix/store/6m2k8kx8h216jlx9dg3lp4m90bz05yck-glibc-2.30/lib/libc-2.30.so) > ==17017==by 0x4863DBB: create_thread (in > /nix/store/6m2k8kx8h216jlx9dg3lp4m90bz05yck-glibc-2.30/lib/libpthread-2.30.so) > ==17017==by 0x486568B: pthread_create@@GLIBC_2.2.5 (in > /nix/store/6m2k8kx8h216jlx9dg3lp4m90bz05yck-glibc-2.30/lib/libpthread-2.30.so) > ==17017==by 0x483E374: pthread_create_WRK (in > /nix/store/6glsqxyngs9kjkx9mqhshwfi93qfsw8q-valgrind-3.15.0/lib/valgrind/vgpreload_helgrind-amd64-linux.so) > ==17017==by 0x483F46F: pthread_create@* (in > /nix/store/6glsqxyngs9kjkx9mqhshwfi93qfsw8q-valgrind-3.15.0/lib/valgrind/vgpreload_helgrind-amd64-linux.so) > ==17017==by 0x403C64: main (threaderciser.c:571) > ==17017== > ==17017== > ==17017== > ==17017== Lock at 0x4FD4380 was first observed > ==17017==at 0x483F7BD: pthread_mutex_init (in > /nix/store/6glsqxyngs9kjkx9mqhshwfi93qfsw8q-valgrind-3.15.0/lib/valgrind/vgpreload_helgrind-amd64-linux.so) > ==17017==by 0x484EBFF: pmutex_init (epoll.c:137) > ==17017==by 0x485412D: pn_proactor (epoll.c:2104) > ==17017==by 0x402F2D: global_init (threaderciser.c:335) > ==17017==by 0x403BD2: main (threaderciser.c:564) > ==17017== Address 0x4fd4380 is 576 bytes inside a block of size 896 alloc'd > ==17017==at 0x483A9F2: calloc (in > /nix/store/6glsqxyngs9kjkx9mqhshwfi93qfsw8q-valgrind-3.15.0/lib/valgrind/vgpreload_helgrind-amd64-linux.so) > ==17017==by 0x48540BD: pn_proactor (epoll.c:2099) > ==17017==by 0x402F2D: global_init (threaderciser.c:335) > ==17017==by 0x403BD2: main (threaderciser.c:564) > ==17017== Block was alloc'd by thread #1 > ==17017== > ==17017== Possible data race during read of size 4 at 0x4FDF90C by thread #5 > ==17017== Locks held: 1, at address 0x4FD4380 > ==17017==at 0x4855143: post_event (epoll.c:2429) > ==17017==by 0x4855C40: proactor_do_e
[jira] [Updated] (PROTON-2225) Set -DTHREADERCISER=ON by default, to prevent regressions
[ https://issues.apache.org/jira/browse/PROTON-2225?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jiri Daněk updated PROTON-2225: --- Fix Version/s: proton-c-0.32.0 > Set -DTHREADERCISER=ON by default, to prevent regressions > - > > Key: PROTON-2225 > URL: https://issues.apache.org/jira/browse/PROTON-2225 > Project: Qpid Proton > Issue Type: Test > Components: build >Affects Versions: proton-c-0.31.0 >Reporter: Jiri Daněk >Assignee: Jiri Daněk >Priority: Major > Fix For: proton-c-0.32.0 > > > Previously, the test stopped compiling, as fixed in PROTON-2120. The reason > the test is disabled is that the test is failing when it is run. > Instead of disabling the test, it would be better to have the test running, > suppress the reported errors and fill a jira to get them fixed eventually. > This requires writing suppressions for both helgrind and tsan. > Now that fd-limit test is disabled (PROTON-2172), we should have some other > test to highlight issues from PROTON-2133. > Current state is that threaderciser test builds and fails under helgrind with > {noformat} > threaderciser start: threads=8, time=1, actions=[listen, close-listen, > connect, close-connect, wake, timeout, cancel-timeout] > ==17017== ---Thread-Announcement-- > ==17017== > ==17017== Thread #5 was created > ==17017==at 0x4D69A3E: clone (in > /nix/store/6m2k8kx8h216jlx9dg3lp4m90bz05yck-glibc-2.30/lib/libc-2.30.so) > ==17017==by 0x4863DBB: create_thread (in > /nix/store/6m2k8kx8h216jlx9dg3lp4m90bz05yck-glibc-2.30/lib/libpthread-2.30.so) > ==17017==by 0x486568B: pthread_create@@GLIBC_2.2.5 (in > /nix/store/6m2k8kx8h216jlx9dg3lp4m90bz05yck-glibc-2.30/lib/libpthread-2.30.so) > ==17017==by 0x483E374: pthread_create_WRK (in > /nix/store/6glsqxyngs9kjkx9mqhshwfi93qfsw8q-valgrind-3.15.0/lib/valgrind/vgpreload_helgrind-amd64-linux.so) > ==17017==by 0x483F46F: pthread_create@* (in > /nix/store/6glsqxyngs9kjkx9mqhshwfi93qfsw8q-valgrind-3.15.0/lib/valgrind/vgpreload_helgrind-amd64-linux.so) > ==17017==by 0x403C92: main (threaderciser.c:572) > ==17017== > ==17017== ---Thread-Announcement-- > ==17017== > ==17017== Thread #2 was created > ==17017==at 0x4D69A3E: clone (in > /nix/store/6m2k8kx8h216jlx9dg3lp4m90bz05yck-glibc-2.30/lib/libc-2.30.so) > ==17017==by 0x4863DBB: create_thread (in > /nix/store/6m2k8kx8h216jlx9dg3lp4m90bz05yck-glibc-2.30/lib/libpthread-2.30.so) > ==17017==by 0x486568B: pthread_create@@GLIBC_2.2.5 (in > /nix/store/6m2k8kx8h216jlx9dg3lp4m90bz05yck-glibc-2.30/lib/libpthread-2.30.so) > ==17017==by 0x483E374: pthread_create_WRK (in > /nix/store/6glsqxyngs9kjkx9mqhshwfi93qfsw8q-valgrind-3.15.0/lib/valgrind/vgpreload_helgrind-amd64-linux.so) > ==17017==by 0x483F46F: pthread_create@* (in > /nix/store/6glsqxyngs9kjkx9mqhshwfi93qfsw8q-valgrind-3.15.0/lib/valgrind/vgpreload_helgrind-amd64-linux.so) > ==17017==by 0x403C64: main (threaderciser.c:571) > ==17017== > ==17017== > ==17017== > ==17017== Lock at 0x4FD4380 was first observed > ==17017==at 0x483F7BD: pthread_mutex_init (in > /nix/store/6glsqxyngs9kjkx9mqhshwfi93qfsw8q-valgrind-3.15.0/lib/valgrind/vgpreload_helgrind-amd64-linux.so) > ==17017==by 0x484EBFF: pmutex_init (epoll.c:137) > ==17017==by 0x485412D: pn_proactor (epoll.c:2104) > ==17017==by 0x402F2D: global_init (threaderciser.c:335) > ==17017==by 0x403BD2: main (threaderciser.c:564) > ==17017== Address 0x4fd4380 is 576 bytes inside a block of size 896 alloc'd > ==17017==at 0x483A9F2: calloc (in > /nix/store/6glsqxyngs9kjkx9mqhshwfi93qfsw8q-valgrind-3.15.0/lib/valgrind/vgpreload_helgrind-amd64-linux.so) > ==17017==by 0x48540BD: pn_proactor (epoll.c:2099) > ==17017==by 0x402F2D: global_init (threaderciser.c:335) > ==17017==by 0x403BD2: main (threaderciser.c:564) > ==17017== Block was alloc'd by thread #1 > ==17017== > ==17017== Possible data race during read of size 4 at 0x4FDF90C by thread #5 > ==17017== Locks held: 1, at address 0x4FD4380 > ==17017==at 0x4855143: post_event (epoll.c:2429) > ==17017==by 0x4855C40: proactor_do_epoll (epoll.c:2676) > ==17017==by 0x4856402: pn_proactor_wait (epoll.c:2803) > ==17017==by 0x40362D: proactor_thread (threaderciser.c:473) > ==17017==by 0x483E568: mythread_wrapper (in > /nix/store/6glsqxyngs9kjkx9mqhshwfi93qfsw8q-valgrind-3.15.0/lib/valgrind/vgpreload_helgrind-amd64-linux.so) > ==17017==by 0x4864EDC: start_thread (in > /nix/store/6m2k8kx8h216jlx9dg3lp4m90bz05yck-glibc-2.30/lib/libpthread-2.30.so) > ==17017==by 0x4D69A4E: clone (in > /nix/store/6m2k8kx8h216jlx9dg3lp4m90bz05yck-glibc-2.3
[jira] [Created] (DISPATCH-1668) Dockerfile instructions show how to use router debug core dump files
Charles E. Rolke created DISPATCH-1668: -- Summary: Dockerfile instructions show how to use router debug core dump files Key: DISPATCH-1668 URL: https://issues.apache.org/jira/browse/DISPATCH-1668 Project: Qpid Dispatch Issue Type: Improvement Affects Versions: 1.12.0 Reporter: Charles E. Rolke Assignee: Charles E. Rolke Fix For: 1.13.0 -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1668) Dockerfile instructions show how to use router debug core dump files
[ https://issues.apache.org/jira/browse/DISPATCH-1668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17114364#comment-17114364 ] ASF subversion and git services commented on DISPATCH-1668: --- Commit 4542f69577ecae191dae5b1894465588d4fabef8 in qpid-dispatch's branch refs/heads/master from Charles E. Rolke [ https://gitbox.apache.org/repos/asf?p=qpid-dispatch.git;h=4542f69 ] DISPATCH-1668: Describe using core dumps in docker containers > Dockerfile instructions show how to use router debug core dump files > > > Key: DISPATCH-1668 > URL: https://issues.apache.org/jira/browse/DISPATCH-1668 > Project: Qpid Dispatch > Issue Type: Improvement >Affects Versions: 1.12.0 >Reporter: Charles E. Rolke >Assignee: Charles E. Rolke >Priority: Major > Fix For: 1.13.0 > > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Resolved] (DISPATCH-1668) Dockerfile instructions show how to use router debug core dump files
[ https://issues.apache.org/jira/browse/DISPATCH-1668?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Charles E. Rolke resolved DISPATCH-1668. Resolution: Fixed Fixed at commit 4542f695 > Dockerfile instructions show how to use router debug core dump files > > > Key: DISPATCH-1668 > URL: https://issues.apache.org/jira/browse/DISPATCH-1668 > Project: Qpid Dispatch > Issue Type: Improvement >Affects Versions: 1.12.0 >Reporter: Charles E. Rolke >Assignee: Charles E. Rolke >Priority: Major > Fix For: 1.13.0 > > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-proton] jiridanek merged pull request #130: PROTON-2221 Add coverage reporting for the Ruby binding
jiridanek merged pull request #130: URL: https://github.com/apache/qpid-proton/pull/130 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (PROTON-2221) Statement coverage reporting for the ruby binding
[ https://issues.apache.org/jira/browse/PROTON-2221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17114401#comment-17114401 ] ASF GitHub Bot commented on PROTON-2221: jiridanek merged pull request #130: URL: https://github.com/apache/qpid-proton/pull/130 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Statement coverage reporting for the ruby binding > - > > Key: PROTON-2221 > URL: https://issues.apache.org/jira/browse/PROTON-2221 > Project: Qpid Proton > Issue Type: Test > Components: build, ruby-binding >Affects Versions: proton-c-0.31.0 >Reporter: Jiri Daněk >Assignee: Jiri Daněk >Priority: Major > Fix For: proton-c-0.32.0 > > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (PROTON-2221) Statement coverage reporting for the ruby binding
[ https://issues.apache.org/jira/browse/PROTON-2221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17114400#comment-17114400 ] ASF subversion and git services commented on PROTON-2221: - Commit 9ac9ba46fe4bd459630e1e46be363de618059ba9 in qpid-proton's branch refs/heads/master from Jirka Daněk [ https://gitbox.apache.org/repos/asf?p=qpid-proton.git;h=9ac9ba4 ] PROTON-2221 Add coverage reporting for the Ruby binding (#130) Co-authored-by: Jiri Danek > Statement coverage reporting for the ruby binding > - > > Key: PROTON-2221 > URL: https://issues.apache.org/jira/browse/PROTON-2221 > Project: Qpid Proton > Issue Type: Test > Components: build, ruby-binding >Affects Versions: proton-c-0.31.0 >Reporter: Jiri Daněk >Assignee: Jiri Daněk >Priority: Major > Fix For: proton-c-0.32.0 > > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Updated] (PROTON-2221) Statement coverage reporting for the ruby binding
[ https://issues.apache.org/jira/browse/PROTON-2221?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jiri Daněk updated PROTON-2221: --- Affects Version/s: proton-c-0.19.0 > Statement coverage reporting for the ruby binding > - > > Key: PROTON-2221 > URL: https://issues.apache.org/jira/browse/PROTON-2221 > Project: Qpid Proton > Issue Type: Test > Components: build, ruby-binding >Affects Versions: proton-c-0.19.0, proton-c-0.31.0 >Reporter: Jiri Daněk >Assignee: Jiri Daněk >Priority: Major > Fix For: proton-c-0.32.0 > > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-proton] codecov-io removed a comment on pull request #130: PROTON-2221 Add coverage reporting for the Ruby binding
codecov-io removed a comment on pull request #130: URL: https://github.com/apache/qpid-proton/pull/130#issuecomment-34536 # [Codecov](https://codecov.io/gh/apache/qpid-proton/pull/130?src=pr&el=h1) Report > Merging [#130](https://codecov.io/gh/apache/qpid-proton/pull/130?src=pr&el=desc) into [master](https://codecov.io/gh/apache/qpid-proton/commit/7abcfc7aba6cfd1c938324cf34a51555c845a589&el=desc) will **increase** coverage by `2.93%`. > The diff coverage is `n/a`. [![Impacted file tree graph](https://codecov.io/gh/apache/qpid-proton/pull/130/graphs/tree.svg?width=650&height=150&src=pr&token=UKKzV9XnFF)](https://codecov.io/gh/apache/qpid-proton/pull/130?src=pr&el=tree) ```diff @@Coverage Diff @@ ## master #130 +/- ## == + Coverage 81.57% 84.51% +2.93% == Files 270 45 -225 Lines 36434 2266 -34168 == - Hits29722 1915 -27807 + Misses 6712 351-6361 ``` | [Impacted Files](https://codecov.io/gh/apache/qpid-proton/pull/130?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [python/proton/\_handlers.py](https://codecov.io/gh/apache/qpid-proton/pull/130/diff?src=pr&el=tree#diff-cHl0aG9uL3Byb3Rvbi9faGFuZGxlcnMucHk=) | | | | [cpp/src/map.cpp](https://codecov.io/gh/apache/qpid-proton/pull/130/diff?src=pr&el=tree#diff-Y3BwL3NyYy9tYXAuY3Bw) | | | | [c/src/reactor/acceptor.c](https://codecov.io/gh/apache/qpid-proton/pull/130/diff?src=pr&el=tree#diff-Yy9zcmMvcmVhY3Rvci9hY2NlcHRvci5j) | | | | [cpp/src/handler.cpp](https://codecov.io/gh/apache/qpid-proton/pull/130/diff?src=pr&el=tree#diff-Y3BwL3NyYy9oYW5kbGVyLmNwcA==) | | | | [cpp/src/contexts.hpp](https://codecov.io/gh/apache/qpid-proton/pull/130/diff?src=pr&el=tree#diff-Y3BwL3NyYy9jb250ZXh0cy5ocHA=) | | | | [cpp/include/proton/codec/decoder.hpp](https://codecov.io/gh/apache/qpid-proton/pull/130/diff?src=pr&el=tree#diff-Y3BwL2luY2x1ZGUvcHJvdG9uL2NvZGVjL2RlY29kZXIuaHBw) | | | | [python/proton/handlers.py](https://codecov.io/gh/apache/qpid-proton/pull/130/diff?src=pr&el=tree#diff-cHl0aG9uL3Byb3Rvbi9oYW5kbGVycy5weQ==) | | | | [cpp/include/proton/connection.hpp](https://codecov.io/gh/apache/qpid-proton/pull/130/diff?src=pr&el=tree#diff-Y3BwL2luY2x1ZGUvcHJvdG9uL2Nvbm5lY3Rpb24uaHBw) | | | | [cpp/include/proton/error.hpp](https://codecov.io/gh/apache/qpid-proton/pull/130/diff?src=pr&el=tree#diff-Y3BwL2luY2x1ZGUvcHJvdG9uL2Vycm9yLmhwcA==) | | | | [cpp/include/proton/scalar.hpp](https://codecov.io/gh/apache/qpid-proton/pull/130/diff?src=pr&el=tree#diff-Y3BwL2luY2x1ZGUvcHJvdG9uL3NjYWxhci5ocHA=) | | | | ... and [305 more](https://codecov.io/gh/apache/qpid-proton/pull/130/diff?src=pr&el=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/qpid-proton/pull/130?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/qpid-proton/pull/130?src=pr&el=footer). Last update [7abcfc7...123f04c](https://codecov.io/gh/apache/qpid-proton/pull/130?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (PROTON-2221) Statement coverage reporting for the ruby binding
[ https://issues.apache.org/jira/browse/PROTON-2221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17114403#comment-17114403 ] ASF GitHub Bot commented on PROTON-2221: codecov-io removed a comment on pull request #130: URL: https://github.com/apache/qpid-proton/pull/130#issuecomment-34536 # [Codecov](https://codecov.io/gh/apache/qpid-proton/pull/130?src=pr&el=h1) Report > Merging [#130](https://codecov.io/gh/apache/qpid-proton/pull/130?src=pr&el=desc) into [master](https://codecov.io/gh/apache/qpid-proton/commit/7abcfc7aba6cfd1c938324cf34a51555c845a589&el=desc) will **increase** coverage by `2.93%`. > The diff coverage is `n/a`. [![Impacted file tree graph](https://codecov.io/gh/apache/qpid-proton/pull/130/graphs/tree.svg?width=650&height=150&src=pr&token=UKKzV9XnFF)](https://codecov.io/gh/apache/qpid-proton/pull/130?src=pr&el=tree) ```diff @@Coverage Diff @@ ## master #130 +/- ## == + Coverage 81.57% 84.51% +2.93% == Files 270 45 -225 Lines 36434 2266 -34168 == - Hits29722 1915 -27807 + Misses 6712 351-6361 ``` | [Impacted Files](https://codecov.io/gh/apache/qpid-proton/pull/130?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [python/proton/\_handlers.py](https://codecov.io/gh/apache/qpid-proton/pull/130/diff?src=pr&el=tree#diff-cHl0aG9uL3Byb3Rvbi9faGFuZGxlcnMucHk=) | | | | [cpp/src/map.cpp](https://codecov.io/gh/apache/qpid-proton/pull/130/diff?src=pr&el=tree#diff-Y3BwL3NyYy9tYXAuY3Bw) | | | | [c/src/reactor/acceptor.c](https://codecov.io/gh/apache/qpid-proton/pull/130/diff?src=pr&el=tree#diff-Yy9zcmMvcmVhY3Rvci9hY2NlcHRvci5j) | | | | [cpp/src/handler.cpp](https://codecov.io/gh/apache/qpid-proton/pull/130/diff?src=pr&el=tree#diff-Y3BwL3NyYy9oYW5kbGVyLmNwcA==) | | | | [cpp/src/contexts.hpp](https://codecov.io/gh/apache/qpid-proton/pull/130/diff?src=pr&el=tree#diff-Y3BwL3NyYy9jb250ZXh0cy5ocHA=) | | | | [cpp/include/proton/codec/decoder.hpp](https://codecov.io/gh/apache/qpid-proton/pull/130/diff?src=pr&el=tree#diff-Y3BwL2luY2x1ZGUvcHJvdG9uL2NvZGVjL2RlY29kZXIuaHBw) | | | | [python/proton/handlers.py](https://codecov.io/gh/apache/qpid-proton/pull/130/diff?src=pr&el=tree#diff-cHl0aG9uL3Byb3Rvbi9oYW5kbGVycy5weQ==) | | | | [cpp/include/proton/connection.hpp](https://codecov.io/gh/apache/qpid-proton/pull/130/diff?src=pr&el=tree#diff-Y3BwL2luY2x1ZGUvcHJvdG9uL2Nvbm5lY3Rpb24uaHBw) | | | | [cpp/include/proton/error.hpp](https://codecov.io/gh/apache/qpid-proton/pull/130/diff?src=pr&el=tree#diff-Y3BwL2luY2x1ZGUvcHJvdG9uL2Vycm9yLmhwcA==) | | | | [cpp/include/proton/scalar.hpp](https://codecov.io/gh/apache/qpid-proton/pull/130/diff?src=pr&el=tree#diff-Y3BwL2luY2x1ZGUvcHJvdG9uL3NjYWxhci5ocHA=) | | | | ... and [305 more](https://codecov.io/gh/apache/qpid-proton/pull/130/diff?src=pr&el=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/qpid-proton/pull/130?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/qpid-proton/pull/130?src=pr&el=footer). Last update [7abcfc7...123f04c](https://codecov.io/gh/apache/qpid-proton/pull/130?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Statement coverage reporting for the ruby binding > - > > Key: PROTON-2221 > URL: https://issues.apache.org/jira/browse/PROTON-2221 > Project: Qpid Proton > Issue Type: Test > Components: build, ruby-binding >Affects Versions: proton-c-0.19.0, proton-c-0.31.0 >Reporter: Jiri Daněk >Assignee: Jiri Daněk >Priority: Major > Fix For: proton-c-0.32.0 > > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1585) Allow defining address prefix shared by different multitenant listeners
[ https://issues.apache.org/jira/browse/DISPATCH-1585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17114406#comment-17114406 ] Charles E. Rolke commented on DISPATCH-1585: [~lulf] Proposing a solution in two parts: * Add an *aliases* field to vhost to hold a list of hostnames that would all resolve to using the vhost. The _vhost hostname_ is now just a placeholder and not a real remote host name. {code:java} ["vhost", { "hostname": "tenant1", "aliases": ["internal.example.com", "public.example.com"], "allowUnknownUser": true, // ... }] {code} * In multi tenant setups the _vhost hostname_ is prepended to the autoLink name instead of the _hostname_ field of the remote AMQP Open. For accounting and statistics the vhost has one identifier (the hostname) and one configuration set but it would apply to all the remote hosts in the aliases list. The aliases list is mutable the same as the rest of the settings in the vhost. This creates new opportunities for misconfiguration. For instance, multiple vhosts claim the same alias host address. Those details are still TBD pending discussion of the basic proposal. > Allow defining address prefix shared by different multitenant listeners > --- > > Key: DISPATCH-1585 > URL: https://issues.apache.org/jira/browse/DISPATCH-1585 > Project: Qpid Dispatch > Issue Type: Wish >Reporter: Ulf Lilleengen >Priority: Major > > At present, a multitenant router listener will prefix addresses with the > hostname in the AMQP Open. However, given a configuration where it is > desirable to expose a router address space for multiple DNS names, any > address, linkRoute and autoLink configuration will need to be duplicated for > each DNS name. This complicates router configuration significantly. > > Instead, having a way to specify which prefix to apply for a multitenant > listener would allow reusing the same address, autoLink and linkRoute > configuration for multiple listeners. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Created] (DISPATCH-1669) Compilation fails on modern clang [-Werror,-Wformat]
Jiri Daněk created DISPATCH-1669: Summary: Compilation fails on modern clang [-Werror,-Wformat] Key: DISPATCH-1669 URL: https://issues.apache.org/jira/browse/DISPATCH-1669 Project: Qpid Dispatch Issue Type: Bug Reporter: Jiri Daněk Assignee: Jiri Daněk https://travis-ci.org/github/apache/qpid-dispatch/jobs/690194590 {noformat} [ 1%] Building C object tests/CMakeFiles/clogger.dir/clogger.c.o /Users/travis/build/apache/qpid-dispatch/tests/clogger.c:430:64: error: format specifies type 'long' but the argument has type 'uint64_t' (aka 'unsigned long long') [-Werror,-Wformat] printf("Sent: %ld Accepted: %ld Not Accepted: %ld\n", sent, acc... ~~~ ^~~~ %llu /Users/travis/build/apache/qpid-dispatch/tests/clogger.c:430:70: error: format specifies type 'long' but the argument has type 'uint64_t' (aka 'unsigned long long') [-Werror,-Wformat] printf("Sent: %ld Accepted: %ld Not Accepted: %ld\n", sent, accepted, n... ~~~ ^~~~ %llu /Users/travis/build/apache/qpid-dispatch/tests/clogger.c:430:80: error: format specifies type 'long' but the argument has type 'uint64_t' (aka 'unsigned long long') [-Werror,-Wformat] ...%ld Accepted: %ld Not Accepted: %ld\n", sent, accepted, not_accepted); ~~~ ^~~~ %llu /Users/travis/build/apache/qpid-dispatch/tests/clogger.c:432:56: error: format specifies type 'long' but the argument has type 'uint64_t' (aka 'unsigned long long') [-Werror,-Wformat] printf("FAILURE! Sent: %ld Acked: %ld\n", sent, accepted + ... ~~~ ^~~~ %llu /Users/travis/build/apache/qpid-dispatch/tests/clogger.c:432:62: error: format specifies type 'long' but the argument has type 'unsigned long long' [-Werror,-Wformat] ...Sent: %ld Acked: %ld\n", sent, accepted + not_accepted); ~~~ ^~~ %llu 5 errors generated. {noformat} {noformat} [ 72%] Building C object src/CMakeFiles/qpid-dispatch.dir/http-libwebsockets.c.o /Users/travis/build/apache/qpid-dispatch/src/http-libwebsockets.c:620:110: error: format specifies type 'unsigned long' but the argument has type 'uint64_t' (aka 'unsigned long long') [-Werror,-Wformat] ...end - *position, "%s:%s_bytes %lu\n", name, field.name, field.value); ~~~ ^~~ %llu 1 error generated. {noformat} -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org