[jira] Commented: (QPID-2744) FieldTable throws a NullPointerException in setObjectProperty rather than expected AMQPInvalidClassException

[ https://issues.apache.org/jira/browse/QPID-2744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12892215#action_12892215 ] Andrew Kennedy commented on QPID-2744: -- Added fix for 0-10 code path. This means

[jira] Created: (QPID-2757) Remove double-checked-locking in ThreadPoolFilter

Remove double-checked-locking in ThreadPoolFilter - Key: QPID-2757 URL: https://issues.apache.org/jira/browse/QPID-2757 Project: Qpid Issue Type: Bug Components: Java Broker

[jira] Resolved: (QPID-2682) Move SCD Plugin to part of the Core Broker

[ https://issues.apache.org/jira/browse/QPID-2682?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robbie Gemmell resolved QPID-2682. -- Resolution: Fixed Move SCD Plugin to part of the Core Broker

[jira] Assigned: (QPID-2682) Move SCD Plugin to part of the Core Broker

[ https://issues.apache.org/jira/browse/QPID-2682?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robbie Gemmell reassigned QPID-2682: Assignee: Robbie Gemmell Move SCD Plugin to part of the Core Broker

[jira] Assigned: (QPID-2679) Cache Queues during bind and remove from cache on queue.close()

[ https://issues.apache.org/jira/browse/QPID-2679?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robbie Gemmell reassigned QPID-2679: Assignee: Robbie Gemmell (was: Martin Ritchie) Cache Queues during bind and remove from

[jira] Resolved: (QPID-2679) Cache Queues during bind and remove from cache on queue.close()

[ https://issues.apache.org/jira/browse/QPID-2679?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robbie Gemmell resolved QPID-2679. -- Resolution: Fixed Cache Queues during bind and remove from cache on queue.close()

[jira] Resolved: (QPID-2757) Remove double-checked-locking in ThreadPoolFilter

[ https://issues.apache.org/jira/browse/QPID-2757?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kennedy resolved QPID-2757. -- Resolution: Fixed Fixed Remove double-checked-locking in ThreadPoolFilter

[jira] Created: (QPID-2758) Remove call to Thread.run() in FirewallPlugin

Remove call to Thread.run() in FirewallPlugin - Key: QPID-2758 URL: https://issues.apache.org/jira/browse/QPID-2758 Project: Qpid Issue Type: Bug Components: Java Broker Affects

[jira] Resolved: (QPID-2758) Remove call to Thread.run() in FirewallPlugin

[ https://issues.apache.org/jira/browse/QPID-2758?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kennedy resolved QPID-2758. -- Resolution: Fixed Fixed Remove call to Thread.run() in FirewallPlugin

[jira] Resolved: (QPID-2697) AMQConnectionURL options do not appear in the toString representation

[ https://issues.apache.org/jira/browse/QPID-2697?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kennedy resolved QPID-2697. -- Resolution: Fixed Fixed AMQConnectionURL options do not appear in the toString representation

[jira] Updated: (QPID-2697) AMQConnectionURL options do not appear in the toString representation

[ https://issues.apache.org/jira/browse/QPID-2697?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kennedy updated QPID-2697: - Attachment: (was: 0001-QPID-2697-Print-AMQConnectionURL-options.patch) AMQConnectionURL

[jira] Updated: (QPID-2658) Update Java 0-10 profile excludes

[ https://issues.apache.org/jira/browse/QPID-2658?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kennedy updated QPID-2658: - Attachment: (was: 0001-QPID-2658-Adding-0-10-profile-excludes-for-java.patch) Update Java

[jira] Commented: (QPID-2658) Update Java 0-10 profile excludes

[ https://issues.apache.org/jira/browse/QPID-2658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12892244#action_12892244 ] Andrew Kennedy commented on QPID-2658: -- Committed changes Update Java 0-10 profile

[jira] Resolved: (QPID-2658) Update Java 0-10 profile excludes

[ https://issues.apache.org/jira/browse/QPID-2658?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kennedy resolved QPID-2658. -- Resolution: Fixed Update Java 0-10 profile excludes -

[jira] Commented: (QPID-2653) Double checked locking in org.apache.qpid.server.transport.ThreadPoolFilter

[ https://issues.apache.org/jira/browse/QPID-2653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12892264#action_12892264 ] Andrew Kennedy commented on QPID-2653: -- Duplicate of QPID-2757 Double checked locking

[jira] Resolved: (QPID-2755) Windows SDK has no README

[ https://issues.apache.org/jira/browse/QPID-2755?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Ross resolved QPID-2755. Assignee: Ted Ross Fix Version/s: 0.7 Resolution: Fixed Windows SDK has no README

[jira] Created: (QPID-2760) Only client 0-10 session sync should throw any exceptions

Only client 0-10 session sync should throw any exceptions - Key: QPID-2760 URL: https://issues.apache.org/jira/browse/QPID-2760 Project: Qpid Issue Type: Bug Reporter:

Re: svn commit: r979283 - in /qpid/trunk/qpid/java/common/src/main/java/org/apache/qpid/transport: Session.java SessionDelegate.java

Andrew, Have you tested this change with the C++ test profiles ? Anytime the 0-10 code path is changed, please make sure to test with the C++ test profiles. For example a recent checkin cause the JMSProperty test to fail (I believe in all test profiles). While it's understandable that humans

[jira] Updated: (QPID-2675) Remove obsolete QpidException

[ https://issues.apache.org/jira/browse/QPID-2675?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kennedy updated QPID-2675: - Attachment: (was: 0010-QPID-2675-Remove-obsolete-QpidException.patch) Remove obsolete

Re: svn commit: r979283 - in /qpid/trunk/qpid/java/common/src/main/java/org/apache/qpid/transport: Session.java SessionDelegate.java

I agree we should be checking all code against both brokers... but I think it will soon become unreasonable to expect that before every checkin we test all combinations. At the moment we *should* be checking the following scenarios on a Java client checkin: Java InVM broker Java External broker

Re: svn commit: r979283 - in /qpid/trunk/qpid/java/common/src/main/java/org/apache/qpid/transport: Session.java SessionDelegate.java

Rob, I agree about the complexity involved in running the test profiles and I agree with you about the set of test profiles you mentioned in the email. While the above criteria could be relaxed for certain changes, for other non trivial changes that has a history of issues the above should be

Re: 0-10 Session Close and Failover

Andrew Kennedy wrote: Hi. I have been looking at the 0-10 session close semantics, and been meaning to ask this for a while... There is no explicit close message in 0-10, rather the session timeout is supposed to be set to 0 seconds and then a session detach message is sent. I have implemented

Re: svn commit: r979283 - in /qpid/trunk/qpid/java/common/src/main/java/org/apache/qpid/transport: Session.java SessionDelegate.java

Yes, I ran the tests for the most recent set of commits against the cpp test profile under the ant build system, which I hope would have highlighted any issues with the C++ broker versus the 0-10 changes in the Java client? Sorry about the JMSTestProperties, I checked in a fix for one profile,

Re: svn commit: r979283 - in /qpid/trunk/qpid/java/common/src/main/java/org/apache/qpid/transport: Session.java SessionDelegate.java

My own view is that on checkin we should need only to be running *unit* tests (which are in rather short supply to be fair).  We should have a CI environment where *system* / *integration* tests are being run constantly with all possible profiles being tested.  IMHO unit tests for the client

Re: svn commit: r979283 - in /qpid/trunk/qpid/java/common/src/main/java/org/apache/qpid/transport: Session.java SessionDelegate.java

On Mon, Jul 26, 2010 at 11:06 AM, Andrew Kennedy andrewinternatio...@gmail.com wrote: Yes, I ran the tests for the most recent set of commits against the cpp test profile under the ant build system, which I hope would have highlighted any issues with the C++ broker versus the 0-10 changes in

Re: svn commit: r979283 - in /qpid/trunk/qpid/java/common/src/main/java/org/apache/qpid/transport: Session.java SessionDelegate.java

On Mon, 26 Jul 2010, Rajith Attapattu wrote: My own view is that on checkin we should need only to be running *unit* tests (which are in rather short supply to be fair).  We should have a CI environment where *system* / *integration* tests are being run constantly with all possible profiles

Re: 0-10 Session Close and Failover

Ok, So, the result of what I changed is that the 0-10 session expiry is correctly propagated via sessionRequestTimeout and sessionTimeout messages, however you are saying that this will not work correctly? If I understand things correctly, when the client creates a session and negotiates an N 0

Re: 0-10 Session Close and Failover

Andrew Kennedy wrote: Ok, So, the result of what I changed is that the 0-10 session expiry is correctly propagated via sessionRequestTimeout and sessionTimeout messages, however you are saying that this will not work correctly? If I understand things correctly, when the client creates a session