[jira] [Commented] (QPID-4667) Selective message acknowledgement does not work over AMQP 1.0

2013-03-27 Thread Justin Ross (JIRA)
[ https://issues.apache.org/jira/browse/QPID-4667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13615112#comment-13615112 ] Justin Ross commented on QPID-4667: --- Approved for 0.22. Selective

[jira] [Commented] (QPID-4668) Message::getRedelivered() always returns true for messages received over AMQP 1.0

2013-03-27 Thread Justin Ross (JIRA)
[ https://issues.apache.org/jira/browse/QPID-4668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13615113#comment-13615113 ] Justin Ross commented on QPID-4668: --- Approved for 0.22.

[jira] [Commented] (QPID-4667) Selective message acknowledgement does not work over AMQP 1.0

2013-03-27 Thread Gordon Sim (JIRA)
[ https://issues.apache.org/jira/browse/QPID-4667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13615155#comment-13615155 ] Gordon Sim commented on QPID-4667: -- Merged to 0.22: http://svn.apache.org/r1461536

[jira] [Resolved] (QPID-4667) Selective message acknowledgement does not work over AMQP 1.0

2013-03-27 Thread Gordon Sim (JIRA)
[ https://issues.apache.org/jira/browse/QPID-4667?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gordon Sim resolved QPID-4667. -- Resolution: Fixed Fix Version/s: 0.21 Selective message acknowledgement does not work over

[jira] [Resolved] (QPID-4668) Message::getRedelivered() always returns true for messages received over AMQP 1.0

2013-03-27 Thread Gordon Sim (JIRA)
[ https://issues.apache.org/jira/browse/QPID-4668?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gordon Sim resolved QPID-4668. -- Resolution: Fixed Fix Version/s: 0.21 Merged to 0.22: http://svn.apache.org/r1461545

[jira] [Created] (QPID-4672) C++ Broker deadlock detaching XmlExchange sessions

2013-03-27 Thread Chuck Rolke (JIRA)
Chuck Rolke created QPID-4672: - Summary: C++ Broker deadlock detaching XmlExchange sessions Key: QPID-4672 URL: https://issues.apache.org/jira/browse/QPID-4672 Project: Qpid Issue Type: Bug

[jira] [Commented] (QPID-4659) [Java Broker] Refactor broker to separate protocol independent from protocol specific classes

2013-03-27 Thread Rob Godfrey (JIRA)
[ https://issues.apache.org/jira/browse/QPID-4659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13615264#comment-13615264 ] Rob Godfrey commented on QPID-4659: --- {quote} MessageMetaDataTypeRegistry.java doesnt

[jira] [Comment Edited] (QPID-4659) [Java Broker] Refactor broker to separate protocol independent from protocol specific classes

2013-03-27 Thread Rob Godfrey (JIRA)
[ https://issues.apache.org/jira/browse/QPID-4659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13615264#comment-13615264 ] Rob Godfrey edited comment on QPID-4659 at 3/27/13 1:50 PM:

Review Request: C++ Broker XmlExchange deadlocks during simultaneous unbinds

2013-03-27 Thread Chug Rolke
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10155/ --- Review request for qpid, Alan Conway, Gordon Sim, and Kenneth Giusti.

Re: Review Request: C++ Broker 'rebind' to steer messages from one queue to others

2013-03-27 Thread Gordon Sim
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10020/#review18422 --- trunk/qpid/cpp/src/qpid/broker/Broker.h

Re: Review Request: C++ Broker XmlExchange deadlocks during simultaneous unbinds

2013-03-27 Thread Gordon Sim
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10155/#review18423 --- trunk/qpid/cpp/src/qpid/xml/XmlExchange.h

Re: Review Request: C++ Broker XmlExchange deadlocks during simultaneous unbinds

2013-03-27 Thread Chug Rolke
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10155/#review18424 --- trunk/qpid/cpp/src/qpid/xml/XmlExchange.h

[jira] [Commented] (QPID-4672) C++ Broker deadlock detaching XmlExchange sessions

2013-03-27 Thread Chuck Rolke (JIRA)
[ https://issues.apache.org/jira/browse/QPID-4672?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13615373#comment-13615373 ] Chuck Rolke commented on QPID-4672: --- Fixed in r1461634.

0.22 request for change to release branch - XmlExchange deadlock

2013-03-27 Thread Chuck Rolke
QPID-4672, approved by Gordon Sim - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (QPID-4672) C++ Broker deadlock detaching XmlExchange sessions

2013-03-27 Thread Gordon Sim (JIRA)
[ https://issues.apache.org/jira/browse/QPID-4672?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13615390#comment-13615390 ] Gordon Sim commented on QPID-4672: -- I concur with backporting to 0.22

Re: Review Request: C++ Broker XmlExchange deadlocks during simultaneous unbinds

2013-03-27 Thread Kenneth Giusti
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10155/#review18425 --- Ship it! Looks fine - but I'm not a big fan of the xxxLH()

[jira] [Commented] (QPID-3769) NPE in client AMQDestination.equals()

2013-03-27 Thread Rajith Attapattu (JIRA)
[ https://issues.apache.org/jira/browse/QPID-3769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13615424#comment-13615424 ] Rajith Attapattu commented on QPID-3769: I was going to request a port, but I

Request for inclusion into the 0.22 branch

2013-03-27 Thread Rajith Attapattu
Hey Justin, I want to include the following commits into the 0.22 branch. http://svn.apache.org/r1461324 http://svn.apache.org/r1461329 Once I make some adjustments to the tests, I would need to port that as well. I will send a follow up email when I've got that sorted out. Regards, Rajith

Re: Request for inclusion into the 0.22 branch

2013-03-27 Thread Rajith Attapattu
Sorry I forgot to include the JIRA in the email. Please see https://issues.apache.org/jira/browse/QPID-3769 for context. Rajith On Wed, Mar 27, 2013 at 12:00 PM, Rajith Attapattu rajit...@gmail.com wrote: Hey Justin, I want to include the following commits into the 0.22 branch.

Re: Review Request: C++ Broker XmlExchange deadlocks during simultaneous unbinds

2013-03-27 Thread Alan Conway
On March 27, 2013, 3:53 p.m., Kenneth Giusti wrote: Looks fine - but I'm not a big fan of the xxxLH() convention, though. It's too brittle. A code change that (re)moves the lock will cause the code to fail, but cannot be detected by the compiler. Not much of an issue if the

Re: Review Request: C++ Broker XmlExchange deadlocks during simultaneous unbinds

2013-03-27 Thread Alan Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10155/#review18429 --- Ship it! Ship It! - Alan Conway On March 27, 2013, 2:38 p.m.,

[jira] [Commented] (QPID-4063) Allow user to assign the name of the source queue when creating an exchange or dynamic route.

2013-03-27 Thread Ted Ross (JIRA)
[ https://issues.apache.org/jira/browse/QPID-4063?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13615626#comment-13615626 ] Ted Ross commented on QPID-4063: There's a possible unintended consequence on this patch:

[jira] [Resolved] (QPID-4063) Allow user to assign the name of the source queue when creating an exchange or dynamic route.

2013-03-27 Thread Ken Giusti (JIRA)
[ https://issues.apache.org/jira/browse/QPID-4063?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ken Giusti resolved QPID-4063. -- Resolution: Fixed Fix Version/s: 0.18 http://svn.apache.org/viewvc?view=revisionrevision=1351518

[jira] [Created] (QPID-4673) [Java Broker AMQP 1.0] Potential for deadlock when draining AMQP 1.0 subscriptions

2013-03-27 Thread Rob Godfrey (JIRA)
Rob Godfrey created QPID-4673: - Summary: [Java Broker AMQP 1.0] Potential for deadlock when draining AMQP 1.0 subscriptions Key: QPID-4673 URL: https://issues.apache.org/jira/browse/QPID-4673 Project:

Re: 0.22, request for merge (create link lockdown)

2013-03-27 Thread Chuck Rolke
I would like to merge the feature from qpid/branches/qpid-4631 into the 0.22 release. It is a forceful lockdown of the interbroker links using ACLs as described in https://issues.apache.org/jira/browse/QPID-4631. The patch changes the behavior of link creation significantly but I think for the

0.22, Request for merge

2013-03-27 Thread Robert Godfrey
Hi Justin, request to merge QPID-4673 [1][2] to 0.22. This is a fix to a deadlock which occurs in the Java Broker when running in the AMQP 1.0 codepath. There is no impact to non 1.0 users. Cheers, Rob [1] https://issues.apache.org/jira/browse/QPID-4673 [2]

[jira] [Commented] (QPID-4672) C++ Broker deadlock detaching XmlExchange sessions

2013-03-27 Thread Justin Ross (JIRA)
[ https://issues.apache.org/jira/browse/QPID-4672?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13615776#comment-13615776 ] Justin Ross commented on QPID-4672: --- Reviewed by Gordon. Approved for 0.22.

Re: Request for inclusion into the 0.22 branch

2013-03-27 Thread Justin Ross
Hi, Rajith. I read the jira comments, and it looks like a little more work is required before we put it on the release branch (the testing for the jndi case). On Wed, Mar 27, 2013 at 12:04 PM, Rajith Attapattu rajit...@gmail.com wrote: Sorry I forgot to include the JIRA in the email. Please

Re: 0.22, request for merge (create link lockdown)

2013-03-27 Thread Justin Ross
Hi, Chuck. I think we should agree to land this on trunk first (I'm definitely in favor of it). That way it can get some cycles with CI. Justin On Wed, Mar 27, 2013 at 4:42 PM, Chuck Rolke cro...@redhat.com wrote: I would like to merge the feature from qpid/branches/qpid-4631 into the 0.22

[jira] [Commented] (QPID-4673) [Java Broker AMQP 1.0] Potential for deadlock when draining AMQP 1.0 subscriptions

2013-03-27 Thread Justin Ross (JIRA)
[ https://issues.apache.org/jira/browse/QPID-4673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13615794#comment-13615794 ] Justin Ross commented on QPID-4673: --- Isolated to 1.0 protocol module. Approved for 0.22.

Re: Request for inclusion into the 0.22 branch

2013-03-27 Thread Rajith Attapattu
On Wed, Mar 27, 2013 at 5:31 PM, Justin Ross justin.r...@gmail.com wrote: Hi, Rajith. I read the jira comments, and it looks like a little more work is required before we put it on the release branch (the testing for the jndi case). Indeed, this review request is for the whole package :P I

[jira] [Assigned] (QPID-4666) Incorrect exception message returned in MessageSubscribe when permission is denied

2013-03-27 Thread Robbie Gemmell (JIRA)
[ https://issues.apache.org/jira/browse/QPID-4666?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robbie Gemmell reassigned QPID-4666: Assignee: Robbie Gemmell Incorrect exception message returned in MessageSubscribe when

[jira] [Updated] (QPID-4666) Incorrect exception message returned in MessageSubscribe when permission is denied

2013-03-27 Thread Robbie Gemmell (JIRA)
[ https://issues.apache.org/jira/browse/QPID-4666?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robbie Gemmell updated QPID-4666: - Fix Version/s: 0.21 Incorrect exception message returned in MessageSubscribe when permission

[jira] [Updated] (QPID-4666) Incorrect exception message returned in MessageSubscribe when permission is denied

2013-03-27 Thread Robbie Gemmell (JIRA)
[ https://issues.apache.org/jira/browse/QPID-4666?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robbie Gemmell updated QPID-4666: - Fix Version/s: (was: 0.21) 0.22 Incorrect exception message returned

[jira] [Updated] (QPID-4666) [Java Broker] Incorrect exception messages returned following 0-10 MessageSubscribe failure

2013-03-27 Thread Robbie Gemmell (JIRA)
[ https://issues.apache.org/jira/browse/QPID-4666?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robbie Gemmell updated QPID-4666: - Summary: [Java Broker] Incorrect exception messages returned following 0-10 MessageSubscribe

[jira] [Commented] (QPID-4666) [Java Broker] Incorrect exception messages returned following 0-10 MessageSubscribe failure

2013-03-27 Thread Robbie Gemmell (JIRA)
[ https://issues.apache.org/jira/browse/QPID-4666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13615889#comment-13615889 ] Robbie Gemmell commented on QPID-4666: -- Hi JAkub, I had a chat with Rob and we

[jira] [Updated] (QPID-4666) [Java Broker] Incorrect exception messages returned following 0-10 MessageSubscribe failure

2013-03-27 Thread Robbie Gemmell (JIRA)
[ https://issues.apache.org/jira/browse/QPID-4666?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robbie Gemmell updated QPID-4666: - Affects Version/s: 0.6 0.8 0.10