Re: Review Request: receiver/session locking changes

2013-04-26 Thread Gordon Sim
On April 25, 2013, 10:13 p.m., Alan Conway wrote: /trunk/qpid/cpp/src/qpid/client/amqp0_10/ReceiverImpl.cpp, line 205 https://reviews.apache.org/r/10704/diff/1/?file=283074#file283074line205 It's not immediately obvious that this is safe - could there be code that depends on the

[jira] [Created] (QPID-4778) [Java Broker] Introduce an ERRORED state for configured objects to indicate that either object configuration is wrong or the object experiences an unexpected condition and

2013-04-26 Thread Alex Rudyy (JIRA)
Alex Rudyy created QPID-4778: Summary: [Java Broker] Introduce an ERRORED state for configured objects to indicate that either object configuration is wrong or the object experiences an unexpected condition and cannot recover from it

[jira] [Created] (QPID-4779) Implementation of policies for queues in Java Qpid Broker

2013-04-26 Thread Michal Zerola (JIRA)
Michal Zerola created QPID-4779: --- Summary: Implementation of policies for queues in Java Qpid Broker Key: QPID-4779 URL: https://issues.apache.org/jira/browse/QPID-4779 Project: Qpid Issue

[jira] [Commented] (QPID-4329) HA disaster recovery.

2013-04-26 Thread Ted Ross (JIRA)
[ https://issues.apache.org/jira/browse/QPID-4329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13642803#comment-13642803 ] Ted Ross commented on QPID-4329: A simpler approach might be to not use multiple clusters

Re: Review Request: receiver/session locking changes

2013-04-26 Thread Alan Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10704/#review19769 --- Ship it! Ship It! - Alan Conway On April 22, 2013, 3:52 p.m.,

[jira] [Updated] (QPID-4779) Implementation of policies for queues in Java Qpid Broker

2013-04-26 Thread Michal Zerola (JIRA)
[ https://issues.apache.org/jira/browse/QPID-4779?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michal Zerola updated QPID-4779: Attachment: policies_prototype.patch Implementation of policies for queues in Java Qpid Broker

[jira] [Commented] (QPID-4329) HA disaster recovery.

2013-04-26 Thread Alan Conway (JIRA)
[ https://issues.apache.org/jira/browse/QPID-4329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13642920#comment-13642920 ] Alan Conway commented on QPID-4329: --- In the cases I have seen so far, both main and DR

[jira] [Commented] (QPID-4760) Associate Java Broker QueueAdapter and SessionAdapter via ConsumerAdapter

2013-04-26 Thread Fraser Adams (JIRA)
[ https://issues.apache.org/jira/browse/QPID-4760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13642921#comment-13642921 ] Fraser Adams commented on QPID-4760: committed to r1476219 an amended patch following a

[jira] [Resolved] (QPID-4760) Associate Java Broker QueueAdapter and SessionAdapter via ConsumerAdapter

2013-04-26 Thread Fraser Adams (JIRA)
[ https://issues.apache.org/jira/browse/QPID-4760?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fraser Adams resolved QPID-4760. Resolution: Fixed Associate Java Broker QueueAdapter and SessionAdapter via ConsumerAdapter

[jira] [Closed] (QPID-4760) Associate Java Broker QueueAdapter and SessionAdapter via ConsumerAdapter

2013-04-26 Thread Fraser Adams (JIRA)
[ https://issues.apache.org/jira/browse/QPID-4760?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fraser Adams closed QPID-4760. -- Associate Java Broker QueueAdapter and SessionAdapter via ConsumerAdapter

Re: 0.22 release update - RC2 is available

2013-04-26 Thread Michael Goulish
I did the autotools make check 50 times on an otherwise-deserted RHEL 6.4 box. Here are the results: qpid_tests.broker_0_10.stats.BrokerStatsTests.test_discards_no_route { 2 failures } queue_flow_limit_tests.QueueFlowLimitTests.test_flow_size { 1 failure

Re: 0.22 release update - RC2 is available

2013-04-26 Thread Michael Goulish
By the way -- I have no idea what failure percentage for a given test should be judged GO / NO-GO for a release. I am only a messenger. :-) - Original Message - I did the autotools make check 50 times on an otherwise-deserted RHEL 6.4 box. Here are the results:

Re: QMFv2 object update bug [WAS Re: Questions from a novice]

2013-04-26 Thread Ken Giusti
Hey Bill, I've cc'ing Fraser and the rest of the dev team on this - been meaning to raise this as a general issue with the C++ broker. I'm trying to find the best way to fix these problems, and I've started making changes on trunk. You've been bitten by my latest attempts - sorry. I first

Re: Review Request: paged queue implementation as flow to disk replacement

2013-04-26 Thread Gordon Sim
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7209/ --- (Updated April 26, 2013, 4:21 p.m.) Review request for qpid, Kenneth Giusti and

Re: Review Request: paged queue implementation as flow to disk replacement

2013-04-26 Thread Gordon Sim
On April 25, 2013, 8:46 p.m., Andrew Stitcher wrote: I really like this code, I think that the issues below are all really nits (except stopping MemoryMappedFile from having a default copy construct and assignment operator) I especially like the improvement of not having to specify

Re: 0.22 release update - RC2 is available

2013-04-26 Thread Ken Giusti
Hey Mick, Any context to the queue flow limit failures? Error messages/stack trace? I think those tests use a shared broker, so one test failure could leave the broker in an unknown state and cause all the remaining tests to fail. -K - Original Message - From: Michael Goulish

Re: Review Request: paged queue implementation as flow to disk replacement

2013-04-26 Thread Andrew Stitcher
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7209/#review19774 --- Except for the missing encode()/decode() functions this looks good.

Re: 0.22 release update - RC2 is available

2013-04-26 Thread Michael Goulish
Yes! From one of the failure-storms, I will just give the backtrace form the first failure, since that probably caused the others: queue_flow_limit_tests.QueueFlowLimitTests.test_blocked_queue_delete fail Error during test: Traceback (most recent call last): File

Re: Review Request: paged queue implementation as flow to disk replacement

2013-04-26 Thread Gordon Sim
On April 26, 2013, 4:34 p.m., Andrew Stitcher wrote: /trunk/qpid/cpp/src/qpid/broker/Message.h, line 148 https://reviews.apache.org/r/7209/diff/3/?file=284903#file284903line148 Did you actually add these new functions to Message.cpp? They don't seem to be anywhere in the review

Re: Review Request: paged queue implementation as flow to disk replacement

2013-04-26 Thread Andrew Stitcher
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7209/#review19778 --- Ship it! - Andrew Stitcher On April 26, 2013, 4:21 p.m., Gordon

Re: Review Request: paged queue implementation as flow to disk replacement

2013-04-26 Thread Andrew Stitcher
On April 26, 2013, 4:34 p.m., Andrew Stitcher wrote: /trunk/qpid/cpp/src/qpid/broker/Message.h, line 148 https://reviews.apache.org/r/7209/diff/3/?file=284903#file284903line148 Did you actually add these new functions to Message.cpp? They don't seem to be anywhere in the review

[jira] [Commented] (QPID-4777) [Java Broker] Add UI to view and edit web management configuration

2013-04-26 Thread Alex Rudyy (JIRA)
[ https://issues.apache.org/jira/browse/QPID-4777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13643024#comment-13643024 ] Alex Rudyy commented on QPID-4777: -- The work is committed in revision

[jira] [Commented] (QPID-4777) [Java Broker] Add UI to view and edit web management configuration

2013-04-26 Thread Alex Rudyy (JIRA)
[ https://issues.apache.org/jira/browse/QPID-4777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13643035#comment-13643035 ] Alex Rudyy commented on QPID-4777: -- Committed into 0.22 branch under revision

[jira] [Updated] (QPID-4777) [Java Broker] Add UI to view and edit web management configuration

2013-04-26 Thread Alex Rudyy (JIRA)
[ https://issues.apache.org/jira/browse/QPID-4777?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alex Rudyy updated QPID-4777: - Affects Version/s: (was: 0.23) 0.22 [Java Broker] Add UI to view and edit

[jira] [Resolved] (QPID-4777) [Java Broker] Add UI to view and edit web management configuration

2013-04-26 Thread Alex Rudyy (JIRA)
[ https://issues.apache.org/jira/browse/QPID-4777?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alex Rudyy resolved QPID-4777. -- Resolution: Fixed [Java Broker] Add UI to view and edit web management configuration

Review Request: C++ Broker - add --log-disable option

2013-04-26 Thread Chug Rolke
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10799/ --- Review request for qpid and Alan Conway. Description --- This patch adds

Re: 0.22 release update - RC2 is available

2013-04-26 Thread Ken Giusti
Nope, can't say I like the looks of that. The test is trying to delete a queue that has a sender blocked on it. That delete command is failing. I'll try to repo it here. -K - Original Message - From: Michael Goulish mgoul...@redhat.com To: dev@qpid.apache.org Sent: Friday, April

[jira] [Created] (QPID-4780) HA broker deadlock after loss of primary broker

2013-04-26 Thread Alan Conway (JIRA)
Alan Conway created QPID-4780: - Summary: HA broker deadlock after loss of primary broker Key: QPID-4780 URL: https://issues.apache.org/jira/browse/QPID-4780 Project: Qpid Issue Type: Bug

[jira] [Resolved] (QPID-4780) HA broker deadlock after loss of primary broker

2013-04-26 Thread Alan Conway (JIRA)
[ https://issues.apache.org/jira/browse/QPID-4780?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alan Conway resolved QPID-4780. --- Resolution: Fixed Unable to reproduce, but found a lock ordering deadlock by inspection of the code

[jira] [Comment Edited] (QPID-4780) HA broker deadlock after loss of primary broker

2013-04-26 Thread Alan Conway (JIRA)
[ https://issues.apache.org/jira/browse/QPID-4780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13643051#comment-13643051 ] Alan Conway edited comment on QPID-4780 at 4/26/13 5:29 PM:

[jira] [Comment Edited] (QPID-4780) HA broker deadlock after loss of primary broker

2013-04-26 Thread Alan Conway (JIRA)
[ https://issues.apache.org/jira/browse/QPID-4780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13643051#comment-13643051 ] Alan Conway edited comment on QPID-4780 at 4/26/13 5:29 PM:

Re: Review Request: C++ Broker - add --log-disable option

2013-04-26 Thread Alan Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10799/#review19785 --- Ship it! Nice - something I had in mind way back when and never

Re: 0.22 Request For Inclusion: QPID-4727

2013-04-26 Thread Jimmy Jones
Do you mean QPID-4724? - Original Message - From: Darryl L. Pierce Sent: 04/25/13 09:30 PM To: dev@qpid.apache.org Subject: 0.22 Request For Inclusion: QPID-4727 QPID-4727: qpid-cpp-0.22-rc1 RHEL6 cmake issues This patch fixes building the Perl libraries in Cmake.

[jira] [Commented] (QPID-4770) Perl bindings don't build from qpid-0.22-rc2.tar.gz

2013-04-26 Thread Jimmy Jones (JIRA)
[ https://issues.apache.org/jira/browse/QPID-4770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13643156#comment-13643156 ] Jimmy Jones commented on QPID-4770: --- Successfully built and correctly linked now cmake is

[jira] [Comment Edited] (QPID-4770) Perl bindings don't build from qpid-0.22-rc2.tar.gz

2013-04-26 Thread Jimmy Jones (JIRA)
[ https://issues.apache.org/jira/browse/QPID-4770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13639469#comment-13639469 ] Jimmy Jones edited comment on QPID-4770 at 4/26/13 7:23 PM:

[jira] [Comment Edited] (QPID-4770) Perl bindings don't build from qpid-0.22-rc2.tar.gz

2013-04-26 Thread Jimmy Jones (JIRA)
[ https://issues.apache.org/jira/browse/QPID-4770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13639464#comment-13639464 ] Jimmy Jones edited comment on QPID-4770 at 4/26/13 7:23 PM: Was

[jira] [Issue Comment Deleted] (QPID-4770) Perl bindings don't build from qpid-0.22-rc2.tar.gz

2013-04-26 Thread Jimmy Jones (JIRA)
[ https://issues.apache.org/jira/browse/QPID-4770?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jimmy Jones updated QPID-4770: -- Comment: was deleted (was: Was using ./configure --prefix=/usr) Perl bindings don't build from

[jira] [Updated] (QPID-4770) Perl bindings don't build from qpid-0.22-rc2.tar.gz

2013-04-26 Thread Jimmy Jones (JIRA)
[ https://issues.apache.org/jira/browse/QPID-4770?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jimmy Jones updated QPID-4770: -- Description: Fresh RHEL6 VM: ./configure --prefix=/usr ... gcc -c -D_REENTRANT -D_GNU_SOURCE

[jira] [Updated] (QPID-4719) Problem building perl bindings from qpid 0.22 RC1 tarball

2013-04-26 Thread Jimmy Jones (JIRA)
[ https://issues.apache.org/jira/browse/QPID-4719?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jimmy Jones updated QPID-4719: -- Description: Tarball http://people.apache.org/~jross/qpid-0.22-rc1/qpid-cpp-0.22-rc1.tar.gz is

[jira] [Updated] (QPID-4719) Problem building perl bindings from qpid 0.22 RC1 tarball

2013-04-26 Thread Jimmy Jones (JIRA)
[ https://issues.apache.org/jira/browse/QPID-4719?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jimmy Jones updated QPID-4719: -- Description: Tarball http://people.apache.org/~jross/qpid-0.22-rc1/qpid-cpp-0.22-rc1.tar.gz is

[jira] [Issue Comment Deleted] (QPID-4719) Problem building perl bindings from qpid 0.22 RC1 tarball

2013-04-26 Thread Jimmy Jones (JIRA)
[ https://issues.apache.org/jira/browse/QPID-4719?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jimmy Jones updated QPID-4719: -- Comment: was deleted (was: Running perl Makefile.PL from perl-qpid-0.22-rc1.tar.gz, after installing

[jira] [Issue Comment Deleted] (QPID-4719) Problem building perl bindings from qpid 0.22 RC1 tarball

2013-04-26 Thread Jimmy Jones (JIRA)
[ https://issues.apache.org/jira/browse/QPID-4719?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jimmy Jones updated QPID-4719: -- Comment: was deleted (was: bin/release.sh controls what files go in, looks as if the perl bindings now

[jira] [Issue Comment Deleted] (QPID-4719) Problem building perl bindings from qpid 0.22 RC1 tarball

2013-04-26 Thread Jimmy Jones (JIRA)
[ https://issues.apache.org/jira/browse/QPID-4719?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jimmy Jones updated QPID-4719: -- Comment: was deleted (was: This might be a separate issue, but if I take the full

[jira] [Comment Edited] (QPID-4719) Problem building perl bindings from qpid 0.22 RC1 tarball

2013-04-26 Thread Jimmy Jones (JIRA)
[ https://issues.apache.org/jira/browse/QPID-4719?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13633184#comment-13633184 ] Jimmy Jones edited comment on QPID-4719 at 4/26/13 7:36 PM:

[jira] [Created] (QPID-4781) cmake build of perl bindings fails in RC2

2013-04-26 Thread Jimmy Jones (JIRA)
Jimmy Jones created QPID-4781: - Summary: cmake build of perl bindings fails in RC2 Key: QPID-4781 URL: https://issues.apache.org/jira/browse/QPID-4781 Project: Qpid Issue Type: Bug

Re: Review Request: Change federation link creation default to deny; allow only by ACL authorization

2013-04-26 Thread Chug Rolke
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10658/ --- (Updated April 26, 2013, 7:45 p.m.) Review request for qpid, Alan Conway and

[jira] [Commented] (QPID-4631) C++ Broker interbroker links should be protected by ACL

2013-04-26 Thread Chuck Rolke (JIRA)
[ https://issues.apache.org/jira/browse/QPID-4631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13643183#comment-13643183 ] Chuck Rolke commented on QPID-4631: --- {noformat} I suggest we add the new requirements

[jira] [Commented] (QPID-4756) Python QMF console: QMFv2 object statistic notifications not working.

2013-04-26 Thread Ken Giusti (JIRA)
[ https://issues.apache.org/jira/browse/QPID-4756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13643201#comment-13643201 ] Ken Giusti commented on QPID-4756: -- Additional bug fix - objectProps was getting invoked

[jira] [Commented] (QPID-4651) C++ Broker logging could use an easy way to disable log messages

2013-04-26 Thread Chuck Rolke (JIRA)
[ https://issues.apache.org/jira/browse/QPID-4651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13643264#comment-13643264 ] Chuck Rolke commented on QPID-4651: --- The code is committed at Committed revision 1476409.