[jira] [Created] (QPID-5364) BindingRestTest.testDeleteBinding failed with 500 internal server error - Too many entries in path. Expected 2; path: []
Keith Wall created QPID-5364:
Summary: BindingRestTest.testDeleteBinding failed with 500
internal server error - Too many entries in path. Expected 2; path: []
Key: QPID-5364
URL: https://issues.apache.org/jira/browse/QPID-5364
Project: Qpid
Issue Type: Bug
Components: Java Broker
Reporter: Keith Wall
Test BindingRestTest.testDeleteBinding failed on a CI (against trunk a RHEL 5.8
).
The logs show that the servlet failed with exception Too many entries in path.
Expected [hierarchy length] 2 which is surprising the binding servlet has a
hierarchy length of 4. This suggests that somehow the servlet request is being
routed to the wrong servlet.
I've since reproduced the problem once on Windows by running the test in a
loop. Extra logging showed on that occasion the bindings request was routed to
the new preferencesprovider servlet.
{noformat}
java.io.IOException: Server returned HTTP response code: 500 for URL:
http://localhost:1/rest/binding/test/amq.direct/queue/queue
at
sun.net.www.protocol.http.HttpURLConnection.getInputStream(HttpURLConnection.java:1479)
at
org.apache.qpid.systest.rest.RestTestHelper.readConnectionInputStream(RestTestHelper.java:177)
at
org.apache.qpid.systest.rest.RestTestHelper.readJsonResponseAsList(RestTestHelper.java:150)
at
org.apache.qpid.systest.rest.RestTestHelper.getJsonAsList(RestTestHelper.java:248)
at
org.apache.qpid.systest.rest.BindingRestTest.testDeleteBinding(BindingRestTest.java:84)
at
org.apache.qpid.test.utils.QpidBrokerTestCase.runBare(QpidBrokerTestCase.java:306)
at org.apache.qpid.test.utils.QpidTestCase.run(QpidTestCase.java:150)
{noformat}
The logs show:
{noformat}
java.lang.IllegalArgumentException: Too many entries in path. Expected 2; path:
[]
at
org.apache.qpid.server.management.plugin.servlet.rest.RestServlet.getObjects(RestServlet.java:124)
at
org.apache.qpid.server.management.plugin.servlet.rest.RestServlet.doGetWithSubjectAndActor(RestServlet.java:294)
at
org.apache.qpid.server.management.plugin.servlet.rest.AbstractServlet$1.run(AbstractServlet.java:80)
at
org.apache.qpid.server.management.plugin.servlet.rest.AbstractServlet$1.run(AbstractServlet.java:76)
at
java.security.AccessController.doPrivileged(AccessController.java:362)
{noformat}
--
This message was sent by Atlassian JIRA
(v6.1#6144)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
Re: Review Request 15677: Windows client error closing AMQP 1.0 connection
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15677/#review29162
---
Ship it!
The same fix is needed in SslTransport I believe. Though that may not be used
on windows and may not actually show up he same crash, the code as is does have
a race condition so even for Linux it is a bug in my view.
- Gordon Sim
On Nov. 19, 2013, 7:53 p.m., Chug Rolke wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15677/
---
(Updated Nov. 19, 2013, 7:53 p.m.)
Review request for qpid, Andrew Stitcher and Steve Huston.
Bugs: QPID-5363
https://issues.apache.org/jira/browse/QPID-5363
Repository: qpid
Description
---
Windows fails with an access violation about 10% of the time while closing
AMQP 1.0 connections:
STACK
=
qpidmessagingd.dll!qpid::messaging::amqp::TcpTransport::close()
Line 123 + 0x10 bytesC++
qpidmessagingd.dll!qpid::messaging::amqp::ConnectionContext::close()
Line 134 + 0x29 bytesC++
qpidmessagingd.dll!qpid::messaging::amqp::ConnectionHandle::close()
Line 62C++
qpidmessagingd.dll!qpid::messaging::Connection::close() Line 78 +
0x24 bytesC++
hello_world.exe!main(int argc=4, char * * argv=0x0053a688) Line 51
+ 0xe bytesC++
hello_world.exe!__tmainCRTStartup() Line 586 + 0x19 bytesC
hello_world.exe!mainCRTStartup() Line 403C
CODE
void TcpTransport::close()
{
QPID_LOG(debug, id TcpTransport closing...);
if (aio)
aio-queueWriteClose();===
}
FAILURE
===
aio's vftable is all 0x, indicating that it has been deleted.
THE FIX
===
Use some locks to protect closing the aio object.
DISCUSSION
==
The locks in the diff appear to work ok in that the code passes thousands of
runs. Are they OK theoretically?
Include in 0.26 release
---
Please indicate your approval or not in QPID-5363.
Diffs
-
trunk/qpid/cpp/src/qpid/messaging/amqp/TcpTransport.h 1543532
trunk/qpid/cpp/src/qpid/messaging/amqp/TcpTransport.cpp 1543532
Diff: https://reviews.apache.org/r/15677/diff/
Testing
---
Running HelloWorld in a loop in multiple windows works ok.
Passes unit tests
Thanks,
Chug Rolke
Re: Review Request 15677: Windows client error closing AMQP 1.0 connection
On Nov. 19, 2013, 8:08 p.m., Andrew Stitcher wrote:
I don't think the locks can deadlock, so from that point of view they are
ok theoretically.
But there are some very important open questions in my mind:
1. Why there are multiple callers of close and is there a good reason for
it.
2. Why don't we see crashes under Linux too, and does this fix work there?
3. Also this looks like cut'n'paste programming from code elsewhere in the
tree - are you sure that the original doesn't also have the bug (and if not
why not?)
1. I can see two hypothetical reasons for the problem. The first is that the
disconnected callback is called by the windows IO layer when the remote peer -
i.e. the broker - closes the socket, whereas on linux the eof callback is
called. If, as seems to be the case for linux, a disconnected callback is
always followed by a closed callback, then socketClosed(), and therefore
queueForDeletion() would be called twice. The second possibility is
disconnection by the remote peer concurrent with a close request from the
application. Certainly the code as it is now (prior to this patch) has a race
condition in it that doesn't handle that concurrency adequately. The patch here
addresses both of these hypothetical problems. Some extra tracing could shed
some light in which (if either) of these is happening.
2. The fix does work on linux. My guess as to why we don't see the same crashes
is due to differences in the underlying AsynchIO implementations. Perhaps its
as simple as timing related. It does seem that on linux the disconnected event
isn't called, at least in the common cases. Perhaps the posix implementation is
more tolerant of double calls to queueForDeletion()?
3. The code here is largely copied from qpid::client::TcpConnector, differing
mainly in the encode and decode. There is some other locking in that class that
would I think prevent the race. The same concerns around the disconnected
callback handler apply, but I'm wondering whether that is only ever actually
called in response to abort()?.
- Gordon
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15677/#review29132
---
On Nov. 19, 2013, 7:53 p.m., Chug Rolke wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15677/
---
(Updated Nov. 19, 2013, 7:53 p.m.)
Review request for qpid, Andrew Stitcher and Steve Huston.
Bugs: QPID-5363
https://issues.apache.org/jira/browse/QPID-5363
Repository: qpid
Description
---
Windows fails with an access violation about 10% of the time while closing
AMQP 1.0 connections:
STACK
=
qpidmessagingd.dll!qpid::messaging::amqp::TcpTransport::close()
Line 123 + 0x10 bytesC++
qpidmessagingd.dll!qpid::messaging::amqp::ConnectionContext::close()
Line 134 + 0x29 bytesC++
qpidmessagingd.dll!qpid::messaging::amqp::ConnectionHandle::close()
Line 62C++
qpidmessagingd.dll!qpid::messaging::Connection::close() Line 78 +
0x24 bytesC++
hello_world.exe!main(int argc=4, char * * argv=0x0053a688) Line 51
+ 0xe bytesC++
hello_world.exe!__tmainCRTStartup() Line 586 + 0x19 bytesC
hello_world.exe!mainCRTStartup() Line 403C
CODE
void TcpTransport::close()
{
QPID_LOG(debug, id TcpTransport closing...);
if (aio)
aio-queueWriteClose();===
}
FAILURE
===
aio's vftable is all 0x, indicating that it has been deleted.
THE FIX
===
Use some locks to protect closing the aio object.
DISCUSSION
==
The locks in the diff appear to work ok in that the code passes thousands of
runs. Are they OK theoretically?
Include in 0.26 release
---
Please indicate your approval or not in QPID-5363.
Diffs
-
trunk/qpid/cpp/src/qpid/messaging/amqp/TcpTransport.h 1543532
trunk/qpid/cpp/src/qpid/messaging/amqp/TcpTransport.cpp 1543532
Diff: https://reviews.apache.org/r/15677/diff/
Testing
---
Running HelloWorld in a loop in multiple windows works ok.
Passes unit tests
Thanks,
Chug Rolke
[jira] [Resolved] (QPIDJMS-4) Add findbugs configuration
[ https://issues.apache.org/jira/browse/QPIDJMS-4?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robbie Gemmell resolved QPIDJMS-4. -- Resolution: Fixed Resolving since this was committed, further changes can go via a new JIRA. Add findbugs configuration -- Key: QPIDJMS-4 URL: https://issues.apache.org/jira/browse/QPIDJMS-4 Project: Qpid JMS Issue Type: Improvement Reporter: Philip Harvey Assignee: Philip Harvey Priority: Minor This is being done as a quick way for us to keep track of code quality. We might remove this config if we set up integration with https://analysis.apache.org/. -- This message was sent by Atlassian JIRA (v6.1#6144) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Closed] (QPIDJMS-7) add support for providing SSL configuration other than the JVM default
[
https://issues.apache.org/jira/browse/QPIDJMS-7?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robbie Gemmell closed QPIDJMS-7.
Resolution: Invalid
Changed my mind on leaving this open, closing since it is probably better to
raise a new JIRA than discuss two different clients on the same one.
add support for providing SSL configuration other than the JVM default
--
Key: QPIDJMS-7
URL: https://issues.apache.org/jira/browse/QPIDJMS-7
Project: Qpid JMS
Issue Type: Improvement
Reporter: mrich
Provide a mechanism for supplying SSL parameters (e.g. keystore information)
to the JMS AMQP 1.0 client at a per connection/factory level.
Currently, in {{org.apache.qpid.amqp_1_0.client.Connection}} the default
{{SSLSocketFactory}} is used, which only picks up the default SSL information
provided by either the Java options or setting the system properties.
More details and the origin of this discussion can be found on the mailing
list thread:
http://qpid.2158936.n2.nabble.com/Specifying-SSL-information-in-URL-for-AMQP-1-0-tp7598974.html
--
This message was sent by Atlassian JIRA
(v6.1#6144)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Created] (QPIDJMS-9) implement the JMS Message types and support for mapping them to/from AMQP messages
Robbie Gemmell created QPIDJMS-9: Summary: implement the JMS Message types and support for mapping them to/from AMQP messages Key: QPIDJMS-9 URL: https://issues.apache.org/jira/browse/QPIDJMS-9 Project: Qpid JMS Issue Type: Task Reporter: Robbie Gemmell Assignee: Robbie Gemmell implement the JMS message types and support for mapping them to/from AMQP messages -- This message was sent by Atlassian JIRA (v6.1#6144) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPIDJMS-9) implement the JMS Message types and support for mapping them to/from AMQP messages
[ https://issues.apache.org/jira/browse/QPIDJMS-9?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13827704#comment-13827704 ] ASF subversion and git services commented on QPIDJMS-9: --- Commit 1543828 from [~gemmellr] in branch 'jms/trunk' [ https://svn.apache.org/r1543828 ] QPIDJMS-9: initial work on Message implementation and mapping to/from AMQP messages - Add some initial stub Message implementations - Initial support constructing appropriate Message type instances based on the incoming AMQP payload - Add abilities to TestAmqpPeer for sending and matching additional message sections such as MessageAnnotations, Properties, and Data. - Add some integration tests for sending/receiving TextMessage and BytesMessage implement the JMS Message types and support for mapping them to/from AMQP messages -- Key: QPIDJMS-9 URL: https://issues.apache.org/jira/browse/QPIDJMS-9 Project: Qpid JMS Issue Type: Task Reporter: Robbie Gemmell Assignee: Robbie Gemmell implement the JMS message types and support for mapping them to/from AMQP messages -- This message was sent by Atlassian JIRA (v6.1#6144) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Created] (QPID-5365) Clean up file locations in Dispatch
Justin Ross created QPID-5365: - Summary: Clean up file locations in Dispatch Key: QPID-5365 URL: https://issues.apache.org/jira/browse/QPID-5365 Project: Qpid Issue Type: Improvement Components: Qpid Dispatch Reporter: Justin Ross Assignee: Justin Ross The attached patch makes the file locations consistent wrt the conventions outlined in QPID-5351 and otherwise removes redundancies, simplifies, and prepares for future additions. With this change, the tests and installs without error in my environment. -- This message was sent by Atlassian JIRA (v6.1#6144) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Updated] (QPID-5365) Clean up file locations in Dispatch
[ https://issues.apache.org/jira/browse/QPID-5365?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Ross updated QPID-5365: -- Attachment: relocations.patch Summary of changes: python/qpiddx - python/qpid_dispatch To match the C code; dx is no longer used in the code qpid_dispatch/qdtoollibs - qpid_dispatch/tools It's already qualified by its location router/router_engine.py - router/engine.py It's already under router tools/disp.py - qdtoollibs/display.py Avoid needless abbreviation README.md - README Make it match the other top-level doc files; that it's markdown is incidental release.sh - bin/release.sh There's another script I intend to add, so we'll need a place for such scripts Clean up file locations in Dispatch --- Key: QPID-5365 URL: https://issues.apache.org/jira/browse/QPID-5365 Project: Qpid Issue Type: Improvement Components: Qpid Dispatch Reporter: Justin Ross Assignee: Justin Ross Attachments: relocations.patch The attached patch makes the file locations consistent wrt the conventions outlined in QPID-5351 and otherwise removes redundancies, simplifies, and prepares for future additions. With this change, the tests and installs without error in my environment. -- This message was sent by Atlassian JIRA (v6.1#6144) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-5365) Clean up file locations in Dispatch
[ https://issues.apache.org/jira/browse/QPID-5365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13827746#comment-13827746 ] Justin Ross commented on QPID-5365: --- Ted, if you approve of this change, I can commit it. The patch may not handle some of the deletions well. Clean up file locations in Dispatch --- Key: QPID-5365 URL: https://issues.apache.org/jira/browse/QPID-5365 Project: Qpid Issue Type: Improvement Components: Qpid Dispatch Reporter: Justin Ross Assignee: Justin Ross Attachments: relocations.patch The attached patch makes the file locations consistent wrt the conventions outlined in QPID-5351 and otherwise removes redundancies, simplifies, and prepares for future additions. With this change, the tests and installs without error in my environment. -- This message was sent by Atlassian JIRA (v6.1#6144) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-5365) Clean up file locations in Dispatch
[ https://issues.apache.org/jira/browse/QPID-5365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13827899#comment-13827899 ] Darryl L. Pierce commented on QPID-5365: We really can't nest the tools library within the package name for the router's private libraries. With QPID-5335, the two sets of Python code will be installed to two different locations. * qpid_dispatch under /usr/lib/qpid-dispatch/ * the tools package to /usr/lib/python2.7/site-packages Python won't work with the same top level package in two different locations; i.e., if it tries to import qpid_dispatch/tools/foo but it has the private library in its path first, it will fail. Clean up file locations in Dispatch --- Key: QPID-5365 URL: https://issues.apache.org/jira/browse/QPID-5365 Project: Qpid Issue Type: Improvement Components: Qpid Dispatch Reporter: Justin Ross Assignee: Justin Ross Attachments: relocations.patch The attached patch makes the file locations consistent wrt the conventions outlined in QPID-5351 and otherwise removes redundancies, simplifies, and prepares for future additions. With this change, the tests and installs without error in my environment. -- This message was sent by Atlassian JIRA (v6.1#6144) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Created] (QPID-5366) qpid segfaults in qpid::ha::BrokerReplicator::disconnected
Alan Conway created QPID-5366: - Summary: qpid segfaults in qpid::ha::BrokerReplicator::disconnected Key: QPID-5366 URL: https://issues.apache.org/jira/browse/QPID-5366 Project: Qpid Issue Type: Bug Components: C++ Clustering Affects Versions: 0.24 Reporter: Alan Conway Assignee: Alan Conway Relocating the qpidd-primary service while the cluster is under load was causing sporadic core dumps in BrokerReplicator::disconnected. For details see: https://bugzilla.redhat.com/show_bug.cgi?id=1030608 -- This message was sent by Atlassian JIRA (v6.1#6144) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Resolved] (QPID-5366) qpid segfaults in qpid::ha::BrokerReplicator::disconnected
[ https://issues.apache.org/jira/browse/QPID-5366?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alan Conway resolved QPID-5366. --- Resolution: Fixed qpid segfaults in qpid::ha::BrokerReplicator::disconnected --- Key: QPID-5366 URL: https://issues.apache.org/jira/browse/QPID-5366 Project: Qpid Issue Type: Bug Components: C++ Clustering Affects Versions: 0.24 Reporter: Alan Conway Assignee: Alan Conway Relocating the qpidd-primary service while the cluster is under load was causing sporadic core dumps in BrokerReplicator::disconnected. For details see: https://bugzilla.redhat.com/show_bug.cgi?id=1030608 -- This message was sent by Atlassian JIRA (v6.1#6144) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-5365) Clean up file locations in Dispatch
[ https://issues.apache.org/jira/browse/QPID-5365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13827913#comment-13827913 ] Justin Ross commented on QPID-5365: --- I think that's a good change to make, but this patch is against the current state of affairs. AFAICT, there haven't been any changes yet to address QPID-5335. There's no patch there either. The only associated change seems to be misattributed. And the next step: none of the qpid dispatch python code needs to be in site-packages, at least so far. All of it IMO can go to /usr/lib/qpid-dispatch. Finally, why /usr/*lib*/qpid-dispatch, out of curiosity? I was thinking /usr/share/qpid-dispatch made more sense. I'd love any pointers to guidelines you have. Clean up file locations in Dispatch --- Key: QPID-5365 URL: https://issues.apache.org/jira/browse/QPID-5365 Project: Qpid Issue Type: Improvement Components: Qpid Dispatch Reporter: Justin Ross Assignee: Justin Ross Attachments: relocations.patch The attached patch makes the file locations consistent wrt the conventions outlined in QPID-5351 and otherwise removes redundancies, simplifies, and prepares for future additions. With this change, the tests and installs without error in my environment. -- This message was sent by Atlassian JIRA (v6.1#6144) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-5366) qpid segfaults in qpid::ha::BrokerReplicator::disconnected
[ https://issues.apache.org/jira/browse/QPID-5366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13827912#comment-13827912 ] ASF subversion and git services commented on QPID-5366: --- Commit 1543893 from [~aconway] in branch 'qpid/trunk' [ https://svn.apache.org/r1543893 ] QPID-5366: qpid segfaults in qpid::ha::BrokerReplicator::disconnected Fix for a race condition: previously, BrokerReplicator created a separate ConnectionObserver object to forward connection events to it. However the Observers locking is such that it is possible for an event to arrive *after* calling Observers::remove (Observers copies the pointers and delivers events outside its lock.) This meant that it was possible for a call to BrokerReplicator::disconnect to be made after the BrokerReplicator was deleted. The fix is to combine BrokerReplicator and BrokerReplicator::ConnectionObserver into a single object with one lifetime that will last until it is removed from both the ExchangeRegistry and the ConnectionObservers. qpid segfaults in qpid::ha::BrokerReplicator::disconnected --- Key: QPID-5366 URL: https://issues.apache.org/jira/browse/QPID-5366 Project: Qpid Issue Type: Bug Components: C++ Clustering Affects Versions: 0.24 Reporter: Alan Conway Assignee: Alan Conway Relocating the qpidd-primary service while the cluster is under load was causing sporadic core dumps in BrokerReplicator::disconnected. For details see: https://bugzilla.redhat.com/show_bug.cgi?id=1030608 -- This message was sent by Atlassian JIRA (v6.1#6144) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-5365) Clean up file locations in Dispatch
[ https://issues.apache.org/jira/browse/QPID-5365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13827922#comment-13827922 ] Ted Ross commented on QPID-5365: Justin, Go ahead and commit the change. Darryl, Lets address the the private path issue on top of this update. Clean up file locations in Dispatch --- Key: QPID-5365 URL: https://issues.apache.org/jira/browse/QPID-5365 Project: Qpid Issue Type: Improvement Components: Qpid Dispatch Reporter: Justin Ross Assignee: Justin Ross Attachments: relocations.patch The attached patch makes the file locations consistent wrt the conventions outlined in QPID-5351 and otherwise removes redundancies, simplifies, and prepares for future additions. With this change, the tests and installs without error in my environment. -- This message was sent by Atlassian JIRA (v6.1#6144) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-5365) Clean up file locations in Dispatch
[ https://issues.apache.org/jira/browse/QPID-5365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13827945#comment-13827945 ] ASF subversion and git services commented on QPID-5365: --- Commit 1543898 from [~justi9] in branch 'dispatch/trunk' [ https://svn.apache.org/r1543898 ] QPID-5365: Clean up file locations Clean up file locations in Dispatch --- Key: QPID-5365 URL: https://issues.apache.org/jira/browse/QPID-5365 Project: Qpid Issue Type: Improvement Components: Qpid Dispatch Reporter: Justin Ross Assignee: Justin Ross Attachments: relocations.patch The attached patch makes the file locations consistent wrt the conventions outlined in QPID-5351 and otherwise removes redundancies, simplifies, and prepares for future additions. With this change, the tests and installs without error in my environment. -- This message was sent by Atlassian JIRA (v6.1#6144) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Resolved] (QPID-5365) Clean up file locations in Dispatch
[ https://issues.apache.org/jira/browse/QPID-5365?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Ross resolved QPID-5365. --- Resolution: Fixed Clean up file locations in Dispatch --- Key: QPID-5365 URL: https://issues.apache.org/jira/browse/QPID-5365 Project: Qpid Issue Type: Improvement Components: Qpid Dispatch Reporter: Justin Ross Assignee: Justin Ross Attachments: relocations.patch The attached patch makes the file locations consistent wrt the conventions outlined in QPID-5351 and otherwise removes redundancies, simplifies, and prepares for future additions. With this change, the tests and installs without error in my environment. -- This message was sent by Atlassian JIRA (v6.1#6144) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Created] (QPID-5367) Dispatch - Add man pages and stubs for other documentation
Justin Ross created QPID-5367: - Summary: Dispatch - Add man pages and stubs for other documentation Key: QPID-5367 URL: https://issues.apache.org/jira/browse/QPID-5367 Project: Qpid Issue Type: Improvement Components: Qpid Dispatch Reporter: Justin Ross Assignee: Justin Ross - Man pages for qdstat, qdrouterd, and qdrouterd.conf - Start a book for more involved documentation, and port some of the content from the website - Add a place for developer notes; add a note about code conventions - Add a place for api doc resources such as an overview for doxygen -- This message was sent by Atlassian JIRA (v6.1#6144) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-5365) Clean up file locations in Dispatch
[ https://issues.apache.org/jira/browse/QPID-5365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13827973#comment-13827973 ] ASF subversion and git services commented on QPID-5365: --- Commit 1543905 from [~tedross] in branch 'dispatch/trunk' [ https://svn.apache.org/r1543905 ] QPID-5365 - More cleanup related to file locations. Clean up file locations in Dispatch --- Key: QPID-5365 URL: https://issues.apache.org/jira/browse/QPID-5365 Project: Qpid Issue Type: Improvement Components: Qpid Dispatch Reporter: Justin Ross Assignee: Justin Ross Attachments: relocations.patch The attached patch makes the file locations consistent wrt the conventions outlined in QPID-5351 and otherwise removes redundancies, simplifies, and prepares for future additions. With this change, the tests and installs without error in my environment. -- This message was sent by Atlassian JIRA (v6.1#6144) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-5365) Clean up file locations in Dispatch
[ https://issues.apache.org/jira/browse/QPID-5365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13827983#comment-13827983 ] Darryl L. Pierce commented on QPID-5365: Ted: Okay. Justin: I discussed the issue with a few people in the #fedora-devel channel on Freenode. There it was suggested to go under /usr/lib/[appname] since they're libraries, but not public libraries. That said, /usr/lib/qpid-dispatch and /usr/share/qpid-dispatch are equally represented, and in the packaging guidelines [1] I found it references /usr/share specifically. [1] http://fedoraproject.org/wiki/Packaging:Python Clean up file locations in Dispatch --- Key: QPID-5365 URL: https://issues.apache.org/jira/browse/QPID-5365 Project: Qpid Issue Type: Improvement Components: Qpid Dispatch Reporter: Justin Ross Assignee: Justin Ross Attachments: relocations.patch The attached patch makes the file locations consistent wrt the conventions outlined in QPID-5351 and otherwise removes redundancies, simplifies, and prepares for future additions. With this change, the tests and installs without error in my environment. -- This message was sent by Atlassian JIRA (v6.1#6144) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Updated] (QPID-4853) Connectors are not closed when connections are closed cleanly
[ https://issues.apache.org/jira/browse/QPID-4853?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Ross updated QPID-4853: -- Assignee: (was: Ted Ross) Connectors are not closed when connections are closed cleanly - Key: QPID-4853 URL: https://issues.apache.org/jira/browse/QPID-4853 Project: Qpid Issue Type: Bug Components: Qpid Dispatch Reporter: Ted Ross Priority: Blocker When a connection is closed cleanly by a client, the pn_connector_closed condition never occurs and the connector is not closed. -- This message was sent by Atlassian JIRA (v6.1#6144) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Comment Edited] (QPID-5365) Clean up file locations in Dispatch
[ https://issues.apache.org/jira/browse/QPID-5365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13827983#comment-13827983 ] Darryl L. Pierce edited comment on QPID-5365 at 11/20/13 7:08 PM: -- Ted: Okay. Justin: I discussed the issue with a few people in the #fedora-devel channel on Freenode. There it was suggested to go under /usr/lib/[appname] since they're libraries, but not public libraries. That said, /usr/lib/qpid-dispatch and /usr/share/qpid-dispatch are equally represented, and in the packaging guidelines [1] I found it mentions /usr/share specifically. Not as a guideline, but the closest I found to such. [1] http://fedoraproject.org/wiki/Packaging:Python was (Author: mcpierce): Ted: Okay. Justin: I discussed the issue with a few people in the #fedora-devel channel on Freenode. There it was suggested to go under /usr/lib/[appname] since they're libraries, but not public libraries. That said, /usr/lib/qpid-dispatch and /usr/share/qpid-dispatch are equally represented, and in the packaging guidelines [1] I found it references /usr/share specifically. [1] http://fedoraproject.org/wiki/Packaging:Python Clean up file locations in Dispatch --- Key: QPID-5365 URL: https://issues.apache.org/jira/browse/QPID-5365 Project: Qpid Issue Type: Improvement Components: Qpid Dispatch Reporter: Justin Ross Assignee: Justin Ross Attachments: relocations.patch The attached patch makes the file locations consistent wrt the conventions outlined in QPID-5351 and otherwise removes redundancies, simplifies, and prepares for future additions. With this change, the tests and installs without error in my environment. -- This message was sent by Atlassian JIRA (v6.1#6144) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Created] (QPID-5368) Dispatch - Exercise qdstat in the tests
Justin Ross created QPID-5368: - Summary: Dispatch - Exercise qdstat in the tests Key: QPID-5368 URL: https://issues.apache.org/jira/browse/QPID-5368 Project: Qpid Issue Type: Improvement Components: Qpid Dispatch Reporter: Justin Ross Assignee: Justin Ross Make sure qdstat is executed in various ways when the developer runs make test. -- This message was sent by Atlassian JIRA (v6.1#6144) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-5368) Dispatch - Exercise qdstat in the tests
[ https://issues.apache.org/jira/browse/QPID-5368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13828014#comment-13828014 ] Ted Ross commented on QPID-5368: You should be able to do this in the context of system_tests_one_router.py. All the tests in that module operate against a running router. Dispatch - Exercise qdstat in the tests --- Key: QPID-5368 URL: https://issues.apache.org/jira/browse/QPID-5368 Project: Qpid Issue Type: Improvement Components: Qpid Dispatch Reporter: Justin Ross Assignee: Justin Ross Make sure qdstat is executed in various ways when the developer runs make test. -- This message was sent by Atlassian JIRA (v6.1#6144) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Updated] (QPID-5217) Dispatch - Cleanup of API inconsistencies and oddities
[ https://issues.apache.org/jira/browse/QPID-5217?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Ross updated QPID-5217: -- Attachment: callback-typedef.patch Minor cleanup. All the other callbacks seem to use _t. Dispatch - Cleanup of API inconsistencies and oddities -- Key: QPID-5217 URL: https://issues.apache.org/jira/browse/QPID-5217 Project: Qpid Issue Type: Improvement Components: Qpid Dispatch Reporter: Ted Ross Assignee: Ted Ross Attachments: callback-typedef.patch This issue is for various API-related issues like cleanup, documentation, consistency, etc. in the Dispatch header files. -- This message was sent by Atlassian JIRA (v6.1#6144) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-5217) Dispatch - Cleanup of API inconsistencies and oddities
[ https://issues.apache.org/jira/browse/QPID-5217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13828020#comment-13828020 ] ASF subversion and git services commented on QPID-5217: --- Commit 1543912 from [~tedross] in branch 'dispatch/trunk' [ https://svn.apache.org/r1543912 ] QPID-5217 - Applied patch from Justin Ross Dispatch - Cleanup of API inconsistencies and oddities -- Key: QPID-5217 URL: https://issues.apache.org/jira/browse/QPID-5217 Project: Qpid Issue Type: Improvement Components: Qpid Dispatch Reporter: Ted Ross Assignee: Ted Ross Attachments: callback-typedef.patch This issue is for various API-related issues like cleanup, documentation, consistency, etc. in the Dispatch header files. -- This message was sent by Atlassian JIRA (v6.1#6144) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-5363) C++ HelloWorld messaging client crash closing AMQP 1.0 connection on Windows
[ https://issues.apache.org/jira/browse/QPID-5363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13828075#comment-13828075 ] ASF subversion and git services commented on QPID-5363: --- Commit 1543935 from c...@apache.org in branch 'qpid/trunk' [ https://svn.apache.org/r1543935 ] QPID-5363: Add locks to prevent race condition in Amqp 1.0 transport handler. Windows clients occasionally crash on exit handling simultaneous eof() and close() on separate threads. C++ HelloWorld messaging client crash closing AMQP 1.0 connection on Windows Key: QPID-5363 URL: https://issues.apache.org/jira/browse/QPID-5363 Project: Qpid Issue Type: Bug Components: C++ Client Affects Versions: 0.25 Environment: Windows, native C++ client, Amqp 1.0 protocol, Visual Studio 2008, 32-bit, Debug Reporter: Chuck Rolke HelloWorld connects, send all messages, and then crashes with an access violation during connection::close(). Gordon and I tracked the issue down to a double free of TcpTransport aio objects, with the __vftable containing all 0x pointers indicating that the object was already deleted. Without the proposed fix, a locked 'closed' flag, the code crashes about 10% of the time. With the fix it proceeds indefinitely. -- This message was sent by Atlassian JIRA (v6.1#6144) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Created] (QPID-5369) [qmf] Add deprecation warnings to the C++ Agent/Console API headers
Ken Giusti created QPID-5369: Summary: [qmf] Add deprecation warnings to the C++ Agent/Console API headers Key: QPID-5369 URL: https://issues.apache.org/jira/browse/QPID-5369 Project: Qpid Issue Type: Wish Components: Qpid Managment Framework Affects Versions: 0.24 Reporter: Ken Giusti Assignee: Ken Giusti Fix For: 0.26 From the us...@qpid.apache.org mail thread: Hi All, I sent this email about a month ago with no replies to date. So I'd thought I'd re-ping the list. Is anyone using these libraries? If not, then I'd like to propose that we mark them as Deprecated in our upcoming 0.26 release. I volunteer adding the appropriate code warning directives to the build, so any code that attempts to include these APIs will issue deprecation warnings at compile time. We'll leave them available in the code for 0.26 (and I think at least one more release - Justin?), and if the warnings reveal a large user base, we can un-deprecate them. But in order to really stand behind this code, we'll have to invest some time in building unit tests for them. AFAIK, this stuff is not getting any test coverage right now. Opinions sought! thanks, -K - Original Message - From: Ken Giusti kgiu...@redhat.com To: us...@qpid.apache.org Sent: Thursday, October 17, 2013 1:51:32 PM Subject: Is anyone using the QMF C++ Agent and Console development libraries (libqmf2)? Hi All, Before I start investing time working on https://issues.apache.org/jira/browse/QPID-5226 and https://issues.apache.org/jira/browse/QPID-4981, I was wondering if anyone actually uses these C++ libraries. As far as I can tell, the code hasn't seen any serious development in over two years. That, and given that there are no unit tests run on that code (QPID-4981), I'm wondering if this code is actually being used. Please let me know, -K - To unsubscribe, e-mail: users-unsubscr...@qpid.apache.org For additional commands, e-mail: users-h...@qpid.apache.org -- -K -- This message was sent by Atlassian JIRA (v6.1#6144) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
Review Request 15747: [QMF] Add compile-time deprecation warnings to the C++ QMF Agent/Console API headers.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15747/ --- Review request for qpid, Andrew Stitcher and Ted Ross. Bugs: qpid-5369 https://issues.apache.org/jira/browse/qpid-5369 Repository: qpid Description --- Causes the compiler to issue deprecation warnings when the C++ Agent or Console API classes are used by applications. Works for GNU C and Microsoft Visual C++ only. Diffs - /trunk/qpid/cpp/bindings/qmf2/examples/cpp/CMakeLists.txt 1543123 /trunk/qpid/cpp/bindings/qmf2/python/CMakeLists.txt 1543123 /trunk/qpid/cpp/bindings/qmf2/ruby/CMakeLists.txt 1543123 /trunk/qpid/cpp/include/qmf/Agent.h 1543123 /trunk/qpid/cpp/include/qmf/AgentEvent.h 1543123 /trunk/qpid/cpp/include/qmf/AgentSession.h 1543123 /trunk/qpid/cpp/include/qmf/ConsoleEvent.h 1543123 /trunk/qpid/cpp/include/qmf/ConsoleSession.h 1543123 /trunk/qpid/cpp/include/qmf/Data.h 1543123 /trunk/qpid/cpp/include/qmf/DataAddr.h 1543123 /trunk/qpid/cpp/include/qmf/ImportExport.h 1543123 /trunk/qpid/cpp/include/qmf/Query.h 1543123 /trunk/qpid/cpp/include/qmf/Schema.h 1543123 /trunk/qpid/cpp/include/qmf/SchemaId.h 1543123 /trunk/qpid/cpp/include/qmf/SchemaMethod.h 1543123 /trunk/qpid/cpp/include/qmf/SchemaProperty.h 1543123 /trunk/qpid/cpp/include/qmf/Subscription.h 1543123 /trunk/qpid/cpp/include/qmf/exceptions.h 1543123 /trunk/qpid/cpp/include/qmf/posix/EventNotifier.h 1543123 Diff: https://reviews.apache.org/r/15747/diff/ Testing --- Removed the warning suppression flags and built the Agent and Console examples on linux and windows - validated that the proper deprecation warnings were issued. Thanks, Kenneth Giusti
AMQP Windows Mobile 6.5?
If I wanted to send messages via AMQP from a Windows Mobile 6.5 device to the Azure Service Bus would the qpid C library be the best option? Sent from my Windows Phone
