---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16316/
---
Review request for qpid, Chug Rolke and Gordon Sim.
Bugs: QPID-5415
[
https://issues.apache.org/jira/browse/QPID-5415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13850222#comment-13850222
]
Andrew Stitcher edited comment on QPID-5415 at 12/17/13 8:05 AM:
[
https://issues.apache.org/jira/browse/QPID-5415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13850222#comment-13850222
]
Andrew Stitcher commented on QPID-5415:
---
There is an open review for proposed code:
Andrew Stitcher created QPID-5427:
-
Summary: It is possible to mask critical logging messages
Key: QPID-5427
URL: https://issues.apache.org/jira/browse/QPID-5427
Project: Qpid
Issue Type:
[
https://issues.apache.org/jira/browse/QPID-5415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13850240#comment-13850240
]
Andrew Stitcher commented on QPID-5415:
---
Currently the tests for the proposed change
[
https://issues.apache.org/jira/browse/QPID-5429?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Keith Wall updated QPID-5429:
-
Priority: Minor (was: Major)
Java Broker does not always write the reason it cannot start-up to
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16316/#review30527
---
Ship it!
Couple of questions, just to be sure, but looks good to
[
https://issues.apache.org/jira/browse/QPID-5419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13850414#comment-13850414
]
Rob Godfrey commented on QPID-5419:
---
Merged to 0.26 branch:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16316/#review30530
---
Ship it!
Minor doc nits and some explanation for the wiki .
[
https://issues.apache.org/jira/browse/QPID-5428?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gordon Sim reassigned QPID-5428:
Assignee: Alan Conway
heartbeats not in use when attempting to connect
On Dec. 17, 2013, 2:46 p.m., Chug Rolke wrote:
/trunk/qpid/cpp/src/qpid/messaging/Logger.cpp, line 68
https://reviews.apache.org/r/16316/diff/1/?file=398793#file398793line68
How is this function's body not surrounded with {}? Seems unnatural.
This is just a rarely used part of the
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16316/#review30539
---
/trunk/qpid/cpp/include/qpid/messaging/Logger.h
[
https://issues.apache.org/jira/browse/QPID-5255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13850658#comment-13850658
]
ASF subversion and git services commented on QPID-5255:
---
Commit
[
https://issues.apache.org/jira/browse/QPID-5255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13850657#comment-13850657
]
ASF subversion and git services commented on QPID-5255:
---
Commit
On 12/16/2013 06:13 PM, Gordon Sim wrote:
On 12/16/2013 07:29 PM, Robbie Gemmell wrote:
On 16 December 2013 18:54, Alan Conway acon...@redhat.com wrote:
The following are processed by various programs, I don't know if there's a
safe comment syntax. Can we get an exemption for such files?
[
https://issues.apache.org/jira/browse/QPID-5367?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ted Ross resolved QPID-5367.
Resolution: Fixed
Dispatch - Add man pages and stubs for other documentation
[
https://issues.apache.org/jira/browse/QPID-5217?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ted Ross resolved QPID-5217.
Resolution: Fixed
Dispatch - Cleanup of API inconsistencies and oddities
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16316/
---
(Updated Dec. 17, 2013, 5:02 p.m.)
Review request for qpid, Chug Rolke and
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16316/#review30540
---
Ship it!
Nice job!
On Dec. 17, 2013, 5:10 p.m., Alan Conway wrote:
/trunk/qpid/cpp/include/qpid/messaging/Logger.h, line 85
https://reviews.apache.org/r/16316/diff/1/?file=398786#file398786line85
Chuck did some work to provide a set of sensible subsystem labels
that the pattern can match that might
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16316/#review30541
---
/trunk/qpid/cpp/include/qpid/messaging/Logger.h
On Dec. 17, 2013, 5:22 p.m., Alan Conway wrote:
/trunk/qpid/cpp/src/qpid/messaging/Logger.cpp, line 68
https://reviews.apache.org/r/16316/diff/1/?file=398793#file398793line68
That's really, really weird. I had no idea you could omit the braces in
a function definition in any
On Dec. 17, 2013, 5:22 p.m., Alan Conway wrote:
/trunk/qpid/cpp/src/qpid/messaging/Logger.cpp, line 68
https://reviews.apache.org/r/16316/diff/1/?file=398793#file398793line68
That's really, really weird. I had no idea you could omit the braces in
a function definition in any
On Dec. 17, 2013, 5:17 p.m., Andrew Stitcher wrote:
/trunk/qpid/cpp/include/qpid/messaging/Logger.h, line 85
https://reviews.apache.org/r/16316/diff/1/?file=398786#file398786line85
Those are the category names (I didn't want to be much more specific as
they aren't really very
24 matches
Mail list logo
