[jira] [Commented] (QPIDJMS-267) Support discovery of failover hosts provided in a connection property of the Open frame

2017-02-24 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/QPIDJMS-267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15883653#comment-15883653 ] ASF subversion and git services commented on QPIDJMS-267: - Commit

[jira] [Created] (QPIDJMS-267) Support discovery of failover hosts provided in a connection property of the Open frame

2017-02-24 Thread Timothy Bish (JIRA)
Timothy Bish created QPIDJMS-267: Summary: Support discovery of failover hosts provided in a connection property of the Open frame Key: QPIDJMS-267 URL: https://issues.apache.org/jira/browse/QPIDJMS-267

[jira] [Resolved] (PROTON-1416) Reconnect when receiving connection close with amqp:connection:forced condition

2017-02-24 Thread Andrew Stitcher (JIRA)
[ https://issues.apache.org/jira/browse/PROTON-1416?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Stitcher resolved PROTON-1416. - Resolution: Fixed Fix Version/s: 0.18.0 > Reconnect when receiving connection

[jira] [Commented] (PROTON-1416) Reconnect when receiving connection close with amqp:connection:forced condition

2017-02-24 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/PROTON-1416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15883572#comment-15883572 ] ASF subversion and git services commented on PROTON-1416: - Commit

[GitHub] qpid-proton pull request #95: [REVIEW] Add fuzzers to proton-c tests

2017-02-24 Thread jdanekrh
Github user jdanekrh commented on a diff in the pull request: https://github.com/apache/qpid-proton/pull/95#discussion_r103038483 --- Diff: proton-c/CMakeLists.txt --- @@ -729,6 +729,12 @@ if (BUILD_PYTHON) endif (BUILD_PYTHON) +# fuzz tests: tests/fuzz

[GitHub] qpid-proton issue #95: [REVIEW] Add fuzzers to proton-c tests

2017-02-24 Thread astitcher
Github user astitcher commented on the issue: https://github.com/apache/qpid-proton/pull/95 Ok, if the function is *useful* without the fuzzer then it makes sense to compile it without the fuzzer. Sold. --- If your project is set up for it, you can reply to this email and

[jira] [Created] (PROTON-1416) Reconnect when receiving connection close with amqp:connection:forced condition

2017-02-24 Thread Andrew Stitcher (JIRA)
Andrew Stitcher created PROTON-1416: --- Summary: Reconnect when receiving connection close with amqp:connection:forced condition Key: PROTON-1416 URL: https://issues.apache.org/jira/browse/PROTON-1416

[GitHub] qpid-proton issue #95: [REVIEW] Add fuzzers to proton-c tests

2017-02-24 Thread kcc
Github user kcc commented on the issue: https://github.com/apache/qpid-proton/pull/95 on oss-fuzz we use adapters between e.g. AFL and LLVMFuzzerTestOneInput. See e.g. https://github.com/llvm-mirror/llvm/blob/master/lib/Fuzzer/afl/afl_driver.cpp So, a fuzzer does not have to

[GitHub] qpid-proton issue #95: [REVIEW] Add fuzzers to proton-c tests

2017-02-24 Thread astitcher
Github user astitcher commented on the issue: https://github.com/apache/qpid-proton/pull/95 Assuming that any compatible fuzzer has to have the same interface (assuming they all use LLVMFuzzerTestOneInput) then they all need to supply a compatible definition. It's not as if

[jira] [Commented] (PROTON-1415) go binding does not create durable subscriber

2017-02-24 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/PROTON-1415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15883540#comment-15883540 ] ASF subversion and git services commented on PROTON-1415: - Commit

[jira] [Resolved] (PROTON-1415) go binding does not create durable subscriber

2017-02-24 Thread Alan Conway (JIRA)
[ https://issues.apache.org/jira/browse/PROTON-1415?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alan Conway resolved PROTON-1415. - Resolution: Fixed > go binding does not create durable subscriber >

[jira] [Comment Edited] (PROTON-1415) go binding does not create durable subscriber

2017-02-24 Thread Andrew Stitcher (JIRA)
[ https://issues.apache.org/jira/browse/PROTON-1415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15883493#comment-15883493 ] Andrew Stitcher edited comment on PROTON-1415 at 2/24/17 9:12 PM: --

[jira] [Reopened] (PROTON-1415) go binding does not create durable subscriber

2017-02-24 Thread Andrew Stitcher (JIRA)
[ https://issues.apache.org/jira/browse/PROTON-1415?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Stitcher reopened PROTON-1415: - > go binding does not create durable subscriber >

[jira] [Commented] (PROTON-1415) go binding does not create durable subscriber

2017-02-24 Thread Andrew Stitcher (JIRA)
[ https://issues.apache.org/jira/browse/PROTON-1415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15883493#comment-15883493 ] Andrew Stitcher commented on PROTON-1415: - [~aconway] Note that changing the

[GitHub] qpid-proton issue #95: [REVIEW] Add fuzzers to proton-c tests

2017-02-24 Thread kcc
Github user kcc commented on the issue: https://github.com/apache/qpid-proton/pull/95 Re declaration of LLVMFuzzerTestOneInput -- libFuzzer does have a single interface header, FuzzerInterface.h, but we typically ask *not* to use it because we want the fuzz targets to be 100%

[GitHub] qpid-proton issue #95: [REVIEW] Add fuzzers to proton-c tests

2017-02-24 Thread kcc
Github user kcc commented on the issue: https://github.com/apache/qpid-proton/pull/95 We use the approach with binary files in a few other repos (e.g. https://github.com/google/boringssl/tree/master/fuzz) and it works perfect. Note that this is not only a seed for fudzzing, but

[GitHub] qpid-proton issue #95: [REVIEW] Add fuzzers to proton-c tests

2017-02-24 Thread astitcher
Github user astitcher commented on the issue: https://github.com/apache/qpid-proton/pull/95 Also, in general I'm not usually happy to check in generated (especially) binary files to a source code repository. I understand the purpose here, but it seems messy to me. --- If

[jira] [Resolved] (QPID-7679) Memory leak in DirectExchange

2017-02-24 Thread Cliff Jansen (JIRA)
[ https://issues.apache.org/jira/browse/QPID-7679?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Cliff Jansen resolved QPID-7679. Resolution: Resolved Fix Version/s: qpid-cpp-1.37.0 > Memory leak in DirectExchange >

[GitHub] qpid-proton issue #95: [REVIEW] Add fuzzers to proton-c tests

2017-02-24 Thread astitcher
Github user astitcher commented on the issue: https://github.com/apache/qpid-proton/pull/95 In general though it's more important to get this into the repo so it can be used going forward and then maybe it can be tidied up later. --- If your project is set up for it, you can reply

[GitHub] qpid-proton issue #95: [REVIEW] Add fuzzers to proton-c tests

2017-02-24 Thread astitcher
Github user astitcher commented on the issue: https://github.com/apache/qpid-proton/pull/95 I'd be happy with just hex files, but the binary files are virtually impossible to use sensibly without extra tools as a developer. It might be a bit better with the fuzzing code

[GitHub] qpid-proton issue #95: [REVIEW] Add fuzzers to proton-c tests

2017-02-24 Thread jdanekrh
Github user jdanekrh commented on the issue: https://github.com/apache/qpid-proton/pull/95 I forgot to comment about hex files. Sure, but then there would have to be a conversion step to hex when adding file to corpus and a conversion step from hex to binary before starting

[GitHub] qpid-proton issue #95: [REVIEW] Add fuzzers to proton-c tests

2017-02-24 Thread jdanekrh
Github user jdanekrh commented on the issue: https://github.com/apache/qpid-proton/pull/95 I am not fan of storing binary data either, but I think it is not unreasonable given the circumstances. The corpus was generated automatically by the fuzzer. There is a greedy

[GitHub] qpid-proton pull request #95: [REVIEW] Add fuzzers to proton-c tests

2017-02-24 Thread jdanekrh
Github user jdanekrh commented on a diff in the pull request: https://github.com/apache/qpid-proton/pull/95#discussion_r102987028 --- Diff: proton-c/src/tests/fuzz/fuzz-sniff-header.c --- @@ -0,0 +1,15 @@ +#include +#include + +#include "core/autodetect.h" +

[GitHub] qpid-proton pull request #95: [REVIEW] Add fuzzers to proton-c tests

2017-02-24 Thread astitcher
Github user astitcher commented on a diff in the pull request: https://github.com/apache/qpid-proton/pull/95#discussion_r102986492 --- Diff: proton-c/src/tests/fuzz/fuzz-sniff-header.c --- @@ -0,0 +1,15 @@ +#include +#include + +#include "core/autodetect.h" +

[GitHub] qpid-proton pull request #95: [REVIEW] Add fuzzers to proton-c tests

2017-02-24 Thread jdanekrh
Github user jdanekrh commented on a diff in the pull request: https://github.com/apache/qpid-proton/pull/95#discussion_r102984140 --- Diff: proton-c/src/tests/fuzz/README.md --- @@ -0,0 +1,45 @@ +# Fuzz testing for qpid-proton-c + +## Dockerfile + +Easiest way

[GitHub] qpid-proton pull request #95: [REVIEW] Add fuzzers to proton-c tests

2017-02-24 Thread jdanekrh
Github user jdanekrh commented on a diff in the pull request: https://github.com/apache/qpid-proton/pull/95#discussion_r102983561 --- Diff: proton-c/src/tests/fuzz/fuzz-sniff-header.c --- @@ -0,0 +1,15 @@ +#include +#include + +#include "core/autodetect.h" +

[GitHub] qpid-proton issue #95: [REVIEW] Add fuzzers to proton-c tests

2017-02-24 Thread astitcher
Github user astitcher commented on the issue: https://github.com/apache/qpid-proton/pull/95 I really like the idea of putting fuzzing tests into the source tree (guarded appropriately by cmake tests). I'm not very keen about putting binary only files into the corpus. Could we

[GitHub] qpid-proton pull request #95: [REVIEW] Add fuzzers to proton-c tests

2017-02-24 Thread astitcher
Github user astitcher commented on a diff in the pull request: https://github.com/apache/qpid-proton/pull/95#discussion_r102975218 --- Diff: proton-c/src/tests/fuzz/fuzz-sniff-header.c --- @@ -0,0 +1,15 @@ +#include +#include + +#include "core/autodetect.h" +

[GitHub] qpid-proton pull request #95: [REVIEW] Add fuzzers to proton-c tests

2017-02-24 Thread jdanekrh
Github user jdanekrh commented on a diff in the pull request: https://github.com/apache/qpid-proton/pull/95#discussion_r102974488 --- Diff: proton-c/src/tests/fuzz/fuzz-sniff-header.c --- @@ -0,0 +1,15 @@ +#include +#include + +#include "core/autodetect.h" +

[GitHub] qpid-proton pull request #95: [REVIEW] Add fuzzers to proton-c tests

2017-02-24 Thread kcc
Github user kcc commented on a diff in the pull request: https://github.com/apache/qpid-proton/pull/95#discussion_r102974377 --- Diff: proton-c/src/tests/fuzz/README.md --- @@ -0,0 +1,45 @@ +# Fuzz testing for qpid-proton-c + +## Dockerfile + +Easiest way to

[GitHub] qpid-proton pull request #95: [REVIEW] Add fuzzers to proton-c tests

2017-02-24 Thread kcc
Github user kcc commented on a diff in the pull request: https://github.com/apache/qpid-proton/pull/95#discussion_r102973776 --- Diff: proton-c/src/tests/fuzz/fuzz-sniff-header.c --- @@ -0,0 +1,15 @@ +#include +#include + +#include "core/autodetect.h" +

[jira] [Updated] (QPIDJMS-239) Client ack session occasionally seen to redeliver recovered messages out of order

2017-02-24 Thread Robbie Gemmell (JIRA)
[ https://issues.apache.org/jira/browse/QPIDJMS-239?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robbie Gemmell updated QPIDJMS-239: --- Fix Version/s: (was: 0.21.0) {quote} I can reason that as

[jira] [Updated] (QPID-7618) Ring policy type

2017-02-24 Thread Alex Rudyy (JIRA)
[ https://issues.apache.org/jira/browse/QPID-7618?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alex Rudyy updated QPID-7618: - Status: Reviewable (was: In Progress) > Ring policy type > > > Key:

[jira] [Assigned] (QPID-7618) Ring policy type

2017-02-24 Thread Alex Rudyy (JIRA)
[ https://issues.apache.org/jira/browse/QPID-7618?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alex Rudyy reassigned QPID-7618: Assignee: Alex Rudyy > Ring policy type > > > Key: QPID-7618 >

[jira] [Commented] (QPID-7618) Ring policy type

2017-02-24 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/QPID-7618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15882816#comment-15882816 ] ASF subversion and git services commented on QPID-7618: --- Commit 1784282 from

[jira] [Commented] (QPID-7618) Ring policy type

2017-02-24 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/QPID-7618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15882819#comment-15882819 ] ASF subversion and git services commented on QPID-7618: --- Commit 1784284 from

[jira] [Commented] (QPID-7618) Ring policy type

2017-02-24 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/QPID-7618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15882818#comment-15882818 ] ASF subversion and git services commented on QPID-7618: --- Commit 1784283 from

[jira] [Commented] (QPIDJMS-239) Client ack session occasionally seen to redeliver recovered messages out of order

2017-02-24 Thread Timothy Bish (JIRA)
[ https://issues.apache.org/jira/browse/QPIDJMS-239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15882777#comment-15882777 ] Timothy Bish commented on QPIDJMS-239: -- Great, thanks for closing the loop on this. > Client ack

[jira] [Commented] (QPIDJMS-239) Client ack session occasionally seen to redeliver recovered messages out of order

2017-02-24 Thread Keith Wall (JIRA)
[ https://issues.apache.org/jira/browse/QPIDJMS-239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15882744#comment-15882744 ] Keith Wall commented on QPIDJMS-239: Hi Tim, Good news. I haven't been able to reproduce the issue

[jira] [Resolved] (QPIDJMS-239) Client ack session occasionally seen to redeliver recovered messages out of order

2017-02-24 Thread Keith Wall (JIRA)
[ https://issues.apache.org/jira/browse/QPIDJMS-239?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Keith Wall resolved QPIDJMS-239. Resolution: Fixed > Client ack session occasionally seen to redeliver recovered messages out of >

[jira] [Updated] (QPIDJMS-239) Client ack session occasionally seen to redeliver recovered messages out of order

2017-02-24 Thread Keith Wall (JIRA)
[ https://issues.apache.org/jira/browse/QPIDJMS-239?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Keith Wall updated QPIDJMS-239: --- Fix Version/s: 0.21.0 > Client ack session occasionally seen to redeliver recovered messages out of

[jira] [Commented] (PROTON-1415) go binding does not create durable subscriber

2017-02-24 Thread Jeremy Gooch (JIRA)
[ https://issues.apache.org/jira/browse/PROTON-1415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15882553#comment-15882553 ] Jeremy Gooch commented on PROTON-1415: -- Looks good to me. Many thanks for resolving this so

[jira] [Commented] (QPID-7618) Ring policy type

2017-02-24 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/QPID-7618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15882502#comment-15882502 ] ASF subversion and git services commented on QPID-7618: --- Commit 1784267 from

[jira] [Created] (QPID-7682) CloudFoundry group provider plugin reports 404 errors from the service as 500 errors

2017-02-24 Thread Keith Wall (JIRA)
Keith Wall created QPID-7682: Summary: CloudFoundry group provider plugin reports 404 errors from the service as 500 errors Key: QPID-7682 URL: https://issues.apache.org/jira/browse/QPID-7682 Project:

[jira] [Updated] (QPID-7682) CloudFoundry group provider plugin reports 404 errors from the service as 500 errors

2017-02-24 Thread Keith Wall (JIRA)
[ https://issues.apache.org/jira/browse/QPID-7682?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Keith Wall updated QPID-7682: - Affects Version/s: qpid-java-6.0.6 qpid-java-6.1.1 > CloudFoundry group provider

[jira] [Updated] (QPID-7682) CloudFoundry group provider plugin reports 404 errors from the service as 500 errors

2017-02-24 Thread Keith Wall (JIRA)
[ https://issues.apache.org/jira/browse/QPID-7682?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Keith Wall updated QPID-7682: - Description: If the underlying CloudFoundry service reports 404, the Broker returns a 500 error back to

[jira] [Updated] (QPID-7618) Ring policy type

2017-02-24 Thread Alex Rudyy (JIRA)
[ https://issues.apache.org/jira/browse/QPID-7618?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alex Rudyy updated QPID-7618: - Attachment: (was: overflow-policy.tar.gz) > Ring policy type > > >

[jira] [Updated] (QPID-7681) [Documentation, Java Broker, JMS Client] Add documentation for multiple queue consumer feature into broker and client documentation

2017-02-24 Thread Alex Rudyy (JIRA)
[ https://issues.apache.org/jira/browse/QPID-7681?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alex Rudyy updated QPID-7681: - Summary: [Documentation, Java Broker, JMS Client] Add documentation for multiple queue consumer feature

[jira] [Created] (QPID-7681) [Documentation, Java Broker, JMS Client] ADd documentation for multiple queue consumer feature into both broker and client documentation

2017-02-24 Thread Alex Rudyy (JIRA)
Alex Rudyy created QPID-7681: Summary: [Documentation, Java Broker, JMS Client] ADd documentation for multiple queue consumer feature into both broker and client documentation Key: QPID-7681 URL:

[jira] [Commented] (QPID-7618) Ring policy type

2017-02-24 Thread Lorenz Quack (JIRA)
[ https://issues.apache.org/jira/browse/QPID-7618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15882398#comment-15882398 ] Lorenz Quack commented on QPID-7618: As discussed in private I think the fix for the threading issue