[jira] [Commented] (PROTON-1728) [proton-c] Reorganize the source tree now that Proton J is split off

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/PROTON-1728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16300818#comment-16300818
 ] 

ASF GitHub Bot commented on PROTON-1728:


Github user codecov-io commented on the issue:

https://github.com/apache/qpid-proton/pull/132
  
# [Codecov](https://codecov.io/gh/apache/qpid-proton/pull/132?src=pr=h1) 
Report
> Merging 
[#132](https://codecov.io/gh/apache/qpid-proton/pull/132?src=pr=desc) into 
[master](https://codecov.io/gh/apache/qpid-proton/commit/b462433e375258167caea81e617f437ce512b12f?src=pr=desc)
 will **decrease** coverage by `<.01%`.
> The diff coverage is `n/a`.

[![Impacted file tree 
graph](https://codecov.io/gh/apache/qpid-proton/pull/132/graphs/tree.svg?src=pr=UKKzV9XnFF=650=150)](https://codecov.io/gh/apache/qpid-proton/pull/132?src=pr=tree)

```diff
@@Coverage Diff@@
##   master#132  +/-   ##
=
- Coverage   83.91%   83.9%   -0.01% 
=
  Files 232 232  
  Lines   30765   30765  
=
- Hits25817   25814   -3 
- Misses   49484951   +3
```


| [Impacted 
Files](https://codecov.io/gh/apache/qpid-proton/pull/132?src=pr=tree) | 
Coverage Δ | |
|---|---|---|
| 
[bindings/cpp/include/proton/codec/decoder.hpp](https://codecov.io/gh/apache/qpid-proton/pull/132/diff?src=pr=tree#diff-YmluZGluZ3MvY3BwL2luY2x1ZGUvcHJvdG9uL2NvZGVjL2RlY29kZXIuaHBw)
 | `100% <ø> (ø)` | |
| 
[bindings/cpp/src/decimal.cpp](https://codecov.io/gh/apache/qpid-proton/pull/132/diff?src=pr=tree#diff-YmluZGluZ3MvY3BwL3NyYy9kZWNpbWFsLmNwcA==)
 | `100% <ø> (ø)` | |
| 
[bindings/cpp/include/proton/codec/list.hpp](https://codecov.io/gh/apache/qpid-proton/pull/132/diff?src=pr=tree#diff-YmluZGluZ3MvY3BwL2luY2x1ZGUvcHJvdG9uL2NvZGVjL2xpc3QuaHBw)
 | `100% <ø> (ø)` | |
| 
[bindings/python/proton/reactor.py](https://codecov.io/gh/apache/qpid-proton/pull/132/diff?src=pr=tree#diff-YmluZGluZ3MvcHl0aG9uL3Byb3Rvbi9yZWFjdG9yLnB5)
 | `70.71% <ø> (ø)` | |
| 
[bindings/cpp/include/proton/endpoint.hpp](https://codecov.io/gh/apache/qpid-proton/pull/132/diff?src=pr=tree#diff-YmluZGluZ3MvY3BwL2luY2x1ZGUvcHJvdG9uL2VuZHBvaW50LmhwcA==)
 | `57.14% <ø> (ø)` | |
| 
[bindings/cpp/src/types\_internal.hpp](https://codecov.io/gh/apache/qpid-proton/pull/132/diff?src=pr=tree#diff-YmluZGluZ3MvY3BwL3NyYy90eXBlc19pbnRlcm5hbC5ocHA=)
 | `100% <ø> (ø)` | |
| 
[bindings/python/proton/handlers.py](https://codecov.io/gh/apache/qpid-proton/pull/132/diff?src=pr=tree#diff-YmluZGluZ3MvcHl0aG9uL3Byb3Rvbi9oYW5kbGVycy5weQ==)
 | `58.12% <ø> (ø)` | |
| 
[bindings/cpp/src/sender.cpp](https://codecov.io/gh/apache/qpid-proton/pull/132/diff?src=pr=tree#diff-YmluZGluZ3MvY3BwL3NyYy9zZW5kZXIuY3Bw)
 | `61.11% <ø> (ø)` | |
| 
[bindings/cpp/include/proton/transfer.hpp](https://codecov.io/gh/apache/qpid-proton/pull/132/diff?src=pr=tree#diff-YmluZGluZ3MvY3BwL2luY2x1ZGUvcHJvdG9uL3RyYW5zZmVyLmhwcA==)
 | `100% <ø> (ø)` | |
| 
[bindings/cpp/include/proton/ssl.hpp](https://codecov.io/gh/apache/qpid-proton/pull/132/diff?src=pr=tree#diff-YmluZGluZ3MvY3BwL2luY2x1ZGUvcHJvdG9uL3NzbC5ocHA=)
 | `100% <ø> (ø)` | |
| ... and [252 
more](https://codecov.io/gh/apache/qpid-proton/pull/132/diff?src=pr=tree-more)
 | |

--

[Continue to review full report at 
Codecov](https://codecov.io/gh/apache/qpid-proton/pull/132?src=pr=continue).
> **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
> Powered by 
[Codecov](https://codecov.io/gh/apache/qpid-proton/pull/132?src=pr=footer). 
Last update 
[b462433...e397ef2](https://codecov.io/gh/apache/qpid-proton/pull/132?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).



> [proton-c] Reorganize the source tree now that Proton J is split off
> 
>
> Key: PROTON-1728
> URL: https://issues.apache.org/jira/browse/PROTON-1728
> Project: Qpid Proton
>  Issue Type: Task
>  Components: proton-c
>Reporter: Justin Ross
>Assignee: Justin Ross
> Fix For: proton-c-0.20.0
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-proton issue #132: PROTON-1728: WIP: Reorganize the source tree and rem...

[codecov-io]

Github user codecov-io commented on the issue:

https://github.com/apache/qpid-proton/pull/132
  
# [Codecov](https://codecov.io/gh/apache/qpid-proton/pull/132?src=pr=h1) 
Report
> Merging 
[#132](https://codecov.io/gh/apache/qpid-proton/pull/132?src=pr=desc) into 
[master](https://codecov.io/gh/apache/qpid-proton/commit/b462433e375258167caea81e617f437ce512b12f?src=pr=desc)
 will **decrease** coverage by `<.01%`.
> The diff coverage is `n/a`.

[![Impacted file tree 
graph](https://codecov.io/gh/apache/qpid-proton/pull/132/graphs/tree.svg?src=pr=UKKzV9XnFF=650=150)](https://codecov.io/gh/apache/qpid-proton/pull/132?src=pr=tree)

```diff
@@Coverage Diff@@
##   master#132  +/-   ##
=
- Coverage   83.91%   83.9%   -0.01% 
=
  Files 232 232  
  Lines   30765   30765  
=
- Hits25817   25814   -3 
- Misses   49484951   +3
```


| [Impacted 
Files](https://codecov.io/gh/apache/qpid-proton/pull/132?src=pr=tree) | 
Coverage Δ | |
|---|---|---|
| 
[bindings/cpp/include/proton/codec/decoder.hpp](https://codecov.io/gh/apache/qpid-proton/pull/132/diff?src=pr=tree#diff-YmluZGluZ3MvY3BwL2luY2x1ZGUvcHJvdG9uL2NvZGVjL2RlY29kZXIuaHBw)
 | `100% <ø> (ø)` | |
| 
[bindings/cpp/src/decimal.cpp](https://codecov.io/gh/apache/qpid-proton/pull/132/diff?src=pr=tree#diff-YmluZGluZ3MvY3BwL3NyYy9kZWNpbWFsLmNwcA==)
 | `100% <ø> (ø)` | |
| 
[bindings/cpp/include/proton/codec/list.hpp](https://codecov.io/gh/apache/qpid-proton/pull/132/diff?src=pr=tree#diff-YmluZGluZ3MvY3BwL2luY2x1ZGUvcHJvdG9uL2NvZGVjL2xpc3QuaHBw)
 | `100% <ø> (ø)` | |
| 
[bindings/python/proton/reactor.py](https://codecov.io/gh/apache/qpid-proton/pull/132/diff?src=pr=tree#diff-YmluZGluZ3MvcHl0aG9uL3Byb3Rvbi9yZWFjdG9yLnB5)
 | `70.71% <ø> (ø)` | |
| 
[bindings/cpp/include/proton/endpoint.hpp](https://codecov.io/gh/apache/qpid-proton/pull/132/diff?src=pr=tree#diff-YmluZGluZ3MvY3BwL2luY2x1ZGUvcHJvdG9uL2VuZHBvaW50LmhwcA==)
 | `57.14% <ø> (ø)` | |
| 
[bindings/cpp/src/types\_internal.hpp](https://codecov.io/gh/apache/qpid-proton/pull/132/diff?src=pr=tree#diff-YmluZGluZ3MvY3BwL3NyYy90eXBlc19pbnRlcm5hbC5ocHA=)
 | `100% <ø> (ø)` | |
| 
[bindings/python/proton/handlers.py](https://codecov.io/gh/apache/qpid-proton/pull/132/diff?src=pr=tree#diff-YmluZGluZ3MvcHl0aG9uL3Byb3Rvbi9oYW5kbGVycy5weQ==)
 | `58.12% <ø> (ø)` | |
| 
[bindings/cpp/src/sender.cpp](https://codecov.io/gh/apache/qpid-proton/pull/132/diff?src=pr=tree#diff-YmluZGluZ3MvY3BwL3NyYy9zZW5kZXIuY3Bw)
 | `61.11% <ø> (ø)` | |
| 
[bindings/cpp/include/proton/transfer.hpp](https://codecov.io/gh/apache/qpid-proton/pull/132/diff?src=pr=tree#diff-YmluZGluZ3MvY3BwL2luY2x1ZGUvcHJvdG9uL3RyYW5zZmVyLmhwcA==)
 | `100% <ø> (ø)` | |
| 
[bindings/cpp/include/proton/ssl.hpp](https://codecov.io/gh/apache/qpid-proton/pull/132/diff?src=pr=tree#diff-YmluZGluZ3MvY3BwL2luY2x1ZGUvcHJvdG9uL3NzbC5ocHA=)
 | `100% <ø> (ø)` | |
| ... and [252 
more](https://codecov.io/gh/apache/qpid-proton/pull/132/diff?src=pr=tree-more)
 | |

--

[Continue to review full report at 
Codecov](https://codecov.io/gh/apache/qpid-proton/pull/132?src=pr=continue).
> **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute  (impact)`, `ø = not affected`, `? = missing 
data`
> Powered by 
[Codecov](https://codecov.io/gh/apache/qpid-proton/pull/132?src=pr=footer). 
Last update 
[b462433...e397ef2](https://codecov.io/gh/apache/qpid-proton/pull/132?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).



---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (PROTON-1728) [proton-c] Reorganize the source tree now that Proton J is split off

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/PROTON-1728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16300801#comment-16300801
 ] 

ASF GitHub Bot commented on PROTON-1728:


GitHub user ssorj opened a pull request:

https://github.com/apache/qpid-proton/pull/132

PROTON-1728: WIP: Reorganize the source tree and remove deprecated bindings

WIP! For review only.

Note that this doesn't attempt any significant clean up of the cmake logic. 
 I left that for another day.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ssorj/qpid-proton ssorj-source-reorg

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/qpid-proton/pull/132.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #132


commit 4bfffc7562959ff5a91235f77a9a6f5f773c24cc
Author: Justin Ross 
Date:   2017-12-21T14:32:50Z

Remove old docs; some of this content will be restored to new locations

commit dc9f16503abc9dcd2630ef45e0ac977c12e85058
Author: Justin Ross 
Date:   2017-12-21T17:39:06Z

Rename version.txt to VERSION.txt

commit 0fbf1bba3b3a19050f5cbb0240e23b7ed5c81ca8
Author: Justin Ross 
Date:   2017-12-21T18:00:14Z

Add a .txt extension to LICENSE and NOTICE, for nicer behavior on Windows

commit df52a496454bba1d013fc63f489e53334d359256
Author: Justin Ross 
Date:   2017-12-21T18:13:19Z

Remove unused test code

commit a90f8636d7ae7a9a689b361763e21eda846b3ab2
Author: Justin Ross 
Date:   2017-12-21T18:21:29Z

Fixups for file name conventions

commit b87af3b679d3b3c0290e4bebe482500abc0abf09
Author: Justin Ross 
Date:   2017-12-21T18:29:48Z

Rename tools/py to tools/python to match the other python dirs

commit 79089187d426ff393c97bdd4842a5ad1fae771d2
Author: Justin Ross 
Date:   2017-12-21T18:33:39Z

Make a space for ancillary files

commit 3852892c4f677fb02fe2dc2e09c3e7337dcff3da
Author: Justin Ross 
Date:   2017-12-21T18:46:30Z

Move the docs dir to the top level

commit 64bea13516ebf4baf7e406380e3246f26c7cb7e6
Author: Justin Ross 
Date:   2017-12-21T19:06:23Z

Move mllib to live with other python tools

commit 854be9fdd6ab497009310a7922c377c68e763f06
Author: Justin Ross 
Date:   2017-12-21T20:03:51Z

Move some includes and package configs to the top level

commit f6e153d3639c740d5ba607b3a04de6a7ed42574e
Author: Justin Ross 
Date:   2017-12-21T21:45:08Z

Lift all of proton-c/* to the top level and adjust paths

commit 8901f2e2ebd428f177e8c78a55a333e0768a461a
Author: Justin Ross 
Date:   2017-12-21T22:07:26Z

Remove the unmaintained javascript, node, perl, and php bindings

commit b31d2ec9287bc1e1ed588e6c21b53a1fd801f4d0
Author: Justin Ross 
Date:   2017-12-21T22:29:34Z

Adjust some reacharound paths

commit 1695aba83452606ceeb0e3e7ab9435bdb4cd4dd8
Author: Justin Ross 
Date:   2017-12-21T22:33:49Z

xproton.py is no longer used

commit 32338a0644a1cfe8a02489b4b13ae1ad84f55fce
Author: Justin Ross 
Date:   2017-12-21T22:44:03Z

Move env.py with the other scripts in bin/

commit c9d076e8645ed26e3a44bc3cd389ef419d20258f
Author: Justin Ross 
Date:   2017-12-21T22:59:24Z

Move tox.ini to misc/

commit 39c5818b1425dd54bb9779091c8ab94fd0b93b86
Author: Justin Ross 
Date:   2017-12-21T23:03:10Z

Move versions.cmake to src/lib-versions.cmake

commit 9edf75bab8f4f26b2b94bf8b3c65734de56fa6f4
Author: Justin Ross 
Date:   2017-12-21T23:14:13Z

Move the env config scripts to misc/; adjust the target for tox.ini.in

commit ab6550fa23c9d33bc542ab5ae74e1d869bd77318
Author: Justin Ross 
Date:   2017-12-21T23:17:51Z

Move soak-check with the other scripts

commit 618e22aafef560ff5056f85e2d20171370c7f486
Author: Justin Ross 
Date:   2017-12-21T23:27:23Z

Remove the C++ reactor app

commit 586061d038b9d08d1c328ed109398ee14b0934db
Author: Justin Ross 
Date:   2017-12-21T23:42:29Z

Move the legacy test apps to tools/test-apps/

commit 0ac09ee8d9b46169a5936f770d21bdd21e978026
Author: Justin Ross 
Date:   2017-12-21T23:46:30Z

Correct some paths I missed

commit ced4cef433404f1100cfe1b9b6260a2d83e14b9e
Author: Justin Ross 
Date:   2017-12-21T23:49:37Z

Rename appveyor.yml to .appveyor.yml

commit 5d4156d96327d78d6e65c535b9ebc1093a5902a7
Author: Justin Ross 
Date:   2017-12-22T00:02:44Z

Back to just versions.cmake - no need to be overly narrow

commit 038857d8f49a781731eff9397038cc02738acb72
Author: Justin Ross 
Date:   2017-12-22T00:07:19Z

Fix a broken path

commit e397ef25143cd4aa434bfe1de4adc5a486668f1c
Author: 

[GitHub] qpid-proton pull request #132: PROTON-1728: WIP: Reorganize the source tree ...

[ssorj]

GitHub user ssorj opened a pull request:

https://github.com/apache/qpid-proton/pull/132

PROTON-1728: WIP: Reorganize the source tree and remove deprecated bindings

WIP! For review only.

Note that this doesn't attempt any significant clean up of the cmake logic. 
 I left that for another day.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ssorj/qpid-proton ssorj-source-reorg

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/qpid-proton/pull/132.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #132


commit 4bfffc7562959ff5a91235f77a9a6f5f773c24cc
Author: Justin Ross 
Date:   2017-12-21T14:32:50Z

Remove old docs; some of this content will be restored to new locations

commit dc9f16503abc9dcd2630ef45e0ac977c12e85058
Author: Justin Ross 
Date:   2017-12-21T17:39:06Z

Rename version.txt to VERSION.txt

commit 0fbf1bba3b3a19050f5cbb0240e23b7ed5c81ca8
Author: Justin Ross 
Date:   2017-12-21T18:00:14Z

Add a .txt extension to LICENSE and NOTICE, for nicer behavior on Windows

commit df52a496454bba1d013fc63f489e53334d359256
Author: Justin Ross 
Date:   2017-12-21T18:13:19Z

Remove unused test code

commit a90f8636d7ae7a9a689b361763e21eda846b3ab2
Author: Justin Ross 
Date:   2017-12-21T18:21:29Z

Fixups for file name conventions

commit b87af3b679d3b3c0290e4bebe482500abc0abf09
Author: Justin Ross 
Date:   2017-12-21T18:29:48Z

Rename tools/py to tools/python to match the other python dirs

commit 79089187d426ff393c97bdd4842a5ad1fae771d2
Author: Justin Ross 
Date:   2017-12-21T18:33:39Z

Make a space for ancillary files

commit 3852892c4f677fb02fe2dc2e09c3e7337dcff3da
Author: Justin Ross 
Date:   2017-12-21T18:46:30Z

Move the docs dir to the top level

commit 64bea13516ebf4baf7e406380e3246f26c7cb7e6
Author: Justin Ross 
Date:   2017-12-21T19:06:23Z

Move mllib to live with other python tools

commit 854be9fdd6ab497009310a7922c377c68e763f06
Author: Justin Ross 
Date:   2017-12-21T20:03:51Z

Move some includes and package configs to the top level

commit f6e153d3639c740d5ba607b3a04de6a7ed42574e
Author: Justin Ross 
Date:   2017-12-21T21:45:08Z

Lift all of proton-c/* to the top level and adjust paths

commit 8901f2e2ebd428f177e8c78a55a333e0768a461a
Author: Justin Ross 
Date:   2017-12-21T22:07:26Z

Remove the unmaintained javascript, node, perl, and php bindings

commit b31d2ec9287bc1e1ed588e6c21b53a1fd801f4d0
Author: Justin Ross 
Date:   2017-12-21T22:29:34Z

Adjust some reacharound paths

commit 1695aba83452606ceeb0e3e7ab9435bdb4cd4dd8
Author: Justin Ross 
Date:   2017-12-21T22:33:49Z

xproton.py is no longer used

commit 32338a0644a1cfe8a02489b4b13ae1ad84f55fce
Author: Justin Ross 
Date:   2017-12-21T22:44:03Z

Move env.py with the other scripts in bin/

commit c9d076e8645ed26e3a44bc3cd389ef419d20258f
Author: Justin Ross 
Date:   2017-12-21T22:59:24Z

Move tox.ini to misc/

commit 39c5818b1425dd54bb9779091c8ab94fd0b93b86
Author: Justin Ross 
Date:   2017-12-21T23:03:10Z

Move versions.cmake to src/lib-versions.cmake

commit 9edf75bab8f4f26b2b94bf8b3c65734de56fa6f4
Author: Justin Ross 
Date:   2017-12-21T23:14:13Z

Move the env config scripts to misc/; adjust the target for tox.ini.in

commit ab6550fa23c9d33bc542ab5ae74e1d869bd77318
Author: Justin Ross 
Date:   2017-12-21T23:17:51Z

Move soak-check with the other scripts

commit 618e22aafef560ff5056f85e2d20171370c7f486
Author: Justin Ross 
Date:   2017-12-21T23:27:23Z

Remove the C++ reactor app

commit 586061d038b9d08d1c328ed109398ee14b0934db
Author: Justin Ross 
Date:   2017-12-21T23:42:29Z

Move the legacy test apps to tools/test-apps/

commit 0ac09ee8d9b46169a5936f770d21bdd21e978026
Author: Justin Ross 
Date:   2017-12-21T23:46:30Z

Correct some paths I missed

commit ced4cef433404f1100cfe1b9b6260a2d83e14b9e
Author: Justin Ross 
Date:   2017-12-21T23:49:37Z

Rename appveyor.yml to .appveyor.yml

commit 5d4156d96327d78d6e65c535b9ebc1093a5902a7
Author: Justin Ross 
Date:   2017-12-22T00:02:44Z

Back to just versions.cmake - no need to be overly narrow

commit 038857d8f49a781731eff9397038cc02738acb72
Author: Justin Ross 
Date:   2017-12-22T00:07:19Z

Fix a broken path

commit e397ef25143cd4aa434bfe1de4adc5a486668f1c
Author: Justin Ross 
Date:   2017-12-22T00:26:41Z

Move some of the less frequently used readme files to docs/




---

-
To unsubscribe, e-mail: 

[jira] [Created] (PROTON-1728) [proton-c] Reorganize the source tree now that Proton J is split off

[Justin Ross (JIRA)]

Justin Ross created PROTON-1728:
---

 Summary: [proton-c] Reorganize the source tree now that Proton J 
is split off
 Key: PROTON-1728
 URL: https://issues.apache.org/jira/browse/PROTON-1728
 Project: Qpid Proton
  Issue Type: Task
  Components: proton-c
Reporter: Justin Ross
Assignee: Justin Ross
 Fix For: proton-c-0.20.0






--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (DISPATCH-894) Unable to run system tests on CentOS 6 (Python 2.6)

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/DISPATCH-894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16300510#comment-16300510
 ] 

ASF subversion and git services commented on DISPATCH-894:
--

Commit 4a173e1ec0f7e0e8f9d7d37b9549d4f9c9d37fb0 in qpid-dispatch's branch 
refs/heads/master from [~ganeshmurthy]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-dispatch.git;h=4a173e1 ]

DISPATCH-894 - Made the following changes to make the system tests work on 
CentOS 6.
1. Modified system tests to use unittest2 instead of unittest test framework.
2. Modified tests/CMakeLists.txt to use the unit2 test runner.
3. Fixed some tests to use backwards compatible assert functions.
4. Remove unused imports in tests


> Unable to run system tests on CentOS 6 (Python 2.6)
> ---
>
> Key: DISPATCH-894
> URL: https://issues.apache.org/jira/browse/DISPATCH-894
> Project: Qpid Dispatch
>  Issue Type: Bug
>  Components: Tests
>Affects Versions: 1.0.0
>Reporter: Ganesh Murthy
>Assignee: Ganesh Murthy
> Fix For: 1.1.0
>
>
> On operating systems that have Python 2.6 as the default Python (link CentOS 
> 6), running ctest does not actually run any tests. Here is a snippet of the 
> test output
> {noformat}
> 33/37 Test #33: system_tests_failover_list    Passed0.51 
> sec
>   Start 34: system_tests_denied_unsettled_multicast
> 34: Test command: /usr/bin/python 
> "/home/gmurthy/opensource/qpid-dispatch/build/tests/run.py" "-m" "unittest" 
> "-v" "system_tests_denied_unsettled_multicast"
> 34: Test timeout computed to be: 1500
> 34: --
> 34: Ran 0 test in 0.200s
> 34: 
> 34: OK
> 34/37 Test #34: system_tests_denied_unsettled_multicast ...   Passed0.54 
> sec
> test 35
>   Start 35: system_tests_auth_service_plugin
> 35: Test command: /usr/bin/python 
> "/home/gmurthy/opensource/qpid-dispatch/build/tests/run.py" "-m" "unittest" 
> "-v" "system_tests_auth_service_plugin"
> 35: Test timeout computed to be: 1500
> 35: 
> 35: --
> 35: Ran 0 tests in 0.322s
> {noformat}
> The problem seems to be that ctest is launching unittest which is older is Py 
> 2.6 and is not feature rich as in Python 2.7
> To solve this problem, Python provides a backwards compatible unit test 
> package called unittest2. This unittest2 backports the new features provided 
> by unittest test framework to older versions of Python.
> unittest2 is available for Python versions 2.3 thru 3.4. It offers a test 
> launcher called unit2 which should be used by ctest.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Resolved] (DISPATCH-894) Unable to run system tests on CentOS 6 (Python 2.6)

[Ted Ross (JIRA)]

 [ 
https://issues.apache.org/jira/browse/DISPATCH-894?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ted Ross resolved DISPATCH-894.
---
Resolution: Fixed

> Unable to run system tests on CentOS 6 (Python 2.6)
> ---
>
> Key: DISPATCH-894
> URL: https://issues.apache.org/jira/browse/DISPATCH-894
> Project: Qpid Dispatch
>  Issue Type: Bug
>  Components: Tests
>Affects Versions: 1.0.0
>Reporter: Ganesh Murthy
>Assignee: Ganesh Murthy
> Fix For: 1.1.0
>
>
> On operating systems that have Python 2.6 as the default Python (link CentOS 
> 6), running ctest does not actually run any tests. Here is a snippet of the 
> test output
> {noformat}
> 33/37 Test #33: system_tests_failover_list    Passed0.51 
> sec
>   Start 34: system_tests_denied_unsettled_multicast
> 34: Test command: /usr/bin/python 
> "/home/gmurthy/opensource/qpid-dispatch/build/tests/run.py" "-m" "unittest" 
> "-v" "system_tests_denied_unsettled_multicast"
> 34: Test timeout computed to be: 1500
> 34: --
> 34: Ran 0 test in 0.200s
> 34: 
> 34: OK
> 34/37 Test #34: system_tests_denied_unsettled_multicast ...   Passed0.54 
> sec
> test 35
>   Start 35: system_tests_auth_service_plugin
> 35: Test command: /usr/bin/python 
> "/home/gmurthy/opensource/qpid-dispatch/build/tests/run.py" "-m" "unittest" 
> "-v" "system_tests_auth_service_plugin"
> 35: Test timeout computed to be: 1500
> 35: 
> 35: --
> 35: Ran 0 tests in 0.322s
> {noformat}
> The problem seems to be that ctest is launching unittest which is older is Py 
> 2.6 and is not feature rich as in Python 2.7
> To solve this problem, Python provides a backwards compatible unit test 
> package called unittest2. This unittest2 backports the new features provided 
> by unittest test framework to older versions of Python.
> unittest2 is available for Python versions 2.3 thru 3.4. It offers a test 
> launcher called unit2 which should be used by ctest.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (DISPATCH-894) Unable to run system tests on CentOS 6 (Python 2.6)

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/DISPATCH-894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16300511#comment-16300511
 ] 

ASF GitHub Bot commented on DISPATCH-894:
-

Github user asfgit closed the pull request at:

https://github.com/apache/qpid-dispatch/pull/239


> Unable to run system tests on CentOS 6 (Python 2.6)
> ---
>
> Key: DISPATCH-894
> URL: https://issues.apache.org/jira/browse/DISPATCH-894
> Project: Qpid Dispatch
>  Issue Type: Bug
>  Components: Tests
>Affects Versions: 1.0.0
>Reporter: Ganesh Murthy
>Assignee: Ganesh Murthy
> Fix For: 1.1.0
>
>
> On operating systems that have Python 2.6 as the default Python (link CentOS 
> 6), running ctest does not actually run any tests. Here is a snippet of the 
> test output
> {noformat}
> 33/37 Test #33: system_tests_failover_list    Passed0.51 
> sec
>   Start 34: system_tests_denied_unsettled_multicast
> 34: Test command: /usr/bin/python 
> "/home/gmurthy/opensource/qpid-dispatch/build/tests/run.py" "-m" "unittest" 
> "-v" "system_tests_denied_unsettled_multicast"
> 34: Test timeout computed to be: 1500
> 34: --
> 34: Ran 0 test in 0.200s
> 34: 
> 34: OK
> 34/37 Test #34: system_tests_denied_unsettled_multicast ...   Passed0.54 
> sec
> test 35
>   Start 35: system_tests_auth_service_plugin
> 35: Test command: /usr/bin/python 
> "/home/gmurthy/opensource/qpid-dispatch/build/tests/run.py" "-m" "unittest" 
> "-v" "system_tests_auth_service_plugin"
> 35: Test timeout computed to be: 1500
> 35: 
> 35: --
> 35: Ran 0 tests in 0.322s
> {noformat}
> The problem seems to be that ctest is launching unittest which is older is Py 
> 2.6 and is not feature rich as in Python 2.7
> To solve this problem, Python provides a backwards compatible unit test 
> package called unittest2. This unittest2 backports the new features provided 
> by unittest test framework to older versions of Python.
> unittest2 is available for Python versions 2.3 thru 3.4. It offers a test 
> launcher called unit2 which should be used by ctest.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-dispatch pull request #239: DISPATCH-894 - Made the following changes t...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/qpid-dispatch/pull/239


---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Issue Comment Deleted] (PROTON-1718) (Proton-J) Custom Sasl

[Tim Taylor (JIRA)]

 [ 
https://issues.apache.org/jira/browse/PROTON-1718?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tim Taylor updated PROTON-1718:
---
Comment: was deleted

(was: Let's simplify this a bit to get the ball rolling (When you get back from 
break)

Suppose I'm taking the library as it is right now. If I needed to include a 
payload in the sasl init frame, is that possible?)

> (Proton-J) Custom Sasl
> --
>
> Key: PROTON-1718
> URL: https://issues.apache.org/jira/browse/PROTON-1718
> Project: Qpid Proton
>  Issue Type: Improvement
>  Components: proton-j
>Affects Versions: proton-j-0.24.0
>Reporter: Tim Taylor
>  Labels: features
>
> I would like to be able to provide a custom SASL implementation for Proton-j 
> to use instead of being forced to use the default SaslImpl.java 
> implementation.
> Ideally, code like below would be possible
> private class CustomSasl implements org.apache.qpid.proton.engine.Sasl
> {
> ...
> }
> ...
> ...
> //transport.sasl(...) saves the provided sasl implementation and uses it 
> internally
> Sasl sasl = transport.sasl(new CustomSasl());
> Do you currently have a workaround that would allow me to use Proton-J this 
> way?



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Issue Comment Deleted] (PROTON-1718) (Proton-J) Custom Sasl

[Tim Taylor (JIRA)]

 [ 
https://issues.apache.org/jira/browse/PROTON-1718?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tim Taylor updated PROTON-1718:
---
Comment: was deleted

(was: Yes, my issue is more to do with how the Reactor does not allow users 
enough control over the Sasl operations in the ways that I outlined above.

Ignore the point of sending multiple init frames, I was mistaken. I do not need 
to be able to do that.

I'll try exploring the possibility of a fix that is more tied to the reactor.)

> (Proton-J) Custom Sasl
> --
>
> Key: PROTON-1718
> URL: https://issues.apache.org/jira/browse/PROTON-1718
> Project: Qpid Proton
>  Issue Type: Improvement
>  Components: proton-j
>Affects Versions: proton-j-0.24.0
>Reporter: Tim Taylor
>  Labels: features
>
> I would like to be able to provide a custom SASL implementation for Proton-j 
> to use instead of being forced to use the default SaslImpl.java 
> implementation.
> Ideally, code like below would be possible
> private class CustomSasl implements org.apache.qpid.proton.engine.Sasl
> {
> ...
> }
> ...
> ...
> //transport.sasl(...) saves the provided sasl implementation and uses it 
> internally
> Sasl sasl = transport.sasl(new CustomSasl());
> Do you currently have a workaround that would allow me to use Proton-J this 
> way?



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (DISPATCH-894) Unable to run system tests on CentOS 6 (Python 2.6)

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/DISPATCH-894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16300462#comment-16300462
 ] 

ASF GitHub Bot commented on DISPATCH-894:
-

GitHub user ganeshmurthy opened a pull request:

https://github.com/apache/qpid-dispatch/pull/239

DISPATCH-894 - Made the following changes to make the system tests wo…

…rk on CentOS 6.

1. Modified system tests to use unittest2 instead of unittest test 
framework.
2. Modified tests/CMakeLists.txt to use the unit2 test runner.
3. Fixed some tests to use backwards compatible assert functions.
4. Remove unused imports in tests

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ganeshmurthy/qpid-dispatch DISPATCH-894-4

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/qpid-dispatch/pull/239.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #239


commit 4a173e1ec0f7e0e8f9d7d37b9549d4f9c9d37fb0
Author: Ganesh Murthy 
Date:   2017-12-06T15:08:24Z

DISPATCH-894 - Made the following changes to make the system tests work on 
CentOS 6.
1. Modified system tests to use unittest2 instead of unittest test 
framework.
2. Modified tests/CMakeLists.txt to use the unit2 test runner.
3. Fixed some tests to use backwards compatible assert functions.
4. Remove unused imports in tests




> Unable to run system tests on CentOS 6 (Python 2.6)
> ---
>
> Key: DISPATCH-894
> URL: https://issues.apache.org/jira/browse/DISPATCH-894
> Project: Qpid Dispatch
>  Issue Type: Bug
>  Components: Tests
>Affects Versions: 1.0.0
>Reporter: Ganesh Murthy
>Assignee: Ganesh Murthy
> Fix For: 1.1.0
>
>
> On operating systems that have Python 2.6 as the default Python (link CentOS 
> 6), running ctest does not actually run any tests. Here is a snippet of the 
> test output
> {noformat}
> 33/37 Test #33: system_tests_failover_list    Passed0.51 
> sec
>   Start 34: system_tests_denied_unsettled_multicast
> 34: Test command: /usr/bin/python 
> "/home/gmurthy/opensource/qpid-dispatch/build/tests/run.py" "-m" "unittest" 
> "-v" "system_tests_denied_unsettled_multicast"
> 34: Test timeout computed to be: 1500
> 34: --
> 34: Ran 0 test in 0.200s
> 34: 
> 34: OK
> 34/37 Test #34: system_tests_denied_unsettled_multicast ...   Passed0.54 
> sec
> test 35
>   Start 35: system_tests_auth_service_plugin
> 35: Test command: /usr/bin/python 
> "/home/gmurthy/opensource/qpid-dispatch/build/tests/run.py" "-m" "unittest" 
> "-v" "system_tests_auth_service_plugin"
> 35: Test timeout computed to be: 1500
> 35: 
> 35: --
> 35: Ran 0 tests in 0.322s
> {noformat}
> The problem seems to be that ctest is launching unittest which is older is Py 
> 2.6 and is not feature rich as in Python 2.7
> To solve this problem, Python provides a backwards compatible unit test 
> package called unittest2. This unittest2 backports the new features provided 
> by unittest test framework to older versions of Python.
> unittest2 is available for Python versions 2.3 thru 3.4. It offers a test 
> launcher called unit2 which should be used by ctest.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-dispatch pull request #239: DISPATCH-894 - Made the following changes t...

[ganeshmurthy]

GitHub user ganeshmurthy opened a pull request:

https://github.com/apache/qpid-dispatch/pull/239

DISPATCH-894 - Made the following changes to make the system tests wo…

…rk on CentOS 6.

1. Modified system tests to use unittest2 instead of unittest test 
framework.
2. Modified tests/CMakeLists.txt to use the unit2 test runner.
3. Fixed some tests to use backwards compatible assert functions.
4. Remove unused imports in tests

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ganeshmurthy/qpid-dispatch DISPATCH-894-4

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/qpid-dispatch/pull/239.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #239


commit 4a173e1ec0f7e0e8f9d7d37b9549d4f9c9d37fb0
Author: Ganesh Murthy 
Date:   2017-12-06T15:08:24Z

DISPATCH-894 - Made the following changes to make the system tests work on 
CentOS 6.
1. Modified system tests to use unittest2 instead of unittest test 
framework.
2. Modified tests/CMakeLists.txt to use the unit2 test runner.
3. Fixed some tests to use backwards compatible assert functions.
4. Remove unused imports in tests




---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-dispatch pull request #238: DISPATCH 894 - Made the following changes t...

[ganeshmurthy]

Github user ganeshmurthy closed the pull request at:

https://github.com/apache/qpid-dispatch/pull/238


---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-dispatch pull request #238: DISPATCH 894 - Made the following changes t...

[ganeshmurthy]

GitHub user ganeshmurthy opened a pull request:

https://github.com/apache/qpid-dispatch/pull/238

DISPATCH 894 - Made the following changes to make the system tests wo…

…rk on CentOS 6.

1. Modified system tests to use unittest2 instead of unittest test 
framework.
2. Modified tests/CMakeLists.txt to use the unit2 test runner.
3. Fixed some tests to use backwards compatible assert functions.
4. Remove unused imports in tests

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ganeshmurthy/qpid-dispatch DISPATCH-894-3

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/qpid-dispatch/pull/238.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #238


commit 051529534faec51c1a6b70e5a1a818ed7ec3a86c
Author: Ganesh Murthy 
Date:   2017-12-06T15:08:24Z

DISPATCH 894 - Made the following changes to make the system tests work on 
CentOS 6.
1. Modified system tests to use unittest2 instead of unittest test 
framework.
2. Modified tests/CMakeLists.txt to use the unit2 test runner.
3. Fixed some tests to use backwards compatible assert functions.
4. Remove unused imports in tests




---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-dispatch pull request #232: DISPATCH 894 - Made the following changes t...

[ganeshmurthy]

Github user ganeshmurthy closed the pull request at:

https://github.com/apache/qpid-dispatch/pull/232


---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-dispatch issue #232: DISPATCH 894 - Made the following changes to make ...

[ted-ross]

Github user ted-ross commented on the issue:

https://github.com/apache/qpid-dispatch/pull/232
  
I see the same failures that are reported by Travis.  None of the 
python-based tests pass.



---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Resolved] (DISPATCH-872) Add a counter for dropped-presettleds on links

[Ted Ross (JIRA)]

 [ 
https://issues.apache.org/jira/browse/DISPATCH-872?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ted Ross resolved DISPATCH-872.
---
Resolution: Fixed

> Add a counter for dropped-presettleds on links
> --
>
> Key: DISPATCH-872
> URL: https://issues.apache.org/jira/browse/DISPATCH-872
> Project: Qpid Dispatch
>  Issue Type: Improvement
>  Components: Router Node
>Reporter: Ted Ross
>Assignee: Ganesh Murthy
> Fix For: 1.1.0
>
>
> When the router drops pre-settled deliveries during congestion, those drops 
> are not counted or reported.  A new counter should be added for links to 
> account for dropped presettled deliveries.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (DISPATCH-872) Add a counter for dropped-presettleds on links

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/DISPATCH-872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16300382#comment-16300382
 ] 

ASF subversion and git services commented on DISPATCH-872:
--

Commit ac9c414f25d6238ed91b134291f00ef82bb5236c in qpid-dispatch's branch 
refs/heads/master from [~tr...@redhat.com]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-dispatch.git;h=ac9c414 ]

DISPATCH-872 - Shortened the header for dropped unsettleds and added help text 
to the qdstat man page.


> Add a counter for dropped-presettleds on links
> --
>
> Key: DISPATCH-872
> URL: https://issues.apache.org/jira/browse/DISPATCH-872
> Project: Qpid Dispatch
>  Issue Type: Improvement
>  Components: Router Node
>Reporter: Ted Ross
>Assignee: Ganesh Murthy
> Fix For: 1.1.0
>
>
> When the router drops pre-settled deliveries during congestion, those drops 
> are not counted or reported.  A new counter should be added for links to 
> account for dropped presettled deliveries.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (DISPATCH-872) Add a counter for dropped-presettleds on links

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/DISPATCH-872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16300383#comment-16300383
 ] 

ASF GitHub Bot commented on DISPATCH-872:
-

Github user asfgit closed the pull request at:

https://github.com/apache/qpid-dispatch/pull/226


> Add a counter for dropped-presettleds on links
> --
>
> Key: DISPATCH-872
> URL: https://issues.apache.org/jira/browse/DISPATCH-872
> Project: Qpid Dispatch
>  Issue Type: Improvement
>  Components: Router Node
>Reporter: Ted Ross
>Assignee: Ganesh Murthy
> Fix For: 1.1.0
>
>
> When the router drops pre-settled deliveries during congestion, those drops 
> are not counted or reported.  A new counter should be added for links to 
> account for dropped presettled deliveries.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (DISPATCH-872) Add a counter for dropped-presettleds on links

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/DISPATCH-872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16300381#comment-16300381
 ] 

ASF subversion and git services commented on DISPATCH-872:
--

Commit b5dcaffac9d7af9a6afa0c6f23cf91b45b4d8209 in qpid-dispatch's branch 
refs/heads/master from [~tr...@redhat.com]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-dispatch.git;h=b5dcaff ]

DISPATCH-872 - PR from gmurthy - Added link counter for dropped-presettled 
deliveries.
This closes #226


> Add a counter for dropped-presettleds on links
> --
>
> Key: DISPATCH-872
> URL: https://issues.apache.org/jira/browse/DISPATCH-872
> Project: Qpid Dispatch
>  Issue Type: Improvement
>  Components: Router Node
>Reporter: Ted Ross
>Assignee: Ganesh Murthy
> Fix For: 1.1.0
>
>
> When the router drops pre-settled deliveries during congestion, those drops 
> are not counted or reported.  A new counter should be added for links to 
> account for dropped presettled deliveries.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-dispatch pull request #226: DISPATCH-872 - Added a counter for dropped-...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/qpid-dispatch/pull/226


---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (QPID-6933) Factor out a JMS client neutral messaging test suite from system tests

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/QPID-6933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16300327#comment-16300327
 ] 

ASF subversion and git services commented on QPID-6933:
---

Commit b618667270dcdf2880ff02b0a21aaa6ecab37064 in qpid-broker-j's branch 
refs/heads/master from [~k-wall]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-broker-j.git;h=b618667 ]

QPID-6933: [System Tests] Move MessageGroupTest to new suite


> Factor out a JMS client neutral messaging test suite from system tests
> --
>
> Key: QPID-6933
> URL: https://issues.apache.org/jira/browse/QPID-6933
> Project: Qpid
>  Issue Type: Improvement
>  Components: Java Tests
>Reporter: Keith Wall
>Assignee: Alex Rudyy
>
> The existing system testsuite is in a poor state.
> * It is poorly structured
> * Mixes different types of test.  i.e. messaging behaviour with those that 
> test features of the Java Broker (e.g. REST).
> * Many of the tests refer directly to the implementation classes of the Qpid 
> Client 0-8..0-10 client meaning the tests cannot be run using the new client.
> As a first step, we want to factor out a separate messaging system test suite:
> * The tests in this suite will be JMS client neutral.
> * Written in terms of JNDI/JMS client
> * Configurations/Broker observations will be performed via a clean 
> Broker-neutral facade. For instance
> **  a mechanism to cause the queue to be created of a particular type.
> ** a mechanism to observe a queue depth.
> * The tests will be classified by feature (to be defined)
> * The classification system will be used to drive an exclusion feature (to be 
> defined).



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (QPID-6933) Factor out a JMS client neutral messaging test suite from system tests

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/QPID-6933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16300323#comment-16300323
 ] 

ASF subversion and git services commented on QPID-6933:
---

Commit a28be4b508c330165a13c46295886260c5f2d471 in qpid-broker-j's branch 
refs/heads/master from [~k-wall]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-broker-j.git;h=a28be4b ]

QPID-6933: [System Tests] Move JMS specific parts of PropertyValueTest to new 
suite.  Protocol specific parts already moved to protocol suites


> Factor out a JMS client neutral messaging test suite from system tests
> --
>
> Key: QPID-6933
> URL: https://issues.apache.org/jira/browse/QPID-6933
> Project: Qpid
>  Issue Type: Improvement
>  Components: Java Tests
>Reporter: Keith Wall
>Assignee: Alex Rudyy
>
> The existing system testsuite is in a poor state.
> * It is poorly structured
> * Mixes different types of test.  i.e. messaging behaviour with those that 
> test features of the Java Broker (e.g. REST).
> * Many of the tests refer directly to the implementation classes of the Qpid 
> Client 0-8..0-10 client meaning the tests cannot be run using the new client.
> As a first step, we want to factor out a separate messaging system test suite:
> * The tests in this suite will be JMS client neutral.
> * Written in terms of JNDI/JMS client
> * Configurations/Broker observations will be performed via a clean 
> Broker-neutral facade. For instance
> **  a mechanism to cause the queue to be created of a particular type.
> ** a mechanism to observe a queue depth.
> * The tests will be classified by feature (to be defined)
> * The classification system will be used to drive an exclusion feature (to be 
> defined).



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (QPID-6933) Factor out a JMS client neutral messaging test suite from system tests

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/QPID-6933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16300325#comment-16300325
 ] 

ASF subversion and git services commented on QPID-6933:
---

Commit 5f8aa0c8adfd0e8e40fe79087b9cdc44eea5e424 in qpid-broker-j's branch 
refs/heads/master from [~k-wall]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-broker-j.git;h=5f8aa0c ]

QPID-6933: [System Tests] Refactor SelectorTest as a JMS 1.1 system tests


> Factor out a JMS client neutral messaging test suite from system tests
> --
>
> Key: QPID-6933
> URL: https://issues.apache.org/jira/browse/QPID-6933
> Project: Qpid
>  Issue Type: Improvement
>  Components: Java Tests
>Reporter: Keith Wall
>Assignee: Alex Rudyy
>
> The existing system testsuite is in a poor state.
> * It is poorly structured
> * Mixes different types of test.  i.e. messaging behaviour with those that 
> test features of the Java Broker (e.g. REST).
> * Many of the tests refer directly to the implementation classes of the Qpid 
> Client 0-8..0-10 client meaning the tests cannot be run using the new client.
> As a first step, we want to factor out a separate messaging system test suite:
> * The tests in this suite will be JMS client neutral.
> * Written in terms of JNDI/JMS client
> * Configurations/Broker observations will be performed via a clean 
> Broker-neutral facade. For instance
> **  a mechanism to cause the queue to be created of a particular type.
> ** a mechanism to observe a queue depth.
> * The tests will be classified by feature (to be defined)
> * The classification system will be used to drive an exclusion feature (to be 
> defined).



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (QPID-6933) Factor out a JMS client neutral messaging test suite from system tests

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/QPID-6933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16300322#comment-16300322
 ] 

ASF subversion and git services commented on QPID-6933:
---

Commit 9b0a837a9f5e38c5ea00639ece6e2e511f92882b in qpid-broker-j's branch 
refs/heads/master from [~k-wall]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-broker-j.git;h=9b0a837 ]

QPID-6933: [System Tests] Move simplified LargeMessageTest to new suite


> Factor out a JMS client neutral messaging test suite from system tests
> --
>
> Key: QPID-6933
> URL: https://issues.apache.org/jira/browse/QPID-6933
> Project: Qpid
>  Issue Type: Improvement
>  Components: Java Tests
>Reporter: Keith Wall
>Assignee: Alex Rudyy
>
> The existing system testsuite is in a poor state.
> * It is poorly structured
> * Mixes different types of test.  i.e. messaging behaviour with those that 
> test features of the Java Broker (e.g. REST).
> * Many of the tests refer directly to the implementation classes of the Qpid 
> Client 0-8..0-10 client meaning the tests cannot be run using the new client.
> As a first step, we want to factor out a separate messaging system test suite:
> * The tests in this suite will be JMS client neutral.
> * Written in terms of JNDI/JMS client
> * Configurations/Broker observations will be performed via a clean 
> Broker-neutral facade. For instance
> **  a mechanism to cause the queue to be created of a particular type.
> ** a mechanism to observe a queue depth.
> * The tests will be classified by feature (to be defined)
> * The classification system will be used to drive an exclusion feature (to be 
> defined).



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (QPID-6933) Factor out a JMS client neutral messaging test suite from system tests

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/QPID-6933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16300326#comment-16300326
 ] 

ASF subversion and git services commented on QPID-6933:
---

Commit bd640ffec47e96fef5fcf0eed92edbb44fcaf9b9 in qpid-broker-j's branch 
refs/heads/master from [~k-wall]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-broker-j.git;h=bd640ff ]

QPID-6933: [System Tests] Move DefaultFiltersTest to extension suite


> Factor out a JMS client neutral messaging test suite from system tests
> --
>
> Key: QPID-6933
> URL: https://issues.apache.org/jira/browse/QPID-6933
> Project: Qpid
>  Issue Type: Improvement
>  Components: Java Tests
>Reporter: Keith Wall
>Assignee: Alex Rudyy
>
> The existing system testsuite is in a poor state.
> * It is poorly structured
> * Mixes different types of test.  i.e. messaging behaviour with those that 
> test features of the Java Broker (e.g. REST).
> * Many of the tests refer directly to the implementation classes of the Qpid 
> Client 0-8..0-10 client meaning the tests cannot be run using the new client.
> As a first step, we want to factor out a separate messaging system test suite:
> * The tests in this suite will be JMS client neutral.
> * Written in terms of JNDI/JMS client
> * Configurations/Broker observations will be performed via a clean 
> Broker-neutral facade. For instance
> **  a mechanism to cause the queue to be created of a particular type.
> ** a mechanism to observe a queue depth.
> * The tests will be classified by feature (to be defined)
> * The classification system will be used to drive an exclusion feature (to be 
> defined).



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (QPID-6933) Factor out a JMS client neutral messaging test suite from system tests

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/QPID-6933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16300321#comment-16300321
 ] 

ASF subversion and git services commented on QPID-6933:
---

Commit e30acdd6d74cfe7ab7bf98c60a09c3cedf2f4182 in qpid-broker-j's branch 
refs/heads/master from [~k-wall]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-broker-j.git;h=e30acdd ]

QPID-6933: [System Tests] Remove more redundant/poorly focused tests


> Factor out a JMS client neutral messaging test suite from system tests
> --
>
> Key: QPID-6933
> URL: https://issues.apache.org/jira/browse/QPID-6933
> Project: Qpid
>  Issue Type: Improvement
>  Components: Java Tests
>Reporter: Keith Wall
>Assignee: Alex Rudyy
>
> The existing system testsuite is in a poor state.
> * It is poorly structured
> * Mixes different types of test.  i.e. messaging behaviour with those that 
> test features of the Java Broker (e.g. REST).
> * Many of the tests refer directly to the implementation classes of the Qpid 
> Client 0-8..0-10 client meaning the tests cannot be run using the new client.
> As a first step, we want to factor out a separate messaging system test suite:
> * The tests in this suite will be JMS client neutral.
> * Written in terms of JNDI/JMS client
> * Configurations/Broker observations will be performed via a clean 
> Broker-neutral facade. For instance
> **  a mechanism to cause the queue to be created of a particular type.
> ** a mechanism to observe a queue depth.
> * The tests will be classified by feature (to be defined)
> * The classification system will be used to drive an exclusion feature (to be 
> defined).



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (QPID-6933) Factor out a JMS client neutral messaging test suite from system tests

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/QPID-6933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16300324#comment-16300324
 ] 

ASF subversion and git services commented on QPID-6933:
---

Commit 3270419ea3b79bf0d3724a4038b9aa888109f495 in qpid-broker-j's branch 
refs/heads/master from [~k-wall]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-broker-j.git;h=3270419 ]

QPID-6933: [System Tests] Reorganise Qpid specific extensions


> Factor out a JMS client neutral messaging test suite from system tests
> --
>
> Key: QPID-6933
> URL: https://issues.apache.org/jira/browse/QPID-6933
> Project: Qpid
>  Issue Type: Improvement
>  Components: Java Tests
>Reporter: Keith Wall
>Assignee: Alex Rudyy
>
> The existing system testsuite is in a poor state.
> * It is poorly structured
> * Mixes different types of test.  i.e. messaging behaviour with those that 
> test features of the Java Broker (e.g. REST).
> * Many of the tests refer directly to the implementation classes of the Qpid 
> Client 0-8..0-10 client meaning the tests cannot be run using the new client.
> As a first step, we want to factor out a separate messaging system test suite:
> * The tests in this suite will be JMS client neutral.
> * Written in terms of JNDI/JMS client
> * Configurations/Broker observations will be performed via a clean 
> Broker-neutral facade. For instance
> **  a mechanism to cause the queue to be created of a particular type.
> ** a mechanism to observe a queue depth.
> * The tests will be classified by feature (to be defined)
> * The classification system will be used to drive an exclusion feature (to be 
> defined).



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Comment Edited] (PROTON-1669) 0.19.0 release tasks

[Justin Ross (JIRA)]

[ 
https://issues.apache.org/jira/browse/PROTON-1669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16300267#comment-16300267
 ] 

Justin Ross edited comment on PROTON-1669 at 12/21/17 5:24 PM:
---

To do: add a special release note telling everyone that the new Ruby API is a 
preview and its API is still subject to change.

Proposed text:

This release contains the initial release of a new Ruby messaging API.  The 
interfaces in this API are subject to change.  We plan to take user feedback 
and make any resulting API changes in upcoming releases.


was (Author: justi9):
To do: add a special release note telling everyone that the new Ruby API is a 
preview and its API is still subject to change.

Proposed text:

This release contains the initial release of a new Ruby messaging API.  The 
interfaces in this API are subject to change.  We plan to take user feedback 
and make the resulting API changes in upcoming releases.

> 0.19.0 release tasks
> 
>
> Key: PROTON-1669
> URL: https://issues.apache.org/jira/browse/PROTON-1669
> Project: Qpid Proton
>  Issue Type: Task
>  Components: proton-c, release
>Reporter: Robbie Gemmell
>Assignee: Robbie Gemmell
> Fix For: proton-c-0.19.0
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (DISPATCH-872) Add a counter for dropped-presettleds on links

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/DISPATCH-872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16300312#comment-16300312
 ] 

ASF GitHub Bot commented on DISPATCH-872:
-

Github user ganeshmurthy commented on a diff in the pull request:

https://github.com/apache/qpid-dispatch/pull/226#discussion_r158332552
  
--- Diff: tests/system_tests_one_router.py ---
@@ -1552,6 +1552,14 @@ def check_if_done(self):
 self.conn.close()
 elif self.n_sent == self.n_released:
 self.error = None
+
+if not self.error:
--- End diff --

Yes, the if statement is unnecessary. It should be removed.

It is true that the test does not send pre-settled deliveries. 

The router has allowUnsettledMulticast: yes
in this specific case we send an unsettled multicast to the router. But 
there is no receiver, so the router sends back the following to the client - 

[0x7ffb1c014c50]:0 -> @disposition(21) [role=true, first=0, last=0, 
settled=true, state=@released(38) []]

Hence this delivery can be considered a dropped pre-settled?


https://github.com/apache/qpid-dispatch/blob/master/src/router_core/transfer.c#L783


> Add a counter for dropped-presettleds on links
> --
>
> Key: DISPATCH-872
> URL: https://issues.apache.org/jira/browse/DISPATCH-872
> Project: Qpid Dispatch
>  Issue Type: Improvement
>  Components: Router Node
>Reporter: Ted Ross
>Assignee: Ganesh Murthy
> Fix For: 1.1.0
>
>
> When the router drops pre-settled deliveries during congestion, those drops 
> are not counted or reported.  A new counter should be added for links to 
> account for dropped presettled deliveries.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-dispatch pull request #226: DISPATCH-872 - Added a counter for dropped-...

[ganeshmurthy]

Github user ganeshmurthy commented on a diff in the pull request:

https://github.com/apache/qpid-dispatch/pull/226#discussion_r158332552
  
--- Diff: tests/system_tests_one_router.py ---
@@ -1552,6 +1552,14 @@ def check_if_done(self):
 self.conn.close()
 elif self.n_sent == self.n_released:
 self.error = None
+
+if not self.error:
--- End diff --

Yes, the if statement is unnecessary. It should be removed.

It is true that the test does not send pre-settled deliveries. 

The router has allowUnsettledMulticast: yes
in this specific case we send an unsettled multicast to the router. But 
there is no receiver, so the router sends back the following to the client - 

[0x7ffb1c014c50]:0 -> @disposition(21) [role=true, first=0, last=0, 
settled=true, state=@released(38) []]

Hence this delivery can be considered a dropped pre-settled?


https://github.com/apache/qpid-dispatch/blob/master/src/router_core/transfer.c#L783


---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (PROTON-1669) 0.19.0 release tasks

[Justin Ross (JIRA)]

[ 
https://issues.apache.org/jira/browse/PROTON-1669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16300267#comment-16300267
 ] 

Justin Ross commented on PROTON-1669:
-

To do: add a special release note telling everyone that the new Ruby API is a 
preview and its API is still subject to change.

Proposed text:

This release contains the initial release of a new Ruby messaging API.  The 
interfaces in this API are subject to change.  We plan to take user feedback 
and make the resulting API changes in upcoming releases.

> 0.19.0 release tasks
> 
>
> Key: PROTON-1669
> URL: https://issues.apache.org/jira/browse/PROTON-1669
> Project: Qpid Proton
>  Issue Type: Task
>  Components: proton-c, release
>Reporter: Robbie Gemmell
>Assignee: Robbie Gemmell
> Fix For: proton-c-0.19.0
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (DISPATCH-872) Add a counter for dropped-presettleds on links

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/DISPATCH-872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16300220#comment-16300220
 ] 

ASF GitHub Bot commented on DISPATCH-872:
-

Github user ted-ross commented on a diff in the pull request:

https://github.com/apache/qpid-dispatch/pull/226#discussion_r158315973
  
--- Diff: tests/system_tests_one_router.py ---
@@ -1552,6 +1552,14 @@ def check_if_done(self):
 self.conn.close()
 elif self.n_sent == self.n_released:
 self.error = None
+
+if not self.error:
--- End diff --

This 'if' is unnecessary.  Also, this test doesn't send pre-settled 
deliveries.  Why does it expect a count of dropped pre-settleds?


> Add a counter for dropped-presettleds on links
> --
>
> Key: DISPATCH-872
> URL: https://issues.apache.org/jira/browse/DISPATCH-872
> Project: Qpid Dispatch
>  Issue Type: Improvement
>  Components: Router Node
>Reporter: Ted Ross
>Assignee: Ganesh Murthy
> Fix For: 1.1.0
>
>
> When the router drops pre-settled deliveries during congestion, those drops 
> are not counted or reported.  A new counter should be added for links to 
> account for dropped presettled deliveries.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-dispatch pull request #226: DISPATCH-872 - Added a counter for dropped-...

[ted-ross]

Github user ted-ross commented on a diff in the pull request:

https://github.com/apache/qpid-dispatch/pull/226#discussion_r158315973
  
--- Diff: tests/system_tests_one_router.py ---
@@ -1552,6 +1552,14 @@ def check_if_done(self):
 self.conn.close()
 elif self.n_sent == self.n_released:
 self.error = None
+
+if not self.error:
--- End diff --

This 'if' is unnecessary.  Also, this test doesn't send pre-settled 
deliveries.  Why does it expect a count of dropped pre-settleds?


---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (DISPATCH-885) Modify qd_compose_insert_[string,symbol,binary] to add zero-length [string, symbol, binary] for null input

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/DISPATCH-885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16300198#comment-16300198
 ] 

ASF GitHub Bot commented on DISPATCH-885:
-

Github user asfgit closed the pull request at:

https://github.com/apache/qpid-dispatch/pull/223


> Modify qd_compose_insert_[string,symbol,binary] to add zero-length [string, 
> symbol, binary] for null input
> --
>
> Key: DISPATCH-885
> URL: https://issues.apache.org/jira/browse/DISPATCH-885
> Project: Qpid Dispatch
>  Issue Type: Improvement
>  Components: Container
>Affects Versions: 1.0.0
>Reporter: Ganesh Murthy
>Assignee: Ganesh Murthy
>Priority: Minor
> Fix For: 1.1.0
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Resolved] (DISPATCH-885) Modify qd_compose_insert_[string,symbol,binary] to add zero-length [string, symbol, binary] for null input

[Ted Ross (JIRA)]

 [ 
https://issues.apache.org/jira/browse/DISPATCH-885?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ted Ross resolved DISPATCH-885.
---
Resolution: Fixed

> Modify qd_compose_insert_[string,symbol,binary] to add zero-length [string, 
> symbol, binary] for null input
> --
>
> Key: DISPATCH-885
> URL: https://issues.apache.org/jira/browse/DISPATCH-885
> Project: Qpid Dispatch
>  Issue Type: Improvement
>  Components: Container
>Affects Versions: 1.0.0
>Reporter: Ganesh Murthy
>Assignee: Ganesh Murthy
>Priority: Minor
> Fix For: 1.1.0
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (DISPATCH-885) Modify qd_compose_insert_[string,symbol,binary] to add zero-length [string, symbol, binary] for null input

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/DISPATCH-885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16300197#comment-16300197
 ] 

ASF subversion and git services commented on DISPATCH-885:
--

Commit 918c8f7c7ba337e44aba96ebde60fd6e3d03c1c3 in qpid-dispatch's branch 
refs/heads/master from [~tr...@redhat.com]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-dispatch.git;h=918c8f7 ]

DISPATCH-885 - PR from gmurthy - Compose zero-length string/symbol/binary when 
a null pointer is provided.
This closes #223


> Modify qd_compose_insert_[string,symbol,binary] to add zero-length [string, 
> symbol, binary] for null input
> --
>
> Key: DISPATCH-885
> URL: https://issues.apache.org/jira/browse/DISPATCH-885
> Project: Qpid Dispatch
>  Issue Type: Improvement
>  Components: Container
>Affects Versions: 1.0.0
>Reporter: Ganesh Murthy
>Assignee: Ganesh Murthy
>Priority: Minor
> Fix For: 1.1.0
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-dispatch pull request #223: DISPATCH-885 - Modified qd_compose_insert_[...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/qpid-dispatch/pull/223


---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Updated] (PROTON-1727) [epoll proactor] segfaults, hangs and leaked FDs around failed connect

[Alan Conway (JIRA)]

 [ 
https://issues.apache.org/jira/browse/PROTON-1727?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Alan Conway updated PROTON-1727:

Priority: Blocker  (was: Major)

> [epoll proactor] segfaults, hangs and leaked FDs around failed connect
> --
>
> Key: PROTON-1727
> URL: https://issues.apache.org/jira/browse/PROTON-1727
> Project: Qpid Proton
>  Issue Type: Bug
>  Components: proton-c
>Affects Versions: proton-c-0.18.1
>Reporter: Alan Conway
>Assignee: Alan Conway
>Priority: Blocker
> Fix For: proton-c-0.20.0
>
>
> There is a race condition that causes leaked FDs and segfaults in the epoll 
> proactor under the following conditions:
> - there is more than one thread processing proactor events. 
> - attempting to connect to a host address that resolves to multiple socket 
> addresses, e.g. resolving the NULL hostname on a machine with ipv4 and ipv6 
> enabled.
> - there is nothing listening on the target port.
> The attached reproducer shows several bad behaviors:
> - under rr or valgrind (--tool=memcheck and --tool=helgrind) it quickly (< 
> 1min) shows race conditions and/or invalid memory access.
> - it hangs fairly often even without valgrind/rr, more so if you increase the 
> thread count. Without valgrind/rr it rarely segfaults.
> - it leaks FDs - the test should run forever, but runs out of FDs around 1024 
> iterations.
> This is probably the cause of 
> https://issues.apache.org/jira/browse/DISPATCH-902, which does occur very 
> frequently under the conditions described there.
> The test program should run forever without leaking or showing any faults. 
> Note that gcc -fsantize does not detect races or memory errors, which 
> suggests the bug requires a delay at the right time to manifest. Valgrind's 
> overhead and rr's code serialization appears to provide that delay. It seems 
> likely that dispatch's reconnect logic is providing the delay in DISPATCH-902.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Updated] (PROTON-1727) [epoll proactor] segfaults, hangs and leaked FDs around failed connect

[Alan Conway (JIRA)]

 [ 
https://issues.apache.org/jira/browse/PROTON-1727?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Alan Conway updated PROTON-1727:

Fix Version/s: (was: proton-c-0.19.0)
   proton-c-0.20.0

> [epoll proactor] segfaults, hangs and leaked FDs around failed connect
> --
>
> Key: PROTON-1727
> URL: https://issues.apache.org/jira/browse/PROTON-1727
> Project: Qpid Proton
>  Issue Type: Bug
>  Components: proton-c
>Affects Versions: proton-c-0.18.1
>Reporter: Alan Conway
>Assignee: Alan Conway
> Fix For: proton-c-0.20.0
>
>
> There is a race condition that causes leaked FDs and segfaults in the epoll 
> proactor under the following conditions:
> - there is more than one thread processing proactor events. 
> - attempting to connect to a host address that resolves to multiple socket 
> addresses, e.g. resolving the NULL hostname on a machine with ipv4 and ipv6 
> enabled.
> - there is nothing listening on the target port.
> The attached reproducer shows several bad behaviors:
> - under rr or valgrind (--tool=memcheck and --tool=helgrind) it quickly (< 
> 1min) shows race conditions and/or invalid memory access.
> - it hangs fairly often even without valgrind/rr, more so if you increase the 
> thread count. Without valgrind/rr it rarely segfaults.
> - it leaks FDs - the test should run forever, but runs out of FDs around 1024 
> iterations.
> This is probably the cause of 
> https://issues.apache.org/jira/browse/DISPATCH-902, which does occur very 
> frequently under the conditions described there.
> The test program should run forever without leaking or showing any faults. 
> Note that gcc -fsantize does not detect races or memory errors, which 
> suggests the bug requires a delay at the right time to manifest. Valgrind's 
> overhead and rr's code serialization appears to provide that delay. It seems 
> likely that dispatch's reconnect logic is providing the delay in DISPATCH-902.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Resolved] (DISPATCH-884) Add schema property to allow configurable TLS protocol versions

[Ganesh Murthy (JIRA)]

 [ 
https://issues.apache.org/jira/browse/DISPATCH-884?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ganesh Murthy resolved DISPATCH-884.

Resolution: Fixed

> Add schema property to allow configurable TLS protocol versions
> ---
>
> Key: DISPATCH-884
> URL: https://issues.apache.org/jira/browse/DISPATCH-884
> Project: Qpid Dispatch
>  Issue Type: Improvement
>  Components: Container
>Affects Versions: 1.1.0
>Reporter: Ganesh Murthy
>Assignee: Ganesh Murthy
> Fix For: 1.1.0
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (DISPATCH-884) Add schema property to allow configurable TLS protocol versions

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/DISPATCH-884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16300176#comment-16300176
 ] 

ASF GitHub Bot commented on DISPATCH-884:
-

Github user asfgit closed the pull request at:

https://github.com/apache/qpid-dispatch/pull/233


> Add schema property to allow configurable TLS protocol versions
> ---
>
> Key: DISPATCH-884
> URL: https://issues.apache.org/jira/browse/DISPATCH-884
> Project: Qpid Dispatch
>  Issue Type: Improvement
>  Components: Container
>Affects Versions: 1.1.0
>Reporter: Ganesh Murthy
>Assignee: Ganesh Murthy
> Fix For: 1.1.0
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (DISPATCH-884) Add schema property to allow configurable TLS protocol versions

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/DISPATCH-884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16300175#comment-16300175
 ] 

ASF subversion and git services commented on DISPATCH-884:
--

Commit 44ee33fc864758177cdada83bcde145f6c1964b5 in qpid-dispatch's branch 
refs/heads/master from [~tr...@redhat.com]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-dispatch.git;h=44ee33f ]

DISPATCH-884 - PR from gmurthy - Add support for configured SSL protocols.
This closes #233


> Add schema property to allow configurable TLS protocol versions
> ---
>
> Key: DISPATCH-884
> URL: https://issues.apache.org/jira/browse/DISPATCH-884
> Project: Qpid Dispatch
>  Issue Type: Improvement
>  Components: Container
>Affects Versions: 1.1.0
>Reporter: Ganesh Murthy
>Assignee: Ganesh Murthy
> Fix For: 1.1.0
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-dispatch pull request #233: DISPATCH-884 - Added schema property protoc...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/qpid-dispatch/pull/233


---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Assigned] (DISPATCH-891) Router incref assert in system_tests_delivery_abort

[Ted Ross (JIRA)]

 [ 
https://issues.apache.org/jira/browse/DISPATCH-891?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ted Ross reassigned DISPATCH-891:
-

Assignee: Ted Ross

> Router incref assert in system_tests_delivery_abort
> ---
>
> Key: DISPATCH-891
> URL: https://issues.apache.org/jira/browse/DISPATCH-891
> Project: Qpid Dispatch
>  Issue Type: Bug
>  Components: Router Node
>Affects Versions: 1.0.0
> Environment: Fedora 27,
> Dispatch master#d5f279b,
> Proton master#25025e9
>Reporter: Chuck Rolke
>Assignee: Ted Ross
> Fix For: 1.1.0
>
> Attachments: A.log
>
>
> Self tests fail every time.
> {noformat}
> > ctest -VV -R system_tests_delivery_abort
> UpdateCTestConfiguration  from 
> :/home/chug/git/qpid-dispatch/build/DartConfiguration.tcl
> Parse Config file:/home/chug/git/qpid-dispatch/build/DartConfiguration.tcl
> UpdateCTestConfiguration  from 
> :/home/chug/git/qpid-dispatch/build/DartConfiguration.tcl
> Parse Config file:/home/chug/git/qpid-dispatch/build/DartConfiguration.tcl
> Test project /home/chug/git/qpid-dispatch/build
> Constructing a list of tests
> Done constructing a list of tests
> Updating test list for fixtures
> Added 0 tests to meet fixture requirements
> Checking test dependency graph...
> Checking test dependency graph end
> test 36
> Start 36: system_tests_delivery_abort
> 36: Test command: /usr/bin/python 
> "/home/chug/git/qpid-dispatch/build/tests/run.py" "-m" "unittest" "-v" 
> "system_tests_delivery_abort"
> 36: Test timeout computed to be: 1500
> 36: test_01_message_route_truncated_one_router 
> (system_tests_delivery_abort.RouterTest) ... ok
> 36: test_02_message_route_truncated_two_routers 
> (system_tests_delivery_abort.RouterTest) ... ok
> 36: test_03_link_route_truncated_one_router 
> (system_tests_delivery_abort.RouterTest) ... ok
> 36: test_04_link_route_truncated_two_routers 
> (system_tests_delivery_abort.RouterTest) ... ok
> 36: test_05_message_route_abort_one_router 
> (system_tests_delivery_abort.RouterTest) ... ok
> 36: test_06_message_route_abort_two_routers 
> (system_tests_delivery_abort.RouterTest) ... ok
> 36: test_07_multicast_truncate_one_router 
> (system_tests_delivery_abort.RouterTest) ... FAIL
> 36: ERROR
> 36: 
> 36: ==
> 36: ERROR: tearDownClass (system_tests_delivery_abort.RouterTest)
> 36: --
> 36: Traceback (most recent call last):
> 36:   File "/home/chug/git/qpid-dispatch/tests/system_test.py", line 606, in 
> tearDownClass
> 36: cls.tester.teardown()
> 36:   File "/home/chug/git/qpid-dispatch/tests/system_test.py", line 544, in 
> teardown
> 36: raise RuntimeError("Errors during teardown: \n\n%s" % 
> "\n\n".join([str(e) for e in errors]))
> 36: RuntimeError: Errors during teardown: 
> 36: 
> 36: Process 27948 error: exit code -6, expected -1
> 36: qdrouterd -c A.conf -I /home/chug/git/qpid-dispatch/python
> 36: 
> /home/chug/git/qpid-dispatch/build/tests/system_test.dir/system_tests_delivery_abort/RouterTest/setUpClass/A-1.cmd
> 36: 
> 36: qdrouterd: /home/chug/git/qpid-dispatch/src/router_core/transfer.c:337: 
> qdr_delivery_incref: Assertion `rc > 0 || !delivery->ref_counted' failed.
> 36: qdrouterd: /home/chug/git/qpid-dispatch/src/router_core/transfer.c:337: 
> qdr_delivery_incref: Assertion `rc > 0 || !delivery->ref_counted' failed.
> 36: 
> 36: 
> 36: ==
> 36: FAIL: test_07_multicast_truncate_one_router 
> (system_tests_delivery_abort.RouterTest)
> 36: --
> 36: Traceback (most recent call last):
> 36:   File 
> "/home/chug/git/qpid-dispatch/tests/system_tests_delivery_abort.py", line 
> 128, in test_07_multicast_truncate_one_router
> 36: self.assertEqual(None, test.error)
> 36: AssertionError: None != "Timeout Expired - Unprocessed Ops: 
> ['Send_Short_3'], Result1: ['Send_Short_1'], Result2: ['Send_Short_1']"
> 36: 
> 36: --
> 36: Ran 7 tests in 17.906s
> 36: 
> 36: FAILED (failures=1, errors=1)
> 1/1 Test #36: system_tests_delivery_abort ..***Failed   18.01 sec
> 0% tests passed, 1 tests failed out of 1
> Total Test time (real) =  18.01 sec
> The following tests FAILED:
>36 - system_tests_delivery_abort (Failed)
> Errors while running CTest
> {noformat}
> Will attach failed router log with incref/decref trace



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

Re: Netty regression in 4.1.18 - does this affect Qpid JMS Client 0.28.0?

[Timothy Bish]

On 12/21/2017 04:03 AM, Keith W wrote:

Hi Robbie, Tim

I noticed the news on the Netty website that there was a regression in
4.1.18 affecting the native transport (#7507). 4.1.19 is already out.

http://netty.io/news/2017/12/18/4-1-19-Final.html

Qpid JMS 0.28.0 included Netty 4.1.18 (QPIDJMS-347) so I expect that
this might affect users taking advantage of the native IO layer on
unix platforms.   Could you confirm this likely to be the case?

Thanks Keith

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org


It could affect someone using it, the details on the issue are not great 
so hard to say what the exact case is that leads to the error.  As 
always the user can easy disable the native transports from the 
connection URI as a workaround should they encounter issues with them.


We'll update our netty dep on the next client release.

--
Tim Bish


-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Updated] (PROTON-1727) [epoll proactor] segfaults, hangs and leaked FDs around failed connect

[Alan Conway (JIRA)]

 [ 
https://issues.apache.org/jira/browse/PROTON-1727?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Alan Conway updated PROTON-1727:

Fix Version/s: proton-c-0.19.0

> [epoll proactor] segfaults, hangs and leaked FDs around failed connect
> --
>
> Key: PROTON-1727
> URL: https://issues.apache.org/jira/browse/PROTON-1727
> Project: Qpid Proton
>  Issue Type: Bug
>  Components: proton-c
>Affects Versions: proton-c-0.18.1
>Reporter: Alan Conway
>Assignee: Alan Conway
> Fix For: proton-c-0.19.0
>
>
> There is a race condition that causes leaked FDs and segfaults in the epoll 
> proactor under the following conditions:
> - there is more than one thread processing proactor events. 
> - attempting to connect to a host address that resolves to multiple socket 
> addresses, e.g. resolving the NULL hostname on a machine with ipv4 and ipv6 
> enabled.
> - there is nothing listening on the target port.
> The attached reproducer shows several bad behaviors:
> - under rr or valgrind (--tool=memcheck and --tool=helgrind) it quickly (< 
> 1min) shows race conditions and/or invalid memory access.
> - it hangs fairly often even without valgrind/rr, more so if you increase the 
> thread count. Without valgrind/rr it rarely segfaults.
> - it leaks FDs - the test should run forever, but runs out of FDs around 1024 
> iterations.
> This is probably the cause of 
> https://issues.apache.org/jira/browse/DISPATCH-902, which does occur very 
> frequently under the conditions described there.
> The test program should run forever without leaking or showing any faults. 
> Note that gcc -fsantize does not detect races or memory errors, which 
> suggests the bug requires a delay at the right time to manifest. Valgrind's 
> overhead and rr's code serialization appears to provide that delay. It seems 
> likely that dispatch's reconnect logic is providing the delay in DISPATCH-902.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Resolved] (DISPATCH-900) Memory leak when repeatedly opening and closing connections

[Ted Ross (JIRA)]

 [ 
https://issues.apache.org/jira/browse/DISPATCH-900?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ted Ross resolved DISPATCH-900.
---
Resolution: Fixed

> Memory leak when repeatedly opening and closing connections
> ---
>
> Key: DISPATCH-900
> URL: https://issues.apache.org/jira/browse/DISPATCH-900
> Project: Qpid Dispatch
>  Issue Type: Bug
>  Components: Container
>Affects Versions: 1.0.0
>Reporter: Ganesh Murthy
>Assignee: Ganesh Murthy
> Fix For: 1.1.0
>
>
> Steps to reproduce - 
> 1. Start the router with the default config file
> 2. Run the following python program which simply opens and closes connections.
> {noformat}
> from proton.utils import BlockingConnection
> URL = '0.0.0.0:5672'
> continue_loop = True
> while continue_loop:
> connection = BlockingConnection(url=URL, ssl_domain=None)
> print 'Creating connection'
> connection.close()
> {noformat}
> 3. While the above python program is running, start up the *top* program and 
> watch the memory of the router grow.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (DISPATCH-900) Memory leak when repeatedly opening and closing connections

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/DISPATCH-900?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16300150#comment-16300150
 ] 

ASF subversion and git services commented on DISPATCH-900:
--

Commit 3bf8cfe9c326a74a076cb7e1e3ff0cee43137d10 in qpid-dispatch's branch 
refs/heads/master from [~tr...@redhat.com]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-dispatch.git;h=3bf8cfe ]

DISPATCH-900 - PR from gmurthy, remove references to unused management entity 
which was moved to the core agent.
This closes #235


> Memory leak when repeatedly opening and closing connections
> ---
>
> Key: DISPATCH-900
> URL: https://issues.apache.org/jira/browse/DISPATCH-900
> Project: Qpid Dispatch
>  Issue Type: Bug
>  Components: Container
>Affects Versions: 1.0.0
>Reporter: Ganesh Murthy
>Assignee: Ganesh Murthy
> Fix For: 1.1.0
>
>
> Steps to reproduce - 
> 1. Start the router with the default config file
> 2. Run the following python program which simply opens and closes connections.
> {noformat}
> from proton.utils import BlockingConnection
> URL = '0.0.0.0:5672'
> continue_loop = True
> while continue_loop:
> connection = BlockingConnection(url=URL, ssl_domain=None)
> print 'Creating connection'
> connection.close()
> {noformat}
> 3. While the above python program is running, start up the *top* program and 
> watch the memory of the router grow.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (DISPATCH-900) Memory leak when repeatedly opening and closing connections

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/DISPATCH-900?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16300151#comment-16300151
 ] 

ASF GitHub Bot commented on DISPATCH-900:
-

Github user asfgit closed the pull request at:

https://github.com/apache/qpid-dispatch/pull/235


> Memory leak when repeatedly opening and closing connections
> ---
>
> Key: DISPATCH-900
> URL: https://issues.apache.org/jira/browse/DISPATCH-900
> Project: Qpid Dispatch
>  Issue Type: Bug
>  Components: Container
>Affects Versions: 1.0.0
>Reporter: Ganesh Murthy
>Assignee: Ganesh Murthy
> Fix For: 1.1.0
>
>
> Steps to reproduce - 
> 1. Start the router with the default config file
> 2. Run the following python program which simply opens and closes connections.
> {noformat}
> from proton.utils import BlockingConnection
> URL = '0.0.0.0:5672'
> continue_loop = True
> while continue_loop:
> connection = BlockingConnection(url=URL, ssl_domain=None)
> print 'Creating connection'
> connection.close()
> {noformat}
> 3. While the above python program is running, start up the *top* program and 
> watch the memory of the router grow.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-dispatch pull request #235: DISPATCH-900 - Fixed memory leak caused by ...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/qpid-dispatch/pull/235


---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Updated] (DISPATCH-900) Memory leak when repeatedly opening and closing connections

[Ganesh Murthy (JIRA)]

 [ 
https://issues.apache.org/jira/browse/DISPATCH-900?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ganesh Murthy updated DISPATCH-900:
---
Fix Version/s: (was: 1.0.0)
   1.1.0

> Memory leak when repeatedly opening and closing connections
> ---
>
> Key: DISPATCH-900
> URL: https://issues.apache.org/jira/browse/DISPATCH-900
> Project: Qpid Dispatch
>  Issue Type: Bug
>  Components: Container
>Affects Versions: 1.0.0
>Reporter: Ganesh Murthy
>Assignee: Ganesh Murthy
> Fix For: 1.1.0
>
>
> Steps to reproduce - 
> 1. Start the router with the default config file
> 2. Run the following python program which simply opens and closes connections.
> {noformat}
> from proton.utils import BlockingConnection
> URL = '0.0.0.0:5672'
> continue_loop = True
> while continue_loop:
> connection = BlockingConnection(url=URL, ssl_domain=None)
> print 'Creating connection'
> connection.close()
> {noformat}
> 3. While the above python program is running, start up the *top* program and 
> watch the memory of the router grow.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Created] (PROTON-1727) [epoll proactor] segfaults, hangs and leaked FDs around failed connect

[Alan Conway (JIRA)]

Alan Conway created PROTON-1727:
---

 Summary: [epoll proactor] segfaults, hangs and leaked FDs around 
failed connect
 Key: PROTON-1727
 URL: https://issues.apache.org/jira/browse/PROTON-1727
 Project: Qpid Proton
  Issue Type: Bug
  Components: proton-c
Affects Versions: proton-c-0.18.1
Reporter: Alan Conway
Assignee: Alan Conway


There is a race condition that causes leaked FDs and segfaults in the epoll 
proactor under the following conditions:

- there is more than one thread processing proactor events. 
- attempting to connect to a host address that resolves to multiple socket 
addresses, e.g. resolving the NULL hostname on a machine with ipv4 and ipv6 
enabled.
- there is nothing listening on the target port.

The attached reproducer shows several bad behaviors:
- under rr or valgrind (--tool=memcheck and --tool=helgrind) it quickly (< 
1min) shows race conditions and/or invalid memory access.
- it hangs fairly often even without valgrind/rr, more so if you increase the 
thread count. Without valgrind/rr it rarely segfaults.
- it leaks FDs - the test should run forever, but runs out of FDs around 1024 
iterations.

This is probably the cause of 
https://issues.apache.org/jira/browse/DISPATCH-902, which does occur very 
frequently under the conditions described there.

The test program should run forever without leaking or showing any faults. 

Note that gcc -fsantize does not detect races or memory errors, which suggests 
the bug requires a delay at the right time to manifest. Valgrind's overhead and 
rr's code serialization appears to provide that delay. It seems likely that 
dispatch's reconnect logic is providing the delay in DISPATCH-902.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Updated] (DISPATCH-902) Intermittent crash with link to broker when broker closed

[Alan Conway (JIRA)]

 [ 
https://issues.apache.org/jira/browse/DISPATCH-902?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Alan Conway updated DISPATCH-902:
-
Attachment: testme.tgz

Proton-only reproducer. See Makefile for how to build/run.

Notes:
- you must have ipv6+ipv4 enabled, the bug requires that a NULL host to 
resolve() result in two addresses.
- this does not require connection failure and subsequent reconnect, it 
illustrates bad behavior simply by trying to connect to a port with nothing 
listening.
- run under valgrind, helgrind or rr quickly (< 1min) shows problems with race 
conditions and invalid memory access. 
- the test program also hangs fairly often even without valgrind, more so if 
you increase the thread count.
- Run normally it rarely segfaults (I saw it once), probably dispatch reconnect 
logic is delaying a thread in just the right place so we see this often after a 
disconnect in dispatch.
- The test also shows we are leaking FDs on this kind of failure, the test 
program should run forever but runs out of FDs around 1024 iterations.

Although I haven't seen an identical stack to the dispatch case, what I have 
seen is all in the same area. I am fairly confident that if we can make this 
test program run forever it will fix the dispatch problem.

> Intermittent crash with link to broker when broker closed
> -
>
> Key: DISPATCH-902
> URL: https://issues.apache.org/jira/browse/DISPATCH-902
> Project: Qpid Dispatch
>  Issue Type: Bug
>Affects Versions: 1.0.0
>Reporter: Kim van der Riet
>Assignee: Alan Conway
>Priority: Blocker
> Fix For: 1.1.0
>
> Attachments: qdrouterd.node1.conf, qdrouterd.node2.conf, 
> qpidd.d2n.conf, testme.tgz
>
>
> When using dispatch in a 2-node configuration with a broker between them:
> {noformat}
> 9002   10001   100019003
> sender > dispatch1 -> qpid-cpp -> dispatch2 -> receiver
> {noformat}
> and initializing in the following order:
> # start dispatch1
> # start dispatch2
> # start qpid-cpp
> # wait for "Link Route Activated" messages on both dispatch nodes
> # stop qpid-cpp
> then the dispatch nodes will core after a random amount of time and after 
> sending a random number of 
> {noformat}
> (info) Connection to localhost:10001 failed: proton:io Connection refused - 
> on read from localhost:10001
> {noformat}
> messages.
> The stack trace is as follows for all occurrences:
> {noformat}
> Thread 3 "qdrouterd" received signal SIGSEGV, Segmentation fault.
> [Switching to Thread 0x7fffea269700 (LWP 10954)]
> pn_transport_tail_closed (transport=0x0) at 
> /home/kpvdr/RedHat/qpid-proton/proton-c/src/core/transport.c:3044
> 3044  bool pn_transport_tail_closed(pn_transport_t *transport) { return 
> transport->tail_closed; }
> (gdb) thread apply all bt
> Thread 5 (Thread 0x7fffe9267700 (LWP 10956)):
> #0  0x767eb6d3 in epoll_wait () at 
> ../sysdeps/unix/syscall-template.S:84
> #1  0x777327e2 in proactor_do_epoll (p=0x89b550, 
> can_block=can_block@entry=true) at 
> /home/kpvdr/RedHat/qpid-proton/proton-c/src/proactor/epoll.c:1978
> #2  0x777337ca in pn_proactor_wait (p=) at 
> /home/kpvdr/RedHat/qpid-proton/proton-c/src/proactor/epoll.c:2025
> #3  0x77bbc219 in thread_run (arg=0x89ec20) at 
> /home/kpvdr/RedHat/qpid-dispatch/src/server.c:932
> #4  0x775185ca in start_thread (arg=0x7fffe9267700) at 
> pthread_create.c:333
> #5  0x767eb0cd in clone () at 
> ../sysdeps/unix/sysv/linux/x86_64/clone.S:109
> Thread 4 (Thread 0x7fffe9a68700 (LWP 10955)):
> #0  0x767eb6d3 in epoll_wait () at 
> ../sysdeps/unix/syscall-template.S:84
> #1  0x777327e2 in proactor_do_epoll (p=0x89b550, 
> can_block=can_block@entry=true) at 
> /home/kpvdr/RedHat/qpid-proton/proton-c/src/proactor/epoll.c:1978
> #2  0x777337ca in pn_proactor_wait (p=) at 
> /home/kpvdr/RedHat/qpid-proton/proton-c/src/proactor/epoll.c:2025
> #3  0x77bbc219 in thread_run (arg=0x89ec20) at 
> /home/kpvdr/RedHat/qpid-dispatch/src/server.c:932
> #4  0x775185ca in start_thread (arg=0x7fffe9a68700) at 
> pthread_create.c:333
> #5  0x767eb0cd in clone () at 
> ../sysdeps/unix/sysv/linux/x86_64/clone.S:109
> Thread 3 (Thread 0x7fffea269700 (LWP 10954)):
> #0  pn_transport_tail_closed (transport=0x0) at 
> /home/kpvdr/RedHat/qpid-proton/proton-c/src/core/transport.c:3044
> #1  0x7794f4f9 in pn_connection_driver_read_closed 
> (d=d@entry=0x7fffdc054288) at 
> /home/kpvdr/RedHat/qpid-proton/proton-c/src/core/connection_driver.c:109
> #2  0x77731ef1 in pconnection_rclosed (pc=0x7fffdc053ce0) at 
> /home/kpvdr/RedHat/qpid-proton/proton-c/src/proactor/epoll.c:898
> #3  pconnection_process (pc=0x7fffdc053ce0, events=, 
> timeout=timeout@entry=false, 

[jira] [Commented] (PROTON-1726) Using PN_TRACE_RAW causes segv

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/PROTON-1726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16300065#comment-16300065
 ] 

ASF subversion and git services commented on PROTON-1726:
-

Commit b462433e375258167caea81e617f437ce512b12f in qpid-proton's branch 
refs/heads/master from [~astitcher]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=b462433 ]

PROTON-1687/PROTON-1726: Fix crash when using PN_TRACE_RAW
- Corrected unsigned subtraction mess.


> Using PN_TRACE_RAW causes segv
> --
>
> Key: PROTON-1726
> URL: https://issues.apache.org/jira/browse/PROTON-1726
> Project: Qpid Proton
>  Issue Type: Bug
>  Components: proton-c
>Affects Versions: proton-j-0.19.0
>Reporter: Andrew Stitcher
>Assignee: Andrew Stitcher
> Fix For: proton-c-0.20.0
>
>
> caused by a bug in PROTON-1687



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (PROTON-1687) Improve efficiency of the transport output buffer

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/PROTON-1687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16300064#comment-16300064
 ] 

ASF subversion and git services commented on PROTON-1687:
-

Commit b462433e375258167caea81e617f437ce512b12f in qpid-proton's branch 
refs/heads/master from [~astitcher]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=b462433 ]

PROTON-1687/PROTON-1726: Fix crash when using PN_TRACE_RAW
- Corrected unsigned subtraction mess.


> Improve efficiency of the transport output buffer
> -
>
> Key: PROTON-1687
> URL: https://issues.apache.org/jira/browse/PROTON-1687
> Project: Qpid Proton
>  Issue Type: Improvement
>  Components: proton-c
>Affects Versions: proton-c-0.18.0
>Reporter: Ted Ross
>Assignee: Andrew Stitcher
>  Labels: perf
> Fix For: proton-c-0.19.0
>
>
> As the size of the transport output buffer grows due to production of 
> deliveries sent through pn_link_send, the amount of time that the CPU spends 
> in memmove becomes a problem.
> It appears (dispatcher.c - pn_dispatcher_output) that whenever a block of 
> data is removed from the buffer, the remainder of the data in the buffer is 
> shifted down using memmove.  If the buffer contains a large amount of data 
> (100s of megabytes), the sending process may spend several minutes doing 
> almost nothing but running memmove.
> Some data:
>   (credit window of 250, unlimited session window, 1 MB payload)
>   - 10 messages, .251 sec, 40 deliveries/sec
>   - 20 messages, 1.267s, 16 dlv/s
>   - 40 messages, 6s, 7 dlv/s
>   - 80 messages, 28s, 3 dlv/s
>   - 160 messages, 138s, ~1 dlv/s



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Created] (PROTON-1726) Using PN_TRACE_RAW causes segv

[Andrew Stitcher (JIRA)]

Andrew Stitcher created PROTON-1726:
---

 Summary: Using PN_TRACE_RAW causes segv
 Key: PROTON-1726
 URL: https://issues.apache.org/jira/browse/PROTON-1726
 Project: Qpid Proton
  Issue Type: Bug
  Components: proton-c
Affects Versions: proton-j-0.19.0
Reporter: Andrew Stitcher
Assignee: Andrew Stitcher
 Fix For: proton-c-0.20.0


caused by a bug in PROTON-1687



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

Re: Review Request 64645: authorization support for sasl delegation plugin

[Chug Rolke]

> On Dec. 15, 2017, 9:41 p.m., Chug Rolke wrote:
> > This seems like a decent approach for starters.
> > 
> > It may have an issue when multiple vhosts come in to the router on the same 
> > port. All of the connections then are sent to the same authServicePlugin 
> > authService port for authentication and authz. In the current policy scheme 
> > the policy is decided later when the AMQP Open frame's hostname field is 
> > used as the name of the vhost policy. Then the user name is looked up in 
> > that vhost policy section.
> 
> Gordon Sim wrote:
> The vhost name can be sent in the sasl-init frame which allows the actual 
> auth service to determine which 'realm' to authenticate against. At present 
> in the plugin this is always taken from configuration, however it could be 
> taken from what the client sends.

It could. Adding the sasl-init hostname sounds like a worthy addition precisely 
for the realm spec and the authentication.

Qpid and AMQP.Net Lite clients have gone through some effort to pass the TLS 
Server Name Indication (SNI) through to the AMQP Open hostname. The clients 
would need to add support to ensure that the SNI hostname makes it into 
sasl-init properly. Having three sources of 'hostname' (external-ssl, 
sasl-init, AMQP Open) is not ideal but is manageable.


- Chug


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64645/#review193976
---


On Dec. 20, 2017, 5:40 p.m., Gordon Sim wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64645/
> ---
> 
> (Updated Dec. 20, 2017, 5:40 p.m.)
> 
> 
> Review request for qpid, Chug Rolke, Ganesh Murthy, and Ted Ross.
> 
> 
> Bugs: DISPATCH-901
> https://issues.apache.org/jira/browse/DISPATCH-901
> 
> 
> Repository: qpid-dispatch
> 
> 
> Description
> ---
> 
> If the client specifies its desire for the ADDRESS-AUTHZ capacbility, the 
> authorization service, if it supports this, will return a set of permissions 
> in the properties of the open frame. The properties will have an 
> address-authz key, whose value is a map of address (or wildcard pattern) to 
> an array of permissions. The only permissions recognised at present by this 
> patch are 'send' and 'recv'.
> 
> 
> Diffs
> -
> 
>   src/policy.c 22cc79f 
>   src/remote_sasl.c e3c969b 
>   tests/CMakeLists.txt 0c6454c 
>   tests/authservice.py PRE-CREATION 
>   tests/system_tests_authz_service_plugin.py PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/64645/diff/4/
> 
> 
> Testing
> ---
> 
> Added new systems tests using proton python based dummy auth service.
> 
> 
> Thanks,
> 
> Gordon Sim
> 
>

[jira] [Resolved] (DISPATCH-905) Dispatch Router not failing over to slave broker when master broker goes away

[Ted Ross (JIRA)]

 [ 
https://issues.apache.org/jira/browse/DISPATCH-905?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ted Ross resolved DISPATCH-905.
---
Resolution: Fixed

> Dispatch Router not failing over to slave broker when master broker goes away
> -
>
> Key: DISPATCH-905
> URL: https://issues.apache.org/jira/browse/DISPATCH-905
> Project: Qpid Dispatch
>  Issue Type: Bug
>  Components: Container
>Affects Versions: 1.0.0
>Reporter: Ganesh Murthy
>Assignee: Ganesh Murthy
> Fix For: 1.1.0
>
> Attachments: broker-master.xml, broker-slave.xml, failover.conf
>
>
> Attached are 3 files
> 1. broker-master.xml (Apache Artemis master broker configuration)
> 2. broker-slave.xml (Apache Artemis slave broker configuration)
> 3. failover.conf (Qpid Dispatch configuration file which connects to the 
> master broker)
> Steps to reproduce the issue - 
> 1. Start 2 artemis brokers with the provided master and slave broker xml files
> 2. Start the Qpid Dispatch router with the provided config file with frame 
> trace on like this 
> {noformat}
> PN_TRACE_FRM=1 qdrouterd -c failover.conf 
> {noformat}
> 3. The master broker will send an open frame to the router than has a 
> failover list. The open frame looks like the following - 
> {noformat}
> [0x7f7b6000c1e0]:0 <- @open(16) [container-id="0.0.0.0", 
> max-frame-size=4294967295, channel-max=65535, idle-time-out=3, 
> offered-capabilities=@PN_SYMBOL[:"sole-connection-for-container", 
> :"DELAYED_DELIVERY", :"SHARED-SUBS", :"ANONYMOUS-RELAY"], 
> properties={:product="apache-activemq-artemis", 
> :"failover-server-list"=[{:hostname="127.0.0.1", :scheme="amqp", :port=62616, 
> :"network-host"="127.0.0.1"}], :version="2.4.0"}]
> {noformat}
> Notice that the failover list is providing the url for the backup slave 
> broker.
> 4. Now terminate the master broker.
> 5. Dispatch router must sense that the connection to the master broker has 
> gone down and must try to connect to the slave broker but it does not.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-dispatch pull request #237: DISPATCH-905 - Added a general get-as-strin...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/qpid-dispatch/pull/237


---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (DISPATCH-905) Dispatch Router not failing over to slave broker when master broker goes away

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/DISPATCH-905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16300012#comment-16300012
 ] 

ASF GitHub Bot commented on DISPATCH-905:
-

Github user asfgit closed the pull request at:

https://github.com/apache/qpid-dispatch/pull/237


> Dispatch Router not failing over to slave broker when master broker goes away
> -
>
> Key: DISPATCH-905
> URL: https://issues.apache.org/jira/browse/DISPATCH-905
> Project: Qpid Dispatch
>  Issue Type: Bug
>  Components: Container
>Affects Versions: 1.0.0
>Reporter: Ganesh Murthy
>Assignee: Ganesh Murthy
> Fix For: 1.1.0
>
> Attachments: broker-master.xml, broker-slave.xml, failover.conf
>
>
> Attached are 3 files
> 1. broker-master.xml (Apache Artemis master broker configuration)
> 2. broker-slave.xml (Apache Artemis slave broker configuration)
> 3. failover.conf (Qpid Dispatch configuration file which connects to the 
> master broker)
> Steps to reproduce the issue - 
> 1. Start 2 artemis brokers with the provided master and slave broker xml files
> 2. Start the Qpid Dispatch router with the provided config file with frame 
> trace on like this 
> {noformat}
> PN_TRACE_FRM=1 qdrouterd -c failover.conf 
> {noformat}
> 3. The master broker will send an open frame to the router than has a 
> failover list. The open frame looks like the following - 
> {noformat}
> [0x7f7b6000c1e0]:0 <- @open(16) [container-id="0.0.0.0", 
> max-frame-size=4294967295, channel-max=65535, idle-time-out=3, 
> offered-capabilities=@PN_SYMBOL[:"sole-connection-for-container", 
> :"DELAYED_DELIVERY", :"SHARED-SUBS", :"ANONYMOUS-RELAY"], 
> properties={:product="apache-activemq-artemis", 
> :"failover-server-list"=[{:hostname="127.0.0.1", :scheme="amqp", :port=62616, 
> :"network-host"="127.0.0.1"}], :version="2.4.0"}]
> {noformat}
> Notice that the failover list is providing the url for the backup slave 
> broker.
> 4. Now terminate the master broker.
> 5. Dispatch router must sense that the connection to the master broker has 
> gone down and must try to connect to the slave broker but it does not.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (DISPATCH-905) Dispatch Router not failing over to slave broker when master broker goes away

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/DISPATCH-905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16300011#comment-16300011
 ] 

ASF subversion and git services commented on DISPATCH-905:
--

Commit 5ca979d53c7761e36ff95052971c1009f29441fc in qpid-dispatch's branch 
refs/heads/master from [~tr...@redhat.com]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-dispatch.git;h=5ca979d ]

DISPATCH-905 - Added a general get-as-string facility for proton data elements. 
 Use this facility for the port field in the failover list.
This closes #237


> Dispatch Router not failing over to slave broker when master broker goes away
> -
>
> Key: DISPATCH-905
> URL: https://issues.apache.org/jira/browse/DISPATCH-905
> Project: Qpid Dispatch
>  Issue Type: Bug
>  Components: Container
>Affects Versions: 1.0.0
>Reporter: Ganesh Murthy
>Assignee: Ganesh Murthy
> Fix For: 1.1.0
>
> Attachments: broker-master.xml, broker-slave.xml, failover.conf
>
>
> Attached are 3 files
> 1. broker-master.xml (Apache Artemis master broker configuration)
> 2. broker-slave.xml (Apache Artemis slave broker configuration)
> 3. failover.conf (Qpid Dispatch configuration file which connects to the 
> master broker)
> Steps to reproduce the issue - 
> 1. Start 2 artemis brokers with the provided master and slave broker xml files
> 2. Start the Qpid Dispatch router with the provided config file with frame 
> trace on like this 
> {noformat}
> PN_TRACE_FRM=1 qdrouterd -c failover.conf 
> {noformat}
> 3. The master broker will send an open frame to the router than has a 
> failover list. The open frame looks like the following - 
> {noformat}
> [0x7f7b6000c1e0]:0 <- @open(16) [container-id="0.0.0.0", 
> max-frame-size=4294967295, channel-max=65535, idle-time-out=3, 
> offered-capabilities=@PN_SYMBOL[:"sole-connection-for-container", 
> :"DELAYED_DELIVERY", :"SHARED-SUBS", :"ANONYMOUS-RELAY"], 
> properties={:product="apache-activemq-artemis", 
> :"failover-server-list"=[{:hostname="127.0.0.1", :scheme="amqp", :port=62616, 
> :"network-host"="127.0.0.1"}], :version="2.4.0"}]
> {noformat}
> Notice that the failover list is providing the url for the backup slave 
> broker.
> 4. Now terminate the master broker.
> 5. Dispatch router must sense that the connection to the master broker has 
> gone down and must try to connect to the slave broker but it does not.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

Netty regression in 4.1.18 - does this affect Qpid JMS Client 0.28.0?

[Keith W]

Hi Robbie, Tim

I noticed the news on the Netty website that there was a regression in
4.1.18 affecting the native transport (#7507). 4.1.19 is already out.

http://netty.io/news/2017/12/18/4-1-19-Final.html

Qpid JMS 0.28.0 included Netty 4.1.18 (QPIDJMS-347) so I expect that
this might affect users taking advantage of the native IO layer on
unix platforms.   Could you confirm this likely to be the case?

Thanks Keith

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org