[jira] [Updated] (DISPATCH-1496) router can grant extra credit during drain of a link-routed receiver
[
https://issues.apache.org/jira/browse/DISPATCH-1496?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ganesh Murthy updated DISPATCH-1496:
Affects Version/s: (was: 1.10.0)
1.9.0
> router can grant extra credit during drain of a link-routed receiver
>
>
> Key: DISPATCH-1496
> URL: https://issues.apache.org/jira/browse/DISPATCH-1496
> Project: Qpid Dispatch
> Issue Type: Bug
>Affects Versions: 1.9.0
>Reporter: Robbie Gemmell
>Assignee: Ganesh Murthy
>Priority: Major
> Fix For: 1.10.0
>
> Attachments: qdrouterd.conf, simple_recv_drain.py
>
>
> The router can grant extra credit during drain of a link-routed receiver,
> leading to the router having more outstanding credit to the peer than the
> receiver has actually granted.
> The following shows a link-routed receiver draining credit from the link,
> after a single message having been received from the broker it was
> link-routed to. The router relays the flow from client to broker as expected,
> with "delivery-count=1, link-credit=999, drain=true", and relays the brokers
> response with "delivery-count=1000, link-credit=0, drain=true":
> {noformat}
> [0x27bb800]:1 <- @flow(19) [next-incoming-id=1, incoming-window=2047,
> next-outgoing-id=5, outgoing-window=2147483647, handle=2, delivery-count=1,
> link-credit=999, drain=true]
> [0x2763c90]:0 -> @flow(19) [next-incoming-id=2, incoming-window=2147483647,
> next-outgoing-id=4, outgoing-window=2147483647, handle=2, delivery-count=1,
> link-credit=999, drain=true]
> [0x2763c90]:0 <- @flow(19) [next-incoming-id=4, incoming-window=2147483647,
> next-outgoing-id=2, outgoing-window=2147483647, handle=2,
> delivery-count=1000, link-credit=0, drain=true]
> [0x27bb800]:1 -> @flow(19) [next-incoming-id=5, incoming-window=2147483647,
> next-outgoing-id=1, outgoing-window=2147483647, handle=2,
> delivery-count=1000, link-credit=0, drain=true]
> {noformat}
> The receiver then supplies more credit, which the router again relays as
> expected:
> {noformat}
> [0x27bb800]:1 <- @flow(19) [next-incoming-id=1, incoming-window=2047,
> next-outgoing-id=5, outgoing-window=2147483647, handle=2,
> delivery-count=1000, link-credit=1000]
> [0x2763c90]:0 -> @flow(19) [next-incoming-id=2, incoming-window=2147483647,
> next-outgoing-id=4, outgoing-window=2147483647, handle=2,
> delivery-count=1000, link-credit=1000, drain=false]
> {noformat}
> The receiver then drained this credit without having received any messages.
> The router relays the drain, but _incorrectly grants additional credit to the
> broker at the same time_, despite the receiver not having done so itself. The
> credit is drained, and the router updates the receiver to note it is also
> drained. Note however that the delivery counts have now diverged between
> client->router and router->broker, which seems unexpected for a link route.
> {noformat}
> [0x27bb800]:1 <- @flow(19) [next-incoming-id=1, incoming-window=2047,
> next-outgoing-id=7, outgoing-window=2147483647, handle=2,
> delivery-count=1000, link-credit=1000, drain=true]
> [0x2763c90]:0 -> @flow(19) [next-incoming-id=2, incoming-window=2147483647,
> next-outgoing-id=6, outgoing-window=2147483647, handle=2,
> delivery-count=1000, link-credit=2000, drain=true]
> [0x2763c90]:0 <- @flow(19) [next-incoming-id=6, incoming-window=2147483647,
> next-outgoing-id=2, outgoing-window=2147483647, handle=2,
> delivery-count=3000, link-credit=0, drain=true]
> [0x27bb800]:1 -> @flow(19) [next-incoming-id=7, incoming-window=2147483647,
> next-outgoing-id=1, outgoing-window=2147483647, handle=2,
> delivery-count=2000, link-credit=0, drain=true]
> {noformat}
> Had the broker been able to send messages using the mistakenly granted extra
> credit, the router would not be able to pass these all on to the client until
> it granted more credit. It isnt clear what would happen to them, but it seems
> like they could get stuck in the router until more credit is granted by the
> receiver, or the receiver detaches, etc. Again, unexpected for a link-route.
> The system continued on in this case since since this receiver grants (and
> drains) new credit:
> {noformat}
> [0x27bb800]:1 <- @flow(19) [next-incoming-id=1, incoming-window=2047,
> next-outgoing-id=7, outgoing-window=2147483647, handle=2,
> delivery-count=2000, link-credit=1000]
> [0x2763c90]:0 -> @flow(19) [next-incoming-id=2, incoming-window=2147483647,
> next-outgoing-id=6, outgoing-window=2147483647, handle=2,
> delivery-count=3000, link-credit=1000, drain=false]
> etc etc
> {noformat}
> however the delivery-count divergence grows over time as the situation
> repeats.
>
> Noticed while trying out changes for DISPATCH-1488.
--
This message was sent by Atlassian
[jira] [Resolved] (DISPATCH-1496) router can grant extra credit during drain of a link-routed receiver
[
https://issues.apache.org/jira/browse/DISPATCH-1496?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ganesh Murthy resolved DISPATCH-1496.
-
Fix Version/s: 1.10.0
Resolution: Fixed
> router can grant extra credit during drain of a link-routed receiver
>
>
> Key: DISPATCH-1496
> URL: https://issues.apache.org/jira/browse/DISPATCH-1496
> Project: Qpid Dispatch
> Issue Type: Bug
>Affects Versions: 1.10.0
>Reporter: Robbie Gemmell
>Assignee: Ganesh Murthy
>Priority: Major
> Fix For: 1.10.0
>
> Attachments: qdrouterd.conf, simple_recv_drain.py
>
>
> The router can grant extra credit during drain of a link-routed receiver,
> leading to the router having more outstanding credit to the peer than the
> receiver has actually granted.
> The following shows a link-routed receiver draining credit from the link,
> after a single message having been received from the broker it was
> link-routed to. The router relays the flow from client to broker as expected,
> with "delivery-count=1, link-credit=999, drain=true", and relays the brokers
> response with "delivery-count=1000, link-credit=0, drain=true":
> {noformat}
> [0x27bb800]:1 <- @flow(19) [next-incoming-id=1, incoming-window=2047,
> next-outgoing-id=5, outgoing-window=2147483647, handle=2, delivery-count=1,
> link-credit=999, drain=true]
> [0x2763c90]:0 -> @flow(19) [next-incoming-id=2, incoming-window=2147483647,
> next-outgoing-id=4, outgoing-window=2147483647, handle=2, delivery-count=1,
> link-credit=999, drain=true]
> [0x2763c90]:0 <- @flow(19) [next-incoming-id=4, incoming-window=2147483647,
> next-outgoing-id=2, outgoing-window=2147483647, handle=2,
> delivery-count=1000, link-credit=0, drain=true]
> [0x27bb800]:1 -> @flow(19) [next-incoming-id=5, incoming-window=2147483647,
> next-outgoing-id=1, outgoing-window=2147483647, handle=2,
> delivery-count=1000, link-credit=0, drain=true]
> {noformat}
> The receiver then supplies more credit, which the router again relays as
> expected:
> {noformat}
> [0x27bb800]:1 <- @flow(19) [next-incoming-id=1, incoming-window=2047,
> next-outgoing-id=5, outgoing-window=2147483647, handle=2,
> delivery-count=1000, link-credit=1000]
> [0x2763c90]:0 -> @flow(19) [next-incoming-id=2, incoming-window=2147483647,
> next-outgoing-id=4, outgoing-window=2147483647, handle=2,
> delivery-count=1000, link-credit=1000, drain=false]
> {noformat}
> The receiver then drained this credit without having received any messages.
> The router relays the drain, but _incorrectly grants additional credit to the
> broker at the same time_, despite the receiver not having done so itself. The
> credit is drained, and the router updates the receiver to note it is also
> drained. Note however that the delivery counts have now diverged between
> client->router and router->broker, which seems unexpected for a link route.
> {noformat}
> [0x27bb800]:1 <- @flow(19) [next-incoming-id=1, incoming-window=2047,
> next-outgoing-id=7, outgoing-window=2147483647, handle=2,
> delivery-count=1000, link-credit=1000, drain=true]
> [0x2763c90]:0 -> @flow(19) [next-incoming-id=2, incoming-window=2147483647,
> next-outgoing-id=6, outgoing-window=2147483647, handle=2,
> delivery-count=1000, link-credit=2000, drain=true]
> [0x2763c90]:0 <- @flow(19) [next-incoming-id=6, incoming-window=2147483647,
> next-outgoing-id=2, outgoing-window=2147483647, handle=2,
> delivery-count=3000, link-credit=0, drain=true]
> [0x27bb800]:1 -> @flow(19) [next-incoming-id=7, incoming-window=2147483647,
> next-outgoing-id=1, outgoing-window=2147483647, handle=2,
> delivery-count=2000, link-credit=0, drain=true]
> {noformat}
> Had the broker been able to send messages using the mistakenly granted extra
> credit, the router would not be able to pass these all on to the client until
> it granted more credit. It isnt clear what would happen to them, but it seems
> like they could get stuck in the router until more credit is granted by the
> receiver, or the receiver detaches, etc. Again, unexpected for a link-route.
> The system continued on in this case since since this receiver grants (and
> drains) new credit:
> {noformat}
> [0x27bb800]:1 <- @flow(19) [next-incoming-id=1, incoming-window=2047,
> next-outgoing-id=7, outgoing-window=2147483647, handle=2,
> delivery-count=2000, link-credit=1000]
> [0x2763c90]:0 -> @flow(19) [next-incoming-id=2, incoming-window=2147483647,
> next-outgoing-id=6, outgoing-window=2147483647, handle=2,
> delivery-count=3000, link-credit=1000, drain=false]
> etc etc
> {noformat}
> however the delivery-count divergence grows over time as the situation
> repeats.
>
> Noticed while trying out changes for DISPATCH-1488.
--
This message was sent by Atlassian Jira
[jira] [Commented] (DISPATCH-1496) router can grant extra credit during drain of a link-routed receiver
[
https://issues.apache.org/jira/browse/DISPATCH-1496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16987400#comment-16987400
]
ASF GitHub Bot commented on DISPATCH-1496:
--
asfgit commented on pull request #636: DISPATCH-1496: Reset link variables
after the drain is complete. Also…
URL: https://github.com/apache/qpid-dispatch/pull/636
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> router can grant extra credit during drain of a link-routed receiver
>
>
> Key: DISPATCH-1496
> URL: https://issues.apache.org/jira/browse/DISPATCH-1496
> Project: Qpid Dispatch
> Issue Type: Bug
>Affects Versions: 1.10.0
>Reporter: Robbie Gemmell
>Assignee: Ganesh Murthy
>Priority: Major
> Attachments: qdrouterd.conf, simple_recv_drain.py
>
>
> The router can grant extra credit during drain of a link-routed receiver,
> leading to the router having more outstanding credit to the peer than the
> receiver has actually granted.
> The following shows a link-routed receiver draining credit from the link,
> after a single message having been received from the broker it was
> link-routed to. The router relays the flow from client to broker as expected,
> with "delivery-count=1, link-credit=999, drain=true", and relays the brokers
> response with "delivery-count=1000, link-credit=0, drain=true":
> {noformat}
> [0x27bb800]:1 <- @flow(19) [next-incoming-id=1, incoming-window=2047,
> next-outgoing-id=5, outgoing-window=2147483647, handle=2, delivery-count=1,
> link-credit=999, drain=true]
> [0x2763c90]:0 -> @flow(19) [next-incoming-id=2, incoming-window=2147483647,
> next-outgoing-id=4, outgoing-window=2147483647, handle=2, delivery-count=1,
> link-credit=999, drain=true]
> [0x2763c90]:0 <- @flow(19) [next-incoming-id=4, incoming-window=2147483647,
> next-outgoing-id=2, outgoing-window=2147483647, handle=2,
> delivery-count=1000, link-credit=0, drain=true]
> [0x27bb800]:1 -> @flow(19) [next-incoming-id=5, incoming-window=2147483647,
> next-outgoing-id=1, outgoing-window=2147483647, handle=2,
> delivery-count=1000, link-credit=0, drain=true]
> {noformat}
> The receiver then supplies more credit, which the router again relays as
> expected:
> {noformat}
> [0x27bb800]:1 <- @flow(19) [next-incoming-id=1, incoming-window=2047,
> next-outgoing-id=5, outgoing-window=2147483647, handle=2,
> delivery-count=1000, link-credit=1000]
> [0x2763c90]:0 -> @flow(19) [next-incoming-id=2, incoming-window=2147483647,
> next-outgoing-id=4, outgoing-window=2147483647, handle=2,
> delivery-count=1000, link-credit=1000, drain=false]
> {noformat}
> The receiver then drained this credit without having received any messages.
> The router relays the drain, but _incorrectly grants additional credit to the
> broker at the same time_, despite the receiver not having done so itself. The
> credit is drained, and the router updates the receiver to note it is also
> drained. Note however that the delivery counts have now diverged between
> client->router and router->broker, which seems unexpected for a link route.
> {noformat}
> [0x27bb800]:1 <- @flow(19) [next-incoming-id=1, incoming-window=2047,
> next-outgoing-id=7, outgoing-window=2147483647, handle=2,
> delivery-count=1000, link-credit=1000, drain=true]
> [0x2763c90]:0 -> @flow(19) [next-incoming-id=2, incoming-window=2147483647,
> next-outgoing-id=6, outgoing-window=2147483647, handle=2,
> delivery-count=1000, link-credit=2000, drain=true]
> [0x2763c90]:0 <- @flow(19) [next-incoming-id=6, incoming-window=2147483647,
> next-outgoing-id=2, outgoing-window=2147483647, handle=2,
> delivery-count=3000, link-credit=0, drain=true]
> [0x27bb800]:1 -> @flow(19) [next-incoming-id=7, incoming-window=2147483647,
> next-outgoing-id=1, outgoing-window=2147483647, handle=2,
> delivery-count=2000, link-credit=0, drain=true]
> {noformat}
> Had the broker been able to send messages using the mistakenly granted extra
> credit, the router would not be able to pass these all on to the client until
> it granted more credit. It isnt clear what would happen to them, but it seems
> like they could get stuck in the router until more credit is granted by the
> receiver, or the receiver detaches, etc. Again, unexpected for a link-route.
> The system continued on in this case since since this receiver grants (and
> drains) new credit:
> {noformat}
> [0x27bb800]:1 <- @flow(19) [next-incoming-id=1, incoming-window=2047,
> next-outgoing-id=7, outgoing-window=2147483647, handle=2,
>
[jira] [Commented] (DISPATCH-1496) router can grant extra credit during drain of a link-routed receiver
[
https://issues.apache.org/jira/browse/DISPATCH-1496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16987399#comment-16987399
]
ASF subversion and git services commented on DISPATCH-1496:
---
Commit 74fab8dadda289d42f4bb10348485c4af427b788 in qpid-dispatch's branch
refs/heads/master from Ganesh Murthy
[ https://gitbox.apache.org/repos/asf?p=qpid-dispatch.git;h=74fab8d ]
DISPATCH-1496: Reset link variables after the drain is complete. Also removed
unused drain flag and related functionality. This closes #636.
> router can grant extra credit during drain of a link-routed receiver
>
>
> Key: DISPATCH-1496
> URL: https://issues.apache.org/jira/browse/DISPATCH-1496
> Project: Qpid Dispatch
> Issue Type: Bug
>Affects Versions: 1.10.0
>Reporter: Robbie Gemmell
>Assignee: Ganesh Murthy
>Priority: Major
> Attachments: qdrouterd.conf, simple_recv_drain.py
>
>
> The router can grant extra credit during drain of a link-routed receiver,
> leading to the router having more outstanding credit to the peer than the
> receiver has actually granted.
> The following shows a link-routed receiver draining credit from the link,
> after a single message having been received from the broker it was
> link-routed to. The router relays the flow from client to broker as expected,
> with "delivery-count=1, link-credit=999, drain=true", and relays the brokers
> response with "delivery-count=1000, link-credit=0, drain=true":
> {noformat}
> [0x27bb800]:1 <- @flow(19) [next-incoming-id=1, incoming-window=2047,
> next-outgoing-id=5, outgoing-window=2147483647, handle=2, delivery-count=1,
> link-credit=999, drain=true]
> [0x2763c90]:0 -> @flow(19) [next-incoming-id=2, incoming-window=2147483647,
> next-outgoing-id=4, outgoing-window=2147483647, handle=2, delivery-count=1,
> link-credit=999, drain=true]
> [0x2763c90]:0 <- @flow(19) [next-incoming-id=4, incoming-window=2147483647,
> next-outgoing-id=2, outgoing-window=2147483647, handle=2,
> delivery-count=1000, link-credit=0, drain=true]
> [0x27bb800]:1 -> @flow(19) [next-incoming-id=5, incoming-window=2147483647,
> next-outgoing-id=1, outgoing-window=2147483647, handle=2,
> delivery-count=1000, link-credit=0, drain=true]
> {noformat}
> The receiver then supplies more credit, which the router again relays as
> expected:
> {noformat}
> [0x27bb800]:1 <- @flow(19) [next-incoming-id=1, incoming-window=2047,
> next-outgoing-id=5, outgoing-window=2147483647, handle=2,
> delivery-count=1000, link-credit=1000]
> [0x2763c90]:0 -> @flow(19) [next-incoming-id=2, incoming-window=2147483647,
> next-outgoing-id=4, outgoing-window=2147483647, handle=2,
> delivery-count=1000, link-credit=1000, drain=false]
> {noformat}
> The receiver then drained this credit without having received any messages.
> The router relays the drain, but _incorrectly grants additional credit to the
> broker at the same time_, despite the receiver not having done so itself. The
> credit is drained, and the router updates the receiver to note it is also
> drained. Note however that the delivery counts have now diverged between
> client->router and router->broker, which seems unexpected for a link route.
> {noformat}
> [0x27bb800]:1 <- @flow(19) [next-incoming-id=1, incoming-window=2047,
> next-outgoing-id=7, outgoing-window=2147483647, handle=2,
> delivery-count=1000, link-credit=1000, drain=true]
> [0x2763c90]:0 -> @flow(19) [next-incoming-id=2, incoming-window=2147483647,
> next-outgoing-id=6, outgoing-window=2147483647, handle=2,
> delivery-count=1000, link-credit=2000, drain=true]
> [0x2763c90]:0 <- @flow(19) [next-incoming-id=6, incoming-window=2147483647,
> next-outgoing-id=2, outgoing-window=2147483647, handle=2,
> delivery-count=3000, link-credit=0, drain=true]
> [0x27bb800]:1 -> @flow(19) [next-incoming-id=7, incoming-window=2147483647,
> next-outgoing-id=1, outgoing-window=2147483647, handle=2,
> delivery-count=2000, link-credit=0, drain=true]
> {noformat}
> Had the broker been able to send messages using the mistakenly granted extra
> credit, the router would not be able to pass these all on to the client until
> it granted more credit. It isnt clear what would happen to them, but it seems
> like they could get stuck in the router until more credit is granted by the
> receiver, or the receiver detaches, etc. Again, unexpected for a link-route.
> The system continued on in this case since since this receiver grants (and
> drains) new credit:
> {noformat}
> [0x27bb800]:1 <- @flow(19) [next-incoming-id=1, incoming-window=2047,
> next-outgoing-id=7, outgoing-window=2147483647, handle=2,
> delivery-count=2000, link-credit=1000]
> [0x2763c90]:0 -> @flow(19) [next-incoming-id=2, incoming-window=2147483647,
> next-outgoing-id=6,
[GitHub] [qpid-dispatch] asfgit closed pull request #636: DISPATCH-1496: Reset link variables after the drain is complete. Also…
asfgit closed pull request #636: DISPATCH-1496: Reset link variables after the drain is complete. Also… URL: https://github.com/apache/qpid-dispatch/pull/636 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1488) link-routed transaction coordination broken due to 'declared' state truncation
[
https://issues.apache.org/jira/browse/DISPATCH-1488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16987367#comment-16987367
]
ASF GitHub Bot commented on DISPATCH-1488:
--
kgiusti commented on issue #638: DISPATCH-1488: add test to verify transanction
handling
URL: https://github.com/apache/qpid-dispatch/pull/638#issuecomment-561411336
At this point that's the best we can do. I'm going to talk a bit further
with the proton devs - either I'm doing it wrong or the python api needs to be
enhanced.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> link-routed transaction coordination broken due to 'declared' state truncation
> --
>
> Key: DISPATCH-1488
> URL: https://issues.apache.org/jira/browse/DISPATCH-1488
> Project: Qpid Dispatch
> Issue Type: Bug
>Affects Versions: 1.9.0, 1.10.0
>Reporter: Robbie Gemmell
>Assignee: Ken Giusti
>Priority: Blocker
> Fix For: 1.10.0
>
>
> The 1.9.0 release and current master for 1.10.0 both truncate the 'declared'
> transaction delivery state when routing a transaction coordinator link to a
> broker peer, omitting the contained txn-id and breaking all ability to link
> route transactional work through the router.
> Some output while trying this to debug an unrelated issue is detailed below.
> First, a message transfer arrives at the router with body requesting a
> transaction declare. The router sends the link-routed transfer onward to the
> broker:
> {noformat}
> [0x2251560]:1 <- @transfer(20) [handle=0, delivery-id=0,
> delivery-tag=b"\x00", message-format=0, settled=false] (7) "\x00Sw\x00S1E"
> [0x21ddf40]:0 -> @transfer(20) [handle=1, delivery-id=0,
> delivery-tag=b"\x00", message-format=0] (7) "\x00Sw\x00S1E"
> {noformat}
> (Not shown, after the above in the case being debugged, there was a
> non-transactional transfer on a second session across the same client->router
> connection, then forwarded on the same router->broker connection).
> The broker peer establishes a transaction and responds with disposition to
> indicate it is declared, and providing the mandatory txn-id. The router
> relays this disposition, but critically drops the txn-id from the delivery
> state:
> {noformat}
> [0x21ddf40]:0 <- @disposition(21) [role=true, first=0, last=0, settled=true,
> state=@declared(51) [txn-id=b"4a12a39a-09fe-11ea-91ae-000c29e9f622"]]
> [0x2251560]:1 -> @disposition(21) [role=true, first=0, settled=true,
> state=@declared(51) null]
> {noformat}
> The recipient client then barfs at this point since txn-id is mandatory for
> the declared state.
> Using 1.8.0, the declared state transited the router fine:
> {noformat}
> [0x1f49530]:0 <- @disposition(21) [role=true, first=0, last=0, settled=true,
> state=@declared(51) [txn-id=b"78dabc4f-0a00-11ea-bb46-000c29e9f622"]]
> [0x1fc2b20]:2 -> @disposition(21) [role=true, first=0, settled=true,
> state=@declared(51) [txn-id=b"78dabc4f-0a00-11ea-bb46-000c29e9f622"]]
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] kgiusti commented on issue #638: DISPATCH-1488: add test to verify transanction handling
kgiusti commented on issue #638: DISPATCH-1488: add test to verify transanction handling URL: https://github.com/apache/qpid-dispatch/pull/638#issuecomment-561411336 At this point that's the best we can do. I'm going to talk a bit further with the proton devs - either I'm doing it wrong or the python api needs to be enhanced. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Resolved] (PROTON-2144) [C] Memory usage tracking
[ https://issues.apache.org/jira/browse/PROTON-2144?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Stitcher resolved PROTON-2144. - Fix Version/s: proton-c-0.30.0 Resolution: Implemented Note that this isn't enabled by default yet - that should be a separate issue. > [C] Memory usage tracking > - > > Key: PROTON-2144 > URL: https://issues.apache.org/jira/browse/PROTON-2144 > Project: Qpid Proton > Issue Type: Improvement > Components: proton-c >Reporter: Andrew Stitcher >Assignee: Andrew Stitcher >Priority: Major > Fix For: proton-c-0.30.0 > > > If you find that proton is using too much memory, it can be hard to figure > out where the memory is being used. > It would be useful to be able to see which objects/types of object are using > what memory. > As proton-c has quite well developed "object model" code this can be used to > aid significantly in accounting for the different types of object and > accounting for their memory use. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-proton] astitcher commented on issue #219: Memory usage tracking for proton-c
astitcher commented on issue #219: Memory usage tracking for proton-c URL: https://github.com/apache/qpid-proton/pull/219#issuecomment-561393845 I've modified this code so that by default it is essentially not compiled and the memory allocation is unaltered - using malloc, calloc, realloc and free. If you want memory debugging you can compile it with -DPN_MEMDEBUG to enable the debugging code. I decided to commit it for this release because it is sufficiently useful that it should have more exposure, but decided not to compile it by default due the issues noted above. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (PROTON-2144) [C] Memory usage tracking
[ https://issues.apache.org/jira/browse/PROTON-2144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16987330#comment-16987330 ] ASF subversion and git services commented on PROTON-2144: - Commit 0ae944a24cc895d1fd5e6c3c3589a164382cff8e in qpid-proton's branch refs/heads/master from Andrew Stitcher [ https://gitbox.apache.org/repos/asf?p=qpid-proton.git;h=0ae944a ] PROTON-2144: Create memory tracking framework - Note this is currently not enabled by default, as currently there are some important unknowns. - However it is potentially very useful so it can be turned on with a compile time define (PN_MEMDEBUG). - In future it should be characterised and perhaps enabled by default. > [C] Memory usage tracking > - > > Key: PROTON-2144 > URL: https://issues.apache.org/jira/browse/PROTON-2144 > Project: Qpid Proton > Issue Type: Improvement > Components: proton-c >Reporter: Andrew Stitcher >Assignee: Andrew Stitcher >Priority: Major > > If you find that proton is using too much memory, it can be hard to figure > out where the memory is being used. > It would be useful to be able to see which objects/types of object are using > what memory. > As proton-c has quite well developed "object model" code this can be used to > aid significantly in accounting for the different types of object and > accounting for their memory use. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (PROTON-2144) [C] Memory usage tracking
[ https://issues.apache.org/jira/browse/PROTON-2144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16987331#comment-16987331 ] ASF subversion and git services commented on PROTON-2144: - Commit 927d43f43118b9f1558bf721ac7a3a97b9fd7c7c in qpid-proton's branch refs/heads/master from Andrew Stitcher [ https://gitbox.apache.org/repos/asf?p=qpid-proton.git;h=927d43f ] PROTON-2144: Instrument all memory allocation/deallocation in proton core - Replace all use of malloc/calloc/realloc/free in libqpid-proton-core with instrumented memory tracking calls > [C] Memory usage tracking > - > > Key: PROTON-2144 > URL: https://issues.apache.org/jira/browse/PROTON-2144 > Project: Qpid Proton > Issue Type: Improvement > Components: proton-c >Reporter: Andrew Stitcher >Assignee: Andrew Stitcher >Priority: Major > > If you find that proton is using too much memory, it can be hard to figure > out where the memory is being used. > It would be useful to be able to see which objects/types of object are using > what memory. > As proton-c has quite well developed "object model" code this can be used to > aid significantly in accounting for the different types of object and > accounting for their memory use. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-proton] asfgit merged pull request #219: Memory usage tracking for proton-c
asfgit merged pull request #219: Memory usage tracking for proton-c URL: https://github.com/apache/qpid-proton/pull/219 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (PROTON-2140) proton-c has very high memory footprint for links
[ https://issues.apache.org/jira/browse/PROTON-2140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16987292#comment-16987292 ] ASF subversion and git services commented on PROTON-2140: - Commit 26c3d79711a62f0a2741a085dced2bbd0def8fab in qpid-proton's branch refs/heads/master from Andrew Stitcher [ https://gitbox.apache.org/repos/asf?p=qpid-proton.git;h=26c3d79 ] PROTON-2140: Revert an internal ABI change that breaks the Ruby binding > proton-c has very high memory footprint for links > - > > Key: PROTON-2140 > URL: https://issues.apache.org/jira/browse/PROTON-2140 > Project: Qpid Proton > Issue Type: Improvement >Reporter: Gordon Sim >Priority: Major > Fix For: proton-c-0.30.0 > > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Resolved] (PROTON-2103) [Python] abstract_server example has incorrect import
[ https://issues.apache.org/jira/browse/PROTON-2103?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Stitcher resolved PROTON-2103. - Resolution: Fixed > [Python] abstract_server example has incorrect import > - > > Key: PROTON-2103 > URL: https://issues.apache.org/jira/browse/PROTON-2103 > Project: Qpid Proton > Issue Type: Bug >Reporter: Andrew Stitcher >Assignee: Andrew Stitcher >Priority: Minor > Fix For: proton-c-0.30.0 > > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1496) router can grant extra credit during drain of a link-routed receiver
[ https://issues.apache.org/jira/browse/DISPATCH-1496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16987273#comment-16987273 ] ASF GitHub Bot commented on DISPATCH-1496: -- codecov-io commented on issue #636: DISPATCH-1496: Reset link variables after the drain is complete. Also… URL: https://github.com/apache/qpid-dispatch/pull/636#issuecomment-560187516 # [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/636?src=pr=h1) Report > Merging [#636](https://codecov.io/gh/apache/qpid-dispatch/pull/636?src=pr=desc) into [master](https://codecov.io/gh/apache/qpid-dispatch/commit/9f7bb192e57019385296808fdb2f5c1edf03f909?src=pr=desc) will **increase** coverage by `0.03%`. > The diff coverage is `100%`. [](https://codecov.io/gh/apache/qpid-dispatch/pull/636?src=pr=tree) ```diff @@Coverage Diff @@ ## master #636 +/- ## == + Coverage 86.48% 86.52% +0.03% == Files 91 91 Lines 2062820629 +1 == + Hits1784117850 +9 + Misses 2787 2779 -8 ``` | [Impacted Files](https://codecov.io/gh/apache/qpid-dispatch/pull/636?src=pr=tree) | Coverage Δ | | |---|---|---| | [src/container.c](https://codecov.io/gh/apache/qpid-dispatch/pull/636/diff?src=pr=tree#diff-c3JjL2NvbnRhaW5lci5j) | `82.35% <ø> (+0.97%)` | :arrow_up: | | [src/router\_core/transfer.c](https://codecov.io/gh/apache/qpid-dispatch/pull/636/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL3RyYW5zZmVyLmM=) | `93.43% <100%> (-0.43%)` | :arrow_down: | | [src/router\_node.c](https://codecov.io/gh/apache/qpid-dispatch/pull/636/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9ub2RlLmM=) | `93.11% <100%> (+0.01%)` | :arrow_up: | | [src/router\_core/connections.c](https://codecov.io/gh/apache/qpid-dispatch/pull/636/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL2Nvbm5lY3Rpb25zLmM=) | `93.87% <0%> (-0.23%)` | :arrow_down: | | [src/policy.c](https://codecov.io/gh/apache/qpid-dispatch/pull/636/diff?src=pr=tree#diff-c3JjL3BvbGljeS5j) | `87.07% <0%> (+0.01%)` | :arrow_up: | | [src/python\_embedded.c](https://codecov.io/gh/apache/qpid-dispatch/pull/636/diff?src=pr=tree#diff-c3JjL3B5dGhvbl9lbWJlZGRlZC5j) | `78.45% <0%> (+0.05%)` | :arrow_up: | | [src/parse.c](https://codecov.io/gh/apache/qpid-dispatch/pull/636/diff?src=pr=tree#diff-c3JjL3BhcnNlLmM=) | `87.97% <0%> (+0.1%)` | :arrow_up: | | [src/iterator.c](https://codecov.io/gh/apache/qpid-dispatch/pull/636/diff?src=pr=tree#diff-c3JjL2l0ZXJhdG9yLmM=) | `89.51% <0%> (+0.16%)` | :arrow_up: | | ... and [1 more](https://codecov.io/gh/apache/qpid-dispatch/pull/636/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/636?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/636?src=pr=footer). Last update [9f7bb19...e1659f8](https://codecov.io/gh/apache/qpid-dispatch/pull/636?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > router can grant extra credit during drain of a link-routed receiver > > > Key: DISPATCH-1496 > URL: https://issues.apache.org/jira/browse/DISPATCH-1496 > Project: Qpid Dispatch > Issue Type: Bug >Affects Versions: 1.10.0 >Reporter: Robbie Gemmell >Assignee: Ganesh Murthy >Priority: Major > Attachments: qdrouterd.conf, simple_recv_drain.py > > > The router can grant extra credit during drain of a link-routed receiver, > leading to the router having more outstanding credit to the peer than the > receiver has actually granted. > The following shows a link-routed receiver draining credit from the link, > after a single message having been received from the broker it was > link-routed to. The router relays the flow from client to broker as expected, > with "delivery-count=1, link-credit=999, drain=true", and relays the brokers >
[GitHub] [qpid-dispatch] codecov-io edited a comment on issue #636: DISPATCH-1496: Reset link variables after the drain is complete. Also…
codecov-io edited a comment on issue #636: DISPATCH-1496: Reset link variables after the drain is complete. Also… URL: https://github.com/apache/qpid-dispatch/pull/636#issuecomment-560187516 # [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/636?src=pr=h1) Report > Merging [#636](https://codecov.io/gh/apache/qpid-dispatch/pull/636?src=pr=desc) into [master](https://codecov.io/gh/apache/qpid-dispatch/commit/9f7bb192e57019385296808fdb2f5c1edf03f909?src=pr=desc) will **increase** coverage by `0.03%`. > The diff coverage is `100%`. [](https://codecov.io/gh/apache/qpid-dispatch/pull/636?src=pr=tree) ```diff @@Coverage Diff @@ ## master #636 +/- ## == + Coverage 86.48% 86.52% +0.03% == Files 91 91 Lines 2062820629 +1 == + Hits1784117850 +9 + Misses 2787 2779 -8 ``` | [Impacted Files](https://codecov.io/gh/apache/qpid-dispatch/pull/636?src=pr=tree) | Coverage Δ | | |---|---|---| | [src/container.c](https://codecov.io/gh/apache/qpid-dispatch/pull/636/diff?src=pr=tree#diff-c3JjL2NvbnRhaW5lci5j) | `82.35% <ø> (+0.97%)` | :arrow_up: | | [src/router\_core/transfer.c](https://codecov.io/gh/apache/qpid-dispatch/pull/636/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL3RyYW5zZmVyLmM=) | `93.43% <100%> (-0.43%)` | :arrow_down: | | [src/router\_node.c](https://codecov.io/gh/apache/qpid-dispatch/pull/636/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9ub2RlLmM=) | `93.11% <100%> (+0.01%)` | :arrow_up: | | [src/router\_core/connections.c](https://codecov.io/gh/apache/qpid-dispatch/pull/636/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL2Nvbm5lY3Rpb25zLmM=) | `93.87% <0%> (-0.23%)` | :arrow_down: | | [src/policy.c](https://codecov.io/gh/apache/qpid-dispatch/pull/636/diff?src=pr=tree#diff-c3JjL3BvbGljeS5j) | `87.07% <0%> (+0.01%)` | :arrow_up: | | [src/python\_embedded.c](https://codecov.io/gh/apache/qpid-dispatch/pull/636/diff?src=pr=tree#diff-c3JjL3B5dGhvbl9lbWJlZGRlZC5j) | `78.45% <0%> (+0.05%)` | :arrow_up: | | [src/parse.c](https://codecov.io/gh/apache/qpid-dispatch/pull/636/diff?src=pr=tree#diff-c3JjL3BhcnNlLmM=) | `87.97% <0%> (+0.1%)` | :arrow_up: | | [src/iterator.c](https://codecov.io/gh/apache/qpid-dispatch/pull/636/diff?src=pr=tree#diff-c3JjL2l0ZXJhdG9yLmM=) | `89.51% <0%> (+0.16%)` | :arrow_up: | | ... and [1 more](https://codecov.io/gh/apache/qpid-dispatch/pull/636/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/636?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/636?src=pr=footer). Last update [9f7bb19...e1659f8](https://codecov.io/gh/apache/qpid-dispatch/pull/636?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Reopened] (PROTON-2099) [Python] example test runner script leaks file handles
[ https://issues.apache.org/jira/browse/PROTON-2099?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Stitcher reopened PROTON-2099: - > [Python] example test runner script leaks file handles > -- > > Key: PROTON-2099 > URL: https://issues.apache.org/jira/browse/PROTON-2099 > Project: Qpid Proton > Issue Type: Bug >Reporter: Andrew Stitcher >Assignee: Andrew Stitcher >Priority: Major > Fix For: proton-c-0.30.0 > > > Since python 3.6 python moans when this happens and so the test runs are very > noisy. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Resolved] (PROTON-2099) [Python] example test runner script leaks file handles
[ https://issues.apache.org/jira/browse/PROTON-2099?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Stitcher resolved PROTON-2099. - Resolution: Fixed > [Python] example test runner script leaks file handles > -- > > Key: PROTON-2099 > URL: https://issues.apache.org/jira/browse/PROTON-2099 > Project: Qpid Proton > Issue Type: Bug >Reporter: Andrew Stitcher >Assignee: Andrew Stitcher >Priority: Major > Fix For: proton-c-0.30.0 > > > Since python 3.6 python moans when this happens and so the test runs are very > noisy. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Updated] (PROTON-2099) [Python] example test runner script leaks file handles
[ https://issues.apache.org/jira/browse/PROTON-2099?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Stitcher updated PROTON-2099: Fix Version/s: proton-c-0.30.0 > [Python] example test runner script leaks file handles > -- > > Key: PROTON-2099 > URL: https://issues.apache.org/jira/browse/PROTON-2099 > Project: Qpid Proton > Issue Type: Bug >Reporter: Andrew Stitcher >Assignee: Andrew Stitcher >Priority: Major > Fix For: proton-c-0.30.0 > > > Since python 3.6 python moans when this happens and so the test runs are very > noisy. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1509) Leak of core agent timer
[ https://issues.apache.org/jira/browse/DISPATCH-1509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16987233#comment-16987233 ] Ken Giusti commented on DISPATCH-1509: -- WIP: [github patch|https://github.com/kgiusti/dispatch/tree/DISPATCH-1509] > Leak of core agent timer > > > Key: DISPATCH-1509 > URL: https://issues.apache.org/jira/browse/DISPATCH-1509 > Project: Qpid Dispatch > Issue Type: Bug > Components: Router Node >Affects Versions: 1.9.0 >Reporter: Ken Giusti >Assignee: Ken Giusti >Priority: Trivial > Fix For: 1.11.0 > > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Created] (DISPATCH-1509) Leak of core agent timer
Ken Giusti created DISPATCH-1509: Summary: Leak of core agent timer Key: DISPATCH-1509 URL: https://issues.apache.org/jira/browse/DISPATCH-1509 Project: Qpid Dispatch Issue Type: Bug Components: Router Node Affects Versions: 1.9.0 Reporter: Ken Giusti Assignee: Ken Giusti Fix For: 1.11.0 -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Closed] (DISPATCH-1027) Cannot connect to router using WS when amqp protocol is specified
[
https://issues.apache.org/jira/browse/DISPATCH-1027?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Kornel closed DISPATCH-1027.
--
Resolution: Invalid
> Cannot connect to router using WS when amqp protocol is specified
> -
>
> Key: DISPATCH-1027
> URL: https://issues.apache.org/jira/browse/DISPATCH-1027
> Project: Qpid Dispatch
> Issue Type: Bug
>Affects Versions: 1.1.0
> Environment: client - rhea
> router - 1.1.0-RC3 (same issue is with previous versions)
>Reporter: David Kornel
>Priority: Major
>
> I cannot connect using websocket connection to router when http is enabled in
> listener when 'amqp' protocol is specified in websocket connection. I can
> only do that when only 'binary' is specified without 'amqp'. Otherwise I
> cannot connect to artemis using websocket when amqp is not specified.
> Router:
> {code:java}
> SERVER (info) Connection from 127.0.0.1 (to 0.0.0.0:5673) failed:
> amqp:connection:framing-error No valid protocol header found
> {code}
>
> Reproducer
>
> {code:java}
> npm install cli-rhea -g
> cli-rhea-sender --broker localhost:5673 --count 1 --conn-ws true
> --conn-ws-protocols binary amqp{code}
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Comment Edited] (DISPATCH-1508) Leak of qd_listener_t's on shutdown
[ https://issues.apache.org/jira/browse/DISPATCH-1508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16987171#comment-16987171 ] Ken Giusti edited comment on DISPATCH-1508 at 12/3/19 6:47 PM: --- WIP: [github branch|https://github.com/kgiusti/dispatch/tree/DISPATCH-1508] was (Author: kgiusti): WIP: [github branch|https://github.com/kgiusti/dispatch/tree/DISPATCH-1488] > Leak of qd_listener_t's on shutdown > --- > > Key: DISPATCH-1508 > URL: https://issues.apache.org/jira/browse/DISPATCH-1508 > Project: Qpid Dispatch > Issue Type: Bug > Components: Router Node >Affects Versions: 1.9.0 >Reporter: Ken Giusti >Assignee: Ken Giusti >Priority: Minor > Fix For: 1.11.0 > > > Leaks of qd_listener_t's show up when running ctest on a > CMAKE_BUILD_TYPE=Debug build. > Example: > 19: Router solo debug dump file: > 19: alloc.c: Items of type 'qd_listener_t' remain allocated at shutdown: 4 -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1508) Leak of qd_listener_t's on shutdown
[ https://issues.apache.org/jira/browse/DISPATCH-1508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16987171#comment-16987171 ] Ken Giusti commented on DISPATCH-1508: -- WIP: [github branch|https://github.com/kgiusti/dispatch/tree/DISPATCH-1488] > Leak of qd_listener_t's on shutdown > --- > > Key: DISPATCH-1508 > URL: https://issues.apache.org/jira/browse/DISPATCH-1508 > Project: Qpid Dispatch > Issue Type: Bug > Components: Router Node >Affects Versions: 1.9.0 >Reporter: Ken Giusti >Assignee: Ken Giusti >Priority: Minor > Fix For: 1.11.0 > > > Leaks of qd_listener_t's show up when running ctest on a > CMAKE_BUILD_TYPE=Debug build. > Example: > 19: Router solo debug dump file: > 19: alloc.c: Items of type 'qd_listener_t' remain allocated at shutdown: 4 -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (PROTON-2099) [Python] example test runner script leaks file handles
[ https://issues.apache.org/jira/browse/PROTON-2099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16987169#comment-16987169 ] Andrew Stitcher commented on PROTON-2099: - [~gsim] That is painful. Closing the file handles without the context managers is probably going to be a lot more verbose and complex. > [Python] example test runner script leaks file handles > -- > > Key: PROTON-2099 > URL: https://issues.apache.org/jira/browse/PROTON-2099 > Project: Qpid Proton > Issue Type: Bug >Reporter: Andrew Stitcher >Assignee: Andrew Stitcher >Priority: Major > > Since python 3.6 python moans when this happens and so the test runs are very > noisy. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Resolved] (PROTON-2098) [Python] client abruptly disconnects after receiving disconnect-close-half socket close sequence
[
https://issues.apache.org/jira/browse/PROTON-2098?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrew Stitcher resolved PROTON-2098.
-
Fix Version/s: proton-c-0.30.0
Resolution: Fixed
> [Python] client abruptly disconnects after receiving disconnect-close-half
> socket close sequence
>
>
> Key: PROTON-2098
> URL: https://issues.apache.org/jira/browse/PROTON-2098
> Project: Qpid Proton
> Issue Type: Bug
> Components: python-binding
>Affects Versions: proton-c-0.28.0
>Reporter: Andrew Stitcher
>Assignee: Andrew Stitcher
>Priority: Major
> Fix For: proton-c-0.30.0
>
>
> This can be demonstrated by using the python examples simple_sender.py and
> direct_recv.py. If you turn logging on for direct_recv.py you will see:
> {code}
> 20190830-11:22:09:proton:DEBUG: 0x7f99e0478d50> recvd Event:
> selectable_readable()
> 20190830-11:22:09:proton:DEBUG: 0x7f99e0478d50> recvd Event:
> PN_TRANSPORT_TAIL_CLOSED( 0x55910988bfe0>)
> 20190830-11:22:09:proton:DEBUG: 0x7f99e0478d50> recvd Event: PN_TRANSPORT_CLOSED( 0x7f99e0cf09d0 ~ 0x55910988bfe0>)
> 20190830-11:22:09:proton:DEBUG: 0x7f99e0478d50> recvd Event: PN_TRANSPORT_ERROR( 0x7f99e049af50 ~ 0x55910988bfe0>)
> 20190830-11:22:09:proton:ERROR: amqp:connection:framing-error: connection
> aborted
> 20190830-11:22:09:proton:DEBUG: 0x7f99e0478d50> recvd Event: selectable_final( object at 0x7f99e049a850>)
> 20190830-11:22:09:proton:DEBUG: 0x7f99e0478d50> recvd Event:
> PN_CONNECTION_UNBOUND( 0x55910988beb0>)
> 20190830-11:22:09:proton:DEBUG: 0x7f99e0478d50> recvd Event: PN_TRANSPORT( 0x7f99e0cf09d0 ~ 0x55910988bfe0>)
> 20190830-11:22:09:proton:DEBUG: 0x7f99e0478d50> recvd Event:
> selectable_final()
> 20190830-11:22:09:proton:DEBUG: 0x7f99e0478d50> Stopping
> 20190830-11:22:09:proton:DEBUG: 0x7f99e0478d50> recvd Event: reactor_final( at 0x7f99e0478d50>)
> 20190830-11:22:09:proton:DEBUG: 0x7f99e0478d50> Stopping
> {code}
> Note the ERROR a few lines from the end.
> This makes the server end see a transport-error (as the socket was abruptly
> disconnected) which seems like an error. Although a well written server
> should not really care about this anyway as it has already shut down the
> connection from its pov.
> Arguably there should be no transport-error in this circumstance at the
> server end. But it would definitely be better behaved if the client correctly
> closed the connection from its end.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (PROTON-2099) [Python] example test runner script leaks file handles
[ https://issues.apache.org/jira/browse/PROTON-2099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16987145#comment-16987145 ] Gordon Sim commented on PROTON-2099: >From some googling 'Context management support was added in 3.2. It is not >supported in 2.7.' > [Python] example test runner script leaks file handles > -- > > Key: PROTON-2099 > URL: https://issues.apache.org/jira/browse/PROTON-2099 > Project: Qpid Proton > Issue Type: Bug >Reporter: Andrew Stitcher >Assignee: Andrew Stitcher >Priority: Major > > Since python 3.6 python moans when this happens and so the test runs are very > noisy. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Created] (DISPATCH-1508) Leak of qd_listener_t's on shutdown
Ken Giusti created DISPATCH-1508: Summary: Leak of qd_listener_t's on shutdown Key: DISPATCH-1508 URL: https://issues.apache.org/jira/browse/DISPATCH-1508 Project: Qpid Dispatch Issue Type: Bug Components: Router Node Affects Versions: 1.9.0 Reporter: Ken Giusti Assignee: Ken Giusti Fix For: 1.11.0 Leaks of qd_listener_t's show up when running ctest on a CMAKE_BUILD_TYPE=Debug build. Example: 19: Router solo debug dump file: 19: alloc.c: Items of type 'qd_listener_t' remain allocated at shutdown: 4 -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Created] (DISPATCH-1507) Don't collapse small number of edge routers and clients into single circle
Ernest Allen created DISPATCH-1507: -- Summary: Don't collapse small number of edge routers and clients into single circle Key: DISPATCH-1507 URL: https://issues.apache.org/jira/browse/DISPATCH-1507 Project: Qpid Dispatch Issue Type: Improvement Components: Console Reporter: Ernest Allen Assignee: Ernest Allen Currently on the console's topology page, if there are multiple clients of the same type, they will be collapsed into a single circle with text indicating the number of clients. This is also true for edge routers. This prevents clients attached to edge routers for appearing on the page. Add a user configurable threshold to the topology page. If the number of clients/edge routers attached to an interior router is below the threshold, they will be drawn individually, otherwise they will be collapsed as they are now. This would allow traffic to/from edge router to be visualized. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (PROTON-2099) [Python] example test runner script leaks file handles
[ https://issues.apache.org/jira/browse/PROTON-2099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16987111#comment-16987111 ] Gordon Sim commented on PROTON-2099: [~astitcher] This seems not to work for python 2.7, now I get 'AttributeError: __exit__' on the with (is the 2.7 subprocess module not compatible with with?). > [Python] example test runner script leaks file handles > -- > > Key: PROTON-2099 > URL: https://issues.apache.org/jira/browse/PROTON-2099 > Project: Qpid Proton > Issue Type: Bug >Reporter: Andrew Stitcher >Assignee: Andrew Stitcher >Priority: Major > > Since python 3.6 python moans when this happens and so the test runs are very > noisy. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1358) Port console to patternfly 4 / React
[ https://issues.apache.org/jira/browse/DISPATCH-1358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16987108#comment-16987108 ] ASF subversion and git services commented on DISPATCH-1358: --- Commit 8d5e08dbbb9c88ece3c5ea6590f7349c6c611655 in qpid-dispatch's branch refs/heads/master from Ernest Allen [ https://gitbox.apache.org/repos/asf?p=qpid-dispatch.git;h=8d5e08d ] DISPATCH-1358 Fixed font on topology legend > Port console to patternfly 4 / React > > > Key: DISPATCH-1358 > URL: https://issues.apache.org/jira/browse/DISPATCH-1358 > Project: Qpid Dispatch > Issue Type: Improvement > Components: Console >Reporter: Ernest Allen >Assignee: Ernest Allen >Priority: Major > > Initial wireframes are at https://marvelapp.com/1fhc8a26/screen/57601872 -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1358) Port console to patternfly 4 / React
[ https://issues.apache.org/jira/browse/DISPATCH-1358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16987099#comment-16987099 ] ASF subversion and git services commented on DISPATCH-1358: --- Commit 0123ba02accf65a026a0cecccd4aef131699bfbc in qpid-dispatch's branch refs/heads/master from Ernest Allen [ https://gitbox.apache.org/repos/asf?p=qpid-dispatch.git;h=0123ba0 ] DISPATCH-1358 Tweaks to dashboard page > Port console to patternfly 4 / React > > > Key: DISPATCH-1358 > URL: https://issues.apache.org/jira/browse/DISPATCH-1358 > Project: Qpid Dispatch > Issue Type: Improvement > Components: Console >Reporter: Ernest Allen >Assignee: Ernest Allen >Priority: Major > > Initial wireframes are at https://marvelapp.com/1fhc8a26/screen/57601872 -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1496) router can grant extra credit during drain of a link-routed receiver
[
https://issues.apache.org/jira/browse/DISPATCH-1496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16987075#comment-16987075
]
ASF GitHub Bot commented on DISPATCH-1496:
--
ted-ross commented on pull request #636: DISPATCH-1496: Reset link variables
after the drain is complete. Also…
URL: https://github.com/apache/qpid-dispatch/pull/636#discussion_r353296483
##
File path: src/router_node.c
##
@@ -1531,8 +1531,11 @@ static void CORE_link_drained(void *context, qdr_link_t
*link)
pn_link_t *plink = qd_link_pn(qlink);
-if (plink)
+if (plink) {
pn_link_drained(plink);
+link->drain_mode = false;
+link->credit_to_core = 0;
Review comment:
Are these operations safe to do here? This function is invoked on an IO
thread.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> router can grant extra credit during drain of a link-routed receiver
>
>
> Key: DISPATCH-1496
> URL: https://issues.apache.org/jira/browse/DISPATCH-1496
> Project: Qpid Dispatch
> Issue Type: Bug
>Affects Versions: 1.10.0
>Reporter: Robbie Gemmell
>Assignee: Ganesh Murthy
>Priority: Major
> Attachments: qdrouterd.conf, simple_recv_drain.py
>
>
> The router can grant extra credit during drain of a link-routed receiver,
> leading to the router having more outstanding credit to the peer than the
> receiver has actually granted.
> The following shows a link-routed receiver draining credit from the link,
> after a single message having been received from the broker it was
> link-routed to. The router relays the flow from client to broker as expected,
> with "delivery-count=1, link-credit=999, drain=true", and relays the brokers
> response with "delivery-count=1000, link-credit=0, drain=true":
> {noformat}
> [0x27bb800]:1 <- @flow(19) [next-incoming-id=1, incoming-window=2047,
> next-outgoing-id=5, outgoing-window=2147483647, handle=2, delivery-count=1,
> link-credit=999, drain=true]
> [0x2763c90]:0 -> @flow(19) [next-incoming-id=2, incoming-window=2147483647,
> next-outgoing-id=4, outgoing-window=2147483647, handle=2, delivery-count=1,
> link-credit=999, drain=true]
> [0x2763c90]:0 <- @flow(19) [next-incoming-id=4, incoming-window=2147483647,
> next-outgoing-id=2, outgoing-window=2147483647, handle=2,
> delivery-count=1000, link-credit=0, drain=true]
> [0x27bb800]:1 -> @flow(19) [next-incoming-id=5, incoming-window=2147483647,
> next-outgoing-id=1, outgoing-window=2147483647, handle=2,
> delivery-count=1000, link-credit=0, drain=true]
> {noformat}
> The receiver then supplies more credit, which the router again relays as
> expected:
> {noformat}
> [0x27bb800]:1 <- @flow(19) [next-incoming-id=1, incoming-window=2047,
> next-outgoing-id=5, outgoing-window=2147483647, handle=2,
> delivery-count=1000, link-credit=1000]
> [0x2763c90]:0 -> @flow(19) [next-incoming-id=2, incoming-window=2147483647,
> next-outgoing-id=4, outgoing-window=2147483647, handle=2,
> delivery-count=1000, link-credit=1000, drain=false]
> {noformat}
> The receiver then drained this credit without having received any messages.
> The router relays the drain, but _incorrectly grants additional credit to the
> broker at the same time_, despite the receiver not having done so itself. The
> credit is drained, and the router updates the receiver to note it is also
> drained. Note however that the delivery counts have now diverged between
> client->router and router->broker, which seems unexpected for a link route.
> {noformat}
> [0x27bb800]:1 <- @flow(19) [next-incoming-id=1, incoming-window=2047,
> next-outgoing-id=7, outgoing-window=2147483647, handle=2,
> delivery-count=1000, link-credit=1000, drain=true]
> [0x2763c90]:0 -> @flow(19) [next-incoming-id=2, incoming-window=2147483647,
> next-outgoing-id=6, outgoing-window=2147483647, handle=2,
> delivery-count=1000, link-credit=2000, drain=true]
> [0x2763c90]:0 <- @flow(19) [next-incoming-id=6, incoming-window=2147483647,
> next-outgoing-id=2, outgoing-window=2147483647, handle=2,
> delivery-count=3000, link-credit=0, drain=true]
> [0x27bb800]:1 -> @flow(19) [next-incoming-id=7, incoming-window=2147483647,
> next-outgoing-id=1, outgoing-window=2147483647, handle=2,
> delivery-count=2000, link-credit=0, drain=true]
> {noformat}
> Had the broker been able to send messages using the mistakenly granted extra
> credit, the router would not be able to pass these all on to the client until
> it granted more credit. It isnt clear
[GitHub] [qpid-dispatch] ted-ross commented on a change in pull request #636: DISPATCH-1496: Reset link variables after the drain is complete. Also…
ted-ross commented on a change in pull request #636: DISPATCH-1496: Reset link
variables after the drain is complete. Also…
URL: https://github.com/apache/qpid-dispatch/pull/636#discussion_r353296483
##
File path: src/router_node.c
##
@@ -1531,8 +1531,11 @@ static void CORE_link_drained(void *context, qdr_link_t
*link)
pn_link_t *plink = qd_link_pn(qlink);
-if (plink)
+if (plink) {
pn_link_drained(plink);
+link->drain_mode = false;
+link->credit_to_core = 0;
Review comment:
Are these operations safe to do here? This function is invoked on an IO
thread.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Updated] (PROTON-2110) [Python] Expand tilde symbol as user's home directory when searching for connect.json file
[
https://issues.apache.org/jira/browse/PROTON-2110?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Justin Ross updated PROTON-2110:
Fix Version/s: proton-c-0.30.0
> [Python] Expand tilde symbol as user's home directory when searching for
> connect.json file
> --
>
> Key: PROTON-2110
> URL: https://issues.apache.org/jira/browse/PROTON-2110
> Project: Qpid Proton
> Issue Type: Bug
> Components: python-binding
>Reporter: Radim Kubis
>Priority: Major
> Fix For: proton-c-0.30.0
>
>
> Tilde ({{~}}) symbol is not expanded as user's home directory, but as a
> directory named tilde in current working directory.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Resolved] (PROTON-2110) [Python] Expand tilde symbol as user's home directory when searching for connect.json file
[
https://issues.apache.org/jira/browse/PROTON-2110?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Justin Ross resolved PROTON-2110.
-
Resolution: Fixed
> [Python] Expand tilde symbol as user's home directory when searching for
> connect.json file
> --
>
> Key: PROTON-2110
> URL: https://issues.apache.org/jira/browse/PROTON-2110
> Project: Qpid Proton
> Issue Type: Bug
> Components: python-binding
>Reporter: Radim Kubis
>Priority: Major
> Fix For: proton-c-0.30.0
>
>
> Tilde ({{~}}) symbol is not expanded as user's home directory, but as a
> directory named tilde in current working directory.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Updated] (PROTON-2109) [Python] Correct default JSON schema to amqps
[
https://issues.apache.org/jira/browse/PROTON-2109?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Justin Ross updated PROTON-2109:
Fix Version/s: proton-c-0.30.0
> [Python] Correct default JSON schema to amqps
> -
>
> Key: PROTON-2109
> URL: https://issues.apache.org/jira/browse/PROTON-2109
> Project: Qpid Proton
> Issue Type: Bug
> Components: python-binding
>Reporter: Radim Kubis
>Assignee: Andrew Stitcher
>Priority: Major
> Fix For: proton-c-0.30.0
>
>
> According to
> [connect-config.md|https://github.com/apache/qpid-proton/blob/master/docs/connect-config.md],
> default port should be \{{amqps}}, but there is \{{amqp}} now.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Resolved] (PROTON-2109) [Python] Correct default JSON schema to amqps
[
https://issues.apache.org/jira/browse/PROTON-2109?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Justin Ross resolved PROTON-2109.
-
Resolution: Fixed
> [Python] Correct default JSON schema to amqps
> -
>
> Key: PROTON-2109
> URL: https://issues.apache.org/jira/browse/PROTON-2109
> Project: Qpid Proton
> Issue Type: Bug
> Components: python-binding
>Reporter: Radim Kubis
>Assignee: Andrew Stitcher
>Priority: Major
>
> According to
> [connect-config.md|https://github.com/apache/qpid-proton/blob/master/docs/connect-config.md],
> default port should be \{{amqps}}, but there is \{{amqp}} now.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Assigned] (PROTON-2109) [Python] Correct default JSON schema to amqps
[
https://issues.apache.org/jira/browse/PROTON-2109?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Justin Ross reassigned PROTON-2109:
---
Assignee: Andrew Stitcher
> [Python] Correct default JSON schema to amqps
> -
>
> Key: PROTON-2109
> URL: https://issues.apache.org/jira/browse/PROTON-2109
> Project: Qpid Proton
> Issue Type: Bug
> Components: python-binding
>Reporter: Radim Kubis
>Assignee: Andrew Stitcher
>Priority: Major
>
> According to
> [connect-config.md|https://github.com/apache/qpid-proton/blob/master/docs/connect-config.md],
> default port should be \{{amqps}}, but there is \{{amqp}} now.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPIDJMS-483) Simplify Inheritance and Polymorphism Behavior for third party lib like Avro
[ https://issues.apache.org/jira/browse/QPIDJMS-483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16987058#comment-16987058 ] ASF GitHub Bot commented on QPIDJMS-483: khamlaoui commented on issue #33: QPIDJMS-483: Simplify Inheritance and Polymorphism Behavior for third… URL: https://github.com/apache/qpid-jms/pull/33#issuecomment-561247196 Do you have any news/ remarks regarding my pull request please? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Simplify Inheritance and Polymorphism Behavior for third party lib like Avro > > > Key: QPIDJMS-483 > URL: https://issues.apache.org/jira/browse/QPIDJMS-483 > Project: Qpid JMS > Issue Type: Improvement > Components: qpid-jms-client >Affects Versions: 0.47.0 >Reporter: Khaled HAMLAOUI >Priority: Major > > > > When we use a third-party library for serialization (Avro in our case), > polymorphism and inheritance are very problematic. > It would be highly desirable if we could simply rename a field (which is > private) at the class JmsBytesMessage (facade attribute) by any other name so > that serialization can work with Avro. > I sent you a pull request for this little job. > Thank you in advance -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-jms] khamlaoui commented on issue #33: QPIDJMS-483: Simplify Inheritance and Polymorphism Behavior for third…
khamlaoui commented on issue #33: QPIDJMS-483: Simplify Inheritance and Polymorphism Behavior for third… URL: https://github.com/apache/qpid-jms/pull/33#issuecomment-561247196 Do you have any news/ remarks regarding my pull request please? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1488) link-routed transaction coordination broken due to 'declared' state truncation
[
https://issues.apache.org/jira/browse/DISPATCH-1488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16986997#comment-16986997
]
ASF GitHub Bot commented on DISPATCH-1488:
--
gemmellr commented on issue #638: DISPATCH-1488: add test to verify
transanction handling
URL: https://github.com/apache/qpid-dispatch/pull/638#issuecomment-561218716
Not so much with the test for now then after all, if I'm understanding the
code/comments? :)
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> link-routed transaction coordination broken due to 'declared' state truncation
> --
>
> Key: DISPATCH-1488
> URL: https://issues.apache.org/jira/browse/DISPATCH-1488
> Project: Qpid Dispatch
> Issue Type: Bug
>Affects Versions: 1.9.0, 1.10.0
>Reporter: Robbie Gemmell
>Assignee: Ken Giusti
>Priority: Blocker
> Fix For: 1.10.0
>
>
> The 1.9.0 release and current master for 1.10.0 both truncate the 'declared'
> transaction delivery state when routing a transaction coordinator link to a
> broker peer, omitting the contained txn-id and breaking all ability to link
> route transactional work through the router.
> Some output while trying this to debug an unrelated issue is detailed below.
> First, a message transfer arrives at the router with body requesting a
> transaction declare. The router sends the link-routed transfer onward to the
> broker:
> {noformat}
> [0x2251560]:1 <- @transfer(20) [handle=0, delivery-id=0,
> delivery-tag=b"\x00", message-format=0, settled=false] (7) "\x00Sw\x00S1E"
> [0x21ddf40]:0 -> @transfer(20) [handle=1, delivery-id=0,
> delivery-tag=b"\x00", message-format=0] (7) "\x00Sw\x00S1E"
> {noformat}
> (Not shown, after the above in the case being debugged, there was a
> non-transactional transfer on a second session across the same client->router
> connection, then forwarded on the same router->broker connection).
> The broker peer establishes a transaction and responds with disposition to
> indicate it is declared, and providing the mandatory txn-id. The router
> relays this disposition, but critically drops the txn-id from the delivery
> state:
> {noformat}
> [0x21ddf40]:0 <- @disposition(21) [role=true, first=0, last=0, settled=true,
> state=@declared(51) [txn-id=b"4a12a39a-09fe-11ea-91ae-000c29e9f622"]]
> [0x2251560]:1 -> @disposition(21) [role=true, first=0, settled=true,
> state=@declared(51) null]
> {noformat}
> The recipient client then barfs at this point since txn-id is mandatory for
> the declared state.
> Using 1.8.0, the declared state transited the router fine:
> {noformat}
> [0x1f49530]:0 <- @disposition(21) [role=true, first=0, last=0, settled=true,
> state=@declared(51) [txn-id=b"78dabc4f-0a00-11ea-bb46-000c29e9f622"]]
> [0x1fc2b20]:2 -> @disposition(21) [role=true, first=0, settled=true,
> state=@declared(51) [txn-id=b"78dabc4f-0a00-11ea-bb46-000c29e9f622"]]
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] gemmellr commented on issue #638: DISPATCH-1488: add test to verify transanction handling
gemmellr commented on issue #638: DISPATCH-1488: add test to verify transanction handling URL: https://github.com/apache/qpid-dispatch/pull/638#issuecomment-561218716 Not so much with the test for now then after all, if I'm understanding the code/comments? :) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1488) link-routed transaction coordination broken due to 'declared' state truncation
[
https://issues.apache.org/jira/browse/DISPATCH-1488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16986988#comment-16986988
]
ASF GitHub Bot commented on DISPATCH-1488:
--
codecov-io commented on issue #638: DISPATCH-1488: add test to verify
transanction handling
URL: https://github.com/apache/qpid-dispatch/pull/638#issuecomment-561209005
#
[Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/638?src=pr=h1)
Report
> Merging
[#638](https://codecov.io/gh/apache/qpid-dispatch/pull/638?src=pr=desc) into
[master](https://codecov.io/gh/apache/qpid-dispatch/commit/0f8ee090b41c6ed9c31aee54fafdc23c690cb30c?src=pr=desc)
will **decrease** coverage by `0.01%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/qpid-dispatch/pull/638?src=pr=tree)
```diff
@@Coverage Diff @@
## master #638 +/- ##
==
- Coverage86.5% 86.48% -0.02%
==
Files 91 91
Lines 2063420634
==
- Hits1784917846 -3
- Misses 2785 2788 +3
```
| [Impacted
Files](https://codecov.io/gh/apache/qpid-dispatch/pull/638?src=pr=tree) |
Coverage Δ | |
|---|---|---|
|
[src/router\_core/transfer.c](https://codecov.io/gh/apache/qpid-dispatch/pull/638/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL3RyYW5zZmVyLmM=)
| `93.36% <0%> (-1.23%)` | :arrow_down: |
|
[src/router\_node.c](https://codecov.io/gh/apache/qpid-dispatch/pull/638/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9ub2RlLmM=)
| `92.97% <0%> (-0.24%)` | :arrow_down: |
|
[src/router\_core/connections.c](https://codecov.io/gh/apache/qpid-dispatch/pull/638/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL2Nvbm5lY3Rpb25zLmM=)
| `94.09% <0%> (+0.22%)` | :arrow_up: |
|
[src/router\_core/terminus.c](https://codecov.io/gh/apache/qpid-dispatch/pull/638/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL3Rlcm1pbnVzLmM=)
| `88.97% <0%> (+0.78%)` | :arrow_up: |
--
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/638?src=pr=continue).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/638?src=pr=footer).
Last update
[0f8ee09...75fb28e](https://codecov.io/gh/apache/qpid-dispatch/pull/638?src=pr=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> link-routed transaction coordination broken due to 'declared' state truncation
> --
>
> Key: DISPATCH-1488
> URL: https://issues.apache.org/jira/browse/DISPATCH-1488
> Project: Qpid Dispatch
> Issue Type: Bug
>Affects Versions: 1.9.0, 1.10.0
>Reporter: Robbie Gemmell
>Assignee: Ken Giusti
>Priority: Blocker
> Fix For: 1.10.0
>
>
> The 1.9.0 release and current master for 1.10.0 both truncate the 'declared'
> transaction delivery state when routing a transaction coordinator link to a
> broker peer, omitting the contained txn-id and breaking all ability to link
> route transactional work through the router.
> Some output while trying this to debug an unrelated issue is detailed below.
> First, a message transfer arrives at the router with body requesting a
> transaction declare. The router sends the link-routed transfer onward to the
> broker:
> {noformat}
> [0x2251560]:1 <- @transfer(20) [handle=0, delivery-id=0,
> delivery-tag=b"\x00", message-format=0, settled=false] (7) "\x00Sw\x00S1E"
> [0x21ddf40]:0 -> @transfer(20) [handle=1, delivery-id=0,
> delivery-tag=b"\x00", message-format=0] (7) "\x00Sw\x00S1E"
> {noformat}
> (Not shown, after the above in the case being debugged, there was a
> non-transactional transfer on a second session across the same client->router
> connection, then forwarded on the same router->broker connection).
> The broker peer establishes a transaction and responds with disposition to
> indicate it is declared, and providing the mandatory txn-id. The router
> relays this disposition, but critically drops the
[GitHub] [qpid-dispatch] codecov-io commented on issue #638: DISPATCH-1488: add test to verify transanction handling
codecov-io commented on issue #638: DISPATCH-1488: add test to verify transanction handling URL: https://github.com/apache/qpid-dispatch/pull/638#issuecomment-561209005 # [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/638?src=pr=h1) Report > Merging [#638](https://codecov.io/gh/apache/qpid-dispatch/pull/638?src=pr=desc) into [master](https://codecov.io/gh/apache/qpid-dispatch/commit/0f8ee090b41c6ed9c31aee54fafdc23c690cb30c?src=pr=desc) will **decrease** coverage by `0.01%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/qpid-dispatch/pull/638?src=pr=tree) ```diff @@Coverage Diff @@ ## master #638 +/- ## == - Coverage86.5% 86.48% -0.02% == Files 91 91 Lines 2063420634 == - Hits1784917846 -3 - Misses 2785 2788 +3 ``` | [Impacted Files](https://codecov.io/gh/apache/qpid-dispatch/pull/638?src=pr=tree) | Coverage Δ | | |---|---|---| | [src/router\_core/transfer.c](https://codecov.io/gh/apache/qpid-dispatch/pull/638/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL3RyYW5zZmVyLmM=) | `93.36% <0%> (-1.23%)` | :arrow_down: | | [src/router\_node.c](https://codecov.io/gh/apache/qpid-dispatch/pull/638/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9ub2RlLmM=) | `92.97% <0%> (-0.24%)` | :arrow_down: | | [src/router\_core/connections.c](https://codecov.io/gh/apache/qpid-dispatch/pull/638/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL2Nvbm5lY3Rpb25zLmM=) | `94.09% <0%> (+0.22%)` | :arrow_up: | | [src/router\_core/terminus.c](https://codecov.io/gh/apache/qpid-dispatch/pull/638/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL3Rlcm1pbnVzLmM=) | `88.97% <0%> (+0.78%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/638?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/638?src=pr=footer). Last update [0f8ee09...75fb28e](https://codecov.io/gh/apache/qpid-dispatch/pull/638?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1496) router can grant extra credit during drain of a link-routed receiver
[
https://issues.apache.org/jira/browse/DISPATCH-1496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16986967#comment-16986967
]
ASF GitHub Bot commented on DISPATCH-1496:
--
gemmellr commented on issue #636: DISPATCH-1496: Reset link variables after the
drain is complete. Also…
URL: https://github.com/apache/qpid-dispatch/pull/636#issuecomment-561200297
No idea on the code changes, but I gave it a try out and all seemed well,
the router no longer granted extra credit itself.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> router can grant extra credit during drain of a link-routed receiver
>
>
> Key: DISPATCH-1496
> URL: https://issues.apache.org/jira/browse/DISPATCH-1496
> Project: Qpid Dispatch
> Issue Type: Bug
>Affects Versions: 1.10.0
>Reporter: Robbie Gemmell
>Assignee: Ganesh Murthy
>Priority: Major
> Attachments: qdrouterd.conf, simple_recv_drain.py
>
>
> The router can grant extra credit during drain of a link-routed receiver,
> leading to the router having more outstanding credit to the peer than the
> receiver has actually granted.
> The following shows a link-routed receiver draining credit from the link,
> after a single message having been received from the broker it was
> link-routed to. The router relays the flow from client to broker as expected,
> with "delivery-count=1, link-credit=999, drain=true", and relays the brokers
> response with "delivery-count=1000, link-credit=0, drain=true":
> {noformat}
> [0x27bb800]:1 <- @flow(19) [next-incoming-id=1, incoming-window=2047,
> next-outgoing-id=5, outgoing-window=2147483647, handle=2, delivery-count=1,
> link-credit=999, drain=true]
> [0x2763c90]:0 -> @flow(19) [next-incoming-id=2, incoming-window=2147483647,
> next-outgoing-id=4, outgoing-window=2147483647, handle=2, delivery-count=1,
> link-credit=999, drain=true]
> [0x2763c90]:0 <- @flow(19) [next-incoming-id=4, incoming-window=2147483647,
> next-outgoing-id=2, outgoing-window=2147483647, handle=2,
> delivery-count=1000, link-credit=0, drain=true]
> [0x27bb800]:1 -> @flow(19) [next-incoming-id=5, incoming-window=2147483647,
> next-outgoing-id=1, outgoing-window=2147483647, handle=2,
> delivery-count=1000, link-credit=0, drain=true]
> {noformat}
> The receiver then supplies more credit, which the router again relays as
> expected:
> {noformat}
> [0x27bb800]:1 <- @flow(19) [next-incoming-id=1, incoming-window=2047,
> next-outgoing-id=5, outgoing-window=2147483647, handle=2,
> delivery-count=1000, link-credit=1000]
> [0x2763c90]:0 -> @flow(19) [next-incoming-id=2, incoming-window=2147483647,
> next-outgoing-id=4, outgoing-window=2147483647, handle=2,
> delivery-count=1000, link-credit=1000, drain=false]
> {noformat}
> The receiver then drained this credit without having received any messages.
> The router relays the drain, but _incorrectly grants additional credit to the
> broker at the same time_, despite the receiver not having done so itself. The
> credit is drained, and the router updates the receiver to note it is also
> drained. Note however that the delivery counts have now diverged between
> client->router and router->broker, which seems unexpected for a link route.
> {noformat}
> [0x27bb800]:1 <- @flow(19) [next-incoming-id=1, incoming-window=2047,
> next-outgoing-id=7, outgoing-window=2147483647, handle=2,
> delivery-count=1000, link-credit=1000, drain=true]
> [0x2763c90]:0 -> @flow(19) [next-incoming-id=2, incoming-window=2147483647,
> next-outgoing-id=6, outgoing-window=2147483647, handle=2,
> delivery-count=1000, link-credit=2000, drain=true]
> [0x2763c90]:0 <- @flow(19) [next-incoming-id=6, incoming-window=2147483647,
> next-outgoing-id=2, outgoing-window=2147483647, handle=2,
> delivery-count=3000, link-credit=0, drain=true]
> [0x27bb800]:1 -> @flow(19) [next-incoming-id=7, incoming-window=2147483647,
> next-outgoing-id=1, outgoing-window=2147483647, handle=2,
> delivery-count=2000, link-credit=0, drain=true]
> {noformat}
> Had the broker been able to send messages using the mistakenly granted extra
> credit, the router would not be able to pass these all on to the client until
> it granted more credit. It isnt clear what would happen to them, but it seems
> like they could get stuck in the router until more credit is granted by the
> receiver, or the receiver detaches, etc. Again, unexpected for a link-route.
> The system continued on in this case since since this receiver grants (and
> drains) new credit:
> {noformat}
[GitHub] [qpid-dispatch] gemmellr commented on issue #636: DISPATCH-1496: Reset link variables after the drain is complete. Also…
gemmellr commented on issue #636: DISPATCH-1496: Reset link variables after the drain is complete. Also… URL: https://github.com/apache/qpid-dispatch/pull/636#issuecomment-561200297 No idea on the code changes, but I gave it a try out and all seemed well, the router no longer granted extra credit itself. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1488) link-routed transaction coordination broken due to 'declared' state truncation
[
https://issues.apache.org/jira/browse/DISPATCH-1488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16986951#comment-16986951
]
ASF GitHub Bot commented on DISPATCH-1488:
--
kgiusti commented on pull request #638: DISPATCH-1488: add test to verify
transanction handling
URL: https://github.com/apache/qpid-dispatch/pull/638
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> link-routed transaction coordination broken due to 'declared' state truncation
> --
>
> Key: DISPATCH-1488
> URL: https://issues.apache.org/jira/browse/DISPATCH-1488
> Project: Qpid Dispatch
> Issue Type: Bug
>Affects Versions: 1.9.0, 1.10.0
>Reporter: Robbie Gemmell
>Assignee: Ken Giusti
>Priority: Blocker
> Fix For: 1.10.0
>
>
> The 1.9.0 release and current master for 1.10.0 both truncate the 'declared'
> transaction delivery state when routing a transaction coordinator link to a
> broker peer, omitting the contained txn-id and breaking all ability to link
> route transactional work through the router.
> Some output while trying this to debug an unrelated issue is detailed below.
> First, a message transfer arrives at the router with body requesting a
> transaction declare. The router sends the link-routed transfer onward to the
> broker:
> {noformat}
> [0x2251560]:1 <- @transfer(20) [handle=0, delivery-id=0,
> delivery-tag=b"\x00", message-format=0, settled=false] (7) "\x00Sw\x00S1E"
> [0x21ddf40]:0 -> @transfer(20) [handle=1, delivery-id=0,
> delivery-tag=b"\x00", message-format=0] (7) "\x00Sw\x00S1E"
> {noformat}
> (Not shown, after the above in the case being debugged, there was a
> non-transactional transfer on a second session across the same client->router
> connection, then forwarded on the same router->broker connection).
> The broker peer establishes a transaction and responds with disposition to
> indicate it is declared, and providing the mandatory txn-id. The router
> relays this disposition, but critically drops the txn-id from the delivery
> state:
> {noformat}
> [0x21ddf40]:0 <- @disposition(21) [role=true, first=0, last=0, settled=true,
> state=@declared(51) [txn-id=b"4a12a39a-09fe-11ea-91ae-000c29e9f622"]]
> [0x2251560]:1 -> @disposition(21) [role=true, first=0, settled=true,
> state=@declared(51) null]
> {noformat}
> The recipient client then barfs at this point since txn-id is mandatory for
> the declared state.
> Using 1.8.0, the declared state transited the router fine:
> {noformat}
> [0x1f49530]:0 <- @disposition(21) [role=true, first=0, last=0, settled=true,
> state=@declared(51) [txn-id=b"78dabc4f-0a00-11ea-bb46-000c29e9f622"]]
> [0x1fc2b20]:2 -> @disposition(21) [role=true, first=0, settled=true,
> state=@declared(51) [txn-id=b"78dabc4f-0a00-11ea-bb46-000c29e9f622"]]
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] kgiusti opened a new pull request #638: DISPATCH-1488: add test to verify transanction handling
kgiusti opened a new pull request #638: DISPATCH-1488: add test to verify transanction handling URL: https://github.com/apache/qpid-dispatch/pull/638 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1358) Port console to patternfly 4 / React
[ https://issues.apache.org/jira/browse/DISPATCH-1358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16986924#comment-16986924 ] ASF subversion and git services commented on DISPATCH-1358: --- Commit 0f8ee090b41c6ed9c31aee54fafdc23c690cb30c in qpid-dispatch's branch refs/heads/master from Ernest Allen [ https://gitbox.apache.org/repos/asf?p=qpid-dispatch.git;h=0f8ee09 ] DISPATCH-1358 Change link color per request from UXG > Port console to patternfly 4 / React > > > Key: DISPATCH-1358 > URL: https://issues.apache.org/jira/browse/DISPATCH-1358 > Project: Qpid Dispatch > Issue Type: Improvement > Components: Console >Reporter: Ernest Allen >Assignee: Ernest Allen >Priority: Major > > Initial wireframes are at https://marvelapp.com/1fhc8a26/screen/57601872 -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Resolved] (PROTON-1801) Strip the version from the /usr/share/proton dir
[ https://issues.apache.org/jira/browse/PROTON-1801?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Ross resolved PROTON-1801. - Resolution: Done > Strip the version from the /usr/share/proton dir > > > Key: PROTON-1801 > URL: https://issues.apache.org/jira/browse/PROTON-1801 > Project: Qpid Proton > Issue Type: Task > Components: proton-c >Reporter: Justin Ross >Assignee: Justin Ross >Priority: Major > Fix For: proton-c-0.30.0 > > > It's contrary to the dominant convention, and it litters /usr/share with old > dirs. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Updated] (PROTON-1801) Strip the version from the /usr/share/proton dir
[ https://issues.apache.org/jira/browse/PROTON-1801?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Ross updated PROTON-1801: Fix Version/s: proton-c-0.30.0 > Strip the version from the /usr/share/proton dir > > > Key: PROTON-1801 > URL: https://issues.apache.org/jira/browse/PROTON-1801 > Project: Qpid Proton > Issue Type: Task > Components: proton-c >Reporter: Justin Ross >Assignee: Justin Ross >Priority: Major > Fix For: proton-c-0.30.0 > > > It's contrary to the dominant convention, and it litters /usr/share with old > dirs. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (PROTON-1801) Strip the version from the /usr/share/proton dir
[ https://issues.apache.org/jira/browse/PROTON-1801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16986909#comment-16986909 ] ASF subversion and git services commented on PROTON-1801: - Commit 5b6f10243db63c05bb0ab2f0f12a0390a98874a4 in qpid-proton's branch refs/heads/master from Justin Ross [ https://gitbox.apache.org/repos/asf?p=qpid-proton.git;h=5b6f102 ] PROTON-1801: Strip the version from the /usr/share/proton dir > Strip the version from the /usr/share/proton dir > > > Key: PROTON-1801 > URL: https://issues.apache.org/jira/browse/PROTON-1801 > Project: Qpid Proton > Issue Type: Task > Components: proton-c >Reporter: Justin Ross >Assignee: Justin Ross >Priority: Major > > It's contrary to the dominant convention, and it litters /usr/share with old > dirs. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (PROTON-1801) Strip the version from the /usr/share/proton dir
[ https://issues.apache.org/jira/browse/PROTON-1801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16986910#comment-16986910 ] ASF GitHub Bot commented on PROTON-1801: asfgit commented on pull request #222: PROTON-1801: Strip the version from the /usr/share/proton dir URL: https://github.com/apache/qpid-proton/pull/222 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Strip the version from the /usr/share/proton dir > > > Key: PROTON-1801 > URL: https://issues.apache.org/jira/browse/PROTON-1801 > Project: Qpid Proton > Issue Type: Task > Components: proton-c >Reporter: Justin Ross >Assignee: Justin Ross >Priority: Major > > It's contrary to the dominant convention, and it litters /usr/share with old > dirs. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-proton] asfgit merged pull request #222: PROTON-1801: Strip the version from the /usr/share/proton dir
asfgit merged pull request #222: PROTON-1801: Strip the version from the /usr/share/proton dir URL: https://github.com/apache/qpid-proton/pull/222 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
