[GitHub] qpid pull request: QPID-6213: fix queue cleaner connection timeout...

2015-05-07 Thread ChugR
Github user ChugR closed the pull request at: https://github.com/apache/qpid/pull/4 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled

[GitHub] qpid-dispatch pull request: DISPATCH-163 - Added username and pass...

2015-10-16 Thread ChugR
Github user ChugR commented on the pull request: https://github.com/apache/qpid-dispatch/pull/19#issuecomment-148835284 How do we manage these credentials internally? Or when viewed through the management interface? Will 'qdmanage query' show the credentials in plain text

[GitHub] qpid-dispatch pull request: DISPATCH-163 - Added username and pass...

2015-10-20 Thread ChugR
Github user ChugR commented on the pull request: https://github.com/apache/qpid-dispatch/pull/21#issuecomment-149681423 I tried this new branch and I think it's better for tests (*.py) all to end up in the /tests folder. At first the test failed. The problem was that the *.pyc

[GitHub] qpid-dispatch pull request #97: DISPATCH-468: Use computed x.509 cert displa...

2016-09-07 Thread ChugR
GitHub user ChugR opened a pull request: https://github.com/apache/qpid-dispatch/pull/97 DISPATCH-468: Use computed x.509 cert display-name as authenticated id Add a DisplayName service interface to be called from C code. During connection establishment use the translated

[GitHub] qpid-dispatch pull request #106: DISPATCH-451: Configurable settings for ses...

2016-10-04 Thread ChugR
Github user ChugR commented on a diff in the pull request: https://github.com/apache/qpid-dispatch/pull/106#discussion_r81838905 --- Diff: include/qpid/dispatch/server.h --- @@ -418,6 +418,22 @@ typedef struct qd_server_config_t { uint32_t max_frame_size

[GitHub] qpid-dispatch pull request #106: DISPATCH-451: Configurable settings for ses...

2016-10-04 Thread ChugR
Github user ChugR commented on a diff in the pull request: https://github.com/apache/qpid-dispatch/pull/106#discussion_r81838943 --- Diff: include/qpid/dispatch/server.h --- @@ -418,6 +418,22 @@ typedef struct qd_server_config_t { uint32_t max_frame_size

[GitHub] qpid-dispatch pull request #106: DISPATCH-451: Configurable settings for ses...

2016-10-04 Thread ChugR
GitHub user ChugR opened a pull request: https://github.com/apache/qpid-dispatch/pull/106 DISPATCH-451: Configurable settings for session capacity and max sessions This patch allows listener and connector settings for session capacity and for max sessions. It does _not_

[GitHub] qpid-dispatch pull request #155: Remove unreachable code.

2017-03-27 Thread ChugR
GitHub user ChugR opened a pull request: https://github.com/apache/qpid-dispatch/pull/155 Remove unreachable code. Early in this function the field is limited to indicate something in the Properties section. `assert(QD_FIELD_MESSAGE_ID <= field &

[GitHub] qpid-dispatch issue #159: Metrics support

2017-04-06 Thread ChugR
Github user ChugR commented on the issue: https://github.com/apache/qpid-dispatch/pull/159 This patch adds a competing statistic for one that already exists. Going forward it would require a completely redundant set and every statistic would be counted twice. That's not desirable

[GitHub] qpid-dispatch pull request #175: DISPATCH-759: Move freeing message and iter...

2017-07-08 Thread ChugR
GitHub user ChugR opened a pull request: https://github.com/apache/qpid-dispatch/pull/175 DISPATCH-759: Move freeing message and iterator out of core thread Some of delivery deletion requires core context and that part stays. You can merge this pull request into a Git repository

[GitHub] qpid-dispatch pull request #171: DISPATCH-760: Message annotation handling i...

2017-07-07 Thread ChugR
Github user ChugR closed the pull request at: https://github.com/apache/qpid-dispatch/pull/171 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] qpid-dispatch pull request #173: DISPATCH-760: Message annotation handling i...

2017-07-07 Thread ChugR
GitHub user ChugR opened a pull request: https://github.com/apache/qpid-dispatch/pull/173 DISPATCH-760: Message annotation handling improvements This PR replaces existing annotation handling with a more efficient version. It is fully compatible with 0.8.x. It contains the same

[GitHub] qpid-dispatch pull request #177: DISPATCH-767 - Added code to support multi ...

2017-07-25 Thread ChugR
Github user ChugR commented on a diff in the pull request: https://github.com/apache/qpid-dispatch/pull/177#discussion_r129308722 --- Diff: src/message.c --- @@ -999,11 +1014,84 @@ void qd_message_set_ingress_annotation(qd_message_t *in_msg, qd_composed_field_t

[GitHub] qpid-dispatch pull request #177: DISPATCH-767 - Added code to support multi ...

2017-07-25 Thread ChugR
Github user ChugR commented on a diff in the pull request: https://github.com/apache/qpid-dispatch/pull/177#discussion_r129318215 --- Diff: src/message_private.h --- @@ -107,11 +106,21 @@ typedef struct { qd_parsed_field_t *ma_pf_to_override; qd_parsed_field_t

[GitHub] qpid-dispatch pull request #177: DISPATCH-767 - Added code to support multi ...

2017-07-25 Thread ChugR
Github user ChugR commented on a diff in the pull request: https://github.com/apache/qpid-dispatch/pull/177#discussion_r129306967 --- Diff: src/buffer.c --- @@ -83,7 +85,26 @@ size_t qd_buffer_size(qd_buffer_t *buf) void qd_buffer_insert(qd_buffer_t *buf, size_t len

[GitHub] qpid-dispatch pull request #177: DISPATCH-767 - Added code to support multi ...

2017-07-25 Thread ChugR
Github user ChugR commented on a diff in the pull request: https://github.com/apache/qpid-dispatch/pull/177#discussion_r129305989 --- Diff: src/message.c --- @@ -846,6 +853,8 @@ qd_message_t *qd_message() } ZERO(msg->content); +msg->c

[GitHub] qpid-dispatch pull request #177: DISPATCH-767 - Added code to support multi ...

2017-07-25 Thread ChugR
Github user ChugR commented on a diff in the pull request: https://github.com/apache/qpid-dispatch/pull/177#discussion_r129307766 --- Diff: src/message.c --- @@ -999,11 +1014,84 @@ void qd_message_set_ingress_annotation(qd_message_t *in_msg, qd_composed_field_t

[GitHub] qpid-dispatch pull request #177: DISPATCH-767 - Added code to support multi ...

2017-07-25 Thread ChugR
Github user ChugR commented on a diff in the pull request: https://github.com/apache/qpid-dispatch/pull/177#discussion_r129306348 --- Diff: include/qpid/dispatch/message.h --- @@ -296,6 +296,61 @@ qd_parsed_field_t *qd_message_get_trace (qd_message_t *msg); */ int

[GitHub] qpid-dispatch pull request #171: DISPATCH-760: Message annotation handling i...

2017-07-04 Thread ChugR
GitHub user ChugR opened a pull request: https://github.com/apache/qpid-dispatch/pull/171 DISPATCH-760: Message annotation handling improvements This PR replaces existing annotation handling with a more efficient version. It is fully compatible with 0.8.x. A comparison

[GitHub] qpid-dispatch issue #168: crolke dev annotations - work in progress PR for r...

2017-06-28 Thread ChugR
Github user ChugR commented on the issue: https://github.com/apache/qpid-dispatch/pull/168 The straight new V2 method offers about a 35% message rate improvement over the existing method that shipped in 0.8.x. However, the new way of doing the original method offers a 25% improvement

[GitHub] qpid-dispatch pull request #168: crolke dev annotations - work in progress P...

2017-06-28 Thread ChugR
Github user ChugR closed the pull request at: https://github.com/apache/qpid-dispatch/pull/168 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] qpid-dispatch issue #168: crolke dev annotations - work in progress PR for r...

2017-06-21 Thread ChugR
Github user ChugR commented on the issue: https://github.com/apache/qpid-dispatch/pull/168 Well spotted. That's a mistake from a failed merge conflict. Will fix. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] qpid-dispatch pull request #168: crolke dev annotations - work in progress P...

2017-06-20 Thread ChugR
GitHub user ChugR opened a pull request: https://github.com/apache/qpid-dispatch/pull/168 crolke dev annotations - work in progress PR for review **DO NOT COMMIT THIS PULL REQUEST** It is for review only. This work adds a new annotation scheme for inter-router annotations

[GitHub] qpid-dispatch pull request #194: DISPATCH-825: Fix interlocking between mess...

2017-09-13 Thread ChugR
GitHub user ChugR opened a pull request: https://github.com/apache/qpid-dispatch/pull/194 DISPATCH-825: Fix interlocking between message send and receive Don't allow a buffer on the message buffer chain that might be removed. Use a content-based pending buffer instead. Don't

[GitHub] qpid-dispatch pull request #196: DISPATCH-807: Message handling requires flo...

2017-09-15 Thread ChugR
GitHub user ChugR opened a pull request: https://github.com/apache/qpid-dispatch/pull/196 DISPATCH-807: Message handling requires flow control to limit memory consumption You can merge this pull request into a Git repository by running: $ git pull https://github.com/ChugR

[GitHub] qpid-dispatch pull request #194: DISPATCH-825: Fix interlocking between mess...

2017-09-13 Thread ChugR
Github user ChugR commented on a diff in the pull request: https://github.com/apache/qpid-dispatch/pull/194#discussion_r138710888 --- Diff: src/message.c --- @@ -1109,95 +1146,97 @@ qd_message_t *qd_message_receive(pn_delivery_t *delivery

[GitHub] qpid-dispatch issue #196: DISPATCH-807: Message handling requires flow contr...

2017-09-15 Thread ChugR
Github user ChugR commented on the issue: https://github.com/apache/qpid-dispatch/pull/196 Merged through another branch --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail

[GitHub] qpid-dispatch pull request #196: DISPATCH-807: Message handling requires flo...

2017-09-15 Thread ChugR
Github user ChugR closed the pull request at: https://github.com/apache/qpid-dispatch/pull/196 --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-dispatch pull request #205: Dispatch 829 - reference only, do not pull ...

2017-10-17 Thread ChugR
Github user ChugR closed the pull request at: https://github.com/apache/qpid-dispatch/pull/205 --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-dispatch pull request #208: Dispatch 829 3

2017-10-17 Thread ChugR
Github user ChugR closed the pull request at: https://github.com/apache/qpid-dispatch/pull/208 --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-dispatch pull request #208: Dispatch 829 3

2017-10-09 Thread ChugR
GitHub user ChugR opened a pull request: https://github.com/apache/qpid-dispatch/pull/208 Dispatch 829 3 This adds to Ganesh's changes in PR #206 You can merge this pull request into a Git repository by running: $ git pull https://github.com/ChugR/qpid-dispatch DISPATCH-829-3

[GitHub] qpid-dispatch pull request #205: Dispatch 829 - reference only, do not pull ...

2017-10-04 Thread ChugR
GitHub user ChugR opened a pull request: https://github.com/apache/qpid-dispatch/pull/205 Dispatch 829 - reference only, do not pull this code Test setup: * Proton master branch as of today. * Dispatch conf: # Router to run qpid-interop-test router

[GitHub] qpid-dispatch pull request #211: A pull request with Ganesh's, Chuck's, and ...

2017-10-18 Thread ChugR
Github user ChugR commented on a diff in the pull request: https://github.com/apache/qpid-dispatch/pull/211#discussion_r145424345 --- Diff: src/message_private.h --- @@ -113,6 +113,7 @@ typedef struct { bool receive_complete; // true

[GitHub] qpid-dispatch pull request #304: Dispatch 990 Use patterns for policy vhost ...

2018-05-15 Thread ChugR
GitHub user ChugR opened a pull request: https://github.com/apache/qpid-dispatch/pull/304 Dispatch 990 Use patterns for policy vhost hostnames This adds all the code (schema, management, run time) and supporting self tests and old style doc. This does not add anything to doc

[GitHub] qpid-dispatch issue #305: Dispatch 965 - Port to Python 3.x

2018-05-18 Thread ChugR
Github user ChugR commented on the issue: https://github.com/apache/qpid-dispatch/pull/305 I ran this branch OK on two systems: * Fedora 27, Python 2.7 * Fedora 28, Python 3.6 The F27 system is my development laptop. It has python 2.6, 2.7, 3.3, 3.4, 3.4m, 3.5

[GitHub] qpid-dispatch issue #324: DISPATCH-976 - Fixed issue with policy validation ...

2018-06-13 Thread ChugR
Github user ChugR commented on the issue: https://github.com/apache/qpid-dispatch/pull/324 Looking at it again I think all three of these need_check_* booleans are suspect. Don't delete just the one, get rid of them all

[GitHub] qpid-dispatch pull request #311: Dispatch 1011- Policy username substition f...

2018-06-01 Thread ChugR
GitHub user ChugR opened a pull request: https://github.com/apache/qpid-dispatch/pull/311 Dispatch 1011- Policy username substition failures; Coverity issues ## Problem statement * The defect is described in [DISPATCH-1011](https://issues.apache.org/jira/browse/DISPATCH-1011

[GitHub] qpid-dispatch issue #309: DISPATCH-1013 - Enable vhost policies to be define...

2018-05-31 Thread ChugR
Github user ChugR commented on the issue: https://github.com/apache/qpid-dispatch/pull/309 This is great. Ship it! An addition to consider for the future: policy supports a _policyDir_ wherein all .json files are read for policy. This could be expanded to include .conf files

[GitHub] qpid-dispatch issue #334: Dispatch 1046 - fix policy handling in python3 env...

2018-06-27 Thread ChugR
Github user ChugR commented on the issue: https://github.com/apache/qpid-dispatch/pull/334 This patch fixes the c_char_p in py3 and improves interfaces with some const additions. The patch also repairs some incorrect handling of policy's parse tree. It looks like there were

[GitHub] qpid-proton issue #132: PROTON-1728: WIP: Reorganize the source tree and rem...

2018-01-11 Thread ChugR
Github user ChugR commented on the issue: https://github.com/apache/qpid-proton/pull/132 * This seems like a great improvement overall. It's easier to find stuff without needing the folklore to locate it. * The presentation of the source tree gives the project a mature look

[GitHub] qpid-dispatch pull request #251: DISPATCH-920: Selftest exposing the issue

2018-01-29 Thread ChugR
GitHub user ChugR opened a pull request: https://github.com/apache/qpid-dispatch/pull/251 DISPATCH-920: Selftest exposing the issue You can merge this pull request into a Git repository by running: $ git pull https://github.com/ChugR/qpid-dispatch crolke-DISPATCH-920

[GitHub] qpid-dispatch pull request #255: DISPATCH-333: Create new router policies do...

2018-02-20 Thread ChugR
Github user ChugR commented on a diff in the pull request: https://github.com/apache/qpid-dispatch/pull/255#discussion_r169471170 --- Diff: doc/new-book/configuration-security.adoc --- @@ -412,3 +414,385 @@ listener { For more information about these attributes, see

[GitHub] qpid-dispatch issue #262: Crolke 918 vhost hostname

2018-02-26 Thread ChugR
Github user ChugR commented on the issue: https://github.com/apache/qpid-dispatch/pull/262 This PR adds vhost attribute 'hostname' as the name of the entity. It deprecates vhost attribute 'id'. Policy code warns if 'id' is used and fails if neither 'id' nor 'hostname

[GitHub] qpid-dispatch pull request #262: Crolke 918 vhost hostname

2018-02-26 Thread ChugR
GitHub user ChugR opened a pull request: https://github.com/apache/qpid-dispatch/pull/262 Crolke 918 vhost hostname You can merge this pull request into a Git repository by running: $ git pull https://github.com/ChugR/qpid-dispatch crolke-918-vhost-hostname Alternatively you

[GitHub] qpid-dispatch pull request #355: DISPATCH-1098: Adjust name of unit2 executa...

2018-08-09 Thread ChugR
GitHub user ChugR opened a pull request: https://github.com/apache/qpid-dispatch/pull/355 DISPATCH-1098: Adjust name of unit2 executable for python3 CMake chooses between 'python' and 'python3'. Make a similar choice for 'unit2' and 'unit2-3'. This lets both python2

[GitHub] qpid-dispatch pull request #340: Dispatch-1055: Router fails to propagage cr...

2018-07-09 Thread ChugR
GitHub user ChugR opened a pull request: https://github.com/apache/qpid-dispatch/pull/340 Dispatch-1055: Router fails to propagage credit on link router after drain cycle In this PR the "fix" is all in transfer.c. * The router was not accounting for transfers

[GitHub] qpid-dispatch pull request #342: DISPATCH-1067 - Improvements and updates to...

2018-07-13 Thread ChugR
Github user ChugR commented on a diff in the pull request: https://github.com/apache/qpid-dispatch/pull/342#discussion_r202473609 --- Diff: docs/books/user-guide/configuration-security.adoc --- @@ -417,290 +417,367 @@ For more information about these attributes, see xref:adding

[GitHub] qpid-dispatch pull request #342: DISPATCH-1067 - Improvements and updates to...

2018-07-13 Thread ChugR
Github user ChugR commented on a diff in the pull request: https://github.com/apache/qpid-dispatch/pull/342#discussion_r202473464 --- Diff: docs/books/user-guide/configuration-security.adoc --- @@ -417,290 +417,367 @@ For more information about these attributes, see xref:adding

[GitHub] qpid-dispatch pull request #342: DISPATCH-1067 - Improvements and updates to...

2018-07-13 Thread ChugR
Github user ChugR commented on a diff in the pull request: https://github.com/apache/qpid-dispatch/pull/342#discussion_r202471950 --- Diff: docs/books/user-guide/configuration-security.adoc --- @@ -417,290 +417,367 @@ For more information about these attributes, see xref:adding

[GitHub] qpid-dispatch pull request #262: Crolke 918 vhost hostname

2018-02-27 Thread ChugR
Github user ChugR commented on a diff in the pull request: https://github.com/apache/qpid-dispatch/pull/262#discussion_r170987746 --- Diff: console/config/schema.json --- @@ -1273,6 +1273,10 @@ "type": "map", "descriptio

[GitHub] qpid-dispatch pull request #271: DISPATCH-945: Prevent crash at shutdown whe...

2018-03-21 Thread ChugR
GitHub user ChugR opened a pull request: https://github.com/apache/qpid-dispatch/pull/271 DISPATCH-945: Prevent crash at shutdown when websocket client connected Execute qd_http_server_free before the server is shut down so that lws vhost and context destruction activity

[GitHub] qpid-dispatch issue #265: DISPATCH-937 - Introduce the validate flag at the ...

2018-03-22 Thread ChugR
Github user ChugR commented on the issue: https://github.com/apache/qpid-dispatch/pull/265 +1 Ship it --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h

[GitHub] qpid-dispatch pull request #255: DISPATCH-333: Create new router policies do...

2018-03-02 Thread ChugR
Github user ChugR commented on a diff in the pull request: https://github.com/apache/qpid-dispatch/pull/255#discussion_r171883800 --- Diff: doc/new-book/configuration-security.adoc --- @@ -412,3 +414,356 @@ listener { For more information about these attributes, see

[GitHub] qpid-dispatch pull request #261: DISPATCH-918 - Initial modifications to Pyt...

2018-02-26 Thread ChugR
Github user ChugR commented on a diff in the pull request: https://github.com/apache/qpid-dispatch/pull/261#discussion_r170614842 --- Diff: tests/system_tests_autolinks.py --- @@ -53,17 +53,18 @@ def setUpClass(cls): # # Create a pair of default

[GitHub] qpid-dispatch issue #262: Crolke 918 vhost hostname

2018-02-28 Thread ChugR
Github user ChugR commented on the issue: https://github.com/apache/qpid-dispatch/pull/262 Close this PR and create a new one using @ganeshmurthy deprecationName --- - To unsubscribe, e-mail: dev-unsubscr

[GitHub] qpid-dispatch pull request #262: Crolke 918 vhost hostname

2018-02-28 Thread ChugR
Github user ChugR closed the pull request at: https://github.com/apache/qpid-dispatch/pull/262 --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-dispatch pull request #255: DISPATCH-333: Create new router policies do...

2018-03-02 Thread ChugR
Github user ChugR commented on a diff in the pull request: https://github.com/apache/qpid-dispatch/pull/255#discussion_r171881914 --- Diff: doc/new-book/configuration-security.adoc --- @@ -412,3 +414,356 @@ listener { For more information about these attributes, see

[GitHub] qpid-dispatch pull request #262: Crolke 918 vhost hostname

2018-02-27 Thread ChugR
Github user ChugR commented on a diff in the pull request: https://github.com/apache/qpid-dispatch/pull/262#discussion_r171073403 --- Diff: console/config/schema.json --- @@ -1273,6 +1273,10 @@ "type": "map", "descriptio

[GitHub] qpid-dispatch issue #420: DISPATCH-1177 - Added new option -e to qdstat. Thi...

2018-11-15 Thread ChugR
Github user ChugR commented on the issue: https://github.com/apache/qpid-dispatch/pull/420 If I have a network of interior routers, each with some edge routers, I can qdstat -e each OK. But if I add -r some-other-router and the other router is on another host them qdstat fails

[GitHub] qpid-dispatch issue #420: DISPATCH-1177 - Added new option -e to qdstat. Thi...

2018-11-15 Thread ChugR
Github user ChugR commented on the issue: https://github.com/apache/qpid-dispatch/pull/420 The problem was router INTC was running master branch code and did not have this PR's changes. With both routers running DISPATCH-1177-1@0e4cd the command works ok. This PR could

[GitHub] qpid-dispatch pull request #421: Import crolke's adverbl project

2018-11-13 Thread ChugR
GitHub user ChugR opened a pull request: https://github.com/apache/qpid-dispatch/pull/421 Import crolke's adverbl project Scraper is a data scraping program. It reads qpid-dispatch router log files, categorizes and sorts the data, and produces an HTML summary. You can merge

[GitHub] qpid-proton pull request #158: PROTON-1937: Use value.type() to check for va...

2018-09-21 Thread ChugR
GitHub user ChugR opened a pull request: https://github.com/apache/qpid-proton/pull/158 PROTON-1937: Use value.type() to check for value presence or absence This works for me on Fedroa 27 and 28 You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] qpid-dispatch issue #384: DISPATCH-1096 - priority sheaf cleanup bug

2018-09-26 Thread ChugR
Github user ChugR commented on the issue: https://github.com/apache/qpid-dispatch/pull/384 This patch clears up the too-many-links for sheaf error and improves my router network stability. FOr this I approve the patch. But in tests before and after this patch my throughput

[GitHub] qpid-dispatch issue #383: DISPATCH-1129 - Moved call to forwarding multicast...

2018-09-25 Thread ChugR
Github user ChugR commented on the issue: https://github.com/apache/qpid-dispatch/pull/383 +1 Ship It Looks good and works. Failing tests could never get beyond a few hundred messages. With this patch I'm past 100 million messages