[jira] [Commented] (DISPATCH-738) Several test failures on Solaris x86

[Adel Boutros (Jira)]

[ 
https://issues.apache.org/jira/browse/DISPATCH-738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17453382#comment-17453382
 ] 

Adel Boutros commented on DISPATCH-738:
---

Hello Jiri,

I actually left the company which was using QPID. However, I don't think they 
still use Solaris but I cannot be sure

> Several test failures on Solaris x86
> 
>
> Key: DISPATCH-738
> URL: https://issues.apache.org/jira/browse/DISPATCH-738
> Project: Qpid Dispatch
>  Issue Type: Bug
>  Components: Tests
>Affects Versions: 0.7.0
>Reporter: Ganesh Murthy
>Priority: Major
> Fix For: Backlog
>
>
> {noformat}
> -- The C compiler identification is SunPro 5.10.0
> -- Check for working C compiler: /usr/bin/cc
> -- Check for working C compiler: /usr/bin/cc -- works
> -- Detecting C compiler ABI info
> -- Detecting C compiler ABI info - done
> -- Found PythonInterp: /python278/bin/python (found version "2.7.8") 
> -- Found PythonLibs: /python278/lib/libpython2.7.so (found version "2.7.8") 
> -- Found Proton: 
> /qpid-dispatch-router/dispatch-workspace/build-dir/qpid-proton/dist/release/lib64/libqpid-proton.so
>   
> -- Could NOT find LIBWEBSOCKETS (missing:  LIBWEBSOCKETS_LIBRARIES 
> LIBWEBSOCKETS_INCLUDE_DIRS) 
> -- Could NOT find VALGRIND (missing:  VALGRIND_EXECUTABLE) 
> -- asciidoc not found: not generating HTML, man pages or PDF
> -- Configuring done
> -- Generating done
> -- Build files have been written to: 
> /qpid-dispatch-router/dispatch-workspace/build-dir/qpid-dispatch
> [  1%] Generating schema_enum.h, schema_enum.c
> Scanning dependencies of target qpid-dispatch
> [  2%] Building C object src/CMakeFiles/qpid-dispatch.dir/amqp.c.o
> [  4%] Building C object src/CMakeFiles/qpid-dispatch.dir/bitmask.c.o
> [  5%] Building C object src/CMakeFiles/qpid-dispatch.dir/buffer.c.o
> [  6%] Building C object src/CMakeFiles/qpid-dispatch.dir/error.c.o
> [  8%] Building C object src/CMakeFiles/qpid-dispatch.dir/compose.c.o
> [  9%] Building C object 
> src/CMakeFiles/qpid-dispatch.dir/connection_manager.c.o
> [ 11%] Building C object src/CMakeFiles/qpid-dispatch.dir/container.c.o
> [ 12%] Building C object src/CMakeFiles/qpid-dispatch.dir/dispatch.c.o
> [ 13%] Building C object src/CMakeFiles/qpid-dispatch.dir/entity.c.o
> [ 15%] Building C object src/CMakeFiles/qpid-dispatch.dir/entity_cache.c.o
> [ 16%] Building C object src/CMakeFiles/qpid-dispatch.dir/failoverlist.c.o
> [ 18%] Building C object src/CMakeFiles/qpid-dispatch.dir/hash.c.o
> [ 19%] Building C object src/CMakeFiles/qpid-dispatch.dir/iovec.c.o
> [ 20%] Building C object src/CMakeFiles/qpid-dispatch.dir/iterator.c.o
> [ 22%] Building C object src/CMakeFiles/qpid-dispatch.dir/log.c.o
> [ 23%] Building C object src/CMakeFiles/qpid-dispatch.dir/message.c.o
> [ 25%] Building C object src/CMakeFiles/qpid-dispatch.dir/parse.c.o
> [ 26%] Building C object src/CMakeFiles/qpid-dispatch.dir/policy.c.o
> [ 27%] Building C object src/CMakeFiles/qpid-dispatch.dir/posix/driver.c.o
> [ 29%] Building C object src/CMakeFiles/qpid-dispatch.dir/posix/threading.c.o
> [ 30%] Building C object src/CMakeFiles/qpid-dispatch.dir/python_embedded.c.o
> [ 31%] Building C object src/CMakeFiles/qpid-dispatch.dir/router_agent.c.o
> [ 33%] Building C object src/CMakeFiles/qpid-dispatch.dir/router_config.c.o
> [ 34%] Building C object 
> src/CMakeFiles/qpid-dispatch.dir/router_core/agent.c.o
> [ 36%] Building C object 
> src/CMakeFiles/qpid-dispatch.dir/router_core/agent_address.c.o
> [ 37%] Building C object 
> src/CMakeFiles/qpid-dispatch.dir/router_core/agent_config_address.c.o
> [ 38%] Building C object 
> src/CMakeFiles/qpid-dispatch.dir/router_core/agent_config_auto_link.c.o
> [ 40%] Building C object 
> src/CMakeFiles/qpid-dispatch.dir/router_core/agent_connection.c.o
> [ 41%] Building C object 
> src/CMakeFiles/qpid-dispatch.dir/router_core/agent_config_link_route.c.o
> [ 43%] Building C object 
> src/CMakeFiles/qpid-dispatch.dir/router_core/agent_link.c.o
> [ 44%] Building C object 
> src/CMakeFiles/qpid-dispatch.dir/router_core/agent_router.c.o
> [ 45%] Building C object 
> src/CMakeFiles/qpid-dispatch.dir/router_core/connections.c.o
> [ 47%] Building C object 
> src/CMakeFiles/qpid-dispatch.dir/router_core/error.c.o
> [ 48%] Building C object 
> src/CMakeFiles/qpid-dispatch.dir/router_core/forwarder.c.o
> [ 50%] Building C object 
> src/CMakeFiles/qpid-dispatch.dir/router_core/route_control.c.o
> [ 51%] Building C object 
> src/CMakeFiles/qpid-dispatch.dir/router_core/router_core.c.o
> [ 52%] Building C object 

[GitHub] qpid-broker-j issue #4: QPID-7972: [Broker-J] Put VirtualHostNode in ERRORed...

[adel-boutros]

Github user adel-boutros commented on the issue:

https://github.com/apache/qpid-broker-j/pull/4
  
Hello Olivier,

It seems you are mixing in your pull request 2 different issues: One 
related to the Error state of the virtualHost and the other one about problems 
with different locales (I assume tests are failing on your machine because it 
is configured with the FR locale).

In my opinion, it is better to split those into 2 different pull requests 
to have a better context


---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (QPID-7910) [Java Broker] Improve qpid.stop script

[Adel Boutros (JIRA)]

[ 
https://issues.apache.org/jira/browse/QPID-7910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16210856#comment-16210856
 ] 

Adel Boutros commented on QPID-7910:


Sounds reasonable to me :)

> [Java Broker] Improve qpid.stop script
> --
>
> Key: QPID-7910
> URL: https://issues.apache.org/jira/browse/QPID-7910
> Project: Qpid
>  Issue Type: Improvement
>  Components: Java Broker
>Reporter: Alex Rudyy
>Priority: Minor
> Fix For: qpid-java-broker-7.0.0
>
> Attachments: qpid-stop
>
>
> Java Broker qpid.stop  needs improvements:
> * it  currently tries to send SIGTERM and SIGKILL commands twice. It is 
> superfluous. Sending event once should be sufficient. 
> * we can use {{kill -0}} to verify the process instead of using ps
> * make {{$SLEEP_DELAY}} overridable from command line
> * script should be able to wait until Qpid processes are killed before exiting



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (QPID-7910) [Java Broker] Improve qpid.stop script

[Adel Boutros (JIRA)]

[ 
https://issues.apache.org/jira/browse/QPID-7910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16210784#comment-16210784
 ] 

Adel Boutros commented on QPID-7910:


Thanks [~alex.rufous],
I have some questions, remarks:
# Shouldn't we limit the stop to the current user's processes? (What would 
happen if he tries to kill a broker which he cannot kill due to lack of 
permissions?)
# I don't think we need to distinguish between single process or multiple ones 
(lines 31 and 32 can be grouped with the one on line 34)
# Can you please refactor the duplicated "org.apache.qpid.server.Main" and 
store it in a variable?
# If kill never succeeds in killing the broker, the script will be looping 
indefinitely. Is this the expected behavior?

Regards,
Adel

> [Java Broker] Improve qpid.stop script
> --
>
> Key: QPID-7910
> URL: https://issues.apache.org/jira/browse/QPID-7910
> Project: Qpid
>  Issue Type: Improvement
>  Components: Java Broker
>Reporter: Alex Rudyy
>Priority: Minor
> Fix For: qpid-java-broker-7.0.0
>
> Attachments: qpid-stop
>
>
> Java Broker qpid.stop  needs improvements:
> * it  currently tries to send SIGTERM and SIGKILL commands twice. It is 
> superfluous. Sending event once should be sufficient. 
> * we can use {{kill -0}} to verify the process instead of using ps
> * make {{$SLEEP_DELAY}} overridable from command line
> * script should be able to wait until Qpid processes are killed before exiting



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Comment Edited] (QPID-7973) Table Name Prefix is set to NULL if no prefix is provided instead of empty String

[Adel Boutros (JIRA)]

[ 
https://issues.apache.org/jira/browse/QPID-7973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16209428#comment-16209428
 ] 

Adel Boutros edited comment on QPID-7973 at 10/18/17 2:36 PM:
--

Hello [~k-wall],

When I did the fix on [QPID-7974| 
https://issues.apache.org/jira/browse/QPID-7974]. Some unit tests failed. When 
I looked, the testing were appending "null" to the table names. This was 
because setTableNamePrefix was being called with a null tablePrefix and as all 
tables have "tablePrefix + TableName".

Test failing: 
org.apache.qpid.server.store.jdbc.GenericJDBCConfigurationStoreTest

Error (See how table name contains NULL): Caused by: java.sql.SQLException: 
Table/View 'NULLQPID_CONFIGURED_OBJECTS' already exists in Schema 'APP'.


was (Author: adelbout...@live.com):
Hello [~k-wall],

When I did the fix on [QPID-7974| 
https://issues.apache.org/jira/browse/QPID-7974]. Some unit tests failed. When 
I looked, the testing were appending "null" to the table names. This was 
because setTableNamePrefix was being called with a null tablePrefix and as all 
tables have "tablePrefix + TableName".

Test failing: 
org.apache.qpid.server.store.jdbc.GenericJDBCConfigurationStoreTest

Error (See how table name contains NULL: Caused by: java.sql.SQLException: 
Table/View 'NULLQPID_CONFIGURED_OBJECTS' already exists in Schema 'APP'.

> Table Name Prefix is set to NULL if no prefix is provided instead of empty 
> String
> -
>
> Key: QPID-7973
> URL: https://issues.apache.org/jira/browse/QPID-7973
> Project: Qpid
>  Issue Type: Bug
>  Components: Java Broker
>    Affects Versions: qpid-java-6.1.4
>Reporter: Adel Boutros
>Assignee: Rob Godfrey
> Fix For: qpid-java-broker-7.0.0
>
>
> If the user provides no TableNamePrefix, then it is set to null whereas it 
> should be set to empty string



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (QPID-7973) Table Name Prefix is set to NULL if no prefix is provided instead of empty String

[Adel Boutros (JIRA)]

[ 
https://issues.apache.org/jira/browse/QPID-7973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16209428#comment-16209428
 ] 

Adel Boutros commented on QPID-7973:


Hello [~k-wall],

When I did the fix on [QPID-7974| 
https://issues.apache.org/jira/browse/QPID-7974]. Some unit tests failed. When 
I looked, the testing were appending "null" to the table names. This was 
because setTableNamePrefix was being called with a null tablePrefix and as all 
tables have "tablePrefix + TableName".

Test failing: 
org.apache.qpid.server.store.jdbc.GenericJDBCConfigurationStoreTest

Error (See how table name contains NULL: Caused by: java.sql.SQLException: 
Table/View 'NULLQPID_CONFIGURED_OBJECTS' already exists in Schema 'APP'.

> Table Name Prefix is set to NULL if no prefix is provided instead of empty 
> String
> -
>
> Key: QPID-7973
> URL: https://issues.apache.org/jira/browse/QPID-7973
> Project: Qpid
>  Issue Type: Bug
>  Components: Java Broker
>Affects Versions: qpid-java-6.1.4
>Reporter: Adel Boutros
>Assignee: Rob Godfrey
> Fix For: qpid-java-broker-7.0.0
>
>
> If the user provides no TableNamePrefix, then it is set to null whereas it 
> should be set to empty string



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (QPID-7974) JdbcUtils.TableExists is very slow on big databases such as Oracle

[Adel Boutros (JIRA)]

[ 
https://issues.apache.org/jira/browse/QPID-7974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16209262#comment-16209262
 ] 

Adel Boutros commented on QPID-7974:


[~rgodfrey] Done :)

> JdbcUtils.TableExists is very slow on big databases such as Oracle
> --
>
> Key: QPID-7974
> URL: https://issues.apache.org/jira/browse/QPID-7974
> Project: Qpid
>  Issue Type: Improvement
>  Components: Java Broker
>Affects Versions: qpid-java-6.1.4
>Reporter: Adel Boutros
>
> The problem is that JdbcUtils.tableExists will actually load all tables and 
> then iterate to find the correct one. On Oracle, this can be around 40 000 
> tables. So it will take 12 minutes for the broker to start.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-broker-j pull request #3: QPID-7974: Only search for the needed table i...

[adel-boutros]

GitHub user adel-boutros opened a pull request:

https://github.com/apache/qpid-broker-j/pull/3

QPID-7974: Only search for the needed table instead of querying the w…

QPID-7974: Only search for the needed table instead of querying the whole 
database tables

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/adel-boutros/qpid-broker-j 
fix_jdbc_table_exist

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/qpid-broker-j/pull/3.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #3


commit 78c5d25c2ed79751e7456467178213a0585f1f5a
Author: aboutros <about...@murex.com>
Date:   2017-10-18T12:41:42Z

QPID-7974: Only search for the needed table instead of querying the whole 
database tables




---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-broker-j issue #1: Jdbc fixes

[adel-boutros]

Github user adel-boutros commented on the issue:

https://github.com/apache/qpid-broker-j/pull/1
  
Will separate them into 2 different PRs


---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-broker-j pull request #1: Jdbc fixes

[adel-boutros]

Github user adel-boutros closed the pull request at:

https://github.com/apache/qpid-broker-j/pull/1


---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-broker-j pull request #2: QPID-7973: Table Name Prefix is set to NULL i...

[adel-boutros]

GitHub user adel-boutros opened a pull request:

https://github.com/apache/qpid-broker-j/pull/2

QPID-7973: Table Name Prefix is set to NULL if no prefix is provided

QPID-7973: Table Name Prefix is set to NULL if no prefix is provided

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/adel-boutros/qpid-broker-j fix_table_prefix

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/qpid-broker-j/pull/2.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2


commit 216a820f9eb6b300e3dd8c30c2f8dd57698496ae
Author: aboutros <about...@murex.com>
Date:   2017-10-18T10:34:14Z

QPID-7973: Table Name Prefix is set to NULL if no prefix is provided 
instead of empty String




---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (QPID-7974) JdbcUtils.TableExists is very slow on big databases such as Oracle

[Adel Boutros (JIRA)]

[ 
https://issues.apache.org/jira/browse/QPID-7974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16209231#comment-16209231
 ] 

Adel Boutros commented on QPID-7974:


Your idea is excellent!
It is still a lot faster to do 3 simple queries than to wait for all of them.

Do you want me to do the change on the pull request?
# check all upper case
# fallback to check all lower case
# fallback to check without changing case

> JdbcUtils.TableExists is very slow on big databases such as Oracle
> --
>
> Key: QPID-7974
> URL: https://issues.apache.org/jira/browse/QPID-7974
> Project: Qpid
>  Issue Type: Improvement
>  Components: Java Broker
>Affects Versions: qpid-java-6.1.4
>Reporter: Adel Boutros
>
> The problem is that JdbcUtils.tableExists will actually load all tables and 
> then iterate to find the correct one. On Oracle, this can be around 40 000 
> tables. So it will take 12 minutes for the broker to start.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Comment Edited] (QPID-7974) JdbcUtils.TableExists is very slow on big databases such as Oracle

[Adel Boutros (JIRA)]

[ 
https://issues.apache.org/jira/browse/QPID-7974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16209210#comment-16209210
 ] 

Adel Boutros edited comment on QPID-7974 at 10/18/17 12:22 PM:
---

Hello Rob,

As it is the broker who tries to create the table, why don't we make all table 
names including the prefix forcibly in upper case? So the check will never fail.

Then if certain DB will still cause issues, we can have a special case for them.

What do you think?


was (Author: adelbout...@live.com):
Hello Rob,

What you are proposing will not fix the problem due to the fact we will always 
fallback to the existing code which is very slow.
As it is the broker who tries to create the table, why don't we make all table 
names including the prefix forcibly in upper case? So the check will never fail.

Then if certain DB will still cause issues, we can have a special case for them.

What do you think?

> JdbcUtils.TableExists is very slow on big databases such as Oracle
> --
>
> Key: QPID-7974
> URL: https://issues.apache.org/jira/browse/QPID-7974
> Project: Qpid
>  Issue Type: Improvement
>  Components: Java Broker
>Affects Versions: qpid-java-6.1.4
>Reporter: Adel Boutros
>
> The problem is that JdbcUtils.tableExists will actually load all tables and 
> then iterate to find the correct one. On Oracle, this can be around 40 000 
> tables. So it will take 12 minutes for the broker to start.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (QPID-7974) JdbcUtils.TableExists is very slow on big databases such as Oracle

[Adel Boutros (JIRA)]

[ 
https://issues.apache.org/jira/browse/QPID-7974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16209218#comment-16209218
 ] 

Adel Boutros commented on QPID-7974:


I have also in mind another minor enhancement:
We know that the tableExists is used in a single thread in the case of creating 
all the needed Qpid tables. In that case, why don't we do a single getTables 
and check in a single loop if all 6 tables exists in one shot? This way we save 
5 redundant calls to getTables.

What do you think?

> JdbcUtils.TableExists is very slow on big databases such as Oracle
> --
>
> Key: QPID-7974
> URL: https://issues.apache.org/jira/browse/QPID-7974
> Project: Qpid
>  Issue Type: Improvement
>  Components: Java Broker
>Affects Versions: qpid-java-6.1.4
>Reporter: Adel Boutros
>
> The problem is that JdbcUtils.tableExists will actually load all tables and 
> then iterate to find the correct one. On Oracle, this can be around 40 000 
> tables. So it will take 12 minutes for the broker to start.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (QPID-7974) JdbcUtils.TableExists is very slow on big databases such as Oracle

[Adel Boutros (JIRA)]

[ 
https://issues.apache.org/jira/browse/QPID-7974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16209210#comment-16209210
 ] 

Adel Boutros commented on QPID-7974:


Hello Rob,

What you are proposing will not fix the problem due to the fact we will always 
fallback to the existing code which is very slow.
As it is the broker who tries to create the table, why don't we make all table 
names including the prefix forcibly in upper case? So the check will never fail.

Then if certain DB will still cause issues, we can have a special case for them.

What do you think?

> JdbcUtils.TableExists is very slow on big databases such as Oracle
> --
>
> Key: QPID-7974
> URL: https://issues.apache.org/jira/browse/QPID-7974
> Project: Qpid
>  Issue Type: Improvement
>  Components: Java Broker
>Affects Versions: qpid-java-6.1.4
>Reporter: Adel Boutros
>
> The problem is that JdbcUtils.tableExists will actually load all tables and 
> then iterate to find the correct one. On Oracle, this can be around 40 000 
> tables. So it will take 12 minutes for the broker to start.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-broker-j pull request #1: Jdbc fixes

[adel-boutros]

GitHub user adel-boutros opened a pull request:

https://github.com/apache/qpid-broker-j/pull/1

Jdbc fixes



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/adel-boutros/qpid-broker-j jdbc_fixes

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/qpid-broker-j/pull/1.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1


commit 84afe501cdacf4d15def076f7572c00b35198170
Author: aboutros <about...@murex.com>
Date:   2017-10-18T10:34:14Z

QPID-7973 Table Name Prefix is set to NULL if no prefix is provided instead 
of empty String

commit 283b25d1831a3316039ecf3d543ae23d94ab9ad6
Author: aboutros <about...@murex.com>
Date:   2017-10-18T10:34:15Z

QPID-7974 Only search for the needed table instead of querying the whole 
database tables




---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Created] (QPID-7974) JdbcUtils.TableExists is very slow on big databases such as Oracle

[Adel Boutros (JIRA)]

Adel Boutros created QPID-7974:
--

 Summary: JdbcUtils.TableExists is very slow on big databases such 
as Oracle
 Key: QPID-7974
 URL: https://issues.apache.org/jira/browse/QPID-7974
 Project: Qpid
  Issue Type: Improvement
  Components: Java Broker
Affects Versions: qpid-java-6.1.4
Reporter: Adel Boutros


The problem is that JdbcUtils.tableExists will actually load all tables and 
then iterate to find the correct one. On Oracle, this can be around 40 000 
tables. So it will take 12 minutes for the broker to start.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Created] (QPID-7973) Table Name Prefix is set to NULL if no prefix is provided instead of empty String

[Adel Boutros (JIRA)]

Adel Boutros created QPID-7973:
--

 Summary: Table Name Prefix is set to NULL if no prefix is provided 
instead of empty String
 Key: QPID-7973
 URL: https://issues.apache.org/jira/browse/QPID-7973
 Project: Qpid
  Issue Type: Bug
  Components: Java Broker
Affects Versions: qpid-java-6.1.4
Reporter: Adel Boutros


If the user provides no TableNamePrefix, then it is set to null whereas it 
should be set to empty string



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Created] (QPID-7972) Virtual Host Node should be in error state if the underlying Virtual Host is in error state

[Adel Boutros (JIRA)]

Adel Boutros created QPID-7972:
--

 Summary: Virtual Host Node should be in error state if the 
underlying Virtual Host is in error state
 Key: QPID-7972
 URL: https://issues.apache.org/jira/browse/QPID-7972
 Project: Qpid
  Issue Type: Improvement
  Components: Java Broker
Affects Versions: qpid-java-6.1.4
Reporter: Adel Boutros


All details can be found here: 
http://qpid.2158936.n2.nabble.com/Qpid-Java-Broker-6-1-4-Broker-is-ready-even-if-an-error-is-occuring-on-startup-and-failStartupWithEre-tp7668029.html



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (DISPATCH-773) Implement a 2-phase start in the Dispatch Router

[Adel Boutros (JIRA)]

[ 
https://issues.apache.org/jira/browse/DISPATCH-773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16174925#comment-16174925
 ] 

Adel Boutros commented on DISPATCH-773:
---

Hello Ted,

* If a consumer connects and no address is configured, then a local address is 
created.
* If the address is created with Waypoint attribute, consumers and producers 
will not create local address.
If you confirm that both of my statements are true, then even for the dynamic 
addressing, we can avoid the problem by making sure addresses are created and 
configured before any consumers are attached.

Another solution I can see is to have an option which explicitly says this 
router will only use brokers for persistence. So the option would simply 
prohibit the creation of local addresses. In that case any consumer/producer 
trying to connect will receive an error ("amqp:not-found" for example). Does 
this solution map to your 2nd workaround (defaultDistribution to "unavailable") 
?

> Implement a 2-phase start in the Dispatch Router
> 
>
> Key: DISPATCH-773
> URL: https://issues.apache.org/jira/browse/DISPATCH-773
> Project: Qpid Dispatch
>  Issue Type: New Feature
>  Components: Routing Engine
>Reporter: Adel Boutros
>Assignee: Ted Ross
>
> All the needed information could be found here:
> http://qpid.2158936.n2.nabble.com/Dispatch-router-2-phase-start-td7663118.html



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (PROTON-1278) [Proton-c] Closing connection in proton::handler puts connection in TIME_WAIT state

[Adel Boutros (JIRA)]

[ 
https://issues.apache.org/jira/browse/PROTON-1278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16101706#comment-16101706
 ] 

Adel Boutros commented on PROTON-1278:
--

[~jr...@redhat.com] We have planned to update our proton version to use 0.17.0 
and try Libuv to be able to use the proactor code for event injection.
We had implemented a workaround to avoid the issue mentioned in this Jira 
issue. So I think we can safely close cancel it

> [Proton-c] Closing connection in proton::handler puts connection in TIME_WAIT 
> state
> ---
>
> Key: PROTON-1278
> URL: https://issues.apache.org/jira/browse/PROTON-1278
> Project: Qpid Proton
>  Issue Type: Bug
>  Components: cpp-binding, proton-c
>Affects Versions: 0.12.2
>    Reporter: Adel Boutros
>Assignee: Alan Conway
>  Labels: reproducer
> Fix For: proton-c-0.18.0
>
> Attachments: ConnectionTimeWaitState.cpp, Wireshark output.png
>
>
> You can check 
> [Nabble|http://qpid.2158936.n2.nabble.com/Java-Broker-6-0-1-AMQP-random-errors-when-sending-messages-using-Proton-c-0-12-2-td7648822.html]
>   for more details.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (PROTON-1321) Sunstudio 12.1 does not compile "++vector.begin()". Error message:"Operand for operator "++" must be an lvalue."

[Adel Boutros (JIRA)]

[ 
https://issues.apache.org/jira/browse/PROTON-1321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16093674#comment-16093674
 ] 

Adel Boutros commented on PROTON-1321:
--

[~jr...@redhat.com] For now yes, but we are actually moving to GCC 4.9.2 on 
Solaris. But it will still take some time to complete the move.

> Sunstudio 12.1 does not compile "++vector.begin()". Error message:"Operand 
> for operator "++" must be an lvalue."
> 
>
> Key: PROTON-1321
> URL: https://issues.apache.org/jira/browse/PROTON-1321
> Project: Qpid Proton
>  Issue Type: Improvement
>  Components: cpp-binding
>Reporter: Adel Boutros
>Assignee: Andrew Stitcher
>  Labels: patch, solaris
> Fix For: 0.18.0
>
> Attachments: 
> 0008-Sunstudio-12.1-does-not-compile-vector.begin-.-Error.patch
>
>
> Sunstudio 12.1 does not compile "++vector.begin()". 
> Error message:"Operand for operator "++" must be an lvalue.". 
> We used a local variable to bypass that.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Created] (DISPATCH-773) Implement a 2-phase start in the Dispatch Router

[Adel Boutros (JIRA)]

Adel Boutros created DISPATCH-773:
-

 Summary: Implement a 2-phase start in the Dispatch Router
 Key: DISPATCH-773
 URL: https://issues.apache.org/jira/browse/DISPATCH-773
 Project: Qpid Dispatch
  Issue Type: New Feature
  Components: Routing Engine
Reporter: Adel Boutros


All the needed information could be found here:
http://qpid.2158936.n2.nabble.com/Dispatch-router-2-phase-start-td7663118.html



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (DISPATCH-390) New pn_proactor-based IO driver

[Adel Boutros (JIRA)]

[ 
https://issues.apache.org/jira/browse/DISPATCH-390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16007064#comment-16007064
 ] 

Adel Boutros commented on DISPATCH-390:
---

Great job!! Can't wait to test it :)

> New pn_proactor-based IO driver
> ---
>
> Key: DISPATCH-390
> URL: https://issues.apache.org/jira/browse/DISPATCH-390
> Project: Qpid Dispatch
>  Issue Type: New Feature
>  Components: Container
>Affects Versions: 0.6.0
>Reporter: Alan Conway
>Assignee: Alan Conway
> Fix For: 1.0.0
>
>
> Replace the current proton IO driver with a driver based on the pn_proactor 
> API. This will allow drop-in replacement of the IO layer for different 
> platforms.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (DISPATCH-627) Implement a more systematic batch timeout test to avoid having low timeout value fail the test on slow machines

[Adel Boutros (JIRA)]

[ 
https://issues.apache.org/jira/browse/DISPATCH-627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15939134#comment-15939134
 ] 

Adel Boutros commented on DISPATCH-627:
---

I am sorry Ganesh but I had this issue some time ago so I don't remember all 
the details. However I am sure the test was failing after a couple of seconds 
not 120. It passed when I set it to around 300.
I was launching the tests on Solaris virtual machines

> Implement a more systematic batch timeout test to avoid having low timeout 
> value fail the test on slow machines
> ---
>
> Key: DISPATCH-627
> URL: https://issues.apache.org/jira/browse/DISPATCH-627
> Project: Qpid Dispatch
>  Issue Type: Improvement
>Affects Versions: 0.7.0
>Reporter: Adel Boutros
>Assignee: Ganesh Murthy
> Fix For: 0.8.0
>
> Attachments: 
> 0001-Implement-a-more-systematic-batch-timeout-test-to-av.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (DISPATCH-627) Implement a more systematic batch timeout test to avoid having low timeout value fail the test on slow machines

[Adel Boutros (JIRA)]

[ 
https://issues.apache.org/jira/browse/DISPATCH-627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15939050#comment-15939050
 ] 

Adel Boutros commented on DISPATCH-627:
---

Hello Ganesh,

If I remember correctly, it was milliseconds not seconds.
However, my patch is actually about not relying that much on timeout. It resets 
it whenever an action occurs.

> Implement a more systematic batch timeout test to avoid having low timeout 
> value fail the test on slow machines
> ---
>
> Key: DISPATCH-627
> URL: https://issues.apache.org/jira/browse/DISPATCH-627
> Project: Qpid Dispatch
>  Issue Type: Improvement
>Affects Versions: 0.7.0
>Reporter: Adel Boutros
>Assignee: Ganesh Murthy
> Fix For: 0.8.0
>
> Attachments: 
> 0001-Implement-a-more-systematic-batch-timeout-test-to-av.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Closed] (DISPATCH-289) Unit tests failing on Solaris

[Adel Boutros (JIRA)]

 [ 
https://issues.apache.org/jira/browse/DISPATCH-289?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Adel Boutros closed DISPATCH-289.
-

> Unit tests failing on Solaris
> -
>
> Key: DISPATCH-289
> URL: https://issues.apache.org/jira/browse/DISPATCH-289
> Project: Qpid Dispatch
>  Issue Type: Bug
>  Components: Tests
>Affects Versions: 0.5
>Reporter: Adel Boutros
>Assignee: Ted Ross
>  Labels: patch, solaris
> Fix For: 0.6.0
>
> Attachments: 
> Fix-issue-on-Solaris-related-to-access-modes-of-file.patch, 
> Use-connection-refused-constant-from-python-errno.patch
>
>
> Full mail thread on nabble: 
> http://qpid.2158936.n2.nabble.com/Qpid-Dispatcher-Runtime-behavior-on-SunOS-td7641941.html#a7642448
>  



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Closed] (DISPATCH-290) Adapt CMakeLists.txt and code so that qpid-dispatch can be compiled on Solaris

[Adel Boutros (JIRA)]

 [ 
https://issues.apache.org/jira/browse/DISPATCH-290?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Adel Boutros closed DISPATCH-290.
-

> Adapt CMakeLists.txt and code so that qpid-dispatch can be compiled on Solaris
> --
>
> Key: DISPATCH-290
> URL: https://issues.apache.org/jira/browse/DISPATCH-290
> Project: Qpid Dispatch
>  Issue Type: Bug
>Affects Versions: 0.5
>    Reporter: Adel Boutros
>Assignee: Ted Ross
>  Labels: build, solaris
> Fix For: 0.6.0
>
> Attachments: 
> 0001-Add-hints-on-when-using-getaddrinfo-to-have-successf.patch, 
> 0001-Fixing-cmake-files-to-compile.-Fixing-OS-related-lib.patch, 
> dispatch-290.patch
>
>
> Propose fixes so that qpid-dispatch can compile successfully on Solaris.
> - Add implicit dependencies explicitly
> - Replace linux specific options with generic options
> - Remove invalid options from CMakeLists.txt
> - Replace linux specific functions with generic functions



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-dispatch pull request #145: DISPATCH-644 - Fix daemon mode incorrectly ...

[adel-boutros]

GitHub user adel-boutros opened a pull request:

https://github.com/apache/qpid-dispatch/pull/145

DISPATCH-644 - Fix daemon mode incorrectly exiting while dispatch rou…



Signed-off-by: aboutros <adelbout...@live.com>

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/adel-boutros/qpid-dispatch-1 master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/qpid-dispatch/pull/145.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #145


commit 67bf5013fbcd16c5f5f335dfc16f442745890356
Author: aboutros <adel.bout...@murex.com>
Date:   2017-02-27T16:59:20Z

DISPATCH-644 - Fix daemon mode incorrectly exiting while dispatch router 
has started

Signed-off-by: aboutros <adel.bout...@murex.com>




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Updated] (DISPATCH-644) Fix qdrouterd generating exit code 1 because of a pipe issue in Daemon mode

[Adel Boutros (JIRA)]

 [ 
https://issues.apache.org/jira/browse/DISPATCH-644?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Adel Boutros updated DISPATCH-644:
--
Attachment: 0001-Fix-writing-to-pipe.patch

> Fix qdrouterd generating exit code 1 because of a pipe issue in Daemon mode
> ---
>
> Key: DISPATCH-644
> URL: https://issues.apache.org/jira/browse/DISPATCH-644
> Project: Qpid Dispatch
>  Issue Type: Bug
>Affects Versions: 0.7.0
>    Reporter: Adel Boutros
> Attachments: 0001-Fix-writing-to-pipe.patch
>
>
> When starting the qdrouterd in Daemon mode, the pipe is not receiving "OK". 
> So the parent process considers the child process failed to start the 
> dispatch router and exits with exit_code 1 while the router has actually 
> started correctly. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Created] (DISPATCH-644) Fix qdrouterd generating exit code 1 because of a pipe issue in Daemon mode

[Adel Boutros (JIRA)]

Adel Boutros created DISPATCH-644:
-

 Summary: Fix qdrouterd generating exit code 1 because of a pipe 
issue in Daemon mode
 Key: DISPATCH-644
 URL: https://issues.apache.org/jira/browse/DISPATCH-644
 Project: Qpid Dispatch
  Issue Type: Bug
Affects Versions: 0.7.0
Reporter: Adel Boutros
 Attachments: 0001-Fix-writing-to-pipe.patch

When starting the qdrouterd in Daemon mode, the pipe is not receiving "OK". So 
the parent process considers the child process failed to start the dispatch 
router and exits with exit_code 1 while the router has actually started 
correctly. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Updated] (DISPATCH-627) Implement a more systematic batch timeout test to avoid having low timeout value fail the test on slow machines

[Adel Boutros (JIRA)]

 [ 
https://issues.apache.org/jira/browse/DISPATCH-627?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Adel Boutros updated DISPATCH-627:
--
Attachment: 0001-Implement-a-more-systematic-batch-timeout-test-to-av.patch

> Implement a more systematic batch timeout test to avoid having low timeout 
> value fail the test on slow machines
> ---
>
> Key: DISPATCH-627
> URL: https://issues.apache.org/jira/browse/DISPATCH-627
> Project: Qpid Dispatch
>  Issue Type: Improvement
>Affects Versions: 0.7.0
>Reporter: Adel Boutros
> Attachments: 
> 0001-Implement-a-more-systematic-batch-timeout-test-to-av.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Created] (DISPATCH-627) Implement a more systematic batch timeout test to avoid having low timeout value fail the test on slow machines

[Adel Boutros (JIRA)]

Adel Boutros created DISPATCH-627:
-

 Summary: Implement a more systematic batch timeout test to avoid 
having low timeout value fail the test on slow machines
 Key: DISPATCH-627
 URL: https://issues.apache.org/jira/browse/DISPATCH-627
 Project: Qpid Dispatch
  Issue Type: Improvement
Affects Versions: 0.7.0
Reporter: Adel Boutros






--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Updated] (DISPATCH-626) Add hints for getaddrinfo on Solaris

[Adel Boutros (JIRA)]

 [ 
https://issues.apache.org/jira/browse/DISPATCH-626?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Adel Boutros updated DISPATCH-626:
--
Attachment: 0001-Add-hints-for-getaddrinfo-on-Solaris.patch

> Add hints for getaddrinfo on Solaris
> 
>
> Key: DISPATCH-626
> URL: https://issues.apache.org/jira/browse/DISPATCH-626
> Project: Qpid Dispatch
>  Issue Type: Bug
>Affects Versions: 0.7.0
>    Reporter: Adel Boutros
> Attachments: 0001-Add-hints-for-getaddrinfo-on-Solaris.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Created] (DISPATCH-626) Add hints for getaddrinfo on Solaris

[Adel Boutros (JIRA)]

Adel Boutros created DISPATCH-626:
-

 Summary: Add hints for getaddrinfo on Solaris
 Key: DISPATCH-626
 URL: https://issues.apache.org/jira/browse/DISPATCH-626
 Project: Qpid Dispatch
  Issue Type: Bug
Affects Versions: 0.7.0
Reporter: Adel Boutros






--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Updated] (DISPATCH-624) Add Atomic operations support on Solaris

[Adel Boutros (JIRA)]

 [ 
https://issues.apache.org/jira/browse/DISPATCH-624?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Adel Boutros updated DISPATCH-624:
--
Description: 
Full details here: 
http://qpid.2158936.n2.nabble.com/Dispatch-Router-0-7-0-SOLARIS-Unit-tests-failing-tp7658341.html

*Methods added inspired from:*
https://www.ibm.com/support/knowledgecenter/SSGH2K_13.1.0/com.ibm.xlc131.aix.doc/compiler_ref/bif_gcc_atomic_fetch_sub.html
https://www.ibm.com/support/knowledgecenter/SSGH2K_13.1.0/com.ibm.xlc131.aix.doc/compiler_ref/bif_gcc_atomic_fetch_add.html
http://docs.oracle.com/cd/E19253-01/816-5168/atomic-ops-3c/index.html

  was:Full details here: 
http://qpid.2158936.n2.nabble.com/Dispatch-Router-0-7-0-SOLARIS-Unit-tests-failing-tp7658341.html


> Add Atomic operations support on Solaris
> 
>
> Key: DISPATCH-624
> URL: https://issues.apache.org/jira/browse/DISPATCH-624
> Project: Qpid Dispatch
>  Issue Type: Bug
>Affects Versions: 0.7.0
>    Reporter: Adel Boutros
> Attachments: 0001-Add-Atomic-operations-for-Solaris.patch
>
>
> Full details here: 
> http://qpid.2158936.n2.nabble.com/Dispatch-Router-0-7-0-SOLARIS-Unit-tests-failing-tp7658341.html
> *Methods added inspired from:*
> https://www.ibm.com/support/knowledgecenter/SSGH2K_13.1.0/com.ibm.xlc131.aix.doc/compiler_ref/bif_gcc_atomic_fetch_sub.html
> https://www.ibm.com/support/knowledgecenter/SSGH2K_13.1.0/com.ibm.xlc131.aix.doc/compiler_ref/bif_gcc_atomic_fetch_add.html
> http://docs.oracle.com/cd/E19253-01/816-5168/atomic-ops-3c/index.html



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Updated] (DISPATCH-624) Add Atomic operations support on Solaris

[Adel Boutros (JIRA)]

 [ 
https://issues.apache.org/jira/browse/DISPATCH-624?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Adel Boutros updated DISPATCH-624:
--
Attachment: 0001-Add-Atomic-operations-for-Solaris.patch

> Add Atomic operations support on Solaris
> 
>
> Key: DISPATCH-624
> URL: https://issues.apache.org/jira/browse/DISPATCH-624
> Project: Qpid Dispatch
>  Issue Type: Bug
>Affects Versions: 0.7.0
>    Reporter: Adel Boutros
> Attachments: 0001-Add-Atomic-operations-for-Solaris.patch
>
>
> Full details here: 
> http://qpid.2158936.n2.nabble.com/Dispatch-Router-0-7-0-SOLARIS-Unit-tests-failing-tp7658341.html



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Created] (DISPATCH-624) Add Atomic operations support on Solaris

[Adel Boutros (JIRA)]

Adel Boutros created DISPATCH-624:
-

 Summary: Add Atomic operations support on Solaris
 Key: DISPATCH-624
 URL: https://issues.apache.org/jira/browse/DISPATCH-624
 Project: Qpid Dispatch
  Issue Type: Bug
Affects Versions: 0.7.0
Reporter: Adel Boutros


Full details here: 
http://qpid.2158936.n2.nabble.com/Dispatch-Router-0-7-0-SOLARIS-Unit-tests-failing-tp7658341.html



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Updated] (DISPATCH-616) Arithmetic operations not allowed on void * pointer

[Adel Boutros (JIRA)]

 [ 
https://issues.apache.org/jira/browse/DISPATCH-616?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Adel Boutros updated DISPATCH-616:
--
Description: 
arithmetic on a void* is illegal in both C and C++: 

http://stackoverflow.com/questions/3523145/pointer-arithmetic-for-void-pointer-in-c
https://gcc.gnu.org/onlinedocs/gcc-4.8.0/gcc/Pointer-Arith.html

> Arithmetic operations not allowed on void * pointer
> ---
>
> Key: DISPATCH-616
> URL: https://issues.apache.org/jira/browse/DISPATCH-616
> Project: Qpid Dispatch
>  Issue Type: Bug
>Affects Versions: 0.7.0
>    Reporter: Adel Boutros
> Attachments: 
> 0006-Arithmetic-operations-not-allowed-on-void-pointer.patch
>
>
> arithmetic on a void* is illegal in both C and C++: 
> 
> http://stackoverflow.com/questions/3523145/pointer-arithmetic-for-void-pointer-in-c
> https://gcc.gnu.org/onlinedocs/gcc-4.8.0/gcc/Pointer-Arith.html



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Updated] (DISPATCH-615) SunStudio doesn't convert pointers to bool correctly

[Adel Boutros (JIRA)]

 [ 
https://issues.apache.org/jira/browse/DISPATCH-615?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Adel Boutros updated DISPATCH-615:
--
Description: improper pointer/integer combination: op "=" (PyObject * to 
bool)

> SunStudio doesn't convert pointers to bool correctly
> 
>
> Key: DISPATCH-615
> URL: https://issues.apache.org/jira/browse/DISPATCH-615
> Project: Qpid Dispatch
>  Issue Type: Bug
>Affects Versions: 0.7.0
>Reporter: Adel Boutros
> Attachments: 
> 0005-SunStudio-doesn-t-convert-pointers-to-bool-correctly.patch
>
>
> improper pointer/integer combination: op "=" (PyObject * to bool)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Updated] (DISPATCH-621) Add missing string.h include for Solaris compiler

[Adel Boutros (JIRA)]

 [ 
https://issues.apache.org/jira/browse/DISPATCH-621?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Adel Boutros updated DISPATCH-621:
--
Attachment: 0011-Add-missing-string.h-include-for-Solaris-compiler.patch

> Add missing string.h include for Solaris compiler
> -
>
> Key: DISPATCH-621
> URL: https://issues.apache.org/jira/browse/DISPATCH-621
> Project: Qpid Dispatch
>  Issue Type: Bug
>Affects Versions: 0.7.0
>    Reporter: Adel Boutros
> Attachments: 
> 0011-Add-missing-string.h-include-for-Solaris-compiler.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Updated] (DISPATCH-623) Unreachable code (qd_field_iterator_free after a return statement) detected on Solaris

[Adel Boutros (JIRA)]

 [ 
https://issues.apache.org/jira/browse/DISPATCH-623?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Adel Boutros updated DISPATCH-623:
--
Attachment: 0013-Unreachable-code-qd_field_iterator_free-after-a-retu.patch

> Unreachable code (qd_field_iterator_free after a return statement) detected 
> on Solaris
> --
>
> Key: DISPATCH-623
> URL: https://issues.apache.org/jira/browse/DISPATCH-623
> Project: Qpid Dispatch
>  Issue Type: Bug
>Affects Versions: 0.7.0
>Reporter: Adel Boutros
> Attachments: 
> 0013-Unreachable-code-qd_field_iterator_free-after-a-retu.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Updated] (DISPATCH-622) use "-lpthread" instead of "-pthread" as compiler error to avoid undefined symbol on Solaris

[Adel Boutros (JIRA)]

 [ 
https://issues.apache.org/jira/browse/DISPATCH-622?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Adel Boutros updated DISPATCH-622:
--
Attachment: 0012-use-lpthread-instead-of-pthread-as-compiler-error-to.patch

> use "-lpthread" instead of "-pthread" as compiler error to avoid undefined 
> symbol on Solaris
> 
>
> Key: DISPATCH-622
> URL: https://issues.apache.org/jira/browse/DISPATCH-622
> Project: Qpid Dispatch
>  Issue Type: Bug
>Affects Versions: 0.7.0
>Reporter: Adel Boutros
> Attachments: 
> 0012-use-lpthread-instead-of-pthread-as-compiler-error-to.patch
>
>
> Undefined symbol _mcount : CMakeFiles/qpid-dispatch.dir/bitmask.c.o



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Updated] (DISPATCH-618) Revert eventfd on Solaris

[Adel Boutros (JIRA)]

 [ 
https://issues.apache.org/jira/browse/DISPATCH-618?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Adel Boutros updated DISPATCH-618:
--
Attachment: 0008-Revert-eventfd-on-Solaris.patch

> Revert eventfd on Solaris
> -
>
> Key: DISPATCH-618
> URL: https://issues.apache.org/jira/browse/DISPATCH-618
> Project: Qpid Dispatch
>  Issue Type: Bug
>Affects Versions: 0.7.0
>    Reporter: Adel Boutros
> Attachments: 0008-Revert-eventfd-on-Solaris.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Updated] (DISPATCH-616) Arithmetic operations not allowed on void * pointer

[Adel Boutros (JIRA)]

 [ 
https://issues.apache.org/jira/browse/DISPATCH-616?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Adel Boutros updated DISPATCH-616:
--
Attachment: 0006-Arithmetic-operations-not-allowed-on-void-pointer.patch

> Arithmetic operations not allowed on void * pointer
> ---
>
> Key: DISPATCH-616
> URL: https://issues.apache.org/jira/browse/DISPATCH-616
> Project: Qpid Dispatch
>  Issue Type: Bug
>Affects Versions: 0.7.0
>    Reporter: Adel Boutros
> Attachments: 
> 0006-Arithmetic-operations-not-allowed-on-void-pointer.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Updated] (DISPATCH-619) Use memalign instead of posix_memalign which is not defined on Solaris

[Adel Boutros (JIRA)]

 [ 
https://issues.apache.org/jira/browse/DISPATCH-619?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Adel Boutros updated DISPATCH-619:
--
Attachment: 0009-Use-memalign-instead-of-posix_memalign-which-is-not-.patch

> Use memalign instead of posix_memalign which is not defined on Solaris
> --
>
> Key: DISPATCH-619
> URL: https://issues.apache.org/jira/browse/DISPATCH-619
> Project: Qpid Dispatch
>  Issue Type: Bug
>Affects Versions: 0.7.0
>    Reporter: Adel Boutros
> Attachments: 
> 0009-Use-memalign-instead-of-posix_memalign-which-is-not-.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Updated] (DISPATCH-620) no-strict-aliasing is only supported with GCC

[Adel Boutros (JIRA)]

 [ 
https://issues.apache.org/jira/browse/DISPATCH-620?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Adel Boutros updated DISPATCH-620:
--
Attachment: 0010-no-strict-aliasing-is-only-supported-with-GCC.patch

> no-strict-aliasing is only supported with GCC
> -
>
> Key: DISPATCH-620
> URL: https://issues.apache.org/jira/browse/DISPATCH-620
> Project: Qpid Dispatch
>  Issue Type: Bug
>Affects Versions: 0.7.0
>    Reporter: Adel Boutros
> Attachments: 0010-no-strict-aliasing-is-only-supported-with-GCC.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Updated] (DISPATCH-617) Define HOST_NAME_MAX on Unix OSes where _POSIX_HOST_NAME_MAX is defined instead

[Adel Boutros (JIRA)]

 [ 
https://issues.apache.org/jira/browse/DISPATCH-617?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Adel Boutros updated DISPATCH-617:
--
Attachment: 0007-Define-HOST_NAME_MAX-on-Unix-OSes-where-_POSIX_HOST_.patch

> Define HOST_NAME_MAX on Unix OSes where _POSIX_HOST_NAME_MAX is defined 
> instead
> ---
>
> Key: DISPATCH-617
> URL: https://issues.apache.org/jira/browse/DISPATCH-617
> Project: Qpid Dispatch
>  Issue Type: Bug
>Affects Versions: 0.7.0
>Reporter: Adel Boutros
> Attachments: 
> 0007-Define-HOST_NAME_MAX-on-Unix-OSes-where-_POSIX_HOST_.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Updated] (DISPATCH-615) SunStudio doesn't convert pointers to bool correctly

[Adel Boutros (JIRA)]

 [ 
https://issues.apache.org/jira/browse/DISPATCH-615?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Adel Boutros updated DISPATCH-615:
--
Attachment: 0005-SunStudio-doesn-t-convert-pointers-to-bool-correctly.patch

> SunStudio doesn't convert pointers to bool correctly
> 
>
> Key: DISPATCH-615
> URL: https://issues.apache.org/jira/browse/DISPATCH-615
> Project: Qpid Dispatch
>  Issue Type: Bug
>Affects Versions: 0.7.0
>    Reporter: Adel Boutros
> Attachments: 
> 0005-SunStudio-doesn-t-convert-pointers-to-bool-correctly.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Updated] (DISPATCH-612) Add support for GCC equivalent compiler options

[Adel Boutros (JIRA)]

 [ 
https://issues.apache.org/jira/browse/DISPATCH-612?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Adel Boutros updated DISPATCH-612:
--
Attachment: 0002-Add-support-for-GCC-equivalent-compiler-options.patch

> Add support for GCC equivalent compiler options
> ---
>
> Key: DISPATCH-612
> URL: https://issues.apache.org/jira/browse/DISPATCH-612
> Project: Qpid Dispatch
>  Issue Type: Bug
>Affects Versions: 0.7.0
>    Reporter: Adel Boutros
> Attachments: 
> 0002-Add-support-for-GCC-equivalent-compiler-options.patch
>
>
> Some compiler flags used are only for GCC



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Updated] (DISPATCH-613) Remove semi-column not needed after function definition

[Adel Boutros (JIRA)]

 [ 
https://issues.apache.org/jira/browse/DISPATCH-613?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Adel Boutros updated DISPATCH-613:
--
Attachment: 0003-Remove-semi-column-not-needed-after-function-definit.patch

> Remove semi-column not needed after function definition
> ---
>
> Key: DISPATCH-613
> URL: https://issues.apache.org/jira/browse/DISPATCH-613
> Project: Qpid Dispatch
>  Issue Type: Bug
>Affects Versions: 0.7.0
>    Reporter: Adel Boutros
> Attachments: 
> 0003-Remove-semi-column-not-needed-after-function-definit.patch
>
>
> Empty statement (an extra ";") causes error on Solaris



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Created] (DISPATCH-623) Unreachable code (qd_field_iterator_free after a return statement) detected on Solaris

[Adel Boutros (JIRA)]

Adel Boutros created DISPATCH-623:
-

 Summary: Unreachable code (qd_field_iterator_free after a return 
statement) detected on Solaris
 Key: DISPATCH-623
 URL: https://issues.apache.org/jira/browse/DISPATCH-623
 Project: Qpid Dispatch
  Issue Type: Bug
Affects Versions: 0.7.0
Reporter: Adel Boutros






--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Created] (DISPATCH-622) use "-lpthread" instead of "-pthread" as compiler error to avoid undefined symbol on Solaris

[Adel Boutros (JIRA)]

Adel Boutros created DISPATCH-622:
-

 Summary: use "-lpthread" instead of "-pthread" as compiler error 
to avoid undefined symbol on Solaris
 Key: DISPATCH-622
 URL: https://issues.apache.org/jira/browse/DISPATCH-622
 Project: Qpid Dispatch
  Issue Type: Bug
Affects Versions: 0.7.0
    Reporter: Adel Boutros


Undefined symbol _mcount : CMakeFiles/qpid-dispatch.dir/bitmask.c.o



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Created] (DISPATCH-616) Arithmetic operations not allowed on void * pointer

[Adel Boutros (JIRA)]

Adel Boutros created DISPATCH-616:
-

 Summary: Arithmetic operations not allowed on void * pointer
 Key: DISPATCH-616
 URL: https://issues.apache.org/jira/browse/DISPATCH-616
 Project: Qpid Dispatch
  Issue Type: Bug
Affects Versions: 0.7.0
Reporter: Adel Boutros






--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Created] (DISPATCH-621) Add missing string.h include for Solaris compiler

[Adel Boutros (JIRA)]

Adel Boutros created DISPATCH-621:
-

 Summary: Add missing string.h include for Solaris compiler
 Key: DISPATCH-621
 URL: https://issues.apache.org/jira/browse/DISPATCH-621
 Project: Qpid Dispatch
  Issue Type: Bug
Affects Versions: 0.7.0
Reporter: Adel Boutros






--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Created] (DISPATCH-620) no-strict-aliasing is only supported with GCC

[Adel Boutros (JIRA)]

Adel Boutros created DISPATCH-620:
-

 Summary: no-strict-aliasing is only supported with GCC
 Key: DISPATCH-620
 URL: https://issues.apache.org/jira/browse/DISPATCH-620
 Project: Qpid Dispatch
  Issue Type: Bug
Affects Versions: 0.7.0
Reporter: Adel Boutros






--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Created] (DISPATCH-615) SunStudio doesn't convert pointers to bool correctly

[Adel Boutros (JIRA)]

Adel Boutros created DISPATCH-615:
-

 Summary: SunStudio doesn't convert pointers to bool correctly
 Key: DISPATCH-615
 URL: https://issues.apache.org/jira/browse/DISPATCH-615
 Project: Qpid Dispatch
  Issue Type: Bug
Affects Versions: 0.7.0
Reporter: Adel Boutros






--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Created] (DISPATCH-617) Define HOST_NAME_MAX on Unix OSes where _POSIX_HOST_NAME_MAX is defined instead

[Adel Boutros (JIRA)]

Adel Boutros created DISPATCH-617:
-

 Summary: Define HOST_NAME_MAX on Unix OSes where 
_POSIX_HOST_NAME_MAX is defined instead
 Key: DISPATCH-617
 URL: https://issues.apache.org/jira/browse/DISPATCH-617
 Project: Qpid Dispatch
  Issue Type: Bug
Affects Versions: 0.7.0
Reporter: Adel Boutros






--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Created] (DISPATCH-614) strerror_r on Solaris does not return char*

[Adel Boutros (JIRA)]

Adel Boutros created DISPATCH-614:
-

 Summary: strerror_r on Solaris does not return char*
 Key: DISPATCH-614
 URL: https://issues.apache.org/jira/browse/DISPATCH-614
 Project: Qpid Dispatch
  Issue Type: Bug
Affects Versions: 0.7.0
Reporter: Adel Boutros






--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Created] (DISPATCH-618) Revert eventfd on Solaris

[Adel Boutros (JIRA)]

Adel Boutros created DISPATCH-618:
-

 Summary: Revert eventfd on Solaris
 Key: DISPATCH-618
 URL: https://issues.apache.org/jira/browse/DISPATCH-618
 Project: Qpid Dispatch
  Issue Type: Bug
Affects Versions: 0.7.0
Reporter: Adel Boutros






--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Created] (DISPATCH-619) Use memalign instead of posix_memalign which is not defined on Solaris

[Adel Boutros (JIRA)]

Adel Boutros created DISPATCH-619:
-

 Summary: Use memalign instead of posix_memalign which is not 
defined on Solaris
 Key: DISPATCH-619
 URL: https://issues.apache.org/jira/browse/DISPATCH-619
 Project: Qpid Dispatch
  Issue Type: Bug
Affects Versions: 0.7.0
Reporter: Adel Boutros






--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Created] (DISPATCH-613) Remove semi-column not needed after function definition

[Adel Boutros (JIRA)]

Adel Boutros created DISPATCH-613:
-

 Summary: Remove semi-column not needed after function definition
 Key: DISPATCH-613
 URL: https://issues.apache.org/jira/browse/DISPATCH-613
 Project: Qpid Dispatch
  Issue Type: Bug
Affects Versions: 0.7.0
Reporter: Adel Boutros


Empty statement (an extra ";") causes error on Solaris



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Created] (DISPATCH-612) Add support for GCC equivalent compiler options

[Adel Boutros (JIRA)]

Adel Boutros created DISPATCH-612:
-

 Summary: Add support for GCC equivalent compiler options
 Key: DISPATCH-612
 URL: https://issues.apache.org/jira/browse/DISPATCH-612
 Project: Qpid Dispatch
  Issue Type: Bug
Affects Versions: 0.7.0
Reporter: Adel Boutros


Some compiler flags used are only for GCC



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (PROTON-1383) Add missing includes to fix Solaris compilation

[Adel Boutros (JIRA)]

[ 
https://issues.apache.org/jira/browse/PROTON-1383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15830338#comment-15830338
 ] 

Adel Boutros commented on PROTON-1383:
--

I see your point. I will wait for your feedback.
I am ready to test whatever fix you think might work

> Add missing includes to fix Solaris compilation
> ---
>
> Key: PROTON-1383
> URL: https://issues.apache.org/jira/browse/PROTON-1383
> Project: Qpid Proton
>  Issue Type: Bug
>  Components: proton-c
>Affects Versions: 0.16.0
>Reporter: Adel Boutros
>Assignee: Andrew Stitcher
>  Labels: patch
> Fix For: 0.17.0
>
> Attachments: 0001-Fix-missing-includes-for-Solaris.patch, 
> 0002-add-missing-includes.patch
>
>
> All details available here: 
> http://qpid.2158936.n2.nabble.com/Proton-0-16-0-Solaris-Unit-tests-hanging-when-destroying-connection-driver-td7657231.html



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Comment Edited] (PROTON-1383) Add missing includes to fix Solaris compilation

[Adel Boutros (JIRA)]

[ 
https://issues.apache.org/jira/browse/PROTON-1383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15829641#comment-15829641
 ] 

Adel Boutros edited comment on PROTON-1383 at 1/19/17 10:06 AM:


Thank you [~astitcher], I have a learned something valuable here which I didn't 
know beforehand!

_*Error message (There are no others or any context)*_
{code}"qpid-proton-0.16.0/proton-c/bindings/cpp/src/message.cpp", Error: 
Function "proton::link::error() const" with incomplete return type 
"proton::error_condition", compiler cannot generate virtual table in this 
situation..{code}

After some analysis, it is actually sender.hpp and receiver.hpp who are 
triggering the problem. So whatever cpp file is having one of these includes, I 
get the above error.

I have attached the new patch with the include in the CPP files.


was (Author: adelbout...@live.com):
Thank you [~astitcher], I have a learned something valuable here which I didn't 
know beforehand!

_*Error message (There are no others)*_
{code}"qpid-proton-0.16.0/proton-c/bindings/cpp/src/message.cpp", Error: 
Function "proton::link::error() const" with incomplete return type 
"proton::error_condition", compiler cannot generate virtual table in this 
situation..{code}

After some analysis, it is actually sender.hpp and receiver.hpp who are 
triggering the problem. So whatever cpp file is having one of these includes, I 
get the above error.

I have attached the new patch with the include in the CPP files.

> Add missing includes to fix Solaris compilation
> ---
>
> Key: PROTON-1383
> URL: https://issues.apache.org/jira/browse/PROTON-1383
> Project: Qpid Proton
>  Issue Type: Bug
>  Components: proton-c
>Affects Versions: 0.16.0
>Reporter: Adel Boutros
>Assignee: Andrew Stitcher
>  Labels: patch
> Fix For: 0.17.0
>
> Attachments: 0001-Fix-missing-includes-for-Solaris.patch, 
> 0002-add-missing-includes.patch
>
>
> All details available here: 
> http://qpid.2158936.n2.nabble.com/Proton-0-16-0-Solaris-Unit-tests-hanging-when-destroying-connection-driver-td7657231.html



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (PROTON-1383) Add missing includes to fix Solaris compilation

[Adel Boutros (JIRA)]

[ 
https://issues.apache.org/jira/browse/PROTON-1383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15829641#comment-15829641
 ] 

Adel Boutros commented on PROTON-1383:
--

Thank you [~astitcher], I have a learned something valuable here which I didn't 
know beforehand!

_*Error message (There are no others)*_
{code}"qpid-proton-0.16.0/proton-c/bindings/cpp/src/message.cpp", Error: 
Function "proton::link::error() const" with incomplete return type 
"proton::error_condition", compiler cannot generate virtual table in this 
situation..{code}

After some analysis, it is actually sender.hpp and receiver.hpp who are 
triggering the problem. So whatever cpp file is having one of these includes, I 
get the above error.

I have attached the new patch with the include in the CPP files.

> Add missing includes to fix Solaris compilation
> ---
>
> Key: PROTON-1383
> URL: https://issues.apache.org/jira/browse/PROTON-1383
> Project: Qpid Proton
>  Issue Type: Bug
>  Components: proton-c
>Affects Versions: 0.16.0
>Reporter: Adel Boutros
>Assignee: Andrew Stitcher
>  Labels: patch
> Fix For: 0.17.0
>
> Attachments: 0001-Fix-missing-includes-for-Solaris.patch, 
> 0002-add-missing-includes.patch
>
>
> All details available here: 
> http://qpid.2158936.n2.nabble.com/Proton-0-16-0-Solaris-Unit-tests-hanging-when-destroying-connection-driver-td7657231.html



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Updated] (PROTON-1383) Add missing includes to fix Solaris compilation

[Adel Boutros (JIRA)]

 [ 
https://issues.apache.org/jira/browse/PROTON-1383?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Adel Boutros updated PROTON-1383:
-
Attachment: 0001-Fix-missing-includes-for-Solaris.patch

> Add missing includes to fix Solaris compilation
> ---
>
> Key: PROTON-1383
> URL: https://issues.apache.org/jira/browse/PROTON-1383
> Project: Qpid Proton
>  Issue Type: Bug
>  Components: proton-c
>Affects Versions: 0.16.0
>Reporter: Adel Boutros
>Assignee: Andrew Stitcher
>  Labels: patch
> Fix For: 0.17.0
>
> Attachments: 0001-Fix-missing-includes-for-Solaris.patch, 
> 0002-add-missing-includes.patch
>
>
> All details available here: 
> http://qpid.2158936.n2.nabble.com/Proton-0-16-0-Solaris-Unit-tests-hanging-when-destroying-connection-driver-td7657231.html



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (PROTON-1391) Passing NULL as a SASL selected mechanism is crashing pn_do_error on Solaris

[Adel Boutros (JIRA)]

[ 
https://issues.apache.org/jira/browse/PROTON-1391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15829382#comment-15829382
 ] 

Adel Boutros commented on PROTON-1391:
--

I actually hesitated between Null and None and I agree None is more user 
friendly

> Passing NULL as a SASL selected mechanism is crashing pn_do_error on Solaris
> 
>
> Key: PROTON-1391
> URL: https://issues.apache.org/jira/browse/PROTON-1391
> Project: Qpid Proton
>  Issue Type: Bug
>  Components: proton-c
>Affects Versions: 0.16.0
>Reporter: Adel Boutros
>Assignee: Andrew Stitcher
> Fix For: 0.17.0
>
> Attachments: 
> 0001-Fix-passing-NULL-as-a-var_arg-not-working-on-Solaris.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Created] (PROTON-1392) SWIG doesn't define how to export symbols on Solaris

[Adel Boutros (JIRA)]

Adel Boutros created PROTON-1392:


 Summary: SWIG doesn't define how to export symbols on Solaris
 Key: PROTON-1392
 URL: https://issues.apache.org/jira/browse/PROTON-1392
 Project: Qpid Proton
  Issue Type: Bug
  Components: python-binding
Affects Versions: 0.16.0
Reporter: Adel Boutros
 Attachments: 
0001-SWIG-doesn-t-define-how-to-export-symbols-on-Solaris.patch

Details are here: 
http://qpid.2158936.n2.nabble.com/Proton-0-16-0-Compiling-Proton-Python-bindings-on-Solaris-is-failing-in-the-python-tests-tp7657976.html



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Created] (PROTON-1391) Passing NULL as a SASL selected mechanism is crashing pn_do_error on Solaris

[Adel Boutros (JIRA)]

Adel Boutros created PROTON-1391:


 Summary: Passing NULL as a SASL selected mechanism is crashing 
pn_do_error on Solaris
 Key: PROTON-1391
 URL: https://issues.apache.org/jira/browse/PROTON-1391
 Project: Qpid Proton
  Issue Type: Bug
  Components: proton-c
Affects Versions: 0.16.0
Reporter: Adel Boutros
 Attachments: 
0001-Fix-passing-NULL-as-a-var_arg-not-working-on-Solaris.patch





--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (PROTON-1391) Passing NULL as a SASL selected mechanism is crashing pn_do_error on Solaris

[Adel Boutros (JIRA)]

[ 
https://issues.apache.org/jira/browse/PROTON-1391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15828339#comment-15828339
 ] 

Adel Boutros commented on PROTON-1391:
--

Details can be found here: 
http://qpid.2158936.n2.nabble.com/Proton-0-16-0-Solaris-Null-does-not-have-a-string-representation-tp7658135.html

> Passing NULL as a SASL selected mechanism is crashing pn_do_error on Solaris
> 
>
> Key: PROTON-1391
> URL: https://issues.apache.org/jira/browse/PROTON-1391
> Project: Qpid Proton
>  Issue Type: Bug
>  Components: proton-c
>Affects Versions: 0.16.0
>Reporter: Adel Boutros
> Attachments: 
> 0001-Fix-passing-NULL-as-a-var_arg-not-working-on-Solaris.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Comment Edited] (PROTON-1383) Add missing includes to fix Solaris compilation

[Adel Boutros (JIRA)]

[ 
https://issues.apache.org/jira/browse/PROTON-1383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15804028#comment-15804028
 ] 

Adel Boutros edited comment on PROTON-1383 at 1/6/17 10:33 AM:
---

Hello [~astitcher],

I cannot say I am a very expert C++ developer because I don't consider I have 
the needed experience yet. However, it seems logical for me to add an include 
wherever it is actually needed.

In *link.hpp*, there is a reference to *_error_condition_* so for me it makes 
sence to have the corresponding include there. This way whoever includes 
link.hpp have all the needed class dependencies as well.
{code:java}//link.hpp line 55
PN_CPP_EXTERN void close(const error_condition&); 
{code}

*message.cpp* is just an example. If I don't include it in *link.hpp*, I will 
have to add it to 10 files to get the compilation to work (Wherever *link.hpp* 
is included, I have to include *error_condition.hpp* as well)

>From what I have seen, Solaris is very picky about missing transitive includes 
>and is always complaining about them. Whenever you use a class directly, the 
>corresponding include should be added.

What do you think?


was (Author: adelbout...@live.com):
Hello [~astitcher],

I cannot say I am a very expert C++ developer because I don't consider I have 
the needed experience yet. However, it seems logical for me to add an include 
wherever it is actually needed.

In *link.hpp*, there is a reference to *_error_condition_* so for me it makes 
sence to have there. This way who ever includes link.hpp have all the needed 
class dependencies as well.
{code:java}//link.hpp line 55
PN_CPP_EXTERN void close(const error_condition&); 
{code}

*message.cpp* is just an example. If I don't include it in *link.hpp*, I will 
have to add it to 10 files to get the compilation to work (Wherever *link.hpp* 
is included, I have to include *error_condition.hpp* as well)

>From what I have seen, Solaris is very picky about missing transitive includes 
>and is always complaining about them. Whenever you use a class directly, the 
>corresponding include should be added.

What do you think?

> Add missing includes to fix Solaris compilation
> ---
>
> Key: PROTON-1383
> URL: https://issues.apache.org/jira/browse/PROTON-1383
> Project: Qpid Proton
>  Issue Type: Bug
>  Components: proton-c
>    Affects Versions: 0.16.0
>Reporter: Adel Boutros
>  Labels: patch
> Fix For: 0.17.0
>
> Attachments: 0002-add-missing-includes.patch
>
>
> All details available here: 
> http://qpid.2158936.n2.nabble.com/Proton-0-16-0-Solaris-Unit-tests-hanging-when-destroying-connection-driver-td7657231.html



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (PROTON-1383) Add missing includes to fix Solaris compilation

[Adel Boutros (JIRA)]

[ 
https://issues.apache.org/jira/browse/PROTON-1383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15804028#comment-15804028
 ] 

Adel Boutros commented on PROTON-1383:
--

Hello [~astitcher],

I cannot say I am a very expert C++ developer because I don't consider I have 
the needed experience yet. However, it seems logical for me to add an include 
where it is actually needed.

In *link.hpp*, there is a reference to *_error_condition_* so for me it makes 
sence to have there. This way who ever includes link.hpp have all the needed 
class dependencies as well.
{code:java}//link.hpp line 55
PN_CPP_EXTERN void close(const error_condition&); 
{code}

*message.cpp* is just an example. If I don't include it in *link.hpp*, I will 
have to add it to 10 files to get the compilation to work (Wherever *link.hpp* 
is included, I have to include *error_condition.hpp* as well)

>From what I have seen, Solaris is very picky about missing transitive includes 
>and is always complaining about them. Whenever you use a class directly, the 
>corresponding include should be added.

What do you think?

> Add missing includes to fix Solaris compilation
> ---
>
> Key: PROTON-1383
> URL: https://issues.apache.org/jira/browse/PROTON-1383
> Project: Qpid Proton
>  Issue Type: Bug
>  Components: proton-c
>Affects Versions: 0.16.0
>Reporter: Adel Boutros
>  Labels: patch
> Fix For: 0.17.0
>
> Attachments: 0002-add-missing-includes.patch
>
>
> All details available here: 
> http://qpid.2158936.n2.nabble.com/Proton-0-16-0-Solaris-Unit-tests-hanging-when-destroying-connection-driver-td7657231.html



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Comment Edited] (PROTON-1383) Add missing includes to fix Solaris compilation

[Adel Boutros (JIRA)]

[ 
https://issues.apache.org/jira/browse/PROTON-1383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15804028#comment-15804028
 ] 

Adel Boutros edited comment on PROTON-1383 at 1/6/17 8:46 AM:
--

Hello [~astitcher],

I cannot say I am a very expert C++ developer because I don't consider I have 
the needed experience yet. However, it seems logical for me to add an include 
wherever it is actually needed.

In *link.hpp*, there is a reference to *_error_condition_* so for me it makes 
sence to have there. This way who ever includes link.hpp have all the needed 
class dependencies as well.
{code:java}//link.hpp line 55
PN_CPP_EXTERN void close(const error_condition&); 
{code}

*message.cpp* is just an example. If I don't include it in *link.hpp*, I will 
have to add it to 10 files to get the compilation to work (Wherever *link.hpp* 
is included, I have to include *error_condition.hpp* as well)

>From what I have seen, Solaris is very picky about missing transitive includes 
>and is always complaining about them. Whenever you use a class directly, the 
>corresponding include should be added.

What do you think?


was (Author: adelbout...@live.com):
Hello [~astitcher],

I cannot say I am a very expert C++ developer because I don't consider I have 
the needed experience yet. However, it seems logical for me to add an include 
where it is actually needed.

In *link.hpp*, there is a reference to *_error_condition_* so for me it makes 
sence to have there. This way who ever includes link.hpp have all the needed 
class dependencies as well.
{code:java}//link.hpp line 55
PN_CPP_EXTERN void close(const error_condition&); 
{code}

*message.cpp* is just an example. If I don't include it in *link.hpp*, I will 
have to add it to 10 files to get the compilation to work (Wherever *link.hpp* 
is included, I have to include *error_condition.hpp* as well)

>From what I have seen, Solaris is very picky about missing transitive includes 
>and is always complaining about them. Whenever you use a class directly, the 
>corresponding include should be added.

What do you think?

> Add missing includes to fix Solaris compilation
> ---
>
> Key: PROTON-1383
> URL: https://issues.apache.org/jira/browse/PROTON-1383
> Project: Qpid Proton
>  Issue Type: Bug
>  Components: proton-c
>    Affects Versions: 0.16.0
>Reporter: Adel Boutros
>  Labels: patch
> Fix For: 0.17.0
>
> Attachments: 0002-add-missing-includes.patch
>
>
> All details available here: 
> http://qpid.2158936.n2.nabble.com/Proton-0-16-0-Solaris-Unit-tests-hanging-when-destroying-connection-driver-td7657231.html



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (PROTON-1382) Remove bit fields initialization for bool fields

[Adel Boutros (JIRA)]

[ 
https://issues.apache.org/jira/browse/PROTON-1382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15804008#comment-15804008
 ] 

Adel Boutros commented on PROTON-1382:
--

Hello [~astitcher],
Patch split and issues split and created. I will reply to your last comment in 
the corresponding issue.

> Remove bit fields initialization for bool fields
> 
>
> Key: PROTON-1382
> URL: https://issues.apache.org/jira/browse/PROTON-1382
> Project: Qpid Proton
>  Issue Type: Bug
>  Components: proton-c
>Affects Versions: 0.16.0
>Reporter: Adel Boutros
>  Labels: patch
> Fix For: 0.17.0
>
> Attachments: 
> 0001-Remove-bit-fields-initialization-for-bool-fields.patch
>
>
> All details available here: 
> http://qpid.2158936.n2.nabble.com/Proton-0-16-0-Solaris-Unit-tests-hanging-when-destroying-connection-driver-td7657231.html



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Updated] (PROTON-1383) Add missing includes to fix Solaris compilation

[Adel Boutros (JIRA)]

 [ 
https://issues.apache.org/jira/browse/PROTON-1383?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Adel Boutros updated PROTON-1383:
-
Attachment: 0002-add-missing-includes.patch

> Add missing includes to fix Solaris compilation
> ---
>
> Key: PROTON-1383
> URL: https://issues.apache.org/jira/browse/PROTON-1383
> Project: Qpid Proton
>  Issue Type: Bug
>  Components: proton-c
>Affects Versions: 0.16.0
>Reporter: Adel Boutros
>  Labels: patch
> Fix For: 0.17.0
>
> Attachments: 0002-add-missing-includes.patch
>
>
> All details available here: 
> http://qpid.2158936.n2.nabble.com/Proton-0-16-0-Solaris-Unit-tests-hanging-when-destroying-connection-driver-td7657231.html



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Updated] (PROTON-1382) Remove bit fields initialization for bool fields

[Adel Boutros (JIRA)]

 [ 
https://issues.apache.org/jira/browse/PROTON-1382?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Adel Boutros updated PROTON-1382:
-
Attachment: 0001-Remove-bit-fields-initialization-for-bool-fields.patch

> Remove bit fields initialization for bool fields
> 
>
> Key: PROTON-1382
> URL: https://issues.apache.org/jira/browse/PROTON-1382
> Project: Qpid Proton
>  Issue Type: Bug
>  Components: proton-c
>Affects Versions: 0.16.0
>Reporter: Adel Boutros
>  Labels: patch
> Fix For: 0.17.0
>
> Attachments: 
> 0001-Remove-bit-fields-initialization-for-bool-fields.patch
>
>
> All details available here: 
> http://qpid.2158936.n2.nabble.com/Proton-0-16-0-Solaris-Unit-tests-hanging-when-destroying-connection-driver-td7657231.html



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Updated] (PROTON-1382) Remove bit fields initialization for bool fields

[Adel Boutros (JIRA)]

 [ 
https://issues.apache.org/jira/browse/PROTON-1382?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Adel Boutros updated PROTON-1382:
-
Attachment: (was: 
0001-Remove-bit-fields-initialization-for-bool-fields.patch)

> Remove bit fields initialization for bool fields
> 
>
> Key: PROTON-1382
> URL: https://issues.apache.org/jira/browse/PROTON-1382
> Project: Qpid Proton
>  Issue Type: Bug
>  Components: proton-c
>Affects Versions: 0.16.0
>Reporter: Adel Boutros
>  Labels: patch
> Fix For: 0.17.0
>
>
> All details available here: 
> http://qpid.2158936.n2.nabble.com/Proton-0-16-0-Solaris-Unit-tests-hanging-when-destroying-connection-driver-td7657231.html



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Created] (PROTON-1383) Add missing includes to fix Solaris compilation

[Adel Boutros (JIRA)]

Adel Boutros created PROTON-1383:


 Summary: Add missing includes to fix Solaris compilation
 Key: PROTON-1383
 URL: https://issues.apache.org/jira/browse/PROTON-1383
 Project: Qpid Proton
  Issue Type: Bug
  Components: proton-c
Affects Versions: 0.16.0
Reporter: Adel Boutros
 Fix For: 0.17.0


All details available here: 
http://qpid.2158936.n2.nabble.com/Proton-0-16-0-Solaris-Unit-tests-hanging-when-destroying-connection-driver-td7657231.html



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Created] (PROTON-1382) Remove bit fields initialization for bool fields

[Adel Boutros (JIRA)]

Adel Boutros created PROTON-1382:


 Summary: Remove bit fields initialization for bool fields
 Key: PROTON-1382
 URL: https://issues.apache.org/jira/browse/PROTON-1382
 Project: Qpid Proton
  Issue Type: Bug
  Components: proton-c
Affects Versions: 0.16.0
Reporter: Adel Boutros
 Attachments: 
0001-Remove-bit-fields-initialization-for-bool-fields.patch

All details available here: 
http://qpid.2158936.n2.nabble.com/Proton-0-16-0-Solaris-Unit-tests-hanging-when-destroying-connection-driver-td7657231.html



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Created] (QPID-7590) Add documentation on how to provide a custom PasswordEncrypter

[Adel Boutros (JIRA)]

Adel Boutros created QPID-7590:
--

 Summary: Add documentation on how to provide a custom 
PasswordEncrypter
 Key: QPID-7590
 URL: https://issues.apache.org/jira/browse/QPID-7590
 Project: Qpid
  Issue Type: Improvement
  Components: Java Broker
Affects Versions: qpid-java-6.0.4
Reporter: Adel Boutros
Priority: Minor


More information available on [the mailing list| 
http://qpid.2158936.n2.nabble.com/Qpid-Java-Broker-Providing-external-encryptor-for-configuration-tp7656183.html]



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (PROTON-1344) Provide C "proactor" API for multi-threaded proton applications

[Adel Boutros (JIRA)]

[ 
https://issues.apache.org/jira/browse/PROTON-1344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15659280#comment-15659280
 ] 

Adel Boutros commented on PROTON-1344:
--

Hello Alan,

I have a question: does this new development forces C++ 11? Or is it still 
supposed to work with C++03/98?

Regards,
Adel

> Provide C "proactor" API for multi-threaded proton applications
> ---
>
> Key: PROTON-1344
> URL: https://issues.apache.org/jira/browse/PROTON-1344
> Project: Qpid Proton
>  Issue Type: Improvement
>  Components: proton-c
>Reporter: Alan Conway
>Assignee: Alan Conway
> Fix For: 0.16.0
>
>
> This work will pull together work that has been going on with the 
> experimental pn_connection_engine_t and work on a new C multi-threaded libuv 
> C driver. This work has matured to the point of putting together a coherent 
> and complete pn_proactor API to (eventually) replace the pn_reactor.
> The big differences:
> - proactive not reactive: e.g. void proactor_connect() does not return a 
> bound connection, it starts an asynchronous connection process. All results 
> are reported asynchronously as events, not as synchrouns return values.
> - application controls threading: application thread(s) call wait() to block 
> for events. There are no callbacks to application code from unknown threading 
> contexts.
> - enforces threading model to ensure that events from one connection engine 
> are only handled in one thread at a time. The application does not need locks 
> to or tables to manage this.
> - provides simple inter-thread singalling - any thread can "wake" a 
> connection, causing the proactor to return an event in a thread-safe way for  
> application-triggered work.
> The big similarities: 
> Same proton protocol engine API is unchanged - the pn_connection_engine will 
> dissappear as a separate entity but it's functions will be folded back into 
> pn_connection and pn_transport.
> Same event model: existing code that processes events is unchanged, instead 
> of registering `void my_handler(pn_event_t *)` with the reactor, the 
> application calls my_handler(pn_driver_wait()) in its own threads. There will 
>  be a handful of new proactor-related events.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (PROTON-1339) Event_loop injection is very slow to trigger the events

[Adel Boutros (JIRA)]

[ 
https://issues.apache.org/jira/browse/PROTON-1339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15654286#comment-15654286
 ] 

Adel Boutros commented on PROTON-1339:
--

Hello Alan,

Did yoi have time to work on this issue?

Regards,
Adel

> Event_loop injection is very slow to trigger the events
> ---
>
> Key: PROTON-1339
> URL: https://issues.apache.org/jira/browse/PROTON-1339
> Project: Qpid Proton
>  Issue Type: Improvement
>  Components: cpp-binding
>Affects Versions: 0.14.0
>Reporter: Adel Boutros
>Assignee: Alan Conway
>  Labels: reproducer
> Attachments: main.cpp
>
>
> Full details here: 
> http://qpid.2158936.n2.nabble.com/Proton-c-0-14-0-0-15-0-Event-loop-injection-is-very-slow-compared-to-timer-schedule-td7652982.html
> The attached test code requires a Broker running.
> Output of attached code:
> {code}
> functor called
> closed connection took 1.155 seconds
> {code}
> ==> 1.155 seconds is too much



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (PROTON-1349) C "proactor" implementation on windows

[Adel Boutros (JIRA)]

[ 
https://issues.apache.org/jira/browse/PROTON-1349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15653715#comment-15653715
 ] 

Adel Boutros commented on PROTON-1349:
--

Hello Cliff,

Will you still support C03 ?

Regards,
Adel

> C "proactor" implementation on windows
> --
>
> Key: PROTON-1349
> URL: https://issues.apache.org/jira/browse/PROTON-1349
> Project: Qpid Proton
>  Issue Type: Improvement
>  Components: proton-c
> Environment: Windows
>Reporter: Cliff Jansen
>Assignee: Cliff Jansen
> Fix For: 0.16.0
>
>
> Provide the Windows counterpart to the work in 
>   https://issues.apache.org/jira/browse/PROTON-1344
> Including a thread safe inject.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (PROTON-1340) [Visual Studio 2013] Event_loop injection triggers an exception when the container is being destroyed

[Adel Boutros (JIRA)]

[ 
https://issues.apache.org/jira/browse/PROTON-1340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15635886#comment-15635886
 ] 

Adel Boutros commented on PROTON-1340:
--

Hello [~justi9],

Why is the fix version "0.17.0"? I think this is actually a bug and should thus 
be released as a patch for the affected version.

Regards,
Adel

> [Visual Studio 2013] Event_loop injection triggers an exception when the 
> container is being destroyed
> -
>
> Key: PROTON-1340
> URL: https://issues.apache.org/jira/browse/PROTON-1340
> Project: Qpid Proton
>  Issue Type: Bug
>  Components: cpp-binding
>Affects Versions: 0.14.0
>Reporter: Adel Boutros
>Assignee: Cliff Jansen
>  Labels: windows
> Fix For: 0.17.0
>
>
> Full details here: 
> http://qpid.2158936.n2.nabble.com/Proton-c-0-14-0-Visual-Studio-2013-Exception-when-destroying-the-container-impl-after-using-the-evenp-td7653029.html
> We have the exception when building in RelWithDebInfo mode



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Updated] (PROTON-1340) [Visual Studio 2013] Event_loop injection triggers an exception when the container is being destroyed

[Adel Boutros (JIRA)]

 [ 
https://issues.apache.org/jira/browse/PROTON-1340?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Adel Boutros updated PROTON-1340:
-
Description: 
Full details here: 
http://qpid.2158936.n2.nabble.com/Proton-c-0-14-0-Visual-Studio-2013-Exception-when-destroying-the-container-impl-after-using-the-evenp-td7653029.html

We have the exception when building in RelWithDebInfo mode

  was:Full details here: 
http://qpid.2158936.n2.nabble.com/Proton-c-0-14-0-Visual-Studio-2013-Exception-when-destroying-the-container-impl-after-using-the-evenp-td7653029.html


> [Visual Studio 2013] Event_loop injection triggers an exception when the 
> container is being destroyed
> -
>
> Key: PROTON-1340
> URL: https://issues.apache.org/jira/browse/PROTON-1340
> Project: Qpid Proton
>  Issue Type: Bug
>  Components: cpp-binding
>Affects Versions: 0.14.0
>    Reporter: Adel Boutros
>Assignee: Cliff Jansen
>
> Full details here: 
> http://qpid.2158936.n2.nabble.com/Proton-c-0-14-0-Visual-Studio-2013-Exception-when-destroying-the-container-impl-after-using-the-evenp-td7653029.html
> We have the exception when building in RelWithDebInfo mode



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Created] (PROTON-1340) [Visual Studio 2013] Event_loop injection triggers an exception when the container is being destroyed

[Adel Boutros (JIRA)]

Adel Boutros created PROTON-1340:


 Summary: [Visual Studio 2013] Event_loop injection triggers an 
exception when the container is being destroyed
 Key: PROTON-1340
 URL: https://issues.apache.org/jira/browse/PROTON-1340
 Project: Qpid Proton
  Issue Type: Bug
  Components: cpp-binding
Affects Versions: 0.14.0
Reporter: Adel Boutros
Assignee: Cliff Jansen


Full details here: 
http://qpid.2158936.n2.nabble.com/Proton-c-0-14-0-Visual-Studio-2013-Exception-when-destroying-the-container-impl-after-using-the-evenp-td7653029.html



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Updated] (PROTON-1339) Event_loop injection is very slow to trigger the events

[Adel Boutros (JIRA)]

 [ 
https://issues.apache.org/jira/browse/PROTON-1339?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Adel Boutros updated PROTON-1339:
-
Attachment: main.cpp

> Event_loop injection is very slow to trigger the events
> ---
>
> Key: PROTON-1339
> URL: https://issues.apache.org/jira/browse/PROTON-1339
> Project: Qpid Proton
>  Issue Type: Improvement
>  Components: cpp-binding
>Affects Versions: 0.14.0
>Reporter: Adel Boutros
>Assignee: Cliff Jansen
> Attachments: main.cpp
>
>
> Full details here: 
> http://qpid.2158936.n2.nabble.com/Proton-c-0-14-0-0-15-0-Event-loop-injection-is-very-slow-compared-to-timer-schedule-td7652982.html
> The attached test code requires a Broker running.
> Output of attached code:
> {code}
> functor called
> closed connection took 1.155 seconds
> {code}
> ==> 1.155 seconds is too much



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Created] (PROTON-1339) Event_loop injection is very slow to trigger the events

[Adel Boutros (JIRA)]

Adel Boutros created PROTON-1339:


 Summary: Event_loop injection is very slow to trigger the events
 Key: PROTON-1339
 URL: https://issues.apache.org/jira/browse/PROTON-1339
 Project: Qpid Proton
  Issue Type: Improvement
  Components: cpp-binding
Affects Versions: 0.14.0
Reporter: Adel Boutros
Assignee: Cliff Jansen


Full details here: 
http://qpid.2158936.n2.nabble.com/Proton-c-0-14-0-0-15-0-Event-loop-injection-is-very-slow-compared-to-timer-schedule-td7652982.html

The attached test code requires a Broker running.

Output of attached code:
{code}
functor called
closed connection took 1.155 seconds
{code}

==> 1.155 seconds is too much



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Updated] (PROTON-1336) [Proton-c 0.14.0][Visual Studio 2013] Failing ssl unit test only in Debug mode

[Adel Boutros (JIRA)]

 [ 
https://issues.apache.org/jira/browse/PROTON-1336?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Adel Boutros updated PROTON-1336:
-
Description: 
check full details here: 
http://qpid.2158936.n2.nabble.com/Proton-c-0-14-0-Visual-Studio-2013-Failing-ssl-unit-test-only-in-Debug-mode-td7652076.html

Suggested patch by Cliff is tested and working

{code}
--- proton/proton-c/src/windows/io.c2016-08-16 06:02:21 -0700 
+++ new/proton-c/src/windows/io.c2016-10-19 16:19:21 -0700 
@@ -90,8 +90,11 @@ 
 void pn_io_finalize(void *obj) 
 { 
   pn_io_t *io = (pn_io_t *) obj; 
-  pn_error_free(io->error); 
+  pn_selector_t *sel = io->iocp->selector; 
   pn_free(io->iocp); 
+  if (sel) 
+pn_decref(sel); 
+  pn_error_free(io->error); 
   WSACleanup(); 
 } 

@@ -366,8 +369,10 @@ 

 pn_selector_t *pn_io_selector(pn_io_t *io) 
 { 
-  if (io->iocp->selector == NULL) 
+  if (io->iocp->selector == NULL) { 
 io->iocp->selector = pni_selector_create(io->iocp); 
+pn_incref(io->iocp->selector); 
+  } 
   return io->iocp->selector; 
 } 
{code}

  was:
check full details here: 
http://qpid.2158936.n2.nabble.com/Proton-c-0-14-0-Visual-Studio-2013-Failing-ssl-unit-test-only-in-Debug-mode-td7652076.html

Suggested patch by Cliff is tested and working

--- proton/proton-c/src/windows/io.c2016-08-16 06:02:21 -0700 
+++ new/proton-c/src/windows/io.c2016-10-19 16:19:21 -0700 
@@ -90,8 +90,11 @@ 
 void pn_io_finalize(void *obj) 
 { 
   pn_io_t *io = (pn_io_t *) obj; 
-  pn_error_free(io->error); 
+  pn_selector_t *sel = io->iocp->selector; 
   pn_free(io->iocp); 
+  if (sel) 
+pn_decref(sel); 
+  pn_error_free(io->error); 
   WSACleanup(); 
 } 

@@ -366,8 +369,10 @@ 

 pn_selector_t *pn_io_selector(pn_io_t *io) 
 { 
-  if (io->iocp->selector == NULL) 
+  if (io->iocp->selector == NULL) { 
 io->iocp->selector = pni_selector_create(io->iocp); 
+pn_incref(io->iocp->selector); 
+  } 
   return io->iocp->selector; 
 } 


> [Proton-c 0.14.0][Visual Studio 2013] Failing ssl unit test only in Debug mode
> --
>
> Key: PROTON-1336
> URL: https://issues.apache.org/jira/browse/PROTON-1336
> Project: Qpid Proton
>  Issue Type: Bug
>  Components: proton-c
>Affects Versions: 0.14.0
>Reporter: Adel Boutros
>
> check full details here: 
> http://qpid.2158936.n2.nabble.com/Proton-c-0-14-0-Visual-Studio-2013-Failing-ssl-unit-test-only-in-Debug-mode-td7652076.html
> Suggested patch by Cliff is tested and working
> {code}
> --- proton/proton-c/src/windows/io.c2016-08-16 06:02:21 -0700 
> +++ new/proton-c/src/windows/io.c2016-10-19 16:19:21 -0700 
> @@ -90,8 +90,11 @@ 
>  void pn_io_finalize(void *obj) 
>  { 
>pn_io_t *io = (pn_io_t *) obj; 
> -  pn_error_free(io->error); 
> +  pn_selector_t *sel = io->iocp->selector; 
>pn_free(io->iocp); 
> +  if (sel) 
> +pn_decref(sel); 
> +  pn_error_free(io->error); 
>WSACleanup(); 
>  } 
> @@ -366,8 +369,10 @@ 
>  pn_selector_t *pn_io_selector(pn_io_t *io) 
>  { 
> -  if (io->iocp->selector == NULL) 
> +  if (io->iocp->selector == NULL) { 
>  io->iocp->selector = pni_selector_create(io->iocp); 
> +pn_incref(io->iocp->selector); 
> +  } 
>return io->iocp->selector; 
>  } 
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Created] (PROTON-1336) [Proton-c 0.14.0][Visual Studio 2013] Failing ssl unit test only in Debug mode

[Adel Boutros (JIRA)]

Adel Boutros created PROTON-1336:


 Summary: [Proton-c 0.14.0][Visual Studio 2013] Failing ssl unit 
test only in Debug mode
 Key: PROTON-1336
 URL: https://issues.apache.org/jira/browse/PROTON-1336
 Project: Qpid Proton
  Issue Type: Bug
  Components: proton-c
Affects Versions: 0.14.0
Reporter: Adel Boutros


check full details here: 
http://qpid.2158936.n2.nabble.com/Proton-c-0-14-0-Visual-Studio-2013-Failing-ssl-unit-test-only-in-Debug-mode-td7652076.html

Suggested patch by Cliff is tested and working

--- proton/proton-c/src/windows/io.c2016-08-16 06:02:21 -0700 
+++ new/proton-c/src/windows/io.c2016-10-19 16:19:21 -0700 
@@ -90,8 +90,11 @@ 
 void pn_io_finalize(void *obj) 
 { 
   pn_io_t *io = (pn_io_t *) obj; 
-  pn_error_free(io->error); 
+  pn_selector_t *sel = io->iocp->selector; 
   pn_free(io->iocp); 
+  if (sel) 
+pn_decref(sel); 
+  pn_error_free(io->error); 
   WSACleanup(); 
 } 

@@ -366,8 +369,10 @@ 

 pn_selector_t *pn_io_selector(pn_io_t *io) 
 { 
-  if (io->iocp->selector == NULL) 
+  if (io->iocp->selector == NULL) { 
 io->iocp->selector = pni_selector_create(io->iocp); 
+pn_incref(io->iocp->selector); 
+  } 
   return io->iocp->selector; 
 } 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Updated] (PROTON-1335) [Proton-c] [C++ Bindings] [Visual Studio 2008] Unable to create a binary message

[Adel Boutros (JIRA)]

 [ 
https://issues.apache.org/jira/browse/PROTON-1335?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Adel Boutros updated PROTON-1335:
-
Summary: [Proton-c] [C++ Bindings] [Visual Studio 2008] Unable to create a 
binary message  (was: [Proton-c] [C++ Bindings] Unable to create a binary 
message)

> [Proton-c] [C++ Bindings] [Visual Studio 2008] Unable to create a binary 
> message
> 
>
> Key: PROTON-1335
> URL: https://issues.apache.org/jira/browse/PROTON-1335
> Project: Qpid Proton
>  Issue Type: Bug
>  Components: cpp-binding
>Affects Versions: 0.14.0
>    Reporter: Adel Boutros
>Assignee: Cliff Jansen
>
> Details can be found here: 
> http://qpid.2158936.n2.nabble.com/Proton-c-0-14-0-C-sending-receiving-bytes-and-map-messages-td7652225.html



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Created] (PROTON-1335) [Proton-c] [C++ Bindings] Unable to create a binary message

[Adel Boutros (JIRA)]

Adel Boutros created PROTON-1335:


 Summary: [Proton-c] [C++ Bindings] Unable to create a binary 
message
 Key: PROTON-1335
 URL: https://issues.apache.org/jira/browse/PROTON-1335
 Project: Qpid Proton
  Issue Type: Bug
  Components: cpp-binding
Affects Versions: 0.14.0
Reporter: Adel Boutros
Assignee: Cliff Jansen


Details can be found here: 
http://qpid.2158936.n2.nabble.com/Proton-c-0-14-0-C-sending-receiving-bytes-and-map-messages-td7652225.html



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

Re: [Proton-c][Solaris][SunStudio-2.1] Compiling Qpid Proton-c and C++ bindings on Solaris

[Adel Boutros]

One last question: will the fixes be released in a patch (0.15.1) or a minor 
(0.16.0)?



On Thu, Oct 20, 2016 at 2:27 PM +0200, "Alan Conway" 
<acon...@redhat.com<mailto:acon...@redhat.com>> wrote:

On Thu, 2016-10-20 at 07:27 +, Adel Boutros wrote:
>
> >>> Symbol hiding: PROTON-1316 removes symbol hiding for gcc
> completely, so that change can't go in as is. I'm sure that wasn't
> intentional, just a side effect of doing what was necessary for
> Solaris without checking properly again on Linux.
>
> This is not true, the patch is protected by "if" which will only
> execute the code for SunStudio compiler and will not affect GCC in
> any way (elseif (${CMAKE_CXX_COMPILER_ID} STREQUAL "SunPro" in
> CMakeLists.txt and elif defined(__SUNPRO_C) || defined(__SUNPRO_CC)
> in code).
>

The original patch did delete the HIDE lines in the GCC section - I'm
sure this was an accident, I restored them as intended.

> >>> This change doesn't quite address my concerns: For SunPro the
> ENABLE_HIDE_UNEXPORTED_SYMBOLS toggle is not honoured.
>
> I apologise for the error in the CMakeLists.txt. We missed the "if
> (ENABLE_HIDE_UNEXPORTED_SYMBOLS) " for the code submitted.
> @Alan
> Will you handle updating the patch here?

Done. I made the minimal change to respect the ENABLE_HIDE... flag for
solaris, I haven't re-factored the flag-setting section.

I've committed the patches,  any further improvements can be made
directly on master.

Cheers,
Alan.

Re: [Proton-c][Solaris][SunStudio-2.1] Compiling Qpid Proton-c and C++ bindings on Solaris

[Adel Boutros]

Thanks alot Alan and Andrew for your help!!


However, it seems one patch has slipped. It is about "int8_t".


PROTON-1324: Interpretation of "int8_t" on Solaris using SunStudio is different 
from GCC one

https://issues.apache.org/jira/browse/PROTON-1324


Regards,

Adel


From: Alan Conway <acon...@redhat.com>
Sent: Thursday, October 20, 2016 2:27:10 PM
To: Adel Boutros; Andrew Stitcher; dev
Cc: rabih.prom...@gmail.com
Subject: Re: [Proton-c][Solaris][SunStudio-2.1] Compiling Qpid Proton-c and C++ 
bindings on Solaris

On Thu, 2016-10-20 at 07:27 +, Adel Boutros wrote:
>
> >>> Symbol hiding: PROTON-1316 removes symbol hiding for gcc
> completely, so that change can't go in as is. I'm sure that wasn't
> intentional, just a side effect of doing what was necessary for
> Solaris without checking properly again on Linux.
>
> This is not true, the patch is protected by "if" which will only
> execute the code for SunStudio compiler and will not affect GCC in
> any way (elseif (${CMAKE_CXX_COMPILER_ID} STREQUAL "SunPro" in
> CMakeLists.txt and elif defined(__SUNPRO_C) || defined(__SUNPRO_CC)
> in code).
>

The original patch did delete the HIDE lines in the GCC section - I'm
sure this was an accident, I restored them as intended.

> >>> This change doesn't quite address my concerns: For SunPro the
> ENABLE_HIDE_UNEXPORTED_SYMBOLS toggle is not honoured.
>
> I apologise for the error in the CMakeLists.txt. We missed the "if
> (ENABLE_HIDE_UNEXPORTED_SYMBOLS) " for the code submitted.
> @Alan
> Will you handle updating the patch here?

Done. I made the minimal change to respect the ENABLE_HIDE... flag for
solaris, I haven't re-factored the flag-setting section.

I've committed the patches,  any further improvements can be made
directly on master.

Cheers,
Alan.

Re: [Proton-c][Solaris][SunStudio-2.1] Compiling Qpid Proton-c and C++ bindings on Solaris

[Adel Boutros]

Hello Andrew,


Before I reply to your comments, I would like to clarify that although the 
patches seem easy and minor, it took us (Rabih and myself) 2 weeks full time to 
find the root causes of the issues, prepare a clean patch which will be 
accepted by the community and has no side effects. This is because we have no 
expertise on the Proton code and the errors were not straightforward.


>>> Solaris should have SO_NOSIGPIPE, so the new code in PROTON-1314 should not 
>>> be needed (although there's nothing wrong with the code as far as I can 
>>> see).


Apologies for not mentioning it, but we are using SunOs (x86 and sparc) which 
are not BSD OS. If you google about SO_NOSIGPIPE and sunos (or even Solaris), 
you will find a lot of articles mentioning this issue.  Also doing a quick grep 
will show this signal is not supported.


[host] / # man getsockopt | grep SO_NOSIGPIPE
Reformatting page.  Please Wait... done
[host] / # man signal | grep SIGPIPE
Reformatting page.  Please Wait... done
[host] / #

>>> Symbol hiding: PROTON-1316 removes symbol hiding for gcc completely, so 
>>> that change can't go in as is. I'm sure that wasn't intentional, just a 
>>> side effect of doing what was necessary for Solaris without checking 
>>> properly again on Linux.

This is not true, the patch is protected by "if" which will only execute the 
code for SunStudio compiler and will not affect GCC in any way (elseif 
(${CMAKE_CXX_COMPILER_ID} STREQUAL "SunPro" in CMakeLists.txt and elif 
defined(__SUNPRO_C) || defined(__SUNPRO_CC) in code).

>>> This change doesn't quite address my concerns: For SunPro the 
>>> ENABLE_HIDE_UNEXPORTED_SYMBOLS toggle is not honoured.

I apologise for the error in the CMakeLists.txt. We missed the "if 
(ENABLE_HIDE_UNEXPORTED_SYMBOLS) " for the code submitted.
@Alan
Will you handle updating the patch here?

Just a bit of context for this issue (You can correct me if I said something 
wrong):

When we asked on the mailing list, we were told there are 2 parts here: The 1st 
is setting export of symbols to hidden by default (implemented in 
CMakeLists.txt) and the 2nd part is explicitly exporting symbols (implemented 
in the code)

Hide Symbols
--
GCC: "-fvisibility=hidden": This causes all inlined class member functions to 
have hidden visibility (https://gcc.gnu.org/wiki/Visibility)

SunStudio: "-xldscope=hidden": Hidden scope is easiest to describe as it just 
means that the symbol can only be seen within the module and is not exported 
for applications or libraries to 
use(https://blogs.oracle.com/d/entry/using_symbol_scoping_libraries_and)


Export Symbols explicitly

--

GCC: "__attribute ((visibility ("default")))" : In your header files, wherever 
you want an interface or API made public outside the current DSO 
(https://gcc.gnu.org/wiki/Visibility)


SunStudio: "define PN_CPP_EXPORT __global" __declspec(dllimport) is equivalent 
to __global (https://docs.oracle.com/cd/E24457_01/html/E21991/bkaee.html)


Regards,

Adel


From: Andrew Stitcher <astitc...@redhat.com>
Sent: Thursday, October 20, 2016 12:45:14 AM
To: Alan Conway; Adel Boutros; dev
Cc: rabih.prom...@gmail.com
Subject: Re: [Proton-c][Solaris][SunStudio-2.1] Compiling Qpid Proton-c and C++ 
bindings on Solaris

On Wed, 2016-10-19 at 17:30 -0400, Alan Conway wrote:
> On Tue, 2016-10-18 at 13:24 -0400, Alan Conway wrote:
> >
> > Hi Adel,
> >
> > I've got your Solaris fixes and my (minor) changes up on
> >  https://github.com/alanconway/qpid-proton/tree/absolaris
[https://avatars3.githubusercontent.com/u/7780958?v=3=400]<https://github.com/alanconway/qpid-proton/tree/absolaris>

alanconway/qpid-proton<https://github.com/alanconway/qpid-proton/tree/absolaris>
github.com
qpid-proton - Mirror of Apache Qpid Proton



> >
> > I'd like Andrew to take a look (he's back tomorrow), unless he has
> > anything to add I'll commit them.
>
> I think I've addressed all Andrew's comments on the github branch,
> will
> wait for one more go-round from him.

I'm happy except for PROTON-1316. I've made a comment on the new github
branch.

Andrew

Re: [Proton-c][Solaris][SunStudio-2.1] Compiling Qpid Proton-c and C++ bindings on Solaris

[Adel Boutros]

Hello Andrew,

I will check tomorrow all your comments because I work in France so I am no 
longer in the office now.

I let you choose where to place the comments and we will be happy to reply to 
them by tomorrow. Just let us know where you put them.

Regards,
Adel

Get Outlook for Android



On Wed, Oct 19, 2016 at 9:21 PM +0200, "Andrew Stitcher" 
> wrote:

Being clear, these are all fairly minor issues:

Thank you both for doing this work, I'm very happy to be expanding the
scope of portability for proton,

Andrew

Re: [Proton-c][Solaris][SunStudio-2.1] Compiling Qpid Proton-c and C++ bindings on Solaris

[Adel Boutros]

Great news!! Thanks for your efforts.


Once they are merged, we can test them with the following configuration:

* Linux: GCC 4.9.1

* Solaris SunOS x86: SunStudio 12.1

* Solaris SunOS sparc: SunStudio 12.1

Regards,
Adel


From: Alan Conway <acon...@redhat.com>
Sent: Tuesday, October 18, 2016 7:24:33 PM
To: Adel Boutros; dev
Cc: Andrew Stitcher; rabih.prom...@gmail.com
Subject: Re: [Proton-c][Solaris][SunStudio-2.1] Compiling Qpid Proton-c and C++ 
bindings on Solaris


Hi Adel,

I've got your Solaris fixes and my (minor) changes up on
 https://github.com/alanconway/qpid-proton/tree/absolaris

I'd like Andrew to take a look (he's back tomorrow), unless he has
anything to add I'll commit them.

Cheers,
Alan.

On Mon, 2016-10-17 at 20:03 +, Adel Boutros wrote:
> Hello Alan,
>
> No, it isn't a necessary fix (change from T*).
>
> However, we compiled this code on linux using GCC 4.9.1 and we didn't
> get any error on the master. I wonder which version of gcc you are
> using which revealed this error?
>
> Regards,
> Adel
>
> Ps: The original issue here is that CC doesn't handle constructors
> with "..." correctly which is here the case of sfinae::wildcard(...)
>
> Get Outlook for Android
>
>
>
> On Mon, Oct 17, 2016 at 9:48 PM +0200, "Alan Conway" <aconway@redhat.
> com> wrote:
>
> Hi Adel,
>
> I've put a workaround for one GCC problem on https://github.com/alanc
> on
> way/qpid-proton/tree/absolaris, otherwise I'm happy with this. I'll
> wait for Andrew's OK and then commit if he's happy.
>
> One question: this makes GCC choke:
>
> index b1aff89..5285e4b 100644
> --- a/proton-c/bindings/cpp/include/proton/codec/encoder.hpp
> +++ b/proton-c/bindings/cpp/include/proton/codec/encoder.hpp
> @@ -175,14 +175,14 @@ namespace is_encodable_impl {   // Protected
> the
> world from wildcard operator<<
>
>  using namespace internal;
>
> -sfinae::no operator<<(sfinae::wildcard, sfinae::wildcard); //
> Fallback
> +sfinae::no operator<<(encoder const&, const sfinae::any_t &); //
> Fallback
>
>  template struct is_encodable : public sfinae {
> -static yes test(encoder);
> +static yes test(encoder&);
>  static no test(...); // Failed test, no match.
> -static encoder* e;
> -static const T* t;
> -static bool const value = sizeof(test(*e << *t)) == sizeof(yes);
> +static encoder& e;
> +static const T& t;
> ^^^THIS LINE^^^
> +static bool const value = sizeof(test(e << t)) == sizeof(yes);
>  };
>
> Is the change from T* to T& required to compile on Solaris? If not I
> would probably revert it, but if it is needed then the workaround
> seems
> to be OK. Windows & clang compilers don't have any problem so I
> suspect
> this is GCC's fault.
>
> Cheers,
> Alan.

[jira] [Updated] (PROTON-1324) Interpretation of "int8_t" on Solaris using SunStudio is different from GCC one

[Adel Boutros (JIRA)]

 [ 
https://issues.apache.org/jira/browse/PROTON-1324?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Adel Boutros updated PROTON-1324:
-
Attachment: 0010-SunStudio-Fix-the-interpretation-of-int8_t.patch

> Interpretation of "int8_t" on Solaris using SunStudio is different from GCC 
> one
> ---
>
> Key: PROTON-1324
> URL: https://issues.apache.org/jira/browse/PROTON-1324
> Project: Qpid Proton
>  Issue Type: Bug
>  Components: cpp-binding
>Reporter: Adel Boutros
>Assignee: Cliff Jansen
> Attachments: 0010-SunStudio-Fix-the-interpretation-of-int8_t.patch
>
>
> Looking at the standard, there are actually 3 ways to define a char:
> * char
> * signed char
> * unsigned char
> There are no specificatoins regarding what "char" will be interperted as 
> either "signed char" or "unsigned char". This is left to the OS/Compiler to 
> choose.
> Solaris: int8_t --> char
> Linux: int8_t --> signed char
> You can check here: http://en.cppreference.com/w/cpp/language/types
> {quote}
> char - type for character representation which can be most efficiently 
> processed on the target system (has the same representation and alignment as 
> either signed char or unsigned char, but is always a distinct type). 
> Multibyte characters strings use this type to represent code units.
> {quote}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Created] (PROTON-1324) Interpretation of "int8_t" on Solaris using SunStudio is different from GCC one

[Adel Boutros (JIRA)]

Adel Boutros created PROTON-1324:


 Summary: Interpretation of "int8_t" on Solaris using SunStudio is 
different from GCC one
 Key: PROTON-1324
 URL: https://issues.apache.org/jira/browse/PROTON-1324
 Project: Qpid Proton
  Issue Type: Bug
  Components: cpp-binding
Reporter: Adel Boutros
Assignee: Cliff Jansen


Looking at the standard, there are actually 3 ways to define a char:
* char
* signed char
* unsigned char

There are no specificatoins regarding what "char" will be interperted as either 
"signed char" or "unsigned char". This is left to the OS/Compiler to choose.

Solaris: int8_t --> char
Linux: int8_t --> signed char

You can check here: http://en.cppreference.com/w/cpp/language/types
{quote}
char - type for character representation which can be most efficiently 
processed on the target system (has the same representation and alignment as 
either signed char or unsigned char, but is always a distinct type). Multibyte 
characters strings use this type to represent code units.
{quote}




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org