[GitHub] qpid-dispatch issue #371: DISPATCH-1090 - Draim excess credit if there are n...

2018-09-10 Thread k-wall
Github user k-wall commented on the issue: https://github.com/apache/qpid-dispatch/pull/371 I manually tested the patch https://github.com/apache/qpid-dispatch/pull/371 against Artemis 2.6.2, Broker-J 7.0.6 and CPP Broker (master). The new behaviour looks good to me. btw

[GitHub] qpid-proton pull request #152: PROTON-1886: Dump the thread's SSL error queu...

2018-08-03 Thread k-wall
GitHub user k-wall opened a pull request: https://github.com/apache/qpid-proton/pull/152 PROTON-1886: Dump the thread's SSL error queue in the event that SSL_new fails. Uses the established mechanism to dump the thread's SSL error queue to established tracer in the event

[GitHub] qpid-broker-j issue #9: [QPID-8208] Fix Sybase support for the link-store

2018-07-02 Thread k-wall
Github user k-wall commented on the issue: https://github.com/apache/qpid-broker-j/pull/9 Olivier, thanks for the PR, but QPID-8208 appears to be a typo (it relates to LDAP auth provider error handling rather than this problem). Can you correct and we'll review

[GitHub] qpid-jms pull request #16: QPIDJMS-372: [SASL] [XOAUTH2] Make access token v...

2018-03-27 Thread k-wall
GitHub user k-wall opened a pull request: https://github.com/apache/qpid-jms/pull/16 QPIDJMS-372: [SASL] [XOAUTH2] Make access token validation comply wit… Makes the client's validation of OAUTH-2 access tokens RFC-6749 compliant. You can merge this pull request into a Git

[GitHub] qpid-broker-j issue #4: QPID-7972: [Broker-J] Put VirtualHostNode in ERRORed...

2018-02-22 Thread k-wall
Github user k-wall commented on the issue: https://github.com/apache/qpid-broker-j/pull/4 Hello Olivier Thanks for the contribution. It is much appreciated. I am not too uncomfortable with the idea of special casing of the state behaviour for this one type

[GitHub] qpid-jms issue #9: QPIDJMS-294: Ensure that SASL mechanism has completed bef...

2017-07-21 Thread k-wall
Github user k-wall commented on the issue: https://github.com/apache/qpid-jms/pull/9 I have refreshed the pull request and added a test case around AmqpSaslAuthenticator. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] qpid-jms issue #9: QPIDJMS-294: Ensure that SASL mechanism has completed bef...

2017-07-14 Thread k-wall
Github user k-wall commented on the issue: https://github.com/apache/qpid-jms/pull/9 Tim, I have addressed your comments. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] qpid-jms pull request #9: QPIDJMS-294: Ensure that SASL mechanism has comple...

2017-07-13 Thread k-wall
GitHub user k-wall opened a pull request: https://github.com/apache/qpid-jms/pull/9 QPIDJMS-294: Ensure that SASL mechanism has completed before allowing… … authentication to complete successfully This change allows the SCRAM mechanisms to ensure that server final

[GitHub] qpid-proton-j pull request #9: PROTON-1486: Expose SaslOutcome additional-da...

2017-07-13 Thread k-wall
GitHub user k-wall opened a pull request: https://github.com/apache/qpid-proton-j/pull/9 PROTON-1486: Expose SaslOutcome additional-data to users of the API Based on original work by rgodfrey <rgodf...@apache.org> Having reviewed the existing API, it seemed r