[jira] [Commented] (QPID-6701) [Regression btw 0.30 - 0.32] If address doesn't resolve an exception is not thrown

2015-08-21 Thread Rajith Attapattu (JIRA)
[ https://issues.apache.org/jira/browse/QPID-6701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14706717#comment-14706717 ] Rajith Attapattu commented on QPID-6701: Couple of points, 1. Assert was to verify

[jira] [Commented] (QPID-6701) [Regression btw 0.30 - 0.32] If address doesn't resolve an exception is not thrown

2015-08-20 Thread Rajith Attapattu (JIRA)
[ https://issues.apache.org/jira/browse/QPID-6701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14705746#comment-14705746 ] Rajith Attapattu commented on QPID-6701: QPID-6040 (rev 1620659) changed

[jira] [Created] (QPID-6701) [Regression btw 0.30 - 0.32] If address doesn't resolve an exception is not thrown

2015-08-18 Thread Rajith Attapattu (JIRA)
Rajith Attapattu created QPID-6701: -- Summary: [Regression btw 0.30 - 0.32] If address doesn't resolve an exception is not thrown Key: QPID-6701 URL: https://issues.apache.org/jira/browse/QPID-6701

Re: Review Request 30379: Skeleton code for a possible approach for codec improvements in proton-j.

2015-02-02 Thread rajith attapattu
/codec2/TypeRegistry.java PRE-CREATION Diff: https://reviews.apache.org/r/30379/diff/ Testing --- Thanks, rajith attapattu

Re: Review Request 30379: Skeleton code for a possible approach for codec improvements in proton-j.

2015-02-02 Thread rajith attapattu
--- On Feb. 2, 2015, 6:38 p.m., rajith attapattu wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30379/ --- (Updated

Re: Review Request 30379: Skeleton code for a possible approach for codec improvements in proton-j.

2015-01-28 Thread rajith attapattu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30379/#review70071 --- On Jan. 28, 2015, 8:04 p.m., rajith attapattu wrote

Review Request 30379: Skeleton code for a possible approach for codec improvements in proton-j.

2015-01-28 Thread rajith attapattu
proton-j/src/main/java/org/apache/qpid/proton/codec2/TransportTypesEncoder.java PRE-CREATION Diff: https://reviews.apache.org/r/30379/diff/ Testing --- Thanks, rajith attapattu

[jira] [Updated] (QPID-5870) Closing a topic consumer should delete its exclusive auto-delete queue

2014-07-08 Thread Rajith Attapattu (JIRA)
[ https://issues.apache.org/jira/browse/QPID-5870?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rajith Attapattu updated QPID-5870: --- Attachment: QPID-5870.part2.patch I added a check to ensure that the subscription queue

[jira] [Commented] (QPID-5870) Closing a topic consumer should delete its exclusive auto-delete queue

2014-07-08 Thread Rajith Attapattu (JIRA)
[ https://issues.apache.org/jira/browse/QPID-5870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14055304#comment-14055304 ] Rajith Attapattu commented on QPID-5870: but I wonder what happens around e.g

[jira] [Commented] (QPID-5868) Java client ignores exceptions when waiting on sync

2014-07-04 Thread Rajith Attapattu (JIRA)
[ https://issues.apache.org/jira/browse/QPID-5868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14052509#comment-14052509 ] Rajith Attapattu commented on QPID-5868: As for the session being closed, once

[jira] [Commented] (QPID-5868) Java client ignores exceptions when waiting on sync

2014-07-04 Thread Rajith Attapattu (JIRA)
[ https://issues.apache.org/jira/browse/QPID-5868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14052508#comment-14052508 ] Rajith Attapattu commented on QPID-5868: Apologies for not putting enough info

[jira] [Commented] (QPID-5870) Closing a topic consumer should delete its exclusive auto-delete queue

2014-07-04 Thread Rajith Attapattu (JIRA)
[ https://issues.apache.org/jira/browse/QPID-5870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14052523#comment-14052523 ] Rajith Attapattu commented on QPID-5870: Again I apologize for not providing enough

[jira] [Commented] (QPID-5868) Java client ignores exceptions when waiting on sync

2014-07-04 Thread Rajith Attapattu (JIRA)
[ https://issues.apache.org/jira/browse/QPID-5868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14052722#comment-14052722 ] Rajith Attapattu commented on QPID-5868: I verified that both the transport session

[jira] [Created] (QPID-5868) Java client ignores exceptions when waiting on sync

2014-07-02 Thread Rajith Attapattu (JIRA)
Rajith Attapattu created QPID-5868: -- Summary: Java client ignores exceptions when waiting on sync Key: QPID-5868 URL: https://issues.apache.org/jira/browse/QPID-5868 Project: Qpid Issue

[jira] [Updated] (QPID-5868) Java client ignores exceptions when waiting on sync

2014-07-02 Thread Rajith Attapattu (JIRA)
[ https://issues.apache.org/jira/browse/QPID-5868?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rajith Attapattu updated QPID-5868: --- Attachment: QPID-5868.patch This patch suggests a potential fix for the issue. Java client

[jira] [Created] (QPID-5869) Specifying an ACL file will cause a core dumps when management is sisabled

2014-07-02 Thread Rajith Attapattu (JIRA)
Rajith Attapattu created QPID-5869: -- Summary: Specifying an ACL file will cause a core dumps when management is sisabled Key: QPID-5869 URL: https://issues.apache.org/jira/browse/QPID-5869 Project

[jira] [Updated] (QPID-5869) Specifying an invalid ACL file will cause a core dumps when management is sisabled

2014-07-02 Thread Rajith Attapattu (JIRA)
[ https://issues.apache.org/jira/browse/QPID-5869?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rajith Attapattu updated QPID-5869: --- Summary: Specifying an invalid ACL file will cause a core dumps when management is sisabled

[jira] [Resolved] (QPID-5869) Specifying an invalid ACL file will cause a core dumps when management is disabled

2014-07-02 Thread Rajith Attapattu (JIRA)
[ https://issues.apache.org/jira/browse/QPID-5869?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rajith Attapattu resolved QPID-5869. Resolution: Fixed Assignee: Rajith Attapattu Added a fix on trunk at r1607488

[jira] [Updated] (QPID-5870) Closing a topic consumer should delete its exclusive auto-delete queue

2014-07-02 Thread Rajith Attapattu (JIRA)
[ https://issues.apache.org/jira/browse/QPID-5870?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rajith Attapattu updated QPID-5870: --- Attachment: QPID-5870.patch The subscription queue is now deleted when the consumer is closed

Re: Welcome Andrew MacBean as a Qpid committer

2014-06-05 Thread Rajith Attapattu
Welcome Andrew! Rajith On Tue, Jun 3, 2014 at 6:25 PM, Andrew MacBean andymacb...@gmail.com wrote: Thanks very much! Also the kind welcome messages are much appreciated. :) -Andrew On 3 Jun 2014 20:32, Gordon Sim g...@redhat.com wrote: The Qpid PMC have voted to grant commit rights to

Review Request 22021: [PROTON-589] Changes proposed to Messenger interface and supporting interfaces

2014-05-29 Thread rajith attapattu
, rajith attapattu

Review Request 22022: [PROTON-589] Implementation to support passive mode for proton-j messenger

2014-05-29 Thread rajith attapattu
based tests. No tests yet for passive mode. Passive mode needs to be tested thoroughly. The purpose of this review is to get agreement about the direction I have taken. Thanks, rajith attapattu

[jira] [Updated] (DISPATCH-16) Improve logging for dispatch

2014-02-07 Thread Rajith Attapattu (JIRA)
[ https://issues.apache.org/jira/browse/DISPATCH-16?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rajith Attapattu updated DISPATCH-16: - Attachment: patch_1_schema_change.diff

[jira] [Updated] (DISPATCH-16) Improve logging for dispatch

2014-02-07 Thread Rajith Attapattu (JIRA)
[ https://issues.apache.org/jira/browse/DISPATCH-16?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rajith Attapattu updated DISPATCH-16: - Attachment: patch_5_remove_set_mask_method.diff Improve logging for dispatch

[jira] [Updated] (QPID-5491) Improve logging for dispatch

2014-01-28 Thread Rajith Attapattu (JIRA)
[ https://issues.apache.org/jira/browse/QPID-5491?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rajith Attapattu updated QPID-5491: --- Attachment: (was: log_patch.2) Improve logging for dispatch

[jira] [Updated] (QPID-5491) Improve logging for dispatch

2014-01-28 Thread Rajith Attapattu (JIRA)
[ https://issues.apache.org/jira/browse/QPID-5491?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rajith Attapattu updated QPID-5491: --- Attachment: log_patch.3 Reworked the patch to work on top of Ted's changes. Improve logging

[jira] [Updated] (QPID-5491) Improve logging for dispatch

2014-01-27 Thread Rajith Attapattu (JIRA)
[ https://issues.apache.org/jira/browse/QPID-5491?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rajith Attapattu updated QPID-5491: --- Attachment: log_patch.2 The patch contains the following changes. 1. Each module registers

[jira] [Commented] (QPID-5491) Improve logging for dispatch

2014-01-17 Thread Rajith Attapattu (JIRA)
[ https://issues.apache.org/jira/browse/QPID-5491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13874837#comment-13874837 ] Rajith Attapattu commented on QPID-5491: Sample configuration. logging

[jira] [Comment Edited] (QPID-5491) Improve logging for dispatch

2014-01-17 Thread Rajith Attapattu (JIRA)
[ https://issues.apache.org/jira/browse/QPID-5491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13874837#comment-13874837 ] Rajith Attapattu edited comment on QPID-5491 at 1/17/14 2:52 PM

Review Request 17050: Improvements to logging in dispatch

2014-01-17 Thread rajith attapattu
/log_private.h 1559165 Diff: https://reviews.apache.org/r/17050/diff/ Testing --- All existing tests pass. Thanks, rajith attapattu

Re: Null Pointer exception in Qpid Java CLient 0.24

2013-10-07 Thread Rajith Attapattu
Yes the older versions (pre 0-10) only works with Binding URL format. Rajith On Mon, Oct 7, 2013 at 1:35 PM, Gordon Sim g...@redhat.com wrote: On 10/07/2013 05:51 PM, k.madnani84 wrote: Hi, I am trying to use Qpid Java client 0.24 with RabbitMQ 3.1.5.I am getting a null pointer

[jira] [Commented] (QPID-5204) qpid.subject is an invalid JMS property identifier

2013-10-03 Thread Rajith Attapattu (JIRA)
[ https://issues.apache.org/jira/browse/QPID-5204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13785382#comment-13785382 ] Rajith Attapattu commented on QPID-5204: QPID-3838 prefixes vendor specific

Re: Review Request 14361: QPID-5197: Remove obsolete --cluster-durable/persistLastNode options in java code.

2013-10-01 Thread rajith attapattu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14361/#review26555 --- Ship it! Ship It! - rajith attapattu On Oct. 1, 2013, 2:04 p.m

Re: Review Request 14361: QPID-5197: Remove obsolete --cluster-durable/persistLastNode options in java code.

2013-10-01 Thread rajith attapattu
On Oct. 1, 2013, 2:29 p.m., rajith attapattu wrote: Ship It! QpidQueueOptions.java is no longer in use. Provided the QMF changes are verified by Fraser I don't foresee any other issues. - rajith --- This is an automatically

Re: Detecting potential Java deadlocks with JCarder

2013-09-06 Thread Rajith Attapattu
Hey Philip, Thanks for the analysis! I've been closely following your work. JCarder seems like a very useful tool. Given that we use multiple locks, there are many ways to get into deadlock situations which has made the current client untenable in some user environments. I will definitely use

Re: Welcome Pavel Moravec as a Qpid committer

2013-09-04 Thread Rajith Attapattu
Congrats and Welcome Pavel! Rajith On Wed, Sep 4, 2013 at 11:17 AM, Gordon Sim g...@redhat.com wrote: The Qpid PMC have voted to grant commit rights to Pavel Moravec in recognition of his long standing contributions to the project. Welcome Pavel, and thank you for your continued support

Re: RFQ 0.24: Two JIRAs

2013-08-16 Thread Rajith Attapattu
For python, this is indeed the solution we used when a user wanted the Java client to recognize a python string sent in a map or an application property. On Fri, Aug 16, 2013 at 8:55 AM, Gordon Sim g...@redhat.com wrote: On 08/16/2013 01:15 PM, Darryl L. Pierce wrote: On Mon, Aug 12, 2013 at

Re: svn commit: r1506095 - /qpid/trunk/qpid/java/client/src/main/java/org/apache/qpid/client/BasicMessageProducer.java

2013-07-23 Thread Rajith Attapattu
Sorry, there wasn't JIRA for this. I should have created one. The patch I mentioned was attached to an internal Bugzilla . Rajith On Tue, Jul 23, 2013 at 12:10 PM, Robbie Gemmell robbie.gemm...@gmail.comwrote: This also seems like a change which should have a JIRA reference, particularly if

[jira] [Resolved] (QPID-3838) [JMS] Vendor specific properties should be prefixed with JMS_

2013-07-23 Thread Rajith Attapattu (JIRA)
[ https://issues.apache.org/jira/browse/QPID-3838?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rajith Attapattu resolved QPID-3838. Resolution: Fixed A fix has been made on trunk and also ported to 0.24

Re: [VOTE] Replace the Qpid website

2013-06-17 Thread Rajith Attapattu
[X] Yes, replace the existing site with the proposed site Rajith On Mon, Jun 17, 2013 at 6:05 PM, Ken Giusti kgiu...@redhat.com wrote: - Original Message - From: Justin Ross jr...@apache.org To: dev@qpid.apache.org Sent: Monday, June 17, 2013 1:35:14 PM Subject: [VOTE]

[jira] [Updated] (QPID-4922) If Consumer close() method is invoked while inside onMessage(), it should be excuted after onMessage() has completed.

2013-06-13 Thread Rajith Attapattu (JIRA)
[ https://issues.apache.org/jira/browse/QPID-4922?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rajith Attapattu updated QPID-4922: --- Attachment: QPID-4922.patch Marks that close has been called and then executes it after

[jira] [Updated] (QPID-4922) If Consumer close() method is invoked while inside onMessage(), it should be excuted after onMessage() has completed.

2013-06-13 Thread Rajith Attapattu (JIRA)
[ https://issues.apache.org/jira/browse/QPID-4922?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rajith Attapattu updated QPID-4922: --- Attachment: (was: QPID-4922.patch) If Consumer close() method is invoked while

[jira] [Updated] (QPID-4922) If Consumer close() method is invoked while inside onMessage(), it should be excuted after onMessage() has completed.

2013-06-13 Thread Rajith Attapattu (JIRA)
[ https://issues.apache.org/jira/browse/QPID-4922?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rajith Attapattu updated QPID-4922: --- Attachment: QPID-4922.patch If Consumer close() method is invoked while inside onMessage

[jira] [Updated] (QPID-4357) If an exception is received while the client is blocked on sync, the client should return immediately rather than timing out.

2013-06-12 Thread Rajith Attapattu (JIRA)
[ https://issues.apache.org/jira/browse/QPID-4357?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rajith Attapattu updated QPID-4357: --- Fix Version/s: (was: 0.21) Future If an exception is received

[jira] [Commented] (QPID-4574) [JMS] Deadlock involving _failoverMutex and _messageDeliveryLock

2013-06-12 Thread Rajith Attapattu (JIRA)
[ https://issues.apache.org/jira/browse/QPID-4574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13681283#comment-13681283 ] Rajith Attapattu commented on QPID-4574: Currently the following solution is being

[jira] [Updated] (QPID-4574) [JMS] Deadlock involving _failoverMutex and _messageDeliveryLock

2013-06-12 Thread Rajith Attapattu (JIRA)
[ https://issues.apache.org/jira/browse/QPID-4574?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rajith Attapattu updated QPID-4574: --- Fix Version/s: (was: 0.21) Future [JMS] Deadlock involving

[jira] [Resolved] (QPID-4608) JMS client authorization failure throws JMSException instead of JMSSecurityException

2013-06-12 Thread Rajith Attapattu (JIRA)
[ https://issues.apache.org/jira/browse/QPID-4608?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rajith Attapattu resolved QPID-4608. Resolution: Fixed The relevant commits are http://svn.apache.org/viewvc?view

[jira] [Closed] (QPID-3769) NPE in client AMQDestination.equals()

2013-06-12 Thread Rajith Attapattu (JIRA)
[ https://issues.apache.org/jira/browse/QPID-3769?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rajith Attapattu closed QPID-3769. -- Resolution: Fixed Committed to both trunk and 0.22 branch. NPE in client

[jira] [Resolved] (QPID-4540) The subscription queue should only be deleted by the consumer.

2013-06-12 Thread Rajith Attapattu (JIRA)
[ https://issues.apache.org/jira/browse/QPID-4540?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rajith Attapattu resolved QPID-4540. Resolution: Fixed A fix was committed at http://svn.apache.org/viewvc?rev=1434492view=rev

[jira] [Resolved] (QPID-4497) [Java client] Exclusive property for the subscription queue cannot be overridden using the address string

2013-06-12 Thread Rajith Attapattu (JIRA)
[ https://issues.apache.org/jira/browse/QPID-4497?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rajith Attapattu resolved QPID-4497. Resolution: Fixed [Java client] Exclusive property for the subscription queue cannot

[jira] [Updated] (QPID-4906) If Session close() or closed() method is invoked while inside onMessage(), they should be excuted after onMessage() has completed.

2013-06-11 Thread Rajith Attapattu (JIRA)
[ https://issues.apache.org/jira/browse/QPID-4906?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rajith Attapattu updated QPID-4906: --- Attachment: QPID-4906.patch If close() or closed() is called while the dispatcher thread

Re: Review Request: Address deadlock btw _messageDeliveryLock and _failoverMutex

2013-06-11 Thread rajith attapattu
for a now-closed consumer? Does any particular attention need paid to the overridden 0-10 specific version of this method? rajith attapattu wrote: The message will be dropped if a consumer (or session is closed or closing). When a consumer is closed, any messages acquired

Re: AMQP 1.0 JMS client - supplementary coding standards

2013-06-04 Thread Rajith Attapattu
I'm strongly against using dependencies for the JMS client unless it's unavoidable. We can make exception for slf4j, but even then my preference is to use JDK logging. We've had several issues dealing with dependencies in the past. Increasingly our client is being used in various containers like

[jira] [Created] (QPID-4906) If Session close() or closed() method is invoked while inside onMessage(), they should be excuted after onMessage() has completed.

2013-06-03 Thread Rajith Attapattu (JIRA)
Rajith Attapattu created QPID-4906: -- Summary: If Session close() or closed() method is invoked while inside onMessage(), they should be excuted after onMessage() has completed. Key: QPID-4906 URL: https

Re: [VOTE] Create a QPIDJMS JIRA project

2013-05-28 Thread Rajith Attapattu
Yes [X] No [ ] On Tue, May 28, 2013 at 11:05 AM, Robbie Gemmell robbie.gemm...@gmail.comwrote: Following recent discussions regarding a more component-focused structure, and beginning work on a Proton-based AMQP 1.0 JMS client, could everyone please vote on the following: Create a QPIDJMS

Re: [VOTE] Subversion to JIRA integration

2013-05-24 Thread Rajith Attapattu
QPID: Yes [x ] No [ ] On Fri, May 24, 2013 at 7:03 AM, Robbie Gemmell robbie.gemm...@gmail.comwrote: Hi all, As some of you will already know, a mail was sent to committers@a.oearlier outlining some of the newer services ASF infra offer that we may not know about. One in particular stuck

Re: Website update 4

2013-05-24 Thread Rajith Attapattu
On Fri, May 24, 2013 at 8:56 AM, Justin Ross justin.r...@gmail.com wrote: On Fri, May 24, 2013 at 8:37 AM, Rob Godfrey Sort of. In general, for release content, there's a special generation step. That's really a per-release task, however, not something that many developers would

Re: Proton-based AMQP 1.0 JMS client

2013-05-23 Thread Rajith Attapattu
+1 for a different JIRA system. I believe that is the only way we can support an independent release cycle. Rajith On Thu, May 23, 2013 at 2:36 PM, Rob Godfrey rob.j.godf...@gmail.comwrote: On 23 May 2013 20:24, Justin Ross jr...@apache.org wrote: This is great news! On Thu, May 23,

[jira] [Resolved] (QPID-4873) Optimizations in Java client to reduce queue memory footprint

2013-05-23 Thread Rajith Attapattu (JIRA)
[ https://issues.apache.org/jira/browse/QPID-4873?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rajith Attapattu resolved QPID-4873. Resolution: Fixed Committed the patch from Helen with modifications to accommodate

[jira] [Commented] (QPID-4873) Optimizations in Java client to reduce queue memory footprint

2013-05-22 Thread Rajith Attapattu (JIRA)
[ https://issues.apache.org/jira/browse/QPID-4873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13664379#comment-13664379 ] Rajith Attapattu commented on QPID-4873: I'm happy with optimization #2 and #3

[jira] [Commented] (QPID-4873) Optimizations in Java client to reduce queue memory footprint

2013-05-22 Thread Rajith Attapattu (JIRA)
[ https://issues.apache.org/jira/browse/QPID-4873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13664487#comment-13664487 ] Rajith Attapattu commented on QPID-4873: +1 Seems a good solution! Rajith

[jira] [Commented] (QPID-4873) Optimizations in Java client to reduce queue memory footprint

2013-05-22 Thread Rajith Attapattu (JIRA)
[ https://issues.apache.org/jira/browse/QPID-4873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13664819#comment-13664819 ] Rajith Attapattu commented on QPID-4873: Hi Helen, I will take care of it first

Re: Review Request: Address deadlock btw _messageDeliveryLock and _failoverMutex

2013-05-21 Thread rajith attapattu
suite, tests from customers and QE around the deadlock situation. Thanks, rajith attapattu

Re: Review Request: Address deadlock btw _messageDeliveryLock and _failoverMutex

2013-05-21 Thread rajith attapattu
for a now-closed consumer? Does any particular attention need paid to the overridden 0-10 specific version of this method? rajith attapattu wrote: The message will be dropped if a consumer (or session is closed or closing). When a consumer is closed, any messages acquired

Re: Review Request: Address deadlock btw _messageDeliveryLock and _failoverMutex

2013-05-21 Thread rajith attapattu
for a now-closed consumer? Does any particular attention need paid to the overridden 0-10 specific version of this method? rajith attapattu wrote: The message will be dropped if a consumer (or session is closed or closing). When a consumer is closed, any messages acquired

[jira] [Created] (QPID-4864) The JMS client shouldn't hold a lock when creating a messge

2013-05-17 Thread Rajith Attapattu (JIRA)
Rajith Attapattu created QPID-4864: -- Summary: The JMS client shouldn't hold a lock when creating a messge Key: QPID-4864 URL: https://issues.apache.org/jira/browse/QPID-4864 Project: Qpid

[jira] [Resolved] (QPID-4864) The JMS client shouldn't hold a lock when creating a messge

2013-05-17 Thread Rajith Attapattu (JIRA)
[ https://issues.apache.org/jira/browse/QPID-4864?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rajith Attapattu resolved QPID-4864. Resolution: Fixed Removed the lock. Fix committed at http://svn.apache.org/r1483877

[jira] [Updated] (QPID-4849) Faulty parsing logic in retrieving CN from an SSL certificate.

2013-05-15 Thread Rajith Attapattu (JIRA)
[ https://issues.apache.org/jira/browse/QPID-4849?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rajith Attapattu updated QPID-4849: --- Labels: JMS SSL, (was: ) Faulty parsing logic in retrieving CN from an SSL certificate

[jira] [Updated] (QPID-4849) Faulty parsing logic in retrieving CN from an SSL certificate.

2013-05-15 Thread Rajith Attapattu (JIRA)
[ https://issues.apache.org/jira/browse/QPID-4849?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rajith Attapattu updated QPID-4849: --- Labels: JMS SSL (was: JMS SSL,) Faulty parsing logic in retrieving CN from an SSL

[jira] [Resolved] (QPID-4849) Faulty parsing logic in retrieving CN from an SSL certificate.

2013-05-15 Thread Rajith Attapattu (JIRA)
[ https://issues.apache.org/jira/browse/QPID-4849?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rajith Attapattu resolved QPID-4849. Resolution: Fixed Committed a fix at http://svn.apache.org/r1483079

[jira] [Issue Comment Deleted] (QPID-4574) [JMS] Deadlock involving _failoverMutex and _messageDeliveryLock

2013-05-14 Thread Rajith Attapattu (JIRA)
[ https://issues.apache.org/jira/browse/QPID-4574?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rajith Attapattu updated QPID-4574: --- Comment: was deleted (was: {code} diff --git a/qpid/java/client/src/main/java/org/apache

[jira] [Issue Comment Deleted] (QPID-4574) [JMS] Deadlock involving _failoverMutex and _messageDeliveryLock

2013-05-14 Thread Rajith Attapattu (JIRA)
[ https://issues.apache.org/jira/browse/QPID-4574?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rajith Attapattu updated QPID-4574: --- Comment: was deleted (was: The change here is that the failoverMutex is acquired before

Re: Review Request: Address deadlock btw _messageDeliveryLock and _failoverMutex

2013-05-14 Thread rajith attapattu
/BasicMessageConsumer_0_10.java 1480271 Diff: https://reviews.apache.org/r/10738/diff/ Testing --- Java test suite, tests from customers and QE around the deadlock situation. Thanks, rajith attapattu

Re: Review Request: Address deadlock btw _messageDeliveryLock and _failoverMutex

2013-05-13 Thread rajith attapattu
., rajith attapattu wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10738/ --- (Updated May 8, 2013, 2:02 p.m.) Review request

Re: Review Request: Address deadlock btw _messageDeliveryLock and _failoverMutex

2013-05-13 Thread rajith attapattu
exceptions, or eat the interrupted status. rajith attapattu wrote: For starters I will narrow it down to interrupted exception and then log it. I meant catch the interrupted exception only and ignore. Even if the thread was woken up prematurely, it will go back to waiting

[jira] [Commented] (QPID-3838) [JMS] Vendor specific properties should be prefixed with JMS_

2013-05-09 Thread Rajith Attapattu (JIRA)
[ https://issues.apache.org/jira/browse/QPID-3838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13652992#comment-13652992 ] Rajith Attapattu commented on QPID-3838: I have committed the fix described

[jira] [Updated] (QPID-3317) JMS client doesn't distinguish between node and link bindings

2013-05-09 Thread Rajith Attapattu (JIRA)
[ https://issues.apache.org/jira/browse/QPID-3317?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rajith Attapattu updated QPID-3317: --- Fix Version/s: 0.20 JMS client doesn't distinguish between node and link bindings

What is the correct behaviour for the following case

2013-05-09 Thread Rajith Attapattu
If we use the following address with the java client you get an error with exchange bind. myEx_headers;{create: always,node:{type: topic,x-declare:{type:headers}}} However the exchange (or queue) is created, all though the bind fails. When this happens, 1. Should we reverse the queue or

Re: What is the correct behaviour for the following case

2013-05-09 Thread Rajith Attapattu
On Thu, May 9, 2013 at 11:52 AM, Gordon Sim g...@redhat.com wrote: On 05/09/2013 04:40 PM, Rajith Attapattu wrote: If we use the following address with the java client you get an error with exchange bind. myEx_headers;{create: always,node:{type: topic,x-declare:{type:headers

Re: Review Request: Address deadlock btw _messageDeliveryLock and _failoverMutex

2013-05-08 Thread rajith attapattu
and QE around the deadlock situation. Thanks, rajith attapattu

[jira] [Commented] (QPID-4714) AMQConnection close can leak socket connections if exceptions occur earlier in the process

2013-04-30 Thread Rajith Attapattu (JIRA)
[ https://issues.apache.org/jira/browse/QPID-4714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13645788#comment-13645788 ] Rajith Attapattu commented on QPID-4714: Applied patch to the 0.22 branch. See http

[jira] [Resolved] (QPID-4714) AMQConnection close can leak socket connections if exceptions occur earlier in the process

2013-04-30 Thread Rajith Attapattu (JIRA)
[ https://issues.apache.org/jira/browse/QPID-4714?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rajith Attapattu resolved QPID-4714. Resolution: Fixed Fix Version/s: (was: Future) 0.22

[jira] [Commented] (QPID-4714) AMQConnection close can leak socket connections if exceptions occur earlier in the process

2013-04-25 Thread Rajith Attapattu (JIRA)
[ https://issues.apache.org/jira/browse/QPID-4714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13641879#comment-13641879 ] Rajith Attapattu commented on QPID-4714: I have checked in a fix at http

Request for inclusion in 0.22

2013-04-25 Thread Rajith Attapattu
I would like to include r1475810 http://svn.apache.org/r1475810 in 0.22 The corresponding JIRA (patch attached) is QPID-4714 Rajith

Re: Review Request: Address deadlock btw _messageDeliveryLock and _failoverMutex

2013-04-25 Thread rajith attapattu
. The bottom line is this issue needs to be resolved, or else people will loose confidence in our client. rajith attapattu wrote: It seems you have already noticed that there would be issues with the consumer close, since it would no longer stop deliveries occurring while closing was in progress

Re: Review Request: Address deadlock btw _messageDeliveryLock and _failoverMutex

2013-04-24 Thread rajith attapattu
/ClientProperties.java 1471133 Diff: https://reviews.apache.org/r/10738/diff/ Testing --- Java test suite, tests from customers and QE around the deadlock situation. Thanks, rajith attapattu

Re: Review Request: Address deadlock btw _messageDeliveryLock and _failoverMutex

2013-04-24 Thread rajith attapattu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10738/#review19626 --- On April 24, 2013, 12:19 p.m., rajith attapattu wrote

Re: Review Request: Address deadlock btw _messageDeliveryLock and _failoverMutex

2013-04-24 Thread rajith attapattu
:19 p.m., rajith attapattu wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10738/ --- (Updated April 24, 2013, 12:19 p.m

Re: [Java Build failure] SessionCreateTest is hanging

2013-04-23 Thread Rajith Attapattu
to the client was 3 weeks ago: http://svn.apache.org/r1463158 It isn't actually running at all on the Java broker profiles: java/test-profiles/JavaExcludes:org.apache.qpid.client.SessionCreateTest#* Robbie On 22 April 2013 20:30, Rajith Attapattu rajit...@gmail.com wrote

Review Request: Address deadlock btw _messageDeliveryLock and _failoverMutex

2013-04-23 Thread rajith attapattu
Diff: https://reviews.apache.org/r/10738/diff/ Testing --- Java test suite, tests from customers and QE around the deadlock situation. Thanks, rajith attapattu

[jira] [Commented] (QPID-4714) AMQConnection close is leaking socket connections

2013-04-23 Thread Rajith Attapattu (JIRA)
[ https://issues.apache.org/jira/browse/QPID-4714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13639735#comment-13639735 ] Rajith Attapattu commented on QPID-4714: If we move the close connection method

[Java Build failure] SessionCreateTest is hanging

2013-04-22 Thread Rajith Attapattu
Hi Folks, org.apache.qpid.client.SessionCreateTest hangs when I run its under the cpp profile. It works well under the java broker profile. It seems the last successful run on Jenkins was 2 days ago https://builds.apache.org/job/Qpid-Java-Cpp-Test/ Anybody else seeing this ? Regards, Rajith

Re: [Java Build failure] SessionCreateTest is hanging

2013-04-22 Thread Rajith Attapattu
/JavaExcludes:org.apache.qpid.client.SessionCreateTest#* Robbie On 22 April 2013 20:30, Rajith Attapattu rajit...@gmail.com wrote: Hi Folks, org.apache.qpid.client.SessionCreateTest hangs when I run its under the cpp profile. It works well under the java broker profile. It seems

Re: Modularizing Qpid

2013-04-10 Thread Rajith Attapattu
+1 on this. Having the flexibility to have individual release cycles for each component will be huge advantage for us. However as Justin mentioned, we shouldn't rule out a Qpid wide release perhaps once a year or so. From a users perspective this is a great thing to have, bcos all the components

[jira] [Created] (QPID-4714) AMQConnection close is leaking socket connections

2013-04-05 Thread Rajith Attapattu (JIRA)
Rajith Attapattu created QPID-4714: -- Summary: AMQConnection close is leaking socket connections Key: QPID-4714 URL: https://issues.apache.org/jira/browse/QPID-4714 Project: Qpid Issue Type

[jira] [Commented] (QPID-3769) NPE in client AMQDestination.equals()

2013-04-01 Thread Rajith Attapattu (JIRA)
[ https://issues.apache.org/jira/browse/QPID-3769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13618814#comment-13618814 ] Rajith Attapattu commented on QPID-3769: Adjusted the hashcode and equals impl

[jira] [Updated] (QPID-3769) NPE in client AMQDestination.equals()

2013-04-01 Thread Rajith Attapattu (JIRA)
[ https://issues.apache.org/jira/browse/QPID-3769?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rajith Attapattu updated QPID-3769: --- Fix Version/s: 0.22 NPE in client AMQDestination.equals

[jira] [Commented] (QPID-3769) NPE in client AMQDestination.equals()

2013-04-01 Thread Rajith Attapattu (JIRA)
[ https://issues.apache.org/jira/browse/QPID-3769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13618955#comment-13618955 ] Rajith Attapattu commented on QPID-3769: Ported the relevant changes to 0.22 branch

[jira] [Commented] (QPID-3769) NPE in client AMQDestination.equals()

2013-03-27 Thread Rajith Attapattu (JIRA)
[ https://issues.apache.org/jira/browse/QPID-3769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13615424#comment-13615424 ] Rajith Attapattu commented on QPID-3769: I was going to request a port, but I

Request for inclusion into the 0.22 branch

2013-03-27 Thread Rajith Attapattu
Hey Justin, I want to include the following commits into the 0.22 branch. http://svn.apache.org/r1461324 http://svn.apache.org/r1461329 Once I make some adjustments to the tests, I would need to port that as well. I will send a follow up email when I've got that sorted out. Regards, Rajith

  1   2   3   4   5   6   7   8   9   10   >