[jira] [Commented] (DISPATCH-451) [AMQP] Hard coded session capacity should be configurable

2016-10-10 Thread ASF subversion and git services (JIRA) 

[ 
https://issues.apache.org/jira/browse/DISPATCH-451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15563370#comment-15563370
 ] 

ASF subversion and git services commented on DISPATCH-451:
--

Commit d5e02b8d7084343fe47873cba4e8bfba66dd1b37 in qpid-dispatch's branch 
refs/heads/master from [~chug]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-dispatch.git;h=d5e02b8 ]

DISPATCH-451: Test connector config settings; Fix setting descriptions

The logic behind the config settings for listeners and connectors is
the same. Add tests to verify that connector settings are propagated
over the wire.
Clarify how maxSessionFrames may be adjusted when the product of
maxFrameSize and maxSessionFrames exceeds 2^31-1.


> [AMQP] Hard coded session capacity should be configurable
> -
>
> Key: DISPATCH-451
> URL: https://issues.apache.org/jira/browse/DISPATCH-451
> Project: Qpid Dispatch
>  Issue Type: Bug
>  Components: Container
>Affects Versions: 0.6.0
>Reporter: Chuck Rolke
>
> In container.c and policy.c
> {noformat}
> pn_session_set_incoming_capacity(link->pn_sess, 100);
> {noformat}
> could be improved.
> Policy provides settable values for Open/maxFrameSize, Open/maxSessions, 
> Begin/incoming_window, Attach/maxMessageSize. Configuration settings for 
> these are also desirable.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (DISPATCH-451) [AMQP] Hard coded session capacity should be configurable

2016-10-10 Thread ASF subversion and git services (JIRA) 

[ 
https://issues.apache.org/jira/browse/DISPATCH-451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15563372#comment-15563372
 ] 

ASF subversion and git services commented on DISPATCH-451:
--

Commit acbae29e5888d75564702fa435ffdd269e094e8e in qpid-dispatch's branch 
refs/heads/master from [~chug]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-dispatch.git;h=acbae29 ]

Merge branch 'crolke-DISPATCH-451'

This closes #106


> [AMQP] Hard coded session capacity should be configurable
> -
>
> Key: DISPATCH-451
> URL: https://issues.apache.org/jira/browse/DISPATCH-451
> Project: Qpid Dispatch
>  Issue Type: Bug
>  Components: Container
>Affects Versions: 0.6.0
>Reporter: Chuck Rolke
>
> In container.c and policy.c
> {noformat}
> pn_session_set_incoming_capacity(link->pn_sess, 100);
> {noformat}
> could be improved.
> Policy provides settable values for Open/maxFrameSize, Open/maxSessions, 
> Begin/incoming_window, Attach/maxMessageSize. Configuration settings for 
> these are also desirable.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (DISPATCH-451) [AMQP] Hard coded session capacity should be configurable

2016-10-10 Thread ASF subversion and git services (JIRA) 

[ 
https://issues.apache.org/jira/browse/DISPATCH-451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15563367#comment-15563367
 ] 

ASF subversion and git services commented on DISPATCH-451:
--

Commit 5f4e4a6f2a0dc326bf51823036ab8e6bad9df063 in qpid-dispatch's branch 
refs/heads/master from [~chug]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-dispatch.git;h=5f4e4a6 ]

DISPATCH-451: Allow configurable maxSessions and maxSessionWindow


> [AMQP] Hard coded session capacity should be configurable
> -
>
> Key: DISPATCH-451
> URL: https://issues.apache.org/jira/browse/DISPATCH-451
> Project: Qpid Dispatch
>  Issue Type: Bug
>  Components: Container
>Affects Versions: 0.6.0
>Reporter: Chuck Rolke
>
> In container.c and policy.c
> {noformat}
> pn_session_set_incoming_capacity(link->pn_sess, 100);
> {noformat}
> could be improved.
> Policy provides settable values for Open/maxFrameSize, Open/maxSessions, 
> Begin/incoming_window, Attach/maxMessageSize. Configuration settings for 
> these are also desirable.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (DISPATCH-451) [AMQP] Hard coded session capacity should be configurable

2016-10-10 Thread ASF subversion and git services (JIRA) 

[ 
https://issues.apache.org/jira/browse/DISPATCH-451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15563368#comment-15563368
 ] 

ASF subversion and git services commented on DISPATCH-451:
--

Commit c248a34f3d2da46bb7e7e67ccbd04e2340b69f15 in qpid-dispatch's branch 
refs/heads/master from [~chug]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-dispatch.git;h=c248a34 ]

DISPATCH-451: Describe policy setting priority over listener/connector setting


> [AMQP] Hard coded session capacity should be configurable
> -
>
> Key: DISPATCH-451
> URL: https://issues.apache.org/jira/browse/DISPATCH-451
> Project: Qpid Dispatch
>  Issue Type: Bug
>  Components: Container
>Affects Versions: 0.6.0
>Reporter: Chuck Rolke
>
> In container.c and policy.c
> {noformat}
> pn_session_set_incoming_capacity(link->pn_sess, 100);
> {noformat}
> could be improved.
> Policy provides settable values for Open/maxFrameSize, Open/maxSessions, 
> Begin/incoming_window, Attach/maxMessageSize. Configuration settings for 
> these are also desirable.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (DISPATCH-451) [AMQP] Hard coded session capacity should be configurable

2016-10-10 Thread ASF subversion and git services (JIRA) 

[ 
https://issues.apache.org/jira/browse/DISPATCH-451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15563371#comment-15563371
 ] 

ASF subversion and git services commented on DISPATCH-451:
--

Commit 2bab3f33e2fb7893fe40f3fc850cc0144a45708e in qpid-dispatch's branch 
refs/heads/master from [~chug]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-dispatch.git;h=2bab3f3 ]

DISPATCH-451: Clarify policy vhost setting descriptions


> [AMQP] Hard coded session capacity should be configurable
> -
>
> Key: DISPATCH-451
> URL: https://issues.apache.org/jira/browse/DISPATCH-451
> Project: Qpid Dispatch
>  Issue Type: Bug
>  Components: Container
>Affects Versions: 0.6.0
>Reporter: Chuck Rolke
>
> In container.c and policy.c
> {noformat}
> pn_session_set_incoming_capacity(link->pn_sess, 100);
> {noformat}
> could be improved.
> Policy provides settable values for Open/maxFrameSize, Open/maxSessions, 
> Begin/incoming_window, Attach/maxMessageSize. Configuration settings for 
> these are also desirable.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (DISPATCH-451) [AMQP] Hard coded session capacity should be configurable

2016-10-10 Thread ASF subversion and git services (JIRA) 

[ 
https://issues.apache.org/jira/browse/DISPATCH-451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15563369#comment-15563369
 ] 

ASF subversion and git services commented on DISPATCH-451:
--

Commit f1dbfbf6dd73b4068440f235be38906944c35b59 in qpid-dispatch's branch 
refs/heads/master from [~chug]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-dispatch.git;h=f1dbfbf ]

DISPATCH-451: Incorporate review comments; add self tests


> [AMQP] Hard coded session capacity should be configurable
> -
>
> Key: DISPATCH-451
> URL: https://issues.apache.org/jira/browse/DISPATCH-451
> Project: Qpid Dispatch
>  Issue Type: Bug
>  Components: Container
>Affects Versions: 0.6.0
>Reporter: Chuck Rolke
>
> In container.c and policy.c
> {noformat}
> pn_session_set_incoming_capacity(link->pn_sess, 100);
> {noformat}
> could be improved.
> Policy provides settable values for Open/maxFrameSize, Open/maxSessions, 
> Begin/incoming_window, Attach/maxMessageSize. Configuration settings for 
> these are also desirable.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (DISPATCH-451) [AMQP] Hard coded session capacity should be configurable

2016-10-10 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/DISPATCH-451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15563373#comment-15563373
 ] 

ASF GitHub Bot commented on DISPATCH-451:
-

Github user asfgit closed the pull request at:

https://github.com/apache/qpid-dispatch/pull/106


> [AMQP] Hard coded session capacity should be configurable
> -
>
> Key: DISPATCH-451
> URL: https://issues.apache.org/jira/browse/DISPATCH-451
> Project: Qpid Dispatch
>  Issue Type: Bug
>  Components: Container
>Affects Versions: 0.6.0
>Reporter: Chuck Rolke
>
> In container.c and policy.c
> {noformat}
> pn_session_set_incoming_capacity(link->pn_sess, 100);
> {noformat}
> could be improved.
> Policy provides settable values for Open/maxFrameSize, Open/maxSessions, 
> Begin/incoming_window, Attach/maxMessageSize. Configuration settings for 
> these are also desirable.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (DISPATCH-451) [AMQP] Hard coded session capacity should be configurable

2016-10-07 Thread ASF subversion and git services (JIRA) 

[ 
https://issues.apache.org/jira/browse/DISPATCH-451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15556288#comment-15556288
 ] 

ASF subversion and git services commented on DISPATCH-451:
--

Commit c248a34f3d2da46bb7e7e67ccbd04e2340b69f15 in qpid-dispatch's branch 
refs/heads/crolke-DISPATCH-451 from [~chug]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-dispatch.git;h=c248a34 ]

DISPATCH-451: Describe policy setting priority over listener/connector setting


> [AMQP] Hard coded session capacity should be configurable
> -
>
> Key: DISPATCH-451
> URL: https://issues.apache.org/jira/browse/DISPATCH-451
> Project: Qpid Dispatch
>  Issue Type: Bug
>  Components: Container
>Affects Versions: 0.6.0
>Reporter: Chuck Rolke
>
> In container.c and policy.c
> {noformat}
> pn_session_set_incoming_capacity(link->pn_sess, 100);
> {noformat}
> could be improved.
> Policy provides settable values for Open/maxFrameSize, Open/maxSessions, 
> Begin/incoming_window, Attach/maxMessageSize. Configuration settings for 
> these are also desirable.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (DISPATCH-451) [AMQP] Hard coded session capacity should be configurable

2016-10-07 Thread ASF subversion and git services (JIRA) 

[ 
https://issues.apache.org/jira/browse/DISPATCH-451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15556287#comment-15556287
 ] 

ASF subversion and git services commented on DISPATCH-451:
--

Commit 5f4e4a6f2a0dc326bf51823036ab8e6bad9df063 in qpid-dispatch's branch 
refs/heads/crolke-DISPATCH-451 from [~chug]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-dispatch.git;h=5f4e4a6 ]

DISPATCH-451: Allow configurable maxSessions and maxSessionWindow


> [AMQP] Hard coded session capacity should be configurable
> -
>
> Key: DISPATCH-451
> URL: https://issues.apache.org/jira/browse/DISPATCH-451
> Project: Qpid Dispatch
>  Issue Type: Bug
>  Components: Container
>Affects Versions: 0.6.0
>Reporter: Chuck Rolke
>
> In container.c and policy.c
> {noformat}
> pn_session_set_incoming_capacity(link->pn_sess, 100);
> {noformat}
> could be improved.
> Policy provides settable values for Open/maxFrameSize, Open/maxSessions, 
> Begin/incoming_window, Attach/maxMessageSize. Configuration settings for 
> these are also desirable.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (DISPATCH-451) [AMQP] Hard coded session capacity should be configurable

2016-10-07 Thread ASF subversion and git services (JIRA) 

[ 
https://issues.apache.org/jira/browse/DISPATCH-451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15556289#comment-15556289
 ] 

ASF subversion and git services commented on DISPATCH-451:
--

Commit f1dbfbf6dd73b4068440f235be38906944c35b59 in qpid-dispatch's branch 
refs/heads/crolke-DISPATCH-451 from [~chug]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-dispatch.git;h=f1dbfbf ]

DISPATCH-451: Incorporate review comments; add self tests


> [AMQP] Hard coded session capacity should be configurable
> -
>
> Key: DISPATCH-451
> URL: https://issues.apache.org/jira/browse/DISPATCH-451
> Project: Qpid Dispatch
>  Issue Type: Bug
>  Components: Container
>Affects Versions: 0.6.0
>Reporter: Chuck Rolke
>
> In container.c and policy.c
> {noformat}
> pn_session_set_incoming_capacity(link->pn_sess, 100);
> {noformat}
> could be improved.
> Policy provides settable values for Open/maxFrameSize, Open/maxSessions, 
> Begin/incoming_window, Attach/maxMessageSize. Configuration settings for 
> these are also desirable.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (DISPATCH-451) [AMQP] Hard coded session capacity should be configurable

2016-10-04 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/DISPATCH-451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15546459#comment-15546459
 ] 

ASF GitHub Bot commented on DISPATCH-451:
-

Github user ChugR commented on a diff in the pull request:

https://github.com/apache/qpid-dispatch/pull/106#discussion_r81838943
  
--- Diff: include/qpid/dispatch/server.h ---
@@ -418,6 +418,22 @@ typedef struct qd_server_config_t {
 uint32_t max_frame_size;
 
 /**
+ * The max_sessions value is the number of sessions allowed on the 
Connection. 
+ * This value minus one is the Open performative channel-max setting.
+ */
+uint32_t max_sessions;
+
+/**
+ * The max_session_window value is the maximum number of outstanding 
octets that are
--- End diff --

Good suggestion. The setting down to proton would be  * 
max-frame-size octets.
There is an identical setting in policy that operates this way, too. Again, 
they ought to be the same either way.


> [AMQP] Hard coded session capacity should be configurable
> -
>
> Key: DISPATCH-451
> URL: https://issues.apache.org/jira/browse/DISPATCH-451
> Project: Qpid Dispatch
>  Issue Type: Bug
>  Components: Container
>Affects Versions: 0.6.0
>Reporter: Chuck Rolke
>
> In container.c and policy.c
> {noformat}
> pn_session_set_incoming_capacity(link->pn_sess, 100);
> {noformat}
> could be improved.
> Policy provides settable values for Open/maxFrameSize, Open/maxSessions, 
> Begin/incoming_window, Attach/maxMessageSize. Configuration settings for 
> these are also desirable.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (DISPATCH-451) [AMQP] Hard coded session capacity should be configurable

2016-10-04 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/DISPATCH-451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15546458#comment-15546458
 ] 

ASF GitHub Bot commented on DISPATCH-451:
-

Github user ChugR commented on a diff in the pull request:

https://github.com/apache/qpid-dispatch/pull/106#discussion_r81838905
  
--- Diff: include/qpid/dispatch/server.h ---
@@ -418,6 +418,22 @@ typedef struct qd_server_config_t {
 uint32_t max_frame_size;
 
 /**
+ * The max_sessions value is the number of sessions allowed on the 
Connection. 
+ * This value minus one is the Open performative channel-max setting.
+ */
+uint32_t max_sessions;
--- End diff --

There should be a comment that says if you specify zero then you get the 
default number. Using channel_max is awkward in its own way: if the setting is 
1 then you get 2.
There is an identical setting in policy that already used the 1..N 
numbering (and not 0..N-1). They ought to be the same either way.


> [AMQP] Hard coded session capacity should be configurable
> -
>
> Key: DISPATCH-451
> URL: https://issues.apache.org/jira/browse/DISPATCH-451
> Project: Qpid Dispatch
>  Issue Type: Bug
>  Components: Container
>Affects Versions: 0.6.0
>Reporter: Chuck Rolke
>
> In container.c and policy.c
> {noformat}
> pn_session_set_incoming_capacity(link->pn_sess, 100);
> {noformat}
> could be improved.
> Policy provides settable values for Open/maxFrameSize, Open/maxSessions, 
> Begin/incoming_window, Attach/maxMessageSize. Configuration settings for 
> these are also desirable.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (DISPATCH-451) [AMQP] Hard coded session capacity should be configurable

2016-10-04 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/DISPATCH-451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15546167#comment-15546167
 ] 

ASF GitHub Bot commented on DISPATCH-451:
-

Github user ted-ross commented on a diff in the pull request:

https://github.com/apache/qpid-dispatch/pull/106#discussion_r81817075
  
--- Diff: include/qpid/dispatch/server.h ---
@@ -418,6 +418,22 @@ typedef struct qd_server_config_t {
 uint32_t max_frame_size;
 
 /**
+ * The max_sessions value is the number of sessions allowed on the 
Connection. 
+ * This value minus one is the Open performative channel-max setting.
+ */
+uint32_t max_sessions;
--- End diff --

What will be do with the value 0?  Should we use channel_max to avoid this 
question?


> [AMQP] Hard coded session capacity should be configurable
> -
>
> Key: DISPATCH-451
> URL: https://issues.apache.org/jira/browse/DISPATCH-451
> Project: Qpid Dispatch
>  Issue Type: Bug
>  Components: Container
>Affects Versions: 0.6.0
>Reporter: Chuck Rolke
>
> In container.c and policy.c
> {noformat}
> pn_session_set_incoming_capacity(link->pn_sess, 100);
> {noformat}
> could be improved.
> Policy provides settable values for Open/maxFrameSize, Open/maxSessions, 
> Begin/incoming_window, Attach/maxMessageSize. Configuration settings for 
> these are also desirable.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (DISPATCH-451) [AMQP] Hard coded session capacity should be configurable

2016-10-04 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/DISPATCH-451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15546168#comment-15546168
 ] 

ASF GitHub Bot commented on DISPATCH-451:
-

Github user ted-ross commented on a diff in the pull request:

https://github.com/apache/qpid-dispatch/pull/106#discussion_r81816919
  
--- Diff: include/qpid/dispatch/server.h ---
@@ -418,6 +418,22 @@ typedef struct qd_server_config_t {
 uint32_t max_frame_size;
 
 /**
+ * The max_sessions value is the number of sessions allowed on the 
Connection. 
+ * This value minus one is the Open performative channel-max setting.
+ */
+uint32_t max_sessions;
+
+/**
+ * The max_session_window value is the maximum number of outstanding 
octets that are
--- End diff --

Might it be easier to explain this if the units were frames instead of 
octets?


> [AMQP] Hard coded session capacity should be configurable
> -
>
> Key: DISPATCH-451
> URL: https://issues.apache.org/jira/browse/DISPATCH-451
> Project: Qpid Dispatch
>  Issue Type: Bug
>  Components: Container
>Affects Versions: 0.6.0
>Reporter: Chuck Rolke
>
> In container.c and policy.c
> {noformat}
> pn_session_set_incoming_capacity(link->pn_sess, 100);
> {noformat}
> could be improved.
> Policy provides settable values for Open/maxFrameSize, Open/maxSessions, 
> Begin/incoming_window, Attach/maxMessageSize. Configuration settings for 
> these are also desirable.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (DISPATCH-451) [AMQP] Hard coded session capacity should be configurable

2016-10-04 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/DISPATCH-451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15545539#comment-15545539
 ] 

ASF GitHub Bot commented on DISPATCH-451:
-

GitHub user ChugR opened a pull request:

https://github.com/apache/qpid-dispatch/pull/106

DISPATCH-451: Configurable settings for session capacity and max sessions

This patch allows listener and connector settings for session capacity and 
for max sessions.

It does _not_ allow a setting for max-message-size. Proton does not provide 
an interface for changing max message size. This issue is tracked at 
[PROTON-1311](https://issues.apache.org/jira/browse/PROTON-1311)

Work is progressing on self tests for this feature. Proton python and 
wrapper interfaces tend to hide sessions and make finding session state 
difficult.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ChugR/qpid-dispatch crolke-DISPATCH-451

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/qpid-dispatch/pull/106.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #106


commit 5f4e4a6f2a0dc326bf51823036ab8e6bad9df063
Author: Chuck Rolke 
Date:   2016-10-03T17:48:52Z

DISPATCH-451: Allow configurable maxSessions and maxSessionWindow

commit c248a34f3d2da46bb7e7e67ccbd04e2340b69f15
Author: Chuck Rolke 
Date:   2016-10-03T18:37:40Z

DISPATCH-451: Describe policy setting priority over listener/connector 
setting




> [AMQP] Hard coded session capacity should be configurable
> -
>
> Key: DISPATCH-451
> URL: https://issues.apache.org/jira/browse/DISPATCH-451
> Project: Qpid Dispatch
>  Issue Type: Bug
>  Components: Container
>Affects Versions: 0.6.0
>Reporter: Chuck Rolke
>
> In container.c and policy.c
> {noformat}
> pn_session_set_incoming_capacity(link->pn_sess, 100);
> {noformat}
> could be improved.
> Policy provides settable values for Open/maxFrameSize, Open/maxSessions, 
> Begin/incoming_window, Attach/maxMessageSize. Configuration settings for 
> these are also desirable.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (DISPATCH-451) [AMQP] Hard coded session capacity should be configurable

2016-10-03 Thread Chuck Rolke (JIRA) 

[ 
https://issues.apache.org/jira/browse/DISPATCH-451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15542646#comment-15542646
 ] 

Chuck Rolke commented on DISPATCH-451:
--

The issue is in the units of the AMQP incoming-window and Proton's session 
'capacity'.

* AMQP Open max-frame-size and Attach max-message-size are measured in octets.
* AMQP Begin incoming-window is measured in transfers.
* Proton pn_session_set_incoming_capacity is measured in octets.

Proton calculates the negotiated Begin incoming-capacity by dividing the value 
of
session incoming capacity by max-frame-size to yield some number of transfers.

Everything is working correctly.


> [AMQP] Hard coded session capacity should be configurable
> -
>
> Key: DISPATCH-451
> URL: https://issues.apache.org/jira/browse/DISPATCH-451
> Project: Qpid Dispatch
>  Issue Type: Bug
>  Components: Container
>Affects Versions: 0.6.0
>Reporter: Chuck Rolke
>
> In container.c and policy.c
> {noformat}
> pn_session_set_incoming_capacity(link->pn_sess, 100);
> {noformat}
> could be improved.
> Policy provides settable values for Open/maxFrameSize, Open/maxSessions, 
> Begin/incoming_window, Attach/maxMessageSize. Configuration settings for 
> these are also desirable.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (DISPATCH-451) [AMQP] Hard coded session capacity should be configurable

2016-10-03 Thread Chuck Rolke (JIRA) 

[ 
https://issues.apache.org/jira/browse/DISPATCH-451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15542331#comment-15542331
 ] 

Chuck Rolke commented on DISPATCH-451:
--

After adding code to set the session incoming_capacity (to 987654 instead of 
100) the exchange between qpid/drain and dispatch is:
{noformat}
Sun Oct  2 08:05:12 2016 SERVER (trace) [2]:0 <- @begin(17) 
[next-outgoing-id=0, incoming-window=2147483647, outgoing-window=2147483647]
Sun Oct  2 08:05:12 2016 SERVER (trace) [2]:0 -> @begin(17) [remote-channel=0, 
next-outgoing-id=0, incoming-window=8, outgoing-window=2147483647]
{noformat}

incoming-window=8? 

# Restoring 100 and the value negotiated is still 8.
# Reverting dispatch to master and the value moves to 61.
# Looking closely at traces taken from proton/master, dispatch/master on 
20160920 and the value is 61.

I'm working backwards in history to determine if this is a dispatch or a proton 
issue.


> [AMQP] Hard coded session capacity should be configurable
> -
>
> Key: DISPATCH-451
> URL: https://issues.apache.org/jira/browse/DISPATCH-451
> Project: Qpid Dispatch
>  Issue Type: Bug
>  Components: Container
>Affects Versions: 0.6.0
>Reporter: Chuck Rolke
>
> In container.c and policy.c
> {noformat}
> pn_session_set_incoming_capacity(link->pn_sess, 100);
> {noformat}
> could be improved.
> Policy provides settable values for Open/maxFrameSize, Open/maxSessions, 
> Begin/incoming_window, Attach/maxMessageSize. Configuration settings for 
> these are also desirable.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org