Github user asfgit closed the pull request at:
https://github.com/apache/qpid-cpp/pull/10
---
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
Github user chrisrichardson77 commented on a diff in the pull request:
https://github.com/apache/qpid-cpp/pull/10#discussion_r143968869
--- Diff: src/qpid/broker/Selector.cpp ---
@@ -108,7 +108,7 @@ MessageSelectorEnv::MessageSelectorEnv(const Message&
m) :
const Value
Github user chrisrichardson77 commented on a diff in the pull request:
https://github.com/apache/qpid-cpp/pull/10#discussion_r143973175
--- Diff: src/qpid/broker/SelectorToken.h ---
@@ -69,7 +69,8 @@ struct Token {
std::string val;
std::string::const_iterator
Github user chrisrichardson77 commented on a diff in the pull request:
https://github.com/apache/qpid-cpp/pull/10#discussion_r143969360
--- Diff: src/qpid/broker/SelectorExpression.cpp ---
@@ -1036,7 +1036,7 @@ Expression* unaryArithExpression(Tokeniser& tokeniser)
Expression*
Github user chrisrichardson77 commented on a diff in the pull request:
https://github.com/apache/qpid-cpp/pull/10#discussion_r143969055
--- Diff: src/qpid/broker/Selector.cpp ---
@@ -165,8 +165,6 @@ const Value MessageSelectorEnv::specialValue(const
string& id) const
GitHub user ssorj opened a pull request:
https://github.com/apache/qpid-cpp/pull/10
Assorted C++ build fixes for review
Do not merge. For review purposes only.
This includes the sketchy initialization changes to make things compile on
Fedora 26. It now also includes the
