[GitHub] qpid-dispatch pull request #226: DISPATCH-872 - Added a counter for dropped-...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/qpid-dispatch/pull/226


---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-dispatch pull request #226: DISPATCH-872 - Added a counter for dropped-...

[ganeshmurthy]

Github user ganeshmurthy commented on a diff in the pull request:

https://github.com/apache/qpid-dispatch/pull/226#discussion_r158332552
  
--- Diff: tests/system_tests_one_router.py ---
@@ -1552,6 +1552,14 @@ def check_if_done(self):
 self.conn.close()
 elif self.n_sent == self.n_released:
 self.error = None
+
+if not self.error:
--- End diff --

Yes, the if statement is unnecessary. It should be removed.

It is true that the test does not send pre-settled deliveries. 

The router has allowUnsettledMulticast: yes
in this specific case we send an unsettled multicast to the router. But 
there is no receiver, so the router sends back the following to the client - 

[0x7ffb1c014c50]:0 -> @disposition(21) [role=true, first=0, last=0, 
settled=true, state=@released(38) []]

Hence this delivery can be considered a dropped pre-settled?


https://github.com/apache/qpid-dispatch/blob/master/src/router_core/transfer.c#L783


---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-dispatch pull request #226: DISPATCH-872 - Added a counter for dropped-...

[ted-ross]

Github user ted-ross commented on a diff in the pull request:

https://github.com/apache/qpid-dispatch/pull/226#discussion_r158315973
  
--- Diff: tests/system_tests_one_router.py ---
@@ -1552,6 +1552,14 @@ def check_if_done(self):
 self.conn.close()
 elif self.n_sent == self.n_released:
 self.error = None
+
+if not self.error:
--- End diff --

This 'if' is unnecessary.  Also, this test doesn't send pre-settled 
deliveries.  Why does it expect a count of dropped pre-settleds?


---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-dispatch pull request #226: DISPATCH-872 - Added a counter for dropped-...

[ganeshmurthy]

GitHub user ganeshmurthy opened a pull request:

https://github.com/apache/qpid-dispatch/pull/226

DISPATCH-872 - Added a counter for dropped-presettleds on links. qdst…

…at now shows this counter

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ganeshmurthy/qpid-dispatch DISPATCH-872-1

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/qpid-dispatch/pull/226.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #226


commit d9eed9ffc940e614be47a034aaca38634e65a4a3
Author: Ganesh Murthy 
Date:   2017-11-10T16:29:07Z

DISPATCH-872 - Added a counter for dropped-presettleds on links. qdstat now 
shows this counter




---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org