[GitHub] qpid-proton pull request #146: NO-JIRA: [c] prefer linking with static libra...

[jdanekrh]

Github user jdanekrh closed the pull request at:

https://github.com/apache/qpid-proton/pull/146


---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-proton pull request #143: NO-JIRA: [c] link fuzzing binaries using CXX ...

[jdanekrh]

Github user jdanekrh closed the pull request at:

https://github.com/apache/qpid-proton/pull/143


---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-proton pull request #172: NO-JIRA: c/test/fuzz patches from oss-fuzz

[jdanekrh]

GitHub user jdanekrh opened a pull request:

https://github.com/apache/qpid-proton/pull/172

NO-JIRA: c/test/fuzz patches from oss-fuzz

* NO-JIRA: [c] prefer linking with static library in fuzz tests
* NO-JIRA: [c] link fuzzing binaries using CXX linker

this supersedes https://github.com/apache/qpid-proton/pull/146 and 
https://github.com/apache/qpid-proton/pull/143

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/jdanekrh/qpid-proton jd_oss-fuzz-patch

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/qpid-proton/pull/172.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #172


commit a0d2345bec4e7538ad7df535323a8acd8bec2d36
Author: Jiri Danek 
Date:   2018-12-13T13:52:09Z

NO-JIRA: c/test/fuzz patches from oss-fuzz

* NO-JIRA: [c] prefer linking with static library in fuzz tests
* NO-JIRA: [c] link fuzzing binaries using CXX linker




---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-proton pull request #171: NO-JIRA: outdated `pn_connection_driver_free`...

[jdanekrh]

GitHub user jdanekrh opened a pull request:

https://github.com/apache/qpid-proton/pull/171

NO-JIRA: outdated `pn_connection_driver_free` reference in doc comment



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/jdanekrh/qpid-proton jd_destroy_free_typo

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/qpid-proton/pull/171.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #171


commit d6ee8967f0db06ce5fb2c0341d754a97d99f3ca8
Author: Jiri Danek 
Date:   2018-12-12T15:33:49Z

NO-JIRA: fix outdated function reference in docs




---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-proton pull request #170: PROTON-1959 [cpp] Binary compatible reconnect

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/qpid-proton/pull/170


---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-proton pull request #170: PROTON-1959 [cpp] Binary compatible reconnect

[alanconway]

GitHub user alanconway opened a pull request:

https://github.com/apache/qpid-proton/pull/170

PROTON-1959 [cpp] Binary compatible reconnect

The previous commit f53c7683d7e90363 added virtual functions to 
messaging_handler
which is a binary incompatible change.

Modify & update doc to work with existing messaging_handler functions.
Use existing pn_connection_open() and pn_transport_error() events instead 
of creating new ones.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/alanconway/qpid-proton 
cpp-reconnect-backward-compat

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/qpid-proton/pull/170.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #170


commit 302c7da439cbffdc7e85959a43421838418d0cc7
Author: Alan Conway 
Date:   2018-11-30T19:07:58Z

PROTON-1959 [cpp] Binary compatible reconnect

The previous commit f53c7683d7e90363 added virtual functions to 
messaging_handler
which is a binary incompatible change.

Modify & update doc to work with existing messaging_handler functions.




---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-proton pull request #169: Clang format

[alanconway]

GitHub user alanconway opened a pull request:

https://github.com/apache/qpid-proton/pull/169

Clang format

Format command: clang-format -i $(git ls-files -- *.cpp *.hpp *.c *.h)

Style file is /.clang-format, with the following contents:

Language: Cpp   # also applies to C
BasedOnStyle: LLVM
IndentWidth: 4
AllowShortIfStatementsOnASingleLine: true
AllowShortLoopsOnASingleLine: true


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/alanconway/qpid-proton clang-format

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/qpid-proton/pull/169.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #169


commit 5f82739467ed4a936f4755b123f7a4108e273a91
Author: Alan Conway 
Date:   2018-11-27T21:08:40Z

WIP: Support for automating clang-format

/.clang-format - style file for C and C++
/scripts/git-clang-format - reformat git changes only

commit 358a30144fa5124619fb1670ebe2587456e4fb0b
Author: Alan Conway 
Date:   2018-11-27T21:10:56Z

WIP: reformat all c/c++ sources using clang-format.

Format command: clang-format -i $(git ls-files -- *.cpp *.hpp *.c *.h)

Style file is /.clang-format, with the following contents:

Language: Cpp   # also applies to C
BasedOnStyle: LLVM
IndentWidth: 4
AllowShortIfStatementsOnASingleLine: true
AllowShortLoopsOnASingleLine: true




---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-proton pull request #168: PROTON-1887: [c] Convert C tests to use Catch...

[alanconway]

GitHub user alanconway opened a pull request:

https://github.com/apache/qpid-proton/pull/168

PROTON-1887: [c] Convert C tests to use Catch2 harness.

Convert c/tests from home-baked test macros to the Catch2 test harness.
We are using version 1.x until we can move on from supporting C++03.
https://github.com/catchorg/Catch2/tree/Catch1.x

Added files:

test/include/
- catch.hpp - the Catch2 version 1.x framework in a single header.
- catch_extra.hpp - added Catch::Matcher support for C-string comparisons

c/tests/
- pn_test.hpp/.cpp - tools for testing the core library
  - auto_free<> - scoped freeing of pn_xxx_t*
  - matchers to check pn_condition/error_t with useful output
  - driver class to pump a pn_connection_driver_t and check events
- trivial in-memory copy transport, no networking needed.
- pn_test_proactor.hpp/cpp - tools for testing the proactor library
  - proactor to pump a pn_proactor and check events.
  - same handler as driver above.

Renamed tests files: c/tests/*.c => c/tests/*_test.cpp

Tests are now linked into 3 executables:

- c-core-test - tests for libqpid-proton-core API
- c-extra-test - tests for the "extra" deprecated API in libqpid-proton
- c-proactor-test - tests for the proactor API in libqpid-proton-proactor

Individual tests or subsets can be run via command line arguments, run with
"-h" for a summary, or see 
https://github.com/catchorg/Catch2/blob/Catch1.x/docs/command-line.md

NOTE: Catch2 allows multiple "tags" to be associated with each test to 
easily
define different test sets. We're not using this feature yet, we could use 
it to
identify a fast self-test set, a long-running stress test set etc.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/alanconway/qpid-proton c-catch-tests

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/qpid-proton/pull/168.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #168


commit a9388dd42739ec5134db6f34da6545d2142f4ce9
Author: Alan Conway 
Date:   2018-11-14T22:12:51Z

PROTON-1887: [c] Convert C tests to use Catch2 harness.

Convert c/tests from home-baked test macros to the Catch2 test harness.
We are using version 1.x until we can move on from supporting C++03.
https://github.com/catchorg/Catch2/tree/Catch1.x

Added files:

test/include/
- catch.hpp - the Catch2 version 1.x framework in a single header.
- catch_extra.hpp - added Catch::Matcher support for C-string comparisons

c/tests/
- pn_test.hpp/.cpp - tools for testing the core library
  - auto_free<> - scoped freeing of pn_xxx_t*
  - matchers to check pn_condition/error_t with useful output
  - driver class to pump a pn_connection_driver_t and check events
- trivial in-memory copy transport, no networking needed.
- pn_test_proactor.hpp/cpp - tools for testing the proactor library
  - proactor to pump a pn_proactor and check events.
  - same handler as driver above.

Renamed tests files: c/tests/*.c => c/tests/*_test.cpp

Tests are now linked into 3 executables:

- c-core-test - tests for libqpid-proton-core API
- c-extra-test - tests for the "extra" deprecated API in libqpid-proton
- c-proactor-test - tests for the proactor API in libqpid-proton-proactor

Individual tests or subsets can be run via command line arguments, run with
"-h" for a summary, or see 
https://github.com/catchorg/Catch2/blob/Catch1.x/docs/command-line.md

NOTE: Catch2 allows multiple "tags" to be associated with each test to 
easily
define different test sets. We're not using this feature yet, we could use 
it to
identify a fast self-test set, a long-running stress test set etc.




---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-proton pull request #162: PROTON-1957: Re-enabling the install of pytho...

[RoddieKieley]

GitHub user RoddieKieley opened a pull request:

https://github.com/apache/qpid-proton/pull/162

PROTON-1957: Re-enabling the install of python 3.6.4_4 for travis mac…

…OS build via specific commit of the forumla.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/RoddieKieley/qpid-proton 
travis-python-reenable

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/qpid-proton/pull/162.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #162


commit 3b2e93c8161ceeab570770af8d2cf248a83061c7
Author: Roddie Kieley 
Date:   2018-10-12T17:31:25Z

PROTON-1957: Re-enabling the install of python 3.6.4_4 for travis macOS 
build via specific commit of the forumla.




---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-proton pull request #161: NO-JIRA: Removed python upgrade for xcode7.3 ...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/qpid-proton/pull/161


---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-proton pull request #161: NO-JIRA: Removed python upgrade for xcode7.3 ...

[RoddieKieley]

GitHub user RoddieKieley opened a pull request:

https://github.com/apache/qpid-proton/pull/161

NO-JIRA: Removed python upgrade for xcode7.3 travis build to fix pip issue

Tried a few different updates to rectify the [travis xcode7.3 build 
failure](https://travis-ci.org/apache/qpid-proton/jobs/436640885) with this 
having the least impact. Originally we needed this to get a working python 
version but now we don't and the upgrade to 3.7.0 breaks pip for the moment.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/RoddieKieley/qpid-proton travis-pip

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/qpid-proton/pull/161.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #161


commit 386a88ccd33ccdd3008f2f4de84f13599cc77a68
Author: Roddie Kieley 
Date:   2018-10-03T18:43:29Z

NO-JIRA: Removed python upgrade for xcode7.3 build to fix pip issue




---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-proton pull request #151: Install tests

[alanconway]

Github user alanconway closed the pull request at:

https://github.com/apache/qpid-proton/pull/151


---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-proton pull request #159: PROTON-1940: [c] normalize encoding of multip...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/qpid-proton/pull/159


---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-proton pull request #142: PROTON-1831: Incorrect open/close sequence fo...

[alanconway]

Github user alanconway closed the pull request at:

https://github.com/apache/qpid-proton/pull/142


---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-proton pull request #157: WIP: extract connection_options_impl for test...

[alanconway]

Github user alanconway closed the pull request at:

https://github.com/apache/qpid-proton/pull/157


---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-proton pull request #160: WIP: option version of connection_options ...

[alanconway]

GitHub user alanconway opened a pull request:

https://github.com/apache/qpid-proton/pull/160

WIP: option version of connection_options getters

This is the template approach to option getters - memory safe.
Needs to be extended to all the _options classes, but I want agreement on 
the approach and option clss before I complete the job. @astitcher 
@cliffjansen 

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/alanconway/qpid-proton cpp-options-get-opt

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/qpid-proton/pull/160.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #160


commit ad144301b3ac9fb03f45420344dc5b236654f768
Author: Alan Conway 
Date:   2018-09-26T20:11:56Z

WIP: option version of connection_options getters




---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-proton pull request #150: PROTON-1888: allow configuration of connectio...

[grs]

Github user grs closed the pull request at:

https://github.com/apache/qpid-proton/pull/150


---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

Re: [GitHub] qpid-proton pull request #159: PROTON-1940: [c] normalize encoding of multip...

[Alan Conway]

On Wed, Sep 26, 2018 at 10:38 AM astitcher  wrote:

>
> What is 'multiple="true" field'? There is nothing called this in the
> standard is there?


 Alas there is, which is where the problem started. It is *yet another* way
to represent a variable-length sequence of identically typed values but
with new and redundant encoding options! Here are the proper links, I'll
update the code:

http://docs.oasis-open.org/amqp/core/v1.0/os/amqp-core-types-v1.0-os.html#doc-idp115568
http://docs.oasis-open.org/amqp/core/v1.0/os/amqp-core-types-v1.0-os.html#section-composite-type-representation

I'll write this up properly for the next go-round

The ="true' naming seems to indicate boolean fields, but this is not the
> case afaict - and this really applies to a list of things that can also be
> empty in which case we just use null instead of the empty list.
>

Correct - multiple="true" is part of the XML field definition, which is
part of a composite definition, which is how frames and other stuff are
described. A field with multiple="true" is allowed to be any of: null,
empty array, single value, non-empty array. null and empty array MUST be
treated as equivalent, so must single value and array of length one. All
this redundancy means that some popular AMQP implementations (.NET) don't
properly handle the empty-array case. Now technically that is their bug,
but normalizing the encoding is more efficient anyway, and more likely to
interop generally. Even multiple="false" fields are allowed to be null, so
it's unlikely that anybody will choke on a null field.

Also url to local file system is not very helpful!
>
Doh!

Re: [GitHub] qpid-proton pull request #159: PROTON-1940: [c] normalize encoding of multip...

[Alan Conway]

On Wed, Sep 26, 2018 at 10:38 AM astitcher  wrote:

> Github user astitcher commented on a diff in the pull request:
>
> https://github.com/apache/qpid-proton/pull/159#discussion_r220587685
>
> --- Diff: c/src/core/codec.c ---
> @@ -529,15 +529,15 @@ int pn_data_vfill(pn_data_t *data, const char
> *fmt, va_list ap)
>  case 'd':
>err = pn_data_put_double(data, va_arg(ap, double));
>break;
> -case 'Z':
> +case 'Z':   /* encode binary, must not be NULL */
> --- End diff --
>
> As much as I agree the format letters need documenting I think that
> doing it inline is *not* the right way to do it - IMO a single block
> comment above would be much easier to encompass all the different codes.
>

The inline comments are for the benefit of someone (like me) who is trying
to figure out what the heck vfill does. I'll leave them, but add a block
comment at the top. I don't think we should put this in user doc, it's
marked INTERNAL in the API and I don't think we should encourage its use as
IMO it stinks. I's very hard to read the format strings and it is very easy
to make a mistake. I think it would be much better to have some sequence of
functions, macros or enums with short-but-meaningful names to identify
types, rather than this crazy mini-language of chars. It is vaguely
printf-like, but the codes don't follow any conventions that any C
programmer is likely to understand, so I think emulating printf has
little/no value.

[GitHub] qpid-proton pull request #159: PROTON-1940: [c] normalize encoding of multip...

[astitcher]

Github user astitcher commented on a diff in the pull request:

https://github.com/apache/qpid-proton/pull/159#discussion_r220587685
  
--- Diff: c/src/core/codec.c ---
@@ -529,15 +529,15 @@ int pn_data_vfill(pn_data_t *data, const char *fmt, 
va_list ap)
 case 'd':
   err = pn_data_put_double(data, va_arg(ap, double));
   break;
-case 'Z':
+case 'Z':   /* encode binary, must not be NULL */
--- End diff --

As much as I agree the format letters need documenting I think that doing 
it inline is *not* the right way to do it - IMO a single block comment above 
would be much easier to encompass all the different codes.


---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-proton pull request #:

[alanconway]

Github user alanconway commented on the pull request:


https://github.com/apache/qpid-proton/commit/3dd3bd4913af915d1632fed57c350d76a5cd0ba2#commitcomment-30626748
  
In ruby/lib/core/connection.rb:
In ruby/lib/core/connection.rb on line 117:
Try indenting by 2 spaces when you continue the long line. YARD prefers 
continuations to be indented - it allows them to not be in some cases for 
backwards compat, but if you're having trouble try indenting.


---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-proton pull request #:

[ssorj]

Github user ssorj commented on the pull request:


https://github.com/apache/qpid-proton/commit/3dd3bd4913af915d1632fed57c350d76a5cd0ba2#commitcomment-30626644
  
In ruby/lib/core/connection.rb:
In ruby/lib/core/connection.rb on line 117:
I tried and failed to figure it out last time, so I resorted to the really 
long line ;).  I'll try again.


---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-proton pull request #159: PROTON-1940: [c] normalize encoding of multip...

[alanconway]

GitHub user alanconway opened a pull request:

https://github.com/apache/qpid-proton/pull/159

PROTON-1940: [c] normalize encoding of multiple="true" fields

AMQP spec allows several ways to encode a "multiple" field, we allow all in
incoming data or pn_data_t values created in the user, but when writing
to the wire we always encode:

- empty array as null
- single value array as a single value
- multiple values - encoded as array

This is the most compact encoding and seems to be best for interop, as some 
AMQP
clients (.NET) have trouble with an empty array in a multiple value field.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/alanconway/qpid-proton c-multiple-null

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/qpid-proton/pull/159.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #159


commit 51f4c581411a3295054323028faa59fdb56f4604
Author: Alan Conway 
Date:   2018-09-24T15:41:03Z

PROTON-1940: [c] normalize encoding of multiple="true" fields

AMQP spec allows several ways to encode a "multiple" field, we allow all in
incoming data or pn_data_t values created in the user, but when writing
to the wire we always encode:

- empty array as null
- single value array as a single value
- multiple values - encoded as array

This is the most compact encoding and seems to be best for interop, as some 
AMQP
clients (.NET) have trouble with an empty array in a multiple value field.




---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-proton pull request #158: PROTON-1937: Use value.type() to check for va...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/qpid-proton/pull/158


---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-proton pull request #158: PROTON-1937: Use value.type() to check for va...

[ChugR]

GitHub user ChugR opened a pull request:

https://github.com/apache/qpid-proton/pull/158

PROTON-1937: Use value.type() to check for value presence or absence

This works for me on Fedroa 27 and 28

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ChugR/qpid-proton PROTON-1937

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/qpid-proton/pull/158.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #158


commit ef657e67443e067d9fc74920960e6ce99c65f07c
Author: Chuck Rolke 
Date:   2018-09-21T20:39:33Z

PROTON-1937: Use value.type() to check for value presence or absence




---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-proton pull request #:

[jdanekrh]

Github user jdanekrh commented on the pull request:


https://github.com/apache/qpid-proton/commit/3dd3bd4913af915d1632fed57c350d76a5cd0ba2#commitcomment-30590156
  
In ruby/lib/core/connection.rb:
In ruby/lib/core/connection.rb on line 117:
@ssorj there is overrun line here in doc comment, it causes `file` to 
report different file type than in 0.24 release (now it is ASCII "with very 
long lines"), which causes RPMDiff waring.

Don't know how multiline rdoc comments work in Ruby, but if it is possible, 
maybe it would be worth it to format this more nicely.


---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-proton pull request #157: WIP: extract connection_options_impl for test...

[alanconway]

GitHub user alanconway opened a pull request:

https://github.com/apache/qpid-proton/pull/157

WIP: extract connection_options_impl for tests and internal use



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/alanconway/qpid-proton cpp-connect-config-test

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/qpid-proton/pull/157.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #157


commit d632867fdd2cd4e967395fc82b4edfafb8e32434
Author: Alan Conway 
Date:   2018-09-19T19:24:45Z

WIP: extract connection_options_impl for tests and internal use




---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-proton pull request #156: PROTON-1936: lower case include and updated i...

[marcelmeulemans]

GitHub user marcelmeulemans opened a pull request:

https://github.com/apache/qpid-proton/pull/156

PROTON-1936: lower case include and updated ifdefs



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/marcelmeulemans/qpid-proton feat/PROTON-1936

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/qpid-proton/pull/156.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #156


commit a34bcdbdf03ea8d69a3d1170fb9df9d4130d5e5e
Author: Marcel Meulemans 
Date:   2018-09-17T12:52:08Z

PROTON-1936: lower case include and updated ifdefs




---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-proton pull request #155: PROTON-1846: allow more than 65536 nodes in a...

[marcelmeulemans]

GitHub user marcelmeulemans opened a pull request:

https://github.com/apache/qpid-proton/pull/155

PROTON-1846: allow more than 65536 nodes in a pn_data_t instance



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/marcelmeulemans/qpid-proton fix/PROTON-1846

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/qpid-proton/pull/155.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #155


commit 28f3b60841f3dbe96f81a77c509fd4ec9e571631
Author: Marcel Meulemans 
Date:   2018-09-17T12:15:13Z

PROTON-1846: allow more than 65536 nodes in a pn_data_t instance




---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-proton pull request #:

[alanconway]

Github user alanconway commented on the pull request:


https://github.com/apache/qpid-proton/commit/6275c986902fe2d16cefb1ae860f1d8af3caacd1#commitcomment-30481273
  
In ruby/CMakeLists.txt:
In ruby/CMakeLists.txt on line 44:
On Wed, Sep 12, 2018 at 10:32 AM, Jiří Daněk 
wrote:

> This is ridiculous. Can't we require Modern CMake TM? As defined by
> https://cliutils.gitlab.io/modern-cmake? There are ways to get it, even
> on RHEL, such as SCL, or pip, apparently...
>
I would be in favor of an upgrade, esp. if 3.1 is the miraculous
improvement over 2.8 that the web page claims (the bar is amazingly low)
But I don't volunteer to do the upgrade or deal with the fall-out :)

> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> 
,
> or mute the thread
> 

> .
>



---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-proton pull request #:

[alanconway]

Github user alanconway commented on the pull request:


https://github.com/apache/qpid-proton/commit/6275c986902fe2d16cefb1ae860f1d8af3caacd1#commitcomment-30481157
  
In ruby/CMakeLists.txt:
In ruby/CMakeLists.txt on line 44:
Fixed

Commit 7e3d648e40e1baa76540f0a975bec929c5839350 in qpid-proton's branch
refs/heads/master from Alan Conway

[ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=7e3d648 ]

PROTON-1798 : [cmake]
string(APPEND) is not available in CMake 2.8.12


On Wed, Sep 12, 2018 at 10:27 AM, Alan Conway  wrote:

>
>
> On Wed, Sep 12, 2018 at 10:07 AM, Jiří Daněk 
> wrote:
>
>> On centos/rhel 7:
>>
>> -- The tox tool is not available; skipping the python-tox-tests
>> CMake Error at ruby/CMakeLists.txt:46 (string):
>>   string does not recognize sub-command APPEND
>>
>> —
>>
> Gahh! Did I mention I hate cmake? Who would have thought that appending to
> a string was a revolutionary new feature only available in the latest
> releases!
>
> I'll put it back the way it was.
>
>
>



---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-proton pull request #:

[jdanekrh]

Github user jdanekrh commented on the pull request:


https://github.com/apache/qpid-proton/commit/6275c986902fe2d16cefb1ae860f1d8af3caacd1#commitcomment-30480915
  
In ruby/CMakeLists.txt:
In ruby/CMakeLists.txt on line 44:
This is ridiculous. Can't we require Modern CMake TM? As defined by 
https://cliutils.gitlab.io/modern-cmake? There are ways to get it, even on 
RHEL, such as SCL, or pip, apparently...


---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-proton pull request #:

[alanconway]

Github user alanconway commented on the pull request:


https://github.com/apache/qpid-proton/commit/6275c986902fe2d16cefb1ae860f1d8af3caacd1#commitcomment-30480860
  
In ruby/CMakeLists.txt:
In ruby/CMakeLists.txt on line 44:
On Wed, Sep 12, 2018 at 10:07 AM, Jiří Daněk 
wrote:

> On centos/rhel 7:
>
> -- The tox tool is not available; skipping the python-tox-tests
> CMake Error at ruby/CMakeLists.txt:46 (string):
>   string does not recognize sub-command APPEND
>
> —
>
Gahh! Did I mention I hate cmake? Who would have thought that appending to
a string was a revolutionary new feature only available in the latest
releases!

I'll put it back the way it was.



---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-proton pull request #:

[jdanekrh]

Github user jdanekrh commented on the pull request:


https://github.com/apache/qpid-proton/commit/6275c986902fe2d16cefb1ae860f1d8af3caacd1#commitcomment-30480490
  
In ruby/CMakeLists.txt:
In ruby/CMakeLists.txt on line 44:
On centos/rhel 7:

-- The tox tool is not available; skipping the python-tox-tests
CMake Error at ruby/CMakeLists.txt:46 (string):
  string does not recognize sub-command APPEND


---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-proton pull request #154: Replace user-defined macro WIN32 by compiler-...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/qpid-proton/pull/154


---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-proton pull request #154: Replace user-defined macro WIN32 by compiler-...

[matlo607]

GitHub user matlo607 opened a pull request:

https://github.com/apache/qpid-proton/pull/154

Replace user-defined macro WIN32 by compiler-defined _WIN32

On Windows, if qpid-proton is used by another build system (still compiling 
with VC) than a Visual Studio project, `/D WIN32` is not automatically set on 
the command line.

Today both `WIN32` and `_WIN32` can be found in the source code.

The idea here are:
* removing this uncertainty by using `_WIN32` that is automatically set by 
the compiler
* having a better uniformity across the source code.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/matlo607/qpid-proton replace-WIN32-by-_WIN32

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/qpid-proton/pull/154.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #154


commit ee3484bc506e098932de7963426d71837b98b8a7
Author: Matthieu Longo 
Date:   2018-08-22T13:53:01Z

Replace user-defined macro WIN32 by compiler-defined _WIN32

More information are available at 
https://stackoverflow.com/questions/662084/whats-the-difference-between-the-win32-and-win32-defines-in-c




---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-proton pull request #152: PROTON-1886: Dump the thread's SSL error queu...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/qpid-proton/pull/152


---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-proton pull request #145: Potential chained epoll impl for PROTON-1842

[cliffjansen]

Github user cliffjansen closed the pull request at:

https://github.com/apache/qpid-proton/pull/145


---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-proton pull request #153: support libressl

[archerabi]

Github user archerabi closed the pull request at:

https://github.com/apache/qpid-proton/pull/153


---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-proton pull request #153: support libressl

[archerabi]

GitHub user archerabi opened a pull request:

https://github.com/apache/qpid-proton/pull/153

support libressl



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/better/qpid-proton libressl

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/qpid-proton/pull/153.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #153


commit ceb0523f00caf77b71027abf8d0cabe7133fdcca
Author: Abhijith Reddy 
Date:   2018-08-16T15:02:10Z

support libressl




---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-proton pull request #152: PROTON-1886: Dump the thread's SSL error queu...

[k-wall]

GitHub user k-wall opened a pull request:

https://github.com/apache/qpid-proton/pull/152

PROTON-1886: Dump the thread's SSL error queue in the event that SSL_new 
fails.

Uses the established mechanism to dump the thread's SSL error queue to 
established tracer in the event that SSL_new fails.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/k-wall/qpid-proton master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/qpid-proton/pull/152.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #152


commit f2ae028f534d37abc6856ce21146c70635203628
Author: Keith Wall 
Date:   2018-08-03T09:29:22Z

PROTON-1886: Dump the thread's SSL error queue in the event that SSL_new 
fails.




---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-proton pull request #133: PROTON-1796 branch for automated periodic Cov...

[jdanekrh]

Github user jdanekrh closed the pull request at:

https://github.com/apache/qpid-proton/pull/133


---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-proton pull request #151: Install tests

[alanconway]

GitHub user alanconway opened a pull request:

https://github.com/apache/qpid-proton/pull/151

Install tests

Tests can be executed from install for c, cpp, ruby.

Installed under INSTALL-PREFIX/share/proton-VERSION/examples.
Each examples/ subdir has a stand-alone `testme` script that runs with no 
arguments.

The script assumes that if examples for a language are installed, then 
proton
support and all pre-requisites are also installed either:
  - under the same INSTALL-prefix
  - in standard places (/usr etc.)
  - locatable using standard environment variables (PATH etc.)

Depending on the type of example the testme script may allow args, e.g. -v 
for
verbose output on python-based testme scripts.

To build/run all tests:
cd TEMP-BUILD-DIR
cmake INSTALL-PREFIX/share/proton-VERSION/examples
make
ctest -VV

To run test that don't need separate build, e.g. ruby:
cd INSTALL-PREFIX/share/proton-VERSION/examples ruby; testme

TODO:

python: examples need updating to be usable for self test:
 - servers to print actual port not command-line port
 - test driver to start servers on port 0, pass real port from server 
stdout to client

go: currently an awkward mix of Go native build tools and cmake.
 - make go examples into standard Go executable package.
 - testme script will be simply `GOPATH=... go test 
qpid.apache.org/proton_examples`
 - make examples available via `go get` and on godoc.org


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/alanconway/qpid-proton install-tests

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/qpid-proton/pull/151.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #151


commit 20c016c8d12aa700f0c1874c7f9259f5ad0e6169
Author: Alan Conway 
Date:   2018-07-06T19:06:34Z

NO-JIRA: [c,cpp] Remove dead code in examples/CMakeLists.txt

commit 1244c375a2dfc1042109c84fed38eae3b59c7391
Author: Alan Conway 
Date:   2018-07-09T22:50:27Z

PROTON-1798: [c, cpp, ruby] Installable tests for proton

Tests can be executed from install for c, cpp, ruby.

Installed under INSTALL-PREFIX/share/proton-VERSION/examples.
Each examples/ subdir has a stand-alone `testme` script that runs with no 
arguments.

The script assumes that if examples for a language are installed, then 
proton
support and all pre-requisites are also installed either:
  - under the same INSTALL-prefix
  - in standard places (/usr etc.)
  - locatable using standard environment variables (PATH etc.)

Depending on the type of example the testme script may allow args, e.g. -v 
for
verbose output on python-based testme scripts.

To build/run all tests:
cd TEMP-BUILD-DIR
cmake INSTALL-PREFIX/share/proton-VERSION/examples
make
ctest -VV

To run test that don't need separate build, e.g. ruby:
cd INSTALL-PREFIX/share/proton-VERSION/examples ruby; testme

TODO:

python: examples need updating to be usable for self test:
 - servers to print actual port not command-line port
 - test driver to start servers on port 0, pass real port from server 
stdout to client

go: currently an awkward mix of Go native build tools and cmake.
 - make go examples into standard Go executable package.
 - testme script will be simply `GOPATH=... go test 
qpid.apache.org/proton_examples`
 - make examples available via `go get` and on godoc.org




---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-proton pull request #150: PROTON-1888: allow configuration of connectio...

[grs]

GitHub user grs opened a pull request:

https://github.com/apache/qpid-proton/pull/150

PROTON-1888: allow configuration of connection details from a config …

…file

The file to use can be specified using the CONNECT_CONFIG environment 
variable. If
that is not set, it will look for a file name connect.json, first in the 
current
directory, then in the users local configuration directory 
(~/.config/messaging)
and then in the system config directory (/etc/messaging/)

The config file is in json format and the following properties can be 
specified:

scheme
host
port
sasl_mechanisms
user
password
cert_file
private_key_file
private_key_password
ca_cert_file

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/grs/qpid-proton default_connect_proposal

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/qpid-proton/pull/150.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #150


commit 52f0f270dc40017cdaffba4f9c5e865e2859df4d
Author: Gordon Sim 
Date:   2018-05-16T15:54:19Z

PROTON-1888: allow configuration of connection details from a config file

The file to use can be specified using the CONNECT_CONFIG environment 
variable. If
that is not set, it will look for a file name connect.json, first in the 
current
directory, then in the users local configuration directory 
(~/.config/messaging)
and then in the system config directory (/etc/messaging/)

The config file is in json format and the following properties can be 
specified:

scheme
host
port
sasl_mechanisms
user
password
cert_file
private_key_file
private_key_password
ca_cert_file




---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-proton pull request #148: PROTON-1354: Don't allow SASL mechanisms GSSA...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/qpid-proton/pull/148


---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-proton pull request #149: Do not merge - just testing....

[kgiusti]

Github user kgiusti closed the pull request at:

https://github.com/apache/qpid-proton/pull/149


---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-proton pull request #149: Do not merge - just testing....

[kgiusti]

GitHub user kgiusti opened a pull request:

https://github.com/apache/qpid-proton/pull/149

Do not merge - just testing

Sorry for the noise, please disregard.  I will delete this PR once travis 
is done.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/kgiusti/qpid-proton KAG-TEST-IGNORE

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/qpid-proton/pull/149.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #149


commit dc0bc67426c52505a03687105da0d591ba5a352b
Author: Kenneth Giusti 
Date:   2018-06-13T13:17:42Z

Do not merge - just testing




---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-proton pull request #148: PROTON-1354: Don't allow SASL mechanisms GSSA...

[astitcher]

GitHub user astitcher opened a pull request:

https://github.com/apache/qpid-proton/pull/148

PROTON-1354: Don't allow SASL mechanisms GSSAPI or GSS-SPNEGO by default

Small change that fixes a pain point if you have kerberos on you client 
machine but aren't using it for proton.

The SASL handling is changed so that if you want to use kerberos you now 
need to tell the pn_sasl_allowed_mechs() API on both the client and server that 
you allow GSSAPI and/or GSS-SPNEGO mechanisms (along with any other mechanisms 
you want).

The logic here is that you are very unlikely to want GSSAPI unless you have 
specifically set it up and then you will know that and can allow it 
specifically.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/astitcher/qpid-proton proton-1354

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/qpid-proton/pull/148.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #148


commit bad63dc878856bd9fb657f03eb008cad02f44098
Author: Andrew Stitcher 
Date:   2018-06-12T20:17:42Z

PROTON-1354: Don't allow SASL mechanisms GSSAPI or GSS-SPNEGO by default
- If you want to use these mechanisms they must be explicitly set in the
  allowed mechanisms list for server and client that are connecting




---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-proton pull request #147: NO-JIRA: [cpp] add constants for standard AMQ...

[alanconway]

Github user alanconway closed the pull request at:

https://github.com/apache/qpid-proton/pull/147


---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-proton pull request #147: NO-JIRA: [cpp] add constants for standard AMQ...

[alanconway]

GitHub user alanconway opened a pull request:

https://github.com/apache/qpid-proton/pull/147

NO-JIRA: [cpp] add constants for standard AMQP condition names



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/alanconway/qpid-proton cpp-error-constants

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/qpid-proton/pull/147.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #147


commit 3bd7f7683e3bded074739dce2fd6615743de88ce
Author: Alan Conway 
Date:   2018-06-04T15:18:16Z

NO-JIRA: [cpp] add constants for standard AMQP condition names




---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-proton pull request #146: NO-JIRA: [c] prefer linking with static libra...

[jdanekrh]

GitHub user jdanekrh opened a pull request:

https://github.com/apache/qpid-proton/pull/146

NO-JIRA: [c] prefer linking with static library in fuzz tests



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/jdanekrh/qpid-proton jd_fuzz_use_static_lib

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/qpid-proton/pull/146.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #146


commit e9a78d45af514f44e8eb59dd8bf41dd7ab83b533
Author: Jiri Danek 
Date:   2018-05-31T11:34:09Z

NO-JIRA: [c] prefer linking with static library in fuzz tests




---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-proton pull request #144: Python proactor

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/qpid-proton/pull/144


---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-proton pull request #145: Potential chained epoll impl for PROTON-1842

[cliffjansen]

GitHub user cliffjansen opened a pull request:

https://github.com/apache/qpid-proton/pull/145

Potential chained epoll impl for PROTON-1842

Removes temp fix, adds chained/secondary epollfd_2.

Still has failure in helgrind threaderciser racecheck.  Still unsure if a 
problem or false positive.

Previous temp fix also has the same threaderciser error, so at least not a 
regression.

I have not been able to detect any change in performance with my various 
epoll proactor load tests.

Instrumented runs show the secondary/chained arming occurs about 0.1% in 
proton ctest.  It is closer to 0.001% in dispatch router runs under heavy load, 
but that may be less indicative of the overall frequency.

Chaining is unlikely to occur if socket output does not fill the kernel 
buffer (!EWOULDBLOCK), or if a write event mask is desired as a result of input 
(say a flow event) and EPOLLIN is also necessary with the EPOLLOUT.

Chaining *is* likely to occur if the socket is quiet (i.e. no recent output 
and waiting on EPOLLIN), and the pconnection gets a pn_connection_wake to do 
enough output to fill the kernel output buffer.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/cliffjansen/qpid-proton p1842_1

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/qpid-proton/pull/145.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #145


commit 1f43f37149e56180424ba0434a98d812ed7ebfb7
Author: Cliff Jansen 
Date:   2018-05-23T21:45:56Z

PROTON-1842: revert 79d9019 temporary mitigation for follow-on long term fix

commit ca5c1b55f58aecab5be3c19e14de1d799f92307d
Author: Cliff Jansen 
Date:   2018-05-24T15:46:37Z

PROTON-1842: epoll proactor - add secondary/chained epollfd to maintain 1-1 
count between epoll registrations and eventual callbacks on pconnections




---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-proton pull request #144: Python proactor

[astitcher]

GitHub user astitcher opened a pull request:

https://github.com/apache/qpid-proton/pull/144

Python proactor

This is a fairly large change to the structure of the Proton python binding.
* Initially it removes support for really old versions of python - anything 
before 2.5.
* Then it goes on to split up the monolithic __init__.py file into IMO) 
more manageable pieces.

I've also used this to restrict the usable API to only those bits that are 
supposed to be API (again IMO).

This is the initial work which I'm using as a base for more substantial 
changes, so I will be grateful for any comments and review.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/astitcher/qpid-proton python-proactor

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/qpid-proton/pull/144.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #144


commit 4dcbd1fd456018d0921fec2f14dbb26fdde5b5f2
Author: Andrew Stitcher 
Date:   2018-04-24T14:38:57Z

PROTON-1848: [Python] Remove Python 2.5 and earlier compatibility
- Remove need for most compatibility hacks
- Fix some seemingly odd conversion functions
- Hidden all compatibility code in _compat module, but this
  still uses six to rename Queue->queue
  - could remove this later
  - will probably get rid of raise_ when rewriting reactor
  - can get rid of string_type by doing unicode type hack in reactor.py
  - leaving iteritems & unichr

commit 68e2922584bbe2445303f32cca94cdba04e0fd48
Author: Andrew Stitcher 
Date:   2018-05-02T23:20:38Z

PROTON-1850: Split up proton __init__.py into multiple files
- Make sure that only what we want gets exported from __init__ by 
restricting
  what it imports
- Move most of the reactor implementation specific code into reactor_impl.py




---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-proton pull request #143: NO-JIRA: [c] link fuzzing binaries using CXX ...

[jdanekrh]

GitHub user jdanekrh opened a pull request:

https://github.com/apache/qpid-proton/pull/143

NO-JIRA: [c] link fuzzing binaries using CXX linker

This should allow for removal of patch file 
https://github.com/google/oss-fuzz/blob/1909d92b8bb068dd7aa94bdf22da4028ada385ea/projects/qpid-proton/c_tests_fuzz_CMakeLists.patch

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/jdanekrh/qpid-proton jd_fuzz_cxx_link

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/qpid-proton/pull/143.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #143


commit d33f6d3892f75a893acf3073097767d91c843ba6
Author: Jiri Danek 
Date:   2018-05-15T10:36:49Z

NO-JIRA: [c] link fuzzing binaries using CXX linker




---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-proton pull request #142: PROTON-1831: Incorrect open/close sequence fo...

[alanconway]

GitHub user alanconway opened a pull request:

https://github.com/apache/qpid-proton/pull/142

PROTON-1831: Incorrect open/close sequence for same link name.

Fixes the server side part of PROTON-1831 - transport error if a duplicate 
link
name is attached instead of seg fault.

Client side problem remains: pni_process does not respect the order of 
individual open/close calls,
and it is possible to generate an invalid sequence that attempts a duplicate
attach when it should not. This commit includes a test that illustrates the
problem, the test runs but status is ignored for now.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/alanconway/qpid-proton c-link-open-close

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/qpid-proton/pull/142.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #142


commit 3ac3e22ce343523291d0baa64debc20fe5a3f415
Author: Alan Conway 
Date:   2018-04-20T19:53:26Z

PROTON-1831: Incorrect open/close sequence for same link name.

Fixes the server side part of PROTON-1831 - transport error if a duplicate 
link
name is attached instead of seg fault.

Client side problem remains: pni_process does not respect the order of 
individual open/close calls,
and it is possible to generate an invalid sequence that attempts a duplicate
attach when it should not. This commit includes a test that illustrates the
problem, the test runs but status is ignored for now.




---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-proton pull request #141: [windows] build fails if CMAKE_MODULE_PATH is...

[matlo607]

GitHub user matlo607 opened a pull request:

https://github.com/apache/qpid-proton/pull/141

[windows] build fails if CMAKE_MODULE_PATH is not empty, use 
CMAKE_SOURCE_DIR instead



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/matlo607/qpid-proton 
build-windows-python-script-path

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/qpid-proton/pull/141.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #141


commit 884579dbca93cb32959896776db8839a20534d78
Author: Matthieu Longo 
Date:   2018-04-09T09:33:57Z

[windows] build fails if CMAKE_MODULE_PATH is not empty, use 
CMAKE_SOURCE_DIR instead




---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-proton pull request #132: PROTON-1728: WIP: Reorganize the source tree ...

[ssorj]

Github user ssorj closed the pull request at:

https://github.com/apache/qpid-proton/pull/132


---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-proton pull request #136: WIP - Remove deprecated bindings and APIs

[ssorj]

Github user ssorj closed the pull request at:

https://github.com/apache/qpid-proton/pull/136


---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-proton pull request #138: WIP - Remove obsolete docs and test code

[ssorj]

Github user ssorj closed the pull request at:

https://github.com/apache/qpid-proton/pull/138


---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-proton pull request #140: PROTON-1638, PROTON-1728: Reorganize the sour...

[ssorj]

Github user ssorj closed the pull request at:

https://github.com/apache/qpid-proton/pull/140


---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-proton pull request #137: [cpp] Fix update method missing 'name' variab...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/qpid-proton/pull/137


---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-proton pull request #110: Fix for PROTON-1517

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/qpid-proton/pull/110


---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-proton pull request #95: PROTON-1412 Add fuzzers to proton-c tests

[jdanekrh]

Github user jdanekrh closed the pull request at:

https://github.com/apache/qpid-proton/pull/95


---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-proton pull request #139: PROTON-1787: Pinned the homebrew python versi...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/qpid-proton/pull/139


---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-proton pull request #140: PROTON-1638, PROTON-1728: Reorganize the sour...

[ssorj]

GitHub user ssorj opened a pull request:

https://github.com/apache/qpid-proton/pull/140

PROTON-1638, PROTON-1728: Reorganize the source tree

I plan to squash this on merge.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ssorj/qpid-proton 
ssorj-reorganize-the-source-tree

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/qpid-proton/pull/140.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #140


commit bb53a69334a88a0dbdb11550882b085660e765c7
Author: Justin Ross 
Date:   2017-12-21T14:32:50Z

Remove old docs; some of this content will be restored to new locations

commit 6a0801b08e47f888d5074def67eb65f237e8f884
Author: Justin Ross 
Date:   2017-12-21T17:39:06Z

Rename version.txt to VERSION.txt

commit 4dddef8019633f47f537645440c439d17102f349
Author: Justin Ross 
Date:   2017-12-21T18:00:14Z

Add a .txt extension to LICENSE and NOTICE, for nicer behavior on Windows

commit 654874b7ad62e3e850e4cc15fc7f6fb18d703690
Author: Justin Ross 
Date:   2017-12-21T18:21:29Z

Fixups for file name conventions

commit 7ce68cadcd25e718e87d8aa8241344f1f8ac81b7
Author: Justin Ross 
Date:   2017-12-21T18:29:48Z

Rename tools/py to tools/python to match the other python dirs

commit f36eba5aa4a988fe01432f19415c9878e6f5eec7
Author: Justin Ross 
Date:   2017-12-21T18:33:39Z

Make a space for ancillary files

commit 2beb5236ca6e0647c814a659db8d34bc4e3a1e94
Author: Justin Ross 
Date:   2017-12-21T18:46:30Z

Move the docs dir to the top level

commit 8a457c031132266014bc3b8f524c105d349495b6
Author: Justin Ross 
Date:   2017-12-21T19:06:23Z

Move mllib to live with other python tools

commit f0531db10070e9a37f049f4f629cbd8fbd906add
Author: Justin Ross 
Date:   2017-12-21T20:03:51Z

Move some includes and package configs to the top level

commit 9bc93610f183e26e8c8a0ab9ba3678b15cf110f6
Author: Justin Ross 
Date:   2017-12-21T21:45:08Z

Lift all of proton-c/* to the top level and adjust paths

commit d1b359473f8e4ed899ed564a110866f8437ac68e
Author: Justin Ross 
Date:   2017-12-21T22:29:34Z

Adjust some reacharound paths

commit 2d8f4b87e2a42dacdfe559a1b0530f7e21185398
Author: Justin Ross 
Date:   2017-12-21T22:33:49Z

xproton.py is no longer used

commit 6434aee3d7930555259deb498b1c3dadde16c526
Author: Justin Ross 
Date:   2017-12-21T22:44:03Z

Move env.py with the other scripts in bin/

commit 4117280ca6b0d5eff0e3e6a8ca2818a6ac3c270c
Author: Justin Ross 
Date:   2017-12-21T22:59:24Z

Move tox.ini to misc/

commit 53facd9b7a676c1967983fd1c3ebf693cda46fb8
Author: Justin Ross 
Date:   2017-12-21T23:14:13Z

Move the env config scripts to misc/; adjust the target for tox.ini.in

commit 066afffcdd596613033fb44a14307106df07d0d5
Author: Justin Ross 
Date:   2017-12-21T23:17:51Z

Move soak-check with the other scripts

commit 781e3c9a586f6295ee1d84e363373eb7d22625c7
Author: Justin Ross 
Date:   2017-12-21T23:27:23Z

Remove the C++ reactor app

commit 2baa52785d683b6c4e68e99fd463e96d5d8bec0d
Author: Justin Ross 
Date:   2017-12-21T23:42:29Z

Move the legacy test apps to tools/test-apps/

commit 3864ff36be56c603f556d69918eb0cd17390
Author: Justin Ross 
Date:   2017-12-21T23:46:30Z

Correct some paths I missed

commit 7345c8c9e3174dea64580111e3f6a2cac189d9a9
Author: Justin Ross 
Date:   2017-12-21T23:49:37Z

Rename appveyor.yml to .appveyor.yml

commit b368b2a2b3adb351dfb3264b2a3c495d835d4e9d
Author: Justin Ross 
Date:   2017-12-22T00:07:19Z

Fix a broken path

commit 82f3d53f93da9a53bf9c9b06e5e83fcadd1e056c
Author: Justin Ross 
Date:   2017-12-22T00:26:41Z

Move some of the less frequently used readme files to docs/

commit 4f87c3e5794b98ea0468593821070d2f433a3747
Author: Justin Ross 
Date:   2018-02-14T01:16:15Z

Remove the perl, php, node, and javascript bindings

commit a54afc17b38a4e4719afe286ffb55cc8e7c5e337
Author: Justin Ross 
Date:   2018-02-14T02:31:07Z

Remove the messenger docs

commit 4c7227bd906f4afb44ce61fff7c432df1fb1cd5d
Author: Justin Ross 
Date:   2018-02-14T02:34:40Z

Remove the python messenger API

commit 00e3f95bb83756230a468d67a98ea32c64cd276b
Author: Justin Ross 
Date:   2018-02-14T03:16:19Z

Remove the ruby messenger API

commit b931a410ba77bd49151cce52bbba69d15f1dd3d4
Author: Justin Ross 
Date:   2018-03-06T23:06:36Z

Remove the reactor-based quick_perf

commit 3a1f6c3b2af512f0c3ae01a6f526eb43ce2e45ef
Author: Justin Ross 
Date:   2018-03-06T23:13:35Z

Remove the python 

[GitHub] qpid-proton pull request #139: NO-JIRA: Pinned the homebrew python version t...

[RoddieKieley]

GitHub user RoddieKieley opened a pull request:

https://github.com/apache/qpid-proton/pull/139

NO-JIRA: Pinned the homebrew python version to 2 to stay current with

current change to default of python to python 3 in homebrew.
See associated travis job 
[140](https://travis-ci.org/RoddieKieley/qpid-proton/builds/350289134)

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/RoddieKieley/qpid-proton 
travis-python-specific-version

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/qpid-proton/pull/139.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #139


commit 55b6074caf5646991dd38c88c64b8ddbb383def4
Author: Roddie Kieley 
Date:   2018-03-06T18:01:48Z

NO-JIRA: Pinned the homebrew python version to 2 to stay current with
current change to default of python to python 3 in homebrew.




---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-proton pull request #138: WIP - Remove obsolete docs and test code

[ssorj]

GitHub user ssorj opened a pull request:

https://github.com/apache/qpid-proton/pull/138

WIP - Remove obsolete docs and test code

Part two of the planned source reorg.  This is intended to follow after 
https://github.com/apache/qpid-proton/pull/136 .


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ssorj/qpid-proton 
ssorj-remove-obsolete-docs-and-test-code

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/qpid-proton/pull/138.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #138


commit 93e54946349509d46ea007a67c57c14e14bed517
Author: Justin Ross 
Date:   2018-02-14T01:16:15Z

Remove the perl, php, node, and javascript bindings

commit 1bcd14bbf0bd0b86f4e4e56f0ecb4bf49911aa6d
Author: Justin Ross 
Date:   2018-02-14T02:31:07Z

Remove the messenger docs

commit e72f0260cf60c258ba65060739eab552e519d81a
Author: Justin Ross 
Date:   2018-02-14T02:34:40Z

Remove the python messenger API

commit cc1af07068f0bbc5858e62a3302a4ca7e256c97f
Author: Justin Ross 
Date:   2018-02-14T03:16:19Z

Remove the ruby messenger API

commit 3c2933f0337d9bcf78be8d03ba131f501ec56e75
Author: Justin Ross 
Date:   2017-12-21T23:27:23Z

Remove the C++ reactor app

commit b25c790042ba8682107004d983ddfcc60270196b
Author: Justin Ross 
Date:   2017-12-21T14:32:50Z

Remove old docs; some of this content will be restored to new locations

commit 91641343baa970c1ce6bbe62a36995a9fbcc116d
Author: Justin Ross 
Date:   2017-12-21T22:33:49Z

xproton.py is no longer used

commit 17cd911bf3588bbec44aeacc5744fad765a41824
Author: Justin Ross 
Date:   2018-03-06T23:06:36Z

Remove the reactor-based quick_perf

commit 598a72486c724b75c10c57416d0f3af0a3a83b8d
Author: Justin Ross 
Date:   2018-03-06T23:13:35Z

Remove the python reactor-send impl




---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-proton pull request #137: [cpp] Fix update method missing 'name' variab...

[p32blo]

GitHub user p32blo opened a pull request:

https://github.com/apache/qpid-proton/pull/137

[cpp] Fix update method missing 'name' variable

The `name` property in the sender and receiver is not being updated 
correctly when passed to the `open_sender` and `open_receiver`.

Here is a simple example demonstrating the problem:
```cpp
#include 
#include 
#include 

#include 

int main()
{
proton::container c;

proton::sender_options so;
proton::receiver_options ro;

so.name("qpid");
ro.name("qpid");

proton::sender sender = c.open_sender("", so);
proton::receiver receiver = c.open_receiver("", ro);

std::cout << sender.name() << std::endl;
std::cout << receiver.name() << std::endl;
}
```
The output is currently a random uuid, but it should be "qpid" in both 
cases.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/p32blo/qpid-proton master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/qpid-proton/pull/137.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #137


commit 69a9f91627ccc997337cab5f191f2d1c80ca10f3
Author: André Oliveira 
Date:   2018-03-01T10:15:30Z

[cpp] Fix update method missing 'name' variable




---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-proton pull request #136: WIP - Remove deprecated bindings and APIs

[ssorj]

GitHub user ssorj opened a pull request:

https://github.com/apache/qpid-proton/pull/136

WIP - Remove deprecated bindings and APIs

This is part one of the planned source reorg.

Note that the SSL test coverage may be impacted by the tests removed in 
tests/python/proton_tests/ssl.py (MessengerSSLTests).  I can raise a jira for 
that if we think there is something useful that should be replaced.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ssorj/qpid-proton 
ssorj-remove-deprecated-bindings-and-apis

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/qpid-proton/pull/136.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #136


commit 20a477d8387b32cf73cd3e1cfffef4aac5c71117
Author: Justin Ross 
Date:   2018-02-14T01:16:15Z

Remove the perl, php, node, and javascript bindings

commit 2c77fdda6749c2939446755d20d39e66e7be77ca
Author: Justin Ross 
Date:   2018-02-14T02:31:07Z

Remove the messenger docs

commit 3c620994417880bd35394fb145faf42718aeb3be
Author: Justin Ross 
Date:   2018-02-14T02:34:40Z

Remove the python messenger API

commit b5c5e86292b4bc9fd332c5522051cfab687924e5
Author: Justin Ross 
Date:   2018-02-14T03:16:19Z

Remove the ruby messenger API




---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-proton pull request #134: PROTON-1730: add python version 3.6 to tox te...

[kgiusti]

Github user kgiusti closed the pull request at:

https://github.com/apache/qpid-proton/pull/134


---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-proton pull request #135: PROTON-1732: [OSX] Enable swig for the Travis...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/qpid-proton/pull/135


---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-proton pull request #135: PROTON-1732: [OSX] Enable swig for the Travis...

[astitcher]

Github user astitcher commented on a diff in the pull request:

https://github.com/apache/qpid-proton/pull/135#discussion_r160062571
  
--- Diff: .travis.yml ---
@@ -23,29 +23,37 @@ compiler:
 - gcc
 - clang
 
+env:
+- PIP='pip'
+
 matrix:
   include:
   - os: linux
 env:
 - QPID_PROTON_CMAKE_ARGS='-DCMAKE_BUILD_TYPE=Coverage'
+- PIP='pip'
--- End diff --

I think we may be talking about the opposite case:
- I'm suggesting that this line which part of a specific matrix build is 
not necessary because there is a line in the non matrix case.
- I think you are saying that not having the non matrix line doesn't work. 
I agree with this.


---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-proton pull request #135: PROTON-1732: [OSX] Enable swig for the Travis...

[RoddieKieley]

Github user RoddieKieley commented on a diff in the pull request:

https://github.com/apache/qpid-proton/pull/135#discussion_r160039052
  
--- Diff: .travis.yml ---
@@ -23,29 +23,37 @@ compiler:
 - gcc
 - clang
 
+env:
+- PIP='pip'
+
 matrix:
   include:
   - os: linux
 env:
 - QPID_PROTON_CMAKE_ARGS='-DCMAKE_BUILD_TYPE=Coverage'
+- PIP='pip'
--- End diff --

I didn't have it first and the non matrix'd builds didn't succeed; see 
[buildlog](https://travis-ci.org/RoddieKieley/qpid-proton/jobs/325304860). Was 
there something I missed maybe?


---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-proton pull request #135: PROTON-1732: [OSX] Enable swig for the Travis...

[astitcher]

Github user astitcher commented on a diff in the pull request:

https://github.com/apache/qpid-proton/pull/135#discussion_r159936304
  
--- Diff: .travis.yml ---
@@ -23,29 +23,37 @@ compiler:
 - gcc
 - clang
 
+env:
+- PIP='pip'
+
 matrix:
   include:
   - os: linux
 env:
 - QPID_PROTON_CMAKE_ARGS='-DCMAKE_BUILD_TYPE=Coverage'
+- PIP='pip'
--- End diff --

You don't need this as it is the same as the default above.


---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-proton pull request #135: PROTON-1732: [OSX] Enable swig for the Travis...

[RoddieKieley]

GitHub user RoddieKieley opened a pull request:

https://github.com/apache/qpid-proton/pull/135

PROTON-1732: [OSX] Enable swig for the Travis CI build

Minor update to enable swig for the OSX Travis CI. BUILD_PERL=OFF for the 
moment as it attempts to build i386 and fails on OSX.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/RoddieKieley/qpid-proton PROTON-1732

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/qpid-proton/pull/135.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #135


commit d88d23d0f8c4efcc4722ac5a87baef8e87227903
Author: Roddie Kieley 
Date:   2018-01-04T02:06:26Z

PROTON-1732: [OSX] Enable swig for the Travis CI build




---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-proton pull request #134: PROTON-1730: add python version 3.6 to tox te...

[kgiusti]

GitHub user kgiusti opened a pull request:

https://github.com/apache/qpid-proton/pull/134

PROTON-1730: add python version 3.6 to tox tests



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/kgiusti/qpid-proton PROTON-1730

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/qpid-proton/pull/134.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #134


commit d562b47e2ce932a1135d28099647969ad78ea85f
Author: Kenneth Giusti 
Date:   2018-01-02T16:19:18Z

PROTON-1730: add python version 3.6 to tox tests




---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-proton pull request #133: NO-JIRA branch for automated periodic Coverit...

[jdanekrh]

GitHub user jdanekrh opened a pull request:

https://github.com/apache/qpid-proton/pull/133

NO-JIRA branch for automated periodic Coverity Scan runs

This commit could be added as a new branch. Then, TravisCI can be set up
to build it daily (or weekly).

What it does is that it
1) checks out the current master branch
2) builds it under the Coverity tool
2) submits the build to Coverity Scan

The `COVERITY_SCAN_TOKEN` would need to be replaced with a correct one.

The new branch would need to be created.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/jdanekrh/qpid-proton jd_coverity

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/qpid-proton/pull/133.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #133


commit b2df20e39fb21beabdd976a2a22849a1d4e95949
Author: Jiri Danek 
Date:   2017-12-24T23:05:16Z

NO-JIRA branch for automated periodic Coverity Scan runs

This commit could be added as a new branch. Then, TravisCI can be set up
to build it daily (or weekly).

What it does is that it
1) checks out the current master branch
2) builds it under the Coverity tool
2) submits the build to Coverity Scan

The `COVERITY_SCAN_TOKEN` would need to be replaced with a correct one.




---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-proton pull request #132: PROTON-1728: WIP: Reorganize the source tree ...

[ssorj]

GitHub user ssorj opened a pull request:

https://github.com/apache/qpid-proton/pull/132

PROTON-1728: WIP: Reorganize the source tree and remove deprecated bindings

WIP! For review only.

Note that this doesn't attempt any significant clean up of the cmake logic. 
 I left that for another day.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ssorj/qpid-proton ssorj-source-reorg

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/qpid-proton/pull/132.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #132


commit 4bfffc7562959ff5a91235f77a9a6f5f773c24cc
Author: Justin Ross 
Date:   2017-12-21T14:32:50Z

Remove old docs; some of this content will be restored to new locations

commit dc9f16503abc9dcd2630ef45e0ac977c12e85058
Author: Justin Ross 
Date:   2017-12-21T17:39:06Z

Rename version.txt to VERSION.txt

commit 0fbf1bba3b3a19050f5cbb0240e23b7ed5c81ca8
Author: Justin Ross 
Date:   2017-12-21T18:00:14Z

Add a .txt extension to LICENSE and NOTICE, for nicer behavior on Windows

commit df52a496454bba1d013fc63f489e53334d359256
Author: Justin Ross 
Date:   2017-12-21T18:13:19Z

Remove unused test code

commit a90f8636d7ae7a9a689b361763e21eda846b3ab2
Author: Justin Ross 
Date:   2017-12-21T18:21:29Z

Fixups for file name conventions

commit b87af3b679d3b3c0290e4bebe482500abc0abf09
Author: Justin Ross 
Date:   2017-12-21T18:29:48Z

Rename tools/py to tools/python to match the other python dirs

commit 79089187d426ff393c97bdd4842a5ad1fae771d2
Author: Justin Ross 
Date:   2017-12-21T18:33:39Z

Make a space for ancillary files

commit 3852892c4f677fb02fe2dc2e09c3e7337dcff3da
Author: Justin Ross 
Date:   2017-12-21T18:46:30Z

Move the docs dir to the top level

commit 64bea13516ebf4baf7e406380e3246f26c7cb7e6
Author: Justin Ross 
Date:   2017-12-21T19:06:23Z

Move mllib to live with other python tools

commit 854be9fdd6ab497009310a7922c377c68e763f06
Author: Justin Ross 
Date:   2017-12-21T20:03:51Z

Move some includes and package configs to the top level

commit f6e153d3639c740d5ba607b3a04de6a7ed42574e
Author: Justin Ross 
Date:   2017-12-21T21:45:08Z

Lift all of proton-c/* to the top level and adjust paths

commit 8901f2e2ebd428f177e8c78a55a333e0768a461a
Author: Justin Ross 
Date:   2017-12-21T22:07:26Z

Remove the unmaintained javascript, node, perl, and php bindings

commit b31d2ec9287bc1e1ed588e6c21b53a1fd801f4d0
Author: Justin Ross 
Date:   2017-12-21T22:29:34Z

Adjust some reacharound paths

commit 1695aba83452606ceeb0e3e7ab9435bdb4cd4dd8
Author: Justin Ross 
Date:   2017-12-21T22:33:49Z

xproton.py is no longer used

commit 32338a0644a1cfe8a02489b4b13ae1ad84f55fce
Author: Justin Ross 
Date:   2017-12-21T22:44:03Z

Move env.py with the other scripts in bin/

commit c9d076e8645ed26e3a44bc3cd389ef419d20258f
Author: Justin Ross 
Date:   2017-12-21T22:59:24Z

Move tox.ini to misc/

commit 39c5818b1425dd54bb9779091c8ab94fd0b93b86
Author: Justin Ross 
Date:   2017-12-21T23:03:10Z

Move versions.cmake to src/lib-versions.cmake

commit 9edf75bab8f4f26b2b94bf8b3c65734de56fa6f4
Author: Justin Ross 
Date:   2017-12-21T23:14:13Z

Move the env config scripts to misc/; adjust the target for tox.ini.in

commit ab6550fa23c9d33bc542ab5ae74e1d869bd77318
Author: Justin Ross 
Date:   2017-12-21T23:17:51Z

Move soak-check with the other scripts

commit 618e22aafef560ff5056f85e2d20171370c7f486
Author: Justin Ross 
Date:   2017-12-21T23:27:23Z

Remove the C++ reactor app

commit 586061d038b9d08d1c328ed109398ee14b0934db
Author: Justin Ross 
Date:   2017-12-21T23:42:29Z

Move the legacy test apps to tools/test-apps/

commit 0ac09ee8d9b46169a5936f770d21bdd21e978026
Author: Justin Ross 
Date:   2017-12-21T23:46:30Z

Correct some paths I missed

commit ced4cef433404f1100cfe1b9b6260a2d83e14b9e
Author: Justin Ross 
Date:   2017-12-21T23:49:37Z

Rename appveyor.yml to .appveyor.yml

commit 5d4156d96327d78d6e65c535b9ebc1093a5902a7
Author: Justin Ross 
Date:   2017-12-22T00:02:44Z

Back to just versions.cmake - no need to be overly narrow

commit 038857d8f49a781731eff9397038cc02738acb72
Author: Justin Ross 
Date:   2017-12-22T00:07:19Z

Fix a broken path

commit e397ef25143cd4aa434bfe1de4adc5a486668f1c
Author: Justin Ross 
Date:   2017-12-22T00:26:41Z

Move some of the less frequently used readme files to docs/




---

-
To unsubscribe, e-mail: 

[GitHub] qpid-proton pull request #:

[alanconway]

Github user alanconway commented on the pull request:


https://github.com/apache/qpid-proton/commit/fe9069f9d9f5e27a8c3609eec366517ed8207b20#commitcomment-26254740
  
In tools/py/proctest.py:
In tools/py/proctest.py on line 10:
It was, fixed.



---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-proton pull request #:

[ssorj]

Github user ssorj commented on the pull request:


https://github.com/apache/qpid-proton/commit/fe9069f9d9f5e27a8c3609eec366517ed8207b20#commitcomment-26196677
  
In tools/py/proctest.py:
In tools/py/proctest.py on line 10:
This looks unintended.


---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-proton pull request #127: PROTON-1651 Fix typos found by the spellcheck...

[jdanekrh]

Github user jdanekrh closed the pull request at:

https://github.com/apache/qpid-proton/pull/127


---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-proton pull request #106: Added command line parameters for configure U...

[ppatierno]

Github user ppatierno closed the pull request at:

https://github.com/apache/qpid-proton/pull/106


---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-proton pull request #131: PROTON-1711: SSL_IMPL none SASL_IMPL none bui...

[RoddieKieley]

Github user RoddieKieley closed the pull request at:

https://github.com/apache/qpid-proton/pull/131


---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-proton pull request #131: PROTON-1711: SSL_IMPL none SASL_IMPL none bui...

[RoddieKieley]

GitHub user RoddieKieley opened a pull request:

https://github.com/apache/qpid-proton/pull/131

PROTON-1711: SSL_IMPL none SASL_IMPL none build attempts to build c-s…

…sl-tests and fails

Added simple check to only build c-ssl-tests if SSL_IMPL was not none.

NOTE: This simple change also exposes the fact that the python binding does 
not build with SSL_IMPL none and all other configuration variables default at 
the moment. I disabled the python binding for a successful build as I didn't 
need it at the moment.

Should be addressed here or via separate issue?

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/RoddieKieley/qpid-proton PROTON-1711

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/qpid-proton/pull/131.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #131


commit 84f2ae514606fb69e6f985f911d4a966c20fc75a
Author: circleci 
Date:   2017-12-07T15:28:07Z

PROTON-1711: SSL_IMPL none SASL_IMPL none build attempts to build 
c-ssl-tests and fails

Added simple check to only build c-ssl-tests if SSL_IMPL was not none.




---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-proton pull request #118: PROTON-1326: update python setup.py to avoid ...

[kgiusti]

Github user kgiusti closed the pull request at:

https://github.com/apache/qpid-proton/pull/118


---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-proton pull request #114: [Ruby code Example] fix Messenger package

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/qpid-proton/pull/114


---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-proton pull request #129: PROTON-522: Apache Qpid Proton on Mac/OSX - C...

[RoddieKieley]

Github user RoddieKieley closed the pull request at:

https://github.com/apache/qpid-proton/pull/129


---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-proton pull request #122: update pointer on reallocated message buffer ...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/qpid-proton/pull/122


---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-proton pull request #125: Steps to make openssl.c thread safe, marked w...

[alanconway]

Github user alanconway closed the pull request at:

https://github.com/apache/qpid-proton/pull/125


---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-proton pull request #109: Cpp drop thread safe

[alanconway]

Github user alanconway closed the pull request at:

https://github.com/apache/qpid-proton/pull/109


---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-proton pull request #103: PROTON-1463 GO-Bindings Added AMQP Address Me...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/qpid-proton/pull/103


---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-proton pull request #128: PROTON-1342: CI on OS X

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/qpid-proton/pull/128


---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-proton pull request #130: Add coverage reporting for the Ruby binding

[jdanekrh]

GitHub user jdanekrh opened a pull request:

https://github.com/apache/qpid-proton/pull/130

Add coverage reporting for the Ruby binding



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/jdanekrh/qpid-proton jd_cov_ruby

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/qpid-proton/pull/130.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #130


commit 0633111631fc9e3b43ff19960f7b2bfc1282
Author: Jiri Danek 
Date:   2017-11-17T11:38:34Z

Add coverage reporting for the Ruby binding




---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-proton pull request #:

[astitcher]

Github user astitcher commented on the pull request:


https://github.com/apache/qpid-proton/commit/de3fd617210b5d5a2f2c3e384c33905dbf75ad58#commitcomment-25557336
  
i can see why you might think the way you do. But actually this is not 
correct.

You are assuming that the final string needs to be zero terminated, but 
this is incorrect. This code copies the user name from an incoming zero 
terminated string, and puts it into a SASL ANONYMOUS frame without it being 
terminated. This frame does not use zero terminated strings.

Also note that the original fix was doubly incorrect as it was 
strlen(username+1) *with the +1 inside the strlen* this actually allocates 2 
characters too few from the point of view of your comment.


---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-proton pull request #:

[rudynedved]

Github user rudynedved commented on the pull request:


https://github.com/apache/qpid-proton/commit/de3fd617210b5d5a2f2c3e384c33905dbf75ad58#commitcomment-25551886
  
For clarity, null terminated strings have X non-null characters and 1 null 
character. Therefore the memory for a null terminated string is strlen()+1. A 4 
character value such as "abcd" will require memory for "abcd\0" which on most 
mallocs is 8 bytes.

size = strlen(username+1) makes the username buffer shorter by 1. The 
subsequent malloc for a username of "abcd" will be strlen("bcd") or size 3 when 
what is needed is 4+1 or 5.

The fix is "size = strlen(username) + 1". Coverity is correct.


---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-proton pull request #129: PROTON-522: Apache Qpid Proton on Mac/OSX - C...

[RoddieKieley]

GitHub user RoddieKieley opened a pull request:

https://github.com/apache/qpid-proton/pull/129

PROTON-522: Apache Qpid Proton on Mac/OSX - C/Objective-C

Updates to the code and cmake files to allow successful builds on OSX. 
Tested locally on 10.11.6 with Xcode 7.3.1 for both -G "Unix Makefiles" and -G 
"Xcode". Note that valgrind is disabled for the Xcode generator due to a large 
number of issues there at the moment the still require investigation, however 
the -G "Unix Makefiles" do not exhibit the same valgrind issues.

Also relevant for -G "Xcode" is that by default a Debug build is done and 
tests are run via 'ctest -VV -C Debug' wihch enables the test executables to be 
launched from the 'buildtype' directory rather than the directory itself.

As per the PR for PROTON-1342 there is travis CI configured for the 
PROTON-522 branch over 
[here](https://travis-ci.org/RoddieKieley/qpid-proton/branches).

While the basic build should work well with minimal spurious test failures 
there is remaining work to be done in a number of areas such as cyrus sasl, 
Xcode valgrind, ipv4 vs. ipv6 and port reuse handling in the tests, etc. 

Further enhancements should include obj-c and swift bindings as well as 
native kqueue support.

Feedback encouraged!

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/RoddieKieley/qpid-proton PROTON-522

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/qpid-proton/pull/129.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #129


commit 436c6e239ff1c2a576fd713365890b7ccf7969ca
Author: Roddie Kieley 
Date:   2017-09-10T23:02:00Z

Minimal travis yaml update for osx

commit 0b2351f1edf7138629e880f8cb1f31828664f9cd
Author: Roddie Kieley 
Date:   2017-09-11T00:22:33Z

Added OSX Build of PROTON-522 branch to README.md and updated .travis.yml 
with more osx specifics.

commit 37d916b104a673b7ed717f398c17b265ea19f810
Author: Roddie Kieley 
Date:   2017-09-11T01:43:51Z

Now with openssl and cyrus sasl configured.

commit d531a3c7b076e2620766737ff5bab07851605ee6
Author: Roddie Kieley 
Date:   2017-09-11T02:40:05Z

Disabled osx openssl brew install and added OPENSSL_INCLUDE_DIR as per brew 
location

commit 74cebd1a3297c85bcb9c180e95a147b06c0c1a9f
Author: Roddie Kieley 
Date:   2017-09-12T01:41:35Z

Enabled std=c++11 via CXXFLAGS and disabled thread local for osx as apple 
clang appears to have removed it for xcode 6 and 7 - may need further 
conditionals for later versions.

commit a32c2806e2821f289a4322d3883465dd14363b57
Author: Roddie Kieley 
Date:   2017-09-14T01:32:49Z

Added mutex init for pn_listener_t and pconnection_init as well as mutex 
destroy for pn_listener_t

commit fc3bcd183429e94bafafeb2229cc391b8463baf0
Author: Roddie Kieley 
Date:   2017-09-14T12:26:22Z

Merge branch 'master' into PROTON-522

commit ae3e0cdffc693f9fbaf2b0a696d2fa0c0b884dde
Author: Roddie Kieley 
Date:   2017-09-14T15:40:49Z

Removed pn_incref and pn_decref from pconnection_free to eliminate SEGFAULT 
during reconnect test on OSX.

commit 89b20cebc459abe5111c04bc0a859e7b9b6a6ffd
Author: Roddie Kieley 
Date:   2017-09-15T13:34:43Z

Merge master.

commit de8341028b2fb21189b70e1bb2eedb4dcc62296a
Author: Roddie Kieley 
Date:   2017-09-15T21:45:38Z

Updated the SASL_VERSION_FULL check for sasl_client_done and 
sasl_server_done calls to 020124 as per the release notes here 
amqps://localhost:51524/examples 
/Users/rkieley/LocalProjects/issues/PROTON-522/qpid-proton-roddiekieley/examples/cpp/ssl_certs
 to fix failing cpp-example-container-ssl test on OSX.

commit c65b12e213bb5951b463beb3a1d9b605f907ec5c
Author: Roddie Kieley 
Date:   2017-09-19T01:23:27Z

Potentially incorrect fix to pass test_netaddr by using ipv6 when __APPLE__ 
and ipv4 otherwise.

commit d29cab9b35bb614780e34ff06c3b639c89e672e8
Author: Roddie Kieley 
Date:   2017-09-19T01:34:10Z

Merge branch 'master' into PROTON-522

commit 095a81dcc5e120f674f4f86f3a85e826708653b2
Author: Roddie Kieley 
Date:   2017-09-19T01:43:20Z

Removed the i386 OSX architecture.

commit 68c663950010651e9c60a361eabbd25bc9ff3826
Author: Roddie Kieley 
Date:   2017-09-19T01:59:10Z

Updated travis yaml to remove extraneous echo of QPID_PROTON_CMAKE_ARGS as 
well as now redundant -DCMAKE_OSX_ARCHITECTURES in the cmake command line.

commit 

[GitHub] qpid-proton pull request #128: PROTON-1342: CI on OS X

[RoddieKieley]

GitHub user RoddieKieley opened a pull request:

https://github.com/apache/qpid-proton/pull/128

PROTON-1342: CI on OS X

This contains the travis yaml updates to configure CI to run osx type os's 
as well as matrix'd variants for 10.11-10.13 and Xcode 7.3.1 - Xcode 9 
respectively. 

IMPORTANT: This alone will simply result in failed builds for os: osx, and 
requires the work in PROTON-522 for working os: osx builds. PR to follow.

NOTE: This PR also contains an updated README.md that shows the status of 
the OSX builds on PROTON-522 at the moment.  Please edit as required.

Feedback welcome!

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/RoddieKieley/qpid-proton PROTON-1342

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/qpid-proton/pull/128.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #128


commit 407e1ec34a528c371306b89878e82fd564e7f3f6
Author: Roddie Kieley 
Date:   2017-11-02T02:01:37Z

PROTON-1342: CI on OS X - configured travis matrix with osx_images for 
10.11 10.12 10.13 xcode 7 through 9 SASL_IMPL none PROACTOR libuv

commit 45776bae356cb9d5f436674c7385b7c29a4469f1
Author: Roddie Kieley 
Date:   2017-11-02T14:05:23Z

Testing travis yaml addons.

commit c699a9fc68217774656e9b6f80ce71ffdd7577ab
Author: Roddie Kieley 
Date:   2017-11-02T14:38:09Z

Testing travis yaml addons.

commit 1d013939b47bf1ff200fe7ebdb15df2ef2a616b3
Author: Roddie Kieley 
Date:   2017-11-02T14:42:52Z

Testing travis yaml addons.

commit a5a85c5e5f7d9ce9da783983637e202a7fa31325
Author: Roddie Kieley 
Date:   2017-11-02T14:44:34Z

Testing travis yaml addons.

commit f46cffe23b9a03f08e7aa2c07001fcea73440920
Author: Roddie Kieley 
Date:   2017-11-02T15:33:18Z

Testing travis yaml addons.

commit 39eb86421a111c0ebe85a4d061cc2b4536247d60
Author: Roddie Kieley 
Date:   2017-11-02T16:52:50Z

Testing travis yaml addons.

commit 92d007162c01817e05b802ec523aa6a9b0fa0833
Author: Roddie Kieley 
Date:   2017-11-02T18:44:53Z

PROTON-1342: CI on OS X - Updated README.md with an OSX build status.




---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-proton pull request #124: PROTON-1622 Add coverage analysis into build ...

[jdanekrh]

Github user jdanekrh closed the pull request at:

https://github.com/apache/qpid-proton/pull/124


---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-proton pull request #:

[alanconway]

Github user alanconway commented on the pull request:


https://github.com/apache/qpid-proton/commit/da7f5056a45528196be6733fc56a1f41bda58ded#commitcomment-25161035
  
In tests/python/proton_tests/utils.py:
In tests/python/proton_tests/utils.py on line 180:
Thanks, that test is causing problems in a couple of ways. I've removed it
till I can figure out a more reliable way to do it.

On Tue, Oct 24, 2017 at 1:29 PM, Jiří Daněk 
wrote:

> this has to be except OSError as e, or just except OSError here.
> Otherwise it fails to run on Python 3. https://travis-ci.org/apache/
> qpid-proton/builds/291711488. There is one more instance of this Python 3
> incompatible syntax elsewhere in Proton; it is not running in Tox in
> travis, so it was not caught.
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> 
,
> or mute the thread
> 

> .
>



---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org