[jira] [Commented] (DISPATCH-1409) Update qdstat -l output to include the current credit
[ https://issues.apache.org/jira/browse/DISPATCH-1409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16964313#comment-16964313 ] ASF GitHub Bot commented on DISPATCH-1409: -- codecov-io commented on issue #605: DISPATCH-1409 - Exposed available-credit and time-of-zero-credit as l… URL: https://github.com/apache/qpid-dispatch/pull/605#issuecomment-548513815 # [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/605?src=pr=h1) Report > Merging [#605](https://codecov.io/gh/apache/qpid-dispatch/pull/605?src=pr=desc) into [master](https://codecov.io/gh/apache/qpid-dispatch/commit/37aef86a9ac20f5925de955846dd001de117ed5a?src=pr=desc) will **increase** coverage by `0.02%`. > The diff coverage is `97.43%`. [](https://codecov.io/gh/apache/qpid-dispatch/pull/605?src=pr=tree) ```diff @@Coverage Diff @@ ## master #605 +/- ## == + Coverage 86.42% 86.45% +0.02% == Files 91 91 Lines 2058220620 +38 == + Hits1778917828 +39 + Misses 2793 2792 -1 ``` | [Impacted Files](https://codecov.io/gh/apache/qpid-dispatch/pull/605?src=pr=tree) | Coverage Δ | | |---|---|---| | [src/router\_core/router\_core.c](https://codecov.io/gh/apache/qpid-dispatch/pull/605/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL3JvdXRlcl9jb3JlLmM=) | `86.54% <0%> (-0.17%)` | :arrow_down: | | [...odules/stuck\_delivery\_detection/delivery\_tracker.c](https://codecov.io/gh/apache/qpid-dispatch/pull/605/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL21vZHVsZXMvc3R1Y2tfZGVsaXZlcnlfZGV0ZWN0aW9uL2RlbGl2ZXJ5X3RyYWNrZXIuYw==) | `96.87% <100%> (+0.26%)` | :arrow_up: | | [src/router\_core/forwarder.c](https://codecov.io/gh/apache/qpid-dispatch/pull/605/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL2ZvcndhcmRlci5j) | `93.92% <100%> (+0.02%)` | :arrow_up: | | [src/router\_core/transfer.c](https://codecov.io/gh/apache/qpid-dispatch/pull/605/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL3RyYW5zZmVyLmM=) | `94.02% <100%> (+0.76%)` | :arrow_up: | | [src/router\_core/connections.c](https://codecov.io/gh/apache/qpid-dispatch/pull/605/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL2Nvbm5lY3Rpb25zLmM=) | `93.97% <100%> (-0.12%)` | :arrow_down: | | [src/router\_core/agent\_link.c](https://codecov.io/gh/apache/qpid-dispatch/pull/605/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL2FnZW50X2xpbmsuYw==) | `68.11% <100%> (+0.95%)` | :arrow_up: | | [src/router\_core/agent\_router.c](https://codecov.io/gh/apache/qpid-dispatch/pull/605/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL2FnZW50X3JvdXRlci5j) | `90.8% <100%> (+0.21%)` | :arrow_up: | | [src/router\_node.c](https://codecov.io/gh/apache/qpid-dispatch/pull/605/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9ub2RlLmM=) | `93.09% <100%> (+0.04%)` | :arrow_up: | | [src/message.c](https://codecov.io/gh/apache/qpid-dispatch/pull/605/diff?src=pr=tree#diff-c3JjL21lc3NhZ2UuYw==) | `90.98% <0%> (-0.01%)` | :arrow_down: | | ... and [3 more](https://codecov.io/gh/apache/qpid-dispatch/pull/605/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/605?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/605?src=pr=footer). Last update [37aef86...8498ffc](https://codecov.io/gh/apache/qpid-dispatch/pull/605?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Update qdstat -l output to include the current credit > - > > Key: DISPATCH-1409 > URL: https://issues.apache.org/jira/browse/DISPATCH-1409 > Project: Qpid Dispatch > Issue Type: Improvement > Components: Router Node, Tools >Affects Versions: 1.8.0 >Reporter: Ken Giusti >Assignee: Ted Ross >Priority: Major > Labels: troubleshooting > Fix For: 1.10.0 > > > The (cap) field in the output of qdstat -l shows the
[jira] [Commented] (DISPATCH-1409) Update qdstat -l output to include the current credit
[ https://issues.apache.org/jira/browse/DISPATCH-1409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16964299#comment-16964299 ] ASF GitHub Bot commented on DISPATCH-1409: -- ted-ross commented on pull request #605: DISPATCH-1409 - Exposed available-credit and time-of-zero-credit as l… URL: https://github.com/apache/qpid-dispatch/pull/605 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Update qdstat -l output to include the current credit > - > > Key: DISPATCH-1409 > URL: https://issues.apache.org/jira/browse/DISPATCH-1409 > Project: Qpid Dispatch > Issue Type: Improvement > Components: Router Node, Tools >Affects Versions: 1.8.0 >Reporter: Ken Giusti >Assignee: Ted Ross >Priority: Major > Labels: troubleshooting > > The (cap) field in the output of qdstat -l shows the configured capacity for > the link, not the current credit available/outstanding. > In order to easily detect credit stalls it would be useful to provide the > current credit for the link. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1409) Update qdstat -l output to include the current credit
[ https://issues.apache.org/jira/browse/DISPATCH-1409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16964294#comment-16964294 ] ASF subversion and git services commented on DISPATCH-1409: --- Commit 1837ece08add3cfd1af377be4dfeb3203dc32339 in qpid-dispatch's branch refs/heads/master from Ted Ross [ https://gitbox.apache.org/repos/asf?p=qpid-dispatch.git;h=1837ece ] DISPATCH-1409 - Added test case, fixed accounting bug found by the test case. > Update qdstat -l output to include the current credit > - > > Key: DISPATCH-1409 > URL: https://issues.apache.org/jira/browse/DISPATCH-1409 > Project: Qpid Dispatch > Issue Type: Improvement > Components: Router Node, Tools >Affects Versions: 1.8.0 >Reporter: Ken Giusti >Assignee: Ted Ross >Priority: Major > Labels: troubleshooting > > The (cap) field in the output of qdstat -l shows the configured capacity for > the link, not the current credit available/outstanding. > In order to easily detect credit stalls it would be useful to provide the > current credit for the link. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1409) Update qdstat -l output to include the current credit
[ https://issues.apache.org/jira/browse/DISPATCH-1409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16964295#comment-16964295 ] ASF subversion and git services commented on DISPATCH-1409: --- Commit 7dc31d20eb917678c8fedbd5cd487c5c4f5f6c50 in qpid-dispatch's branch refs/heads/master from Ted Ross [ https://gitbox.apache.org/repos/asf?p=qpid-dispatch.git;h=7dc31d2 ] DISPATCH-1409 - Added a test for sender-link credit. > Update qdstat -l output to include the current credit > - > > Key: DISPATCH-1409 > URL: https://issues.apache.org/jira/browse/DISPATCH-1409 > Project: Qpid Dispatch > Issue Type: Improvement > Components: Router Node, Tools >Affects Versions: 1.8.0 >Reporter: Ken Giusti >Assignee: Ted Ross >Priority: Major > Labels: troubleshooting > > The (cap) field in the output of qdstat -l shows the configured capacity for > the link, not the current credit available/outstanding. > In order to easily detect credit stalls it would be useful to provide the > current credit for the link. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1409) Update qdstat -l output to include the current credit
[ https://issues.apache.org/jira/browse/DISPATCH-1409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16964293#comment-16964293 ] ASF subversion and git services commented on DISPATCH-1409: --- Commit 8fe83b73005c5c1b6322a6b0dad7356672b17f5f in qpid-dispatch's branch refs/heads/master from Ted Ross [ https://gitbox.apache.org/repos/asf?p=qpid-dispatch.git;h=8fe83b7 ] DISPATCH-1409 - Added global metric/gauge for links-blocked. Updated qdstat man page. > Update qdstat -l output to include the current credit > - > > Key: DISPATCH-1409 > URL: https://issues.apache.org/jira/browse/DISPATCH-1409 > Project: Qpid Dispatch > Issue Type: Improvement > Components: Router Node, Tools >Affects Versions: 1.8.0 >Reporter: Ken Giusti >Assignee: Ted Ross >Priority: Major > Labels: troubleshooting > > The (cap) field in the output of qdstat -l shows the configured capacity for > the link, not the current credit available/outstanding. > In order to easily detect credit stalls it would be useful to provide the > current credit for the link. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1409) Update qdstat -l output to include the current credit
[ https://issues.apache.org/jira/browse/DISPATCH-1409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16964292#comment-16964292 ] ASF subversion and git services commented on DISPATCH-1409: --- Commit abda6a8de0d4838cb022e686c35af8471a194f3b in qpid-dispatch's branch refs/heads/master from Ted Ross [ https://gitbox.apache.org/repos/asf?p=qpid-dispatch.git;h=abda6a8 ] DISPATCH-1409 - Reduce the batch size for batched management queries to account for the increased number of attributes in the link entity type. > Update qdstat -l output to include the current credit > - > > Key: DISPATCH-1409 > URL: https://issues.apache.org/jira/browse/DISPATCH-1409 > Project: Qpid Dispatch > Issue Type: Improvement > Components: Router Node, Tools >Affects Versions: 1.8.0 >Reporter: Ken Giusti >Assignee: Ted Ross >Priority: Major > Labels: troubleshooting > > The (cap) field in the output of qdstat -l shows the configured capacity for > the link, not the current credit available/outstanding. > In order to easily detect credit stalls it would be useful to provide the > current credit for the link. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1409) Update qdstat -l output to include the current credit
[ https://issues.apache.org/jira/browse/DISPATCH-1409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16964291#comment-16964291 ] ASF subversion and git services commented on DISPATCH-1409: --- Commit beb89a3d4a355af277f37248dac6bf3ae9733e96 in qpid-dispatch's branch refs/heads/master from Ted Ross [ https://gitbox.apache.org/repos/asf?p=qpid-dispatch.git;h=beb89a3 ] DISPATCH-1409 - Exposed available-credit and time-of-zero-credit as link attributes. Added logging for links that have been stuck with no credit for more than ten seconds. > Update qdstat -l output to include the current credit > - > > Key: DISPATCH-1409 > URL: https://issues.apache.org/jira/browse/DISPATCH-1409 > Project: Qpid Dispatch > Issue Type: Improvement > Components: Router Node, Tools >Affects Versions: 1.8.0 >Reporter: Ken Giusti >Assignee: Ted Ross >Priority: Major > Labels: troubleshooting > > The (cap) field in the output of qdstat -l shows the configured capacity for > the link, not the current credit available/outstanding. > In order to easily detect credit stalls it would be useful to provide the > current credit for the link. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1409) Update qdstat -l output to include the current credit
[ https://issues.apache.org/jira/browse/DISPATCH-1409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16963402#comment-16963402 ] ASF GitHub Bot commented on DISPATCH-1409: -- kgiusti commented on pull request #605: DISPATCH-1409 - Exposed available-credit and time-of-zero-credit as l… URL: https://github.com/apache/qpid-dispatch/pull/605#discussion_r340841820 ## File path: src/router_core/transfer.c ## @@ -262,6 +262,7 @@ void qdr_link_flow(qdr_core_t *core, qdr_link_t *link, int credit, bool drain_mo action->args.connection.drain = drain_mode; qdr_action_enqueue(core, action); +qdr_record_link_credit(core, link); Review comment: Curious - why after the action is enqueued, not before? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Update qdstat -l output to include the current credit > - > > Key: DISPATCH-1409 > URL: https://issues.apache.org/jira/browse/DISPATCH-1409 > Project: Qpid Dispatch > Issue Type: Improvement > Components: Router Node, Tools >Affects Versions: 1.8.0 >Reporter: Ken Giusti >Assignee: Ted Ross >Priority: Major > Labels: troubleshooting > > The (cap) field in the output of qdstat -l shows the configured capacity for > the link, not the current credit available/outstanding. > In order to easily detect credit stalls it would be useful to provide the > current credit for the link. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1409) Update qdstat -l output to include the current credit
[ https://issues.apache.org/jira/browse/DISPATCH-1409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16963165#comment-16963165 ] ASF GitHub Bot commented on DISPATCH-1409: -- ted-ross commented on issue #605: DISPATCH-1409 - Exposed available-credit and time-of-zero-credit as l… URL: https://github.com/apache/qpid-dispatch/pull/605#issuecomment-547980607 I've put this up for review and testing to see if it provides the expected visibility into link credit. I'll add a test shortly. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Update qdstat -l output to include the current credit > - > > Key: DISPATCH-1409 > URL: https://issues.apache.org/jira/browse/DISPATCH-1409 > Project: Qpid Dispatch > Issue Type: Improvement > Components: Router Node, Tools >Affects Versions: 1.8.0 >Reporter: Ken Giusti >Assignee: Ted Ross >Priority: Major > Labels: troubleshooting > > The (cap) field in the output of qdstat -l shows the configured capacity for > the link, not the current credit available/outstanding. > In order to easily detect credit stalls it would be useful to provide the > current credit for the link. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1409) Update qdstat -l output to include the current credit
[ https://issues.apache.org/jira/browse/DISPATCH-1409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16963151#comment-16963151 ] ASF GitHub Bot commented on DISPATCH-1409: -- ted-ross commented on pull request #605: DISPATCH-1409 - Exposed available-credit and time-of-zero-credit as l… URL: https://github.com/apache/qpid-dispatch/pull/605 …ink attributes. Added logging for links that have been stuck with no credit for more than ten seconds. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Update qdstat -l output to include the current credit > - > > Key: DISPATCH-1409 > URL: https://issues.apache.org/jira/browse/DISPATCH-1409 > Project: Qpid Dispatch > Issue Type: Improvement > Components: Router Node, Tools >Affects Versions: 1.8.0 >Reporter: Ken Giusti >Assignee: Ted Ross >Priority: Major > Labels: troubleshooting > > The (cap) field in the output of qdstat -l shows the configured capacity for > the link, not the current credit available/outstanding. > In order to easily detect credit stalls it would be useful to provide the > current credit for the link. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1409) Update qdstat -l output to include the current credit
[ https://issues.apache.org/jira/browse/DISPATCH-1409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16960877#comment-16960877 ] Keith Wall commented on DISPATCH-1409: -- I think a zero credit reached timestamp would need to be exposed. That way, tools consuming the output can distinguish those links that have languished with zero credit for a long time and may signify a problem in either application or router network itself. > Update qdstat -l output to include the current credit > - > > Key: DISPATCH-1409 > URL: https://issues.apache.org/jira/browse/DISPATCH-1409 > Project: Qpid Dispatch > Issue Type: Improvement > Components: Router Node, Tools >Affects Versions: 1.8.0 >Reporter: Ken Giusti >Priority: Major > Labels: troubleshooting > > The (cap) field in the output of qdstat -l shows the configured capacity for > the link, not the current credit available/outstanding. > In order to easily detect credit stalls it would be useful to provide the > current credit for the link. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
