[jira] [Commented] (PROTON-1533) Swig deprecation warnings with recent versions of cmake

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/PROTON-1533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16120201#comment-16120201
 ] 

ASF GitHub Bot commented on PROTON-1533:


Github user ssorj closed the pull request at:

https://github.com/apache/qpid-proton/pull/115


> Swig deprecation warnings with recent versions of cmake
> ---
>
> Key: PROTON-1533
> URL: https://issues.apache.org/jira/browse/PROTON-1533
> Project: Qpid Proton
>  Issue Type: Bug
>  Components: build
> Environment: Fedora 25, 26
> Cmake 3.8+
>Reporter: Justin Ross
>Assignee: Justin Ross
>Priority: Minor
> Fix For: proton-c-0.18.0
>
>
> Same output as described in https://issues.apache.org/jira/browse/QPID-7860



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (PROTON-1533) Swig deprecation warnings with recent versions of cmake

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/PROTON-1533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16120196#comment-16120196
 ] 

ASF subversion and git services commented on PROTON-1533:
-

Commit bdac005a999ffded075eafc61877515edf236b38 in qpid-proton's branch 
refs/heads/master from [~jr...@redhat.com]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=bdac005 ]

PROTON-1533: Fix swig deprecation warnings


> Swig deprecation warnings with recent versions of cmake
> ---
>
> Key: PROTON-1533
> URL: https://issues.apache.org/jira/browse/PROTON-1533
> Project: Qpid Proton
>  Issue Type: Bug
>  Components: build
> Environment: Fedora 25, 26
> Cmake 3.8+
>Reporter: Justin Ross
>Assignee: Justin Ross
>Priority: Minor
> Fix For: proton-c-0.18.0
>
>
> Same output as described in https://issues.apache.org/jira/browse/QPID-7860



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (PROTON-1533) Swig deprecation warnings with recent versions of cmake

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/PROTON-1533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16120120#comment-16120120
 ] 

ASF GitHub Bot commented on PROTON-1533:


Github user astitcher commented on a diff in the pull request:

https://github.com/apache/qpid-proton/pull/115#discussion_r132225370
  
--- Diff: proton-c/bindings/php/CMakeLists.txt ---
@@ -34,7 +34,7 @@ list(APPEND SWIG_MODULE_cproton_EXTRA_DEPS
 ${CMAKE_SOURCE_DIR}/proton-c/include/proton/cproton.i
 ${PROTON_HEADERS}
 )
-swig_add_module(cproton php ${CMAKE_CURRENT_SOURCE_DIR}/php.i)
+swig_add_library(cproton LANGUAGE php SOURCES 
${CMAKE_CURRENT_SOURCE_DIR}/php.i)
--- End diff --

Not directly related to your change, but I think the 
${CMAKE_CURRENT_SOURCE_DIR} is extraneous here and is different from all the 
other uses of swig_add_library in the other bindings.


> Swig deprecation warnings with recent versions of cmake
> ---
>
> Key: PROTON-1533
> URL: https://issues.apache.org/jira/browse/PROTON-1533
> Project: Qpid Proton
>  Issue Type: Bug
>  Components: build
> Environment: Fedora 25, 26
> Cmake 3.8+
>Reporter: Justin Ross
>Assignee: Justin Ross
>Priority: Minor
> Fix For: proton-c-0.18.0
>
>
> Same output as described in https://issues.apache.org/jira/browse/QPID-7860



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (PROTON-1533) Swig deprecation warnings with recent versions of cmake

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/PROTON-1533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16119815#comment-16119815
 ] 

ASF GitHub Bot commented on PROTON-1533:


GitHub user ssorj opened a pull request:

https://github.com/apache/qpid-proton/pull/115

PROTON-1533: Fix swig deprecation warnings

For review

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ssorj/qpid-proton master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/qpid-proton/pull/115.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #115


commit 7fa4bf7be0f7e5cf6e43683a3294675df908f46c
Author: Justin Ross 
Date:   2017-08-08T23:49:31Z

Use swig_add_library instead of the now deprecated swig_add_module; provide 
a fallback impl

commit 5c2b1529e610171172565eb802cec8102a9e48be
Author: Justin Ross 
Date:   2017-08-09T00:07:42Z

Correct a cmake test expression

commit 04c07670a445ceb7188a56070c5141e8bded56a0
Author: Justin Ross 
Date:   2017-08-09T12:02:24Z

Remove extraneous macro definition




> Swig deprecation warnings with recent versions of cmake
> ---
>
> Key: PROTON-1533
> URL: https://issues.apache.org/jira/browse/PROTON-1533
> Project: Qpid Proton
>  Issue Type: Bug
>  Components: build
> Environment: Fedora 25, 26
> Cmake 3.8+
>Reporter: Justin Ross
>Assignee: Justin Ross
>Priority: Minor
> Fix For: proton-c-0.18.0
>
>
> Same output as described in https://issues.apache.org/jira/browse/QPID-7860



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org