Github user Terranlee commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/229#discussion_r110910643
--- Diff: parser/SqlParser.ypp ---
@@ -1198,23 +1211,49 @@ with_list_element:
$$->set_table_reference_signature($1);
};
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/229#discussion_r110817047
--- Diff: parser/SqlParser.ypp ---
@@ -1198,23 +1211,49 @@ with_list_element:
$$->set_table_reference_signature($1);
};
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-quickstep/pull/229
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/229#discussion_r110511246
--- Diff: parser/SqlParser.ypp ---
@@ -676,7 +686,7 @@ sql_statement:
| quit_statement {
$$ = $1;
}
- |
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/229#discussion_r110300377
--- Diff: parser/tests/SetOperation.test ---
@@ -0,0 +1,38 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/229#discussion_r110304313
--- Diff: query_optimizer/resolver/Resolver.cpp ---
@@ -1350,16 +1351,172 @@ L::LogicalPtr Resolver::resolveSelect(
return logical_plan;
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/229#discussion_r110295303
--- Diff: parser/ParseSetOperation.hpp ---
@@ -0,0 +1,136 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/229#discussion_r110304131
--- Diff: query_optimizer/resolver/Resolver.cpp ---
@@ -1350,16 +1351,172 @@ L::LogicalPtr Resolver::resolveSelect(
return logical_plan;
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/229#discussion_r110303184
--- Diff: query_optimizer/resolver/Resolver.cpp ---
@@ -372,23 +373,23 @@ L::LogicalPtr Resolver::resolve(const ParseStatement
_query) {
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/229#discussion_r110305172
--- Diff: query_optimizer/resolver/Resolver.hpp ---
@@ -183,6 +184,24 @@ class Resolver {
const NameResolver *parent_resolver);
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/229#discussion_r110303831
--- Diff: query_optimizer/resolver/Resolver.cpp ---
@@ -1350,16 +1351,172 @@ L::LogicalPtr Resolver::resolveSelect(
return logical_plan;
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/229#discussion_r110295083
--- Diff: parser/ParseSetOperation.hpp ---
@@ -0,0 +1,136 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/229#discussion_r110305426
--- Diff: query_optimizer/resolver/Resolver.cpp ---
@@ -1350,16 +1351,172 @@ L::LogicalPtr Resolver::resolveSelect(
return logical_plan;
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/229#discussion_r110295617
--- Diff: parser/ParseStatement.hpp ---
@@ -479,49 +480,49 @@ class ParseStatementDropTable : public ParseStatement
{
};
/**
-
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/229#discussion_r110300461
--- Diff: query_optimizer/LogicalGenerator.cpp ---
@@ -51,12 +51,12 @@ L::LogicalPtr LogicalGenerator::generatePlan(
const CatalogDatabase
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/229#discussion_r110302971
--- Diff: query_optimizer/logical/SetOperation.hpp ---
@@ -0,0 +1,182 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/229#discussion_r110303143
--- Diff: query_optimizer/resolver/Resolver.cpp ---
@@ -372,23 +373,23 @@ L::LogicalPtr Resolver::resolve(const ParseStatement
_query) {
GitHub user Terranlee opened a pull request:
https://github.com/apache/incubator-quickstep/pull/229
Implement parser and resolver for UNION and INTERSECT operators
This pull request implements the parser and resolver parts of set
operations (`UNION` and `INTERSECT`).
It
18 matches
Mail list logo
