Github user asfgit closed the pull request at:
https://github.com/apache/incubator-quickstep/pull/232
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user cramja commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/232#discussion_r113040305
--- Diff: CMakeLists.txt ---
@@ -145,6 +145,7 @@ if (ENABLE_VECTOR_PREDICATE_SHORT_CIRCUIT)
)
endif()
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/232#discussion_r112842721
--- Diff: cli/NetworkIO.hpp ---
@@ -0,0 +1,286 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/232#discussion_r112842641
--- Diff: cli/Flags.cpp ---
@@ -87,4 +87,25 @@ DEFINE_bool(preload_buffer_pool, false,
"accepting queries (should also set
Github user cramja commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/232#discussion_r112837404
--- Diff: cli/NetworkIO.hpp ---
@@ -0,0 +1,286 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more
Github user cramja commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/232#discussion_r112836758
--- Diff: cli/NetworkIO.hpp ---
@@ -0,0 +1,286 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more
Github user cramja commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/232#discussion_r112836622
--- Diff: cli/NetworkCliClientMain.cpp ---
@@ -0,0 +1,62 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ *
Github user cramja commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/232#discussion_r112836342
--- Diff: cli/IOInterface.hpp ---
@@ -0,0 +1,82 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more
Github user cramja commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/232#discussion_r112836146
--- Diff: cli/IOInterface.hpp ---
@@ -0,0 +1,82 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more
Github user cramja commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/232#discussion_r112836065
--- Diff: cli/CMakeLists.txt ---
@@ -15,7 +15,6 @@
# specific language governing permissions and limitations
# under the License.
Github user cramja commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/232#discussion_r112835877
--- Diff: cli/Flags.cpp ---
@@ -87,4 +87,25 @@ DEFINE_bool(preload_buffer_pool, false,
"accepting queries (should also set
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/232#discussion_r112819466
--- Diff: cli/IOInterface.hpp ---
@@ -0,0 +1,82 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/232#discussion_r112825369
--- Diff: cli/CMakeLists.txt ---
@@ -176,5 +249,14 @@ target_link_libraries(quickstep_cli
quickstep_cli_DropRelation
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/232#discussion_r112819579
--- Diff: cli/NetworkIO.hpp ---
@@ -0,0 +1,286 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/232#discussion_r112819551
--- Diff: cli/NetworkCliClientMain.cpp ---
@@ -0,0 +1,62 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/232#discussion_r112819636
--- Diff: cli/NetworkIO.hpp ---
@@ -0,0 +1,286 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/232#discussion_r112819680
--- Diff: cli/NetworkIO.hpp ---
@@ -0,0 +1,286 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/232#discussion_r112825394
--- Diff: cli/LineReaderBuffered.hpp ---
@@ -0,0 +1,75 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/232#discussion_r112819449
--- Diff: cli/CMakeLists.txt ---
@@ -15,7 +15,6 @@
# specific language governing permissions and limitations
# under the License.
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/232#discussion_r112819559
--- Diff: cli/NetworkCliClientMain.cpp ---
@@ -0,0 +1,62 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/232#discussion_r112819627
--- Diff: cli/NetworkIO.hpp ---
@@ -0,0 +1,286 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/232#discussion_r112819491
--- Diff: cli/LocalIO.hpp ---
@@ -0,0 +1,88 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/232#discussion_r112819528
--- Diff: cli/LocalIO.hpp ---
@@ -0,0 +1,88 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/232#discussion_r112819487
--- Diff: cli/LocalIO.hpp ---
@@ -0,0 +1,88 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/232#discussion_r112819541
--- Diff: cli/LocalIO.hpp ---
@@ -0,0 +1,88 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/232#discussion_r112797758
--- Diff: CMakeLists.txt ---
@@ -145,6 +145,7 @@ if (ENABLE_VECTOR_PREDICATE_SHORT_CIRCUIT)
)
endif()
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/232#discussion_r112790553
--- Diff: cli/NetworkCliClient.hpp ---
@@ -0,0 +1,91 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more
Github user cramja commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/232#discussion_r112787479
--- Diff: cli/NetworkCliClient.hpp ---
@@ -0,0 +1,91 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or
Github user cramja commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/232#discussion_r112686604
--- Diff: CMakeLists.txt ---
@@ -145,6 +145,7 @@ if (ENABLE_VECTOR_PREDICATE_SHORT_CIRCUIT)
)
endif()
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/232#discussion_r112549415
--- Diff: cli/tests/NetworkIO_unittest.cpp ---
@@ -0,0 +1,182 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/232#discussion_r112418012
--- Diff: cli/NetworkIO.hpp ---
@@ -0,0 +1,227 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/232#discussion_r112409077
--- Diff: cli/NetworkCliClient.hpp ---
@@ -0,0 +1,91 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/232#discussion_r112548998
--- Diff: cli/tests/NetworkIO_unittest.cpp ---
@@ -0,0 +1,182 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/232#discussion_r112547224
--- Diff: cli/NetworkIO.hpp ---
@@ -0,0 +1,227 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/232#discussion_r112417791
--- Diff: cli/tests/NetworkIO_unittest.cpp ---
@@ -0,0 +1,182 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/232#discussion_r112417078
--- Diff: cli/NetworkIO.hpp ---
@@ -0,0 +1,227 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/232#discussion_r112548566
--- Diff: cli/tests/NetworkIO_unittest.cpp ---
@@ -0,0 +1,182 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/232#discussion_r112417374
--- Diff: cli/NetworkIO.hpp ---
@@ -0,0 +1,227 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/232#discussion_r112417941
--- Diff: cli/NetworkIO.hpp ---
@@ -0,0 +1,227 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/232#discussion_r112547359
--- Diff: cli/QuickstepCli.cpp ---
@@ -28,26 +28,23 @@
#include
#include
-#include "cli/CliConfig.h" // For
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/232#discussion_r112417234
--- Diff: cli/NetworkIO.hpp ---
@@ -0,0 +1,227 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/232#discussion_r112549890
--- Diff: cli/tests/NetworkIO_unittest.cpp ---
@@ -0,0 +1,182 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/232#discussion_r112404840
--- Diff: cli/IOInterface.hpp ---
@@ -0,0 +1,62 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/232#discussion_r112417113
--- Diff: cli/NetworkIO.hpp ---
@@ -0,0 +1,227 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/232#discussion_r112411604
--- Diff: cli/NetworkCliClientMain.cpp ---
@@ -0,0 +1,62 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/232#discussion_r112549264
--- Diff: cli/tests/NetworkIO_unittest.cpp ---
@@ -0,0 +1,182 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/232#discussion_r112550617
--- Diff: cli/tests/NetworkIO_unittest.cpp ---
@@ -0,0 +1,182 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/232#discussion_r112403533
--- Diff: CMakeLists.txt ---
@@ -145,6 +145,7 @@ if (ENABLE_VECTOR_PREDICATE_SHORT_CIRCUIT)
)
endif()
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/232#discussion_r112406197
--- Diff: cli/LineReaderBuffered.cpp ---
@@ -0,0 +1,39 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/232#discussion_r112406425
--- Diff: cli/LineReaderBuffered.hpp ---
@@ -0,0 +1,73 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/232#discussion_r112404491
--- Diff: cli/Flags.cpp ---
@@ -87,4 +87,18 @@ DEFINE_bool(preload_buffer_pool, false,
"accepting queries (should also set
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/232#discussion_r112548387
--- Diff: cli/tests/NetworkIO_unittest.cpp ---
@@ -0,0 +1,182 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/232#discussion_r112405059
--- Diff: cli/IOInterface.hpp ---
@@ -0,0 +1,62 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/232#discussion_r112405717
--- Diff: cli/IOInterface.hpp ---
@@ -0,0 +1,62 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/232#discussion_r112407163
--- Diff: cli/LineReaderBuffered.hpp ---
@@ -0,0 +1,73 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/232#discussion_r112406932
--- Diff: cli/LocalIO.hpp ---
@@ -0,0 +1,74 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/232#discussion_r112407922
--- Diff: cli/NetworkCliClient.hpp ---
@@ -0,0 +1,91 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/232#discussion_r112411238
--- Diff: cli/NetworkCliClientMain.cpp ---
@@ -0,0 +1,62 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/232#discussion_r112407047
--- Diff: cli/LocalIO.hpp ---
@@ -0,0 +1,74 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/232#discussion_r112407627
--- Diff: cli/NetworkCliClient.hpp ---
@@ -0,0 +1,91 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/232#discussion_r112406128
--- Diff: cli/LineReaderBuffered.cpp ---
@@ -0,0 +1,39 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or
Github user cramja commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/232#discussion_r112325082
--- Diff: cli/LineReaderBuffered.hpp ---
@@ -0,0 +1,70 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or
Github user cramja commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/232#discussion_r112324538
--- Diff: cli/LineReaderBuffered.hpp ---
@@ -0,0 +1,70 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or
Github user cramja commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/232#discussion_r112324457
--- Diff: cli/LineReaderBuffered.cpp ---
@@ -0,0 +1,67 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or
Github user cramja commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/232#discussion_r112323095
--- Diff: cli/LineReaderBuffered.cpp ---
@@ -0,0 +1,67 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or
Github user cramja commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/232#discussion_r112322839
--- Diff: cli/IOInterface.hpp ---
@@ -0,0 +1,61 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more
Github user hbdeshmukh commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/232#discussion_r112250274
--- Diff: cli/LineReaderBuffered.cpp ---
@@ -0,0 +1,67 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ *
Github user hbdeshmukh commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/232#discussion_r112250845
--- Diff: cli/LineReaderBuffered.hpp ---
@@ -0,0 +1,70 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ *
Github user hbdeshmukh commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/232#discussion_r112249998
--- Diff: cli/IOInterface.hpp ---
@@ -0,0 +1,61 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or
Github user hbdeshmukh commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/232#discussion_r112250621
--- Diff: cli/LineReaderBuffered.hpp ---
@@ -0,0 +1,70 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ *
Github user hbdeshmukh commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/232#discussion_r112249915
--- Diff: cli/IOInterface.hpp ---
@@ -0,0 +1,61 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or
Github user hbdeshmukh commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/232#discussion_r112249411
--- Diff: cli/IOInterface.hpp ---
@@ -0,0 +1,61 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or
Github user hbdeshmukh commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/232#discussion_r112249378
--- Diff: cli/IOInterface.hpp ---
@@ -0,0 +1,61 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or
Github user hbdeshmukh commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/232#discussion_r112249266
--- Diff: cli/IOInterface.hpp ---
@@ -0,0 +1,61 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or
Github user hbdeshmukh commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/232#discussion_r112248871
--- Diff: cli/Flags.cpp ---
@@ -87,4 +87,15 @@ DEFINE_bool(preload_buffer_pool, false,
"accepting queries (should also set
75 matches
Mail list logo
