[jira] [Updated] (RANGER-2238) String comparison should not use ‘==’ in ServiceUtil.java

2018-10-07 Thread Qiang Zhang (JIRA)
[ https://issues.apache.org/jira/browse/RANGER-2238?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Qiang Zhang updated RANGER-2238: Attachment: (was: 0001-RANGER-2238-String-comparison-should-not-use-in-Serv.patch) > String

[jira] [Updated] (RANGER-2238) String comparison should not use ‘==’ in ServiceUtil.java

2018-10-07 Thread Qiang Zhang (JIRA)
[ https://issues.apache.org/jira/browse/RANGER-2238?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Qiang Zhang updated RANGER-2238: Attachment: 0001-RANGER-2238-String-comparison-should-not-use-in-Serv.patch > String comparison

Re: Review Request 68881: RANGER-2203: Review and update database schema for ranger policies to minimize database queries/updates

2018-10-07 Thread Madhan Neethiraj
> On Oct. 7, 2018, 10:28 p.m., Madhan Neethiraj wrote: > > agents-common/src/main/java/org/apache/ranger/plugin/store/TagStore.java > > Lines 87 (patched) > > > > > > updateTagsInServiceResource(resourceId) method

Re: Review Request 68864: RANGER-2237 Upgrade Kylin version to 2.5.0

2018-10-07 Thread Qiang Zhang
> On 十月 2, 2018, 4:41 p.m., Velmurugan Periasamy wrote: > > pom.xml > > Line 191 (original), 191 (patched) > > > > > > This patch does not apply. Could you please rebase? > > > > ``` > > $ git apply

Re: Review Request 68871: RANGER-2238 String comparison should not use ‘==’ in ServiceUtil.java

2018-10-07 Thread Qiang Zhang
> On 十月 2, 2018, 3:55 p.m., Velmurugan Periasamy wrote: > > security-admin/src/main/java/org/apache/ranger/common/ServiceUtil.java > > Line 859 (original), 859 (patched) > > > > > > Better to use equalsIgnoreCase ?

Re: Review Request 68871: RANGER-2238 String comparison should not use ‘==’ in ServiceUtil.java

2018-10-07 Thread Qiang Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68871/ --- (Updated 十月 8, 2018, 2:08 a.m.) Review request for ranger, Ankita Sinha, Don

Re: Review Request 68881: RANGER-2203: Review and update database schema for ranger policies to minimize database queries/updates

2018-10-07 Thread Abhay Kulkarni
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68881/ --- (Updated Oct. 8, 2018, 2:07 a.m.) Review request for ranger, Madhan Neethiraj,

[jira] [Updated] (RANGER-2237) Upgrade Kylin version to 2.5.0

2018-10-07 Thread Qiang Zhang (JIRA)
[ https://issues.apache.org/jira/browse/RANGER-2237?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Qiang Zhang updated RANGER-2237: Attachment: 0001-RANGER-2237-Upgrade-Kylin-version-to-2.5.0.patch > Upgrade Kylin version to

[jira] [Updated] (RANGER-2237) Upgrade Kylin version to 2.5.0

2018-10-07 Thread Qiang Zhang (JIRA)
[ https://issues.apache.org/jira/browse/RANGER-2237?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Qiang Zhang updated RANGER-2237: Attachment: (was: 0001-RANGER-2237-Upgrade-Kylin-version-to-2.5.0.patch) > Upgrade Kylin

Re: Review Request 68864: RANGER-2237 Upgrade Kylin version to 2.5.0

2018-10-07 Thread Qiang Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68864/ --- (Updated 十月 8, 2018, 1:51 a.m.) Review request for ranger, Ankita Sinha, Don

Re: Review Request 68881: RANGER-2203: Review and update database schema for ranger policies to minimize database queries/updates

2018-10-07 Thread Madhan Neethiraj
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68881/#review209275 ---