Re: Review Request 65920: Ranger Tagsync should use cookie based authentication for subsequent requests to Ranger admin

2018-03-14 Thread Velmurugan Periasamy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65920/#review199164 --- Ship it! Ship It! - Velmurugan Periasamy On March 14, 2018,

Re: Review Request 65920: Ranger Tagsync should use cookie based authentication for subsequent requests to Ranger admin

2018-03-14 Thread Madhan Neethiraj
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65920/#review199154 --- Ship it! Ship It! - Madhan Neethiraj On March 14, 2018,

Re: Review Request 65920: Ranger Tagsync should use cookie based authentication for subsequent requests to Ranger admin

2018-03-14 Thread Nikhil P
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65920/ --- (Updated March 14, 2018, 12:01 p.m.) Review request for ranger, Ankita Sinha,

Re: Review Request 65920: Ranger Tagsync should use cookie based authentication for subsequent requests to Ranger admin

2018-03-13 Thread Madhan Neethiraj
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65920/#review199151 --- Fix it, then Ship it!

Re: Review Request 65920: Ranger Tagsync should use cookie based authentication for subsequent requests to Ranger admin

2018-03-12 Thread Ramesh Mani
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65920/#review199028 ---

Re: Review Request 65920: Ranger Tagsync should use cookie based authentication for subsequent requests to Ranger admin

2018-03-12 Thread Nikhil P
> On March 12, 2018, 12:51 p.m., Madhan Neethiraj wrote: > > tagsync/src/main/java/org/apache/ranger/tagsync/sink/tagadmin/TagAdminRESTSink.java > > Lines 328 (patched) > > > > > > when would 'response' not contain

Re: Review Request 65920: Ranger Tagsync should use cookie based authentication for subsequent requests to Ranger admin

2018-03-12 Thread Nikhil P
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65920/ --- (Updated March 12, 2018, 3:46 p.m.) Review request for ranger, Ankita Sinha,

Re: Review Request 65920: Ranger Tagsync should use cookie based authentication for subsequent requests to Ranger admin

2018-03-12 Thread Madhan Neethiraj
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65920/#review199004 ---

Re: Review Request 65920: Ranger Tagsync should use cookie based authentication for subsequent requests to Ranger admin

2018-03-12 Thread Gautam Borad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65920/#review199005 --- Ship it! Ship It! - Gautam Borad On March 9, 2018, 4:35

Re: Review Request 65920: Ranger Tagsync should use cookie based authentication for subsequent requests to Ranger admin

2018-03-09 Thread Nikhil P
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65920/ --- (Updated March 9, 2018, 10:05 p.m.) Review request for ranger, Ankita Sinha,

Re: Review Request 65920: Ranger Tagsync should use cookie based authentication for subsequent requests to Ranger admin

2018-03-09 Thread Nikhil P
> On March 6, 2018, 9:49 p.m., Zsombor Gegesy wrote: > > tagsync/src/main/java/org/apache/ranger/tagsync/sink/tagadmin/TagAdminRESTSink.java > > Lines 267 (patched) > > > > > > Instead of relying on an external

Re: Review Request 65920: Ranger Tagsync should use cookie based authentication for subsequent requests to Ranger admin

2018-03-06 Thread Zsombor Gegesy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65920/#review198707 --- And one question, why there is a uploadTagsWithCredUnSync ? It's