Re: Review Request 60192: Proxying Ranger UI does not work with Ranger-KnoxSSO

2017-06-25 Thread Mehul Parikh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60192/#review178861 --- Ship it! Ship It! - Mehul Parikh On June 19, 2017, 11:41 a.m

Re: Review Request 60192: Proxying Ranger UI does not work with Ranger-KnoxSSO

2017-06-19 Thread Colm O hEigeartaigh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60192/#review178225 --- Ship it! Ship It! - Colm O hEigeartaigh On June 19, 2017, 11

Re: Review Request 60192: Proxying Ranger UI does not work with Ranger-KnoxSSO

2017-06-19 Thread Ankita Sinha
> On June 19, 2017, 11:22 a.m., Colm O hEigeartaigh wrote: > > Sorry, just one more change - I think instead of having "xForwardedURL" as > > a class variable, instead it would be better to return it from > > "constructForwardableURL". Thank Colm, updated the patch. - Ankita --

Re: Review Request 60192: Proxying Ranger UI does not work with Ranger-KnoxSSO

2017-06-19 Thread Ankita Sinha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60192/ --- (Updated June 19, 2017, 11:41 a.m.) Review request for ranger. Changes --

Re: Review Request 60192: Proxying Ranger UI does not work with Ranger-KnoxSSO

2017-06-19 Thread Colm O hEigeartaigh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60192/#review178220 --- Sorry, just one more change - I think instead of having "xForwarde

Re: Review Request 60192: Proxying Ranger UI does not work with Ranger-KnoxSSO

2017-06-19 Thread Velmurugan Periasamy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60192/#review178219 --- Ship it! Ship It! - Velmurugan Periasamy On June 19, 2017, 1

Re: Review Request 60192: Proxying Ranger UI does not work with Ranger-KnoxSSO

2017-06-19 Thread Ankita Sinha
> On June 19, 2017, 10:10 a.m., Colm O hEigeartaigh wrote: > > OK thanks. Just one other change I'd like to see - the code to construct > > the "xForwardedURL" could all be moved into a separate method. Thanks Colm, updated the patch with suggested change. - Ankita -

Re: Review Request 60192: Proxying Ranger UI does not work with Ranger-KnoxSSO

2017-06-19 Thread Ankita Sinha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60192/ --- (Updated June 19, 2017, 10:26 a.m.) Review request for ranger. Changes --

Re: Review Request 60192: Proxying Ranger UI does not work with Ranger-KnoxSSO

2017-06-19 Thread Colm O hEigeartaigh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60192/#review178216 --- OK thanks. Just one other change I'd like to see - the code to con

Re: Review Request 60192: Proxying Ranger UI does not work with Ranger-KnoxSSO

2017-06-19 Thread Ankita Sinha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60192/ --- (Updated June 19, 2017, 9:44 a.m.) Review request for ranger. Bugs: RANGER-16

Re: Review Request 60192: Proxying Ranger UI does not work with Ranger-KnoxSSO

2017-06-19 Thread Colm O hEigeartaigh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60192/#review178207 --- A few trivial code comments: a) String xForwardedPorto -> Should

Review Request 60192: Proxying Ranger UI does not work with Ranger-KnoxSSO

2017-06-19 Thread Ankita Sinha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60192/ --- Review request for ranger, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, Madhan