Re: Review Request 60260: Similar to RANGER-1599, Different developers use different log directories in the kms installation script. Its processing logic is chaotic. We should optimize this logic.

2017-06-29 Thread Colm O hEigeartaigh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60260/#review179235 --- Ship it! Ship It! - Colm O hEigeartaigh On June 27, 2017, 11

Re: Review Request 60260: Similar to RANGER-1599, Different developers use different log directories in the kms installation script. Its processing logic is chaotic. We should optimize this logic.

2017-06-27 Thread pengjianhua
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60260/ --- (Updated 六月 27, 2017, 11:31 a.m.) Review request for ranger, Alok Lal, Ankita S

Re: Review Request 60260: Similar to RANGER-1599, Different developers use different log directories in the kms installation script. Its processing logic is chaotic. We should optimize this logic.

2017-06-27 Thread pengjianhua
> On 六月 21, 2017, 9:38 a.m., Colm O hEigeartaigh wrote: > > With the patch, the $LOGFILES property is not actually used at all. Do we > > know what $LOGFILES is meant to do, and why we have both $LOGFILE and > > $LOGFILES? > > pengjianhua wrote: > I also noticed your question. $LOGFILES sh

Re: Review Request 60260: Similar to RANGER-1599, Different developers use different log directories in the kms installation script. Its processing logic is chaotic. We should optimize this logic.

2017-06-23 Thread pengjianhua
> On 六月 21, 2017, 9:38 a.m., Colm O hEigeartaigh wrote: > > With the patch, the $LOGFILES property is not actually used at all. Do we > > know what $LOGFILES is meant to do, and why we have both $LOGFILE and > > $LOGFILES? > > pengjianhua wrote: > I also noticed your question. $LOGFILES sh

Re: Review Request 60260: Similar to RANGER-1599, Different developers use different log directories in the kms installation script. Its processing logic is chaotic. We should optimize this logic.

2017-06-22 Thread Colm O hEigeartaigh
> On June 21, 2017, 9:38 a.m., Colm O hEigeartaigh wrote: > > With the patch, the $LOGFILES property is not actually used at all. Do we > > know what $LOGFILES is meant to do, and why we have both $LOGFILE and > > $LOGFILES? > > pengjianhua wrote: > I also noticed your question. $LOGFILES

Re: Review Request 60260: Similar to RANGER-1599, Different developers use different log directories in the kms installation script. Its processing logic is chaotic. We should optimize this logic.

2017-06-21 Thread Qiang Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60260/#review178608 --- Ship it! Ship It! - Qiang Zhang On 六月 21, 2017, 3:10 a.m., p

Re: Review Request 60260: Similar to RANGER-1599, Different developers use different log directories in the kms installation script. Its processing logic is chaotic. We should optimize this logic.

2017-06-21 Thread pengjianhua
> On 六月 21, 2017, 9:38 a.m., Colm O hEigeartaigh wrote: > > With the patch, the $LOGFILES property is not actually used at all. Do we > > know what $LOGFILES is meant to do, and why we have both $LOGFILE and > > $LOGFILES? I also noticed your question. $LOGFILES should not be needed in current

Re: Review Request 60260: Similar to RANGER-1599, Different developers use different log directories in the kms installation script. Its processing logic is chaotic. We should optimize this logic.

2017-06-21 Thread Colm O hEigeartaigh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60260/#review178474 --- With the patch, the $LOGFILES property is not actually used at all

Review Request 60260: Similar to RANGER-1599, Different developers use different log directories in the kms installation script. Its processing logic is chaotic. We should optimize this logic.

2017-06-20 Thread pengjianhua
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60260/ --- Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O hEige