Review Request 66492: Hive table columns with no explicit allow policy are listed with 'desc table' command

[Abhay Kulkarni]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66492/
---

Review request for ranger and Ramesh Mani.


Bugs: RANGER-2045
https://issues.apache.org/jira/browse/RANGER-2045


Repository: ranger


Description
---

Fix regression caused by earlier patch in hbase component.


Diffs
-

  
agents-common/src/main/java/org/apache/ranger/plugin/policyevaluator/RangerDefaultPolicyEvaluator.java
 56dc0f6bc 


Diff: https://reviews.apache.org/r/66492/diff/1/


Testing
---

Tested with hive and hbase components


Thanks,

Abhay Kulkarni

[jira] [Commented] (RANGER-2029) Ranger Kafka default policy creation improvement.

[Nikhil Purbhe (JIRA)]

[ 
https://issues.apache.org/jira/browse/RANGER-2029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16429246#comment-16429246
 ] 

Nikhil Purbhe commented on RANGER-2029:
---

patch committed on 
[master|https://github.com/apache/ranger/commit/091ad6f95c98357b4843bfb94e71b58ba5463aff]

> Ranger Kafka default policy creation improvement.
> -
>
> Key: RANGER-2029
> URL: https://issues.apache.org/jira/browse/RANGER-2029
> Project: Ranger
>  Issue Type: Improvement
>  Components: Ranger
>Reporter: Nikhil Purbhe
>Assignee: Nikhil Purbhe
>Priority: Major
> Fix For: master
>
> Attachments: 
> RANGER-2029-Ranger-Kafka-default-policy-creation-imp.patch
>
>
> Ranger Kafka default policy creation improvement.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Re: Review Request 66492: Hive table columns with no explicit allow policy are listed with 'desc table' command

[Ramesh Mani]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66492/#review200696
---


Ship it!




Ship It!

- Ramesh Mani


On April 7, 2018, 1:30 a.m., Abhay Kulkarni wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66492/
> ---
> 
> (Updated April 7, 2018, 1:30 a.m.)
> 
> 
> Review request for ranger and Ramesh Mani.
> 
> 
> Bugs: RANGER-2045
> https://issues.apache.org/jira/browse/RANGER-2045
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> Fix regression caused by earlier patch in hbase component.
> 
> 
> Diffs
> -
> 
>   
> agents-common/src/main/java/org/apache/ranger/plugin/policyevaluator/RangerDefaultPolicyEvaluator.java
>  56dc0f6bc 
> 
> 
> Diff: https://reviews.apache.org/r/66492/diff/1/
> 
> 
> Testing
> ---
> 
> Tested with hive and hbase components
> 
> 
> Thanks,
> 
> Abhay Kulkarni
> 
>

[jira] [Created] (RANGER-2060) Knox proxy with knox-sso is not working for ranger

[Vishal Suvagia (JIRA)]

Vishal Suvagia created RANGER-2060:
--

 Summary: Knox proxy with knox-sso is not working for ranger
 Key: RANGER-2060
 URL: https://issues.apache.org/jira/browse/RANGER-2060
 Project: Ranger
  Issue Type: Bug
  Components: Ranger
Affects Versions: 1.0.0
Reporter: Vishal Suvagia
 Fix For: 1.1.0, 1.0.1


Knox proxy with Knox-SSO is not working in a case when HA is enabled for both 
Ranger and Knox.

If Ranger-HA url is rangerha.abc.com:6080 with individual Ranger hosts as 
ranger1.abc.com:6080 and ranger2.abc.com:6080 with Knox hosted on  
knoxha.abc.com:8443 and individual knox hosts as knox1.abc.com and 
knox2.abc.com.

If Ranger load-balancer URL is used in the knox topology for knox-proxy ui.xml, 
redirected url gets corrupted as:
knoxha.abc.com:8443/gateway/?originalUrl=https://knoxha.abc.com:8443,%20knox1.abc.com:8443/gateway//ranger

Additionally: Individually enabling Knox-SSO gives 401-Unauthorized error for 
Ranger to login.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Re: Review Request 66448: Good coding practices for KMS and unixauth

[Velmurugan Periasamy]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66448/#review200639
---


Ship it!




Ship It!

- Velmurugan Periasamy


On April 5, 2018, 11 a.m., Nikhil P wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66448/
> ---
> 
> (Updated April 5, 2018, 11 a.m.)
> 
> 
> Review request for ranger, Ankita Sinha, Don Bosco Durai, Gautam Borad, Abhay 
> Kulkarni, Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, Selvamohan 
> Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-2056
> https://issues.apache.org/jira/browse/RANGER-2056
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> Good coding practices for KMS and unixauth
> 
> 
> Diffs
> -
> 
>   kms/src/main/java/org/apache/hadoop/crypto/key/ConsoleUtil.java 9f43740 
>   kms/src/main/java/org/apache/hadoop/crypto/key/DB2HSMMKUtil.java ad85245 
>   kms/src/main/java/org/apache/hadoop/crypto/key/HSM2DBMKUtil.java b330a01 
>   kms/src/main/java/org/apache/hadoop/crypto/key/JKS2RangerUtil.java 13833cb 
>   kms/src/main/java/org/apache/hadoop/crypto/key/Ranger2JKSUtil.java f7c3e6d 
>   
> unixauthclient/src/main/java/org/apache/ranger/authentication/unix/jaas/PamLoginModule.java
>  803e3e8 
>   
> unixauthclient/src/main/java/org/apache/ranger/authentication/unix/jaas/RemoteUnixLoginModule.java
>  40cc51e 
> 
> 
> Diff: https://reviews.apache.org/r/66448/diff/1/
> 
> 
> Testing
> ---
> 
> 1)verified if Ranger KMS is working properly.
> 2)verified if unix authentication,pam authentication works properly.
> 
> 
> Thanks,
> 
> Nikhil P
> 
>

Re: Review Request 66473: RANGER-2059 : Write unit tests for export/import functionality

[Velmurugan Periasamy]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66473/#review200637
---


Ship it!




Ship It!

- Velmurugan Periasamy


On April 5, 2018, 10:21 a.m., bhavik patel wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66473/
> ---
> 
> (Updated April 5, 2018, 10:21 a.m.)
> 
> 
> Review request for ranger, Ankita Sinha, Don Bosco Durai, Gautam Borad, Abhay 
> Kulkarni, Madhan Neethiraj, Mehul Parikh, Ramesh Mani, Selvamohan Neethiraj, 
> Sailaja Polavarapu, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-2059
> https://issues.apache.org/jira/browse/RANGER-2059
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> Write unit tests for export/import functionality.
> 
> 
> Diffs
> -
> 
>   pom.xml a3ef325 
>   security-admin/src/test/java/org/apache/ranger/rest/TestServiceREST.java 
> fec5912 
>   
> security-admin/src/test/java/org/apache/ranger/rest/importPolicy/import_policy_test_file.json
>  PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/66473/diff/1/
> 
> 
> Testing
> ---
> 
> Tested with below two type
> 
> 1.eclipse->Run as->Junit Test
> 2.mvn test
> 
> 
> Thanks,
> 
> bhavik patel
> 
>

Re: Review Request 66245: Ranger Kafka default policy creation improvement

[Mehul Parikh]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66245/#review200641
---


Ship it!




Ship It!

- Mehul Parikh


On April 3, 2018, 7:21 a.m., Nikhil P wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66245/
> ---
> 
> (Updated April 3, 2018, 7:21 a.m.)
> 
> 
> Review request for ranger, Ankita Sinha, Don Bosco Durai, Gautam Borad, Abhay 
> Kulkarni, Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, Selvamohan 
> Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-2029
> https://issues.apache.org/jira/browse/RANGER-2029
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> Ranger Kafka default policy creation improvement.
> 
> 
> Diffs
> -
> 
>   
> agents-common/src/main/java/org/apache/ranger/plugin/service/RangerBaseService.java
>  d99f478 
>   
> plugin-kafka/src/main/java/org/apache/ranger/services/kafka/RangerServiceKafka.java
>  b7bbe98 
> 
> 
> Diff: https://reviews.apache.org/r/66245/diff/3/
> 
> 
> Testing
> ---
> 
> 1) Tested if required policies are getting created when required service 
> configs are given.
> 
> 
> Thanks,
> 
> Nikhil P
> 
>

[jira] [Commented] (RANGER-2059) Write unit tests for export/import functionality

[bhavik patel (JIRA)]

[ 
https://issues.apache.org/jira/browse/RANGER-2059?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16428213#comment-16428213
 ] 

bhavik patel commented on RANGER-2059:
--

Commit link for master : 
https://github.com/apache/ranger/commit/122172a0baa4c899a145e119038243da1370788d

> Write unit tests for export/import functionality
> 
>
> Key: RANGER-2059
> URL: https://issues.apache.org/jira/browse/RANGER-2059
> Project: Ranger
>  Issue Type: Improvement
>  Components: Ranger
>Reporter: bhavik patel
>Assignee: bhavik patel
>Priority: Major
> Fix For: master
>
> Attachments: RANGER-2059-master.patch
>
>
> Write unit tests for export/import functionality.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Re: Review Request 66357: RANGER-2017 : Ranger KMS encryption good practices

[Velmurugan Periasamy]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66357/#review200636
---


Ship it!




Ship It!

- Velmurugan Periasamy


On April 4, 2018, 6:02 a.m., bhavik patel wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66357/
> ---
> 
> (Updated April 4, 2018, 6:02 a.m.)
> 
> 
> Review request for ranger, Ankita Sinha, Don Bosco Durai, Gautam Borad, Abhay 
> Kulkarni, Madhan Neethiraj, Mehul Parikh, Ramesh Mani, Selvamohan Neethiraj, 
> Sailaja Polavarapu, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-2017
> https://issues.apache.org/jira/browse/RANGER-2017
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> Code Improvement To Follow Best Practices.
> 
> 
> Diffs
> -
> 
>   kms/config/kms-webapp/dbks-site.xml 2fc5177 
>   kms/scripts/DBMK2HSM.sh 89c8c2d 
>   kms/scripts/HSMMK2DB.sh 2637cf6 
>   kms/scripts/importJCEKSKeys.sh d72c93e 
>   kms/src/main/java/org/apache/hadoop/crypto/key/RangerMasterKey.java 5614c16 
> 
> 
> Diff: https://reviews.apache.org/r/66357/diff/3/
> 
> 
> Testing
> ---
> 
> 1. Verified Ranger Kms is working as expected.
> 2. Import/Export of key's working as expected.
> 
> 
> Thanks,
> 
> bhavik patel
> 
>

Re: Review Request 66245: Ranger Kafka default policy creation improvement

[Velmurugan Periasamy]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66245/#review200638
---


Ship it!




Ship It!

- Velmurugan Periasamy


On April 3, 2018, 7:21 a.m., Nikhil P wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66245/
> ---
> 
> (Updated April 3, 2018, 7:21 a.m.)
> 
> 
> Review request for ranger, Ankita Sinha, Don Bosco Durai, Gautam Borad, Abhay 
> Kulkarni, Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, Selvamohan 
> Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-2029
> https://issues.apache.org/jira/browse/RANGER-2029
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> Ranger Kafka default policy creation improvement.
> 
> 
> Diffs
> -
> 
>   
> agents-common/src/main/java/org/apache/ranger/plugin/service/RangerBaseService.java
>  d99f478 
>   
> plugin-kafka/src/main/java/org/apache/ranger/services/kafka/RangerServiceKafka.java
>  b7bbe98 
> 
> 
> Diff: https://reviews.apache.org/r/66245/diff/3/
> 
> 
> Testing
> ---
> 
> 1) Tested if required policies are getting created when required service 
> configs are given.
> 
> 
> Thanks,
> 
> Nikhil P
> 
>

Re: Review Request 66473: RANGER-2059 : Write unit tests for export/import functionality

[Mehul Parikh]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66473/#review200640
---


Ship it!




Ship It!

- Mehul Parikh


On April 5, 2018, 10:21 a.m., bhavik patel wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66473/
> ---
> 
> (Updated April 5, 2018, 10:21 a.m.)
> 
> 
> Review request for ranger, Ankita Sinha, Don Bosco Durai, Gautam Borad, Abhay 
> Kulkarni, Madhan Neethiraj, Mehul Parikh, Ramesh Mani, Selvamohan Neethiraj, 
> Sailaja Polavarapu, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-2059
> https://issues.apache.org/jira/browse/RANGER-2059
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> Write unit tests for export/import functionality.
> 
> 
> Diffs
> -
> 
>   pom.xml a3ef325 
>   security-admin/src/test/java/org/apache/ranger/rest/TestServiceREST.java 
> fec5912 
>   
> security-admin/src/test/java/org/apache/ranger/rest/importPolicy/import_policy_test_file.json
>  PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/66473/diff/1/
> 
> 
> Testing
> ---
> 
> Tested with below two type
> 
> 1.eclipse->Run as->Junit Test
> 2.mvn test
> 
> 
> Thanks,
> 
> bhavik patel
> 
>

[jira] [Commented] (RANGER-2017) Ranger KMS encryption good practices

[bhavik patel (JIRA)]

[ 
https://issues.apache.org/jira/browse/RANGER-2017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16428212#comment-16428212
 ] 

bhavik patel commented on RANGER-2017:
--

Commit link for master : 
https://github.com/apache/ranger/commit/20db6e67bdaf65e1f6012ac798fe6c9d3b1cd110

> Ranger KMS encryption good practices
> 
>
> Key: RANGER-2017
> URL: https://issues.apache.org/jira/browse/RANGER-2017
> Project: Ranger
>  Issue Type: Bug
>  Components: Ranger
>Reporter: Selvamohan Neethiraj
>Assignee: bhavik patel
>Priority: Critical
> Fix For: 1.1.0
>
> Attachments: RANGER-2017-master-01.patch, 
> RANGER-2017-master-02.patch, RANGER-2017-master.patch
>
>
> Change the default crypt algorithm to use a stronger cipher algorithm in 
> Ranger KMS (Similar to RANGER-1644 for Ranger Admin). Also make these options 
> configurable.  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Re: Review Request 61116: RANGER-1664 Add-ons to support ADLS in Ranger Authorization Model

[Velmurugan Periasamy]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61116/#review200647
---




agents-common/src/main/java/org/apache/ranger/plugin/store/EmbeddedServiceDefsUtil.java
Line 63 (original), 63 (patched)


Can you please revise the patch? Fails to apply. 

```
$ git apply --check -v < ~/Downloads/RANGER-1664.1.patch
Checking patch 
agents-common/src/main/java/org/apache/ranger/plugin/store/EmbeddedServiceDefsUtil.java...
error: while searching for:
public static final String EMBEDDED_SERVICEDEF_NIFI_NAME  = "nifi";
public static final String EMBEDDED_SERVICEDEF_ATLAS_NAME  = "atlas";
public static final String EMBEDDED_SERVICEDEF_WASB_NAME  = "wasb";

public static final String PROPERTY_CREATE_EMBEDDED_SERVICE_DEFS = 
"ranger.service.store.create.embedded.service-defs";

error: patch failed: 
agents-common/src/main/java/org/apache/ranger/plugin/store/EmbeddedServiceDefsUtil.java:63
error: 
agents-common/src/main/java/org/apache/ranger/plugin/store/EmbeddedServiceDefsUtil.java:
 patch does not apply
Checking patch 
agents-common/src/main/resources/service-defs/ranger-servicedef-adls.json...
```


- Velmurugan Periasamy


On Nov. 20, 2017, 1:11 p.m., Anandsagar Kothapalli wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61116/
> ---
> 
> (Updated Nov. 20, 2017, 1:11 p.m.)
> 
> 
> Review request for ranger, Abhay Kulkarni, Ramesh Mani, and Velmurugan 
> Periasamy.
> 
> 
> Bugs: RANGER-1664
> https://issues.apache.org/jira/browse/RANGER-1664
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> Add-ons to support Azure Data lake(ADLS) in Ranger Authorization Model
> 
> 
> Diffs
> -
> 
>   
> agents-common/src/main/java/org/apache/ranger/plugin/store/EmbeddedServiceDefsUtil.java
>  0bc09f60 
>   agents-common/src/main/resources/service-defs/ranger-servicedef-adls.json 
> PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/61116/diff/1/
> 
> 
> Testing
> ---
> 
> Tested creating a VM
> 
> 
> Thanks,
> 
> Anandsagar Kothapalli
> 
>

[jira] [Updated] (RANGER-1664) Add-ons to support ADLS in Ranger Authorization Model

[Velmurugan Periasamy (JIRA)]

 [ 
https://issues.apache.org/jira/browse/RANGER-1664?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Velmurugan Periasamy updated RANGER-1664:
-
Fix Version/s: 1.1.0

> Add-ons to support ADLS in Ranger Authorization Model
> -
>
> Key: RANGER-1664
> URL: https://issues.apache.org/jira/browse/RANGER-1664
> Project: Ranger
>  Issue Type: Bug
>  Components: Ranger
>Reporter: Anandsagar Kothapalli
>Priority: Major
> Fix For: 1.1.0
>
>
> Add-ons to support Azure Data Lakes (ADLS) in Ranger Authorization Model. 
> This will gives an option to add ADLS as Service in the Ranger. 
> In ranger-admin-site.xml the parameter to include is 
> ranger.supportedcomponents=tag,hdfs,hbase,hive,kms,knox,storm,yarn,kafka,solr,atlas,wasb,adls
>  
> This will add the ADLS ServiceDef along with other services to Ranger. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (RANGER-1664) Add-ons to support ADLS in Ranger Authorization Model

[Velmurugan Periasamy (JIRA)]

[ 
https://issues.apache.org/jira/browse/RANGER-1664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16428358#comment-16428358
 ] 

Velmurugan Periasamy commented on RANGER-1664:
--

[~ankothap] - Can you please revise the patch? It fails to apply. CC [~rmani]

> Add-ons to support ADLS in Ranger Authorization Model
> -
>
> Key: RANGER-1664
> URL: https://issues.apache.org/jira/browse/RANGER-1664
> Project: Ranger
>  Issue Type: Bug
>  Components: Ranger
>Reporter: Anandsagar Kothapalli
>Priority: Major
> Fix For: 1.1.0
>
>
> Add-ons to support Azure Data Lakes (ADLS) in Ranger Authorization Model. 
> This will gives an option to add ADLS as Service in the Ranger. 
> In ranger-admin-site.xml the parameter to include is 
> ranger.supportedcomponents=tag,hdfs,hbase,hive,kms,knox,storm,yarn,kafka,solr,atlas,wasb,adls
>  
> This will add the ADLS ServiceDef along with other services to Ranger. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)