[jira] [Commented] (RANGER-1595) conf directory is missing

[Qiang Zhang (JIRA)]

[ 
https://issues.apache.org/jira/browse/RANGER-1595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16018200#comment-16018200
 ] 

Qiang Zhang commented on RANGER-1595:
-

The conf directory was created when runing the installer.
Please tell us what type of user you used to run setup.sh. 

> conf directory is missing
> -
>
> Key: RANGER-1595
> URL: https://issues.apache.org/jira/browse/RANGER-1595
> Project: Ranger
>  Issue Type: Bug
>  Components: admin
>Affects Versions: 0.7.0
>Reporter: Nishit Jain
>
> I pulled 0.7.0 release from http://ranger.apache.org/download.html
> Built it and found that was not conf folder:
> ranger-0.7.0-admin/ews/webapp/WEB-INF/classes -> ls
> META-INF db_message_bundle.properties org 
>  resourcenamemap.properties
> conf.distlog4jdbc.properties  ranger-plugins
> As a result of that when I run ranger-admin-services.sh start I am getting:
> find: `/data/ranger/ews/webapp/WEB-INF/classes/conf/': No such file or 
> directory
> Starting Apache Ranger Admin Service
> Apache Ranger Admin Service failed to start!



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (RANGER-1595) conf directory is missing

[Velmurugan Periasamy (JIRA)]

[ 
https://issues.apache.org/jira/browse/RANGER-1595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16017904#comment-16017904
 ] 

Velmurugan Periasamy commented on RANGER-1595:
--

Did you run setup.sh? 

> conf directory is missing
> -
>
> Key: RANGER-1595
> URL: https://issues.apache.org/jira/browse/RANGER-1595
> Project: Ranger
>  Issue Type: Bug
>  Components: admin
>Affects Versions: 0.7.0
>Reporter: Nishit Jain
>
> I pulled 0.7.0 release from http://ranger.apache.org/download.html
> Built it and found that was not conf folder:
> ranger-0.7.0-admin/ews/webapp/WEB-INF/classes -> ls
> META-INF db_message_bundle.properties org 
>  resourcenamemap.properties
> conf.distlog4jdbc.properties  ranger-plugins
> As a result of that when I run ranger-admin-services.sh start I am getting:
> find: `/data/ranger/ews/webapp/WEB-INF/classes/conf/': No such file or 
> directory
> Starting Apache Ranger Admin Service
> Apache Ranger Admin Service failed to start!



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Created] (RANGER-1595) conf directory is missing

[Nishit Jain (JIRA)]

Nishit Jain created RANGER-1595:
---

 Summary: conf directory is missing
 Key: RANGER-1595
 URL: https://issues.apache.org/jira/browse/RANGER-1595
 Project: Ranger
  Issue Type: Bug
  Components: admin
Affects Versions: 0.7.0
Reporter: Nishit Jain


I pulled 0.7.0 release from http://ranger.apache.org/download.html

Built it and found that was not conf folder:

ranger-0.7.0-admin/ews/webapp/WEB-INF/classes -> ls
META-INF db_message_bundle.properties org   
   resourcenamemap.properties
conf.distlog4jdbc.properties  ranger-plugins


As a result of that when I run ranger-admin-services.sh start I am getting:
find: `/data/ranger/ews/webapp/WEB-INF/classes/conf/': No such file or directory
Starting Apache Ranger Admin Service
Apache Ranger Admin Service failed to start!



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (RANGER-1583) Test connections are failing for plugins after upgrade

[Gautam Borad (JIRA)]

[ 
https://issues.apache.org/jira/browse/RANGER-1583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16017648#comment-16017648
 ] 

Gautam Borad commented on RANGER-1583:
--

Committed to master : 69204867d4bba0d7094ea5963971baf403af2fe4
Committed to ranger-0.7 : 0765c215d6fa1a70734a32e6f37f6fc77dc718d5

> Test connections are failing for plugins after upgrade
> --
>
> Key: RANGER-1583
> URL: https://issues.apache.org/jira/browse/RANGER-1583
> Project: Ranger
>  Issue Type: Bug
>  Components: Ranger
>Reporter: bhavik patel
>Assignee: bhavik patel
> Fix For: 1.0.0, 0.7.1
>
> Attachments: RANGER-1583-07-01.patch, RANGER-1583-07.patch, 
> RANGER-1583-master-01.patch, RANGER-1583-master.patch
>
>
> After upgrade from ranger-0.6 to ranger-0.7 all test connections are failing 
> for plugins. 
> Below error is shown in xa_portal.log:
> ERROR org.apache.ranger.plugin.util.PasswordUtils (PasswordUtils.java:129) - 
> Unable to decrypt password due to error



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Re: Review Request 59335: RANGER-1583 : Test connections are failing for plugins after upgrade

[Gautam Borad]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59335/#review175525
---


Ship it!




Ship It!

- Gautam Borad


On May 19, 2017, 1:33 p.m., bhavik patel wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59335/
> ---
> 
> (Updated May 19, 2017, 1:33 p.m.)
> 
> 
> Review request for ranger, Ankita Sinha, Gautam Borad, Abhay Kulkarni, Madhan 
> Neethiraj, Mehul Parikh, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, 
> and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-1583
> https://issues.apache.org/jira/browse/RANGER-1583
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> After upgrade from ranger-0.6 to ranger-0.7 all test connections are failing 
> for plugins.
> Below error is shown in xa_portal.log:
> ERROR org.apache.ranger.plugin.util.PasswordUtils (PasswordUtils.java:129) - 
> Unable to decrypt password due to error
> 
> 
> Diffs
> -
> 
>   
> agents-common/src/main/java/org/apache/ranger/plugin/util/PasswordUtils.java 
> 3759b8d 
>   security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java 
> a44aa46 
>   
> security-admin/src/main/java/org/apache/ranger/service/RangerServiceService.java
>  256d42e 
>   security-admin/src/main/resources/conf.dist/ranger-admin-default-site.xml 
> 4f5f1d3 
> 
> 
> Diff: https://reviews.apache.org/r/59335/diff/2/
> 
> 
> Testing
> ---
> 
> 1. After upgrade from ranger-0.6 to ranger-0.7 verified plugins 
> test-connections & resource-lookup.
> 
> 
> Thanks,
> 
> bhavik patel
> 
>

Re: Review Request 59335: RANGER-1583 : Test connections are failing for plugins after upgrade

[Colm O hEigeartaigh]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59335/#review175523
---


Ship it!




Ship It!

- Colm O hEigeartaigh


On May 19, 2017, 1:33 p.m., bhavik patel wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59335/
> ---
> 
> (Updated May 19, 2017, 1:33 p.m.)
> 
> 
> Review request for ranger, Ankita Sinha, Gautam Borad, Abhay Kulkarni, Madhan 
> Neethiraj, Mehul Parikh, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, 
> and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-1583
> https://issues.apache.org/jira/browse/RANGER-1583
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> After upgrade from ranger-0.6 to ranger-0.7 all test connections are failing 
> for plugins.
> Below error is shown in xa_portal.log:
> ERROR org.apache.ranger.plugin.util.PasswordUtils (PasswordUtils.java:129) - 
> Unable to decrypt password due to error
> 
> 
> Diffs
> -
> 
>   
> agents-common/src/main/java/org/apache/ranger/plugin/util/PasswordUtils.java 
> 3759b8d 
>   security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java 
> a44aa46 
>   
> security-admin/src/main/java/org/apache/ranger/service/RangerServiceService.java
>  256d42e 
>   security-admin/src/main/resources/conf.dist/ranger-admin-default-site.xml 
> 4f5f1d3 
> 
> 
> Diff: https://reviews.apache.org/r/59335/diff/2/
> 
> 
> Testing
> ---
> 
> 1. After upgrade from ranger-0.6 to ranger-0.7 verified plugins 
> test-connections & resource-lookup.
> 
> 
> Thanks,
> 
> bhavik patel
> 
>

Re: Review Request 59335: RANGER-1583 : Test connections are failing for plugins after upgrade

[Velmurugan Periasamy]

> On May 19, 2017, 3:24 p.m., Velmurugan Periasamy wrote:
> > Ship It!
> 
> Colm O hEigeartaigh wrote:
> Are the concerns I raised above addressed in the latest patch?
> 
> Velmurugan Periasamy wrote:
> yes Colm, I see they are addressed.
> 
> Colm O hEigeartaigh wrote:
> Hi Vel, I still see a default iteration count of "17", or am I missing 
> something?
> 
> Velmurugan Periasamy wrote:
> I see code in setPropertiesValue to use DEFAULT_ITERATION_COUNT only for 
> old installs. For the new installs, can't the user change the iteration count?
> 
> Colm O hEigeartaigh wrote:
> Ah ok. So if I understand correctly, then the value of "1000" in 
> "ranger-admin-default-site.xml" is used for new deployments, but for old 
> deployments then it falls back to "17"?

yes, that is my understanding as well.


- Velmurugan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59335/#review175508
---


On May 19, 2017, 1:33 p.m., bhavik patel wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59335/
> ---
> 
> (Updated May 19, 2017, 1:33 p.m.)
> 
> 
> Review request for ranger, Ankita Sinha, Gautam Borad, Abhay Kulkarni, Madhan 
> Neethiraj, Mehul Parikh, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, 
> and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-1583
> https://issues.apache.org/jira/browse/RANGER-1583
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> After upgrade from ranger-0.6 to ranger-0.7 all test connections are failing 
> for plugins.
> Below error is shown in xa_portal.log:
> ERROR org.apache.ranger.plugin.util.PasswordUtils (PasswordUtils.java:129) - 
> Unable to decrypt password due to error
> 
> 
> Diffs
> -
> 
>   
> agents-common/src/main/java/org/apache/ranger/plugin/util/PasswordUtils.java 
> 3759b8d 
>   security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java 
> a44aa46 
>   
> security-admin/src/main/java/org/apache/ranger/service/RangerServiceService.java
>  256d42e 
>   security-admin/src/main/resources/conf.dist/ranger-admin-default-site.xml 
> 4f5f1d3 
> 
> 
> Diff: https://reviews.apache.org/r/59335/diff/2/
> 
> 
> Testing
> ---
> 
> 1. After upgrade from ranger-0.6 to ranger-0.7 verified plugins 
> test-connections & resource-lookup.
> 
> 
> Thanks,
> 
> bhavik patel
> 
>

Re: Review Request 59335: RANGER-1583 : Test connections are failing for plugins after upgrade

[Colm O hEigeartaigh]

> On May 19, 2017, 3:24 p.m., Velmurugan Periasamy wrote:
> > Ship It!
> 
> Colm O hEigeartaigh wrote:
> Are the concerns I raised above addressed in the latest patch?
> 
> Velmurugan Periasamy wrote:
> yes Colm, I see they are addressed.
> 
> Colm O hEigeartaigh wrote:
> Hi Vel, I still see a default iteration count of "17", or am I missing 
> something?
> 
> Velmurugan Periasamy wrote:
> I see code in setPropertiesValue to use DEFAULT_ITERATION_COUNT only for 
> old installs. For the new installs, can't the user change the iteration count?

Ah ok. So if I understand correctly, then the value of "1000" in 
"ranger-admin-default-site.xml" is used for new deployments, but for old 
deployments then it falls back to "17"?


- Colm


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59335/#review175508
---


On May 19, 2017, 1:33 p.m., bhavik patel wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59335/
> ---
> 
> (Updated May 19, 2017, 1:33 p.m.)
> 
> 
> Review request for ranger, Ankita Sinha, Gautam Borad, Abhay Kulkarni, Madhan 
> Neethiraj, Mehul Parikh, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, 
> and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-1583
> https://issues.apache.org/jira/browse/RANGER-1583
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> After upgrade from ranger-0.6 to ranger-0.7 all test connections are failing 
> for plugins.
> Below error is shown in xa_portal.log:
> ERROR org.apache.ranger.plugin.util.PasswordUtils (PasswordUtils.java:129) - 
> Unable to decrypt password due to error
> 
> 
> Diffs
> -
> 
>   
> agents-common/src/main/java/org/apache/ranger/plugin/util/PasswordUtils.java 
> 3759b8d 
>   security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java 
> a44aa46 
>   
> security-admin/src/main/java/org/apache/ranger/service/RangerServiceService.java
>  256d42e 
>   security-admin/src/main/resources/conf.dist/ranger-admin-default-site.xml 
> 4f5f1d3 
> 
> 
> Diff: https://reviews.apache.org/r/59335/diff/2/
> 
> 
> Testing
> ---
> 
> 1. After upgrade from ranger-0.6 to ranger-0.7 verified plugins 
> test-connections & resource-lookup.
> 
> 
> Thanks,
> 
> bhavik patel
> 
>

Re: Review Request 59335: RANGER-1583 : Test connections are failing for plugins after upgrade

[Velmurugan Periasamy]

> On May 19, 2017, 3:24 p.m., Velmurugan Periasamy wrote:
> > Ship It!
> 
> Colm O hEigeartaigh wrote:
> Are the concerns I raised above addressed in the latest patch?
> 
> Velmurugan Periasamy wrote:
> yes Colm, I see they are addressed.
> 
> Colm O hEigeartaigh wrote:
> Hi Vel, I still see a default iteration count of "17", or am I missing 
> something?

I see code in setPropertiesValue to use DEFAULT_ITERATION_COUNT only for old 
installs. For the new installs, can't the user change the iteration count?


- Velmurugan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59335/#review175508
---


On May 19, 2017, 1:33 p.m., bhavik patel wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59335/
> ---
> 
> (Updated May 19, 2017, 1:33 p.m.)
> 
> 
> Review request for ranger, Ankita Sinha, Gautam Borad, Abhay Kulkarni, Madhan 
> Neethiraj, Mehul Parikh, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, 
> and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-1583
> https://issues.apache.org/jira/browse/RANGER-1583
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> After upgrade from ranger-0.6 to ranger-0.7 all test connections are failing 
> for plugins.
> Below error is shown in xa_portal.log:
> ERROR org.apache.ranger.plugin.util.PasswordUtils (PasswordUtils.java:129) - 
> Unable to decrypt password due to error
> 
> 
> Diffs
> -
> 
>   
> agents-common/src/main/java/org/apache/ranger/plugin/util/PasswordUtils.java 
> 3759b8d 
>   security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java 
> a44aa46 
>   
> security-admin/src/main/java/org/apache/ranger/service/RangerServiceService.java
>  256d42e 
>   security-admin/src/main/resources/conf.dist/ranger-admin-default-site.xml 
> 4f5f1d3 
> 
> 
> Diff: https://reviews.apache.org/r/59335/diff/2/
> 
> 
> Testing
> ---
> 
> 1. After upgrade from ranger-0.6 to ranger-0.7 verified plugins 
> test-connections & resource-lookup.
> 
> 
> Thanks,
> 
> bhavik patel
> 
>

Re: Review Request 59335: RANGER-1583 : Test connections are failing for plugins after upgrade

[Colm O hEigeartaigh]

> On May 19, 2017, 3:24 p.m., Velmurugan Periasamy wrote:
> > Ship It!
> 
> Colm O hEigeartaigh wrote:
> Are the concerns I raised above addressed in the latest patch?
> 
> Velmurugan Periasamy wrote:
> yes Colm, I see they are addressed.

Hi Vel, I still see a default iteration count of "17", or am I missing 
something?


- Colm


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59335/#review175508
---


On May 19, 2017, 1:33 p.m., bhavik patel wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59335/
> ---
> 
> (Updated May 19, 2017, 1:33 p.m.)
> 
> 
> Review request for ranger, Ankita Sinha, Gautam Borad, Abhay Kulkarni, Madhan 
> Neethiraj, Mehul Parikh, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, 
> and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-1583
> https://issues.apache.org/jira/browse/RANGER-1583
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> After upgrade from ranger-0.6 to ranger-0.7 all test connections are failing 
> for plugins.
> Below error is shown in xa_portal.log:
> ERROR org.apache.ranger.plugin.util.PasswordUtils (PasswordUtils.java:129) - 
> Unable to decrypt password due to error
> 
> 
> Diffs
> -
> 
>   
> agents-common/src/main/java/org/apache/ranger/plugin/util/PasswordUtils.java 
> 3759b8d 
>   security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java 
> a44aa46 
>   
> security-admin/src/main/java/org/apache/ranger/service/RangerServiceService.java
>  256d42e 
>   security-admin/src/main/resources/conf.dist/ranger-admin-default-site.xml 
> 4f5f1d3 
> 
> 
> Diff: https://reviews.apache.org/r/59335/diff/2/
> 
> 
> Testing
> ---
> 
> 1. After upgrade from ranger-0.6 to ranger-0.7 verified plugins 
> test-connections & resource-lookup.
> 
> 
> Thanks,
> 
> bhavik patel
> 
>

Re: Review Request 59335: RANGER-1583 : Test connections are failing for plugins after upgrade

[Velmurugan Periasamy]

> On May 19, 2017, 3:24 p.m., Velmurugan Periasamy wrote:
> > Ship It!
> 
> Colm O hEigeartaigh wrote:
> Are the concerns I raised above addressed in the latest patch?

yes Colm, I see they are addressed.


- Velmurugan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59335/#review175508
---


On May 19, 2017, 1:33 p.m., bhavik patel wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59335/
> ---
> 
> (Updated May 19, 2017, 1:33 p.m.)
> 
> 
> Review request for ranger, Ankita Sinha, Gautam Borad, Abhay Kulkarni, Madhan 
> Neethiraj, Mehul Parikh, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, 
> and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-1583
> https://issues.apache.org/jira/browse/RANGER-1583
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> After upgrade from ranger-0.6 to ranger-0.7 all test connections are failing 
> for plugins.
> Below error is shown in xa_portal.log:
> ERROR org.apache.ranger.plugin.util.PasswordUtils (PasswordUtils.java:129) - 
> Unable to decrypt password due to error
> 
> 
> Diffs
> -
> 
>   
> agents-common/src/main/java/org/apache/ranger/plugin/util/PasswordUtils.java 
> 3759b8d 
>   security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java 
> a44aa46 
>   
> security-admin/src/main/java/org/apache/ranger/service/RangerServiceService.java
>  256d42e 
>   security-admin/src/main/resources/conf.dist/ranger-admin-default-site.xml 
> 4f5f1d3 
> 
> 
> Diff: https://reviews.apache.org/r/59335/diff/2/
> 
> 
> Testing
> ---
> 
> 1. After upgrade from ranger-0.6 to ranger-0.7 verified plugins 
> test-connections & resource-lookup.
> 
> 
> Thanks,
> 
> bhavik patel
> 
>

Re: Review Request 59335: RANGER-1583 : Test connections are failing for plugins after upgrade

[Colm O hEigeartaigh]

> On May 19, 2017, 3:24 p.m., Velmurugan Periasamy wrote:
> > Ship It!

Are the concerns I raised above addressed in the latest patch?


- Colm


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59335/#review175508
---


On May 19, 2017, 1:33 p.m., bhavik patel wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59335/
> ---
> 
> (Updated May 19, 2017, 1:33 p.m.)
> 
> 
> Review request for ranger, Ankita Sinha, Gautam Borad, Abhay Kulkarni, Madhan 
> Neethiraj, Mehul Parikh, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, 
> and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-1583
> https://issues.apache.org/jira/browse/RANGER-1583
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> After upgrade from ranger-0.6 to ranger-0.7 all test connections are failing 
> for plugins.
> Below error is shown in xa_portal.log:
> ERROR org.apache.ranger.plugin.util.PasswordUtils (PasswordUtils.java:129) - 
> Unable to decrypt password due to error
> 
> 
> Diffs
> -
> 
>   
> agents-common/src/main/java/org/apache/ranger/plugin/util/PasswordUtils.java 
> 3759b8d 
>   security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java 
> a44aa46 
>   
> security-admin/src/main/java/org/apache/ranger/service/RangerServiceService.java
>  256d42e 
>   security-admin/src/main/resources/conf.dist/ranger-admin-default-site.xml 
> 4f5f1d3 
> 
> 
> Diff: https://reviews.apache.org/r/59335/diff/2/
> 
> 
> Testing
> ---
> 
> 1. After upgrade from ranger-0.6 to ranger-0.7 verified plugins 
> test-connections & resource-lookup.
> 
> 
> Thanks,
> 
> bhavik patel
> 
>

Re: Review Request 59335: RANGER-1583 : Test connections are failing for plugins after upgrade

[Velmurugan Periasamy]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59335/#review175508
---


Ship it!




Ship It!

- Velmurugan Periasamy


On May 19, 2017, 1:33 p.m., bhavik patel wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59335/
> ---
> 
> (Updated May 19, 2017, 1:33 p.m.)
> 
> 
> Review request for ranger, Ankita Sinha, Gautam Borad, Abhay Kulkarni, Madhan 
> Neethiraj, Mehul Parikh, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, 
> and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-1583
> https://issues.apache.org/jira/browse/RANGER-1583
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> After upgrade from ranger-0.6 to ranger-0.7 all test connections are failing 
> for plugins.
> Below error is shown in xa_portal.log:
> ERROR org.apache.ranger.plugin.util.PasswordUtils (PasswordUtils.java:129) - 
> Unable to decrypt password due to error
> 
> 
> Diffs
> -
> 
>   
> agents-common/src/main/java/org/apache/ranger/plugin/util/PasswordUtils.java 
> 3759b8d 
>   security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java 
> a44aa46 
>   
> security-admin/src/main/java/org/apache/ranger/service/RangerServiceService.java
>  256d42e 
>   security-admin/src/main/resources/conf.dist/ranger-admin-default-site.xml 
> 4f5f1d3 
> 
> 
> Diff: https://reviews.apache.org/r/59335/diff/2/
> 
> 
> Testing
> ---
> 
> 1. After upgrade from ranger-0.6 to ranger-0.7 verified plugins 
> test-connections & resource-lookup.
> 
> 
> Thanks,
> 
> bhavik patel
> 
>

Re: Review Request 59398: RANGER-1583 : Test connections are failing for plugins after upgrade

[Velmurugan Periasamy]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59398/#review175505
---


Ship it!




Ship It!

- Velmurugan Periasamy


On May 19, 2017, 1:36 p.m., bhavik patel wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59398/
> ---
> 
> (Updated May 19, 2017, 1:36 p.m.)
> 
> 
> Review request for ranger, Ankita Sinha, Gautam Borad, Abhay Kulkarni, Madhan 
> Neethiraj, Mehul Parikh, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, 
> and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-1583
> https://issues.apache.org/jira/browse/RANGER-1583
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> After upgrade from ranger-0.6 to ranger-0.7 all test connections are failing 
> for plugins.
> Below error is shown in xa_portal.log:
> ERROR org.apache.ranger.plugin.util.PasswordUtils (PasswordUtils.java:129) - 
> Unable to decrypt password due to error
> 
> 
> Diffs
> -
> 
>   
> agents-common/src/main/java/org/apache/ranger/plugin/util/PasswordUtils.java 
> 3759b8d 
>   security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java 
> 3ac8d3d 
>   
> security-admin/src/main/java/org/apache/ranger/service/RangerServiceService.java
>  9aa4aed 
>   security-admin/src/main/resources/conf.dist/ranger-admin-default-site.xml 
> 4f5f1d3 
> 
> 
> Diff: https://reviews.apache.org/r/59398/diff/1/
> 
> 
> Testing
> ---
> 
> 1. After upgrade from ranger-0.6 to ranger-0.7 verified plugins 
> test-connections & resource-lookup.
> 2. Verified on simple as well as on kerberized environment.
> 
> 
> Thanks,
> 
> bhavik patel
> 
>

Review Request 59399: RANGER-1594 - Fix HBase tests to work with HBase 1.2.x

[Colm O hEigeartaigh]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59399/
---

Review request for ranger.


Bugs: RANGER-1594
https://issues.apache.org/jira/browse/RANGER-1594


Repository: ranger


Description
---

Currently, the HBase tests in Ranger fail on an upgrade to 1.2.x. This task is 
to fix the tests so that when we upgrade everything works.


Diffs
-

  
hbase-agent/src/test/java/org/apache/ranger/authorization/hbase/HBaseRangerAuthorizationTest.java
 2a46709a 


Diff: https://reviews.apache.org/r/59399/diff/1/


Testing
---


Thanks,

Colm O hEigeartaigh

[jira] [Updated] (RANGER-1594) Fix HBase tests to work with HBase 1.2.x

[Colm O hEigeartaigh (JIRA)]

 [ 
https://issues.apache.org/jira/browse/RANGER-1594?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Colm O hEigeartaigh updated RANGER-1594:

Attachment: 0001-RANGER-1594-Fix-HBase-tests-to-work-with-HBase-1.2.x.patch

> Fix HBase tests to work with HBase 1.2.x
> 
>
> Key: RANGER-1594
> URL: https://issues.apache.org/jira/browse/RANGER-1594
> Project: Ranger
>  Issue Type: Test
>  Components: plugins
>Reporter: Colm O hEigeartaigh
>Assignee: Colm O hEigeartaigh
> Fix For: 1.0.0
>
> Attachments: 
> 0001-RANGER-1594-Fix-HBase-tests-to-work-with-HBase-1.2.x.patch
>
>
> Currently, the HBase tests in Ranger fail on an upgrade to 1.2.x. This task 
> is to fix the tests so that when we upgrade everything works.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Created] (RANGER-1594) Fix HBase tests to work with HBase 1.2.x

[Colm O hEigeartaigh (JIRA)]

Colm O hEigeartaigh created RANGER-1594:
---

 Summary: Fix HBase tests to work with HBase 1.2.x
 Key: RANGER-1594
 URL: https://issues.apache.org/jira/browse/RANGER-1594
 Project: Ranger
  Issue Type: Test
  Components: plugins
Reporter: Colm O hEigeartaigh
Assignee: Colm O hEigeartaigh
 Fix For: 1.0.0


Currently, the HBase tests in Ranger fail on an upgrade to 1.2.x. This task is 
to fix the tests so that when we upgrade everything works.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Review Request 59398: RANGER-1583 : Test connections are failing for plugins after upgrade

[bhavik patel]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59398/
---

Review request for ranger, Ankita Sinha, Gautam Borad, Abhay Kulkarni, Madhan 
Neethiraj, Mehul Parikh, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, 
and Velmurugan Periasamy.


Bugs: RANGER-1583
https://issues.apache.org/jira/browse/RANGER-1583


Repository: ranger


Description
---

After upgrade from ranger-0.6 to ranger-0.7 all test connections are failing 
for plugins.
Below error is shown in xa_portal.log:
ERROR org.apache.ranger.plugin.util.PasswordUtils (PasswordUtils.java:129) - 
Unable to decrypt password due to error


Diffs
-

  agents-common/src/main/java/org/apache/ranger/plugin/util/PasswordUtils.java 
3759b8d 
  security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java 
3ac8d3d 
  
security-admin/src/main/java/org/apache/ranger/service/RangerServiceService.java
 9aa4aed 
  security-admin/src/main/resources/conf.dist/ranger-admin-default-site.xml 
4f5f1d3 


Diff: https://reviews.apache.org/r/59398/diff/1/


Testing
---

1. After upgrade from ranger-0.6 to ranger-0.7 verified plugins 
test-connections & resource-lookup.
2. Verified on simple as well as on kerberized environment.


Thanks,

bhavik patel

[jira] [Updated] (RANGER-1583) Test connections are failing for plugins after upgrade

[bhavik patel (JIRA)]

 [ 
https://issues.apache.org/jira/browse/RANGER-1583?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

bhavik patel updated RANGER-1583:
-
Attachment: RANGER-1583-master-01.patch
RANGER-1583-07-01.patch

> Test connections are failing for plugins after upgrade
> --
>
> Key: RANGER-1583
> URL: https://issues.apache.org/jira/browse/RANGER-1583
> Project: Ranger
>  Issue Type: Bug
>  Components: Ranger
>Reporter: bhavik patel
>Assignee: bhavik patel
> Fix For: 0.7.1
>
> Attachments: RANGER-1583-07-01.patch, RANGER-1583-07.patch, 
> RANGER-1583-master-01.patch, RANGER-1583-master.patch
>
>
> After upgrade from ranger-0.6 to ranger-0.7 all test connections are failing 
> for plugins. 
> Below error is shown in xa_portal.log:
> ERROR org.apache.ranger.plugin.util.PasswordUtils (PasswordUtils.java:129) - 
> Unable to decrypt password due to error



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Servicedef documentation/spec

[Nigel L Jones]

I’m working on a ranger plugin for an additional technology (gaianDB).

 

I can find servicedef defitions – such as for hive, hbase etc, plus information 
on how to deploy, but I didn’t see where servicedef is documented

 

Is this something I missed – other than copying/modifying one of the existing 
definitions, reviewing code & trying out 

 

Thanks

Nigel.

Unless stated otherwise above:
IBM United Kingdom Limited - Registered in England and Wales with number 
741598. 
Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU

Review Request 59395: RANGER-1593 - Avoid Classloading default AtlasResourceMappers

[Colm O hEigeartaigh]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59395/
---

Review request for ranger.


Bugs: RANGER-1593
https://issues.apache.org/jira/browse/RANGER-1593


Repository: ranger


Description
---

In AtlasResourceMapperUtil we classload both the default AtlasResourceMappers 
and then the custom ones. This is unnecessary - we should just instantiate the 
default ones and classload the custom ones.


Diffs
-

  
tagsync/src/main/java/org/apache/ranger/tagsync/source/atlas/AtlasResourceMapperUtil.java
 5227d8c3 


Diff: https://reviews.apache.org/r/59395/diff/1/


Testing
---


Thanks,

Colm O hEigeartaigh

Re: Review Request 59255: Some users hope that the pid file of the Ranger Admin can be unified management when they integrate Ranger into the big data platform or business systems to uniform install a

[Colm O hEigeartaigh]

> On May 13, 2017, 1:46 p.m., Velmurugan Periasamy wrote:
> > embeddedwebserver/scripts/ranger-admin-services.sh
> > Lines 71 (patched)
> > 
> >
> > Users can set RANGER_PID_DIR_PATH if they don't want to use default 
> > path. So what is the need for an additional variable?
> 
> pengjianhua wrote:
> This function is perfect if user independently use our ranger. 
> There is defect for ranger when they integrate Ranger into the big data 
> platform or business systems to uniform install and run Ranger. These systems 
> require services to support multiple instances, that is, the same service can 
> been run multiple instances in the same node. These systems need to 
> dynamically change the pid file path to avoid conflicts when they run 
> service. They hope that ranger also has the ability to dynamically change the 
> pid path at startup. 
> We should meet this need by minor modifications without affecting the 
> current function and logic.
> 
> Colm O hEigeartaigh wrote:
> I think it would be better if we kept the functionality of 
> RANGER_PID_DIR_PATH as it is, but instead used RANGER_ADMIN_PID_NAME or 
> something which would default to "rangeradmin.pid". So if you want to 
> customise it you can change the path via RANGER_PID_DIR_PATH and the filename 
> via RANGER_ADMIN_PID_NAME.
> 
> Gautam Borad wrote:
> +1 for Colm's suggestions.
> 
> Qiang Zhang wrote:
> +1 for Colm's suggestions.
> 
> pengjianhua wrote:
> The RANGER_PID_DIR_PATH variable was set when installing Ranger Admin. So 
> the value for RANGER_PID_DIR_PATH variable can not be changed after install 
> Ranger Admin. The user can only change the pid name and can not change the 
> path according to Colm's opinion.
> 1. The value for RANGER_PID_DIR_PATH was writed to 
> ./ews/webapp/WEB-INF/classes/conf/ranger-admin-env-piddir.sh file when 
> installing Ranger Admin.
> 2. Get the value for RANGER_PID_DIR_PATH through following code when run 
> Ranger Admin service.
> for custom_env_script in `find 
> ${XAPOLICYMGR_DIR}/ews/webapp/WEB-INF/classes/conf/ -name 
> "ranger-admin-env*"`; do
> if [ -f $custom_env_script ]; then
> . $custom_env_script
> fi
> done
> 
> Hi Colm, Do you have better opinion? Thanks!
> 
> Qiang Zhang wrote:
> Hi Colm, I think that pengjianhua's modification logic is also very 
> reasonable. In the case of meeting new needs, his logic is very well 
> compatible with the existing logic and does not introduce new problems.
> About your opinion and his logic, do you think which is more appropriate 
> to submit this issue? I tend to his logic after reading his explanation.

Is it possible to modify the logic of the "for custom_env_script" above so that 
it only sets e.g. RANGER_PID_DIR_PATH if there isn't a user (runtime) defined 
value for it already?


- Colm


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59255/#review174894
---


On May 13, 2017, 7:14 a.m., pengjianhua wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59255/
> ---
> 
> (Updated May 13, 2017, 7:14 a.m.)
> 
> 
> Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O 
> hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan 
> Neethiraj, Velmurugan Periasamy, and Qiang Zhang.
> 
> 
> Bugs: RANGER-1575
> https://issues.apache.org/jira/browse/RANGER-1575
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> Some users hope that the pid file of the Ranger Admin can be unified 
> management when they integrate Ranger into the big data platform or business 
> systems to uniform install and run Ranger.
> We should support the need in the case of compatibility with existing logic. 
> When running ranger, users can set the pid file to meet their own needs.
> 
> We will explicitly document this change in the next release.
> 
> 
> Diffs
> -
> 
>   embeddedwebserver/scripts/ranger-admin-services.sh a81219b 
> 
> 
> Diff: https://reviews.apache.org/r/59255/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> pengjianhua
> 
>

[jira] [Resolved] (RANGER-1591) The log is inconsistent with the code in ServiceDBStore class,update it to ensure their consistency.

[Qiang Zhang (JIRA)]

 [ 
https://issues.apache.org/jira/browse/RANGER-1591?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Qiang Zhang resolved RANGER-1591.
-
   Resolution: Fixed
Fix Version/s: 1.0.0

> The log is inconsistent with the code in ServiceDBStore class,update it to 
> ensure their consistency.
> 
>
> Key: RANGER-1591
> URL: https://issues.apache.org/jira/browse/RANGER-1591
> Project: Ranger
>  Issue Type: Bug
>  Components: admin
>Affects Versions: 1.0.0
>Reporter: Qiang Zhang
>Assignee: Qiang Zhang
>Priority: Trivial
>  Labels: patch
> Fix For: 1.0.0
>
> Attachments: 
> 0001-RANGER-1591-The-log-is-inconsistent-with-the-code-in.patch
>
>
> The log is inconsistent with the code in ServiceDBStore class,update it to 
> ensure their consistency.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Re: Review Request 58697: RANGER-1542:Exceptions occured when I test connection during create a new service for atlas-plugin

[Colm O hEigeartaigh]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58697/#review175480
---


Ship it!




Ship It!

- Colm O hEigeartaigh


On April 28, 2017, 1:21 a.m., Qiang Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58697/
> ---
> 
> (Updated April 28, 2017, 1:21 a.m.)
> 
> 
> Review request for ranger, Don Bosco Durai, Colm O hEigeartaigh, Ramesh Mani, 
> and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-1542
> https://issues.apache.org/jira/browse/RANGER-1542
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> there is a bug, as follows:
> 
> try {
>   decryptedPwd = PasswordUtils.decryptPassword(password);
>   } catch (Exception ex) {
>   LOG.info("Password decryption failed; trying Atlas connection with 
> received password string");
>   decryptedPwd = null;
>   } finally {
>   if (decryptedPwd == null) {
>   decryptedPwd = password;
>   }
>   }
>   formData.add("j_password", PasswordUtils.decryptPassword(password));
> 
> we should change the code 'formData.add("j_password", 
> PasswordUtils.decryptPassword(password));'
> to 'formData.add("j_password", decryptedPwd);'.
> 
> 
> Error message poped out as below:
> 2017-04-25 07:02:20,358 [timed-executor-pool-0] ERROR 
> org.apache.ranger.plugin.util.PasswordUtils (PasswordUtils.java:127) - Unable 
> to decrypt password due to error
> javax.crypto.BadPaddingException: Given final block not properly padded
>   at com.sun.crypto.provider.CipherCore.doFinal(CipherCore.java:811)
>   at com.sun.crypto.provider.CipherCore.doFinal(CipherCore.java:676)
>   at com.sun.crypto.provider.PBECipherCore.doFinal(PBECipherCore.java:422)
>   at 
> com.sun.crypto.provider.PBEWithMD5AndDESCipher.engineDoFinal(PBEWithMD5AndDESCipher.java:316)
>   at javax.crypto.Cipher.doFinal(Cipher.java:2131)
>   at 
> org.apache.ranger.plugin.util.PasswordUtils.decryptPassword(PasswordUtils.java:112)
>   at 
> org.apache.ranger.services.atlas.client.AtlasClient.getStatusResponse(AtlasClient.java:183)
>   at 
> org.apache.ranger.services.atlas.client.AtlasClient.connectionTestResource(AtlasClient.java:227)
>   at 
> org.apache.ranger.services.atlas.client.AtlasClient$1$1.run(AtlasClient.java:123)
>   at 
> org.apache.ranger.services.atlas.client.AtlasClient$1$1.run(AtlasClient.java:114)
>   at java.security.AccessController.doPrivileged(Native Method)
>   at javax.security.auth.Subject.doAs(Subject.java:356)
>   at 
> org.apache.ranger.services.atlas.client.AtlasClient$1.call(AtlasClient.java:114)
>   at 
> org.apache.ranger.services.atlas.client.AtlasClient$1.call(AtlasClient.java:107)
>   at 
> org.apache.ranger.services.atlas.client.AtlasClient.timedTask(AtlasClient.java:692)
>   at 
> org.apache.ranger.services.atlas.client.AtlasClient.getResourceList(AtlasClient.java:161)
>   at 
> org.apache.ranger.services.atlas.client.AtlasClient.getAtlasResource(AtlasClient.java:673)
>   at 
> org.apache.ranger.services.atlas.client.AtlasClient.connectionTest(AtlasClient.java:619)
>   at 
> org.apache.ranger.services.atlas.client.AtlasResourceMgr.validateConfig(AtlasResourceMgr.java:40)
>   at 
> org.apache.ranger.services.atlas.RangerServiceAtlas.validateConfig(RangerServiceAtlas.java:58)
>   at 
> org.apache.ranger.biz.ServiceMgr$ValidateCallable.actualCall(ServiceMgr.java:563)
>   at 
> org.apache.ranger.biz.ServiceMgr$ValidateCallable.actualCall(ServiceMgr.java:550)
>   at 
> org.apache.ranger.biz.ServiceMgr$TimedCallable.call(ServiceMgr.java:511)
>   at java.util.concurrent.FutureTask.run(FutureTask.java:262)
>   at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
>   at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
>   at java.lang.Thread.run(Thread.java:745)
> 2017-04-25 07:02:20,358 [timed-executor-pool-0] INFO  
> apache.ranger.services.atlas.client.AtlasClient (AtlasClient.java:185) - 
> Password decryption failed; trying Atlas connection with received password 
> string
> 2017-04-25 07:02:20,359 [timed-executor-pool-0] ERROR 
> org.apache.ranger.plugin.util.PasswordUtils (PasswordUtils.java:127) - Unable 
> to decrypt password due to error
> javax.crypto.BadPaddingException: Given final block not properly padded
>   at com.sun.crypto.provider.CipherCore.doFinal(CipherCore.java:811)
>   at com.sun.crypto.provider.CipherCore.doFinal(CipherCore.java:676)
>   at com.sun.crypto.provider.PBECipherCore.doFinal(PBECipherCore.java:422)
>   at 
> 

[jira] [Resolved] (RANGER-1589) Ranger build fails when python3 is the default

[Colm O hEigeartaigh (JIRA)]

 [ 
https://issues.apache.org/jira/browse/RANGER-1589?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Colm O hEigeartaigh resolved RANGER-1589.
-
Resolution: Fixed

> Ranger build fails when python3 is the default
> --
>
> Key: RANGER-1589
> URL: https://issues.apache.org/jira/browse/RANGER-1589
> Project: Ranger
>  Issue Type: Bug
>  Components: Ranger
>Affects Versions: 0.7.0, master
> Environment: Mac OS Sierra, python3 by default.
>Reporter: Denes Bodo
>Priority: Minor
>  Labels: build, easyfix, newbie
> Fix For: 1.0.0
>
> Attachments: 
> 0001-RANGER-1589-fix-build-ranger-utils-python-version-wa.patch
>
>
> When python3 is the default python version on the computer Ranger build fails.
> {noformat}
> [ERROR] Failed to execute goal 
> org.apache.maven.plugins:maven-antrun-plugin:1.7:run 
> (generate-version-annotation) on project ranger-util: An Ant BuildException 
> has occured: exec returned: 1
> [ERROR] around Ant part .. @ 
> 4:48 in 
> /Users/dbodo/work/repos/ranger/ranger-util/target/antrun/build-main.xml
> {noformat}
> I recommend to use "python2" instead of "python".



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Resolved] (RANGER-1590) Modify code for the error logs in ranger\knox-agent\src\main\java\org\apache\ranger\services\knox\client\KnoxClient.java

[Colm O hEigeartaigh (JIRA)]

 [ 
https://issues.apache.org/jira/browse/RANGER-1590?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Colm O hEigeartaigh resolved RANGER-1590.
-
Resolution: Fixed

> Modify code for the error logs in 
> ranger\knox-agent\src\main\java\org\apache\ranger\services\knox\client\KnoxClient.java
> 
>
> Key: RANGER-1590
> URL: https://issues.apache.org/jira/browse/RANGER-1590
> Project: Ranger
>  Issue Type: Improvement
>  Components: plugins
>Affects Versions: master
>Reporter: peng.jianhua
>Assignee: peng.jianhua
> Fix For: 1.0.0
>
>
> modify code for the error logs in 
> ranger\knox-agent\src\main\java\org\apache\ranger\services\knox\client\KnoxClient.java
> chang   from LOG.debug("Knox service look up response JSON string: " + 
> jsonString);to  LOG.debug("Knox service lookup response JSON string: 
> " + jsonString);
> Reason :keep the log consistent:
> response = webResource.accept(EXPECTED_MIME_TYPE)
>   
> .get(ClientResponse.class);
>   LOG.debug("Knox service lookup 
> response: " + response);
>   if (response != null) {
>   if (response.getStatus() == 
> 200) {
>   String jsonString = 
> response.getEntity(String.class);
>   LOG.debug("Knox service 
> lookup response JSON string: " + jsonString);



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Re: Review Request 59390: The log is inconsistent with the code in ServiceDBStore class, update it to ensure their consistency.

[Colm O hEigeartaigh]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59390/#review175479
---


Ship it!




Ship It!

- Colm O hEigeartaigh


On May 19, 2017, 7:28 a.m., Qiang Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59390/
> ---
> 
> (Updated May 19, 2017, 7:28 a.m.)
> 
> 
> Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O 
> hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan 
> Neethiraj, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-1591
> https://issues.apache.org/jira/browse/RANGER-1591
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> The log is inconsistent with the code in ServiceDBStore class,update it to 
> ensure their consistency.
> 
> 
> Diffs
> -
> 
>   security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java 
> a44aa46 
> 
> 
> Diff: https://reviews.apache.org/r/59390/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Qiang Zhang
> 
>

Re: Review Request 59388: Modify code for the error logs in KnoxClient.java

[Colm O hEigeartaigh]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59388/#review175478
---


Ship it!




Ship It!

- Colm O hEigeartaigh


On May 19, 2017, 7:26 a.m., pengjianhua wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59388/
> ---
> 
> (Updated May 19, 2017, 7:26 a.m.)
> 
> 
> Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O 
> hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan 
> Neethiraj, Velmurugan Periasamy, and Qiang Zhang.
> 
> 
> Bugs: RANGER-1590
> https://issues.apache.org/jira/browse/RANGER-1590
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> modify code for the error logs in 
> ranger\knox-agent\src\main\java\org\apache\ranger\services\knox\client\KnoxClient.java
> chang from LOG.debug("Knox service look up response JSON string: " + 
> jsonString); to  LOG.debug("Knox service lookup response JSON string: " + 
> jsonString);
> Reason :keep the log consistent:
> response = webResource.accept(EXPECTED_MIME_TYPE)
> .get(ClientResponse.class);
> LOG.debug("Knox service lookup response: " + response);
> if (response != null) {
> if (response.getStatus() == 200) {
> String jsonString = response.getEntity(String.class);
> LOG.debug("Knox service lookup response JSON string: " + jsonString);
> 
> 
> Diffs
> -
> 
>   
> knox-agent/src/main/java/org/apache/ranger/services/knox/client/KnoxClient.java
>  ec08ae8 
> 
> 
> Diff: https://reviews.apache.org/r/59388/diff/1/
> 
> 
> Testing
> ---
> 
> tested it
> 
> 
> Thanks,
> 
> pengjianhua
> 
>

[jira] [Updated] (RANGER-1590) Modify code for the error logs in ranger\knox-agent\src\main\java\org\apache\ranger\services\knox\client\KnoxClient.java

[Colm O hEigeartaigh (JIRA)]

 [ 
https://issues.apache.org/jira/browse/RANGER-1590?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Colm O hEigeartaigh updated RANGER-1590:

Fix Version/s: 1.0.0

> Modify code for the error logs in 
> ranger\knox-agent\src\main\java\org\apache\ranger\services\knox\client\KnoxClient.java
> 
>
> Key: RANGER-1590
> URL: https://issues.apache.org/jira/browse/RANGER-1590
> Project: Ranger
>  Issue Type: Improvement
>  Components: plugins
>Affects Versions: master
>Reporter: peng.jianhua
>Assignee: peng.jianhua
> Fix For: 1.0.0
>
>
> modify code for the error logs in 
> ranger\knox-agent\src\main\java\org\apache\ranger\services\knox\client\KnoxClient.java
> chang   from LOG.debug("Knox service look up response JSON string: " + 
> jsonString);to  LOG.debug("Knox service lookup response JSON string: 
> " + jsonString);
> Reason :keep the log consistent:
> response = webResource.accept(EXPECTED_MIME_TYPE)
>   
> .get(ClientResponse.class);
>   LOG.debug("Knox service lookup 
> response: " + response);
>   if (response != null) {
>   if (response.getStatus() == 
> 200) {
>   String jsonString = 
> response.getEntity(String.class);
>   LOG.debug("Knox service 
> lookup response JSON string: " + jsonString);



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Re: Review Request 59363: RANGER-1588 - Simplify Storm Test config

[Colm O hEigeartaigh]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59363/
---

(Updated May 19, 2017, 8:55 a.m.)


Review request for ranger.


Changes
---

N/A


Bugs: RANGER-1588
https://issues.apache.org/jira/browse/RANGER-1588


Repository: ranger


Description (updated)
---

The Storm test config has way too many un-needed properties defined.


Diffs
-

  storm-agent/src/test/resources/storm.yaml a3069663 


Diff: https://reviews.apache.org/r/59363/diff/1/


Testing
---


Thanks,

Colm O hEigeartaigh

Re: Review Request 59255: Some users hope that the pid file of the Ranger Admin can be unified management when they integrate Ranger into the big data platform or business systems to uniform install a

[Qiang Zhang]

> On 五月 13, 2017, 1:46 p.m., Velmurugan Periasamy wrote:
> > embeddedwebserver/scripts/ranger-admin-services.sh
> > Lines 71 (patched)
> > 
> >
> > Users can set RANGER_PID_DIR_PATH if they don't want to use default 
> > path. So what is the need for an additional variable?
> 
> pengjianhua wrote:
> This function is perfect if user independently use our ranger. 
> There is defect for ranger when they integrate Ranger into the big data 
> platform or business systems to uniform install and run Ranger. These systems 
> require services to support multiple instances, that is, the same service can 
> been run multiple instances in the same node. These systems need to 
> dynamically change the pid file path to avoid conflicts when they run 
> service. They hope that ranger also has the ability to dynamically change the 
> pid path at startup. 
> We should meet this need by minor modifications without affecting the 
> current function and logic.
> 
> Colm O hEigeartaigh wrote:
> I think it would be better if we kept the functionality of 
> RANGER_PID_DIR_PATH as it is, but instead used RANGER_ADMIN_PID_NAME or 
> something which would default to "rangeradmin.pid". So if you want to 
> customise it you can change the path via RANGER_PID_DIR_PATH and the filename 
> via RANGER_ADMIN_PID_NAME.
> 
> Gautam Borad wrote:
> +1 for Colm's suggestions.
> 
> Qiang Zhang wrote:
> +1 for Colm's suggestions.
> 
> pengjianhua wrote:
> The RANGER_PID_DIR_PATH variable was set when installing Ranger Admin. So 
> the value for RANGER_PID_DIR_PATH variable can not be changed after install 
> Ranger Admin. The user can only change the pid name and can not change the 
> path according to Colm's opinion.
> 1. The value for RANGER_PID_DIR_PATH was writed to 
> ./ews/webapp/WEB-INF/classes/conf/ranger-admin-env-piddir.sh file when 
> installing Ranger Admin.
> 2. Get the value for RANGER_PID_DIR_PATH through following code when run 
> Ranger Admin service.
> for custom_env_script in `find 
> ${XAPOLICYMGR_DIR}/ews/webapp/WEB-INF/classes/conf/ -name 
> "ranger-admin-env*"`; do
> if [ -f $custom_env_script ]; then
> . $custom_env_script
> fi
> done
> 
> Hi Colm, Do you have better opinion? Thanks!

Hi Colm, I think that pengjianhua's modification logic is also very reasonable. 
In the case of meeting new needs, his logic is very well compatible with the 
existing logic and does not introduce new problems.
About your opinion and his logic, do you think which is more appropriate to 
submit this issue? I tend to his logic after reading his explanation.


- Qiang


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59255/#review174894
---


On 五月 13, 2017, 7:14 a.m., pengjianhua wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59255/
> ---
> 
> (Updated 五月 13, 2017, 7:14 a.m.)
> 
> 
> Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O 
> hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan 
> Neethiraj, Velmurugan Periasamy, and Qiang Zhang.
> 
> 
> Bugs: RANGER-1575
> https://issues.apache.org/jira/browse/RANGER-1575
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> Some users hope that the pid file of the Ranger Admin can be unified 
> management when they integrate Ranger into the big data platform or business 
> systems to uniform install and run Ranger.
> We should support the need in the case of compatibility with existing logic. 
> When running ranger, users can set the pid file to meet their own needs.
> 
> We will explicitly document this change in the next release.
> 
> 
> Diffs
> -
> 
>   embeddedwebserver/scripts/ranger-admin-services.sh a81219b 
> 
> 
> Diff: https://reviews.apache.org/r/59255/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> pengjianhua
> 
>

[jira] [Updated] (RANGER-1591) The log is inconsistent with the code in ServiceDBStore class,update it to ensure their consistency.

[Qiang Zhang (JIRA)]

 [ 
https://issues.apache.org/jira/browse/RANGER-1591?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Qiang Zhang updated RANGER-1591:

Attachment: 0001-RANGER-1591-The-log-is-inconsistent-with-the-code-in.patch

> The log is inconsistent with the code in ServiceDBStore class,update it to 
> ensure their consistency.
> 
>
> Key: RANGER-1591
> URL: https://issues.apache.org/jira/browse/RANGER-1591
> Project: Ranger
>  Issue Type: Bug
>  Components: admin
>Affects Versions: 1.0.0
>Reporter: Qiang Zhang
>Assignee: Qiang Zhang
>Priority: Trivial
>  Labels: patch
> Attachments: 
> 0001-RANGER-1591-The-log-is-inconsistent-with-the-code-in.patch
>
>
> The log is inconsistent with the code in ServiceDBStore class,update it to 
> ensure their consistency.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Review Request 59390: The log is inconsistent with the code in ServiceDBStore class, update it to ensure their consistency.

[Qiang Zhang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59390/
---

Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O 
hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan 
Neethiraj, and Velmurugan Periasamy.


Bugs: RANGER-1591
https://issues.apache.org/jira/browse/RANGER-1591


Repository: ranger


Description
---

The log is inconsistent with the code in ServiceDBStore class,update it to 
ensure their consistency.


Diffs
-

  security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java 
a44aa46 


Diff: https://reviews.apache.org/r/59390/diff/1/


Testing
---


Thanks,

Qiang Zhang

[jira] [Updated] (RANGER-1590) Modify code for the error logs in ranger\knox-agent\src\main\java\org\apache\ranger\services\knox\client\KnoxClient.java

[peng.jianhua (JIRA)]

 [ 
https://issues.apache.org/jira/browse/RANGER-1590?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

peng.jianhua updated RANGER-1590:
-
Summary: Modify code for the error logs in 
ranger\knox-agent\src\main\java\org\apache\ranger\services\knox\client\KnoxClient.java
  (was: modify code for the error logs in 
ranger\knox-agent\src\main\java\org\apache\ranger\services\knox\client\KnoxClient.java)

> Modify code for the error logs in 
> ranger\knox-agent\src\main\java\org\apache\ranger\services\knox\client\KnoxClient.java
> 
>
> Key: RANGER-1590
> URL: https://issues.apache.org/jira/browse/RANGER-1590
> Project: Ranger
>  Issue Type: Improvement
>  Components: plugins
>Affects Versions: master
>Reporter: peng.jianhua
>Assignee: peng.jianhua
>
> modify code for the error logs in 
> ranger\knox-agent\src\main\java\org\apache\ranger\services\knox\client\KnoxClient.java
> chang   from LOG.debug("Knox service look up response JSON string: " + 
> jsonString);to  LOG.debug("Knox service lookup response JSON string: 
> " + jsonString);
> Reason :keep the log consistent:
> response = webResource.accept(EXPECTED_MIME_TYPE)
>   
> .get(ClientResponse.class);
>   LOG.debug("Knox service lookup 
> response: " + response);
>   if (response != null) {
>   if (response.getStatus() == 
> 200) {
>   String jsonString = 
> response.getEntity(String.class);
>   LOG.debug("Knox service 
> lookup response JSON string: " + jsonString);



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Re: Review Request 59388: Modify code for the error logs in KnoxClient.java

[pengjianhua]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59388/
---

(Updated 五月 19, 2017, 7:26 a.m.)


Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O 
hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan 
Neethiraj, Velmurugan Periasamy, and Qiang Zhang.


Summary (updated)
-

Modify code for the error logs in KnoxClient.java


Bugs: RANGER-1590
https://issues.apache.org/jira/browse/RANGER-1590


Repository: ranger


Description
---

modify code for the error logs in 
ranger\knox-agent\src\main\java\org\apache\ranger\services\knox\client\KnoxClient.java
chang from LOG.debug("Knox service look up response JSON string: " + 
jsonString); toLOG.debug("Knox service lookup response JSON string: " + 
jsonString);
Reason :keep the log consistent:
response = webResource.accept(EXPECTED_MIME_TYPE)
.get(ClientResponse.class);
LOG.debug("Knox service lookup response: " + response);
if (response != null) {
if (response.getStatus() == 200) {
String jsonString = response.getEntity(String.class);
LOG.debug("Knox service lookup response JSON string: " + jsonString);


Diffs
-

  
knox-agent/src/main/java/org/apache/ranger/services/knox/client/KnoxClient.java 
ec08ae8 


Diff: https://reviews.apache.org/r/59388/diff/1/


Testing
---

tested it


Thanks,

pengjianhua

Review Request 59388: modify code for the error logs in KnoxClient.java

[pengjianhua]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59388/
---

Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O 
hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan 
Neethiraj, Velmurugan Periasamy, and Qiang Zhang.


Bugs: RANGER-1590
https://issues.apache.org/jira/browse/RANGER-1590


Repository: ranger


Description
---

modify code for the error logs in 
ranger\knox-agent\src\main\java\org\apache\ranger\services\knox\client\KnoxClient.java
chang from LOG.debug("Knox service look up response JSON string: " + 
jsonString); toLOG.debug("Knox service lookup response JSON string: " + 
jsonString);
Reason :keep the log consistent:
response = webResource.accept(EXPECTED_MIME_TYPE)
.get(ClientResponse.class);
LOG.debug("Knox service lookup response: " + response);
if (response != null) {
if (response.getStatus() == 200) {
String jsonString = response.getEntity(String.class);
LOG.debug("Knox service lookup response JSON string: " + jsonString);


Diffs
-

  
knox-agent/src/main/java/org/apache/ranger/services/knox/client/KnoxClient.java 
ec08ae8 


Diff: https://reviews.apache.org/r/59388/diff/1/


Testing
---

tested it


Thanks,

pengjianhua

[jira] [Updated] (RANGER-1590) modify code for the error logs in ranger\knox-agent\src\main\java\org\apache\ranger\services\knox\client\KnoxClient.java

[peng.jianhua (JIRA)]

 [ 
https://issues.apache.org/jira/browse/RANGER-1590?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

peng.jianhua updated RANGER-1590:
-
Description: 
modify code for the error logs in 
ranger\knox-agent\src\main\java\org\apache\ranger\services\knox\client\KnoxClient.java
chang   LOG.debug("Knox service look up 
response JSON string: " + jsonString);
to  LOG.debug("Knox service lookup 
response JSON string: " + jsonString);

reson :keep the log consistent:
response = webResource.accept(EXPECTED_MIME_TYPE)

.get(ClientResponse.class);
LOG.debug("Knox service lookup 
response: " + response);
if (response != null) {

if (response.getStatus() == 
200) {
String jsonString = 
response.getEntity(String.class);
LOG.debug("Knox service 
lookup response JSON string: " + jsonString);

> modify code for the error logs in 
> ranger\knox-agent\src\main\java\org\apache\ranger\services\knox\client\KnoxClient.java
> 
>
> Key: RANGER-1590
> URL: https://issues.apache.org/jira/browse/RANGER-1590
> Project: Ranger
>  Issue Type: Improvement
>  Components: plugins
>Affects Versions: master
>Reporter: peng.jianhua
>Assignee: peng.jianhua
>
> modify code for the error logs in 
> ranger\knox-agent\src\main\java\org\apache\ranger\services\knox\client\KnoxClient.java
> chang LOG.debug("Knox service 
> look up response JSON string: " + jsonString);
> toLOG.debug("Knox service lookup 
> response JSON string: " + jsonString);
> reson :keep the log consistent:
> response = webResource.accept(EXPECTED_MIME_TYPE)
>   
> .get(ClientResponse.class);
>   LOG.debug("Knox service lookup 
> response: " + response);
>   if (response != null) {
>   if (response.getStatus() == 
> 200) {
>   String jsonString = 
> response.getEntity(String.class);
>   LOG.debug("Knox service 
> lookup response JSON string: " + jsonString);



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Created] (RANGER-1591) The log is inconsistent with the code in ServiceDBStore class,update it to ensure their consistency.

[Qiang Zhang (JIRA)]

Qiang Zhang created RANGER-1591:
---

 Summary: The log is inconsistent with the code in ServiceDBStore 
class,update it to ensure their consistency.
 Key: RANGER-1591
 URL: https://issues.apache.org/jira/browse/RANGER-1591
 Project: Ranger
  Issue Type: Bug
  Components: admin
Affects Versions: 1.0.0
Reporter: Qiang Zhang
Assignee: Qiang Zhang
Priority: Trivial


The log is inconsistent with the code in ServiceDBStore class,update it to 
ensure their consistency.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Created] (RANGER-1590) modify code for the error logs in ranger\knox-agent\src\main\java\org\apache\ranger\services\knox\client\KnoxClient.java

[peng.jianhua (JIRA)]

peng.jianhua created RANGER-1590:


 Summary: modify code for the error logs in 
ranger\knox-agent\src\main\java\org\apache\ranger\services\knox\client\KnoxClient.java
 Key: RANGER-1590
 URL: https://issues.apache.org/jira/browse/RANGER-1590
 Project: Ranger
  Issue Type: Improvement
  Components: plugins
Affects Versions: master
Reporter: peng.jianhua
Assignee: peng.jianhua






--
This message was sent by Atlassian JIRA
(v6.3.15#6346)