Re: RANGER-2395

2019-04-10 Thread Abhay Kulkarni 
Hi Bolke,

Could you please create a review request (
https://reviews.apache.org/dashboard/)  using attached patch for getting it
reviewed?

Thanks,
-Abhay

Re: Review Request 70389: RANGER-2394 - filter multiple users or exclude multiple users in audit search

2019-04-10 Thread Velmurugan Periasamy 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70389/#review214542
---




security-admin/src/main/java/org/apache/ranger/rest/AssetREST.java
Line 629 (original), 629 (patched)


Seems like this is failing unit tests. Could you please take a look and 
resolve? 

```
Failed tests:
  TestAssetREST.testGetAccessLogs:764
searchUtil.extractString(
,
,
,
,
or(isA(java.lang.String), isNull())
);
Wanted 14 times:
-> at 
org.apache.ranger.rest.TestAssetREST.testGetAccessLogs(TestAssetREST.java:764)
But was 13 times:
-> at org.apache.ranger.rest.AssetREST.getAccessLogs(AssetREST.java:619)
-> at org.apache.ranger.rest.AssetREST.getAccessLogs(AssetREST.java:621)
-> at org.apache.ranger.rest.AssetREST.getAccessLogs(AssetREST.java:623)
-> at org.apache.ranger.rest.AssetREST.getAccessLogs(AssetREST.java:625)
-> at org.apache.ranger.rest.AssetREST.getAccessLogs(AssetREST.java:627)
-> at org.apache.ranger.rest.AssetREST.getAccessLogs(AssetREST.java:633)
-> at org.apache.ranger.rest.AssetREST.getAccessLogs(AssetREST.java:635)
-> at org.apache.ranger.rest.AssetREST.getAccessLogs(AssetREST.java:637)
-> at org.apache.ranger.rest.AssetREST.getAccessLogs(AssetREST.java:639)
-> at org.apache.ranger.rest.AssetREST.getAccessLogs(AssetREST.java:641)
-> at org.apache.ranger.rest.AssetREST.getAccessLogs(AssetREST.java:654)
-> at org.apache.ranger.rest.AssetREST.getAccessLogs(AssetREST.java:655)
-> at org.apache.ranger.rest.AssetREST.getAccessLogs(AssetREST.java:656)

  TestAssetREST.testGetAccessLogsForKms:807
searchUtil.extractString(
,
,
,
,
or(isA(java.lang.String), isNull())
);
Wanted 14 times:
-> at 
org.apache.ranger.rest.TestAssetREST.testGetAccessLogsForKms(TestAssetREST.java:807)
But was 13 times:
-> at org.apache.ranger.rest.AssetREST.getAccessLogs(AssetREST.java:619)
-> at org.apache.ranger.rest.AssetREST.getAccessLogs(AssetREST.java:621)
-> at org.apache.ranger.rest.AssetREST.getAccessLogs(AssetREST.java:623)
-> at org.apache.ranger.rest.AssetREST.getAccessLogs(AssetREST.java:625)
-> at org.apache.ranger.rest.AssetREST.getAccessLogs(AssetREST.java:627)
-> at org.apache.ranger.rest.AssetREST.getAccessLogs(AssetREST.java:633)
-> at org.apache.ranger.rest.AssetREST.getAccessLogs(AssetREST.java:635)
-> at org.apache.ranger.rest.AssetREST.getAccessLogs(AssetREST.java:637)
-> at org.apache.ranger.rest.AssetREST.getAccessLogs(AssetREST.java:639)
-> at org.apache.ranger.rest.AssetREST.getAccessLogs(AssetREST.java:641)
-> at org.apache.ranger.rest.AssetREST.getAccessLogs(AssetREST.java:654)
-> at org.apache.ranger.rest.AssetREST.getAccessLogs(AssetREST.java:655)
-> at org.apache.ranger.rest.AssetREST.getAccessLogs(AssetREST.java:656)
```


- Velmurugan Periasamy


On April 4, 2019, 6:13 p.m., Zsombor Gegesy wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70389/
> ---
> 
> (Updated April 4, 2019, 6:13 p.m.)
> 
> 
> Review request for ranger.
> 
> 
> Bugs: RANGER-2394
> https://issues.apache.org/jira/browse/RANGER-2394
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> Currently the audit search only allows to:
> 
> * filter to one user's activity
> * exclude all 'service users' from every user's activity.
> 
> If there were way to search for multiple users or exclude multiple users from 
> the search list, it would make debugging complex interactions simpler, for 
> example only look for actions for 'alice' and 'hive' and 'yarn'
> 
> The frontend tweaked a bit, so if multiple users are passed to the jquery 
> layer, the user names are always converted as 
> requestUser=aaa=bbb=ccc instead of changing to 
> requestUser[]=aaa[]=bbb[]=ccc, which would be an 
> incompatible change between the server and to any potential client code.
> 
> 
> Diffs
> -
> 
>   security-admin/src/main/java/org/apache/ranger/rest/AssetREST.java 
> ce577e0fc 
>   security-admin/src/main/java/org/apache/ranger/rest/XAuditREST.java 
> fdf5ad86b 
>   
> security-admin/src/main/java/org/apache/ranger/solr/SolrAccessAuditsService.java
>  cf2a3b4d8 
>   security-admin/src/main/webapp/scripts/utils/XAUtils.js b14f4b918 
>   security-admin/src/main/webapp/scripts/views/reports/AuditLayout.js 
> e7b45d992 
> 
> 
> Diff: https://reviews.apache.org/r/70389/diff/1/
> 
> 
> Testing
> ---
> 
> Tested on a live cluster that:
> * searching for one user
> * searching for multiple users
> * excluding one user
> * excluding

Re: Review Request 70420: RANGER-2377 : Make solr bootstrapping configurable

2019-04-10 Thread Velmurugan Periasamy 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70420/#review214540
---


Ship it!




Ship It!

- Velmurugan Periasamy


On April 8, 2019, 6:17 a.m., bhavik patel wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70420/
> ---
> 
> (Updated April 8, 2019, 6:17 a.m.)
> 
> 
> Review request for ranger, Ankita Sinha, Don Bosco Durai, Gautam Borad, Abhay 
> Kulkarni, Madhan Neethiraj, Oliver Szabo, Pradeep Agrawal, Ramesh Mani, 
> Selvamohan Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-2377
> https://issues.apache.org/jira/browse/RANGER-2377
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> 1.) Solr Bootstrap needs to be configurable on ranger side.
> 2.) Restrict the maximum tries to connect solr in case when no live solr node 
> is available.
> 
> 
> Diffs
> -
> 
>   
> embeddedwebserver/src/main/java/org/apache/ranger/server/tomcat/EmbeddedServer.java
>  8633e00 
>   
> embeddedwebserver/src/main/java/org/apache/ranger/server/tomcat/SolrCollectionBoostrapper.java
>  0d85e91 
>   security-admin/src/main/resources/conf.dist/ranger-admin-default-site.xml 
> 189f7b8 
>   security-admin/src/main/resources/conf.dist/ranger-admin-site.xml 26a9d64 
> 
> 
> Diff: https://reviews.apache.org/r/70420/diff/1/
> 
> 
> Testing
> ---
> 
> Successfully tested the solr bootstrapping with below mentioned prop.
> 1.) ranger.audit.solr.bootstrap.enabled = true /false (default vaue is true)
> 2.) ranger.audit.solr.max.retry = 30 (default value ). No. of attempts made 
> to bootstrap solr in case of any failure will depends on this prop value.
> 
> 
> Thanks,
> 
> bhavik patel
> 
>

Re: Review Request 70432: RANGER-2387 : add public api v2 for security zones

2019-04-10 Thread Velmurugan Periasamy 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70432/#review214539
---




security-admin/src/main/java/org/apache/ranger/rest/PublicAPIsv2.java
Lines 112 (patched)


See my comment in https://reviews.apache.org/r/70447/

Please resolve the conflict.


- Velmurugan Periasamy


On April 9, 2019, 12:10 p.m., Nikhil P wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70432/
> ---
> 
> (Updated April 9, 2019, 12:10 p.m.)
> 
> 
> Review request for ranger, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, 
> Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, Sailaja Polavarapu, and 
> Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-2387
> https://issues.apache.org/jira/browse/RANGER-2387
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> add public api v2 for security zones
> 
> 
> Diffs
> -
> 
>   security-admin/src/main/java/org/apache/ranger/rest/PublicAPIsv2.java 
> 073404e 
> 
> 
> Diff: https://reviews.apache.org/r/70432/diff/1/
> 
> 
> Testing
> ---
> 
> 1.Tested Curl response of Public api v2 are correct.
> 2.validated response result for public API matches with SecurityZoneREST
> 
> 
> Thanks,
> 
> Nikhil P
> 
>

Re: [GitHub] [ranger] bolkedebruin opened a new pull request #36: Add Presto plugin

2019-04-10 Thread Bolke de Bruin 
Can I please get a review on this? 

Thanks!
Bolke

Sent from my iPhone

> On 6 Apr 2019, at 20:06, GitBox  wrote:
> 
> bolkedebruin opened a new pull request #36: Add Presto plugin
> URL: https://github.com/apache/ranger/pull/36
> 
> 
>   This implements a plugin for Presto, a distributed SQL
>   engine.
> 
>   * JIRA: https://issues.apache.org/jira/browse/RANGER-2395
> 
>   (this was submitted to the review board as an older version)
> 
> 
> This is an automated message from the Apache Git Service.
> To respond to the message, please log on to GitHub and use the
> URL above to go to the specific comment.
> 
> For queries about this service, please contact Infrastructure at:
> us...@infra.apache.org
> 
> 
> With regards,
> Apache Git Services

Re: Review Request 70351: RANGER-2389:Ranger Hive Plugin enhancement for KILL query and Replication commands authorization

2019-04-10 Thread Velmurugan Periasamy 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70351/#review214537
---


Ship it!




Ship It!

- Velmurugan Periasamy


On April 1, 2019, 7:57 p.m., Ramesh Mani wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70351/
> ---
> 
> (Updated April 1, 2019, 7:57 p.m.)
> 
> 
> Review request for ranger, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, 
> Madhan Neethiraj, Pradeep Agrawal, Selvamohan Neethiraj, Sailaja Polavarapu, 
> and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-2389
> https://issues.apache.org/jira/browse/RANGER-2389
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> RANGER-2389:Ranger Hive Plugin enhancement for KILL query and Replication 
> commands authorization
> 
> 
> Diffs
> -
> 
>   agents-common/src/main/resources/service-defs/ranger-servicedef-hive.json 
> b0f877a 
>   agents-common/src/test/resources/policyengine/test_policyengine_hive.json 
> b7f9888 
>   
> hive-agent/src/main/java/org/apache/ranger/authorization/hive/authorizer/RangerHiveAccessRequest.java
>  a8bf543 
>   
> hive-agent/src/main/java/org/apache/ranger/authorization/hive/authorizer/RangerHiveAuditHandler.java
>  ac35d77 
>   
> hive-agent/src/main/java/org/apache/ranger/authorization/hive/authorizer/RangerHiveAuthorizer.java
>  be82639 
>   
> hive-agent/src/main/java/org/apache/ranger/authorization/hive/authorizer/RangerHiveResource.java
>  48b8cb2 
>   
> hive-agent/src/test/java/org/apache/ranger/services/hive/HIVERangerAuthorizerTest.java
>  b04e8bc 
>   
> hive-agent/src/test/java/org/apache/ranger/services/hive/RangerHiveOperationType.java
>  PRE-CREATION 
>   
> hive-agent/src/test/java/org/apache/ranger/services/hive/TestAllHiveOperationInRanger.java
>  PRE-CREATION 
>   hive-agent/src/test/resources/hive-policies.json 3613206 
>   security-admin/src/main/java/org/apache/ranger/common/AppConstants.java 
> 09ed06a 
>   security-admin/src/main/java/org/apache/ranger/common/ServiceUtil.java 
> c82636a 
>   
> security-admin/src/main/java/org/apache/ranger/patch/PatchForHiveServiceDefUpdate_J10009.java
>  PRE-CREATION 
>   
> security-admin/src/main/java/org/apache/ranger/patch/PatchForHiveServiceDefUpdate_J10010.java
>  PRE-CREATION 
>   security-admin/src/main/java/org/apache/ranger/view/VXPolicy.java da7082d 
>   security-admin/src/main/java/org/apache/ranger/view/VXResource.java 8ce0ebe 
> 
> 
> Diff: https://reviews.apache.org/r/70351/diff/1/
> 
> 
> Testing
> ---
> 
> - Testing done in Local VM
> 
> 
> Thanks,
> 
> Ramesh Mani
> 
>

Re: Review Request 70426: RANGER-2400: policy name needs to be unique within security zone and service

2019-04-10 Thread Abhay Kulkarni 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70426/
---

(Updated April 10, 2019, 3:58 p.m.)


Review request for ranger, Madhan Neethiraj, Mehul Parikh, Nikhil P, Pradeep 
Agrawal, Ramesh Mani, and Velmurugan Periasamy.


Changes
---

Cleaned up SQL scripts


Bugs: RANGER-2400
https://issues.apache.org/jira/browse/RANGER-2400


Repository: ranger


Description
---

Ranger enforces uniqueness of policy name within a service. However, with 
introduction of security zones, policy name needs to be unique within a 
security zone and a service. This will obviate the need for inventing unique 
policy names if the policy is associated with the same service but different 
security zones, as well as present security zone as a namespace in Ranger admin 
as it does for making authorization decisions.


Diffs (updated)
-

  
agents-common/src/main/java/org/apache/ranger/plugin/model/validation/RangerPolicyValidator.java
 710e75d57 
  
agents-common/src/main/java/org/apache/ranger/plugin/model/validation/RangerValidator.java
 fa50ab2d6 
  agents-common/src/main/java/org/apache/ranger/plugin/store/ServiceStore.java 
9e37cd550 
  
agents-common/src/test/java/org/apache/ranger/plugin/model/validation/TestRangerPolicyValidator.java
 8cdb9c3a6 
  security-admin/db/mysql/optimized/current/ranger_core_db_mysql.sql 2eaffccac 
  
security-admin/db/mysql/patches/040-modify-unique-constraint-on-policy-table.sql
 PRE-CREATION 
  security-admin/db/oracle/optimized/current/ranger_core_db_oracle.sql 
5ca1e3667 
  
security-admin/db/oracle/patches/040-modify-unique-constraint-on-policy-table.sql
 PRE-CREATION 
  security-admin/db/postgres/optimized/current/ranger_core_db_postgres.sql 
51f4999f7 
  
security-admin/db/postgres/patches/040-modify-unique-constraint-on-policy-table.sql
 PRE-CREATION 
  
security-admin/db/sqlanywhere/optimized/current/ranger_core_db_sqlanywhere.sql 
5f64a2dba 
  
security-admin/db/sqlanywhere/patches/040-modify-unique-constraint-on-policy-table.sql
 PRE-CREATION 
  security-admin/db/sqlserver/optimized/current/ranger_core_db_sqlserver.sql 
fc21cec3e 
  
security-admin/db/sqlserver/patches/040-modify-unique-constraint-on-policy-table.sql
 PRE-CREATION 
  security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java 
574166c3d 
  security-admin/src/main/java/org/apache/ranger/db/XXPolicyDao.java 2a870efaa 
  
security-admin/src/main/java/org/apache/ranger/patch/PatchMigration_J10002.java 
0af7a1da2 
  security-admin/src/main/resources/META-INF/jpa_named_queries.xml 7e702c144 


Diff: https://reviews.apache.org/r/70426/diff/3/

Changes: https://reviews.apache.org/r/70426/diff/2-3/


Testing
---

Created security zone and ensured that the default policies created within zone 
have same names as corresponding default policies in unzoned zone. Ensured that 
within same zone (including unzoned zone), two policies with same name cannot 
be created.


Thanks,

Abhay Kulkarni

Re: Review Request 70447: RANGER-2384 : Get All Zones API is returning response in raw format, proper response object is required.

2019-04-10 Thread Abhay Kulkarni 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70447/#review214534
---


Ship it!




Ship It!

- Abhay Kulkarni


On April 10, 2019, 1:01 p.m., Nikhil P wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70447/
> ---
> 
> (Updated April 10, 2019, 1:01 p.m.)
> 
> 
> Review request for ranger, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, 
> Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, Sailaja Polavarapu, and 
> Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-2384
> https://issues.apache.org/jira/browse/RANGER-2384
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> Get All Zones API is returning response in raw format,proper response object 
> is required.
> 
> 
> Diffs
> -
> 
>   security-admin/src/main/java/org/apache/ranger/biz/SecurityZoneDBStore.java 
> 299e256 
>   security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java 
> 574166c 
>   security-admin/src/main/java/org/apache/ranger/rest/SecurityZoneREST.java 
> b8b8c1b 
>   
> security-admin/src/main/java/org/apache/ranger/service/RangerSecurityZoneService.java
>  04003f4 
>   
> security-admin/src/main/java/org/apache/ranger/service/RangerSecurityZoneServiceService.java
>  PRE-CREATION 
>   
> security-admin/src/main/java/org/apache/ranger/view/RangerSecurityZoneList.java
>  PRE-CREATION 
>   
> security-admin/src/main/webapp/scripts/collection_bases/RangerZoneListBase.js 
> 8180414 
>   security-admin/src/main/webapp/scripts/controllers/Controller.js 934a1a2 
>   security-admin/src/main/webapp/scripts/views/reports/UserAccessLayout.js 
> d2f8a91 
>   
> security-admin/src/test/java/org/apache/ranger/biz/TestSecurityZoneDBStore.java
>  3d7c3ef 
>   
> security-admin/src/test/java/org/apache/ranger/rest/TestSecurityZoneREST.java 
> e4b5a1b 
> 
> 
> Diff: https://reviews.apache.org/r/70447/diff/1/
> 
> 
> Testing
> ---
> 
> 1)Verified If proper response is coming in get All zones.
> 2)Tested on local VM.
> 
> 
> Thanks,
> 
> Nikhil P
> 
>

Review Request 70447: RANGER-2384 : Get All Zones API is returning response in raw format, proper response object is required.

2019-04-10 Thread Nikhil P 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70447/
---

Review request for ranger, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, 
Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, Sailaja Polavarapu, and 
Velmurugan Periasamy.


Bugs: RANGER-2384
https://issues.apache.org/jira/browse/RANGER-2384


Repository: ranger


Description
---

Get All Zones API is returning response in raw format,proper response object is 
required.


Diffs
-

  security-admin/src/main/java/org/apache/ranger/biz/SecurityZoneDBStore.java 
299e256 
  security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java 
574166c 
  security-admin/src/main/java/org/apache/ranger/rest/SecurityZoneREST.java 
b8b8c1b 
  
security-admin/src/main/java/org/apache/ranger/service/RangerSecurityZoneService.java
 04003f4 
  
security-admin/src/main/java/org/apache/ranger/service/RangerSecurityZoneServiceService.java
 PRE-CREATION 
  
security-admin/src/main/java/org/apache/ranger/view/RangerSecurityZoneList.java 
PRE-CREATION 
  security-admin/src/main/webapp/scripts/collection_bases/RangerZoneListBase.js 
8180414 
  security-admin/src/main/webapp/scripts/controllers/Controller.js 934a1a2 
  security-admin/src/main/webapp/scripts/views/reports/UserAccessLayout.js 
d2f8a91 
  
security-admin/src/test/java/org/apache/ranger/biz/TestSecurityZoneDBStore.java 
3d7c3ef 
  security-admin/src/test/java/org/apache/ranger/rest/TestSecurityZoneREST.java 
e4b5a1b 


Diff: https://reviews.apache.org/r/70447/diff/1/


Testing
---

1)Verified If proper response is coming in get All zones.
2)Tested on local VM.


Thanks,

Nikhil P

[jira] [Updated] (RANGER-2384) Get All Zones API is returning response in raw format,proper response object is required.

2019-04-10 Thread Nikhil Purbhe (JIRA) 


 [ 
https://issues.apache.org/jira/browse/RANGER-2384?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nikhil Purbhe updated RANGER-2384:
--
Attachment: RANGER-2384.patch

> Get All Zones API is returning response in raw format,proper response object 
> is required.
> -
>
> Key: RANGER-2384
> URL: https://issues.apache.org/jira/browse/RANGER-2384
> Project: Ranger
>  Issue Type: Bug
>  Components: Ranger
>Reporter: Nitin Galave
>Assignee: Nikhil Purbhe
>Priority: Major
> Fix For: master
>
> Attachments: RANGER-2384.patch
>
>
> Get All Zones API is returning response in raw format,proper response object 
> is required.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Re: Review Request 70376: RANGER-2392: Create / Update zone to have provision to associate Tag based service with zone

2019-04-10 Thread Pradeep Agrawal 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70376/#review214527
---




security-admin/db/sqlserver/optimized/current/ranger_core_db_sqlserver.sql
Lines 2272 (patched)


change this to tag_srvc_id



security-admin/db/sqlserver/optimized/current/ranger_core_db_sqlserver.sql
Lines 2273 (patched)


change this to tag_srvc_name


- Pradeep Agrawal


On April 9, 2019, 12:38 p.m., Nitin Galave wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70376/
> ---
> 
> (Updated April 9, 2019, 12:38 p.m.)
> 
> 
> Review request for ranger, Abhay Kulkarni, Mehul Parikh, Nikhil P, Pradeep 
> Agrawal, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-2392
> https://issues.apache.org/jira/browse/RANGER-2392
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> Currently, Resource-based services are associated with the zone as part of 
> zone creation.
> Need to add a feature to only associate Tag based service as part of zone.
> No need to add resources with tag-based service association.
> 
> 
> Diffs
> -
> 
>   
> agents-common/src/main/java/org/apache/ranger/plugin/model/RangerSecurityZone.java
>  547e2d2 
>   security-admin/db/mysql/optimized/current/ranger_core_db_mysql.sql 2eaffcc 
>   security-admin/db/mysql/patches/037-create-security-zone-schema.sql aff9786 
>   security-admin/db/oracle/optimized/current/ranger_core_db_oracle.sql 
> 5ca1e36 
>   security-admin/db/oracle/patches/037-create-security-zone-schema.sql 
> aae31dc 
>   security-admin/db/postgres/optimized/current/ranger_core_db_postgres.sql 
> 51f4999 
>   security-admin/db/postgres/patches/037-create-security-zone-schema.sql 
> 4a94d26 
>   
> security-admin/db/sqlanywhere/optimized/current/ranger_core_db_sqlanywhere.sql
>  5f64a2d 
>   security-admin/db/sqlanywhere/patches/037-create-security-zone-schema.sql 
> 5b7dade 
>   security-admin/db/sqlserver/optimized/current/ranger_core_db_sqlserver.sql 
> fc21cec 
>   security-admin/db/sqlserver/patches/037-create-security-zone-schema.sql 
> e621b43 
>   
> security-admin/src/main/java/org/apache/ranger/biz/SecurityZoneRefUpdater.java
>  2b0c462 
>   security-admin/src/main/java/org/apache/ranger/common/RangerConstants.java 
> cdb5e11 
>   security-admin/src/main/java/org/apache/ranger/db/RangerDaoManagerBase.java 
> 3599cf3 
>   
> security-admin/src/main/java/org/apache/ranger/db/XXSecurityZoneRefTagServiceDao.java
>  PRE-CREATION 
>   
> security-admin/src/main/java/org/apache/ranger/entity/XXSecurityZoneRefTagService.java
>  PRE-CREATION 
>   security-admin/src/main/java/org/apache/ranger/rest/SecurityZoneREST.java 
> b8b8c1b 
>   
> security-admin/src/main/java/org/apache/ranger/service/RangerSecurityZoneService.java
>  04003f4 
>   security-admin/src/main/resources/META-INF/jpa_named_queries.xml 7e702c1 
>   security-admin/src/main/webapp/scripts/models/RangerZone.js 4f99c83 
>   security-admin/src/main/webapp/scripts/utils/XAUtils.js b14f4b9 
>   security-admin/src/main/webapp/scripts/views/policymanager/ServiceLayout.js 
> d3eb026 
>   security-admin/src/main/webapp/scripts/views/security_zone/SecurityZone.js 
> a1e9716 
>   
> security-admin/src/main/webapp/scripts/views/security_zone/ZoneAdministration.js
>  63fafb4 
>   security-admin/src/main/webapp/scripts/views/security_zone/ZoneCreate.js 
> dd34605 
>   security-admin/src/main/webapp/styles/xa.css f90f21b 
>   
> security-admin/src/main/webapp/templates/security_zone/SecurityZone_tmpl.html 
> f0b2572 
>   
> security-admin/src/main/webapp/templates/security_zone/ZoneAdministration_tmpl.html
>  89acb10 
>   
> security-admin/src/main/webapp/templates/security_zone/ZoneCreateForm_tmpl.html
>  fdcb821 
> 
> 
> Diff: https://reviews.apache.org/r/70376/diff/2/
> 
> 
> Testing
> ---
> 
> 1. Verified that new field "Zone Tag Services" is available on Zone form 
> (create/update page).
> 2. Verified that  multiple Tag services can be mapped to zone using newly 
> added field i.e "Zone Tag Services".
> 3. Verified that Same Tag services can be mapped to multiple zones.
> 4. Zone detail page display tag services associated with that zone.
> 5. Verified that When tag based services is not mapped to any zone, It 
> displays message "No tag based services are associated with this zone" on 
> Zone listing page.
> 6. Verified that Audit>>Admin logs gets generated for zone tag services field 
> in zone form
> 
> 
> Thanks,
> 
> Nitin Galave
> 
>

[jira] [Comment Edited] (RANGER-2399) User's listing page hits users API call twice from UI

2019-04-10 Thread Nitin Galave (JIRA) 


[ 
https://issues.apache.org/jira/browse/RANGER-2399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16814086#comment-16814086
 ] 

Nitin Galave edited comment on RANGER-2399 at 4/10/19 6:11 AM:
---

Committed to 
[master|https://github.com/apache/ranger/commit/767d69e335a70bdb96fed39623facd4319397980]
 branch.


was (Author: nitin.galave):
Committed to apache 
[master|https://github.com/apache/ranger/commit/767d69e335a70bdb96fed39623facd4319397980]
 branch.

> User's listing page hits users API call twice from UI
> -
>
> Key: RANGER-2399
> URL: https://issues.apache.org/jira/browse/RANGER-2399
> Project: Ranger
>  Issue Type: Bug
>  Components: Ranger
>Reporter: Nitin Galave
>Assignee: Nitin Galave
>Priority: Minor
> Fix For: master
>
> Attachments: RANGER-2399.patch
>
>
> #issue1
> Steps: Login and go to users/group tab
> 1. Click on username name link and open user update page
> 2. And go back to user's listing page.
> See user API call hit twice. The unnecessary call needs to be removed from UI
> #issue 2
> 2. Zonename title placement on zone listing page to be checked when zone name 
> is long



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (RANGER-2399) User's listing page hits users API call twice from UI

2019-04-10 Thread Nitin Galave (JIRA) 


[ 
https://issues.apache.org/jira/browse/RANGER-2399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16814086#comment-16814086
 ] 

Nitin Galave commented on RANGER-2399:
--

Committed to apache 
[master|https://github.com/apache/ranger/commit/767d69e335a70bdb96fed39623facd4319397980]
 branch.

> User's listing page hits users API call twice from UI
> -
>
> Key: RANGER-2399
> URL: https://issues.apache.org/jira/browse/RANGER-2399
> Project: Ranger
>  Issue Type: Bug
>  Components: Ranger
>Reporter: Nitin Galave
>Assignee: Nitin Galave
>Priority: Minor
> Fix For: master
>
> Attachments: RANGER-2399.patch
>
>
> #issue1
> Steps: Login and go to users/group tab
> 1. Click on username name link and open user update page
> 2. And go back to user's listing page.
> See user API call hit twice. The unnecessary call needs to be removed from UI
> #issue 2
> 2. Zonename title placement on zone listing page to be checked when zone name 
> is long



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (RANGER-2401) Ranger Secuity Zone needs to be added in audit type filter in admin audit

2019-04-10 Thread Nitin Galave (JIRA) 


[ 
https://issues.apache.org/jira/browse/RANGER-2401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16814088#comment-16814088
 ] 

Nitin Galave commented on RANGER-2401:
--

Committed to 
[master|https://github.com/apache/ranger/commit/a232c6421a5be65cd2a3d4b1f2a1155754f3edb4]
 branch.

> Ranger Secuity Zone needs to be added in audit type filter in admin audit
> -
>
> Key: RANGER-2401
> URL: https://issues.apache.org/jira/browse/RANGER-2401
> Project: Ranger
>  Issue Type: Bug
>  Components: Ranger
>Reporter: Nitin Galave
>Assignee: Nitin Galave
>Priority: Major
> Fix For: master
>
> Attachments: RANGER-2401.patch
>
>
> *1. Ranger Security Zone* is missing in audit type filter in the admin audit 
> log.
> 2. Also, Include "User Profile" in the audit type filter for admin audits
> When a user is deleted, admin audit entries are generated for user deletion 
> and user profile deletion with audit types as "Ranger User" and "User 
> Profile".
> "Ranger User" option is available in the audit type search filter, "User 
> Profile" is not. Suggestion is to include "User Profile" option also in audit 
> type filter



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Re: Review Request 70339: RANGER-2386: Code duplication due to RangerCredentialProvider.getCredentialString returns char[]

2019-04-10 Thread Pradeep Agrawal 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70339/#review214521
---


Ship it!




Ship It!

- Pradeep Agrawal


On March 29, 2019, 12:18 p.m., Zsombor Gegesy wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70339/
> ---
> 
> (Updated March 29, 2019, 12:18 p.m.)
> 
> 
> Review request for ranger.
> 
> 
> Bugs: RANGER-2386
> https://issues.apache.org/jira/browse/RANGER-2386
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> The same code appears in lot's of places, because 
> RangerCredentialProvider.getCredentialString returns a char array, which 
> needs to be converted to String - remove this duplication.
> 
> 
> Diffs
> -
> 
>   
> agents-audit/src/main/java/org/apache/ranger/audit/provider/DbAuditProvider.java
>  1490c2782a9d603b8ad1392a1aafef7655e56562 
>   agents-audit/src/main/java/org/apache/ranger/audit/provider/MiscUtil.java 
> eff38249e044a910b747aa7e81003028d2b3 
>   
> agents-common/src/main/java/org/apache/ranger/plugin/util/RangerRESTClient.java
>  2a4b9c90186effdcc2d9bc5b8726a5351ea668bd 
>   
> agents-common/src/main/java/org/apache/ranger/plugin/util/RangerSslHelper.java
>  2036661e81201b15fc296d53f2a831a8a1770b36 
>   
> agents-cred/src/main/java/org/apache/ranger/authorization/hadoop/utils/RangerCredentialProvider.java
>  44cadfba2dc2f209a94b11f6d3ad7e7582f3d8cb 
>   
> agents-cred/src/test/java/org/apache/ranger/authorization/hadoop/utils/RangerCredentialProviderTest.java
>  971ee681a33dfcf5993e4d79e25c648c90646df2 
> 
> 
> Diff: https://reviews.apache.org/r/70339/diff/1/
> 
> 
> Testing
> ---
> 
> Tested with plugins on a cluster
> 
> 
> Thanks,
> 
> Zsombor Gegesy
> 
>