Re: Review Request 73852: RANGER-3595, refactor the file layout of ranger-xxx-kms.tar.gz

2022-03-02 Thread Kirby Zhou
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73852/ --- (Updated 三月 3, 2022, 7:27 a.m.) Review request for ranger, Dhaval Shah,

Re: Review Request 73852: RANGER-3595, refactor the file layout of ranger-xxx-kms.tar.gz

2022-03-02 Thread bhavik patel
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73852/#review224123 --- PMD failure :

Re: Review Request 73852: RANGER-3595, refactor the file layout of ranger-xxx-kms.tar.gz

2022-03-02 Thread Kirby Zhou
> On 三月 3, 2022, 5:25 a.m., bhavik patel wrote: > > Patch has a conflict and please update the commit message. > > Kirby Zhou wrote: > what is your point about "commit message"? > and what is the conflict? > > I have tried apply it on 53b103c5826f115f05e011d883041471d7546a63. >

Re: Review Request 73852: RANGER-3595, refactor the file layout of ranger-xxx-kms.tar.gz

2022-03-02 Thread bhavik patel
> On March 3, 2022, 5:25 a.m., bhavik patel wrote: > > Patch has a conflict and please update the commit message. > > Kirby Zhou wrote: > what is your point about "commit message"? > and what is the conflict? > > I have tried apply it on

Re: Review Request 73852: RANGER-3595, refactor the file layout of ranger-xxx-kms.tar.gz

2022-03-02 Thread bhavik patel
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73852/#review224119 --- Patch has a conflict and please update the commit message. -

Re: Review Request 73867: RANGER-3630: Support wildcards, group short names, and list of memberof attribute DNs for computing user search filter

2022-03-02 Thread Pradeep Agrawal
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73867/#review224118 ---

Re: Review Request 73885: RANGER-3651:Remove jersey1.x version dependency for knox plugin

2022-03-02 Thread bhavik patel
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73885/#review224117 --- Ship it! Ship It! - bhavik patel On March 2, 2022, 8:02

Re: Review Request 73835: RANGER-3611 Uncatched NullPointerException when missing lastKnownVersion in ServiceREST::getServicePoliciesIfUpdated

2022-03-02 Thread bhavik patel
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73835/#review224116 --- Ship it! Ship It! - bhavik patel On March 3, 2022, 3:48

[jira] [Updated] (RANGER-3611) Uncatched NullPointerException when missing lastKnownVersion in ServiceREST::getServicePoliciesIfUpdated

2022-03-02 Thread kirby zhou (Jira)
[ https://issues.apache.org/jira/browse/RANGER-3611?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] kirby zhou updated RANGER-3611: --- Attachment: (was: 0001-fix-NullPtrException-in-API-policies-download.patch) > Uncatched

Re: Review Request 73835: RANGER-3611 Uncatched NullPointerException when missing lastKnownVersion in ServiceREST::getServicePoliciesIfUpdated

2022-03-02 Thread Kirby Zhou
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73835/ --- (Updated 三月 3, 2022, 3:48 a.m.) Review request for ranger, Ankita Sinha,

Re: Review Request 73852: RANGER-3595, refactor the file layout of ranger-xxx-kms.tar.gz

2022-03-02 Thread Kirby Zhou
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73852/ --- (Updated 三月 3, 2022, 2:43 a.m.) Review request for ranger, Dhaval Shah,

Re: Review Request 73852: RANGER-3595, refactor the file layout of ranger-xxx-kms.tar.gz

2022-03-02 Thread Kirby Zhou
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73852/ --- (Updated 三月 3, 2022, 2:28 a.m.) Review request for ranger, Dhaval Shah,

[jira] [Updated] (RANGER-3459) Upgrade Ranger's Kafka dependency to 2.8

2022-03-02 Thread Andras Katona (Jira)
[ https://issues.apache.org/jira/browse/RANGER-3459?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andras Katona updated RANGER-3459: -- Fix Version/s: 3.0.0 > Upgrade Ranger's Kafka dependency to 2.8 >

[jira] [Commented] (RANGER-3459) Upgrade Ranger's Kafka dependency to 2.8

2022-03-02 Thread Ramesh Mani (Jira)
[ https://issues.apache.org/jira/browse/RANGER-3459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17500375#comment-17500375 ] Ramesh Mani commented on RANGER-3459: - [~akatona]  commit to master. Thanks. > Upgrade Ranger's

[jira] [Commented] (RANGER-3010) Rest API 'addUsersAndGroups' issue

2022-03-02 Thread Madhan Neethiraj (Jira)
[ https://issues.apache.org/jira/browse/RANGER-3010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17500369#comment-17500369 ] Madhan Neethiraj commented on RANGER-3010: -- [~ankita] - can you please help with this? Thanks!

Review Request 73885: RANGER-3651:Remove jersey1.x version dependency for knox plugin

2022-03-02 Thread Ramesh Mani
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73885/ --- Review request for ranger, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh,

[jira] [Updated] (RANGER-3651) Remove jersey1.x version dependency for knox plugin

2022-03-02 Thread Ramesh Mani (Jira)
[ https://issues.apache.org/jira/browse/RANGER-3651?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ramesh Mani updated RANGER-3651: Affects Version/s: 2.3.0 (was: 2.2.0) > Remove jersey1.x version

[jira] [Created] (RANGER-3651) Remove jersey1.x version dependency for knox plugin

2022-03-02 Thread Ramesh Mani (Jira)
Ramesh Mani created RANGER-3651: --- Summary: Remove jersey1.x version dependency for knox plugin Key: RANGER-3651 URL: https://issues.apache.org/jira/browse/RANGER-3651 Project: Ranger Issue

[jira] [Commented] (RANGER-3632) Improve ranger logs, RENAME_ON_ROTATE and others

2022-03-02 Thread kirby zhou (Jira)
[ https://issues.apache.org/jira/browse/RANGER-3632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17500245#comment-17500245 ] kirby zhou commented on RANGER-3632: [https://reviews.apache.org/r/73884/] for 2.3 branch > Improve

Re: Review Request 73884: RANGER-3632 log improve, cherry-pick from master

2022-03-02 Thread Kirby Zhou
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73884/ --- (Updated 三月 2, 2022, 3:33 p.m.) Review request for ranger. Summary (updated)

Review Request 73884: RANGER-3623 log improve, cherry-pick from master

2022-03-02 Thread Kirby Zhou
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73884/ --- Review request for ranger. Bugs: RANGER-3623

Re: Review Request 73877: RANGER-3459: Upgrade Kafka dependency to 2.8

2022-03-02 Thread Ramesh Mani
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73877/#review224115 --- Ship it! Ship It! - Ramesh Mani On Feb. 28, 2022, 1:18

Re: Review Request 73882: RANGER-3600: Ranger service tags import request failure

2022-03-02 Thread Abhay Kulkarni
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73882/#review224114 ---

[jira] [Updated] (RANGER-3600) Ranger service tags import request failure

2022-03-02 Thread Pradeep Agrawal (Jira)
[ https://issues.apache.org/jira/browse/RANGER-3600?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pradeep Agrawal updated RANGER-3600: Attachment: 0001-RANGER-3600-Ranger-service-tags-import-request-failu.patch > Ranger

Review Request 73882: RANGER-3600: Ranger service tags import request failure

2022-03-02 Thread Pradeep Agrawal
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73882/ --- Review request for ranger, Abhay Kulkarni, Madhan Neethiraj, Ramesh Mani,

[jira] [Commented] (RANGER-3010) Rest API 'addUsersAndGroups' issue

2022-03-02 Thread Nixon Rodrigues (Jira)
[ https://issues.apache.org/jira/browse/RANGER-3010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17500134#comment-17500134 ] Nixon Rodrigues commented on RANGER-3010: - [~Leo Pard]  where is patch ? can you contribute back 

[jira] [Commented] (RANGER-3010) Rest API 'addUsersAndGroups' issue

2022-03-02 Thread leo sun (Jira)
[ https://issues.apache.org/jira/browse/RANGER-3010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17500122#comment-17500122 ] leo sun commented on RANGER-3010: - This API indeed have some logical mistakes, I think. I have added

[jira] [Commented] (RANGER-3619) REST API should return 403 when authenticated client is not allowed to access API.

2022-03-02 Thread kirby zhou (Jira)
[ https://issues.apache.org/jira/browse/RANGER-3619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17500115#comment-17500115 ] kirby zhou commented on RANGER-3619: [https://reviews.apache.org/r/73881/]   > REST API should

Review Request 73881: RANGER-3619: REST API returns 403 when authed user has no permission.

2022-03-02 Thread Kirby Zhou
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73881/ --- Review request for ranger. Bugs: RANGER-3619

Re: Review Request 73854: RANGER-3629 : Handle solr permissions during upgrade

2022-03-02 Thread bhavik patel
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73854/#review224113 --- Ship it! Ship It! - bhavik patel On Feb. 22, 2022, 4:22

Re: Review Request 73853: RANGER-3628 : Support fine grain authorization for different solr objects

2022-03-02 Thread bhavik patel
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73853/#review224112 ---

Re: Review Request 73879: RANGER-3650: fix unit test of blockAuditorRoleUser

2022-03-02 Thread bhavik patel
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73879/#review224111 --- Ship it! Ship It! - bhavik patel On March 2, 2022, 10:32

[jira] [Commented] (RANGER-3231) Ranger should use kafka Authorizer from KIP-504

2022-03-02 Thread Andras Katona (Jira)
[ https://issues.apache.org/jira/browse/RANGER-3231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17500088#comment-17500088 ] Andras Katona commented on RANGER-3231: --- I've prepared a reviewboard request:

[jira] [Assigned] (RANGER-3231) Ranger should use kafka Authorizer from KIP-504

2022-03-02 Thread Andras Katona (Jira)
[ https://issues.apache.org/jira/browse/RANGER-3231?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andras Katona reassigned RANGER-3231: - Assignee: Andras Katona (was: Chia-Ping Tsai) > Ranger should use kafka Authorizer

Review Request 73880: RANGER-3231: Ranger-Kafka-Plugin implementing Kafka Authorizer from KIP-504

2022-03-02 Thread Andras Katona via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73880/ --- Review request for ranger and Ramesh Mani. Bugs: RANGER-3231

[GitHub] [ranger] akatona84 commented on pull request #133: RANGER-3231: Ranger-Kafka-Plugin implementing Kafka Authorizer from KIP-504

2022-03-02 Thread GitBox
akatona84 commented on pull request #133: URL: https://github.com/apache/ranger/pull/133#issuecomment-1056837821 Thank you, @urbandan . Now I'm going to just rebase to see if the checks would work (some snapshot dependency was not available) -- This is an automated message from the

[jira] [Commented] (RANGER-3010) Rest API 'addUsersAndGroups' issue

2022-03-02 Thread Nixon Rodrigues (Jira)
[ https://issues.apache.org/jira/browse/RANGER-3010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17500072#comment-17500072 ] Nixon Rodrigues commented on RANGER-3010: - [~kulkabhay]  Facing similar issue. Can you please

[GitHub] [ranger] urbandan commented on a change in pull request #133: RANGER-3231: Ranger-Kafka-Plugin implementing Kafka Authorizer from KIP-504

2022-03-02 Thread GitBox
urbandan commented on a change in pull request #133: URL: https://github.com/apache/ranger/pull/133#discussion_r817599735 ## File path: ranger-kafka-plugin-shim/src/main/java/org/apache/ranger/authorization/kafka/authorizer/RangerKafkaAuthorizer.java ## @@ -19,272 +19,200 @@

[jira] [Updated] (RANGER-3600) Ranger service tags import request failure

2022-03-02 Thread Pradeep Agrawal (Jira)
[ https://issues.apache.org/jira/browse/RANGER-3600?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pradeep Agrawal updated RANGER-3600: Description: Ranger service tag import request may fail if RangerServiceResource objects

[jira] [Updated] (RANGER-3600) Ranger service tags import request failure

2022-03-02 Thread Pradeep Agrawal (Jira)
[ https://issues.apache.org/jira/browse/RANGER-3600?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pradeep Agrawal updated RANGER-3600: Summary: Ranger service tags import request failure (was: Add fallback support in

Re: Review Request 73852: RANGER-3595, refactor the file layout of ranger-xxx-kms.tar.gz

2022-03-02 Thread bhavik patel
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73852/#review224110 --- Please rebase the patch and update the commit message format -

[jira] [Created] (RANGER-3650) unit test of blockAuditorRoleUser in RANGER-2095 commit is meaningless.

2022-03-02 Thread kirby zhou (Jira)
kirby zhou created RANGER-3650: -- Summary: unit test of blockAuditorRoleUser in RANGER-2095 commit is meaningless. Key: RANGER-3650 URL: https://issues.apache.org/jira/browse/RANGER-3650 Project: Ranger

[jira] [Commented] (RANGER-3632) Improve ranger logs, RENAME_ON_ROTATE and others

2022-03-02 Thread Bhavik Patel (Jira)
[ https://issues.apache.org/jira/browse/RANGER-3632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17500047#comment-17500047 ] Bhavik Patel commented on RANGER-3632: -- Please raise separate Review Request for 2.3 branch. >

[jira] [Commented] (RANGER-3632) Improve ranger logs, RENAME_ON_ROTATE and others

2022-03-02 Thread Bhavik Patel (Jira)
[ https://issues.apache.org/jira/browse/RANGER-3632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17500046#comment-17500046 ] Bhavik Patel commented on RANGER-3632: -- master branch commit link:

[jira] [Assigned] (RANGER-3632) Improve ranger logs, RENAME_ON_ROTATE and others

2022-03-02 Thread Bhavik Patel (Jira)
[ https://issues.apache.org/jira/browse/RANGER-3632?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bhavik Patel reassigned RANGER-3632: Assignee: kirby zhou > Improve ranger logs, RENAME_ON_ROTATE and others >

[jira] [Updated] (RANGER-3632) Improve ranger logs, RENAME_ON_ROTATE and others

2022-03-02 Thread Bhavik Patel (Jira)
[ https://issues.apache.org/jira/browse/RANGER-3632?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bhavik Patel updated RANGER-3632: - Fix Version/s: 3.0.0 > Improve ranger logs, RENAME_ON_ROTATE and others >

[jira] [Commented] (RANGER-3647) Connection to DB fails for MySQL version above 8.0

2022-03-02 Thread Bhavik Patel (Jira)
[ https://issues.apache.org/jira/browse/RANGER-3647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17500044#comment-17500044 ] Bhavik Patel commented on RANGER-3647: -- [~vishalsuvagia] Please add the error/exception in the

[jira] [Resolved] (RANGER-2095) Add unit tests for new read only admin-auditor/kms-auditor roles functionality

2022-03-02 Thread Bhavik Patel (Jira)
[ https://issues.apache.org/jira/browse/RANGER-2095?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bhavik Patel resolved RANGER-2095. -- Resolution: Done > Add unit tests for new read only admin-auditor/kms-auditor roles

[jira] [Commented] (RANGER-2095) Add unit tests for new read only admin-auditor/kms-auditor roles functionality

2022-03-02 Thread Bhavik Patel (Jira)
[ https://issues.apache.org/jira/browse/RANGER-2095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17500042#comment-17500042 ] Bhavik Patel commented on RANGER-2095: -- Might be the test code is not synced with latest master

[jira] [Commented] (RANGER-2095) Add unit tests for new read only admin-auditor/kms-auditor roles functionality

2022-03-02 Thread kirby zhou (Jira)
[ https://issues.apache.org/jira/browse/RANGER-2095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17500034#comment-17500034 ] kirby zhou commented on RANGER-2095: [https://reviews.apache.org/r/73879/] Please review it. > Add

Review Request 73879: RANGER-2095: unit test in old commit is meaningless, fixed here.

2022-03-02 Thread Kirby Zhou
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73879/ --- Review request for ranger. Bugs: RANGER-2095

Re: Review Request 72024: RANGER-2704 : Support browser login using kerberized authentication.

2022-03-02 Thread Kirby Zhou
> On 三月 1, 2022, 3:25 a.m., Kirby Zhou wrote: > > What will happens at following situation? > > > > 1. A kerberosized browser with unauthorized principal want to login to > > ranger by HTML form using another user/password. > > > > 2. A kerberosized browser with different KDC want to login to

Re: Review Request 72024: RANGER-2704 : Support browser login using kerberized authentication.

2022-03-02 Thread Vishal Suvagia via Review Board
> On March 1, 2022, 3:25 a.m., Kirby Zhou wrote: > > What will happens at following situation? > > > > 1. A kerberosized browser with unauthorized principal want to login to > > ranger by HTML form using another user/password. > > > > 2. A kerberosized browser with different KDC want to login

[jira] [Commented] (RANGER-2095) Add unit tests for new read only admin-auditor/kms-auditor roles functionality

2022-03-02 Thread kirby zhou (Jira)
[ https://issues.apache.org/jira/browse/RANGER-2095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1741#comment-1741 ] kirby zhou commented on RANGER-2095: Even the 2 class member is invalid usage of @Mock.

[jira] [Reopened] (RANGER-2095) Add unit tests for new read only admin-auditor/kms-auditor roles functionality

2022-03-02 Thread kirby zhou (Jira)
[ https://issues.apache.org/jira/browse/RANGER-2095?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] kirby zhou reopened RANGER-2095: The patch is buggy:   * testBlockAuditorRoleUserThrowsErrorForAuditKeyAdmin *