Re: Review Request 74280: RANGER-4041 : Upgrade netty-all version to 4.1.86.Final

2023-02-08 Thread Vishal Suvagia via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74280/#review225165 --- Ship it! Ship It! - Vishal Suvagia On Feb. 8, 2023, 6:56

Re: Review Request 74215: RANGER-3976:Upgrade tomcat version to 8.5.83

2022-11-24 Thread Vishal Suvagia via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74215/#review224907 --- Ship it! Ship It! - Vishal Suvagia On Nov. 24, 2022, 3:07

Re: Review Request 74211: RANGER-3975:Upgrade netty-all version to 4.1.85.Final

2022-11-23 Thread Vishal Suvagia via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74211/#review224900 --- Ship it! Ship It! - Vishal Suvagia On Nov. 22, 2022, 11:47

Re: Review Request 74209: RANGER-3972:Upgrade jettison version to 1.5.2

2022-11-23 Thread Vishal Suvagia via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74209/#review224898 --- Ship it! Ship It! - Vishal Suvagia On Nov. 22, 2022, 8:29

Re: Review Request 74210: RANGER-3974:Upgrade jackson version to 2.14.0

2022-11-23 Thread Vishal Suvagia via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74210/#review224899 --- Ship it! Ship It! - Vishal Suvagia On Nov. 22, 2022, 11:13

Re: Review Request 74208: RANGER-3971: Upgrade HBASE version to 2.4.6

2022-11-23 Thread Vishal Suvagia via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74208/#review224897 --- Ship it! Ship It! - Vishal Suvagia On Nov. 23, 2022, 4:20

Re: Review Request 74127: Ranger-3880 : Ranger setup fails for newer MySQL versions

2022-10-10 Thread Vishal Suvagia via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74127/#review224771 --- kms/scripts/dba_script.py Lines 167 (patched)

Re: Review Request 74014: RANGER-3739: Add JWT filter in Ranger Admin -- follow-up patch

2022-06-09 Thread Vishal Suvagia via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74014/#review224488 --- Ship it! Ship It! - Vishal Suvagia On June 8, 2022, 3:19

Re: Review Request 73965: RANGER-3739: Add JWT filter in Ranger Admin

2022-05-06 Thread Vishal Suvagia via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73965/#review224411 --- Ship it! Ship It! - Vishal Suvagia On May 2, 2022, 11:53

Re: Review Request 73973: RANGER-3740: Create Ranger Admin API to refresh tag cache

2022-05-06 Thread Vishal Suvagia via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73973/#review224409 --- Ship it! Ship It! - Vishal Suvagia On May 5, 2022, 8:43

Re: Review Request 73958: RANGER-3727: Create common module for handling authentication

2022-04-29 Thread Vishal Suvagia via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73958/#review224394 --- Ship it! Ship It! - Vishal Suvagia On April 28, 2022, 11:20

Re: Review Request 73936: RANGER-3695 : Ranger Keystore alias should be configurable

2022-04-08 Thread Vishal Suvagia via Review Board
> On April 8, 2022, 4 a.m., bhavik patel wrote: > > embeddedwebserver/src/main/java/org/apache/ranger/server/tomcat/EmbeddedServer.java > > Line 167 (original), 167 (patched) > > > > > > default should be

Re: Review Request 73935: RANGER-3669 : Connection to DB fails for MySQL version above 8.0

2022-04-08 Thread Vishal Suvagia via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73935/ --- (Updated April 8, 2022, 10:57 a.m.) Review request for ranger, Ankita Sinha,

Re: Review Request 73936: RANGER-3695 : Ranger Keystore alias should be configurable

2022-04-08 Thread Vishal Suvagia via Review Board
> On April 8, 2022, 4 a.m., bhavik patel wrote: > > embeddedwebserver/src/main/java/org/apache/ranger/server/tomcat/EmbeddedServer.java > > Line 167 (original), 167 (patched) > > > > > > default should be

Review Request 73936: RANGER-3695 : Ranger Keystore alias should be configurable

2022-04-07 Thread Vishal Suvagia via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73936/ --- Review request for ranger, Ankita Sinha, Dhaval Shah, Dineshkumar Yadav, Gautam

Review Request 73935: RANGER-3669 : Connection to DB fails for MySQL version above 8.0

2022-04-07 Thread Vishal Suvagia via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73935/ --- Review request for ranger, Ankita Sinha, Dhaval Shah, Dineshkumar Yadav, Gautam

Re: Review Request 72024: RANGER-2704 : Support browser login using kerberized authentication.

2022-04-05 Thread Vishal Suvagia via Review Board
> On April 4, 2022, 1:31 p.m., bhavik patel wrote: > > security-admin/src/main/java/org/apache/ranger/security/web/filter/RangerSSOAuthenticationFilter.java > > Lines 607 (patched) > > > > > > same method is there

Re: Review Request 72024: RANGER-2704 : Support browser login using kerberized authentication.

2022-04-05 Thread Vishal Suvagia via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72024/ --- (Updated April 5, 2022, 12:24 p.m.) Review request for ranger, Ankita Sinha,

Re: Review Request 72024: RANGER-2704 : Support browser login using kerberized authentication.

2022-04-04 Thread Vishal Suvagia via Review Board
> On March 1, 2022, 3:25 a.m., Kirby Zhou wrote: > > What will happens at following situation? > > > > 1. A kerberosized browser with unauthorized principal want to login to > > ranger by HTML form using another user/password. > > > > 2. A kerberosized browser with different KDC want to login

Re: Review Request 72024: RANGER-2704 : Support browser login using kerberized authentication.

2022-04-04 Thread Vishal Suvagia via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72024/ --- (Updated April 4, 2022, 1:04 p.m.) Review request for ranger, Ankita Sinha,

Re: Review Request 73878: RANGER-3647 : Connection to DB fails for MySQL version above 8.0

2022-03-21 Thread Vishal Suvagia via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73878/ --- (Updated March 21, 2022, 2:17 p.m.) Review request for ranger, Ankita Sinha,

Re: Review Request 72024: RANGER-2704 : Support browser login using kerberized authentication.

2022-03-02 Thread Vishal Suvagia via Review Board
> On March 1, 2022, 3:25 a.m., Kirby Zhou wrote: > > What will happens at following situation? > > > > 1. A kerberosized browser with unauthorized principal want to login to > > ranger by HTML form using another user/password. > > > > 2. A kerberosized browser with different KDC want to login

Re: Review Request 72024: RANGER-2704 : Support browser login using kerberized authentication.

2022-02-28 Thread Vishal Suvagia via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72024/ --- (Updated Feb. 28, 2022, 7:35 p.m.) Review request for ranger, Ankita Sinha,

Review Request 73636: RANGER-3418 : Rotated Ranger admin access logs aren't getting removed

2021-10-07 Thread Vishal Suvagia via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73636/ --- Review request for ranger, Ankita Sinha, Dhaval Shah, Dineshkumar Yadav, Gautam

Re: Review Request 73568: RANGER-3398: Duplicate JAVA patch suffix should not be allowed

2021-09-07 Thread Vishal Suvagia via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73568/#review223450 --- Ship it! Ship It! - Vishal Suvagia On Sept. 6, 2021, 7:44

Re: Review Request 73505: RANGER-3355 : Update the current logging mechanism to use custom log4j conf.

2021-08-09 Thread Vishal Suvagia via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73505/#review223320 --- Ship it! Ship It! - Vishal Suvagia On Aug. 6, 2021, 2:38

Review Request 73479: RANGER-3342 : Addendum fix Need to make the Ranger embedded server work directory configurable

2021-07-23 Thread Vishal Suvagia via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73479/ --- Review request for ranger, Ankita Sinha, Dhaval Shah, Dineshkumar Yadav, Gautam

Re: Review Request 73463: RANGER-3342 : Need to make the Ranger embedded server work directory configurable

2021-07-20 Thread Vishal Suvagia via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73463/ --- (Updated July 20, 2021, 9:37 a.m.) Review request for ranger, Ankita Sinha,

Review Request 73463: RANGER-3342 : Need to make the Ranger embedded server work directory configurable

2021-07-19 Thread Vishal Suvagia via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73463/ --- Review request for ranger, Ankita Sinha, Dhaval Shah, Dineshkumar Yadav, Gautam

Re: Review Request 73393: RANGER-3303: Improve error handling in Ranger Solr bootstrap

2021-06-02 Thread Vishal Suvagia via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73393/#review223087 --- Ship it! Ship It! - Vishal Suvagia On June 2, 2021, 7:31

Re: Review Request 73360: RANGER-3287 : Implement best practices for logging.

2021-05-20 Thread Vishal Suvagia via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73360/ --- (Updated May 20, 2021, 12:15 p.m.) Review request for ranger, Ankita Sinha,

Review Request 73360: RANGER-3287 : Implement best practices for logging.

2021-05-18 Thread Vishal Suvagia via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73360/ --- Review request for ranger, Ankita Sinha, Dhaval Shah, Dineshkumar Yadav, Gautam

Re: Review Request 73348: RANGER-3251: [Ranger Audit Filters UI] Tag, KMS service not showing the audit filters in UI section

2021-05-12 Thread Vishal Suvagia via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73348/#review222982 --- Ship it! Ship It! - Vishal Suvagia On May 12, 2021, 5:25

Re: Review Request 73338: RANGER-3275 : Need to update solr-config.xml in the ranger-audits collection config-set

2021-05-06 Thread Vishal Suvagia via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73338/ --- (Updated May 6, 2021, 4:43 p.m.) Review request for ranger, Ankita Sinha,

Re: Review Request 73037: RANGER-3087 :: Making db_setup.py fool-proof and robust

2020-11-30 Thread Vishal Suvagia via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73037/ --- (Updated Dec. 1, 2020, 4:38 a.m.) Review request for ranger, Ankita Sinha,

Review Request 69509: RANGER-2304 : Need to add property dfs.permissions.ContentSummary.subAccess when enabling Ranger HDFS plugin manually.

2018-12-05 Thread Vishal Suvagia via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69509/ --- Review request for ranger, Ankita Sinha, bhavik patel, Colm O hEigeartaigh,

Review Request 69112: RANGER-2259 : Need to provide appropriate permisssions for unix-auth files.

2018-10-22 Thread Vishal Suvagia via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69112/ --- Review request for ranger, Ankita Sinha, Colm O hEigeartaigh, Gautam Borad,

Re: Review Request 69083: RANGER-2251 : Need to provide options for making java heap size memory configurable in Ranger services.

2018-10-22 Thread Vishal Suvagia via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69083/ --- (Updated Oct. 22, 2018, 9:01 a.m.) Review request for ranger, Ankita Sinha,

Review Request 69083: RANGER-2251 : Need to provide options for making java heap size memory configurable in Ranger services.

2018-10-19 Thread Vishal Suvagia via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69083/ --- Review request for ranger, Ankita Sinha, Colm O hEigeartaigh, Gautam Borad,

Re: Review Request 68681: RANGER-2213 Tomcat Security Vulnerability Alert. The version of the tomcat for ranger should upgrade to 7.0.90.

2018-09-12 Thread Vishal Suvagia via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68681/#review208553 --- @Qiang Zhang, Kindly add the testing done with this patch ? -

Review Request 66509: RANGER-2060 : Knox proxy with knox-sso is not working for ranger

2018-04-09 Thread Vishal Suvagia via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66509/ --- Review request for ranger, Ankita Sinha, bhavik patel, Gautam Borad, Abhay

Re: Review Request 62495: RANGER-1797:Tomcat Security Vulnerability Alert. The version of the tomcat for ranger should upgrade to 7.0.82.

2017-12-05 Thread Vishal Suvagia via Review Board
> On Nov. 30, 2017, 9:38 a.m., Vishal Suvagia wrote: > > pom.xml > > Line 212 (original), 212 (patched) > > > > > > @PengJianhua, > > I used attached patch and did a build on my local machine > >

Re: Review Request 62495: RANGER-1797:Tomcat Security Vulnerability Alert. The version of the tomcat for ranger should upgrade to 7.0.82.

2017-12-05 Thread Vishal Suvagia via Review Board
> On Nov. 30, 2017, 9:38 a.m., Vishal Suvagia wrote: > > pom.xml > > Line 212 (original), 212 (patched) > > > > > > @PengJianhua, > > I used attached patch and did a build on my local machine > >

Re: Review Request 62495: RANGER-1797:Tomcat Security Vulnerability Alert. The version of the tomcat for ranger should upgrade to 7.0.82.

2017-12-05 Thread Vishal Suvagia via Review Board
> On Nov. 30, 2017, 9:38 a.m., Vishal Suvagia wrote: > > pom.xml > > Line 212 (original), 212 (patched) > > > > > > @PengJianhua, > > I used attached patch and did a build on my local machine > >

Re: Review Request 62495: RANGER-1797:Tomcat Security Vulnerability Alert. The version of the tomcat for ranger should upgrade to 7.0.82.

2017-11-30 Thread Vishal Suvagia via Review Board
> On Nov. 30, 2017, 9:38 a.m., Vishal Suvagia wrote: > > pom.xml > > Line 212 (original), 212 (patched) > > > > > > @PengJianhua, > > I used attached patch and did a build on my local machine > >