Re: Review Request 63145: This JAVA_VERSION_REQUIRED configuration item is invalid in security admin installer, we should enable it to control the necessary java version.

2017-10-26 Thread Colm O hEigeartaigh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63145/#review189299 --- Ship it! Ship It! - Colm O hEigeartaigh On Oct. 24, 2017,

Re: Review Request 63145: This JAVA_VERSION_REQUIRED configuration item is invalid in security admin installer, we should enable it to control the necessary java version.

2017-10-25 Thread pengjianhua
> On 十月 25, 2017, 10:07 a.m., Colm O hEigeartaigh wrote: > > Have you tested the awk statement works with Java 9? It uses a different > > version String... Ok. I had carefully tested the awk statement works with Java 9. The test result shows that this new algorithm not only to satisfy the

Re: Review Request 63145: This JAVA_VERSION_REQUIRED configuration item is invalid in security admin installer, we should enable it to control the necessary java version.

2017-10-25 Thread Colm O hEigeartaigh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63145/#review189181 --- Have you tested the awk statement works with Java 9? It uses a

Re: Review Request 63145: This JAVA_VERSION_REQUIRED configuration item is invalid in security admin installer, we should enable it to control the necessary java version.

2017-10-24 Thread pengjianhua
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63145/ --- (Updated 十月 24, 2017, 8:39 a.m.) Review request for ranger, Alok Lal, Ankita

Re: Review Request 63145: This JAVA_VERSION_REQUIRED configuration item is invalid in security admin installer, we should enable it to control the necessary java version.

2017-10-23 Thread pengjianhua
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63145/#review189013 --- Hi Colm, I fixed the issue and updated it's patch according to

Re: Review Request 63145: This JAVA_VERSION_REQUIRED configuration item is invalid in security admin installer, we should enable it to control the necessary java version.

2017-10-23 Thread pengjianhua
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63145/ --- (Updated 十月 24, 2017, 2:59 a.m.) Review request for ranger, Alok Lal, Ankita

Re: Review Request 63145: This JAVA_VERSION_REQUIRED configuration item is invalid in security admin installer, we should enable it to control the necessary java version.

2017-10-19 Thread Qiang Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63145/#review188804 --- Ship it! Ship It! - Qiang Zhang On Oct. 20, 2017, 2:02

Re: Review Request 63145: This JAVA_VERSION_REQUIRED configuration item is invalid in security admin installer, we should enable it to control the necessary java version.

2017-10-19 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63145/#review188803 --- Ship it! Ship It! - Alejandro Fernandez On Oct. 20, 2017,

Re: Review Request 63145: This JAVA_VERSION_REQUIRED configuration item is invalid in security admin installer, we should enable it to control the necessary java version.

2017-10-19 Thread pengjianhua
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63145/ --- (Updated 十月 20, 2017, 2:02 a.m.) Review request for ranger, Alok Lal, Ankita

Re: Review Request 63145: This JAVA_VERSION_REQUIRED configuration item is invalid in security admin installer, we should enable it to control the necessary java version.

2017-10-19 Thread pengjianhua
> On 十月 19, 2017, 5:51 p.m., Alejandro Fernandez wrote: > > security-admin/scripts/setup.sh > > Line 305 (original), 304 (patched) > > > > > > This will not work if the minor version ever changes to 2 digits, e.g.,

Re: Review Request 63145: This JAVA_VERSION_REQUIRED configuration item is invalid in security admin installer, we should enable it to control the necessary java version.

2017-10-19 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63145/#review188713 --- security-admin/scripts/setup.sh Line 305 (original), 304

Review Request 63145: This JAVA_VERSION_REQUIRED configuration item is invalid in security admin installer, we should enable it to control the necessary java version.

2017-10-19 Thread pengjianhua
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63145/ --- Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O