Re: Review Request 70376: RANGER-2392: Create / Update zone to have provision to associate Tag based service with zone

2019-04-15 Thread Abhay Kulkarni 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70376/#review214664
---


Ship it!




Ship It!

- Abhay Kulkarni


On April 15, 2019, 1:26 p.m., Nitin Galave wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70376/
> ---
> 
> (Updated April 15, 2019, 1:26 p.m.)
> 
> 
> Review request for ranger, Abhay Kulkarni, Mehul Parikh, Nikhil P, Pradeep 
> Agrawal, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-2392
> https://issues.apache.org/jira/browse/RANGER-2392
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> Currently, Resource-based services are associated with the zone as part of 
> zone creation.
> Need to add a feature to only associate Tag based service as part of zone.
> No need to add resources with tag-based service association.
> 
> 
> Diffs
> -
> 
>   
> agents-common/src/main/java/org/apache/ranger/plugin/model/RangerSecurityZone.java
>  547e2d2 
>   security-admin/db/mysql/optimized/current/ranger_core_db_mysql.sql 0a529b4 
>   security-admin/db/mysql/patches/037-create-security-zone-schema.sql aff9786 
>   security-admin/db/oracle/optimized/current/ranger_core_db_oracle.sql 
> 9be7e8d 
>   security-admin/db/oracle/patches/037-create-security-zone-schema.sql 
> aae31dc 
>   security-admin/db/postgres/optimized/current/ranger_core_db_postgres.sql 
> ec39c32 
>   security-admin/db/postgres/patches/037-create-security-zone-schema.sql 
> 4a94d26 
>   
> security-admin/db/sqlanywhere/optimized/current/ranger_core_db_sqlanywhere.sql
>  abfe120 
>   security-admin/db/sqlanywhere/patches/037-create-security-zone-schema.sql 
> 5b7dade 
>   security-admin/db/sqlserver/optimized/current/ranger_core_db_sqlserver.sql 
> 1e8dff9 
>   security-admin/db/sqlserver/patches/037-create-security-zone-schema.sql 
> e621b43 
>   
> security-admin/src/main/java/org/apache/ranger/biz/SecurityZoneRefUpdater.java
>  2b0c462 
>   security-admin/src/main/java/org/apache/ranger/common/RangerConstants.java 
> cdb5e11 
>   security-admin/src/main/java/org/apache/ranger/db/RangerDaoManagerBase.java 
> 3599cf3 
>   
> security-admin/src/main/java/org/apache/ranger/db/XXSecurityZoneRefTagServiceDao.java
>  PRE-CREATION 
>   
> security-admin/src/main/java/org/apache/ranger/entity/XXSecurityZoneRefTagService.java
>  PRE-CREATION 
>   security-admin/src/main/java/org/apache/ranger/rest/SecurityZoneREST.java 
> ec69d6e 
>   
> security-admin/src/main/java/org/apache/ranger/service/RangerSecurityZoneServiceService.java
>  7927e31 
>   security-admin/src/main/resources/META-INF/jpa_named_queries.xml 7e702c1 
>   security-admin/src/main/webapp/scripts/models/RangerZone.js 4f99c83 
>   security-admin/src/main/webapp/scripts/utils/XAUtils.js 29c33f5 
>   security-admin/src/main/webapp/scripts/views/policymanager/ServiceLayout.js 
> d3eb026 
>   security-admin/src/main/webapp/scripts/views/security_zone/SecurityZone.js 
> 2a07020 
>   
> security-admin/src/main/webapp/scripts/views/security_zone/ZoneAdministration.js
>  63fafb4 
>   security-admin/src/main/webapp/scripts/views/security_zone/ZoneCreate.js 
> dd34605 
>   security-admin/src/main/webapp/styles/xa.css 60e045c 
>   
> security-admin/src/main/webapp/templates/security_zone/SecurityZone_tmpl.html 
> a2f1374 
>   
> security-admin/src/main/webapp/templates/security_zone/ZoneAdministration_tmpl.html
>  89acb10 
>   
> security-admin/src/main/webapp/templates/security_zone/ZoneCreateForm_tmpl.html
>  fdcb821 
> 
> 
> Diff: https://reviews.apache.org/r/70376/diff/4/
> 
> 
> Testing
> ---
> 
> 1. Verified that new field "Zone Tag Services" is available on Zone form 
> (create/update page).
> 2. Verified that  multiple Tag services can be mapped to zone using newly 
> added field i.e "Zone Tag Services".
> 3. Verified that Same Tag services can be mapped to multiple zones.
> 4. Zone detail page display tag services associated with that zone.
> 5. Verified that When tag based services is not mapped to any zone, It 
> displays message "No tag based services are associated with this zone" on 
> Zone listing page.
> 6. Verified that Audit>>Admin logs gets generated for zone tag services field 
> in zone form
> 7.Verified with databse flavours: MYSQL, Oracle, postgres, Sql anywhere, 
> MSSQL.
> 
> 
> Thanks,
> 
> Nitin Galave
> 
>

Re: Review Request 70376: RANGER-2392: Create / Update zone to have provision to associate Tag based service with zone

2019-04-12 Thread Nitin Galave 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70376/
---

(Updated April 12, 2019, 1:17 p.m.)


Review request for ranger, Abhay Kulkarni, Mehul Parikh, Nikhil P, Pradeep 
Agrawal, and Velmurugan Periasamy.


Changes
---

Database patches minor changes


Bugs: RANGER-2392
https://issues.apache.org/jira/browse/RANGER-2392


Repository: ranger


Description
---

Currently, Resource-based services are associated with the zone as part of zone 
creation.
Need to add a feature to only associate Tag based service as part of zone.
No need to add resources with tag-based service association.


Diffs (updated)
-

  
agents-common/src/main/java/org/apache/ranger/plugin/model/RangerSecurityZone.java
 547e2d2 
  security-admin/db/mysql/optimized/current/ranger_core_db_mysql.sql 0a529b4 
  security-admin/db/mysql/patches/037-create-security-zone-schema.sql aff9786 
  security-admin/db/oracle/optimized/current/ranger_core_db_oracle.sql 9be7e8d 
  security-admin/db/oracle/patches/037-create-security-zone-schema.sql aae31dc 
  security-admin/db/postgres/optimized/current/ranger_core_db_postgres.sql 
ec39c32 
  security-admin/db/postgres/patches/037-create-security-zone-schema.sql 
4a94d26 
  
security-admin/db/sqlanywhere/optimized/current/ranger_core_db_sqlanywhere.sql 
abfe120 
  security-admin/db/sqlanywhere/patches/037-create-security-zone-schema.sql 
5b7dade 
  security-admin/db/sqlserver/optimized/current/ranger_core_db_sqlserver.sql 
1e8dff9 
  security-admin/db/sqlserver/patches/037-create-security-zone-schema.sql 
e621b43 
  
security-admin/src/main/java/org/apache/ranger/biz/SecurityZoneRefUpdater.java 
2b0c462 
  security-admin/src/main/java/org/apache/ranger/common/RangerConstants.java 
cdb5e11 
  security-admin/src/main/java/org/apache/ranger/db/RangerDaoManagerBase.java 
3599cf3 
  
security-admin/src/main/java/org/apache/ranger/db/XXSecurityZoneRefTagServiceDao.java
 PRE-CREATION 
  
security-admin/src/main/java/org/apache/ranger/entity/XXSecurityZoneRefTagService.java
 PRE-CREATION 
  security-admin/src/main/java/org/apache/ranger/rest/SecurityZoneREST.java 
b8b8c1b 
  
security-admin/src/main/java/org/apache/ranger/service/RangerSecurityZoneService.java
 04003f4 
  security-admin/src/main/resources/META-INF/jpa_named_queries.xml 7e702c1 
  security-admin/src/main/webapp/scripts/models/RangerZone.js 4f99c83 
  security-admin/src/main/webapp/scripts/utils/XAUtils.js b14f4b9 
  security-admin/src/main/webapp/scripts/views/policymanager/ServiceLayout.js 
d3eb026 
  security-admin/src/main/webapp/scripts/views/security_zone/SecurityZone.js 
2a07020 
  
security-admin/src/main/webapp/scripts/views/security_zone/ZoneAdministration.js
 63fafb4 
  security-admin/src/main/webapp/scripts/views/security_zone/ZoneCreate.js 
dd34605 
  security-admin/src/main/webapp/styles/xa.css 60e045c 
  security-admin/src/main/webapp/templates/security_zone/SecurityZone_tmpl.html 
a2f1374 
  
security-admin/src/main/webapp/templates/security_zone/ZoneAdministration_tmpl.html
 89acb10 
  
security-admin/src/main/webapp/templates/security_zone/ZoneCreateForm_tmpl.html 
fdcb821 


Diff: https://reviews.apache.org/r/70376/diff/3/

Changes: https://reviews.apache.org/r/70376/diff/2-3/


Testing
---

1. Verified that new field "Zone Tag Services" is available on Zone form 
(create/update page).
2. Verified that  multiple Tag services can be mapped to zone using newly added 
field i.e "Zone Tag Services".
3. Verified that Same Tag services can be mapped to multiple zones.
4. Zone detail page display tag services associated with that zone.
5. Verified that When tag based services is not mapped to any zone, It displays 
message "No tag based services are associated with this zone" on Zone listing 
page.
6. Verified that Audit>>Admin logs gets generated for zone tag services field 
in zone form


Thanks,

Nitin Galave

Re: Review Request 70376: RANGER-2392: Create / Update zone to have provision to associate Tag based service with zone

2019-04-10 Thread Pradeep Agrawal 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70376/#review214527
---




security-admin/db/sqlserver/optimized/current/ranger_core_db_sqlserver.sql
Lines 2272 (patched)


change this to tag_srvc_id



security-admin/db/sqlserver/optimized/current/ranger_core_db_sqlserver.sql
Lines 2273 (patched)


change this to tag_srvc_name


- Pradeep Agrawal


On April 9, 2019, 12:38 p.m., Nitin Galave wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70376/
> ---
> 
> (Updated April 9, 2019, 12:38 p.m.)
> 
> 
> Review request for ranger, Abhay Kulkarni, Mehul Parikh, Nikhil P, Pradeep 
> Agrawal, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-2392
> https://issues.apache.org/jira/browse/RANGER-2392
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> Currently, Resource-based services are associated with the zone as part of 
> zone creation.
> Need to add a feature to only associate Tag based service as part of zone.
> No need to add resources with tag-based service association.
> 
> 
> Diffs
> -
> 
>   
> agents-common/src/main/java/org/apache/ranger/plugin/model/RangerSecurityZone.java
>  547e2d2 
>   security-admin/db/mysql/optimized/current/ranger_core_db_mysql.sql 2eaffcc 
>   security-admin/db/mysql/patches/037-create-security-zone-schema.sql aff9786 
>   security-admin/db/oracle/optimized/current/ranger_core_db_oracle.sql 
> 5ca1e36 
>   security-admin/db/oracle/patches/037-create-security-zone-schema.sql 
> aae31dc 
>   security-admin/db/postgres/optimized/current/ranger_core_db_postgres.sql 
> 51f4999 
>   security-admin/db/postgres/patches/037-create-security-zone-schema.sql 
> 4a94d26 
>   
> security-admin/db/sqlanywhere/optimized/current/ranger_core_db_sqlanywhere.sql
>  5f64a2d 
>   security-admin/db/sqlanywhere/patches/037-create-security-zone-schema.sql 
> 5b7dade 
>   security-admin/db/sqlserver/optimized/current/ranger_core_db_sqlserver.sql 
> fc21cec 
>   security-admin/db/sqlserver/patches/037-create-security-zone-schema.sql 
> e621b43 
>   
> security-admin/src/main/java/org/apache/ranger/biz/SecurityZoneRefUpdater.java
>  2b0c462 
>   security-admin/src/main/java/org/apache/ranger/common/RangerConstants.java 
> cdb5e11 
>   security-admin/src/main/java/org/apache/ranger/db/RangerDaoManagerBase.java 
> 3599cf3 
>   
> security-admin/src/main/java/org/apache/ranger/db/XXSecurityZoneRefTagServiceDao.java
>  PRE-CREATION 
>   
> security-admin/src/main/java/org/apache/ranger/entity/XXSecurityZoneRefTagService.java
>  PRE-CREATION 
>   security-admin/src/main/java/org/apache/ranger/rest/SecurityZoneREST.java 
> b8b8c1b 
>   
> security-admin/src/main/java/org/apache/ranger/service/RangerSecurityZoneService.java
>  04003f4 
>   security-admin/src/main/resources/META-INF/jpa_named_queries.xml 7e702c1 
>   security-admin/src/main/webapp/scripts/models/RangerZone.js 4f99c83 
>   security-admin/src/main/webapp/scripts/utils/XAUtils.js b14f4b9 
>   security-admin/src/main/webapp/scripts/views/policymanager/ServiceLayout.js 
> d3eb026 
>   security-admin/src/main/webapp/scripts/views/security_zone/SecurityZone.js 
> a1e9716 
>   
> security-admin/src/main/webapp/scripts/views/security_zone/ZoneAdministration.js
>  63fafb4 
>   security-admin/src/main/webapp/scripts/views/security_zone/ZoneCreate.js 
> dd34605 
>   security-admin/src/main/webapp/styles/xa.css f90f21b 
>   
> security-admin/src/main/webapp/templates/security_zone/SecurityZone_tmpl.html 
> f0b2572 
>   
> security-admin/src/main/webapp/templates/security_zone/ZoneAdministration_tmpl.html
>  89acb10 
>   
> security-admin/src/main/webapp/templates/security_zone/ZoneCreateForm_tmpl.html
>  fdcb821 
> 
> 
> Diff: https://reviews.apache.org/r/70376/diff/2/
> 
> 
> Testing
> ---
> 
> 1. Verified that new field "Zone Tag Services" is available on Zone form 
> (create/update page).
> 2. Verified that  multiple Tag services can be mapped to zone using newly 
> added field i.e "Zone Tag Services".
> 3. Verified that Same Tag services can be mapped to multiple zones.
> 4. Zone detail page display tag services associated with that zone.
> 5. Verified that When tag based services is not mapped to any zone, It 
> displays message "No tag based services are associated with this zone" on 
> Zone listing page.
> 6. Verified that Audit>>Admin logs gets generated for zone tag services field 
> in zone form
> 
> 
> Thanks,
> 
> Nitin Galave
> 
>

Re: Review Request 70376: RANGER-2392: Create / Update zone to have provision to associate Tag based service with zone

2019-04-09 Thread Mehul Parikh 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70376/#review214518
---


Ship it!




Ship It!

- Mehul Parikh


On April 9, 2019, 12:38 p.m., Nitin Galave wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70376/
> ---
> 
> (Updated April 9, 2019, 12:38 p.m.)
> 
> 
> Review request for ranger, Abhay Kulkarni, Mehul Parikh, Nikhil P, Pradeep 
> Agrawal, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-2392
> https://issues.apache.org/jira/browse/RANGER-2392
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> Currently, Resource-based services are associated with the zone as part of 
> zone creation.
> Need to add a feature to only associate Tag based service as part of zone.
> No need to add resources with tag-based service association.
> 
> 
> Diffs
> -
> 
>   
> agents-common/src/main/java/org/apache/ranger/plugin/model/RangerSecurityZone.java
>  547e2d2 
>   security-admin/db/mysql/optimized/current/ranger_core_db_mysql.sql 2eaffcc 
>   security-admin/db/mysql/patches/037-create-security-zone-schema.sql aff9786 
>   security-admin/db/oracle/optimized/current/ranger_core_db_oracle.sql 
> 5ca1e36 
>   security-admin/db/oracle/patches/037-create-security-zone-schema.sql 
> aae31dc 
>   security-admin/db/postgres/optimized/current/ranger_core_db_postgres.sql 
> 51f4999 
>   security-admin/db/postgres/patches/037-create-security-zone-schema.sql 
> 4a94d26 
>   
> security-admin/db/sqlanywhere/optimized/current/ranger_core_db_sqlanywhere.sql
>  5f64a2d 
>   security-admin/db/sqlanywhere/patches/037-create-security-zone-schema.sql 
> 5b7dade 
>   security-admin/db/sqlserver/optimized/current/ranger_core_db_sqlserver.sql 
> fc21cec 
>   security-admin/db/sqlserver/patches/037-create-security-zone-schema.sql 
> e621b43 
>   
> security-admin/src/main/java/org/apache/ranger/biz/SecurityZoneRefUpdater.java
>  2b0c462 
>   security-admin/src/main/java/org/apache/ranger/common/RangerConstants.java 
> cdb5e11 
>   security-admin/src/main/java/org/apache/ranger/db/RangerDaoManagerBase.java 
> 3599cf3 
>   
> security-admin/src/main/java/org/apache/ranger/db/XXSecurityZoneRefTagServiceDao.java
>  PRE-CREATION 
>   
> security-admin/src/main/java/org/apache/ranger/entity/XXSecurityZoneRefTagService.java
>  PRE-CREATION 
>   security-admin/src/main/java/org/apache/ranger/rest/SecurityZoneREST.java 
> b8b8c1b 
>   
> security-admin/src/main/java/org/apache/ranger/service/RangerSecurityZoneService.java
>  04003f4 
>   security-admin/src/main/resources/META-INF/jpa_named_queries.xml 7e702c1 
>   security-admin/src/main/webapp/scripts/models/RangerZone.js 4f99c83 
>   security-admin/src/main/webapp/scripts/utils/XAUtils.js b14f4b9 
>   security-admin/src/main/webapp/scripts/views/policymanager/ServiceLayout.js 
> d3eb026 
>   security-admin/src/main/webapp/scripts/views/security_zone/SecurityZone.js 
> a1e9716 
>   
> security-admin/src/main/webapp/scripts/views/security_zone/ZoneAdministration.js
>  63fafb4 
>   security-admin/src/main/webapp/scripts/views/security_zone/ZoneCreate.js 
> dd34605 
>   security-admin/src/main/webapp/styles/xa.css f90f21b 
>   
> security-admin/src/main/webapp/templates/security_zone/SecurityZone_tmpl.html 
> f0b2572 
>   
> security-admin/src/main/webapp/templates/security_zone/ZoneAdministration_tmpl.html
>  89acb10 
>   
> security-admin/src/main/webapp/templates/security_zone/ZoneCreateForm_tmpl.html
>  fdcb821 
> 
> 
> Diff: https://reviews.apache.org/r/70376/diff/2/
> 
> 
> Testing
> ---
> 
> 1. Verified that new field "Zone Tag Services" is available on Zone form 
> (create/update page).
> 2. Verified that  multiple Tag services can be mapped to zone using newly 
> added field i.e "Zone Tag Services".
> 3. Verified that Same Tag services can be mapped to multiple zones.
> 4. Zone detail page display tag services associated with that zone.
> 5. Verified that When tag based services is not mapped to any zone, It 
> displays message "No tag based services are associated with this zone" on 
> Zone listing page.
> 6. Verified that Audit>>Admin logs gets generated for zone tag services field 
> in zone form
> 
> 
> Thanks,
> 
> Nitin Galave
> 
>

Review Request 70376: RANGER-2392: Create / Update zone to have provision to associate Tag based service with zone

2019-04-03 Thread Nitin Galave 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70376/
---

Review request for ranger, Abhay Kulkarni, Mehul Parikh, Nikhil P, Pradeep 
Agrawal, and Velmurugan Periasamy.


Bugs: RANGER-2392
https://issues.apache.org/jira/browse/RANGER-2392


Repository: ranger


Description
---

Currently, Resource-based services are associated with the zone as part of zone 
creation.
Need to add a feature to only associate Tag based service as part of zone.
No need to add resources with tag-based service association.


Diffs
-

  
agents-common/src/main/java/org/apache/ranger/plugin/model/RangerSecurityZone.java
 547e2d2 
  security-admin/db/mysql/optimized/current/ranger_core_db_mysql.sql 2eaffcc 
  security-admin/db/mysql/patches/037-create-security-zone-schema.sql aff9786 
  security-admin/db/oracle/optimized/current/ranger_core_db_oracle.sql 5ca1e36 
  security-admin/db/oracle/patches/037-create-security-zone-schema.sql aae31dc 
  security-admin/db/postgres/optimized/current/ranger_core_db_postgres.sql 
51f4999 
  security-admin/db/postgres/patches/037-create-security-zone-schema.sql 
4a94d26 
  
security-admin/db/sqlanywhere/optimized/current/ranger_core_db_sqlanywhere.sql 
5f64a2d 
  security-admin/db/sqlanywhere/patches/037-create-security-zone-schema.sql 
5b7dade 
  security-admin/db/sqlserver/optimized/current/ranger_core_db_sqlserver.sql 
fc21cec 
  security-admin/db/sqlserver/patches/037-create-security-zone-schema.sql 
e621b43 
  
security-admin/src/main/java/org/apache/ranger/biz/SecurityZoneRefUpdater.java 
2b0c462 
  security-admin/src/main/java/org/apache/ranger/common/RangerConstants.java 
cdb5e11 
  security-admin/src/main/java/org/apache/ranger/db/RangerDaoManagerBase.java 
3599cf3 
  
security-admin/src/main/java/org/apache/ranger/db/XXSecurityZoneRefTagServiceDao.java
 PRE-CREATION 
  
security-admin/src/main/java/org/apache/ranger/entity/XXSecurityZoneRefTagService.java
 PRE-CREATION 
  security-admin/src/main/java/org/apache/ranger/rest/SecurityZoneREST.java 
b8b8c1b 
  
security-admin/src/main/java/org/apache/ranger/service/RangerSecurityZoneService.java
 04003f4 
  security-admin/src/main/resources/META-INF/jpa_named_queries.xml 7e702c1 
  security-admin/src/main/webapp/scripts/models/RangerZone.js 4f99c83 
  security-admin/src/main/webapp/scripts/utils/XAUtils.js b14f4b9 
  security-admin/src/main/webapp/scripts/views/policymanager/ServiceLayout.js 
d3eb026 
  security-admin/src/main/webapp/scripts/views/security_zone/SecurityZone.js 
a1e9716 
  
security-admin/src/main/webapp/scripts/views/security_zone/ZoneAdministration.js
 63fafb4 
  security-admin/src/main/webapp/scripts/views/security_zone/ZoneCreate.js 
dd34605 
  security-admin/src/main/webapp/styles/xa.css f90f21b 
  security-admin/src/main/webapp/templates/security_zone/SecurityZone_tmpl.html 
f0b2572 
  
security-admin/src/main/webapp/templates/security_zone/ZoneAdministration_tmpl.html
 89acb10 
  
security-admin/src/main/webapp/templates/security_zone/ZoneCreateForm_tmpl.html 
fdcb821 


Diff: https://reviews.apache.org/r/70376/diff/1/


Testing
---

1. Verified that new field "Zone Tag Services" is available on Zone form 
(create/update page).
2. Verified that  multiple Tag services can be mapped to zone using newly added 
field i.e "Zone Tag Services".
3. Verified that Same Tag services can be mapped to multiple zones.
4. Zone detail page display tag services associated with that zone.
5. Verified that When tag based services is not mapped to any zone, It displays 
message "No tag based services are associated with this zone" on Zone listing 
page.
6. Verified that Audit>>Admin logs gets generated for zone tag services field 
in zone form


Thanks,

Nitin Galave