Re: Review Request 70565: RANGER-2411 : Restrict Admin role user to create Zone for KMS service

2019-05-06 Thread Pradeep Agrawal 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70565/#review215057
---


Ship it!




Ship It!

- Pradeep Agrawal


On May 6, 2019, 5:50 a.m., Nikhil P wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70565/
> ---
> 
> (Updated May 6, 2019, 5:50 a.m.)
> 
> 
> Review request for ranger, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, 
> Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, Sailaja Polavarapu, and 
> Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-2411
> https://issues.apache.org/jira/browse/RANGER-2411
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> Restrict Admin role user to create Zone for KMS service
> 
> 
> Diffs
> -
> 
>   security-admin/src/main/java/org/apache/ranger/rest/SecurityZoneREST.java 
> 4f6fa89 
>   
> security-admin/src/test/java/org/apache/ranger/rest/TestSecurityZoneREST.java 
> edb3102 
> 
> 
> Diff: https://reviews.apache.org/r/70565/diff/4/
> 
> 
> Testing
> ---
> 
> Tested if Admin user is not able to create zone for KMS service.
> 
> 
> Thanks,
> 
> Nikhil P
> 
>

Re: Review Request 70565: RANGER-2411 : Restrict Admin role user to create Zone for KMS service

2019-05-05 Thread Nikhil P 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70565/
---

(Updated May 6, 2019, 11:20 a.m.)


Review request for ranger, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, 
Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, Sailaja Polavarapu, and 
Velmurugan Periasamy.


Bugs: RANGER-2411
https://issues.apache.org/jira/browse/RANGER-2411


Repository: ranger


Description
---

Restrict Admin role user to create Zone for KMS service


Diffs (updated)
-

  security-admin/src/main/java/org/apache/ranger/rest/SecurityZoneREST.java 
4f6fa89 
  security-admin/src/test/java/org/apache/ranger/rest/TestSecurityZoneREST.java 
edb3102 


Diff: https://reviews.apache.org/r/70565/diff/3/

Changes: https://reviews.apache.org/r/70565/diff/2-3/


Testing
---

Tested if Admin user is not able to create zone for KMS service.


Thanks,

Nikhil P

Re: Review Request 70565: RANGER-2411 : Restrict Admin role user to create Zone for KMS service

2019-05-03 Thread Ramesh Mani 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70565/#review215029
---



Fix it and ship it


security-admin/src/main/java/org/apache/ranger/rest/SecurityZoneREST.java
Lines 457 (patched)


Do we need to check isAdmin() here again?


- Ramesh Mani


On May 3, 2019, 8:54 a.m., Nikhil P wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70565/
> ---
> 
> (Updated May 3, 2019, 8:54 a.m.)
> 
> 
> Review request for ranger, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, 
> Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, Sailaja Polavarapu, and 
> Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-2411
> https://issues.apache.org/jira/browse/RANGER-2411
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> Restrict Admin role user to create Zone for KMS service
> 
> 
> Diffs
> -
> 
>   security-admin/src/main/java/org/apache/ranger/rest/SecurityZoneREST.java 
> 4f6fa89 
>   
> security-admin/src/test/java/org/apache/ranger/rest/TestSecurityZoneREST.java 
> edb3102 
> 
> 
> Diff: https://reviews.apache.org/r/70565/diff/2/
> 
> 
> Testing
> ---
> 
> Tested if Admin user is not able to create zone for KMS service.
> 
> 
> Thanks,
> 
> Nikhil P
> 
>

Re: Review Request 70565: RANGER-2411 : Restrict Admin role user to create Zone for KMS service

2019-05-03 Thread Velmurugan Periasamy 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70565/#review215018
---


Ship it!




Ship It!

- Velmurugan Periasamy


On May 3, 2019, 8:54 a.m., Nikhil P wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70565/
> ---
> 
> (Updated May 3, 2019, 8:54 a.m.)
> 
> 
> Review request for ranger, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, 
> Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, Sailaja Polavarapu, and 
> Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-2411
> https://issues.apache.org/jira/browse/RANGER-2411
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> Restrict Admin role user to create Zone for KMS service
> 
> 
> Diffs
> -
> 
>   security-admin/src/main/java/org/apache/ranger/rest/SecurityZoneREST.java 
> 4f6fa89 
>   
> security-admin/src/test/java/org/apache/ranger/rest/TestSecurityZoneREST.java 
> edb3102 
> 
> 
> Diff: https://reviews.apache.org/r/70565/diff/2/
> 
> 
> Testing
> ---
> 
> Tested if Admin user is not able to create zone for KMS service.
> 
> 
> Thanks,
> 
> Nikhil P
> 
>

Re: Review Request 70565: RANGER-2411 : Restrict Admin role user to create Zone for KMS service

2019-05-03 Thread Nikhil P 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70565/
---

(Updated May 3, 2019, 2:24 p.m.)


Review request for ranger, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, 
Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, Sailaja Polavarapu, and 
Velmurugan Periasamy.


Bugs: RANGER-2411
https://issues.apache.org/jira/browse/RANGER-2411


Repository: ranger


Description
---

Restrict Admin role user to create Zone for KMS service


Diffs (updated)
-

  security-admin/src/main/java/org/apache/ranger/rest/SecurityZoneREST.java 
4f6fa89 
  security-admin/src/test/java/org/apache/ranger/rest/TestSecurityZoneREST.java 
edb3102 


Diff: https://reviews.apache.org/r/70565/diff/2/

Changes: https://reviews.apache.org/r/70565/diff/1-2/


Testing
---

Tested if Admin user is not able to create zone for KMS service.


Thanks,

Nikhil P

Re: Review Request 70565: RANGER-2411 : Restrict Admin role user to create Zone for KMS service

2019-05-02 Thread Velmurugan Periasamy 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70565/#review215005
---




security-admin/src/main/java/org/apache/ranger/rest/SecurityZoneREST.java
Line 80 (original), 85 (patched)


please update the patch.

```
$ git apply --check -v /Users/vperiasamy/Downloads/RANGER-2411.patch
Checking patch 
security-admin/src/main/java/org/apache/ranger/rest/SecurityZoneREST.java...
Hunk #1 succeeded at 43 (offset 2 lines).
Hunk #2 succeeded at 57 (offset 2 lines).
error: while searching for:
@Autowired
RangerBizUtil bizUtil;

@POST
@Path("/zones")
public RangerSecurityZone createSecurityZone(RangerSecurityZone 
securityZone) {

error: patch failed: 
security-admin/src/main/java/org/apache/ranger/rest/SecurityZoneREST.java:85
error: 
security-admin/src/main/java/org/apache/ranger/rest/SecurityZoneREST.java: 
patch does not apply
Checking patch 
security-admin/src/test/java/org/apache/ranger/rest/TestSecurityZoneREST.java...
```


- Velmurugan Periasamy


On April 29, 2019, 8:11 a.m., Nikhil P wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70565/
> ---
> 
> (Updated April 29, 2019, 8:11 a.m.)
> 
> 
> Review request for ranger, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, 
> Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, Sailaja Polavarapu, and 
> Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-2411
> https://issues.apache.org/jira/browse/RANGER-2411
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> Restrict Admin role user to create Zone for KMS service
> 
> 
> Diffs
> -
> 
>   security-admin/src/main/java/org/apache/ranger/rest/SecurityZoneREST.java 
> 6ce5365 
>   
> security-admin/src/test/java/org/apache/ranger/rest/TestSecurityZoneREST.java 
> edb3102 
> 
> 
> Diff: https://reviews.apache.org/r/70565/diff/1/
> 
> 
> Testing
> ---
> 
> Tested if Admin user is not able to create zone for KMS service.
> 
> 
> Thanks,
> 
> Nikhil P
> 
>

Review Request 70565: RANGER-2411 : Restrict Admin role user to create Zone for KMS service

2019-04-29 Thread Nikhil P 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70565/
---

Review request for ranger, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, 
Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, Sailaja Polavarapu, and 
Velmurugan Periasamy.


Bugs: RANGER-2411
https://issues.apache.org/jira/browse/RANGER-2411


Repository: ranger


Description
---

Restrict Admin role user to create Zone for KMS service


Diffs
-

  security-admin/src/main/java/org/apache/ranger/rest/SecurityZoneREST.java 
6ce5365 
  security-admin/src/test/java/org/apache/ranger/rest/TestSecurityZoneREST.java 
edb3102 


Diff: https://reviews.apache.org/r/70565/diff/1/


Testing
---

Tested if Admin user is not able to create zone for KMS service.


Thanks,

Nikhil P