Re: Release 2.2 comments

2011-07-01 Thread Peter
I'll go over the list archives and get back to you, the tests might currently be disabled, or perhaps it was fixed, by the way what platform are you compilling on? Peter. - Original message - > In what sense does the qa suite require jdk1.6? > > With the modification to change NameServi

Re: Release 2.2 comments

2011-06-30 Thread Patricia Shanahan
In what sense does the qa suite require jdk1.6? With the modification to change NameServiceImpl back to the 1.5 NameService interface, I just did a successful JDK1.5 "ant all.build". Patricia On 6/30/2011 12:25 AM, Peter wrote: The qa suite needs to be considered separately from the main bui

Re: Release 2.2 comments

2011-06-30 Thread Gregg Wonderly
+1 I vote a non-binding +1 to release. I agree with Peter's perspective too. The fact that the tests need to be compiled under JDK1.6 is a distraction that can be worked on separately from putting out releases. There is an environment to run 100% test coverage in, and the known limitations

Re: Release 2.2 comments

2011-06-30 Thread Patricia Shanahan
I was waiting precisely to find out whether it was used or not. In the presence of reflection a clean compile without a class is not definitive evidence of non-use. The conclusion is that it is used. I got into this by reading and following the "Getting Started" instructions in the release ca

Re: Release 2.2 comments

2011-06-30 Thread Dan Creswell
On 30 June 2011 08:25, Peter wrote: > The qa suite needs to be considered separately from the main build.  It > currently requires jdk1.6, there are other tests using sun internal > implementations that depend on jdk 1.6. > > With source=1.4 or jsr14 it didn't matter, it still had to be compiled

Re: Release 2.2 comments

2011-06-30 Thread Tom Hobbs
If its not used then delete it now. Why wait? But I get what you're saying about the problem being more than just this file. Is this building in 6 and testing in 5/6 documented on the web? I can't remember off hand and not in a position to check. In any case... +1 release current artifacts (r

Re: Release 2.2 comments

2011-06-30 Thread Peter
The qa suite needs to be considered separately from the main build. It currently requires jdk1.6, there are other tests using sun internal implementations that depend on jdk 1.6. With source=1.4 or jsr14 it didn't matter, it still had to be compiled with 1.6, we bundled it into the main build

Re: Release 2.2 comments

2011-06-29 Thread Patricia Shanahan
I'm signing off for the night. Sill one failure. Patricia On 6/29/2011 8:56 PM, Patricia Shanahan wrote: I got a QA test failure, com/sun/jini/test/impl/reggie/MultihomedClientTest.td. The failure is due to the missing com.sun.jini.test.impl.reggie.NameServiceDescriptorImpl class. That leaves

Re: Release 2.2 comments

2011-06-29 Thread Patricia Shanahan
I got a QA test failure, com/sun/jini/test/impl/reggie/MultihomedClientTest.td. The failure is due to the missing com.sun.jini.test.impl.reggie.NameServiceDescriptorImpl class. That leaves us with the following options: 1. Insist on Java 5 compilation, and change the code to match the Java 5

Re: Release 2.2 comments

2011-06-29 Thread Peter
http://rkuzmik.blogspot.com/2006/08/local-managed-dns-java_11.html This might help explain the usage. Peter. - Original message - > Over 250 tests passed with no failures. Meanwhile, I've done some > grepping, and found one use, in a text file: > > more > ./qa/src/com/sun/jini/test/impl/

Re: Release 2.2 comments

2011-06-29 Thread Patricia Shanahan
Over 250 tests passed with no failures. Meanwhile, I've done some grepping, and found one use, in a text file: more ./qa/src/com/sun/jini/test/impl/reggie/META-INF/services/sun.net.spi.nameservice.NameServiceDescriptor com.sun.jini.test.impl.reggie.NameServiceDescriptorImpl The file has been

Re: Release 2.2 comments

2011-06-29 Thread Tom Hobbs
Well that's something. A good something! Fingers cross on the QA tests. I'm just about to sign off now, but please check the deletions into the trunk if/when you're happy with them and I'll create some new RCs. If only all fixes were as simple. On Wed, Jun 29, 2011 at 9:56 PM, Patricia Shanah

Re: Release 2.2 comments

2011-06-29 Thread Patricia Shanahan
I've done a clean build with the classes in question deleted. It got a "BUILD SUCCESSFUL". I'll start the QA tests that way, but I suggest making that change. (I'm not checking in anything to the trunk right now, to avoid risk of tripping up your efforts). Patricia On 6/29/2011 1:07 PM, Tom H

Re: Release 2.2 comments

2011-06-29 Thread Tom Hobbs
I've just done a quick search for uses of NameServiceImpl and the only thing I could find was in NameServiceDescriptorImpl. And I couldn't find any references for that. Given that the package is "com.sun.jini.test.impl.reggie" for both of these classes, can I assume that they're for some test onl

Re: Release 2.2 comments

2011-06-28 Thread Peter
We have a number of uses of internal sun impl classes, I'd agree they should all be replaced so we can expand beyond the sun implementation. Is there a related jira? If you can see a simple fix eliminating the sun dependency, go for it, otherwise I think just fix it enough to get our release o

Re: Release 2.2 comments

2011-06-28 Thread Patricia Shanahan
I think the problem may go deeper. sun.net.spi.nameservice.NameService is a sun.net interface that can change from version to version. Is it essential that we have our own implementation? Patricia On 6/28/2011 12:18 AM, Peter wrote: Oops, I fixed that but didn't commit, sorry Not near my de

Re: Release 2.2 comments

2011-06-27 Thread Peter
Oops, I fixed that but didn't commit, sorry Not near my dev box, but the fix is relatively simple, get byte array from each InetAddress, and return byte[][] instead, can someone fix it? - Original message - > I downloaded the source, and tried a naive build on Windows XP, Cygwin. > I pu

Re: Release 2.2 comments

2011-06-27 Thread Patricia Shanahan
I'll take a bit more of look at it tomorrow. Also, I'll run any tests or experiments you recommend then. Patricia On 6/27/2011 10:29 PM, Tom Hobbs wrote: Thanks, Patricia. I'll. Try and look at those tonight. I don't know how much luck I will have though, no Windows machines in my house! C

Re: Release 2.2 comments

2011-06-27 Thread Tom Hobbs
Thanks, Patricia. I'll. Try and look at those tonight. I don't know how much luck I will have though, no Windows machines in my house! Cheers, Tom Grammar and spelling have been sacrificed on the altar of messaging via mobile device. On 28 Jun 2011 04:42, "Patricia Shanahan" wrote: > I dow

Release 2.2 comments

2011-06-27 Thread Patricia Shanahan
I downloaded the source, and tried a naive build on Windows XP, Cygwin. I put a JDK 1.5 bin directory at the start of my path, and ran "ant all.build". It failed with the following errors: compile: [javac] Compiling 1993 source files to C:\Documents and Settings\Administrator\My Documents