[GitHub] [rocketmq-connect] odbozhou closed pull request #295: [ISSUE #220] Fix failed unit test

2022-08-31 Thread GitBox
odbozhou closed pull request #295: [ISSUE #220] Fix failed unit test URL: https://github.com/apache/rocketmq-connect/pull/295 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [rocketmq-connect] odbozhou merged pull request #296: [ISSUE #294]StateManagementServiceImpl null pointer exception

2022-08-31 Thread GitBox
odbozhou merged PR #296: URL: https://github.com/apache/rocketmq-connect/pull/296 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [rocketmq-site] RockChuLee opened a new pull request, #196: Push consumer

2022-08-31 Thread GitBox
RockChuLee opened a new pull request, #196: URL: https://github.com/apache/rocketmq-site/pull/196 Please do not create a Pull Request without creating an issue first. ## What is the purpose of the change Add the English-version Push Consumer. ## Brief changelog

[RESULT] [VOTE] Release gRPC Java Client for Apache RocketMQ 5.0.1 RC1

2022-08-31 Thread aaron ai
Hello RocketMQ Community, The Apache RocketMQ vote is now closed and has passed with 5 binding +1s, 0 non-binding +1s and no 0 or -1; Binding votes +1s: yukon(yu...@apache.org) Xiaorui Wang(vintagew...@apache.org) Qinshan Lin(linh...@apache.org) Rongrong Jin(jinrongt...@apache.org) Zhanhui

[GitHub] [rocketmq-clients] aaron-ai merged pull request #219: Add build-result into status check

2022-08-31 Thread GitBox
aaron-ai merged PR #219: URL: https://github.com/apache/rocketmq-clients/pull/219 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [rocketmq] azhsmesos opened a new issue, #4962: doc 问题

2022-08-31 Thread GitBox
azhsmesos opened a new issue, #4962: URL: https://github.com/apache/rocketmq/issues/4962 https://user-images.githubusercontent.com/65518067/187828797-f39d2b03-956e-449a-a2f8-fb8adffaced8.png;> 今天在讨论时有人说官网说 consumer queue这个概念,我看了一下给的链接,我感觉这儿表述不清晰容易给人带来误解吧 -- This is an automated

[GitHub] [rocketmq] lizhanhui commented on pull request #4754: using take replace poll

2022-08-31 Thread GitBox
lizhanhui commented on PR #4754: URL: https://github.com/apache/rocketmq/pull/4754#issuecomment-1233703508 @kang-hl Please rebase to the latest `develop` branch to trigger CI checks that are required to merge this pull request. -- This is an automated message from the Apache Git

[GitHub] [rocketmq] lizhanhui commented on pull request #4942: prepare to release rocketmq 5.0.0 version

2022-08-31 Thread GitBox
lizhanhui commented on PR #4942: URL: https://github.com/apache/rocketmq/pull/4942#issuecomment-1233701888 Where is the associated issue? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [rocketmq] lollipopjin merged pull request #4961: fix code style in MQClientInstance

2022-08-31 Thread GitBox
lollipopjin merged PR #4961: URL: https://github.com/apache/rocketmq/pull/4961 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [rocketmq] SeaItFover commented on pull request #4961: fix code style in MQClientInstance

2022-08-31 Thread GitBox
SeaItFover commented on PR #4961: URL: https://github.com/apache/rocketmq/pull/4961#issuecomment-1233673626 > fixed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [rocketmq-clients] lizhanhui merged pull request #209: Add FIFO/Timed message publishment examples

2022-08-31 Thread GitBox
lizhanhui merged PR #209: URL: https://github.com/apache/rocketmq-clients/pull/209 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [rocketmq-schema-registry] MatrixHB opened a new pull request, #56: Optimize code before 1.0-release

2022-08-31 Thread GitBox
MatrixHB opened a new pull request, #56: URL: https://github.com/apache/rocketmq-schema-registry/pull/56 to fix some bugs or code-format. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [rocketmq-clients] aaron-ai merged pull request #217: Feature/add c sharp log path

2022-08-31 Thread GitBox
aaron-ai merged PR #217: URL: https://github.com/apache/rocketmq-clients/pull/217 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [rocketmq-clients] aaron-ai merged pull request #218: Revert "Remove misspell-check from required_status_checks"

2022-08-31 Thread GitBox
aaron-ai merged PR #218: URL: https://github.com/apache/rocketmq-clients/pull/218 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [rocketmq-clients] aaron-ai opened a new pull request, #218: Revert "Remove misspell-check from required_status_checks"

2022-08-31 Thread GitBox
aaron-ai opened a new pull request, #218: URL: https://github.com/apache/rocketmq-clients/pull/218 Reverts apache/rocketmq-clients#216 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [rocketmq-clients] aaron-ai merged pull request #216: Remove misspell-check from required_status_checks

2022-08-31 Thread GitBox
aaron-ai merged PR #216: URL: https://github.com/apache/rocketmq-clients/pull/216 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [rocketmq] codecov-commenter commented on pull request #4957: [ISSUE #4945] Adjust the storedir format of test cases to the Windows platform

2022-08-31 Thread GitBox
codecov-commenter commented on PR #4957: URL: https://github.com/apache/rocketmq/pull/4957#issuecomment-1233660211 # [Codecov](https://codecov.io/gh/apache/rocketmq/pull/4957?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)

[GitHub] [rocketmq-schema-registry] MatrixHB commented on pull request #53: [WIP] add protobuf schema evoluation

2022-08-31 Thread GitBox
MatrixHB commented on PR #53: URL: https://github.com/apache/rocketmq-schema-registry/pull/53#issuecomment-1233658490 > > @complone您好,非常感谢您贡献这个PR,但是在您进一步优化之前,我需要确认您是否对protobuf的兼容性验证有任何误解? 这里所谓的兼容性验证关注的是兼容性,也就是比较更新后的protobuf schema和之前版本的protobuf schema,其变化是否会使得消息的生产和消费不兼容。 > >

[GitHub] [rocketmq-clients] aaron-ai merged pull request #213: Update C# log path

2022-08-31 Thread GitBox
aaron-ai merged PR #213: URL: https://github.com/apache/rocketmq-clients/pull/213 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [rocketmq] xdkxlk closed issue #4955: Should validate userProperties contain control character or not

2022-08-31 Thread GitBox
xdkxlk closed issue #4955: Should validate userProperties contain control character or not URL: https://github.com/apache/rocketmq/issues/4955 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [rocketmq] xdkxlk closed issue #4953: Should return INVALID_RECEIPT_HANDLE when cannot find the broker of one handle

2022-08-31 Thread GitBox
xdkxlk closed issue #4953: Should return INVALID_RECEIPT_HANDLE when cannot find the broker of one handle URL: https://github.com/apache/rocketmq/issues/4953 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [rocketmq] xdkxlk closed issue #4947: Concurrency problem when write client settings and other data at the same time

2022-08-31 Thread GitBox
xdkxlk closed issue #4947: Concurrency problem when write client settings and other data at the same time URL: https://github.com/apache/rocketmq/issues/4947 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [rocketmq] xdkxlk closed issue #4939: Should stop renew when some error occurred in the renew process of ReceiptHandleProcessor

2022-08-31 Thread GitBox
xdkxlk closed issue #4939: Should stop renew when some error occurred in the renew process of ReceiptHandleProcessor URL: https://github.com/apache/rocketmq/issues/4939 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [rocketmq] xdkxlk closed issue #4938: Concurrency problems when renew handle and ack or changeInvisibleTime at the same time

2022-08-31 Thread GitBox
xdkxlk closed issue #4938: Concurrency problems when renew handle and ack or changeInvisibleTime at the same time URL: https://github.com/apache/rocketmq/issues/4938 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [rocketmq] tsunghanjacktsai commented on pull request #4961: fix code style in MQClientInstance

2022-08-31 Thread GitBox
tsunghanjacktsai commented on PR #4961: URL: https://github.com/apache/rocketmq/pull/4961#issuecomment-1233654747 Hi @SeaItFover , Thanks for your detailed changes. Please fix the style errors reported by CI. -- This is an automated message from the Apache Git Service. To respond

[GitHub] [rocketmq] lizhanhui merged pull request #4940: [ISSUE #4938, ISSUE #4939] fix the concurrency problems and limit the times of renew when some error occurred in ReceiptHandleProcessor

2022-08-31 Thread GitBox
lizhanhui merged PR #4940: URL: https://github.com/apache/rocketmq/pull/4940 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [rocketmq] TheR1sing3un commented on issue #4959: Fix the logic when deal with a read_event with empty events(the log need to be appended by DLedger)

2022-08-31 Thread GitBox
TheR1sing3un commented on issue #4959: URL: https://github.com/apache/rocketmq/issues/4959#issuecomment-1233648091 > Hello @TheR1sing3un > The theme and the PR changes don't match, I guess > > It should be > > Fix the logic when deal with a `write_event` with empty

[GitHub] [rocketmq] duhenglucky closed issue #4902: 把循环index的类型由long改为int,让循环前放置Safepoint,效果会不会比Thread.sleep(0)更好?

2022-08-31 Thread GitBox
duhenglucky closed issue #4902: 把循环index的类型由long改为int,让循环前放置Safepoint,效果会不会比Thread.sleep(0)更好? URL: https://github.com/apache/rocketmq/issues/4902 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [rocketmq] lizhanhui commented on pull request #4674: Remove redundant else

2022-08-31 Thread GitBox
lizhanhui commented on PR #4674: URL: https://github.com/apache/rocketmq/pull/4674#issuecomment-1233645813 @123monkey Can you please rebase on top of the latest `develop` branch? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [rocketmq] SeaItFover opened a new pull request, #4961: fix code style in MQClientInstance

2022-08-31 Thread GitBox
SeaItFover opened a new pull request, #4961: URL: https://github.com/apache/rocketmq/pull/4961 **Make sure set the target branch to `develop`** ## What is the purpose of the change X ## Brief changelog XX ## Verifying this change

[GitHub] [rocketmq] lizhanhui commented on pull request #4891: [ISSUE 4890] WIP Fix binary search consume offset by time

2022-08-31 Thread GitBox
lizhanhui commented on PR #4891: URL: https://github.com/apache/rocketmq/pull/4891#issuecomment-1233635461 I do not have the working bandwidth for this pull request, for now, let's postpone it to the next release cycle. -- This is an automated message from the Apache Git Service. To

[GitHub] [rocketmq] lizhanhui merged pull request #4881: send async,time calculation rules Multiple method patches

2022-08-31 Thread GitBox
lizhanhui merged PR #4881: URL: https://github.com/apache/rocketmq/pull/4881 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [rocketmq] lizhanhui merged pull request #4956: [ISSUE #4955] validate userProperties contain control character or not

2022-08-31 Thread GitBox
lizhanhui merged PR #4956: URL: https://github.com/apache/rocketmq/pull/4956 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [rocketmq] lizhanhui merged pull request #4954: [ISSUE #4953] return INVALID_RECEIPT_HANDLE when cannot find the broker of handle

2022-08-31 Thread GitBox
lizhanhui merged PR #4954: URL: https://github.com/apache/rocketmq/pull/4954 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [rocketmq] lizhanhui merged pull request #4948: Fix concurrency problems in ClientActivity of proxy

2022-08-31 Thread GitBox
lizhanhui merged PR #4948: URL: https://github.com/apache/rocketmq/pull/4948 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [rocketmq] Oliverwqcwrw commented on pull request #4903: fix-warmMappedFile:Place a safepoint before the loop, the processing effect takes precedence over sleep

2022-08-31 Thread GitBox
Oliverwqcwrw commented on PR #4903: URL: https://github.com/apache/rocketmq/pull/4903#issuecomment-1233632181 > @Oliverwqcwrw Why not perform an A-B test between the current solution and the proposed one, let data talk. agree with, The data makes it easier for us to choose specific

[GitHub] [rocketmq] Oliverwqcwrw commented on pull request #4903: fix-warmMappedFile:Place a safepoint before the loop, the processing effect takes precedence over sleep

2022-08-31 Thread GitBox
Oliverwqcwrw commented on PR #4903: URL: https://github.com/apache/rocketmq/pull/4903#issuecomment-1233631786 > @Oliverwqcwrw Why not perform an A-B test between the current solution and the proposed one, let data talk. agree with, The data makes it easier for us to choose specific

[GitHub] [rocketmq] lizhanhui commented on pull request #4903: fix-warmMappedFile:Place a safepoint before the loop, the processing effect takes precedence over sleep

2022-08-31 Thread GitBox
lizhanhui commented on PR #4903: URL: https://github.com/apache/rocketmq/pull/4903#issuecomment-1233630387 @Oliverwqcwrw Why not perform an A-B test between the current solution and the proposed one, let data talk. -- This is an automated message from the Apache Git Service. To respond

Re: Re:Re: [Vote] Release gRPC Java Client for Apache RocketMQ 5.0.1 RC1

2022-08-31 Thread Zhanhui Li
+1 On Wed, Aug 31, 2022 at 9:45 PM jinrongtong wrote: > +1, I checked[OK] Hash and Tag in GitHub repo is matching the > current artifacts[OK] Maven jar in nexus repo is > right[OK] The release note is clear[OK] verify the > asc(PGP sign) > At 2022-08-31 14:52:22, "hill" wrote: > >+1 > > > >At

[GitHub] [rocketmq] mxsm closed issue #4958: Fix test case: AutoSwitchHATest#testTruncateEpochLogAndChangeMaster

2022-08-31 Thread GitBox
mxsm closed issue #4958: Fix test case: AutoSwitchHATest#testTruncateEpochLogAndChangeMaster URL: https://github.com/apache/rocketmq/issues/4958 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [rocketmq] mxsm commented on a diff in pull request #4957: [ISSUE #4945] Adjust the storedir format of test cases to the Windows platform

2022-08-31 Thread GitBox
mxsm commented on code in PR #4957: URL: https://github.com/apache/rocketmq/pull/4957#discussion_r960138680 ## store/src/test/java/org/apache/rocketmq/store/ha/autoswitch/AutoSwitchHATest.java: ## @@ -72,9 +73,9 @@ public class AutoSwitchHATest { private String

[GitHub] [rocketmq] Oliverwqcwrw commented on issue #4959: Fix the logic when deal with a read_event with empty events(the log need to be appended by DLedger)

2022-08-31 Thread GitBox
Oliverwqcwrw commented on issue #4959: URL: https://github.com/apache/rocketmq/issues/4959#issuecomment-1233618189 Hello @TheR1sing3un The theme and the PR changes don't match, I guess It should be Fix the logic when deal with a `write_event` with empty events(the log need

[GitHub] [rocketmq] mxsm commented on a diff in pull request #4957: [ISSUE #4945] Adjust the storedir format of test cases to the Windows platform

2022-08-31 Thread GitBox
mxsm commented on code in PR #4957: URL: https://github.com/apache/rocketmq/pull/4957#discussion_r960138680 ## store/src/test/java/org/apache/rocketmq/store/ha/autoswitch/AutoSwitchHATest.java: ## @@ -72,9 +73,9 @@ public class AutoSwitchHATest { private String

[GitHub] [rocketmq] Oliverwqcwrw commented on a diff in pull request #4957: [ISSUE #4945] Adjust the storedir format of test cases to the Windows platform

2022-08-31 Thread GitBox
Oliverwqcwrw commented on code in PR #4957: URL: https://github.com/apache/rocketmq/pull/4957#discussion_r960132420 ## store/src/test/java/org/apache/rocketmq/store/ha/autoswitch/AutoSwitchHATest.java: ## @@ -72,9 +73,9 @@ public class AutoSwitchHATest { private String

[GitHub] [rocketmq] Oliverwqcwrw commented on pull request #4903: fix-warmMappedFile:Place a safepoint before the loop, the processing effect takes precedence over sleep

2022-08-31 Thread GitBox
Oliverwqcwrw commented on PR #4903: URL: https://github.com/apache/rocketmq/pull/4903#issuecomment-1233593164 Would it be better to place safepoint if we had GC problems in the current situation ? -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [rocketmq-schema-registry] complone commented on pull request #53: [WIP] add protobuf schema evoluation

2022-08-31 Thread GitBox
complone commented on PR #53: URL: https://github.com/apache/rocketmq-schema-registry/pull/53#issuecomment-1233477020 > @complone您好,非常感谢您贡献这个PR,但是在您进一步优化之前,我需要确认您是否对protobuf的兼容性验证有任何误解? 这里所谓的兼容性验证关注的是兼容性,也就是比较更新后的protobuf schema和之前版本的protobuf schema,其变化是否会使得消息的生产和消费不兼容。 > >

[GitHub] [rocketmq-connect] ingdex opened a new pull request, #299: add doris sink connector

2022-08-31 Thread GitBox
ingdex opened a new pull request, #299: URL: https://github.com/apache/rocketmq-connect/pull/299 add doris sink connector -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [rocketmq-connect] ingdex closed pull request #298: add doris sink connector

2022-08-31 Thread GitBox
ingdex closed pull request #298: add doris sink connector URL: https://github.com/apache/rocketmq-connect/pull/298 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [rocketmq-connect] ingdex opened a new pull request, #298: add doris sink connector

2022-08-31 Thread GitBox
ingdex opened a new pull request, #298: URL: https://github.com/apache/rocketmq-connect/pull/298 add doris sink connector -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [rocketmq-connect] ingdex closed pull request #251: pass checkstyle

2022-08-31 Thread GitBox
ingdex closed pull request #251: pass checkstyle URL: https://github.com/apache/rocketmq-connect/pull/251 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[GitHub] [rocketmq] TheR1sing3un opened a new pull request, #4960: [ISSUE#4959]: fix the logic when deal with a write event with empt…

2022-08-31 Thread GitBox
TheR1sing3un opened a new pull request, #4960: URL: https://github.com/apache/rocketmq/pull/4960 …y events 1. fix the logic when deal with a write event with empty events issue: https://github.com/apache/rocketmq/issues/4959 **Make sure set the target branch to

[GitHub] [rocketmq] TheR1sing3un opened a new issue, #4959: Fix the logic when deal with a read_event with empty events(the log need to be appended by DLedger)

2022-08-31 Thread GitBox
TheR1sing3un opened a new issue, #4959: URL: https://github.com/apache/rocketmq/issues/4959 > DLedgerController.ControllerEventHandler#run() ![image](https://user-images.githubusercontent.com/87409330/187713599-c5dd92d9-440c-4740-8b35-4434d3bc2a43.png) If a write_event has

[GitHub] [rocketmq] mxsm opened a new issue, #4958: Fix test case: AutoSwitchHATest#testTruncateEpochLogAndChangeMaster

2022-08-31 Thread GitBox
mxsm opened a new issue, #4958: URL: https://github.com/apache/rocketmq/issues/4958 https://github.com/apache/rocketmq/runs/8116118273?check_suite_focus=true ![image](https://user-images.githubusercontent.com/15797831/187711071-4cee9f07-38a7-41d7-8e61-05b36c2814dd.png) -- This is an

[GitHub] [rocketmq-schema-registry] MatrixHB commented on pull request #53: [WIP] add protobuf schema evoluation

2022-08-31 Thread GitBox
MatrixHB commented on PR #53: URL: https://github.com/apache/rocketmq-schema-registry/pull/53#issuecomment-1233048960 You can take a look at how _kafka-schema-registry_ deals with protobuf compatibility validation. It focuses on change between two versions of protobuf schema.

[GitHub] [rocketmq-schema-registry] MatrixHB commented on pull request #53: [WIP] add protobuf schema evoluation

2022-08-31 Thread GitBox
MatrixHB commented on PR #53: URL: https://github.com/apache/rocketmq-schema-registry/pull/53#issuecomment-1233039561 @complone Hello, thank you very much for contributing this PR, but before you further optimize, I need to confirm whether you have any misunderstanding about the

[GitHub] [rocketmq] mxsm opened a new pull request, #4957: [ISSUE #4945] Adjust the storedir format of test cases to the Windows platform

2022-08-31 Thread GitBox
mxsm opened a new pull request, #4957: URL: https://github.com/apache/rocketmq/pull/4957 **Make sure set the target branch to `develop`** ## What is the purpose of the change close #4945 ## Brief changelog - Adjust the storedir format of test cases to the

Re:Re:Re: [Vote] Release gRPC Java Client for Apache RocketMQ 5.0.1 RC1

2022-08-31 Thread jinrongtong
+1, I checked[OK] Hash and Tag in GitHub repo is matching the current artifacts[OK] Maven jar in nexus repo is right[OK] The release note is clear[OK] verify the asc(PGP sign) At 2022-08-31 14:52:22, "hill" wrote: >+1 > >At 2022-08-31 13:32:54, "Xiaorui Wang" wrote: >>+1 >> >>yukon 于2022年8月31日

Re:[VOTE] Release Apache RocketMQ-MQTT 1.0.0

2022-08-31 Thread jinrongtong
+1, I checked [OK] Hash and Tag in GitHub repo is matching the current artifacts [OK] Maven jar in nexus repo is right [OK] Verify the asc(PGP sign),SHA512 At 2022-08-29 10:07:06, "Ping Wang" wrote: [VOTE] Release Apache RocketMQ-MQTT 1.0.0 Hello RocketMQ Community, This is the vote for

[GitHub] [rocketmq-clients] guyinyou commented on issue #181: Golang: Print requestId to log

2022-08-31 Thread GitBox
guyinyou commented on issue #181: URL: https://github.com/apache/rocketmq-clients/issues/181#issuecomment-1232945271 done in #215 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [rocketmq-clients] guyinyou opened a new pull request, #215: log error with requestId

2022-08-31 Thread GitBox
guyinyou opened a new pull request, #215: URL: https://github.com/apache/rocketmq-clients/pull/215 log error with requestId -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [rocketmq-connect] sunxiaojian opened a new pull request, #297: [ISSUE #252]Replace the use of the Converter interface with RecordConverter

2022-08-31 Thread GitBox
sunxiaojian opened a new pull request, #297: URL: https://github.com/apache/rocketmq-connect/pull/297 ## What is the purpose of the change X ## Brief changelog XX ## Verifying this change Follow this checklist to help us incorporate your

[GitHub] [rocketmq] xdkxlk opened a new pull request, #4956: [ISSUE #4955] validate userProperties contain control character or not

2022-08-31 Thread GitBox
xdkxlk opened a new pull request, #4956: URL: https://github.com/apache/rocketmq/pull/4956 **Make sure set the target branch to `develop`** ## What is the purpose of the change validate userProperties contain control character or not ## Brief changelog XX

[GitHub] [rocketmq] xdkxlk opened a new issue, #4955: Should validate userProperties contain control character or not

2022-08-31 Thread GitBox
xdkxlk opened a new issue, #4955: URL: https://github.com/apache/rocketmq/issues/4955 We should return ILLEGAL_MESSAGE_PROPERTY_KEY when userProperties contain control character -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [rocketmq] xdkxlk opened a new pull request, #4954: [ISSUE #4953] return INVALID_RECEIPT_HANDLE when cannot find the broker of handle

2022-08-31 Thread GitBox
xdkxlk opened a new pull request, #4954: URL: https://github.com/apache/rocketmq/pull/4954 **Make sure set the target branch to `develop`** ## What is the purpose of the change return INVALID_RECEIPT_HANDLE when cannot find the broker of handle ## Brief changelog

[GitHub] [rocketmq] xdkxlk opened a new issue, #4953: Should return INVALID_RECEIPT_HANDLE when cannot find the broker of one handle

2022-08-31 Thread GitBox
xdkxlk opened a new issue, #4953: URL: https://github.com/apache/rocketmq/issues/4953 We should return INVALID_RECEIPT_HANDLE when cannot find the broker of one handle. Client will not to retry ack/changeInvisibleTime after receive INVALID_RECEIPT_HANDLE -- This is an automated message

[GitHub] [rocketmq] RongtongJin closed issue #4950: Fix wrong typo about DLedger

2022-08-31 Thread GitBox
RongtongJin closed issue #4950: Fix wrong typo about DLedger URL: https://github.com/apache/rocketmq/issues/4950 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [rocketmq] RongtongJin merged pull request #4951: [ISSUE#4950] fix wrong typo about DLedger

2022-08-31 Thread GitBox
RongtongJin merged PR #4951: URL: https://github.com/apache/rocketmq/pull/4951 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [rocketmq] aaron-ai closed pull request #4952: WIP

2022-08-31 Thread GitBox
aaron-ai closed pull request #4952: WIP URL: https://github.com/apache/rocketmq/pull/4952 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [rocketmq] aaron-ai opened a new pull request, #4952: WIP

2022-08-31 Thread GitBox
aaron-ai opened a new pull request, #4952: URL: https://github.com/apache/rocketmq/pull/4952 **Make sure set the target branch to `develop`** ## What is the purpose of the change X ## Brief changelog XX ## Verifying this change Follow

[GitHub] [rocketmq-connect] sunxiaojian opened a new pull request, #296: [ISSUE #294]StateManagementServiceImpl null pointer exception

2022-08-31 Thread GitBox
sunxiaojian opened a new pull request, #296: URL: https://github.com/apache/rocketmq-connect/pull/296 ## What is the purpose of the change X ## Brief changelog XX ## Verifying this change Follow this checklist to help us incorporate your

[GitHub] [rocketmq] TheR1sing3un opened a new pull request, #4951: [ISSUE#4950] fix wrong typo about DLedger

2022-08-31 Thread GitBox
TheR1sing3un opened a new pull request, #4951: URL: https://github.com/apache/rocketmq/pull/4951 **Make sure set the target branch to `develop`** ## What is the purpose of the change issue: https://github.com/apache/rocketmq/issues/4950 X ## Brief changelog XX

[GitHub] [rocketmq-clients] aaron-ai closed issue #206: Client log file location specification

2022-08-31 Thread GitBox
aaron-ai closed issue #206: Client log file location specification URL: https://github.com/apache/rocketmq-clients/issues/206 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [rocketmq-clients] aaron-ai merged pull request #214: Initial commit of observability docs

2022-08-31 Thread GitBox
aaron-ai merged PR #214: URL: https://github.com/apache/rocketmq-clients/pull/214 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [rocketmq] TheR1sing3un opened a new issue, #4950: Fix wrong typo about DLedger

2022-08-31 Thread GitBox
TheR1sing3un opened a new issue, #4950: URL: https://github.com/apache/rocketmq/issues/4950 The issue tracker is used for bug reporting purposes **ONLY** whereas feature request needs to follow the [RIP process](https://github.com/apache/rocketmq/wiki/RocketMQ-Improvement-Proposal). To

[GitHub] [rocketmq] aaron-ai opened a new issue, #4949: Fix 'Address already in use' in AutoSwitchRoleIntegrationTest#testCheckSyncStateSet

2022-08-31 Thread GitBox
aaron-ai opened a new issue, #4949: URL: https://github.com/apache/rocketmq/issues/4949 https://github.com/apache/rocketmq/runs/8110128184?check_suite_focus=true ![image](https://user-images.githubusercontent.com/19537356/187649959-e261306e-fb82-4f23-a964-42fed1470e94.png) --

[GitHub] [rocketmq-client-nodejs] wuteng606 commented on issue #27: npm install 403

2022-08-31 Thread GitBox
wuteng606 commented on issue #27: URL: https://github.com/apache/rocketmq-client-nodejs/issues/27#issuecomment-1232711927 > https://opensource-rocketmq-client.oss-cn-hangzhou.aliyuncs.com/cpp-client/linux/2.1.0/UBUNTU/14.04/librocketmq.a 谁有相同的文件能给我一个吗?急用! 可以上 rocketmq-client-cpp

[GitHub] [rocketmq] codecov-commenter commented on pull request #4948: Fix concurrency problems in ClientActivity of proxy

2022-08-31 Thread GitBox
codecov-commenter commented on PR #4948: URL: https://github.com/apache/rocketmq/pull/4948#issuecomment-1232709313 # [Codecov](https://codecov.io/gh/apache/rocketmq/pull/4948?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)

[GitHub] [rocketmq] xdkxlk opened a new pull request, #4948: Fix concurrency problems in ClientActivity of proxy

2022-08-31 Thread GitBox
xdkxlk opened a new pull request, #4948: URL: https://github.com/apache/rocketmq/pull/4948 **Make sure set the target branch to `develop`** ## What is the purpose of the change 1. write client settings in lock to solve concurrency problems 2. optimize the process of error

[GitHub] [rocketmq] xdkxlk opened a new issue, #4947: Concurrency problem when write client settings and other data at the same time

2022-08-31 Thread GitBox
xdkxlk opened a new issue, #4947: URL: https://github.com/apache/rocketmq/issues/4947 In ClientActivity, there is a concurrency problem when write client settings and other data at the same time, which will lead to errors like this

[GitHub] [rocketmq-streams] ni-ze merged pull request #201: Resolve bug of concurrent modification

2022-08-31 Thread GitBox
ni-ze merged PR #201: URL: https://github.com/apache/rocketmq-streams/pull/201 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [rocketmq] aaron-ai closed issue #4943: test of BatchConsumeQueueTest#testBuildAndSearchBatchConsumeQueuePerformance is not stable

2022-08-31 Thread GitBox
aaron-ai closed issue #4943: test of BatchConsumeQueueTest#testBuildAndSearchBatchConsumeQueuePerformance is not stable URL: https://github.com/apache/rocketmq/issues/4943 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [rocketmq] aaron-ai merged pull request #4946: [ISSUE #4943] not to assert time cost in test case

2022-08-31 Thread GitBox
aaron-ai merged PR #4946: URL: https://github.com/apache/rocketmq/pull/4946 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [rocketmq] codecov-commenter commented on pull request #4946: [ISSUE #4943] not to assert time cost in test case

2022-08-31 Thread GitBox
codecov-commenter commented on PR #4946: URL: https://github.com/apache/rocketmq/pull/4946#issuecomment-1232630677 # [Codecov](https://codecov.io/gh/apache/rocketmq/pull/4946?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)

[GitHub] [rocketmq] aaron-ai merged pull request #4932: fix excessive nesting in MQClientInstance.java

2022-08-31 Thread GitBox
aaron-ai merged PR #4932: URL: https://github.com/apache/rocketmq/pull/4932 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [rocketmq] lizhanhui commented on pull request #4925: [ISSUE #4905] Close stale issues/PRs

2022-08-31 Thread GitBox
lizhanhui commented on PR #4925: URL: https://github.com/apache/rocketmq/pull/4925#issuecomment-1232613576 +1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [rocketmq] ShannonDing merged pull request #4944: [ISSUE #4936] Remove useless log output after the master and slave broker are started on the empty disk in controller mode

2022-08-31 Thread GitBox
ShannonDing merged PR #4944: URL: https://github.com/apache/rocketmq/pull/4944 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [rocketmq-clients] aaron-ai merged pull request #212: Add comments on RpcClient#telemetry

2022-08-31 Thread GitBox
aaron-ai merged PR #212: URL: https://github.com/apache/rocketmq-clients/pull/212 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [rocketmq] xdkxlk opened a new pull request, #4946: [ISSUE #4943] not to assert time cost in test case

2022-08-31 Thread GitBox
xdkxlk opened a new pull request, #4946: URL: https://github.com/apache/rocketmq/pull/4946 The assertion of time used is not stable in github actions -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [rocketmq] xdkxlk commented on a diff in pull request #4940: [ISSUE #4938, ISSUE #4939] fix the concurrency problems and limit the times of renew when some error occurred in ReceiptHandleProc

2022-08-31 Thread GitBox
xdkxlk commented on code in PR #4940: URL: https://github.com/apache/rocketmq/pull/4940#discussion_r959273452 ## proxy/src/test/java/org/apache/rocketmq/proxy/common/ReceiptHandleGroupTest.java: ## @@ -0,0 +1,178 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [rocketmq] codecov-commenter commented on pull request #4944: [ISSUE #4936] Remove useless log output after the master and slave broker are started on the empty disk in controller mode

2022-08-31 Thread GitBox
codecov-commenter commented on PR #4944: URL: https://github.com/apache/rocketmq/pull/4944#issuecomment-1232560527 # [Codecov](https://codecov.io/gh/apache/rocketmq/pull/4944?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)

[GitHub] [rocketmq] aaron-ai commented on a diff in pull request #4940: [ISSUE #4938, ISSUE #4939] fix the concurrency problems and limit the times of renew when some error occurred in ReceiptHandlePr

2022-08-31 Thread GitBox
aaron-ai commented on code in PR #4940: URL: https://github.com/apache/rocketmq/pull/4940#discussion_r959236200 ## proxy/src/test/java/org/apache/rocketmq/proxy/common/ReceiptHandleGroupTest.java: ## @@ -0,0 +1,178 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [rocketmq] mxsm opened a new issue, #4945: Adjust the storedir format of test cases to the Windows platform

2022-08-31 Thread GitBox
mxsm opened a new issue, #4945: URL: https://github.com/apache/rocketmq/issues/4945 ![image](https://user-images.githubusercontent.com/15797831/187615484-3d30ddae-8d5c-4e76-9f31-71a11581e185.png) As shown in the figure above, run on the windows platform baseDir is: ```

[GitHub] [rocketmq-spring] Xuchengen commented on issue #253: @RocketMQTransactionListener can definition multiple implement class?

2022-08-31 Thread GitBox
Xuchengen commented on issue #253: URL: https://github.com/apache/rocketmq-spring/issues/253#issuecomment-1232540748 看样子需要自己做一个基于`topic:tag`路由分发来解决这个问题。 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [rocketmq] RongtongJin opened a new pull request, #4944: [ISSUE #4936] Remove useless log output after the master and slave broker are started on the empty disk in controller mode

2022-08-31 Thread GitBox
RongtongJin opened a new pull request, #4944: URL: https://github.com/apache/rocketmq/pull/4944 **Make sure set the target branch to `develop`** ## What is the purpose of the change Remove useless log output after the master and slave broker are started on the empty disk in

Re:Re: [Vote] Release gRPC Java Client for Apache RocketMQ 5.0.1 RC1

2022-08-31 Thread hill
+1 At 2022-08-31 13:32:54, "Xiaorui Wang" wrote: >+1 > >yukon 于2022年8月31日 周三14:19写道: > >> +1 >> >> On Mon, Aug 29, 2022 at 10:55 AM aaron ai wrote: >> >> > Hello RocketMQ Community, >> > >> > This is the vote for 5.0.1 RC1 of Apache RocketMQ client for java. >> > >> > Apache RocketMQ clients

[GitHub] [rocketmq] xdkxlk commented on a diff in pull request #4940: [ISSUE #4938, ISSUE #4939] fix the concurrency problems and limit the times of renew when some error occurred in ReceiptHandleProc

2022-08-31 Thread GitBox
xdkxlk commented on code in PR #4940: URL: https://github.com/apache/rocketmq/pull/4940#discussion_r959215396 ## proxy/src/main/java/org/apache/rocketmq/proxy/common/MessageReceiptHandle.java: ## @@ -27,24 +29,26 @@ public class MessageReceiptHandle { private final String

[GitHub] [rocketmq-spring] Xuchengen commented on issue #414: Some questions about RocketMQLocalTransactionListener.

2022-08-31 Thread GitBox
Xuchengen commented on issue #414: URL: https://github.com/apache/rocketmq-spring/issues/414#issuecomment-1232530806 我也比较关心这个问题。 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [rocketmq] lollipopjin commented on a diff in pull request #4940: [ISSUE #4938, ISSUE #4939] fix the concurrency problems and limit the times of renew when some error occurred in ReceiptHandl

2022-08-31 Thread GitBox
lollipopjin commented on code in PR #4940: URL: https://github.com/apache/rocketmq/pull/4940#discussion_r959199154 ## proxy/src/main/java/org/apache/rocketmq/proxy/common/MessageReceiptHandle.java: ## @@ -27,24 +29,26 @@ public class MessageReceiptHandle { private final

Re: [Vote] Release gRPC Java Client for Apache RocketMQ 5.0.1 RC1

2022-08-31 Thread Xiaorui Wang
+1 yukon 于2022年8月31日 周三14:19写道: > +1 > > On Mon, Aug 29, 2022 at 10:55 AM aaron ai wrote: > > > Hello RocketMQ Community, > > > > This is the vote for 5.0.1 RC1 of Apache RocketMQ client for java. > > > > Apache RocketMQ clients 5.x series follow the specs of rocketmq-apis > >

[GitHub] [rocketmq] complone commented on issue #4933: [feature] Rocketmq producer side supports idempotency

2022-08-31 Thread GitBox
complone commented on issue #4933: URL: https://github.com/apache/rocketmq/issues/4933#issuecomment-1232517897 The real existence of this function I think I am referring to [kafka's inbox](https://www.archive.link/dig/detail/1652381596718757 ), etc. to send the rId that implements mq。 --

  1   2   >