[GitHub] [rocketmq-client-cpp] ifplusor commented on issue #232: feat(callback): use start pointer to manager callbacks

2020-01-15 Thread GitBox
ifplusor commented on issue #232: feat(callback): use start pointer to manager callbacks URL: https://github.com/apache/rocketmq-client-cpp/pull/232#issuecomment-574554174 I think smart pointer is unnecessary. This is an

[GitHub] [rocketmq-client-cpp] ifplusor edited a comment on issue #232: feat(callback): use start pointer to manager callbacks

2020-01-15 Thread GitBox
ifplusor edited a comment on issue #232: feat(callback): use start pointer to manager callbacks URL: https://github.com/apache/rocketmq-client-cpp/pull/232#issuecomment-574554174 I think smart pointer is unnecessary, and unique_ptr is better.

[GitHub] [rocketmq] Switch-vov commented on issue #1510: Some question about "vip channel"?

2020-01-15 Thread GitBox
Switch-vov commented on issue #1510: Some question about "vip channel"? URL: https://github.com/apache/rocketmq/issues/1510#issuecomment-574601243 @MountainOne thanks, the answer is very clearly. This is an automated message

[GitHub] [rocketmq-client-cpp] ifplusor edited a comment on issue #232: feat(callback): use start pointer to manager callbacks

2020-01-15 Thread GitBox
ifplusor edited a comment on issue #232: feat(callback): use start pointer to manager callbacks URL: https://github.com/apache/rocketmq-client-cpp/pull/232#issuecomment-574554174 I think use unique_ptr is better. This is an

[GitHub] [rocketmq] coveralls edited a comment on issue #1684: Producer manager channel

2020-01-15 Thread GitBox
coveralls edited a comment on issue #1684: Producer manager channel URL: https://github.com/apache/rocketmq/pull/1684#issuecomment-569213927 [![Coverage Status](https://coveralls.io/builds/28119416/badge)](https://coveralls.io/builds/28119416) Coverage decreased (-0.1%) to

[GitHub] [rocketmq] coveralls edited a comment on issue #1684: Producer manager channel

2020-01-15 Thread GitBox
coveralls edited a comment on issue #1684: Producer manager channel URL: https://github.com/apache/rocketmq/pull/1684#issuecomment-569213927 [![Coverage Status](https://coveralls.io/builds/28118281/badge)](https://coveralls.io/builds/28118281) Coverage decreased (-0.08%) to

[GitHub] [rocketmq] zongtanghu commented on issue #1726: consumer cant be started if it started after another consumer which dont have access to a topic.

2020-01-15 Thread GitBox
zongtanghu commented on issue #1726: consumer cant be started if it started after another consumer which dont have access to a topic. URL: https://github.com/apache/rocketmq/issues/1726#issuecomment-574574938 Okay, I will see this issue these days.

[GitHub] [rocketmq-spring] chwii opened a new issue #224: Is it possible to create consumer that subscribe to certain topic on the fly?

2020-01-15 Thread GitBox
chwii opened a new issue #224: Is it possible to create consumer that subscribe to certain topic on the fly? URL: https://github.com/apache/rocketmq-spring/issues/224 I was able to do so with rocketmq-client like below ```java public DefaultMQPushConsumer create(Object...args){ //

Passed: apache/rocketmq#3549 (rocketmq-all-4.6.1 - 86c98b7)

2020-01-15 Thread Travis CI
Build Update for apache/rocketmq - Build: #3549 Status: Passed Duration: 20 mins and 43 secs Commit: 86c98b7 (rocketmq-all-4.6.1) Author: rongtongjin Message: [maven-release-plugin] prepare release rocketmq-all-4.6.1 View the changeset:

[GitHub] [rocketmq-spring] vongosling closed issue #211: A template can only bind one group at present. How to implement multiple instances of rocketmq template?

2020-01-15 Thread GitBox
vongosling closed issue #211: A template can only bind one group at present. How to implement multiple instances of rocketmq template? URL: https://github.com/apache/rocketmq-spring/issues/211 This is an automated message

[GitHub] [rocketmq-spring] vongosling merged pull request #212: [ISSUE #211] Remove the limitation that ExtRocketMQTemplate can not keep the same nameserver as RocketMQTemplate

2020-01-15 Thread GitBox
vongosling merged pull request #212: [ISSUE #211] Remove the limitation that ExtRocketMQTemplate can not keep the same nameserver as RocketMQTemplate URL: https://github.com/apache/rocketmq-spring/pull/212 This is an

[DISCUSS]Release Apache RocketMQ 4.6.1

2020-01-15 Thread 金融通
Hello RocketMQ Community, Apache RocketMQ team is about to release Apache RocketMQ 4.6.1 and we will stop merge PR. If your PR has not been merged and needs further attention, please reply to this email and we will review it as soon as possible. Best Regards, Apache RocketMQ Team.

[GitHub] [rocketmq] coveralls edited a comment on issue #1684: Producer manager channel

2020-01-15 Thread GitBox
coveralls edited a comment on issue #1684: Producer manager channel URL: https://github.com/apache/rocketmq/pull/1684#issuecomment-569213927 [![Coverage Status](https://coveralls.io/builds/28122135/badge)](https://coveralls.io/builds/28122135) Coverage increased (+0.03%) to

[GitHub] [rocketmq-spring] vongosling edited a comment on issue #210: [ISSUE #218] Fix spring scopeTarget will repeat consumer instance

2020-01-15 Thread GitBox
vongosling edited a comment on issue #210: [ISSUE #218] Fix spring scopeTarget will repeat consumer instance URL: https://github.com/apache/rocketmq-spring/pull/210#issuecomment-574647774 @snicoll Could you help to review this pr:-) refresh could result in the two instances of the

Contributing to RocketMQ

2020-01-15 Thread Axay Sagathiya
Hi, I am a newcomer(3rd year of undergrad) in the software world and I want to start contributing to the open-source. I have chosen rocketMQ as my first open-source. Can you guide me a bit on how to start with this project? Where can I start in the code? Important files and concepts etc.

[GitHub] [rocketmq-spring] vongosling merged pull request #209: [ISSUE #208]support request/reply model in rocketmq-spring

2020-01-15 Thread GitBox
vongosling merged pull request #209: [ISSUE #208]support request/reply model in rocketmq-spring URL: https://github.com/apache/rocketmq-spring/pull/209 This is an automated message from the Apache Git Service. To respond to

[GitHub] [rocketmq-spring] RongtongJin commented on issue #171: [ISSUE #8] Offer a more user-friendly format to configure nameserver

2020-01-15 Thread GitBox
RongtongJin commented on issue #171: [ISSUE #8] Offer a more user-friendly format to configure nameserver URL: https://github.com/apache/rocketmq-spring/pull/171#issuecomment-574673513 @snicoll, I apologize for not replying you sooner, I missed your message since I closed this pull

[GitHub] [rocketmq-spring] RongtongJin opened a new pull request #171: [ISSUE #8] Offer a more user-friendly format to configure nameserver

2020-01-15 Thread GitBox
RongtongJin opened a new pull request #171: [ISSUE #8] Offer a more user-friendly format to configure nameserver URL: https://github.com/apache/rocketmq-spring/pull/171 ## What is the purpose of the change User can config name-server with format `host:port,host:port` or other list

[GitHub] [rocketmq-spring] snicoll commented on issue #210: [ISSUE #218] Fix spring scopeTarget will repeat consumer instance

2020-01-15 Thread GitBox
snicoll commented on issue #210: [ISSUE #218] Fix spring scopeTarget will repeat consumer instance URL: https://github.com/apache/rocketmq-spring/pull/210#issuecomment-574648868 Can do when time permits. I'd appreciate an answer here:

[GitHub] [rocketmq] atris commented on issue #1362: Throws ClientErrorCode.CONNECT_BROKER_EXCEPTION in MQClientException when send max times still failed which in DefaultMQProducerImpl.java

2020-01-15 Thread GitBox
atris commented on issue #1362: Throws ClientErrorCode.CONNECT_BROKER_EXCEPTION in MQClientException when send max times still failed which in DefaultMQProducerImpl.java URL: https://github.com/apache/rocketmq/issues/1362#issuecomment-574733504 I would like to work on this -- can I be

[GitHub] [rocketmq-spring] vongosling edited a comment on issue #210: [ISSUE #218] Fix spring scopeTarget will repeat consumer instance

2020-01-15 Thread GitBox
vongosling edited a comment on issue #210: [ISSUE #218] Fix spring scopeTarget will repeat consumer instance URL: https://github.com/apache/rocketmq-spring/pull/210#issuecomment-574647774 @snicoll Could you help to review this pr:-) refresh could result in the two instances of the

Re: Contributing to RocketMQ

2020-01-15 Thread heng du
Hi, Axay, Thanks for your attention, it would be nice if you can start with this doc: https://rocketmq.apache.org/docs/how-to-contribute/. and rocketmq related docs can be found in here: https://github.com/apache/rocketmq/tree/master/docs/en In my opinion, getting familiar with the project you

[GitHub] [rocketmq-spring] vongosling commented on issue #210: [ISSUE #218] Fix spring scopeTarget will repeat consumer instance

2020-01-15 Thread GitBox
vongosling commented on issue #210: [ISSUE #218] Fix spring scopeTarget will repeat consumer instance URL: https://github.com/apache/rocketmq-spring/pull/210#issuecomment-574647774 @snicoll Could you have to review this pr. refresh could result in the two instances of the **Container

[GitHub] [rocketmq-spring] vongosling edited a comment on issue #210: [ISSUE #218] Fix spring scopeTarget will repeat consumer instance

2020-01-15 Thread GitBox
vongosling edited a comment on issue #210: [ISSUE #218] Fix spring scopeTarget will repeat consumer instance URL: https://github.com/apache/rocketmq-spring/pull/210#issuecomment-574647774 @snicoll Could you help to review this pr:-) refresh could result in the two instances of the

[GitHub] [rocketmq-client-cpp] ShannonDing merged pull request #233: feat(consumer): remove event if consumer service shutdown

2020-01-15 Thread GitBox
ShannonDing merged pull request #233: feat(consumer): remove event if consumer service shutdown URL: https://github.com/apache/rocketmq-client-cpp/pull/233 This is an automated message from the Apache Git Service. To

Passed: apache/rocketmq#3555 (develop - 68f050c)

2020-01-15 Thread Travis CI
Build Update for apache/rocketmq - Build: #3555 Status: Passed Duration: 21 mins and 50 secs Commit: 68f050c (develop) Author: rongtongjin Message: feat(release):update version to release 4.6.1 View the changeset:

[GitHub] [rocketmq] atris commented on issue #1362: Throws ClientErrorCode.CONNECT_BROKER_EXCEPTION in MQClientException when send max times still failed which in DefaultMQProducerImpl.java

2020-01-15 Thread GitBox
atris commented on issue #1362: Throws ClientErrorCode.CONNECT_BROKER_EXCEPTION in MQClientException when send max times still failed which in DefaultMQProducerImpl.java URL: https://github.com/apache/rocketmq/issues/1362#issuecomment-574959366 Ah, I did not realise @HymanShi is working

[GitHub] [rocketmq] HymanShi commented on issue #1362: Throws ClientErrorCode.CONNECT_BROKER_EXCEPTION in MQClientException when send max times still failed which in DefaultMQProducerImpl.java

2020-01-15 Thread GitBox
HymanShi commented on issue #1362: Throws ClientErrorCode.CONNECT_BROKER_EXCEPTION in MQClientException when send max times still failed which in DefaultMQProducerImpl.java URL: https://github.com/apache/rocketmq/issues/1362#issuecomment-574960776 @duhenglucky Thanks for your invitation

Passed: apache/rocketmq#3559 (release-4.6.1 - 1716911)

2020-01-15 Thread Travis CI
Build Update for apache/rocketmq - Build: #3559 Status: Passed Duration: 21 mins and 27 secs Commit: 1716911 (release-4.6.1) Author: rongtongjin Message: [maven-release-plugin] prepare release rocketmq-all-4.6.1 View the changeset:

[GitHub] [rocketmq-client-cpp] ShannonDing opened a new pull request #233: feat(consumer): remove event if consumer service shutdown

2020-01-15 Thread GitBox
ShannonDing opened a new pull request #233: feat(consumer): remove event if consumer service shutdown URL: https://github.com/apache/rocketmq-client-cpp/pull/233 ## What is the purpose of the change feat(consumer): remove event if consumer service shutdown

[GitHub] [rocketmq-client-cpp] codecov-io commented on issue #233: feat(consumer): remove event if consumer service shutdown

2020-01-15 Thread GitBox
codecov-io commented on issue #233: feat(consumer): remove event if consumer service shutdown URL: https://github.com/apache/rocketmq-client-cpp/pull/233#issuecomment-574994121 # [Codecov](https://codecov.io/gh/apache/rocketmq-client-cpp/pull/233?src=pr=h1) Report > Merging

[GitHub] [rocketmq-spring] vongosling commented on issue #210: [ISSUE #218] Fix spring scopeTarget will repeat consumer instance

2020-01-15 Thread GitBox
vongosling commented on issue #210: [ISSUE #218] Fix spring scopeTarget will repeat consumer instance URL: https://github.com/apache/rocketmq-spring/pull/210#issuecomment-574998826 @snicoll Thank you in advance, we hope this feature can be released in version 2.1.0 in the latest week, I

[GitHub] [rocketmq] zongtanghu commented on issue #1726: consumer cant be started if it started after another consumer which dont have access to a topic.

2020-01-15 Thread GitBox
zongtanghu commented on issue #1726: consumer cant be started if it started after another consumer which dont have access to a topic. URL: https://github.com/apache/rocketmq/issues/1726#issuecomment-574934511 @zhangjidi2016

Passed: apache/rocketmq#3554 (develop - c21db66)

2020-01-15 Thread Travis CI
Build Update for apache/rocketmq - Build: #3554 Status: Passed Duration: 23 mins and 22 secs Commit: c21db66 (develop) Author: rongtongjin Message: [maven-release-plugin] prepare release rocketmq-all-4.6.1 View the changeset:

[GitHub] [rocketmq] duhenglucky commented on issue #1362: Throws ClientErrorCode.CONNECT_BROKER_EXCEPTION in MQClientException when send max times still failed which in DefaultMQProducerImpl.java

2020-01-15 Thread GitBox
duhenglucky commented on issue #1362: Throws ClientErrorCode.CONNECT_BROKER_EXCEPTION in MQClientException when send max times still failed which in DefaultMQProducerImpl.java URL: https://github.com/apache/rocketmq/issues/1362#issuecomment-574942214 @atris thanks for your attention and

[GitHub] [rocketmq] duhenglucky commented on issue #1362: Throws ClientErrorCode.CONNECT_BROKER_EXCEPTION in MQClientException when send max times still failed which in DefaultMQProducerImpl.java

2020-01-15 Thread GitBox
duhenglucky commented on issue #1362: Throws ClientErrorCode.CONNECT_BROKER_EXCEPTION in MQClientException when send max times still failed which in DefaultMQProducerImpl.java URL: https://github.com/apache/rocketmq/issues/1362#issuecomment-574943601 @HymanShi Because there are many