Re: [VOTE] Graduate Apache RocketMQ from podling to TLP

2017-08-15 Thread vintagewang
+1 I believe Apache RocketMQ will be a very good messaging middleware, in the big data field, streaming computing, and reliable messaging On Wed, Aug 16, 2017 at 9:48 AM, Von Gosling wrote: > Hi, > > Following the discussion in Apache RocketMQ PPMC on graduating Apache >

[GitHub] incubator-rocketmq pull request #147: [ROCKETMQ-266] Add a specific Exceptio...

2017-08-15 Thread Jaskey
Github user Jaskey commented on a diff in the pull request: https://github.com/apache/incubator-rocketmq/pull/147#discussion_r133349431 --- Diff: client/src/test/java/org/apache/rocketmq/client/impl/consumer/DefaultMQPushConsumerImplTest.java --- @@ -0,0 +1,48 @@ +/* + *

[GitHub] incubator-rocketmq pull request #145: [ROCKETMQ-264]Fix unit test cost too l...

2017-08-15 Thread lindzh
Github user lindzh commented on a diff in the pull request: https://github.com/apache/incubator-rocketmq/pull/145#discussion_r133344416 --- Diff: broker/src/test/java/org/apache/rocketmq/broker/filter/MessageStoreWithFilterTest.java --- @@ -76,6 +86,24 @@ }

[VOTE] Graduate Apache RocketMQ from podling to TLP

2017-08-15 Thread Von Gosling
Hi, Following the discussion in Apache RocketMQ PPMC on graduating Apache RocketMQ from incubation to a Top Level Project, starting this voting thread within the RocketMQ community. Apache RocketMQ entered into incubation during Nov. 2016. Since then, we announced two incubating

[GitHub] incubator-rocketmq-externals pull request #19: [DISCUSS]Go-Client:Detail Des...

2017-08-15 Thread StyleTang
Github user StyleTang closed the pull request at: https://github.com/apache/incubator-rocketmq-externals/pull/19 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

[GitHub] incubator-rocketmq issue #147: [ROCKETMQ-266] Add a specific Exception messa...

2017-08-15 Thread mark800
Github user mark800 commented on the issue: https://github.com/apache/incubator-rocketmq/pull/147 @lindzh My opinion is:consumeThreadMax and consumeThreadMin are two separate configuration, if we only configure one parameter, it should work, or at least give a reasonable

[GitHub] incubator-rocketmq pull request #145: [ROCKETMQ-264]Fix unit test cost too l...

2017-08-15 Thread vongosling
Github user vongosling commented on a diff in the pull request: https://github.com/apache/incubator-rocketmq/pull/145#discussion_r133153891 --- Diff: broker/src/test/java/org/apache/rocketmq/broker/filter/MessageStoreWithFilterTest.java --- @@ -76,6 +86,24 @@ }

[GitHub] incubator-rocketmq issue #147: [ROCKETMQ-266] Add a specific Exception messa...

2017-08-15 Thread lindzh
Github user lindzh commented on the issue: https://github.com/apache/incubator-rocketmq/pull/147 While consumeThreadMin is specified by a range,why not add consumeThreadMax to a range too? --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] incubator-rocketmq-externals issue #23: [ROCKETMQ-193] init subproject: rock...

2017-08-15 Thread vongosling
Github user vongosling commented on the issue: https://github.com/apache/incubator-rocketmq-externals/pull/23 @Zhang-Ke Could you remove author info and follow our codestyle, such as add license. if have any question, please let me know :-) --- If your project is set up for it, you

[GitHub] incubator-rocketmq issue #134: [ROCKETMQ-44] Duplicated Codes in DefaultMess...

2017-08-15 Thread vongosling
Github user vongosling commented on the issue: https://github.com/apache/incubator-rocketmq/pull/134 @Ritabrata-TW Thanks for your attention for rocketmq community, whats' your scenario when using apache rocketmq in your company :-) --- If your project is set up for it, you can

[GitHub] incubator-rocketmq issue #147: Add a specific Exception message for comparin...

2017-08-15 Thread mark800
Github user mark800 commented on the issue: https://github.com/apache/incubator-rocketmq/pull/147 @vsair Thanks for your advice! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] incubator-rocketmq issue #147: Can’t start consumer with a small consumerT...

2017-08-15 Thread coveralls
Github user coveralls commented on the issue: https://github.com/apache/incubator-rocketmq/pull/147 [![Coverage Status](https://coveralls.io/builds/12836052/badge)](https://coveralls.io/builds/12836052) Coverage increased (+0.003%) to 38.785% when pulling

[GitHub] incubator-rocketmq issue #147: Can’t start consumer with a small consumerT...

2017-08-15 Thread coveralls
Github user coveralls commented on the issue: https://github.com/apache/incubator-rocketmq/pull/147 [![Coverage Status](https://coveralls.io/builds/12836052/badge)](https://coveralls.io/builds/12836052) Coverage increased (+0.003%) to 38.785% when pulling

[GitHub] incubator-rocketmq issue #147: Can’t start consumer with a small consumerT...

2017-08-15 Thread coveralls
Github user coveralls commented on the issue: https://github.com/apache/incubator-rocketmq/pull/147 [![Coverage Status](https://coveralls.io/builds/12836052/badge)](https://coveralls.io/builds/12836052) Coverage increased (+0.003%) to 38.785% when pulling

[GitHub] incubator-rocketmq-externals issue #27: [ROCKETMQ-268]add rocketmq-cpp code

2017-08-15 Thread lizhanhui
Github user lizhanhui commented on the issue: https://github.com/apache/incubator-rocketmq-externals/pull/27 Yes, I see your update...Thanks for you contribution. CMake, IMO, is very good to have! One more thing, I think we can assume dependent libraries are all installed