[GitHub] incubator-rocketmq pull request #133: [ROCKETMQ-249] Do not attempt to clear...

2017-09-22 Thread shroman
Github user shroman commented on a diff in the pull request: https://github.com/apache/incubator-rocketmq/pull/133#discussion_r140425575 --- Diff: store/src/main/java/org/apache/rocketmq/store/DefaultMessageStore.java --- @@ -1509,65 +1514,62 @@ private boolean isTimeToDelete() {

[GitHub] incubator-rocketmq pull request #133: [ROCKETMQ-249] Do not attempt to clear...

2017-09-21 Thread dongeforever
Github user dongeforever commented on a diff in the pull request: https://github.com/apache/incubator-rocketmq/pull/133#discussion_r140402297 --- Diff: store/src/test/java/org/apache/rocketmq/store/CleanCommitLogServiceTest.java --- @@ -0,0 +1,115 @@ +/* + * Licensed to

[GitHub] incubator-rocketmq pull request #133: [ROCKETMQ-249] Do not attempt to clear...

2017-08-13 Thread solosky
Github user solosky commented on a diff in the pull request: https://github.com/apache/incubator-rocketmq/pull/133#discussion_r132864458 --- Diff: common/src/main/java/org/apache/rocketmq/common/UtilAll.java --- @@ -184,15 +184,27 @@ public static String