Github user shroman commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/133#discussion_r140425575
--- Diff:
store/src/main/java/org/apache/rocketmq/store/DefaultMessageStore.java ---
@@ -1509,65 +1514,62 @@ private boolean isTimeToDelete() {
Github user dongeforever commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/133#discussion_r140402297
--- Diff:
store/src/test/java/org/apache/rocketmq/store/CleanCommitLogServiceTest.java ---
@@ -0,0 +1,115 @@
+/*
+ * Licensed to
Github user solosky commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/133#discussion_r132864458
--- Diff: common/src/main/java/org/apache/rocketmq/common/UtilAll.java ---
@@ -184,15 +184,27 @@ public static String