[GitHub] incubator-rocketmq pull request #144: [ROCKETMQ-257] name server address and...

2017-08-22 Thread qqeasonchen
Github user qqeasonchen closed the pull request at: https://github.com/apache/incubator-rocketmq/pull/144 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if th

[GitHub] incubator-rocketmq pull request #144: [ROCKETMQ-257] name server address and...

2017-08-11 Thread shroman
Github user shroman commented on a diff in the pull request: https://github.com/apache/incubator-rocketmq/pull/144#discussion_r132808594 --- Diff: common/src/main/java/org/apache/rocketmq/common/MixAll.java --- @@ -59,7 +59,7 @@ public static final String WS_DOMAIN_NAME =

[GitHub] incubator-rocketmq pull request #144: [ROCKETMQ-257] name server address and...

2017-08-10 Thread qqeasonchen
Github user qqeasonchen commented on a diff in the pull request: https://github.com/apache/incubator-rocketmq/pull/144#discussion_r132623736 --- Diff: client/src/main/java/org/apache/rocketmq/client/impl/factory/MQClientInstance.java --- @@ -225,10 +225,13 @@ public void start() t

[GitHub] incubator-rocketmq pull request #144: [ROCKETMQ-257] name server address and...

2017-08-10 Thread lindzh
Github user lindzh commented on a diff in the pull request: https://github.com/apache/incubator-rocketmq/pull/144#discussion_r132393089 --- Diff: client/src/main/java/org/apache/rocketmq/client/impl/factory/MQClientInstance.java --- @@ -225,10 +225,13 @@ public void start() throws

[GitHub] incubator-rocketmq pull request #144: [ROCKETMQ-257] name server address and...

2017-08-09 Thread qqeasonchen
GitHub user qqeasonchen opened a pull request: https://github.com/apache/incubator-rocketmq/pull/144 [ROCKETMQ-257] name server address and web server address should be s… …pecified at least one You can merge this pull request into a Git repository by running: $ git pull ht