Github user shroman commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/69
@vongosling I meant "If I were you, I would ..." :) Anyway, I don't see why
this pr can be merged if a unit test can be easily written. I think we have to
accept PRs with tests, except
Github user vongosling commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/69
thanks @yilingfeng . Consider this PR has been merged, we will commit your
unit-test in another commit. @shroman I have a same understand as @zhouxinyu
about your unit-test said :-)
Github user yilingfeng commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/69
Ok,I've added a unit test. @lizhanhui @shroman
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
GitHub user shroman opened a pull request:
https://github.com/apache/incubator-rocketmq-site/pull/8
Added having unit tests as a necessary condition for PR (when applicaâ¦
â¦ble).
You can merge this pull request into a Git repository by running:
$ git pull
@Rick Zhang
That's a good suggestion!
The feature is useful.
We plan to add monitor(alert) in milestone 2.
(In fact,milestone 1 already has some code for this feature,but we don't
have enough time to develop it,see
org.apache.rocketmq.console.service.MonitorService)
We can discuss what we want
Github user shroman commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/69
@zhouxinyu Probably you misunderstood what I meant :) -- this PR needs unit
tests. I think it's the responsibility of the person who submitted PR to create
them, whenever possible, since
Hi RocketMQ Team,
Now in RocketMQ, there is only a simple watermark, which print runtime
messages to a log file. In production, a more powerful monitor/alarm
functionality is necessary. For instance, if messages are accumulated in a
queue, we should know the first time. Sometimes the
Hi,
> Thank you for the feedback, this is why I post calls to contribute to the
> reports to the dev@ list. Unfortunately, this report has already been
> submitted.
It can still be edited here [1]. When that says final it can’t be.
Thanks,
Justin
1. https://wiki.apache.org/incubator/March2017
