Github user Jaskey commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/85#discussion_r111524822
--- Diff:
common/src/main/java/org/apache/rocketmq/common/utils/LogUtils.java ---
@@ -0,0 +1,96 @@
+/*
+ * Licensed to the Apache Software
Github user lizhanhui commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/91#discussion_r111524663
--- Diff:
client/src/main/java/org/apache/rocketmq/client/producer/LocalTransactionExecutor.java
---
@@ -18,6 +18,6 @@
import
Hi,
If the goal is to move the project more quickly, adding
maintainers will only hinder the progress not help move faster as
it's another layer of getting a patch committed. Since RocketMQ is
still in the incubation stage, IMO too soon to introduce
maintainers. Once
Github user Jaskey commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/91#discussion_r111524324
--- Diff:
client/src/main/java/org/apache/rocketmq/client/producer/LocalTransactionExecutor.java
---
@@ -18,6 +18,6 @@
import
Github user lizhanhui commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/91#discussion_r111522507
--- Diff:
client/src/main/java/org/apache/rocketmq/client/producer/LocalTransactionExecutor.java
---
@@ -18,6 +18,6 @@
import
Github user Jaskey commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/91#discussion_r111211864
--- Diff:
client/src/main/java/org/apache/rocketmq/client/producer/LocalTransactionExecutor.java
---
@@ -18,6 +18,6 @@
import
Github user Jaskey commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/91#discussion_r111211195
--- Diff:
client/src/main/java/org/apache/rocketmq/client/consumer/listener/ConsumeReturnType.java
---
@@ -33,7 +33,7 @@
/**
*
Github user coveralls commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/91
[](https://coveralls.io/builds/11083278)
Coverage increased (+0.0007%) to 34.626% when pulling
Github user coveralls commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/91
[](https://coveralls.io/builds/11083278)
Coverage increased (+0.0007%) to 34.626% when pulling
Github user lizhanhui commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/82
Will look into this PR today.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Hi Bruce,
> Is the RocketMQ code base currently divided up with certain people
working only in certain areas?
Not only, but most of committers have their focus areas.
We don't want to divide the code base totally for certain people, IMO,
global collaboration with a certain focus may be a better
Dear Podling,
As you may be aware, the Incubator has recently selected a new logo. In
conjunction with this new logo, Sally has prepared material to help podlings
incorporate incubator branding into their logos.
Please review the Press Kit for Podlings page at
Hi yukon,
I haven't heard of this concept at the ASF before, so I guess it's
something that only a few projects are using. It seems kinda heavy-handed,
but maybe this is just my perspective in not having worked on the RocketMQ
code base. Is the RocketMQ code base currently divided up with certain
+1
I remembered storm pmc member xinwang has raised the similar problem. IMO, we
can learn from Apache other project’s best practice. Maintainer’s introduction
is a good choise for RocketMQ's Issue, codebase and other community affairs.
Consider this is a good start, We could polish this
Github user zhouxinyu commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/91
The JIRA issue is here: https://issues.apache.org/jira/browse/ROCKETMQ-174
And I have added a time tracker for this issue.
---
If your project is set up for it, you can reply to
Github user vesense commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/87
LGTM +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so,
Github user lizhanhui commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/91#discussion_r111319070
--- Diff: CONTRIBUTING.md ---
@@ -11,7 +11,7 @@ To submit a change for inclusion, please do the following:
If the change is
Github user vesense commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/90
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
Github user vesense commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/91
Overall looks good to me. Nice job!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user vesense commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/91#discussion_r111317677
--- Diff: CONTRIBUTING.md ---
@@ -11,7 +11,7 @@ To submit a change for inclusion, please do the following:
If the change is
Github user vongosling commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/77
Sorry to response for this PR. It seems good ~
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user vongosling commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/87
@shroman @lizhanhui Could you help us to review this long-time delayed PR
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
22 matches
Mail list logo
