[GitHub] incubator-rocketmq pull request #53: [ROCKETMQ-80] Add batch feature

2017-03-05 Thread dongeforever
Github user dongeforever commented on a diff in the pull request: https://github.com/apache/incubator-rocketmq/pull/53#discussion_r104348323 --- Diff: store/src/main/java/org/apache/rocketmq/store/ConsumeQueue.java --- @@ -331,7 +331,7 @@ public long getMinOffsetInQueue() {

[GitHub] incubator-rocketmq pull request #53: [ROCKETMQ-80] Add batch feature

2017-02-20 Thread vongosling
Github user vongosling commented on a diff in the pull request: https://github.com/apache/incubator-rocketmq/pull/53#discussion_r101991874 --- Diff: client/src/main/java/org/apache/rocketmq/client/impl/MQClientAPIImpl.java --- @@ -278,14 +280,14 @@ public void createTopic(final

[GitHub] incubator-rocketmq pull request #53: [ROCKETMQ-80] Add batch feature

2017-02-20 Thread vongosling
Github user vongosling commented on a diff in the pull request: https://github.com/apache/incubator-rocketmq/pull/53#discussion_r101995717 --- Diff: store/src/main/java/org/apache/rocketmq/store/AppendMessageResult.java --- @@ -119,6 +129,7 @@ public String toString() {

[GitHub] incubator-rocketmq pull request #53: [ROCKETMQ-80] Add batch feature

2017-02-20 Thread vongosling
Github user vongosling commented on a diff in the pull request: https://github.com/apache/incubator-rocketmq/pull/53#discussion_r101989915 --- Diff: broker/src/main/java/org/apache/rocketmq/broker/processor/SendMessageProcessor.java --- @@ -442,6 +449,202 @@ private

[GitHub] incubator-rocketmq pull request #53: [ROCKETMQ-80] Add batch feature

2017-02-20 Thread vongosling
Github user vongosling commented on a diff in the pull request: https://github.com/apache/incubator-rocketmq/pull/53#discussion_r101994094 --- Diff: common/src/main/java/org/apache/rocketmq/common/message/MessageBatch.java --- @@ -0,0 +1,77 @@ +/* + * Licensed to the

[GitHub] incubator-rocketmq pull request #53: [ROCKETMQ-80] Add batch feature

2017-02-20 Thread vongosling
Github user vongosling commented on a diff in the pull request: https://github.com/apache/incubator-rocketmq/pull/53#discussion_r101992848 --- Diff: client/src/main/java/org/apache/rocketmq/client/impl/producer/DefaultMQProducerImpl.java --- @@ -595,8 +596,11 @@ private

[GitHub] incubator-rocketmq pull request #53: [ROCKETMQ-80] Add batch feature

2017-02-20 Thread vongosling
Github user vongosling commented on a diff in the pull request: https://github.com/apache/incubator-rocketmq/pull/53#discussion_r101993057 --- Diff: client/src/main/java/org/apache/rocketmq/client/impl/producer/DefaultMQProducerImpl.java --- @@ -737,6 +742,10 @@ public

[GitHub] incubator-rocketmq pull request #53: [ROCKETMQ-80] Add batch feature

2017-02-20 Thread vongosling
Github user vongosling commented on a diff in the pull request: https://github.com/apache/incubator-rocketmq/pull/53#discussion_r101990343 --- Diff: broker/src/main/java/org/apache/rocketmq/broker/processor/SendMessageProcessor.java --- @@ -442,6 +449,202 @@ private

[GitHub] incubator-rocketmq pull request #53: [ROCKETMQ-80] Add batch feature

2017-02-20 Thread vongosling
Github user vongosling commented on a diff in the pull request: https://github.com/apache/incubator-rocketmq/pull/53#discussion_r101965587 --- Diff: broker/src/main/java/org/apache/rocketmq/broker/processor/SendMessageProcessor.java --- @@ -72,7 +73,13 @@ public RemotingCommand