Re: Github comments

2017-12-12 Thread Piotr Zarzycki
Hi Harbs, Maybe comments are mergin additionally. If you merge couple of revision into one pull request and those revision had something to do with the request. Just blind shot. Thanks, Piotr 2017-12-13 8:42 GMT+01:00 Harbs : > Does anyone know what’s going on with

Github comments

2017-12-12 Thread Harbs
Does anyone know what’s going on with Github comments?[1] We have a ton of comments which appear to have nothing to do with the the PR. [1]https://github.com/apache/royale-asjs/pull/96

Re: [Royale] DynamicItemsRendererFactoryForArrayListData

2017-12-12 Thread Piotr Zarzycki
If yes I will simply create bead which take care of scenario where we are removing all items from the ArrayList. Thanks, Piotr 2017-12-12 23:25 GMT+01:00 Piotr Zarzycki : > Peter, > > I did fix all issues in MDL Table and playing with your >

Re: [Royale] DynamicItemsRendererFactoryForArrayListData

2017-12-12 Thread Piotr Zarzycki
Peter, I did fix all issues in MDL Table and playing with your DynamicRemoveItemRendererForArrayListData. If I do on ArrayList.removeAll - I'm getting ITEM_REMOVED, but one time. From the user perspective I don't know actually what has happened. How to proceed if I'm using your bead in that case

Re: Slider Component

2017-12-12 Thread Justin Mclean
HI, A while back I raised several issues with the slider component, if you happen if fix any of these issues please close them. [1][2][3][4][5] I note for instance the slider still incorrectly gives the value NaN when you click on the track. The issue arises in this line in the

Re: Slider Component

2017-12-12 Thread Peter Ent
If you set the slider's width and height explicitly, the layout should work fine. Found two issues: The SliderMouseController is oriented toward a horizontal slider. I will create a HorizontalSliderMouseController and a VerticalSLiderMouseController. Second, on the HTML/JS side, the slider

Re: NPM for Royale (was Re: Repos and Releases)

2017-12-12 Thread Alex Harui
OK, we can stick with two standalone packages. FWIW, the CI build finished and I successfully ran: sudo npm install -g http://apacheflexbuild.cloudapp.net:8080/job/royale-asjs/lastSuccessfulBuil d/artifact/out/apache-royale-jsonly-0.9.0-bin.tar.gz The npm progress bar did not show anything at

Re: Repos and Releases

2017-12-12 Thread Alex Harui
Actually, it was: cd royale-asjs/ide/flashbuilder ant -f antscripts.xml setup I have updated the wiki to reflect this. I was able to import the jsonly SDK and create a new project that compiled without errors. I'll be looking into the code-assist issue next. -Alex On 12/12/17, 9:24 AM,

Re: NPM for Royale (was Re: Repos and Releases)

2017-12-12 Thread Alex Harui
FWIW, we also have the option of making the SWF support more of an "add-on" instead of its own package. IOW, right now both packages contain mostly the same files and the SWF support is additional files and some slightly different settings. An add-on package would just contain the additional

Re: NPM for Royale (was Re: Repos and Releases)

2017-12-12 Thread OmPrakash Muppirala
I think it would be good if we do: apache-royale-x.x.x and apache-royale-with-swf-x.x.x. That makes it much clearer. Thanks, Om On Tue, Dec 12, 2017 at 11:04 AM, Alex Harui wrote: > OK, I think I got the packaging fixed. The CI server is building it and > should

Re: NPM for Royale (was Re: Repos and Releases)

2017-12-12 Thread Alex Harui
OK, I think I got the packaging fixed. The CI server is building it and should finish in 90 minutes or so. You can try it out locally if you want by syncing up and running "ant release" and pointing NPM at the tar.gz file in the out folder. I think you need to "npm uninstall flexjs" first. I

Re: Repos and Releases

2017-12-12 Thread Alex Harui
Hi Carlos, Please look at the README files and past discussions. There are 4 steps for Maven for this release and hopefully only 3 after that. Due to the way our code uses Jburg we must generate a plugin for Jburg, but Maven will not let you create build plugins as part of your build. So we

Re: Repos and Releases

2017-12-12 Thread Carlos Rovira
Hi Piotr, thanks. that worked and finaly I was able to compile all repos. But this makes me feel not completly happy, since before we didn't need to do that. So we have change from 3 "steps" or command line instrucciones to 5. Is this normal? temporal? why we need to do this now and before we

[Royale] TreeGrid

2017-12-12 Thread Peter Ent
Hi, I've pushed a new component for the Basic package: TreeGrid. This component is a hybrid of Tree and DataGrid. TreeGrid uses a Hierarchical data provider and displays a Tree in the first column; the other columns display additional fields from the records. You can use TreeGrid like this:

Re: Slider Component

2017-12-12 Thread Carlos Rovira
Thanks Peter, This is one of the components I want to stylize, so if you upgrade it, I could as well work on the visuals ( and use it for the demo controls too) Carlos 2017-12-12 16:35 GMT+01:00 Peter Ent : > I just saw this email. I'll be happy to look at it. I think

Re: NPM for Royale (was Re: Repos and Releases)

2017-12-12 Thread Alex Harui
The package on the CI server aren't working with NPM. I think I messed up the Ant script. Looking into it now. -Alex On 12/12/17, 10:10 AM, "omup...@gmail.com on behalf of OmPrakash Muppirala" wrote: >On Dec 12, 2017 8:41 AM, "Alex Harui"

Re: NPM for Royale (was Re: Repos and Releases)

2017-12-12 Thread OmPrakash Muppirala
On Dec 12, 2017 8:41 AM, "Alex Harui" wrote: On 12/12/17, 3:51 AM, "omup...@gmail.com on behalf of OmPrakash Muppirala" wrote: >On Dec 12, 2017 12:25 AM, "Alex Harui" wrote: > >I just

Re: Repos and Releases

2017-12-12 Thread Alex Harui
On 12/12/17, 7:20 AM, "Yishay Weiss" wrote: >Ok, I guess I was missing some context. Piotr’s upthread [1] link made it >clear to me what the topic was about… > >So yes, royale-asjs siblings are recognized and it builds fine with ant >all. > >I tried following the wiki for

Re: Repos and Releases

2017-12-12 Thread Alex Harui
Hi, Also keep in mind that I think I have updated the README in the various repos and packages. So it would be great if you would take the time to read the build instructions in the README and see if they work or need improvement. Thanks, -Alex On 12/12/17, 3:28 AM, "Piotr Zarzycki"

Re: Slider Component

2017-12-12 Thread Peter Ent
I just saw this email. I'll be happy to look at it. I think it was made early in FlexJS. I imagine it could be crude. I'm also sure it is horizontal. I'll keep vertical in mind - maybe it needs different layouts to handle that. ‹peter On 12/12/17, 5:00 AM, "carlos.rov...@gmail.com on behalf of

Re: NPM for Royale (was Re: Repos and Releases)

2017-12-12 Thread OmPrakash Muppirala
On Dec 12, 2017 12:25 AM, "Alex Harui" wrote: I did some reading about NPM this evening. I think that we can use NPM as a distribution server. It looked like in FlexJS, we still pulled all of the artifacts from the mirrors, but I don't think that is a requirement.

Re: Repos and Releases

2017-12-12 Thread Piotr Zarzycki
Carlos, I just pulled all changes in three repositories and build compiler. Everything went fine. Try to rebuild those project which I have mention. Thanks, Piotr 2017-12-12 11:10 GMT+01:00 Carlos Rovira : > Hi Piotr, > > I think that artifacts are already in my .m2

Re: Repos and Releases

2017-12-12 Thread Carlos Rovira
Hi Piotr, I think that artifacts are already in my .m2 repo, I didn't delete it Or at least I never had to do that (if it's not the first build), do you think right now it's needed due to changes in packaging ? Also, I assume I'm on right brach ("develop") So, If nothing has change for maven I

Re: Repos and Releases

2017-12-12 Thread Piotr Zarzycki
Hi Carlos, Try to build first following projects: compiler-jburg-types and compiler-build-tools. For Maven there were no crucial changes, everything working as it was. Let me know if it's helped. Thanks, Piotr 2017-12-12 10:50 GMT+01:00 Carlos Rovira : > Hi Alex, > >

Slider Component

2017-12-12 Thread Carlos Rovira
Hi, I'm planning to start working soon in the theme feature and one thing I was trying to use is the Slider component (both for styling and for use to control styling change in examples in real time) I found some weeks ago that the Slider component was not working as expected, as I move the

Re: Repos and Releases

2017-12-12 Thread Carlos Rovira
Hi Alex, for NPM, I think we should bake it in the package. I think NPM is very important right now to get the most easy and quick install and use for newcomers, and that's what we're pursuing. In the other hand, as Yshay, I'm trying to check what is done, and right now I'm syncing "develop"

Re: NPM for Royale (was Re: Repos and Releases)

2017-12-12 Thread Carlos Rovira
Hi Alex, that seems good to me, as we have this finished I'll be updating the website with final commands Thanks Carlos 2017-12-12 9:25 GMT+01:00 Alex Harui : > I did some reading about NPM this evening. I think that we can use NPM as > a distribution server. It

NPM for Royale (was Re: Repos and Releases)

2017-12-12 Thread Alex Harui
I did some reading about NPM this evening. I think that we can use NPM as a distribution server. It looked like in FlexJS, we still pulled all of the artifacts from the mirrors, but I don't think that is a requirement. Now that the current package bundles all 3 repos into a tarball, that

Re: Repos and Releases

2017-12-12 Thread Alex Harui
On 12/12/17, 12:06 AM, "Yishay Weiss" wrote: >I’m trying to understand what’s going on here, so I’ll ask some naïve >questions: > > > 1. Are royale-compiler and royale-typedefs supposed to be merged into >royale-asjs? The current package doesn't "merge" as much as it

RE: Repos and Releases

2017-12-12 Thread Yishay Weiss
I’m trying to understand what’s going on here, so I’ll ask some naïve questions: 1. Are royale-compiler and royale-typedefs supposed to be merged into royale-asjs? 2. If so, why does running ant all from royale-asjs clone said repos? 3. “Folks should have noticed that the