Re: [royale-asjs] branch develop updated: Fixes #258. But is that a proper fix?

2018-06-05 Thread Harbs
I think the point was that the inline style needed to be removed in certain cases. > On Jun 6, 2018, at 8:52 AM, Yishay Weiss wrote: > > Ok, but why does that get in the way of ‘flex’ and other display/layout > styles? > > > > > From: Alex Harui > Sent:

RE: [royale-asjs] branch develop updated: Fixes #258. But is that a proper fix?

2018-06-05 Thread Yishay Weiss
Ok, but why does that get in the way of ‘flex’ and other display/layout styles? From: Alex Harui Sent: Tuesday, June 5, 2018 7:53:51 PM To: dev@royale.apache.org Subject: Re: [royale-asjs] branch develop updated: Fixes #258. But is that a proper fix? If you

Re: Problem with Debugger in VSCode

2018-06-05 Thread Piotr Zarzycki
Hi Om, I've tried Chrome and have the same issue. I will try as you said with the console. Thanks, Piotr On Wed, Jun 6, 2018, 2:24 AM OmPrakash Muppirala wrote: > I've seen some flakiness with this in the past. Some things that could > help is: after starting the app in the browser, open the

Re: Problem with Debugger in VSCode

2018-06-05 Thread OmPrakash Muppirala
I've seen some flakiness with this in the past. Some things that could help is: after starting the app in the browser, open the developer console, then go back to VS and hit the reload button. That should activate the debugger. Another thing, is try using Chrome as your browser? Hope that

Re: Incorrect descendent CSS output

2018-06-05 Thread Alex Harui
If the namespace prefixes are stored in the selector, then when deciding whether to keepRules, we should check the prefix and if it is null and the default namespace is xhtml, then we can use a fully qualified name in the comparison. HTH, -Alex On 6/5/18, 3:09 PM, "Harbs" wrote: Hmm. I

Re: Incorrect descendent CSS output

2018-06-05 Thread Harbs
Hmm. I wonder if CSSSemanticAnalyzer.resolveSelectors could stuff the selector namespace into the ICSSSelector. It seems to be looping through them anyway. ICSSSeelctor would need a new property for this.) Is CSSSemanticAnalyzer.resolveSelectors called before

Re: Incorrect descendent CSS output

2018-06-05 Thread Harbs
I’m not using menu, and it’s pretty doubtful anyone else is using it yet either, so yeah, it’s probably safe to remove it temporarily. Not sure which other elements might cause problems. Another one which we really should fix is Button (because Button component styling effects every button

Re: Incorrect descendent CSS output

2018-06-05 Thread Alex Harui
The data structure seems to have a slot to hold a namespace. I think there is code somewhere that checks the namespace to avoid the outputting some error, but it may not be storing it. The short term solution may be to remove menu from the list of htmlelements. Does anybody actually use it?

Re: Incorrect descendent CSS output

2018-06-05 Thread Harbs
I think it’s line 189. It checks if the lowercase string matches. Only if that check fails does it enter the logic to figure out where to insert the dot. I’m really not sure how to fix this though… :-( We’d need menu{} to stay menu{} for html elements, but become .menu{} for other component

Re: Incorrect descendent CSS output

2018-06-05 Thread Alex Harui
On 6/5/18, 2:29 PM, "Harbs" wrote: Done. That does seem to fix the problem. Of course, things like .Menu{} (for org.apache.royale.html.Menu) now became Menu{}. Considering that Menu is actually a List which is a div and not a menu element, this will break any styling

Re: Incorrect descendent CSS output

2018-06-05 Thread Harbs
Done. That does seem to fix the problem. Of course, things like .Menu{} (for org.apache.royale.html.Menu) now became Menu{}. Considering that Menu is actually a List which is a div and not a menu element, this will break any styling applied to Menu components… There might be others. Not sure

Re: How to replace Flex Path in Royale

2018-06-05 Thread Piotr Zarzycki
Ok! I will look into it! Thanks! On Tue, Jun 5, 2018, 11:15 PM Harbs wrote: > The link was to our ASDoc. Not sure why it didn’t work. > > We have an svg Path class which is similar to the spark one. > > Drawing command are slightly different, but the same idea. > > Have you looked at it? > > >

Re: How to replace Flex Path in Royale

2018-06-05 Thread Harbs
The link was to our ASDoc. Not sure why it didn’t work. We have an svg Path class which is similar to the spark one. Drawing command are slightly different, but the same idea. Have you looked at it? > On Jun 6, 2018, at 12:03 AM, Piotr Zarzycki wrote: > > Unfortunately link doesn't work for

Re: Incorrect descendent CSS output

2018-06-05 Thread Alex Harui
On 6/5/18, 2:01 PM, "Harbs" wrote: OK. And that will only work for the html namespace? Don’t know for sure. It appears that the namespace is not retained. So I think if you add a component to Jewel call "h4" its type selector may be in all output. We might need to fix that, but

Re: How to replace Flex Path in Royale

2018-06-05 Thread Piotr Zarzycki
Unfortunately link doesn't work for me. Can you post code in paste.apache.org. Thanks, Piotr wt., 5 cze 2018 o 22:45 Harbs napisał(a): > Does this help? > http://royale.apache.org/asdoc/#!org.apache.royale.svg/Path < > http://royale.apache.org/asdoc/#!org.apache.royale.svg/Path> > > > On Jun

Re: Incorrect descendent CSS output

2018-06-05 Thread Harbs
OK. And that will only work for the html namespace? > On Jun 5, 2018, at 11:57 PM, Alex Harui wrote: > > > > On 6/5/18, 12:24 PM, "Harbs" wrote: > >It doesn’t look like the fix helped. > >The following selectors are still being stripped out. I did not understand > how the commit

Re: Incorrect descendent CSS output

2018-06-05 Thread Alex Harui
On 6/5/18, 12:24 PM, "Harbs" wrote: It doesn’t look like the fix helped. The following selectors are still being stripped out. I did not understand how the commit depends on namespaces. We should keep *all* selectors for generic HTML. Please add *all* selectors to

Re: Last class selectors

2018-06-05 Thread Harbs
I think you’re theoretically supposed to be able to use the map.js file to debug minified code too, but I have yet to manage to do that. > On Jun 5, 2018, at 11:46 PM, Carlos Rovira wrote: > > ok, but I thought that for debugging we had all we need in js-debug > version, and js-release, does

Re: Last class selectors

2018-06-05 Thread Carlos Rovira
ok, but I thought that for debugging we had all we need in js-debug version, and js-release, does not had anything. I'm still confusing with it... 2018-06-05 21:09 GMT+02:00 Harbs : > The js.map file is used for debugging source code. > > > so very good right? ;) > > Yup! :-) > > > On Jun 5,

Re: How to replace Flex Path in Royale

2018-06-05 Thread Harbs
Does this help? http://royale.apache.org/asdoc/#!org.apache.royale.svg/Path > On Jun 5, 2018, at 11:08 PM, Piotr Zarzycki wrote: > > Hi Guys, > > I have a component where 90% of it is Path [1] class which is drawing for > me. If I

How to replace Flex Path in Royale

2018-06-05 Thread Piotr Zarzycki
Hi Guys, I have a component where 90% of it is Path [1] class which is drawing for me. If I would like to port that component and draw exactly the same thing in Royale - How approach to that task ? [1] https://flex.apache.org/asdoc/spark/primitives/Path.html Thanks, -- Piotr Zarzycki

Problem with Debugger in VSCode

2018-06-05 Thread Piotr Zarzycki
Hi Guys, Does anyone who is using VSCode has problem with debugging app? I've created Hello World app and tried to debug it but debugger cannot connect with app at all. When I hit Menu "Debug" -> "Start Debugging" - Application has been launched, but debugger seems to be dead, no stop on

Re: Incorrect descendent CSS output

2018-06-05 Thread Harbs
That one snuck in by mistake. It’s not being stripped out… > On Jun 5, 2018, at 10:24 PM, Harbs wrote: > > .tab__content > li .content__wrapper

Re: Incorrect descendent CSS output

2018-06-05 Thread Harbs
It doesn’t look like the fix helped. The following selectors are still being stripped out. I did not understand how the commit depends on namespaces. We should keep *all* selectors for generic HTML. The way that’s currently declared is by using the “http :// www .w3 .org/1999/xhtml” namespace.

Re: Last class selectors

2018-06-05 Thread Carlos Rovira
Hi, for example latest view state example in js-release is: index.html - 2kb .js - 110kb .css - 16kb so 128kb -> gzip - 33kb (and js.map - 293 kb -> this file I assume is not needed right? what's the purpose? If I remove it the app works the same) This is using some layouts, Button,

Re: [royale-asjs] branch develop updated: Fixes #258. But is that a proper fix?

2018-06-05 Thread Carlos Rovira
Hi Alex, 2018-06-05 18:31 GMT+02:00 Alex Harui : > They might be connected. I think the problem we've been discussing is > "how should the DOM be set up for absolute positioning?". in Jewel I'm trying to use only flexbox, and that's part of Jewel. So both, classes and css rules are defined

Re: Last class selectors

2018-06-05 Thread Alex Harui
I just compiled HelloWorld. It is 79K. That's bigger than it used to be. In looking at the js-debug version, there are some .js files from the framework that might be eliminated if we want to take the time. It is nice to know that we can create small apps, although I'm wondering if it is a

Re: Incorrect descendent CSS output

2018-06-05 Thread Alex Harui
Good catch. I pushed a fix that will fix that and hopefully not drag other selectors back in. -Alex On 6/4/18, 9:48 PM, "Harbs" wrote: Thanks. I just observed a new problem. I have not pulled in your changes, so I don’t know if it’s fixed, but it used to work correctly.

Re: [royale-asjs] branch develop updated: Fixes #258. But is that a proper fix?

2018-06-05 Thread Alex Harui
If you look at the DOM generated back then, every tag had "style="position:relative" on it. -Alex On 6/4/18, 11:53 PM, "yishayw" wrote: Alex Harui-2 wrote > UIBase used to set position=relative on all positioners. We took that > away so that the "flex" and other display/layout

Re: [royale-asjs] branch develop updated: Fixes #258. But is that a proper fix?

2018-06-05 Thread Alex Harui
They might be connected. I think the problem we've been discussing is "how should the DOM be set up for absolute positioning?". I don't think there is a perfect solution, but using '.Application *' may be good enough for now. I think you may be describing a different issue which is "how

Re: Last class selectors

2018-06-05 Thread Carlos Rovira
But, you version is only with a part of Royale, if you put a button, will grow, if put a TextInput, will grow and so I think the comparison should be with almost all code involved right? I don't think the rest of frameworks listed there will be showing parts, but the whole library. 2018-06-05

Re: Last class selectors

2018-06-05 Thread Harbs
FYI, application size stacks up very nicely when compared to other frameworks: https://gist.github.com/Restuta/cda69e50a853aa64912d 24KB gzipped *with all application logic* is right in there with the smallest frameworks *sans the actual

Re: Last class selectors

2018-06-05 Thread Carlos Rovira
Congrats Harbs! :) as I just responded to Alex, I hope to give a try to all this soon as I get finish some work I have in my hands right now. Maybe in one or two days from now. Thanks! Carlos 2018-06-04 15:48 GMT+02:00 Harbs : > FYI, I just compiled a bare-bones app, and a Basic app with a

Re: [Discussion] Package change names (was Re: 0.9.3 Release)

2018-06-05 Thread Carlos Rovira
Hi Alex, 2018-06-04 20:15 GMT+02:00 Alex Harui : > Hi Carlos, > > At this point, I think I've addressed all of the compiler issues that > result in unnecessary output or processing. If Harbs is finished with the > framework changes, then I think we can try building Jewel with and without >

Re: [royale-asjs] branch develop updated: Fixes #258. But is that a proper fix?

2018-06-05 Thread Carlos Rovira
Hi, just let you know that the problem seems a bit close to the one I reported about using view states for a new blog example post. If I change View layout from Basic to for example VerticalLayout, that fixes the issue. So in Jewel BasicLayout, that now is based on CSS, I added a loop like in the

Re: [royale-asjs] branch develop updated: Fixes #258. But is that a proper fix?

2018-06-05 Thread yishayw
Alex Harui-2 wrote > UIBase used to set position=relative on all positioners. We took that > away so that the "flex" and other display/layout styles would not have to > deal with the excess clutter and overhead of having set position on so > many elements in the DOM. Can you give an example of

Re: [royale-asjs] branch develop updated: Fixes #258. But is that a proper fix?

2018-06-05 Thread Harbs
Yeah. If you’d need static for some reason, you’d specify that. I think needing static instead of relative would be pretty rare. Here’s an interesting article.[1] I think the fact that static is the default in HTML is more of conceptual decision (less opinion on positioning) than a practical