Build failed in Jenkins: Royale-asjs_MXRoyale #1

2018-06-07 Thread apacheroyaleci
See -- [...truncated 445.16 KB...] [junit] -external-library-path=C:\Program Files

Re: [royale-asjs] branch develop updated: Fixes #258. But is that a proper fix?

2018-06-07 Thread Alex Harui
Well, you changed the test a bit. I guess I should have had child show a border. Where would the border be? And isn't child.offsetParent != child.parentNode? Also shouldn't the test be: var point:Point = PointUtils.localToGlobal(new Point(0, 0),child); Also, I

Re: [royale-asjs] branch develop updated: Fixes #258. But is that a proper fix?

2018-06-07 Thread Harbs
I was waiting to test it. Here’s the results: http://ns.adobe.com/mxml/2009; xmlns:js="library://ns.apache.org/royale/basic" xmlns:ns1="*" applicationComplete="onComplete()" >

Re: [royale-asjs] branch develop updated: Fixes #258. But is that a proper fix?

2018-06-07 Thread Alex Harui
Harbs, I posted a 3 MXML tag example. Will it work like it does in Flex with your changes? If so, how/why? If not, then we need the old code. It is unfortunate that it causes extra reflows, but setting x,y should be rare. And if you can propose a different solution that is PAYG, even

Re: [royale-asjs] branch develop updated: Fixes #258. But is that a proper fix?

2018-06-07 Thread Harbs
> On Jun 8, 2018, at 1:11 AM, Alex Harui wrote: > >In your animation code example, having the offsetParent code in the setter > makes the animation *way* less efficient. There is a an extra forced reflow > for every assignment of the new value. > > I don't understand this point. Can you

Re: [royale-asjs] branch develop updated: Fixes #258. But is that a proper fix?

2018-06-07 Thread Alex Harui
I'm not arguing to keep this code and much as make sure it is right. I did ponder removing x,y from Royale. But I think x,y should exist for backward compatibility. And if it is going to exist, then it should work like it did in Flex. Which means setting x,y to the offset you expect from

Re: Problem with Debugger in VSCode

2018-06-07 Thread Carlos Rovira
Hi Josh, I don't think break points are invalid. I think are recognized correctly. The only point is that debugger is not stopping at breakpoints. If I put a BP on a clickHandler, the method run with out stopping in the line. But the line shows a red dot showing right recognition (if not it will

Re: [royale-asjs] branch develop updated: Fixes #258. But is that a proper fix?

2018-06-07 Thread Harbs
> On Jun 7, 2018, at 10:44 PM, Alex Harui wrote: > > Are you testing with the selector that sets position!=static throughout the > DOM? No. I’m testing with no extra selectors. I dropped that idea. Thanks for pointing out the problems with it. :-) I don’t think it’s usually necessary. The

Re: Type Selector Approximation (was Re: [DISCUSS] Explanation of the changes)

2018-06-07 Thread Alex Harui
Alina is nearing the point of getting everything to compile. Now it is time to get things to "run". And later, we will try to get things to "run and look good". I've been distracted by other things, but I hope get back to getting components to "run". Meaning, they show something on the

Re: [royale-asjs] branch develop updated: Fixes #258. But is that a proper fix?

2018-06-07 Thread Alex Harui
Are you testing with the selector that sets position!=static throughout the DOM? If not, then I think that the "get what you set" rule has to apply and I would think that code is necessary. That was also a rule in Flex. The following was always true: Var value:int = 10; someWidget.x = value;

Re: [royale-asjs] branch develop updated: Fixes #258. But is that a proper fix?

2018-06-07 Thread Harbs
> I hope the current implementation tries to mimic Flash/Flex for backward > compatibility reasons. Here’s the kicker: I have not yet found a *SINGLE* case yet where this attempt to mimic the Flash/Flex behavior is necessary to *GET THE SAME RESULT*. Both my own app and the examples that

Re: [royale-asjs] branch develop updated: Fixes #258. But is that a proper fix?

2018-06-07 Thread Harbs
> I don’t think I was clear enough That still was not clear enough. The problem was that the value being applied to the style is *different* than the value specified. So, the code was writing a y value of (something like) 15, but what’s actually written is the (observed) offset of 500 plus 15

Re: [royale-asjs] branch develop updated: Fixes #258. But is that a proper fix?

2018-06-07 Thread Alex Harui
I'm not sure I'm understanding. There is no x,y in HTML/JS, so we can make it mean anything we want it to. I hope the current implementation tries to mimic Flash/Flex for backward compatibility reasons. We could agree to change that if we really want to, but I think backward-compatibility is

Re: [royale-asjs] branch develop updated: Fixes #258. But is that a proper fix?

2018-06-07 Thread Harbs
> Who needs to set x,y and why? Anyone who wants to read or set a position of an element. That’s usually going to be inside a container which has a Basic or Relative layout. Generally, the element shouldn’t need to care whether that’s relative to the parent or grandparent. A common case is

Re: [royale-asjs] branch develop updated: Fixes #258. But is that a proper fix?

2018-06-07 Thread Harbs
I don’t think I was clear enough. The original issue that started this thread is actually caused by the code which sets the y value based on the parentOffset. If the parentOffset is ignored, the issue goes away and we don’t have to care about layout lifecycles. For the few cases where we need

Re: [royale-asjs] branch develop updated: Fixes #258. But is that a proper fix?

2018-06-07 Thread Alex Harui
IMO, we first need to address the fundamental problem. Who needs to set x,y and why? Otherwise you are trying to solve a problem "just-in-case". Effects like MoveEffect will set x,y. For sure, absolute positioning layouts will but then the layout can set properties on the parent. PopUps

Re: Problem with Debugger in VSCode

2018-06-07 Thread Josh Tynjala
It is possible that a recent change made to the compiler has resulted in invalid source map files. If they're not pointing to the correct locations in any of the relevant files (.as, .mxml, or .js), that could explain why the breakpoints aren't working. However, I wrote a number of automated

Re: [royale-asjs] branch develop updated: Fixes #258. But is that a proper fix?

2018-06-07 Thread Harbs
> So, if we don't force position!=static throughout the DOM, then you have to > have code that compensates for that difference. I don’t think I agree. Right now we’re modifying the x and y values because we *might* care about the offsetParent. That’s not PAYG. In fact, the set values will be

Re: New blog example post "Using View States to show or hide content"

2018-06-07 Thread Alex Harui
Infra already knows. On 6/7/18, 10:29 AM, "carlos.rov...@gmail.com on behalf of Carlos Rovira" wrote: Hi Website is gving many problems this days, can someone fill a infra ticket or talk with someone from infra so we can see what's happening we have people in social networks

Re: Rounting lib for Royale

2018-06-07 Thread Carlos Rovira
This can be the same problem that we're seeing in the website working intermittently 2018-06-07 11:43 GMT+02:00 Piotr Zarzycki : > That link posted by Harbs was to Path class and now it's working for me -> > http://royale.apache.org/asdoc/#!org.apache.royale.svg/Path > > Maybe it was some

Re: New blog example post "Using View States to show or hide content"

2018-06-07 Thread Carlos Rovira
Hi Website is gving many problems this days, can someone fill a infra ticket or talk with someone from infra so we can see what's happening we have people in social networks reporting issues. Sometimes work, others no... thanks! 2018-06-07 16:24 GMT+02:00 Harbs : > No. It works for me. > > > On

Re: [royale-asjs] branch develop updated: Fixes #258. But is that a proper fix?

2018-06-07 Thread Alex Harui
IIRC, the parentNode is always the parent of the child if you examine the DOM. offsetParent is the parent or grandparent, etc, that has position != static, and left/top/right/bottom styles are always relative to offsetParent. So, if we don't force position!=static throughout the DOM, then you

Re: New blog example post "Using View States to show or hide content"

2018-06-07 Thread Harbs
No. It works for me. > On Jun 7, 2018, at 5:03 PM, OmPrakash Muppirala wrote: > > Hey, I am seeing a 404 error now. Did the url change? > > Thanks, > Om > > On Thu, Jun 7, 2018, 2:31 AM Carlos Rovira wrote: > >> Great Harbs! As many of us making changes on website, we can move Royale >>

Re: New blog example post "Using View States to show or hide content"

2018-06-07 Thread OmPrakash Muppirala
Hey, I am seeing a 404 error now. Did the url change? Thanks, Om On Thu, Jun 7, 2018, 2:31 AM Carlos Rovira wrote: > Great Harbs! As many of us making changes on website, we can move Royale > out there better! :) > > Thanks! > > > 2018-06-07 11:21 GMT+02:00 Harbs : > > > I made the changes

Re: [royale-asjs] branch develop updated: Fixes #258. But is that a proper fix?

2018-06-07 Thread Harbs
I created a “simplify-position” feature branch which does away with the offsetParent logic in UIBase. It does not change anything regarding position: static. I have tested with my own app and a number of the examples. I haven’t found any problems yet. Input welcome… Harbs > On Jun 7, 2018,

Re: Rounting lib for Royale

2018-06-07 Thread Piotr Zarzycki
That link posted by Harbs was to Path class and now it's working for me -> http://royale.apache.org/asdoc/#!org.apache.royale.svg/Path Maybe it was some problem not related to our code totally. Piotr czw., 7 cze 2018 o 11:40 Carlos Rovira napisał(a): > Hi, > > just let you know that View

Rounting lib for Royale

2018-06-07 Thread Carlos Rovira
Hi, just let you know that View States example gives two comments, one in website and other in facebook page that request to complement with Routing example. I think it's a logic request, don't know if is the same person, or two different, but I think he wants to see a view state change that

Re: New blog example post "Using View States to show or hide content"

2018-06-07 Thread Carlos Rovira
Great Harbs! As many of us making changes on website, we can move Royale out there better! :) Thanks! 2018-06-07 11:21 GMT+02:00 Harbs : > I made the changes and they are live. > > Thanks for the directions. :-) > > Harbs > > > On Jun 7, 2018, at 12:14 PM, Carlos Rovira > wrote: > > > > Hi

Re: [royale-asjs] branch develop updated: Fixes #258. But is that a proper fix?

2018-06-07 Thread Harbs
> So, IMO, it would be nice to do a similar investigation of controlsPallette. You are right. Removing the y value has no effect. I am wondering that maybe it makes sense to apply relative to the Container CSS selector and possibly a few others. I’m trying to understand the specific cases

Re: New blog example post "Using View States to show or hide content"

2018-06-07 Thread Carlos Rovira
Hi Harbs just let you know that maybe you are having a hard time seeing the changes reflected in public site. I found this issue in my last change, and seems to be something related to apache infrastructure working slow. Until now changes use to be ready in seconds, this days seems to behave

RE: [royale-asjs] branch develop updated: Fixes #258. But is that a proper fix?

2018-06-07 Thread Yishay Weiss
For what it’s worth, I removed x="{filterGrip.width}" and it works the same. So it’s probably just legacy code. From: Harbs Sent: Wednesday, June 6, 2018 9:25 PM To: dev@royale.apache.org Subject: Re: [royale-asjs] branch develop

Re: Problem with Debugger in VSCode

2018-06-07 Thread Piotr Zarzycki
That's good. czw., 7 cze 2018 o 10:33 Carlos Rovira napisał(a): > Hi Piotr, > > nobody said to change nothing. More over, we're gitignoring .vscode/** > files > > 2018-06-07 10:27 GMT+02:00 Piotr Zarzycki : > > > Carlos, > > > > Config is ok for people who are using building straight through

Re: Problem with Debugger in VSCode

2018-06-07 Thread Piotr Zarzycki
Alex, That sounds like a good plan, but I doubt if it will gives us stop on breakpoints in MXML/AS3 code. I just tested debugger statement according to Josh's link and I got stop but straight in the JS code. If having debugger statement make that thing working, why not merging and having that

Re: Problem with Debugger in VSCode

2018-06-07 Thread Carlos Rovira
Hi Piotr, nobody said to change nothing. More over, we're gitignoring .vscode/** files 2018-06-07 10:27 GMT+02:00 Piotr Zarzycki : > Carlos, > > Config is ok for people who are using building straight through the SDK not > through the Maven as you are. If we have in the examples "source-map":

Re: Problem with Debugger in VSCode

2018-06-07 Thread Piotr Zarzycki
Hi Josh, Unfortunately the debugger trick didn't help. It stopped debugger, but only in index.html not in AS3 code. However If having that debugger should help me debug just JS code that should be always something. Thanks, Piotr śr., 6 cze 2018 o 19:18 Josh Tynjala napisał(a): > You might be

Re: Problem with Debugger in VSCode

2018-06-07 Thread Piotr Zarzycki
Carlos, Config is ok for people who are using building straight through the SDK not through the Maven as you are. If we have in the examples "source-map": true let it stay as is. Piotr czw., 7 cze 2018 o 10:21 Carlos Rovira napisał(a): > Hi, > > something I saw from my old config launch.json

Re: Problem with Debugger in VSCode

2018-06-07 Thread Carlos Rovira
Hi, something I saw from my old config launch.json file and the instructions in Josh website is that we don't need in that file "sourceMaps": true Since I'm using maven always, I think for me the config is: -source-map=true This make the VSCode break points turn from outlined to red, and I

Re: Type Selector Approximation (was Re: [DISCUSS] Explanation of the changes)

2018-06-07 Thread Harbs
> IMO, if we all pitched in on emulation > Perfection can be the enemy of success. Sorry to be so selfish, but I am > just trying to keep my job. Fair enough. If I were to pitch in with the emulation, what would you recommend I work on? Harbs > On Jun 6, 2018, at 9:24 PM, Alex Harui

Re: New blog example post "Using View States to show or hide content"

2018-06-07 Thread Carlos Rovira
Hi Harbs, steps to make this: 1.- log into royale.codeoscopic.com (since is a WP site go to /wp-admin and insert your credentials) 2.- go to *settings -> Codecolorer *(is the plugin that create the syntax coloring for MXML and AS3 code) 3.- change the setting for height to what you prefer, right

Re: New blog example post "Using View States to show or hide content"

2018-06-07 Thread Harbs
FWIW, I tried to remove that from the page, but it had no effect. I don’t know why. I also tried to see how it was constructed in WordPress and I couldn’t see the code block at all. What was I missing there? Harbs > On Jun 7, 2018, at 10:50 AM, Carlos Rovira wrote: > > Hi Om, > > thanks!,

Re: New blog example post "Using View States to show or hide content"

2018-06-07 Thread Carlos Rovira
You're right Vincent! :) I think we have already a repo for that, and some work was done a year or so ago, but was left. But the project is already setup. We need volunteers for that. So anyone wanting to make this happen can join this movement! :) Thanks 2018-06-07 1:55 GMT+02:00 Vincent Sotto

Re: New blog example post "Using View States to show or hide content"

2018-06-07 Thread Carlos Rovira
Hi Om, thanks!, ok, I'll try to change height of code view for the current examples in the next update :) 2018-06-06 20:52 GMT+02:00 OmPrakash Muppirala : > Thanks for this, Carlos! > > The snippet only shows 15 lines and then we need to scroll to see the > rest. Can we make it show all the