Jenkins build is back to normal : royale-asjs_MXTests #153

See

Build failed in Jenkins: royale-asjs_MXTests #152

See Changes: [aharui] ADG column sorting [aharui] column lines in ADG -- [...truncated 1.17 MB...] [mxmlc] scanning for overrides:

Re: Apache Royale Maven improvements, fixes and reproducible builds PR by Chris Dutz

Well, you can always merge the PR and see if anything blows up and revert if it does. The only things I saw so far will affect the release steps but probably not the nightly builds. -Alex On 11/15/19, 12:21 PM, "Carlos Rovira" wrote: Hi Alex, El vie., 15 nov. 2019 a las 20:48,

Re: Apache Royale Maven improvements, fixes and reproducible builds PR by Chris Dutz

Hi Alex, El vie., 15 nov. 2019 a las 20:48, Alex Harui () escribió: > Hi Carlos, > > If/When you decide to merge these PRs, please make sure you have reserved > time to fix anything it breaks in CI. > Let me know if the following plan would fit your expectations: 1) If nobody find any problem

Re: Apache Royale Maven improvements, fixes and reproducible builds PR by Chris Dutz

Hi Carlos, If/When you decide to merge these PRs, please make sure you have reserved time to fix anything it breaks in CI. I thought we already had made the changes to build with Maven without Flash. I have some missing DG features to implement for Alina before I can find time to review the

Re: Apache Royale Maven improvements, fixes and reproducible builds PR by Chris Dutz

Hi Alex, my plan was to be a RM at some point, so maybe this is a good time to do it. I think we all agree that improvements and fixes will need other ones in the CI release steps. Can be improvements without touching that part too I think all the improvements are worth it the changes to CI

Re: Apache Royale Maven improvements, fixes and reproducible builds PR by Chris Dutz

The second commit I looked at is also huge so I will not be able to review it or any others right now. The things I remember wondering about in the first commit I reviewed is: 1) changing of the timestamp options that ensured SWFs are reproducible 2) removal of JGit which is needed by the CI

Re: Apache Royale Maven improvements, fixes and reproducible builds PR by Chris Dutz

I've only reviewed one commit in one PR so far, but I think it will break the CI release steps. Also, IMO, 0.9.6 has reproducible Maven artifacts. Improvements and fixes are welcome. Who is going to verify that the CI release steps continue to work after these changes? -Alex On 11/15/19,

Re: Apache Royale Maven improvements, fixes and reproducible builds PR by Chris Dutz

To all, about reproducible builds: possibly the most interesting thing of all this changes might be that now we should allow releasing Royale via Maven with the ability of creating reproducible builds. Ideally releasing a part of Royale is just a 2-3 step process: - royale-compiler:

Re: Apache Royale Maven improvements, fixes and reproducible builds PR by Chris Dutz

Great you like it Harbs! :) I forgot to mention that another effort in parallel is to release v1.0.0 of "flex-sdk-converter-maven-extension" (located in Apache Flex utilities repo), so we can remove the need to add "-s settings-template.xml" to each line, what will improve event more the build

Re: Apache Royale Maven improvements, fixes and reproducible builds PR by Chris Dutz

If it all works, sounds great to me! :-) (I’m not going to be able to test until sometime next week, but don’t wait for me.) Thanks to Chris for working on this! Harbs > On Nov 15, 2019, at 2:45 PM, Carlos Rovira wrote: > > Hi, > > this days Chris Dutz has had the deference and detail of

Apache Royale Maven improvements, fixes and reproducible builds PR by Chris Dutz

Hi, this days Chris Dutz has had the deference and detail of working on improving Apache Royale Maven build by simplifying the scripts so we all have less headaches with all this stuff that he knows and master so well. I want to give a big thanks to Chris for investing his time in working on this

Re: Tabbar with scroll in TourDeJewel

Hi Piotr, The following is a guess, so not tested and could not work. In this call: setTimeout(refreshNavigationButtonVisibility, 100); have you tried to increase the 100 to 400 and see what happens? IICR, time outs depends on any browser, so maybe you are testing with a browser that needs more