Re: Slider Component

2018-01-10 Thread Peter Ent
I compared Justin's suggested change with what was already in the repo and changed the code to remove an unnecessary offset. To me, it now works correctly. ‹peter On 1/9/18, 7:14 PM, "Justin Mclean" wrote: >Hi, > >> I've tried the slider with Safari, Chrome, and

Re: Slider Component

2018-01-09 Thread Peter Ent
Hi I've pushed a change to the slider mouse controllers that should make it better. Now clicking on the thumb will not move it. If you drag the thumb it should reposition centered under the mouse cursor. But doing it quickly (ie, normally) it tracks a little off. I think that's because the events

Re: Slider Component

2018-01-09 Thread Peter Ent
Thanks for the video! That was great. I do see what you are describing. I'll look into it. —peter On 1/9/18, 1:49 PM, "carlos.rov...@gmail.com on behalf of Carlos Rovira" wrote: >Hi Peter, > >I think the best way to show you the

Re: Slider Component

2018-01-09 Thread Carlos Rovira
Hi Peter, I think the best way to show you the problems is with a video. I uploaded a hidden video here: https://youtu.be/m1SnCyHeUzc Please, let me know when you see it, I could remove it in some days or if you want left it more time I'm on Mac/Safari, I think here you can see some problems

Re: Slider Component

2018-01-09 Thread Peter Ent
I've tried the slider with Safari, Chrome, and Firefox. I guess I am not understanding the problem. When I move the mouse into the slider thumb control, press the mouse button down and drag, the thumb follows the mouse immediately. It may snap to step positions along the track if the range isn't

Re: Slider Component

2018-01-07 Thread Carlos Rovira
Hi Peter I could at last try the new slider and works far way better. Thanks for the great work!. I notice the problems raised by Justin. I think one of the problem is that thumb is not considering the mouse exact point of interaction and that cause the thumb "moves" or adapts to the mouse. I

Re: Slider Component

2017-12-14 Thread Justin Mclean
HI, Look like the new slider code has introduced a few new issues and one in particular in easily discoverable by users [1]. Can someone take a look at this PR please. [2] Thanks, Justin 1. https://github.com/apache/royale-asjs/issues/102 2. https://github.com/apache/royale-asjs/pull/104

Re: Slider Component

2017-12-13 Thread OmPrakash Muppirala
On Wed, Dec 13, 2017 at 11:00 AM, Peter Ent wrote: > I've pushed changes to the Slider component and resolved (I hope) most of > the issues listed below by Justin. Only one, having to do with arrow keys, > should be resolved or at least improved. The arrow keys should be

Re: Slider Component

2017-12-12 Thread Justin Mclean
HI, A while back I raised several issues with the slider component, if you happen if fix any of these issues please close them. [1][2][3][4][5] I note for instance the slider still incorrectly gives the value NaN when you click on the track. The issue arises in this line in the

Re: Slider Component

2017-12-12 Thread Peter Ent
If you set the slider's width and height explicitly, the layout should work fine. Found two issues: The SliderMouseController is oriented toward a horizontal slider. I will create a HorizontalSliderMouseController and a VerticalSLiderMouseController. Second, on the HTML/JS side, the slider

Re: Slider Component

2017-12-12 Thread Carlos Rovira
Thanks Peter, This is one of the components I want to stylize, so if you upgrade it, I could as well work on the visuals ( and use it for the demo controls too) Carlos 2017-12-12 16:35 GMT+01:00 Peter Ent : > I just saw this email. I'll be happy to look at it. I think

Re: Slider Component

2017-12-12 Thread Peter Ent
I just saw this email. I'll be happy to look at it. I think it was made early in FlexJS. I imagine it could be crude. I'm also sure it is horizontal. I'll keep vertical in mind - maybe it needs different layouts to handle that. ‹peter On 12/12/17, 5:00 AM, "carlos.rov...@gmail.com on behalf of